Bug 1459312 - Make AsyncPanZoomController::GetCurrentAsyncViewportTransform() private. r=kats
authorBotond Ballo <botond@mozilla.com>
Sat, 02 Feb 2019 23:53:19 +0000
changeset 456584 11ac6c2ac639b725497a5f2541abe8e86e34427b
parent 456583 4d6a4c43775b78788ef78aba2b9cab7f7c043d41
child 456585 016c3e822444aa9aa678a57cfc3c4a646859a091
push id77350
push userbballo@mozilla.com
push dateSat, 02 Feb 2019 23:55:46 +0000
treeherderautoland@a03c30492ed7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskats
bugs1459312
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1459312 - Make AsyncPanZoomController::GetCurrentAsyncViewportTransform() private. r=kats It is an implementation detail of GetCurrentAsyncTransformForFixedAdjustment(). Differential Revision: https://phabricator.services.mozilla.com/D17719
gfx/layers/apz/src/AsyncPanZoomController.h
--- a/gfx/layers/apz/src/AsyncPanZoomController.h
+++ b/gfx/layers/apz/src/AsyncPanZoomController.h
@@ -1086,26 +1086,16 @@ class AsyncPanZoomController {
   /**
    * Return a visual effect that reflects this apzc's
    * overscrolled state, if any.
    */
   AsyncTransformComponentMatrix GetOverscrollTransform(
       AsyncTransformConsumer aMode) const;
 
   /**
-   * Returns the incremental transformation corresponding to the async
-   * panning/zooming of the layout viewport (unlike GetCurrentAsyncTransform,
-   * which deals with async movement of the visual viewport). That is, when
-   * this transform is multiplied with the layer's existing transform, it will
-   * make the layer appear with the desired pan/zoom amount.
-   */
-  AsyncTransform GetCurrentAsyncViewportTransform(
-      AsyncTransformConsumer aMode) const;
-
-  /**
    * Returns the incremental transformation corresponding to the async pan/zoom
    * in progress. That is, when this transform is multiplied with the layer's
    * existing transform, it will make the layer appear with the desired pan/zoom
    * amount.
    * The transform can have both scroll and zoom components; the caller can
    * request just one or the other, or both, via the |aComponents| parameter.
    */
   AsyncTransform GetCurrentAsyncTransform(
@@ -1144,16 +1134,26 @@ class AsyncPanZoomController {
    * sampled value.
    *
    * (This is only relevant when |gfxPrefs::APZFrameDelayEnabled() == true|.
    * Otherwise, GetCurrentAsyncTransform() always reflects what's stored in
    * |Metrics()| immediately, without any delay.)
    */
   bool SampleCompositedAsyncTransform();
 
+  /**
+   * Returns the incremental transformation corresponding to the async
+   * panning/zooming of the layout viewport (unlike GetCurrentAsyncTransform,
+   * which deals with async movement of the visual viewport). That is, when
+   * this transform is multiplied with the layer's existing transform, it will
+   * make the layer appear with the desired pan/zoom amount.
+   */
+  AsyncTransform GetCurrentAsyncViewportTransform(
+      AsyncTransformConsumer aMode) const;
+
   /*
    * Helper functions to query the async layout viewport, scroll offset, and
    * zoom either directly from |Metrics()|, or from cached variables that
    * store the required value from the last time it was sampled by calling
    * SampleCompositedAsyncTransform(), depending on who is asking.
    */
   CSSRect GetEffectiveLayoutViewport(AsyncTransformConsumer aMode) const;
   CSSPoint GetEffectiveScrollOffset(AsyncTransformConsumer aMode) const;