Bug 1564616 - Remove redundant '.alternate-button' class. r=sfoster
authorTim Nguyen <ntim.bugs@gmail.com>
Wed, 10 Jul 2019 18:19:35 +0000
changeset 482267 118cd41584b5f4a66eda0d4bf491b749f2e5ca71
parent 482266 4d8a44b52bb6773ba7bf346efe44afc3056ef4d5
child 482268 278205a39cd87fae34b84827c4188147d8ee2b1e
push id89662
push userntim.bugs@gmail.com
push dateWed, 10 Jul 2019 19:57:11 +0000
treeherderautoland@118cd41584b5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssfoster
bugs1564616
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1564616 - Remove redundant '.alternate-button' class. r=sfoster Differential Revision: https://phabricator.services.mozilla.com/D37501
browser/components/aboutlogins/content/aboutLogins.html
browser/components/aboutlogins/content/common.css
--- a/browser/components/aboutlogins/content/aboutLogins.html
+++ b/browser/components/aboutlogins/content/aboutLogins.html
@@ -83,18 +83,18 @@
       <link rel="stylesheet" href="chrome://global/skin/in-content/common.css">
       <link rel="stylesheet" href="chrome://browser/content/aboutlogins/common.css">
       <link rel="stylesheet" href="chrome://browser/content/aboutlogins/components/login-item.css">
       <div class="header">
         <h2 class="title">
           <span class="login-item-title"></span>
           <span class="new-login-title" data-l10n-id="login-item-new-login-title"></span>
         </h2>
-        <button class="edit-button alternate-button" data-l10n-id="login-item-edit-button"></button>
-        <button class="delete-button alternate-button" data-l10n-id="login-item-delete-button"></button>
+        <button class="edit-button ghost-button" data-l10n-id="login-item-edit-button"></button>
+        <button class="delete-button ghost-button" data-l10n-id="login-item-delete-button"></button>
       </div>
       <form>
         <div class="detail-row">
           <label class="detail-cell">
             <span class="origin-label field-label" data-l10n-id="login-item-origin-label"></span>
             <input type="url" name="origin" class="origin-input" required data-l10n-id="login-item-origin"/>
           </label>
           <button class="open-site-button" data-l10n-id="login-item-open-site-button"></button>
@@ -138,18 +138,18 @@
       <link rel="stylesheet" href="chrome://browser/content/aboutlogins/components/login-filter.css">
       <input data-l10n-id="login-filter" class="filter" type="text"/>
     </template>
 
     <template id="menu-button-template">
       <link rel="stylesheet" href="chrome://global/skin/in-content/common.css">
       <link rel="stylesheet" href="chrome://browser/content/aboutlogins/common.css">
       <link rel="stylesheet" href="chrome://browser/content/aboutlogins/components/menu-button.css">
-      <button class="menu-button alternate-button" data-l10n-id="menu"></button>
+      <button class="menu-button ghost-button" data-l10n-id="menu"></button>
       <ul class="menu" role="menu" hidden>
-        <button role="menuitem" class="menuitem-button menuitem-import alternate-button" hidden data-supported-platforms="Win32" data-event-name="AboutLoginsImport" data-l10n-id="menu-menuitem-import"></button>
-        <button role="menuitem" class="menuitem-button menuitem-preferences alternate-button" data-event-name="AboutLoginsOpenPreferences" data-l10n-id="menu-menuitem-preferences"></button>
-        <button role="menuitem" class="menuitem-button menuitem-feedback alternate-button" data-event-name="AboutLoginsOpenFeedback" data-l10n-id="menu-menuitem-feedback"></button>
-        <button role="menuitem" class="menuitem-button menuitem-faq alternate-button" data-event-name="AboutLoginsOpenFAQ" data-l10n-id="menu-menuitem-faq"></button>
+        <button role="menuitem" class="menuitem-button menuitem-import ghost-button" hidden data-supported-platforms="Win32" data-event-name="AboutLoginsImport" data-l10n-id="menu-menuitem-import"></button>
+        <button role="menuitem" class="menuitem-button menuitem-preferences ghost-button" data-event-name="AboutLoginsOpenPreferences" data-l10n-id="menu-menuitem-preferences"></button>
+        <button role="menuitem" class="menuitem-button menuitem-feedback ghost-button" data-event-name="AboutLoginsOpenFeedback" data-l10n-id="menu-menuitem-feedback"></button>
+        <button role="menuitem" class="menuitem-button menuitem-faq ghost-button" data-event-name="AboutLoginsOpenFAQ" data-l10n-id="menu-menuitem-faq"></button>
       </ul>
     </template>
   </body>
 </html>
--- a/browser/components/aboutlogins/content/common.css
+++ b/browser/components/aboutlogins/content/common.css
@@ -2,20 +2,8 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 /* [hidden] isn't applying to elements in Shadow DOM. */
 :host([hidden]),
 [hidden] {
   display: none !important;
 }
-
-.alternate-button {
-  background-color: transparent;
-}
-
-.alternate-button:hover {
-  background-color: var(--in-content-button-background-hover);
-}
-
-.alternate-button:hover:active {
-  background-color: var(--in-content-button-background-active);
-}