Backed out 1 changesets (bug 1405252) for failing devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_filters.js r=backout on a CLOSED TREE
authorAndreea Pavel <apavel@mozilla.com>
Wed, 22 Nov 2017 19:07:02 +0200
changeset 393084 11865acd385763e5c7c4c87d6f4e7785a0f28269
parent 393083 d9bbfb2a7e42820b4866d6b3a0e64d11979cc198
child 393085 e1667b83dc102e673ddcc0a58ac64df28901b033
push id55842
push userapavel@mozilla.com
push dateWed, 22 Nov 2017 17:07:20 +0000
treeherderautoland@11865acd3857 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1405252
milestone59.0a1
backs outaa2c49a11df2fceba71e44082e2663467d11deb2
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out 1 changesets (bug 1405252) for failing devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_filters.js r=backout on a CLOSED TREE Backed out changeset aa2c49a11df2 (bug 1405252)
devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser.ini
@@ -236,16 +236,17 @@ skip-if = true #	Bug 1406038
 [browser_webconsole_closing_after_completion.js]
 [browser_webconsole_closure_inspection.js]
 skip-if = true #	Bug 1405250
 [browser_webconsole_console_api_iframe.js]
 [browser_webconsole_console_dir.js]
 [browser_webconsole_console_dir_uninspectable.js]
 [browser_webconsole_console_group.js]
 [browser_webconsole_console_logging_workers_api.js]
+skip-if = true # Bug 1405252
 [browser_webconsole_console_table.js]
 [browser_webconsole_context_menu_copy_entire_message.js]
 subsuite = clipboard
 skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_webconsole_context_menu_copy_link_location.js]
 subsuite = clipboard
 skip-if = (os == 'linux' && bits == 32 && debug) # bug 1328915, disable linux32 debug devtools for timeouts
 [browser_webconsole_context_menu_copy_object.js]
--- a/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_console_logging_workers_api.js
@@ -4,19 +4,36 @@
  * http://creativecommons.org/publicdomain/zero/1.0/ */
 
 // Tests that the basic console.log()-style APIs and filtering work for
 // sharedWorkers
 
 "use strict";
 
 const TEST_URI = "http://example.com/browser/devtools/client/webconsole/" +
-                 "new-console-output/test/mochitest/test-console-workers.html";
+                 "test/test-console-workers.html";
+
+add_task(function* () {
+  yield loadTab(TEST_URI);
+
+  let hud = yield openConsole();
+
+  yield waitForMessages({
+    webconsole: hud,
+    messages: [{
+      text: "foo-bar-shared-worker"
+    }],
+  });
 
-add_task(async function () {
-  const hud = await openNewTabAndConsole(TEST_URI);
-  const message = await waitFor(() => findMessage(hud, "foo-bar-shared-worker"));
-  is(
-    message.querySelector(".message-body").textContent,
-    `foo-bar-shared-worker Object { foo: "bar" }`,
-    "log from SharedWorker is displayed as expected"
-  );
+  hud.setFilterState("sharedworkers", false);
+
+  is(hud.outputNode.querySelectorAll(".filtered-by-type").length, 1,
+     "1 message hidden for sharedworkers (logging turned off)");
+
+  hud.setFilterState("sharedworkers", true);
+
+  is(hud.outputNode.querySelectorAll(".filtered-by-type").length, 0,
+     "1 message shown for sharedworkers (logging turned on)");
+
+  hud.setFilterState("sharedworkers", false);
+
+  hud.jsterm.clearOutput(true);
 });
--- a/devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
+++ b/devtools/client/webconsole/new-console-output/test/mochitest/test-console-workers.html
@@ -2,14 +2,12 @@
      http://creativecommons.org/publicdomain/zero/1.0/ -->
 <!DOCTYPE HTML>
 <html dir="ltr" xml:lang="en-US" lang="en-US"><head>
     <meta charset="utf-8">
     <title>Console test</title>
   </head>
   <body>
     <script type="text/javascript">
-      new SharedWorker(`data:application/javascript,
-        console.log("foo-bar-shared-worker", {foo: "bar"});
-      `);
+var sw = new SharedWorker('data:application/javascript,console.log("foo-bar-shared-worker");');
     </script>
   </body>
 </html>