Bug 1777367 - Put YouTube's PiP toggle visibility threshold back to 0.7. r=kpatenio
authorMike Conley <mconley@mozilla.com>
Thu, 30 Jun 2022 15:19:15 +0000
changeset 622729 10b948f553640201f0c87b2a9820192ba8acdb14
parent 622728 006e83688e604417ae25ef552a859d2a1d45c7b9
child 622730 df04b052c20c6fce2eb26d6ad9de6811be2bfc6b
push id165536
push usermconley@mozilla.com
push dateThu, 30 Jun 2022 16:27:15 +0000
treeherderautoland@10b948f55364 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskpatenio
bugs1777367
milestone104.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1777367 - Put YouTube's PiP toggle visibility threshold back to 0.7. r=kpatenio Differential Revision: https://phabricator.services.mozilla.com/D150702
browser/extensions/pictureinpicture/data/picture_in_picture_overrides.js
--- a/browser/extensions/pictureinpicture/data/picture_in_picture_overrides.js
+++ b/browser/extensions/pictureinpicture/data/picture_in_picture_overrides.js
@@ -141,18 +141,23 @@ let AVAILABLE_PIP_OVERRIDES;
       "https://*.twitch.a2z.com/*": { policy: TOGGLE_POLICIES.ONE_QUARTER },
     },
 
     udemy: {
       "https://*.udemy.com/*": { policy: TOGGLE_POLICIES.ONE_QUARTER },
     },
 
     youtube: {
+      /**
+       * The threshold of 0.7 is so that users can click on the "Skip Ads"
+       * button on the YouTube site player without accidentally triggering
+       * PiP.
+       */
       "https://*.youtube.com/*": {
-        visibilityThreshold: 0.9,
+        visibilityThreshold: 0.7,
         videoWrapperScriptPath: "video-wrappers/youtube.js",
       },
       "https://*.youtube-nocookie.com/*": {
         visibilityThreshold: 0.9,
         videoWrapperScriptPath: "video-wrappers/youtube.js",
       },
     },