Backed out changeset 3173e1090b3c (bug 1302702)
authorSebastian Hengst <archaeopteryx@coole-files.de>
Wed, 17 May 2017 20:01:13 +0200
changeset 358797 0d25af257e6a42a3fb6fb3c3fcc6ab7ccc271fc7
parent 358796 43bc4f4903cb3b52b6107bd3636b50aabad7d7b5
child 358798 d728f32c4449de2b3d61ecae275d5c43087e3952
push id42853
push userarchaeopteryx@coole-files.de
push dateWed, 17 May 2017 18:02:46 +0000
treeherderautoland@8c2e9b2ee8eb [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1302702
milestone55.0a1
backs out3173e1090b3ca80f9368a8dfdc4831505be1ec0c
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 3173e1090b3c (bug 1302702)
devtools/server/actors/inspector.js
--- a/devtools/server/actors/inspector.js
+++ b/devtools/server/actors/inspector.js
@@ -2441,18 +2441,16 @@ var WalkerActor = protocol.ActorClassWit
     }
     if (isTopLevel) {
       // If we initialize the inspector while the document is loading,
       // we may already have a root document set in the constructor.
       if (this.rootDoc && !Cu.isDeadWrapper(this.rootDoc) &&
           this.rootDoc.defaultView) {
         this.onFrameUnload({ window: this.rootDoc.defaultView });
       }
-      // Update all DOM objects references to target the new document.
-      this.rootWin = window;
       this.rootDoc = window.document;
       this.rootNode = this.document();
       this.queueMutation({
         type: "newRoot",
         target: this.rootNode.form()
       });
       return;
     }
@@ -2984,17 +2982,17 @@ function isNodeDead(node) {
  *        Either SKIP_TO_PARENT or SKIP_TO_SIBLING. If the provided node is not compatible
  *        with the filter function for this walker, try to find a compatible one either
  *        in the parents or in the siblings of the node.
  */
 function DocumentWalker(node, rootWin,
     whatToShow = nodeFilterConstants.SHOW_ALL,
     filter = standardTreeWalkerFilter,
     skipTo = SKIP_TO_PARENT) {
-  if (Cu.isDeadWrapper(rootWin) || !rootWin.location) {
+  if (!rootWin.location) {
     throw new Error("Got an invalid root window in DocumentWalker");
   }
 
   this.walker = Cc["@mozilla.org/inspector/deep-tree-walker;1"]
     .createInstance(Ci.inIDeepTreeWalker);
   this.walker.showAnonymousContent = true;
   this.walker.showSubDocuments = true;
   this.walker.showDocumentsAsNodes = true;