Bug 1708481, add separator beneath bookmarks panel header r=mconley
authorEmma Malysz <emalysz@mozilla.com>
Thu, 29 Apr 2021 18:47:24 +0000
changeset 578049 0bb236e351f1d4211b88a0c15ff9d73a3813c9ff
parent 578048 ba63cd4d03efc4f58617635f5b44e06c98856c8a
child 578050 64e44a2a6b5b4354b71086827894a2726402b0b1
push id142225
push useremalysz@mozilla.com
push dateThu, 29 Apr 2021 18:49:47 +0000
treeherderautoland@0bb236e351f1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmconley
bugs1708481
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1708481, add separator beneath bookmarks panel header r=mconley Differential Revision: https://phabricator.services.mozilla.com/D113811
browser/base/content/browser.xhtml
browser/themes/shared/customizableui/panelUI.inc.css
browser/themes/shared/places/editBookmarkPanel.inc.css
--- a/browser/base/content/browser.xhtml
+++ b/browser/base/content/browser.xhtml
@@ -298,16 +298,17 @@
              tabspecific="true"
              aria-labelledby="editBookmarkPanelTitle">
         <box class="panel-header">
           <html:h1 id="editBookmarkPanelTitle"/>
           <toolbarbutton tabindex="0" id="editBookmarkPanelInfoButton" class="panel-info-button" oncommand="StarUI.toggleRecommendation();" >
             <image/>
           </toolbarbutton>
         </box>
+        <toolbarseparator id="editBookmarkHeaderSeparator"></toolbarseparator>
         <vbox class="panel-subview-body">
           <html:div id="editBookmarkPanelInfoArea">
             <html:div id="editBookmarkPanelRecommendation"></html:div>
             <html:div id="editBookmarkPanelFaviconContainer">
               <html:img id="editBookmarkPanelFavicon"/>
             </html:div>
             <html:div id="editBookmarkPanelImage"></html:div>
           </html:div>
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -1833,17 +1833,17 @@ menuitem.panel-subview-footer@menuStateA
 
 #widget-overflow-mainView > toolbarseparator,
 #widget-overflow-mainView > .panel-subview-body > toolbarseparator,
 .PanelUI-subView toolbarseparator,
 #permission-popup-mainView > toolbarseparator,
 #protections-popup-multiView toolbarseparator,
 #identity-popup-mainView > toolbarseparator,
 #identity-popup-securityView > toolbarseparator,
-#editBookmarkSeparator,
+#editBookmarkPanel toolbarseparator,
 .cui-widget-panelview menuseparator,
 .cui-widget-panel toolbarseparator {
   appearance: none;
   min-height: 0;
   border-top: 1px solid var(--panel-separator-color);
   border-bottom: none;
   margin: var(--panel-separator-margin);
   padding: 0;
--- a/browser/themes/shared/places/editBookmarkPanel.inc.css
+++ b/browser/themes/shared/places/editBookmarkPanel.inc.css
@@ -151,27 +151,29 @@ html|img#editBookmarkPanelFavicon[src] {
 #editBMPanel_folderTree {
   min-width: 27em;
 }
 
 #editBookmarkPanelBottomButtons {
   display: flex;
 }
 
+#editBookmarkPanel > #editBookmarkHeaderSeparator,
 #editBookmarkPanel > .panel-subview-body > #editBookmarkSeparator {
   margin-bottom: 0;
+  margin-inline: 16px;
 }
 
 @media (-moz-proton-doorhangers) {
 #editBookmarkPanel {
   font: caption;
 }
 
 #editBookmarkPanelInfoArea {
-  padding: 6px var(--arrowpanel-padding) 0;
+  padding: 4px var(--arrowpanel-padding) 0;
 }
 
 #editBookmarkPanelRows > vbox:not(#editBMPanel_nameRow) {
   padding-block: var(--arrowpanel-padding) 0;
 }
 
 #editBookmarkPanelContent label[control] {
   margin-inline-start: 0;