Bug 1594069 - ensure wptrunner.py start() always returns a value, r=jgraham
authorBob Clary <bclary@bclary.com>
Tue, 12 Nov 2019 19:23:33 +0000
changeset 501631 0b0779e6ebe39537f30b6bed33a0201f0434d308
parent 501630 f18d343c7f9d36827f883031e7bacc97017306fe
child 501632 5ffac45592a6604c0d34e4a09dd62e92c41e9cfc
push id100332
push userjames@hoppipolla.co.uk
push dateTue, 12 Nov 2019 19:54:35 +0000
treeherderautoland@0b0779e6ebe3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjgraham
bugs1594069
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1594069 - ensure wptrunner.py start() always returns a value, r=jgraham Differential Revision: https://phabricator.services.mozilla.com/D52191
testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
--- a/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
+++ b/testing/web-platform/tests/tools/wptrunner/wptrunner/wptrunner.py
@@ -337,29 +337,31 @@ def check_stability(**kwargs):
 
 def start(**kwargs):
     assert logger is not None
 
     logged_critical = wptlogging.LoggedAboveLevelHandler("CRITICAL")
     handler = handlers.LogLevelFilter(logged_critical, "CRITICAL")
     logger.add_handler(handler)
 
+    rv = False
     try:
         if kwargs["list_test_groups"]:
             list_test_groups(**kwargs)
         elif kwargs["list_disabled"]:
             list_disabled(**kwargs)
         elif kwargs["list_tests"]:
             list_tests(**kwargs)
         elif kwargs["verify"] or kwargs["stability"]:
-            return check_stability(**kwargs) or logged_critical.has_log
+            rv = check_stability(**kwargs) or logged_critical.has_log
         else:
-            return not run_tests(**kwargs) or logged_critical.has_log
+            rv = not run_tests(**kwargs) or logged_critical.has_log
     finally:
         logger.remove_handler(handler)
+    return rv
 
 
 def main():
     """Main entry point when calling from the command line"""
     kwargs = wptcommandline.parse_args()
 
     try:
         if kwargs["prefs_root"] is None: