Bug 405664: keyboard shortcuts to display the search engine list broken, r=enndeakin, a=schrep
authorgavin@gavinsharp.com
Mon, 03 Dec 2007 14:35:08 -0800
changeset 8616 0ac795900d6743c14a3e1ca115387491aa3dd769
parent 8615 6eb2cb1a468a8dcb1b041c75a378cbbd95591631
child 8617 909a0ca5ba42fe677d4795253acf22a8e133276c
push id1
push userbsmedberg@mozilla.com
push dateThu, 20 Mar 2008 16:49:24 +0000
treeherderautoland@61007906a1f8 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersenndeakin, schrep
bugs405664
milestone1.9b2pre
Bug 405664: keyboard shortcuts to display the search engine list broken, r=enndeakin, a=schrep
browser/components/search/Makefile.in
browser/components/search/content/search.xml
browser/components/search/test/Makefile.in
browser/components/search/test/browser_405664.js
--- a/browser/components/search/Makefile.in
+++ b/browser/components/search/Makefile.in
@@ -38,16 +38,20 @@
 
 DEPTH     = ../../..
 topsrcdir = @top_srcdir@
 srcdir    = @srcdir@
 VPATH     = @srcdir@
 
 include $(DEPTH)/config/autoconf.mk
 
+ifdef MOZ_MOCHITEST
+DIRS = test
+endif
+
 MODULE = browsersearch
 XPIDL_MODULE = browsersearch
 
 XPIDLSRCS = nsIBrowserSearchService.idl
 
 EXTRA_PP_COMPONENTS = nsSearchService.js \
 	nsSearchSuggestions.js
 
--- a/browser/components/search/content/search.xml
+++ b/browser/components/search/content/search.xml
@@ -682,17 +682,17 @@
         ]]></body>
       </method>
 
       <method name="openSearch">
         <body>
           <![CDATA[
             // Don't open search popup if history popup is open
             if (!this.popupOpen) {
-              document.getBindingParent(this)._popup.click();
+              document.getBindingParent(this).searchButton.open = true;
               return false;
             }
             return true;
           ]]>
         </body>
       </method>
 
       <!-- Displays a grayed-out hint string containing the name of the
new file mode 100644
--- /dev/null
+++ b/browser/components/search/test/Makefile.in
@@ -0,0 +1,51 @@
+# ***** BEGIN LICENSE BLOCK *****
+# Version: MPL 1.1/GPL 2.0/LGPL 2.1
+#
+# The contents of this file are subject to the Mozilla Public License Version
+# 1.1 (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+# http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an "AS IS" basis,
+# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+# for the specific language governing rights and limitations under the
+# License.
+#
+# The Original Code is mozilla.org code.
+#
+# The Initial Developer of the Original Code is
+# Mozilla Corporation.
+# Portions created by the Initial Developer are Copyright (C) 2007
+# the Initial Developer. All Rights Reserved.
+#
+# Contributor(s):
+#   Gavin Sharp <gavin@gavinsharp.com> (Original author)
+#
+# Alternatively, the contents of this file may be used under the terms of
+# either of the GNU General Public License Version 2 or later (the "GPL"),
+# or the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
+# in which case the provisions of the GPL or the LGPL are applicable instead
+# of those above. If you wish to allow use of your version of this file only
+# under the terms of either the GPL or the LGPL, and not to allow others to
+# use your version of this file under the terms of the MPL, indicate your
+# decision by deleting the provisions above and replace them with the notice
+# and other provisions required by the GPL or the LGPL. If you do not delete
+# the provisions above, a recipient may use your version of this file under
+# the terms of any one of the MPL, the GPL or the LGPL.
+#
+# ***** END LICENSE BLOCK *****
+
+DEPTH		= ../../../..
+topsrcdir	= @top_srcdir@
+srcdir		= @srcdir@
+VPATH		= @srcdir@
+relativesrcdir  =  browser/components/search/test
+
+include $(DEPTH)/config/autoconf.mk
+include $(topsrcdir)/config/rules.mk
+
+_BROWSER_TEST_FILES = 	  browser_405664.js \
+	                  $(NULL)
+
+libs:: $(_BROWSER_TEST_FILES)
+	$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/browser/$(relativesrcdir)
new file mode 100644
--- /dev/null
+++ b/browser/components/search/test/browser_405664.js
@@ -0,0 +1,29 @@
+function test() {
+  var searchBar = BrowserSearch.searchBar;
+  ok(searchBar, "got search bar");
+  
+  searchBar.focus();
+
+  var pbo = searchBar._popup.popupBoxObject;
+  ok(pbo, "popup is nsIPopupBoxObject");
+
+  EventUtils.synthesizeKey("VK_UP", { altKey: true });
+  is(pbo.popupState, "showing", "popup is opening after Alt+Up");
+
+  EventUtils.synthesizeKey("VK_ESCAPE", {});
+  is(pbo.popupState, "closed", "popup is closed after ESC");
+
+  EventUtils.synthesizeKey("VK_DOWN", { altKey: true });
+  is(pbo.popupState, "showing", "popup is opening after Alt+Down");
+
+  EventUtils.synthesizeKey("VK_ESCAPE", {});
+  is(pbo.popupState, "closed", "popup is closed after ESC 2");
+
+  if (!/Mac/.test(navigator.platform)) {
+    EventUtils.synthesizeKey("VK_F4", {});
+    is(pbo.popupState, "showing", "popup is opening after F4");
+
+    EventUtils.synthesizeKey("VK_ESCAPE", {});
+    is(pbo.popupState, "closed", "popup is closed after ESC 3");
+  }
+}