Bug 1563330 - Let login autocomplete for subdomains ride trains for release. r=MattN
authorSam Foster <sfoster@mozilla.com>
Sat, 12 Oct 2019 08:51:20 +0000
changeset 497362 09f5cd302da54f83b83cff91a13eea73c7914643
parent 497361 1411bb191e69e717fe5d2309be5a6e4f69cf7b16
child 497363 a0f1057c6f5042b1c80f411a9208a18b46b710cd
push id97836
push userncsoregi@mozilla.com
push dateSat, 12 Oct 2019 14:07:11 +0000
treeherderautoland@09f5cd302da5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersMattN
bugs1563330
milestone71.0a1
Bug 1563330 - Let login autocomplete for subdomains ride trains for release. r=MattN Needs a rs to enable the feature for 71. Try: https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=mochitest&revision=811f92d684564767fdfcfabf9408905e41ec1de0 I guess all the autocomplete tests are skipped for android anyhow, but I also ran: https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=mochitest&revision=f7d3c7dbb98654e8345030ca3058f44a9c31b510 Differential Revision: https://phabricator.services.mozilla.com/D49046
browser/app/profile/firefox.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -1789,21 +1789,18 @@ pref("signon.generation.available", true
 pref("signon.generation.enabled", true);
 pref("signon.schemeUpgrades", true);
 pref("signon.privateBrowsingCapture.enabled", true);
 pref("signon.showAutoCompleteFooter", true);
 pref("signon.management.page.enabled", true);
 pref("signon.management.page.breach-alerts.enabled", true);
 pref("signon.management.page.sort", "name");
 pref("signon.management.overrideURI", "about:logins?filter=%DOMAIN%");
-#ifdef NIGHTLY_BUILD
-  // Bug 1563330 tracks shipping this by default.
-  pref("signon.showAutoCompleteOrigins", true);
-  pref("signon.includeOtherSubdomainsInLookup", true);
-#endif
+pref("signon.showAutoCompleteOrigins", true);
+pref("signon.includeOtherSubdomainsInLookup", true);
 // The utm_creative value is appended within the code (specific to the location on
 // where it is clicked). Be sure that if these two prefs are updated, that
 // the utm_creative param be last.
 pref("signon.management.page.mobileAndroidURL", "https://app.adjust.com/6tteyjo?redirect=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dmozilla.lockbox&utm_campaign=Desktop&utm_adgroup=InProduct&utm_creative=");
 pref("signon.management.page.mobileAppleURL", "https://app.adjust.com/6tteyjo?redirect=https%3A%2F%2Fitunes.apple.com%2Fapp%2Fid1314000270%3Fmt%3D8&utm_campaign=Desktop&utm_adgroup=InProduct&utm_creative=");
 pref("signon.management.page.breachAlertUrl",
      "https://monitor.firefox.com/breach-details/");