Bug 1658937 - [3.0] Update changelog. r=geckoview-reviewers,agi
☠☠ backed out by c7193ad59e98 ☠ ☠
authorEugen Sawin <esawin@mozilla.com>
Tue, 22 Sep 2020 20:58:34 +0000
changeset 549721 031b4f94e7f7432db7691ab91a47a05820a436fb
parent 549720 8d6b4239dacb0a28f94fac9089d7056e60ab1e86
child 549722 994c13da52dc80ad8996c059ab052e8b3cf56797
push id126962
push useresawin@mozilla.com
push dateWed, 23 Sep 2020 02:30:22 +0000
treeherderautoland@031b4f94e7f7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgeckoview-reviewers, agi
bugs1658937
milestone83.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1658937 - [3.0] Update changelog. r=geckoview-reviewers,agi Differential Revision: https://phabricator.services.mozilla.com/D90912
mobile/android/geckoview/api.txt
mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
--- a/mobile/android/geckoview/api.txt
+++ b/mobile/android/geckoview/api.txt
@@ -1368,17 +1368,16 @@ package org.mozilla.geckoview {
 
   @UiThread public static interface MediaSession.Delegate {
     method default public void onActivated(@NonNull GeckoSession, @NonNull MediaSession);
     method default public void onDeactivated(@NonNull GeckoSession, @NonNull MediaSession);
     method default public void onFeatures(@NonNull GeckoSession, @NonNull MediaSession, long);
     method default public void onFullscreen(@NonNull GeckoSession, @NonNull MediaSession, boolean, @Nullable MediaSession.ElementMetadata);
     method default public void onMetadata(@NonNull GeckoSession, @NonNull MediaSession, @NonNull MediaSession.Metadata);
     method default public void onPause(@NonNull GeckoSession, @NonNull MediaSession);
-    method default public void onPictureInPicture(@NonNull GeckoSession, @NonNull MediaSession, boolean);
     method default public void onPlay(@NonNull GeckoSession, @NonNull MediaSession);
     method default public void onPositionState(@NonNull GeckoSession, @NonNull MediaSession, @NonNull MediaSession.PositionState);
     method default public void onStop(@NonNull GeckoSession, @NonNull MediaSession);
   }
 
   public static class MediaSession.ElementMetadata {
     ctor public ElementMetadata(@Nullable String, double, long, long, int, int);
     field public final int audioTrackCount;
--- a/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
+++ b/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/doc-files/CHANGELOG.md
@@ -9,16 +9,22 @@ exclude: true
 {% capture javadoc_uri %}{{ site.url }}{{ site.baseurl}}/javadoc/mozilla-central/org/mozilla/geckoview{% endcapture %}
 {% capture bugzilla %}https://bugzilla.mozilla.org/show_bug.cgi?id={% endcapture %}
 
 # GeckoView API Changelog.
 
 ⚠️  breaking change and deprecation notices
 
 ## v83
+- ⚠️  Removing unsupported `MediaSession.Delegate.onPictureInPicture` for now.
+  Also, [`MediaSession.Delegate.onMetadata`][83.1] is no longer dispatched for
+  plain media elements.
+  ([bug 1658937]({{bugzilla}}1658937))
+
+[83.1]: {{javadoc_uri}}/MediaSession.Delegate.html#onMetadata-org.mozilla.geckoview.GeckoSession-org.mozilla.geckoview.MediaSession-org.mozilla.geckoview.MediaSession.Metadata-
 
 ## v82
 - ⚠️  [`WebNotification.source`][79.2] is now `@Nullable` to account for
   WebExtension notifications which don't have a `source` field.
 - ⚠️ Deprecated [`ContentDelegate#onExternalResponse(GeckoSession, WebResponseInfo)`][82.1] with the intention of removing
   them in GeckoView v85. 
   ([bug 1530022]({{bugzilla}}1530022))
 - Added [`ContentDelegate#onExternalResponse(GeckoSession, WebResponse)`][82.2] to eliminate the need
@@ -798,9 +804,9 @@ to allow adding gecko profiler markers.
 [65.19]: {{javadoc_uri}}/GeckoSession.NavigationDelegate.LoadRequest.html#isRedirect
 [65.20]: {{javadoc_uri}}/GeckoSession.html#LOAD_FLAGS_BYPASS_CLASSIFIER
 [65.21]: {{javadoc_uri}}/GeckoSession.ContentDelegate.ContextElement.html
 [65.22]: {{javadoc_uri}}/GeckoSession.ContentDelegate.html#onContextMenu-org.mozilla.geckoview.GeckoSession-int-int-org.mozilla.geckoview.GeckoSession.ContentDelegate.ContextElement-
 [65.23]: {{javadoc_uri}}/GeckoSession.FinderResult.html
 [65.24]: {{javadoc_uri}}/CrashReporter.html#sendCrashReport-android.content.Context-android.os.Bundle-java.lang.String-
 [65.25]: {{javadoc_uri}}/GeckoResult.html
 
-[api-version]: e62341ace2541ae9fbd4f08f7c2d03ba28bf416a
+[api-version]: 8cbbe3b03d78c33888562ea18a4554cff90f531d