autoland: changeset 530075:023fc1d6e3aeaf289484970417315e40f5296195

☠☠ backed out by 267cd03f6f5c ☠ ☠
author	Manuel Rego Casasnovas <rego@igalia.com>
	Wed, 13 May 2020 09:45:43 +0000
changeset 530075	023fc1d6e3aeaf289484970417315e40f5296195
parent 530074	8460a9f973209f9984acc906bf11d8cca7217a82
child 530076	eed68249208e11575d6c59cedcad9594eb891386
push id	116003
push user	wptsync@mozilla.com
push date	Thu, 14 May 2020 19:04:08 +0000
treeherder	autoland@7baa72e0d62c [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	testonly
bugs	1636045, 23420, 1078539, 2182471, 766312
milestone	78.0a1
first release with	nightly linux32 5a0a960a8d55 / 78.0a1 / 20200515093304 / files nightly linux64 5a0a960a8d55 / 78.0a1 / 20200515093304 / files nightly mac 5a0a960a8d55 / 78.0a1 / 20200515093304 / files nightly win32 5a0a960a8d55 / 78.0a1 / 20200515093304 / files nightly win64 5a0a960a8d55 / 78.0a1 / 20200515093304 / files
last release without	nightly linux32 8af03d77567d / 78.0a1 / 20200514094044 / files nightly linux64 8af03d77567d / 78.0a1 / 20200514094044 / files nightly mac 8af03d77567d / 78.0a1 / 20200514094044 / files nightly win32 8af03d77567d / 78.0a1 / 20200514094044 / files nightly win64 8af03d77567d / 78.0a1 / 20200514094044 / files

Bug 1636045 [wpt PR 23420] - Fix "auto" outline with padding and overflowing inline descendants, a=testonly Automatic update from web-platform-tests Fix "auto" outline with padding and overflowing inline descendants This patch fixes a regression in LayoutNG compared to legacy, when the descendant of an element with padding and "outline: auto" is an inline block. And also when it's an inline element (which was not working properly in legacy layout either, that's why outline-025 and outline-026 tests fail on legacy). We need to rebaseline an old pixel test, as we're coming back to the legacy layout behavior for it. BUG=1078539 TEST=external/wpt/css/css-ui/outline-024.html TEST=external/wpt/css/css-ui/outline-025.html TEST=external/wpt/css/css-ui/outline-026.html Change-Id: I8ccf72fb34e1d9ce6821eec9312f1fecd52e1281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182471 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#766312} -- wpt-commits: 663e39d65620ff336e5183b0b4c2a7bb1636c2c7 wpt-pr: 23420

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-ui/outline-024.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Basic User Interface: outline with padding</title>
+<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
+<link rel="help" href="https://drafts.csswg.org/css-ui/#outline-props">
+<link rel="match" href="reference/outline-024-ref.html">
+<meta name="assert" content="Test checks that 'auto' outline works as expected in an element with padding and overflowing inline block descendant.">
+<meta name="flags" content="ahem">
+<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
+<p>Test passes if the outline is wrapping all the green boxes.</p>
+<div style="width: 50px; height: 50px; padding: 10px; outline: auto;">
+  <div style="display: inline-block; font: 50px/1 Ahem; color: green;">XX</div>
+</div>

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-ui/outline-025.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Basic User Interface: outline with padding</title>
+<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
+<link rel="help" href="https://drafts.csswg.org/css-ui/#outline-props">
+<link rel="match" href="reference/outline-024-ref.html">
+<meta name="assert" content="Test checks that 'auto' outline works as expected in an element with padding and overflowing inline descendant.">
+<meta name="flags" content="ahem">
+<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
+<p>Test passes if the outline is wrapping all the green boxes.</p>
+<div style="width: 50px; height: 50px; padding: 10px; outline: auto;">
+  <div style="display: inline; font: 50px/1 Ahem; color: green;">XX</div>
+</div>

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-ui/outline-026.html
@@ -0,0 +1,13 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Basic User Interface: outline with padding</title>
+<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
+<link rel="help" href="https://drafts.csswg.org/css-ui/#outline-props">
+<link rel="match" href="reference/outline-024-ref.html">
+<meta name="assert" content="Test checks that 'auto' outline works as expected in an element with padding and overflowing SPAN descendant.">
+<meta name="flags" content="ahem">
+<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
+<p>Test passes if the outline is wrapping all the green boxes.</p>
+<div style="width: 50px; height: 50px; padding: 10px; outline: auto;">
+  <span style="font: 50px/1 Ahem; color: green;">XX</span>
+</div>

new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-ui/reference/outline-024-ref.html
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<meta charset="utf-8">
+<title>CSS Basic User Interface: Reference test for outline with padding</title>
+<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
+<meta name="flags" content="ahem">
+<link rel="stylesheet" type="text/css" href="/fonts/ahem.css" />
+<p>Test passes if the outline is wrapping all the green boxes.</p>
+<div style="width: 50px; height: 50px; padding: 10px; outline: auto;">
+  <div style="font: 50px/1 Ahem; color: green;">XX</div>
+</div>
+

testing/web-platform/tests/css/css-ui/outline-024.html		file \| annotate \| diff \| comparison \| revisions
testing/web-platform/tests/css/css-ui/outline-025.html		file \| annotate \| diff \| comparison \| revisions
testing/web-platform/tests/css/css-ui/outline-026.html		file \| annotate \| diff \| comparison \| revisions
testing/web-platform/tests/css/css-ui/reference/outline-024-ref.html		file \| annotate \| diff \| comparison \| revisions