Bug 1647695 - Uniformizing naming conventions within fields of ChildProcInfoDictionary;r=tarek
☠☠ backed out by ea03df7a1554 ☠ ☠
authorDavid Teller <dteller@mozilla.com>
Mon, 03 Aug 2020 15:03:26 +0000
changeset 543134 01b6951d0aaee040d5c51ef737046ea88cd9f7bb
parent 543133 1b1fa5dbd9bdf7d3579af6bcdb3a727e6ec9a777
child 543135 328923e31a701a32936b8f2259cc3a9bc594ba97
push id123248
push userdteller@mozilla.com
push dateMon, 03 Aug 2020 15:05:58 +0000
treeherderautoland@01b6951d0aae [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstarek
bugs1647695
milestone81.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1647695 - Uniformizing naming conventions within fields of ChildProcInfoDictionary;r=tarek Differential Revision: https://phabricator.services.mozilla.com/D83667
dom/chrome-webidl/ChromeUtils.webidl
widget/tests/browser/browser_test_procinfo.js
--- a/dom/chrome-webidl/ChromeUtils.webidl
+++ b/dom/chrome-webidl/ChromeUtils.webidl
@@ -549,17 +549,17 @@ dictionary ChildProcInfoDictionary {
   long long pid = 0;
   DOMString filename = "";
   unsigned long long virtualMemorySize = 0;
   long long residentSetSize = 0;
   unsigned long long cpuUser = 0;
   unsigned long long cpuKernel = 0;
   sequence<ThreadInfoDictionary> threads = [];
   // Firefox info
-  unsigned long long ChildID = 0;
+  unsigned long long childID = 0;
   UTF8String origin = "";
   WebIDLProcType type = "web";
 };
 
 dictionary ParentProcInfoDictionary {
   // System info
   long long pid = 0;
   DOMString filename = "";
--- a/widget/tests/browser/browser_test_procinfo.js
+++ b/widget/tests/browser/browser_test_procinfo.js
@@ -44,16 +44,26 @@ add_task(async function test_proc_info()
 
         for (var i = 0; i < parentProc.children.length; i++) {
           let childProc = parentProc.children[i];
           Assert.notEqual(
             childProc.type,
             "browser",
             "Child proc type should not be browser"
           );
+          if (
+            childProc.type.startsWith("web") ||
+            childProc.type.startsWith("Web")
+          ) {
+            Assert.notEqual(
+              childProc.childID,
+              0,
+              "Child proc should not have a 0 childID"
+            );
+          }
           Assert.notEqual(
             childProc.type,
             "unknown",
             "Child proc type should be known"
           );
           if (childProc.type == "webIsolated") {
             Assert.notEqual(
               childProc.origin || "",