Bug 1594998 - Make standalone SpiderMonkey use libxul-like panic. r=froydnj This moves the parts of toolkit/library/rust/shared/lib.rs related to panic hooking to a new mozglue subdirectory, which will be used for things that can be statically linked to e.g. libxul, rather than in a "shared library". The panic hook is disabled when building spidermonkey via the mozjs_sys crate. Differential Revision: https://phabricator.services.mozilla.com/D52793

Bug 1568058 - pt 4 - Use batch decoding in MediaBufferDecoder. r=jya - Add a pref for controlling the batch size when doing webaudio decoding on RDD. - If batch size is greater than 1 and the decoder is capable of batch decoding, send raw sample batches to decoder. Differential Revision: https://phabricator.services.mozilla.com/D51454

Bug 1568058 - pt 3 - Remove MediaFormatReader from MediaBufferDecoder. r=jya Stop using MediaFormatReader and use a demuxer and decoder directly in MediaBufferDecoder. This will allow us to do batch decoding calls for webaudio that will improve performance by reducing the number of IPC calls to the RDD process. Differential Revision: https://phabricator.services.mozilla.com/D51453

Bug 1568058 - pt 2 - Add batch decode methods to MediaDataDecoder. r=jya In order to use the batch decoding abilities added in Bug 1590475, we need to also add batch decoding to MediaDataDecoder. For now only RemoteMediaDataDecoder (and AudioTrimmer as a wrapper) know how to do batch, but this could be implemented more generically later in MediaDataDecoder. Differential Revision: https://phabricator.services.mozilla.com/D51452

Bug 1568058 - pt 1 - Add DecoderTraits::CreateDemuxer and use it in CreateReader. r=jya CreateDemuxer will be used in MediaBufferDecoder as we remove MediaFormatReader. Differential Revision: https://phabricator.services.mozilla.com/D45094

Bug 1596198 - Remove the canary from nsStringBuffer r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D52961

Bug 1596330 - Remove CrossProcessRedirectDone and FinishCrossProcessSwitch r=mattwoodrow Depends on D52950 Differential Revision: https://phabricator.services.mozilla.com/D52951

Bug 1596330 - Remove mDoingCrossProcessRedirect r=mattwoodrow Depends on D52949 Differential Revision: https://phabricator.services.mozilla.com/D52950

Bug 1596330 - Remove dead process switching code r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D52949

Bug 1595287 - update math-global-event-handlers.tentative.html expectations r=aryx Differential Revision: https://phabricator.services.mozilla.com/D52455

Bug 1588975 - Replace ShellExecuteExW with mozilla::ShellExecuteByExplorer. r=aklotz,asuth The launcher process turns on the `PreferSystem32Images` mitigation policy for the browser process. Since the mitigation policy is inherited, a process launched by the browser process also has `PreferSystem32Images`. If an application which does not support `PreferSystem32Images`, such as Skype for Business, is launched via a hyperlink, a custom uri, or a downloaded file, it would fail to launch. Bug 1567614 fixed this issue by introducing `mozilla::ShellExecuteByExplorer` to `nsMIMEInfoWin::LoadUriInternal`. This patch introduces `mozilla::ShellExecuteByExplorer` to two more places. 1. xul!nsLocalFile::Launch This is invoked when a user opens a file from the Download Library, or a user opens a downloaded file with the default application without saving it. 2. xul!nsMIMEInfoWin::LaunchWithFile This is invoked when a user opens a downloaded file with a custom application (configured in about:preference) without saving it. *Why does this patch change worker.js?* The mochitest dom/tests/browser/browser_test_new_window_from_content.js failed if it was executed after dom/serviceworkers/test/browser_download.js in the same batch. This was because browser_download.js launched Notepad to open fake_download.bin.txt, preventing a new window from being opened in the foreground in browser_test_new_window_from_content.js. The test browser_download.js can verify downloaded data without opening an associated application. So this patch adds the content-type to the response header in order not to open Notepad on Windows. Differential Revision: https://phabricator.services.mozilla.com/D52567

Bug 1528429 - disable browser_urlBar_zoom.js on mac r=gbrown Differential Revision: https://phabricator.services.mozilla.com/D52687

Bug 1589931 - P2: Update cubeb-audiounit-rs to 0920240. r=padenot Pick commits: 0920240 - Always return null-terminated strings from current_device (#25) Differential Revision: https://phabricator.services.mozilla.com/D52880

Bug 1589931 - P1: Only check non-null current output device. r=padenot Differential Revision: https://phabricator.services.mozilla.com/D52750

Bug 1585231 - disable browser_delay_autoplay_media_pausedAfterPlay.js on fission r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53087

Bug 1596279 - Set all ccov opt tests as tier-3 for now. r=jmaher Depends on D53001 Differential Revision: https://phabricator.services.mozilla.com/D53002

Bug 1596279 - Set the same chunk numbers and timeouts for coverage opt builds as in coverage debug builds. r=jmaher In bug 1596368 we will adjust them, after disabling tests in coverage debug builds. Depends on D53000 Differential Revision: https://phabricator.services.mozilla.com/D53001

Bug 1596279 - Don't disable ccov opt tests with a transform. r=jmaher Depends on D52999 Differential Revision: https://phabricator.services.mozilla.com/D53000

Bug 1596279 - Define linux64-ccov/opt as a test platform. r=jmaher Depends on D52998 Differential Revision: https://phabricator.services.mozilla.com/D52999

Bug 1596279 - Install grcov in the Linux coverage opt build to parse gcno/gcda files. r=jmaher Depends on D52997 Differential Revision: https://phabricator.services.mozilla.com/D52998

Bug 1596279 - Enable Rust tests on the Linux coverage opt built too. r=jmaher Differential Revision: https://phabricator.services.mozilla.com/D52997

No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM Differential Revision: https://phabricator.services.mozilla.com/D53009

Bug 1595519 - Update pdf.js to version 2.4.127. r=bdahl Differential Revision: https://phabricator.services.mozilla.com/D52545

Backed out 2 changesets (bug 1594204) for SM build bustages at WasmBaselineCompile.cpp on a CLOSED TREE Backed out changeset 74cc3a413cb0 (bug 1594204) Backed out changeset 6295568b6ea4 (bug 1594204)

Bug 1596288 - Move some code in Bailouts.h into Bailouts.cpp that is the sole user of it. r=jandem Differential Revision: https://phabricator.services.mozilla.com/D52936

Bug 1594304. Add deprecation notes to methods that allow throwing a bare nsresult with no useful message. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D53092

Bug 1578534 - Change nsIX509CertDB.constructX509 to take Array<uint8_t> r=keeler Differential Revision: https://phabricator.services.mozilla.com/D44730

Bug 1589742 - Collect telemetry on the types of user clicks r=smaug Differential Revision: https://phabricator.services.mozilla.com/D51508

Bug 1577217: Let third-party-modules ride to early beta; r=mhowell We've decided to let this ride through to early beta. We'll evaluate how the early beta numbers look, and if there are no significant issues we'll follow up with another patch to ride to release. This is already covered by the data review for bug 1542830. Differential Revision: https://phabricator.services.mozilla.com/D53084

Bug 1594122 - convert XBL binding to custom element in reftest 1369954-1.xhtml r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D53064

Bug 1487212 - When hyphenation resources are compressed in omnijar, load them into shared memory and share among all content processes. r=heycam,froydnj Differential Revision: https://phabricator.services.mozilla.com/D52835

Bug 1592968 - Use the registry to record creating a taskbar pin. r=agashlin My initial idea of using the shortcuts log to store this information didn't work out because the helper, when run by an updater which was run by the maintenance service, doesn't get write permissions on that file. Differential Revision: https://phabricator.services.mozilla.com/D52276

Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh Differential Revision: https://phabricator.services.mozilla.com/D50931

Bug 1516367 - Move the minidump-analyzer out of the crash reporter application bundle r=spohl,dmajor The minidump-analyzer tool was originally conceived to be used from the crash report client and as such was installed in the crash reporter client application bundle on macOS. It was later adapted to work from Firefox itself but this caused linking problems when invoked from the Firefox app bundle. This patch moves the minidump-analyzer into the Firefox app bundle and adapts the relevant code to find it there. The minidump-analyzer was also not signed like the rest of our executables and this patch addresses that issue too. Differential Revision: https://phabricator.services.mozilla.com/D52910

Bug 1593131 - part6 : modify log name. r=chunmin Differential Revision: https://phabricator.services.mozilla.com/D52708

Bug 1593131 - part5 : use unreachable assertion to replace debug log. r=chunmin To make sure it never happens. Differential Revision: https://phabricator.services.mozilla.com/D52707

Bug 1593131 - part4 : make 'MediaControlKeysManager' being both an event source and listener. r=chunmin The event source in `MediaControlKeysManager` now is created dynamically, so that means sometime we don't have an event source to allow people add or remove listener Therefore, make `MediaControlKeysManager` inherit from `MediaControlKeysEventSource` to allow it to provide add/remove listener methods and inherit from `MediaControlKeysEventListener` to allow it to monitor the real media control keys event and dispatch event to its listeners. Differential Revision: https://phabricator.services.mozilla.com/D51766

Bug 1593131 - part3 : use nsISupport for ref counting r=chunmin Use` nsISupport` for ref counting, instead of using `NS_INLINE_DECL_THREADSAFE_REFCOUNTING`, then we can allow an usage such like inheritting from both `MediaControlKeysEventListener` and `MediaControlKeysEventSource` at the same time, which doesn't be allowed in old implementation because we can only have one parent class owning `mRefCnt`. Differential Revision: https://phabricator.services.mozilla.com/D52703

Bug 1593131 - part2 : dynamically create or destroy media keys event source according to the amount of media controller r=chunmin In this patch, we dynamically create or destroy media keys event source according to the amount of media controller . We would create the event source when we have a controller which needs to be controlled, and destory the event source when there is no controllers existing. In addition, create a `Init()` function for media service for calling any other owned module's initialization, which is used to ensure that we finish setting the `gMediaControlService` before any other classes call `MediaControlService::GetService()`. Differential Revision: https://phabricator.services.mozilla.com/D51765

Bug 1593131 - part1 : use media event to notity media controller amount changed. r=chunmin As we have a need to know if there is any existing controller needs to be controlled in order to achieve dynamically creation and destruction of media keys event source. (that will be implemented in patch2) Therefore, using the media event to send the current media controller amount when the total media controller amount changed in the media service. Differential Revision: https://phabricator.services.mozilla.com/D51763

Bug 1596341 - Fix nasm putting garbage in the .debug_loc section on elf32. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52972

Bug 1588218 - Expose DNS suffix list (Android) r=michal,snorp Differential Revision: https://phabricator.services.mozilla.com/D51561

Bug 1595877, replace .xul mochitest files in layout/ with .xhtml r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D52728

Bug 1596117: Fail early on bad atom table indices in XDR decoding r=tcampbell Before we read an atom from the atom table, verify that the index is valid. Differential Revision: https://phabricator.services.mozilla.com/D53060

Bug 1594850 - Part 2 - Write a test for gHistoryMaxSize in nsSHistory being set to 0 and mIndex and mRequestedIndex=-1, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D52927

Bug 1594850 - Part 1 - Fix crash in nsSHistory::EnsureCorrectEntryAtCurrIndex when mIndex=-1, r=peterv Differential Revision: https://phabricator.services.mozilla.com/D52370

Bug 1596172 - Add perf-reftest-singletons to PGO training r=firefox-build-system-reviewers,mshal This ought to overcome a regression from 1592981 as well as make this test suite less noisy about toolchain updates in the future. While here, tidy up the PGO list: sort alphabetically, stop using a hardcoded test index for the Speedometer time extension, and stop using js-input/ for the virtual mappings since js-input/ is an actual directory in our repo. Differential Revision: https://phabricator.services.mozilla.com/D52888

Bug 1594204 - Generate inline code for memory.copy and memory.fill. r=lth This commit adds an inline code path for memory.copy/fill for Ion and Baseline for all platforms. To keep things simple, I reused the plain wasm load/store codegen with integer types up to 64bits. A future commit can add SIMD support as needed. A copy with constant length is reduced to a series of loads (from low-to-high) onto the value stack (for baseline), or onto a stack of definitions (for ion). Then a series of stores are emitted (from high-to-low) from the value stack or temp definition stack. A fill with constant length and value is reduced to a series of stores (from high-to-low). The stores use the widest transfer width as possible, and the value is splatted as appropriate to fill the whole integer. This optimization is limited to sizes that are less than the guard page so that we only need to perform a single bounds check for src/dest. The threshold is per-platform and derived from the wasm-bulk-bench microbenchmark. I attempted to pick the length just before the inline path began to slow exponentially. This was roughly constant at 8 loads/stores for 64 and 32 bits. Differential Revision: https://phabricator.services.mozilla.com/D52129

Bug 1594204 - Split out 'emitMemCopy' function for dedicated optimizations. r=lth Differential Revision: https://phabricator.services.mozilla.com/D50380

Bug 1596245 - Fix WebGPU device destruction r=jgilbert Differential Revision: https://phabricator.services.mozilla.com/D53081

Merge mozilla-central to autoland. a=merge on a CLOSED TREE

Merge mozilla-inbound to mozilla-central a=merge

Merge autoland to mozilla-central a=merge

Bug 1579189 - raise the minimum clang version to 5; r=#build We need this for "full" C++17 support (everything is supported, but some C++17 features still have bugs) and this change also brings Linux into parity with our Mac requirements. MANUAL PUSH: build toolchains on inbound to avoid clogging autoland Differential Revision: https://phabricator.services.mozilla.com/D51450

Backed out changeset c4ff245706ab (bug 1595155) for Android mochitest failures on mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html a=backout

Bug 1591989 - [remote] Don't use 'frameId' for Page.loadEventFired event. r=whimboo,remote-protocol-reviewers Differential Revision: https://phabricator.services.mozilla.com/D53046

Backed out changeset 70304898d836 (bug 1595927) for causing browser_cmd_click.js to permafail CLOSED TREE

Backed out 3 changesets (bug 1535437, bug 1591253) for causing browser_resizeVideo.js to permafail CLOSED TREE Backed out changeset f7cc2f6d9640 (bug 1591253) Backed out changeset bc637c20c7d4 (bug 1535437) Backed out changeset 46b4eb05f2ae (bug 1535437)

Bug 1595328 - Add browser.experiments.urlbar.lastBrowserUpdateDate webextension experiment API. r=mak,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D52948

Bug 1530402 - Move WebExtensionListener to WebExtension.java. r=esawin Differential Revision: https://phabricator.services.mozilla.com/D52709

Bug 1530402 - Add {Browser,Page}Action support to GVE. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D49042

Bug 1530402 - Implement {Browser,Page}Action for GeckoView. r=snorp,mixedpuppy,esawin Design doc: https://docs.google.com/document/d/1XJuKk9Hm_2RNbX8KRcyUOXTaELBWYMyXBUchz15OElY Differential Revision: https://phabricator.services.mozilla.com/D49041

Bug 1530402 - Emit |location-change| from mobile's TabTracker. r=snorp This matches desktop's TabTracker. Also, remove Tab:Selected which is an event that was coming from Fennec. Differential Revision: https://phabricator.services.mozilla.com/D52252

Bug 1530402 - Add package-protected isPopup setting to hide GeckoSessions from extensions. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D51918

Bug 1530402 - Provide GeckoImageDecoder. r=snorp This class allows GeckoView embedders to decode images using Gecko's image library. Differential Revision: https://phabricator.services.mozilla.com/D49038

Bug 1530402 - Provide imgTools.decodeFromChannelAsync. r=aosmond,snorp This method allows consumers to decode images from a |nsIChannel| instance. This method also supports vector images (e.g. SVGs), which other decode methods don't. Differential Revision: https://phabricator.services.mozilla.com/D49037

Bug 1530402 - Remove Fennec's {Browser,Page} Action implementation. r=snorp We're going to replace this implementation from scratch so we remove it here to avoid a confusing diff. Differential Revision: https://phabricator.services.mozilla.com/D51917

Bug 1530402 - Refactor desktop's ext-{page,browser}Action. r=mixedpuppy This patch refactors Desktop's implementation of Page and Browser actions to decouple the logic inside a common Action object that can be used to implement actions on other platforms, like mobile, without re-implementing it. A follow-up commit will use this common logic on the mobile implementation. Differential Revision: https://phabricator.services.mozilla.com/D49036

Bug 1530402 - Provide an API to use TextureView in GeckoView. r=snorp,droeh Differential Revision: https://phabricator.services.mozilla.com/D51916

Bug 1530402 - Remove unused NULL_MESSAGE_DELEGATE. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D49053

Bug 1533156 - Remove toolkit/components/reader from GeckoView. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D49035

Bug 1530402 - Remove Fennec code from ext-utils.js. r=droeh Differential Revision: https://phabricator.services.mozilla.com/D51641

Bug 1595891 - Guard against IndexError in wpt get_test_window(); r=jgraham Change order of conditions to avoid intermittent IndexError when there are no handles. Differential Revision: https://phabricator.services.mozilla.com/D52735

Bug 1595257 - Add annotations report to 'mach test-info report'; r=jmaher This "annotations" report provides a different view of manifest data, concentrating on the manifest annotations, like "skip-if". What conditions are used in manifests? How many times does each occur? Differential Revision: https://phabricator.services.mozilla.com/D52926

Bug 1595091 - Remove alwaysOnTop from the window features used by the abuse report dialog. r=mstriemer Differential Revision: https://phabricator.services.mozilla.com/D52896

Bug 1591755 - Support Web Permissions in FxR for Desktop r=Gijs,pbz This change will be the first of multiple changes to control permissions in FxR on PC. This change introduces a new class, FxrPermissionPromptPrototype, in the FxR front end code. With the introduction of this class, all permission requests are denied by default. Subsequent changes will provide UI to give user control. Differential Revision: https://phabricator.services.mozilla.com/D52283

Bug 1596503 - Remove unnecessary trailing semicolon with rust nightly (breaks the build) r=jrmuizel Differential Revision: https://phabricator.services.mozilla.com/D53056

Bug 1596137 - mozAddonManager.reportAbuse should reject on unsupported addon types. r=mixedpuppy mozAddonManager.reportAbuse should reject explicitly when called for an unsupported addon type, to make AMO able to detect when if triggering the integrated report failed instead of being cancelled by the user, and fallback on the report form integrated on the AMO website. Differential Revision: https://phabricator.services.mozilla.com/D52882

Bug 1405971 - Test that Webextension UUID doesn't leak via XHR/Fetch requests. r=mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D40854

Bug 1405971 - Strip existing disallowed schemes in Origin header. r=JuniorHsu,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D39781

Bug 1580156 - set WebRTC thread name r=dmajor Differential Revision: https://phabricator.services.mozilla.com/D51975

Bug 1596238, Make NodeIterator less AddRef/Release heavy by trying to avoid use of strong pointer when the node is skipped because of whatToShow, r=Ehsan TreeWalker could use some similar changes, but that is a different bug. TreeWalker does use TestNode method too, which is why the new argument is optional. A new bug will be filed for TreeWalker. Differential Revision: https://phabricator.services.mozilla.com/D53016

Bug 1595787: Move ExternalImageHandler and OutputImageHandler traits to webrender_api. r=kvark Differential Revision: https://phabricator.services.mozilla.com/D52686

Bug 1596220 - Document GMPProvider's findUpdates and checkForUpdates functions. r=spohl Add documentation to help differentiate the use cases for these two functions. Differential Revision: https://phabricator.services.mozilla.com/D52911

Bug 1595906 - Allow opting out of hardening compile flags on a granular basis r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D52756

Bug 1595927 - Remove XPCOM gunk around RemoteWebNavigation creation. r=mconley It just adds a lot of unnecessary overhead and indirection. Differential Revision: https://phabricator.services.mozilla.com/D52753

Bug 1596430 - Permit an additional stat to the NSS certDB metadata files r=florian Probably caused by Bug 1577803, which is a good change, so updating the tests. Differential Revision: https://phabricator.services.mozilla.com/D53050

Bug 1592007 - land NSS 87f35ba4c82f UPGRADE_NSS_RELEASE, r=keeler 2019-11-13 J.C. Jones <jjones@mozilla.com> * lib/softoken/pkcs11c.c: Bug 1591363 - Fixup double-free of params in nsc_SetupPBEKeyGen r=keeler Caused in commit 7ef8d2604494. [87f35ba4c82f] [tip] 2019-11-07 Makoto Kato <m_kato@ga2.so-net.ne.jp> * lib/freebl/ctr.c: Bug 1592869 - Use NEON for ctr_xor. r=kjacobs Using NEON for ctr_xor, aes_ctr can improve 30%-40%i decode/encode time on Cortex-A72. [d244c7287908] 2019-11-12 Marcus Burghardt <mburghardt@mozilla.com> * gtests/pk11_gtest/pk11_pbkdf2_unittest.cc, lib/pk11wrap/pk11pbe.c, lib/pk11wrap/pk11skey.c, lib/softoken/pkcs11c.c: Bug 1591363 - PBKDF2 memory leaks in NSC_GenerateKey. r=jcj A memory leak was reported and confirmed in this bug. However, during the "manual" analysis of the flow, another possible leak was found. I created a patch for both leaks, added gtests for unexpected keySizes and adjusted the general syntax of the gtest file. [7ef8d2604494] 2019-11-11 Tom Prince <mozilla@hocat.ca> * automation/taskcluster/graph/src/extend.js, automation/taskcluster/windows/setup.sh: Bug 1594891 - Use tc-proxy for nss tooltool; r=dustin,jcj [c33b214b2ec8] 2019-11-08 Daiki Ueno <dueno@redhat.com> * gtests/ssl_gtest/ssl_dhe_unittest.cc, gtests/ssl_gtest/ssl_ecdh_unittest.cc, gtests/ssl_gtest/tls_connect.h, lib/ssl/ssl3con.c: Bug 1566131, check policy against hash algorithms used for ServerKeyExchange, r=mt Summary: This adds necessary policy checks in `ssl3_ComputeCommonKeyHash()`, right before calculating hashes. Note that it currently doesn't check MD5 as it still needs to be allowed in TLS 1.1 or earlier and many tests fail if we change that. Reviewers: mt Reviewed By: mt Bug #: 1566131 [c08947c6af57] 2019-11-08 Kai Engert <kaie@kuix.de> * coreconf/coreconf.dep: Dummy change, trigger a build to test latest NSPR commits. [e766899c72a5] * automation/taskcluster/graph/src/extend.js: Bug 1579836 - Execute NSPR tests as part of NSS continuous integration. r=jcj [46bfbabf7e75] 2019-11-08 Dustin J. Mitchell <dustin@mozilla.com> * automation/taskcluster/graph/npm-shrinkwrap.json, automation/taskcluster/graph/package.json, automation/taskcluster/graph/src/image_builder.js, automation/taskcluster/graph/src/queue.js, automation/taskcluster/scripts/tools.sh, automation/taskcluster/windows/gen_certs.sh, automation/taskcluster/windows/run_tests.sh: Bug 1594891 - Updates to run correctly on the new TC deployment r=jcj * Update the Taskcluster client used in the decision task to one that understands Taskcluster rootUrls. * Update scripts that fetch content to use the TASKCLUSTER_ROOT_URL * the absence of this variale signals an "old" worker so we use an "old" URL [67d630e7cb7c] 2019-11-07 Tom Prince <mozilla@hocat.ca> * .taskcluster.yml, automation/taskcluster/graph/src/extend.js, automation/taskcluster/graph/src/queue.js: Bug 1591275: Switch workers to use AWS Provder; r=kjacobs [a2bebaad41dd] 2019-11-06 Daiki Ueno <dueno@redhat.com> * gtests/pk11_gtest/pk11_module_unittest.cc: Bug 1577803, clang-format, a=bustage [c9014b2892d5] * gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/pkcs11testmodule.cpp, lib/pk11wrap/debug_module.c, lib/pk11wrap/pk11obj.c, lib/pk11wrap/pk11slot.c, lib/pk11wrap/secmodti.h, lib/util/pkcs11t.h: Bug 1577803, pk11wrap: set friendly flag if token implements CKP_PUBLIC_CERTIFICATES_TOKEN, r=rrelyea Summary: This makes NSS look for CKO_PROFILE object at token initialization time to check if it implements the [[ https://docs .oasis-open.org/pkcs11/pkcs11-profiles/v3.0/pkcs11-profiles-v3.0.pdf | Public Certificates Token profile ]] as defined in PKCS #11 v3.0. If it is found, the token is automatically marked as friendly so no authentication attempts will be made when accessing certificates. Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [b39c8eeabe6a] 2019-11-06 Martin Thomson <mt@lowentropy.net> * lib/freebl/blinit.c, lib/freebl/gcm-ppc.c: Bug 1566126 - clang-format, a=bustage [6125200fbc88] 2019-11-06 Lauri Kasanen <cand@gmx.com> * lib/freebl/Makefile, lib/freebl/altivec-types.h, lib/freebl/blapii.h, lib/freebl/blinit.c, lib/freebl/freebl.gyp, lib/freebl/gcm-ppc.c, lib/freebl/gcm.c, lib/freebl/gcm.h: Bug 1566126 - freebl: POWER GHASH Vector Acceleration, r=mt Implementation for POWER8 adapted from the ARM paper: https://conradoplg.cryptoland.net/files/2010/12/gcm14.pdf Benchmark of `bltest -E -m aes_gcm -i tests/aes_gcm/plaintext10 \ -v tests/aes_gcm/iv10 -k tests/aes_gcm/key10 -5 10` on POWER8 3.3GHz. NSS_DISABLE_HW_CRYPTO=1 mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 309Mb 192 5M 0 0.000 10000.000 10.001 30Mb mode in symmkey opreps cxreps context op time(sec) thrgput aes_gcm_e 829Mb 192 14M 0 0.000 10000.000 10.001 82Mb Notable operf results, sw: samples % image name symbol name 226033 59.3991 libfreeblpriv3.so bmul 80606 21.1824 libfreeblpriv3.so rijndael_encryptBlock128 28851 7.5817 libfreeblpriv3.so gcm_HashMult_sftw hw: 213899 56.2037 libfreeblpriv3.so rijndael_encryptBlock128 45233 11.8853 libfreeblpriv3.so gcm_HashMult_hw So the ghash part is ~5.6x faster. Signed-off-by: Lauri Kasanen <cand@gmx.com> [3d7e509d6d20] 2019-11-05 Marcus Burghardt <mburghardt@mozilla.com> * lib/certdb/certdb.c, lib/util/secport.h: Bug 1589073 - Use of new PR_ASSERT_ARG in certdb.c. r=mt Bug 1588015 introduced in NSPR a new way to ASSERT values where the arguments are always used avoiding "unused variable" errors. This was implemented in NSS, at certdb.c. [73c28cad3dbb] 2019-11-05 Daiki Ueno <dueno@redhat.com> * cpputil/nss_scoped_ptrs.h, gtests/manifest.mn, gtests/pk11_gtest/manifest.mn, gtests/pk11_gtest/pk11_gtest.gyp, gtests/pk11_gtest/pk11_module_unittest.cc, gtests/pkcs11testmodule/Makefile, gtests/pkcs11testmodule/config.mk, gtests/pkcs11testmodule/manifest.mn, gtests/pkcs11testmodule/pkcs11testmodule.cpp, gtests/pkcs11testmodule/pkcs11testmodule.def, gtests/pkcs11testmodule/pkcs11testmodule.gyp, gtests/pkcs11testmodule/pkcs11testmodule.rc, nss.gyp: Bug 1577803, gtests: import pkcs11testmodule from Firefox, r=rrelyea Summary: This adds a mock PKCS #11 module from Firefox and add basic tests around it. This is needed for proper testing of PKCS #11 v3.0 profile objects (D45669). Reviewers: rrelyea Reviewed By: rrelyea Subscribers: reviewbot Bug #: 1577803 [0a86945adf74] Differential Revision: https://phabricator.services.mozilla.com/D52779

Bug 1582297 - Suppress IPC "pipe error" messages if the cause was probably the other process exiting. r=froydnj There are two issues here: 1. These error messages occur even during normal channel shutdown, because that's tracked in the mozilla::ipc::MessageChannel layer, which the ipc/chromium code can't access. 2. If we get this kind of error when the channel wasn't intentionally closed, it almost certainly means that the other process crashed. In that case, having error messages from a different process and a likely unrelated subsystem just leads to confusion and misfiled bugs. (Also complicating things: on Unix a closed channel often, but not always, results in an end-of-file indication, which already isn't logged; on Windows it's always a broken pipe error, which causes a much larger amount of log spam.) Bonus fix: the error that contains a fd number is clarified to avoid having it mistaken for an error code. Differential Revision: https://phabricator.services.mozilla.com/D52727

Bug 1594122 - convert XBL binding to custom element in 348049-1.xhtml reftest r=bzbarsky Differential Revision: https://phabricator.services.mozilla.com/D52854

Bug 1591253 - Maintain PiP player position when source video is resized r=mconley Differential Revision: https://phabricator.services.mozilla.com/D52064

Bug 1535437 - Part 2: Resize PiP window when video source resizes r=mconley Differential Revision: https://phabricator.services.mozilla.com/D50139

Bug 1535437 - Part 1: Allow windows to resize outside of aspect ratio locking on Windows r=jmathies Differential Revision: https://phabricator.services.mozilla.com/D51940

Bug 1595470 - Prevent EnsureCorrectPermissions from making faulty assumptions about childBuffer r=rstrong Differential Revision: https://phabricator.services.mozilla.com/D52604

Backed out 2 changesets (bug 1594204) for build bustage at WasmBaselineCompile.cpp on a CLOSED TREE Backed out changeset b0545db75058 (bug 1594204) Backed out changeset 36d41bbf2f46 (bug 1594204)

Bug 1594204 - Generate inline code for memory.copy and memory.fill. r=lth This commit adds an inline code path for memory.copy/fill for Ion and Baseline for all platforms. To keep things simple, I reused the plain wasm load/store codegen with integer types up to 64bits. A future commit can add SIMD support as needed. A copy with constant length is reduced to a series of loads (from low-to-high) onto the value stack (for baseline), or onto a stack of definitions (for ion). Then a series of stores are emitted (from high-to-low) from the value stack or temp definition stack. A fill with constant length and value is reduced to a series of stores (from high-to-low). The stores use the widest transfer width as possible, and the value is splatted as appropriate to fill the whole integer. This optimization is limited to sizes that are less than the guard page so that we only need to perform a single bounds check for src/dest. The threshold is per-platform and derived from the wasm-bulk-bench microbenchmark. I attempted to pick the length just before the inline path began to slow exponentially. This was roughly constant at 8 loads/stores for 64 and 32 bits. Differential Revision: https://phabricator.services.mozilla.com/D52129

Bug 1594204 - Split out 'emitMemCopy' function for dedicated optimizations. r=lth Differential Revision: https://phabricator.services.mozilla.com/D50380

Bug 1595885 - Fix lint error, r=maja_zf Differential Revision: https://phabricator.services.mozilla.com/D53048

Bug 1595926 - Don't use distribution256Sum until Android Studio is fixed. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D52900

Bug 1595836 - add support for ./mach python-test r=rwood Differential Revision: https://phabricator.services.mozilla.com/D52976

Bug 1596474 - Remove GetBindingParent from nsGenericHTMLElement. r=smaug The two loops where they're used can't walk across shadow boundaries, so we only need to check for NAC. We don't have forms in NAC, so avoid silly book-keeping and just return early for those cases. Differential Revision: https://phabricator.services.mozilla.com/D53045

Bug 1596342 - Update sending patch documentation to only mention Phabricator + moz-phab. r=rcaliman. The documentation was mentioning arc as the primary tool to push to review (and was discouraging using moz-phab). moz-phab is now much more stable and is the prefered way of pushing patches, so we shouldn't mention arc anymore. There was also a (not recommended) mention of attaching patch to Bugzilla for reviews, which I think isn't something we recommend anymore. Differential Revision: https://phabricator.services.mozilla.com/D52969

Bug 1596186 - Close all extension pages when unregistering an extension. r=snorp Differential Revision: https://phabricator.services.mozilla.com/D52894

Backed out changeset c4ff245706ab (bug 1595155) for Android mochitest failures on mobile/android/components/extensions/test/mochitest/test_ext_webNavigation_onCommitted.html. CLOSED TREE

Backed out changeset 6e3d285d14ee (bug 1594521) for toolkit/mozapps/extensions/test/browser/browser_CTP_plugins.js. CLOSED TREE

Bug 1595885 - Ensure we have a valid window after wpt reftest timeout, r=webdriver-reviewers,maja_zf Typically we can close the wpt reftest window at the end of a test and open a new one for the follwing test. But that interacts badly with the harness trying to run marionette commands before the test starts; for example when it tries to set a pref. So we were hitting a situation where tests that TIMEOUT followed by tests that require a pref end up erroring. To avoid this make sure to set the original opener window as the marionette window when we close the reftest window. Differential Revision: https://phabricator.services.mozilla.com/D53014

Bug 1596463 - Remove GetBindingParent usage in the XML pretty printer. r=smaug It was already checking shadow trees as well, so trivial change. Differential Revision: https://phabricator.services.mozilla.com/D53035

Bug 1594552 - Add moz.configure bits to specify a compiler for converting C/C++ to wasm r=firefox-build-system-reviewers,chmanchester Differential Revision: https://phabricator.services.mozilla.com/D52111

Bug 1596365 - Adjust metrics.yaml to pass yamllint. r=chutten Differential Revision: https://phabricator.services.mozilla.com/D52982

Bug 1575092 - don't spawn Shared/Service Workers in "web COOP+COEP" processes r=asuth Preventing RemoteWorkerService from existing in "web COOP+COEP" content processes prevents Shared/ServiceWorkers from being spawned in them because there won't be an associated RemoteWorkerServiceParent that registers with the parent process RemoteWorkerManager. Differential Revision: https://phabricator.services.mozilla.com/D50815

Bug 1575092 - add "web COOP+COEP" process type helpers r=asuth Differential Revision: https://phabricator.services.mozilla.com/D50814

Bug 1592797 - Fix MediaKeys linker error exposed with different optimization flags r=edgar Seeing this linker error when building with optimization flags -O2 and others: .../mozilla-central/dom/media/eme/mediadrm/MediaDrmCDMProxy.cpp:297: error: undefined reference to 'void mozilla::dom::MediaKeys::ResolvePromiseWithResult<bool>(unsigned int, bool const&)' This patch moves the template definition from dom/media/eme/MediaKeys.cpp to dom/media/eme/MediaKeys.h Differential Revision: https://phabricator.services.mozilla.com/D51188

Bug 1168606 - Set flag to invalidate in-flight responses as well. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D52559

Bug 1168606 - Added test case for IDBObjectStore.delete while iterating a cursor. r=asuth Differential Revision: https://phabricator.services.mozilla.com/D48504

Bug 1168606 - Increase default maximum number of extra records to preload to 64. r=ttung,asuth Differential Revision: https://phabricator.services.mozilla.com/D43467

Backed out 2 changesets (bug 1585410) for causing xpcshell failures in test_TelemetryController.js CLOSED TREE Backed out changeset bbe85df3365a (bug 1585410) Backed out changeset 474430e7ea37 (bug 1585410)

Backed out changeset 5d7640ffbf2a (bug 1595135) for causing bc failures in toolkit/components/thumbnails CLOSED TREE

Bug 1581161 - Removed GeckoResponse and reworked Text Selection API. r=geckoview-reviewers,snorp,esawin Differential Revision: https://phabricator.services.mozilla.com/D47116

Bug 1594981 - improve BUG_COMPONENT in various moz.build files r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D53024

Bug 1595245 - Translate remaining uncaught mozharness ADBErrors into task retries; r=bc Most mozdevice access in mozharness was already encapsulated in try blocks, with only the shell_output() case neglected, consistent with the observed intermittent failures. Differential Revision: https://phabricator.services.mozilla.com/D52879