searching for reviewer(yulia)
8ec50232ea5541b34962a496abaff720ebd81a73: Bug 1662977: Allow "maximumFractionDigits" option in Intl.NumberFormat to be less than the default minimum fraction digits. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 24 Nov 2020 10:29:51 +0000 - rev 558441
Push 131571 by cbrindusan@mozilla.com at Tue, 24 Nov 2020 18:38:42 +0000
Bug 1662977: Allow "maximumFractionDigits" option in Intl.NumberFormat to be less than the default minimum fraction digits. r=yulia Implements the changes from the "has consensus" PR <https://github.com/tc39/ecma402/pull/471>. The second pair of `DefaultNumberOption()` calls was inlined, because only the fallback case is relevant anyway. Steps 12.d and 12.e from the spec PR were combined into a single `if`-block. That way it also matches step 12.f more closely. Also changed the single `if` steps into an `if-else if` chain, because the steps are mutually exclusive. Depends on D95734 Differential Revision: https://phabricator.services.mozilla.com/D95735
7fc74cb51fe135346bed315653ad3199006771de: Bug 1670062: Support "collation" option in Intl.Collator constructor. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 24 Nov 2020 09:14:15 +0000 - rev 558440
Push 131571 by cbrindusan@mozilla.com at Tue, 24 Nov 2020 18:38:42 +0000
Bug 1670062: Support "collation" option in Intl.Collator constructor. r=yulia Implements the changes from the "has consensus" PR <https://github.com/tc39/ecma402/pull/459>. Drive-by change: - Enable a named groups RegExp test which wasn't enabled when bug 1362154 was implemented. Differential Revision: https://phabricator.services.mozilla.com/D95734
eae616d39b5183328e36d3f9a3116bef89e0c6c8: Bug 1674560: Skip test for "dayPeriod" when not on Nightly. r=yulia
André Bargull <andre.bargull@gmail.com> - Mon, 02 Nov 2020 15:39:32 +0000 - rev 555447
Push 129958 by cbrindusan@mozilla.com at Mon, 02 Nov 2020 16:49:51 +0000
Bug 1674560: Skip test for "dayPeriod" when not on Nightly. r=yulia The "fractionalSecondDigits" option for `Intl.DateTimeFormat` is now shipping, but the "dayPeriod" option isn't yet. Skip the test which uses "dayPeriod" when not running on Nightly. Differential Revision: https://phabricator.services.mozilla.com/D95520
8a2e8d901a435bf0f6f7ecbe5e8ffa09a2328dac: Bug 1645107 - Part 2: Enable "fractionalSecondDigits" test262 tests by default. r=yulia
André Bargull <andre.bargull@gmail.com> - Fri, 30 Oct 2020 16:55:26 +0000 - rev 555278
Push 129869 by cbrindusan@mozilla.com at Fri, 30 Oct 2020 19:12:28 +0000
Bug 1645107 - Part 2: Enable "fractionalSecondDigits" test262 tests by default. r=yulia Depends on D95271 Differential Revision: https://phabricator.services.mozilla.com/D95272
4a8cd93a0876fa8290245ff41470e786adf42a77: Bug 1645107 - Part 1: Ship "fractionalSecondDigits" option for Intl.DateTimeFormat. r=yulia
André Bargull <andre.bargull@gmail.com> - Fri, 30 Oct 2020 10:29:40 +0000 - rev 555277
Push 129869 by cbrindusan@mozilla.com at Fri, 30 Oct 2020 19:12:28 +0000
Bug 1645107 - Part 1: Ship "fractionalSecondDigits" option for Intl.DateTimeFormat. r=yulia Depends on D95270 Differential Revision: https://phabricator.services.mozilla.com/D95271
4a065c1a4c55bcea3d8d8d31270dc580dd252e8b: Bug 1670496: Access "fractionalSecondDigits" before "timeZoneName" property. r=yulia
André Bargull <andre.bargull@gmail.com> - Fri, 30 Oct 2020 10:26:39 +0000 - rev 555276
Push 129869 by cbrindusan@mozilla.com at Fri, 30 Oct 2020 19:12:28 +0000
Bug 1670496: Access "fractionalSecondDigits" before "timeZoneName" property. r=yulia The spec PR changed to access "fractionalSecondDigits" before the "timeZoneName" property, update our code accordingly. Differential Revision: https://phabricator.services.mozilla.com/D95270
38a6d65eb220f58eb04e9f9dda4057e8d9729b26: Bug 1426219 - TypeError is not a developer error anymore;r=yulia
David Teller <dteller@mozilla.com> - Fri, 30 Oct 2020 11:34:37 +0000 - rev 555215
Push 129828 by dteller@mozilla.com at Fri, 30 Oct 2020 13:43:50 +0000
Bug 1426219 - TypeError is not a developer error anymore;r=yulia This patch is part of an ongoing work to help our test suite show developer errors that are currently being swallowed by `try { ... } catch (e) { ... }`. Previous patches in the work used the heuristic that all instances of `TypeError`, `SyntaxError` and `ReferenceError` are developer errors unless specified otherwise. As it turns out, we are throwing `TypeError` in many cases that are not type errors. Since we have no manner of distinguishing which of these cases are actual (developer) errors and which are runtime exceptions, this patch removes `TypeError` from the list of developer errors. Ideally, a followup patch would carefully reactivate `TypeError`, with a mechanism to annotate which actually represent type errors (typically, those thrown by SpiderMonkey or `throw new TypeError`) and which do not (typically, most of the instances of `TypeError` thrown by DOM operations). Differential Revision: https://phabricator.services.mozilla.com/D95276
7dc21301609c66760746625f2bc5a8505882a537: Bug 1655086 - Test semantics for throwing private field initializers r=yulia
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 31 Jul 2020 08:25:50 +0000 - rev 542857
Push 123075 by mgaudet@mozilla.com at Fri, 31 Jul 2020 12:25:05 +0000
Bug 1655086 - Test semantics for throwing private field initializers r=yulia DefineField calls the intializer before doing PrivateFieldAdd, so if an initializer throws, we end up with partially initialized objects. Differential Revision: https://phabricator.services.mozilla.com/D84844
f58cbd3ffe3fa3e03361205e1d23785fb744da5f: Bug 1652216 - Update jsparagus to fix private field handling. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Thu, 16 Jul 2020 00:13:18 +0000 - rev 540653
Push 121846 by arai_a@mac.com at Thu, 16 Jul 2020 00:19:33 +0000
Bug 1652216 - Update jsparagus to fix private field handling. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D83643
7516c5d950390491ffdb5903140f0b6322c1a3cc: Bug 1651329 - Guard use of TypedObjects to avoid failures in beta r=yulia
Matthew Gaudet <mgaudet@mozilla.com> - Wed, 08 Jul 2020 21:02:32 +0000 - rev 539503
Push 121165 by mgaudet@mozilla.com at Thu, 09 Jul 2020 01:58:18 +0000
Bug 1651329 - Guard use of TypedObjects to avoid failures in beta r=yulia Differential Revision: https://phabricator.services.mozilla.com/D82734
13e737b413dec2929b401fb7d2aefc46f81bc8fa: Bug 1648757 - Part 4: Update test262 exclusion list. r=yulia
André Bargull <andre.bargull@gmail.com> - Mon, 29 Jun 2020 10:08:48 +0000 - rev 537788
Push 120214 by rmaries@mozilla.com at Mon, 29 Jun 2020 11:44:48 +0000
Bug 1648757 - Part 4: Update test262 exclusion list. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D81365
6aa6852f64249e0671076314ea01973b0e8113b4: Bug 1648757 - Part 3: Update test262 June 2020. r=yulia
André Bargull <andre.bargull@gmail.com> - Mon, 29 Jun 2020 10:02:52 +0000 - rev 537787
Push 120214 by rmaries@mozilla.com at Mon, 29 Jun 2020 11:44:48 +0000
Bug 1648757 - Part 3: Update test262 June 2020. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D81358
9e6bc3021fa17765122febece028de3fa8c88a77: Bug 1648757 - Part 2: Update unsupported features list. r=yulia
André Bargull <andre.bargull@gmail.com> - Sat, 27 Jun 2020 06:11:51 +0000 - rev 537786
Push 120214 by rmaries@mozilla.com at Mon, 29 Jun 2020 11:44:48 +0000
Bug 1648757 - Part 2: Update unsupported features list. r=yulia Depends on D81324 Differential Revision: https://phabricator.services.mozilla.com/D81325
d3e2ab6f703a10db2ee228318300bcd653a56a2d: Bug 1648757 - Part 1: Allow more than one argument in IsHTMLDDA_Call. r=yulia
André Bargull <andre.bargull@gmail.com> - Sat, 27 Jun 2020 06:11:51 +0000 - rev 537785
Push 120214 by rmaries@mozilla.com at Mon, 29 Jun 2020 11:44:48 +0000
Bug 1648757 - Part 1: Allow more than one argument in IsHTMLDDA_Call. r=yulia Allow more than one argument per <https://github.com/tc39/test262/pull/2674>. Differential Revision: https://phabricator.services.mozilla.com/D81324
583323d355636e8da55b45d9a5f6e88e6a128f1e: Bug 1647169: Optional call can't be a direct eval. r=yulia
André Bargull <andre.bargull@gmail.com> - Mon, 22 Jun 2020 12:42:58 +0000 - rev 536589
Push 119551 by ncsoregi@mozilla.com at Mon, 22 Jun 2020 14:59:37 +0000
Bug 1647169: Optional call can't be a direct eval. r=yulia Test case will be added through the next test262 sync: - https://github.com/tc39/test262/pull/2667 Differential Revision: https://phabricator.services.mozilla.com/D80416
be88821c6c6077e86c7668100011f91ac4400872: Bug 1645792 - Mark non262/String/normalize-generateddata-part* slow in SM(smoosh) debug job. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Mon, 15 Jun 2020 15:17:04 +0000 - rev 535708
Push 119029 by arai_a@mac.com at Mon, 15 Jun 2020 15:27:19 +0000
Bug 1645792 - Mark non262/String/normalize-generateddata-part* slow in SM(smoosh) debug job. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D79696
c8c31dc035b3640f8bf626ec9ca8a92233378d25: Bug 1643632 - Use BaseScopeData. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Fri, 05 Jun 2020 10:34:56 +0000 - rev 534145
Push 118166 by arai_a@mac.com at Fri, 05 Jun 2020 12:55:25 +0000
Bug 1643632 - Use BaseScopeData. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D78475
17f21c2824f08e1d32167db63cfed84e18c586ba: Bug 1643044 - Use bumpalo 3.4.0. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Fri, 05 Jun 2020 11:04:23 +0000 - rev 534144
Push 118166 by arai_a@mac.com at Fri, 05 Jun 2020 12:55:25 +0000
Bug 1643044 - Use bumpalo 3.4.0. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D78079
f9735776f715bc7f69b56f773436f9834602bd48: Bug 1639591 - Part 3: Re-import test262. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 03 Jun 2020 09:01:32 +0000 - rev 533697
Push 117898 by btara@mozilla.com at Wed, 03 Jun 2020 09:09:50 +0000
Bug 1639591 - Part 3: Re-import test262. r=yulia Depends on D77823 Differential Revision: https://phabricator.services.mozilla.com/D77824
c7e9155860a9873991d57fe7d3e3bb50403f1f25: Bug 1639591 - Part 2: Ship logical assignment operators proposal. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 02 Jun 2020 15:51:36 +0000 - rev 533696
Push 117898 by btara@mozilla.com at Wed, 03 Jun 2020 09:09:50 +0000
Bug 1639591 - Part 2: Ship logical assignment operators proposal. r=yulia Depends on D77822 Differential Revision: https://phabricator.services.mozilla.com/D77823
f15d364b3feca665e6ddc1a0c2d1b53ca68cad04: Bug 1639591 - Part 1: Assign name to anonymous function for short-circuit assignment. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 02 Jun 2020 15:50:22 +0000 - rev 533695
Push 117898 by btara@mozilla.com at Wed, 03 Jun 2020 09:09:50 +0000
Bug 1639591 - Part 1: Assign name to anonymous function for short-circuit assignment. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D77822
9ba7358924dc1ef04841289004b1a7caccb44cb7: Bug 1639772 - Update jsparagus and use ImmutableScriptFlags directly. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Fri, 29 May 2020 13:30:51 +0000 - rev 532975
Push 117494 by arai_a@mac.com at Fri, 29 May 2020 13:34:43 +0000
Bug 1639772 - Update jsparagus and use ImmutableScriptFlags directly. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D76267
31c34fc039e6f26eebdffb73e1dbecab95d9ee4d: Bug 1639073 - Update jsparagus and use stencil crate. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Wed, 20 May 2020 17:34:02 +0000 - rev 531310
Push 116565 by arai_a@mac.com at Wed, 20 May 2020 17:37:05 +0000
Bug 1639073 - Update jsparagus and use stencil crate. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D75881
6ce1c29f3ed5b339b805f7f2543aca61bf208dc4: Bug 1638470 - Update jsparagus, and update SmooshMonkey to store atoms in gcthings. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Tue, 19 May 2020 17:30:32 +0000 - rev 530871
Push 116422 by tcampbell@mozilla.com at Tue, 19 May 2020 17:47:18 +0000
Bug 1638470 - Update jsparagus, and update SmooshMonkey to store atoms in gcthings. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D75711
f0fa5c2a4cde55e6e66ada3424feceb295914df9: Bug 1629833 - Part 5: Move a variable comment to the variable declaration. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 13:28:40 +0000 - rev 524170
Push 113025 by shindli@mozilla.com at Wed, 15 Apr 2020 13:31:39 +0000
Bug 1629833 - Part 5: Move a variable comment to the variable declaration. r=yulia It's probably more helpful to have the variable documentation near the declaration. Also amends the description to cover normal name assignments. Depends on D70863 Differential Revision: https://phabricator.services.mozilla.com/D70864
0bdacd0e3c6ae8ab1d319eb8dc77b4cf973431a8: Bug 1629833 - Part 4: Remove unnecessary manual lifetime management of Maybe<> variables. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 08:33:46 +0000 - rev 524169
Push 113025 by shindli@mozilla.com at Wed, 15 Apr 2020 13:31:39 +0000
Bug 1629833 - Part 4: Remove unnecessary manual lifetime management of Maybe<> variables. r=yulia `~Maybe()` will perform the clean-up anyway, so we don't really need to call `reset()` manually here. Depends on D70862 Differential Revision: https://phabricator.services.mozilla.com/D70863
6984de9355ec511be7772da9b73b8b9b6565e9bd: Bug 1629833 - Part 3: Reduce code duplication for assignment operations. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 08:33:25 +0000 - rev 524168
Push 113025 by shindli@mozilla.com at Wed, 15 Apr 2020 13:31:39 +0000
Bug 1629833 - Part 3: Reduce code duplication for assignment operations. r=yulia The comment about handling name assignments separately predates `NameOpEmitter`. Using `NameOpEmitter` we don't have to worry choosing the correct bytecode operations and when to emit `BindName`. Depends on D70861 Differential Revision: https://phabricator.services.mozilla.com/D70862
badc2504dd4c713155085d8e9d3088137728eefe: Bug 1629833 - Part 2: Pretty print compound assignment in disassembler. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 08:32:19 +0000 - rev 524167
Push 113025 by shindli@mozilla.com at Wed, 15 Apr 2020 13:31:39 +0000
Bug 1629833 - Part 2: Pretty print compound assignment in disassembler. r=yulia Depends on D70860 Differential Revision: https://phabricator.services.mozilla.com/D70861
af1a9e9efc37df34377e024f7a2330ed5ed65de4: Bug 1629833 - Part 1: Add missing source-note for compound assignment. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 08:32:11 +0000 - rev 524166
Push 113025 by shindli@mozilla.com at Wed, 15 Apr 2020 13:31:39 +0000
Bug 1629833 - Part 1: Add missing source-note for compound assignment. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D70860
373440004686812de9e4907e025c4c78a5ab4fab: Bug 1629106 - Part 2: Enable test262 tests for Logical Assignment Operators proposal. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 09:16:09 +0000 - rev 524158
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629106 - Part 2: Enable test262 tests for Logical Assignment Operators proposal. r=yulia Depends on D70823 Differential Revision: https://phabricator.services.mozilla.com/D70824
17566bf1e9cdba83fd57310351426871b4c45743: Bug 1629106 - Part 1: Implement Logical Assignment Operators proposal. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 15 Apr 2020 09:15:22 +0000 - rev 524157
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629106 - Part 1: Implement Logical Assignment Operators proposal. r=yulia Restricted to Nightly because there's still an open issue about inferred function names and because the proposal was only recently moved to stage 3. Depends on D70821 Differential Revision: https://phabricator.services.mozilla.com/D70823
df074e9ed3219f4676f45b470afcbc21422e8cfa: Bug 1629794: Handle absent arguments in AsyncFromSyncIteratorPrototype. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 14 Apr 2020 14:40:35 +0000 - rev 524153
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629794: Handle absent arguments in AsyncFromSyncIteratorPrototype. r=yulia We're using a shared implementation for the "next", "return", and "throw" methods, so we only need to adjust a single line of code. Spec PR: https://github.com/tc39/ecma262/pull/1776 Depends on D70815 Differential Revision: https://phabricator.services.mozilla.com/D70816
47dd633b1c5b764844ccb398aeb285d8c74af99c: Bug 1629792 - Part 3: Update test262 skip list. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 14 Apr 2020 14:39:04 +0000 - rev 524150
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629792 - Part 3: Update test262 skip list. r=yulia Depends on D70812 Differential Revision: https://phabricator.services.mozilla.com/D70813
c09cebe849105a5e8309ec4e7341e91adc8d0ce7: Bug 1629792 - Part 2: Update test262 April 14 2020. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 14 Apr 2020 14:39:04 +0000 - rev 524149
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629792 - Part 2: Update test262 April 14 2020. r=yulia Depends on D70811 Differential Revision: https://phabricator.services.mozilla.com/D70812
637689d896b45fbd2f498c803d6942ca85306199: Bug 1629792 - Part 1: Update test262 features list. r=yulia
André Bargull <andre.bargull@gmail.com> - Tue, 14 Apr 2020 14:39:03 +0000 - rev 524148
Push 113018 by apavel@mozilla.com at Wed, 15 Apr 2020 11:25:02 +0000
Bug 1629792 - Part 1: Update test262 features list. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D70811
0e6b66e117a22fa04ee2aea12d92bea798ad63d9: Bug 1625823 - Part 2: Use smoosh_/Smoosh prefix for bindings. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Apr 2020 11:27:01 +0000 - rev 522621
Push 112225 by arai_a@mac.com at Tue, 07 Apr 2020 13:44:26 +0000
Bug 1625823 - Part 2: Use smoosh_/Smoosh prefix for bindings. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D69890
0777f5f882b1041da5206636cc186daeec0f0769: Bug 1625823 - Part 1: Update jsparagus and support RegExp. r=yulia
Tooru Fujisawa <arai_a@mac.com> - Tue, 07 Apr 2020 13:43:45 +0000 - rev 522620
Push 112225 by arai_a@mac.com at Tue, 07 Apr 2020 13:44:26 +0000
Bug 1625823 - Part 1: Update jsparagus and support RegExp. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D69886
65c1c7d322edbbd45fb945b1d1055d3d5716e20f: Bug 1611777 - Part 16: Pass through ValueUsage in optional chains. r=yulia
André Bargull <andre.bargull@gmail.com> - Thu, 30 Jan 2020 08:21:44 +0000 - rev 512124
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 16: Pass through ValueUsage in optional chains. r=yulia This allows us to emit `JSOp::CallIgnoresRv` in optional chains. Differential Revision: https://phabricator.services.mozilla.com/D61163
075c4404c2c81312c55db4c3e04ab4d1ddef8aa8: Bug 1611777 - Part 15: Support FunCall/FunApply optimisations for optional chaining. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:31:20 +0000 - rev 512123
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 15: Support FunCall/FunApply optimisations for optional chaining. r=yulia This change allows the bytecode emitter to use `JSOp::FunCall` resp. `JSOp::FunApply` for calls in optional chain expressions. Differential Revision: https://phabricator.services.mozilla.com/D61162
46d27864b908bd0926d6ec0b25ee165917cd9887: Bug 1611777 - Part 14: Simplify two lines in optionalExpr(). r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:30:36 +0000 - rev 512122
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 14: Simplify two lines in optionalExpr(). r=yulia - We don't need to test for `tt == TokenKind::Eof` when we return for `tt != TokenKind::OptionalChain` anyway. - Omit local variable for the result value and instead use a tail-call. This matches the local style in the parser more closely. Differential Revision: https://phabricator.services.mozilla.com/D61161
9c5786b1bccbe2f1b481d51395d915e7e58eaaf0: Bug 1611777 - Part 13: Remove unused default arguments from parser methods. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:30:01 +0000 - rev 512121
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 13: Remove unused default arguments from parser methods. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D61160
849b4d84f74365b7202bf923423335967e07712e: Bug 1611777 - Part 12: Use optionalExpr() for update expressions to match spec grammar. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:29:22 +0000 - rev 512120
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 12: Use optionalExpr() for update expressions to match spec grammar. r=yulia Using optionalExpr matches the spec grammar more closely. This change also modifies the reported error message. `++a?.b` reported before this change "unexpected token: '?.'", but now reports "invalid increment/decrement operand". Differential Revision: https://phabricator.services.mozilla.com/D61159
468ff3d2cf8e3e6e5eac3a79285cc9e53f7e2f22: Bug 1611777 - Part 11: Support optional chaining in class heritage expression. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:29:15 +0000 - rev 512119
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 11: Support optional chaining in class heritage expression. r=yulia Differential Revision: https://phabricator.services.mozilla.com/D61158
e82fbc9dee634c29797c5019b12c2c1ebea3eba1: Bug 1611777 - Part 10: Remove unnecessary "allowCallSyntax" parameter from Parser::optionalExpr. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:28:05 +0000 - rev 512118
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 10: Remove unnecessary "allowCallSyntax" parameter from Parser::optionalExpr. r=yulia All callers pass allowCallSyntax=true, so we can omit this parameter. Differential Revision: https://phabricator.services.mozilla.com/D61157
fa5be03a588c387639907f7e72b4d86d2bfe880a: Bug 1611777 - Part 9: Replace an if-statement with an assertion. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:27:22 +0000 - rev 512117
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 9: Replace an if-statement with an assertion. r=yulia `nextMember` is never nullptr, so we don't need to test for it. Differential Revision: https://phabricator.services.mozilla.com/D61156
958adec635321bfe453ac74672a8e2037b953259: Bug 1611777 - Part 8: Add missing emitGet in emitOptionalElemExpression. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:26:44 +0000 - rev 512116
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 8: Add missing emitGet in emitOptionalElemExpression. r=yulia Aligns emitOptionalElemExpression() with emitOptionalDotExpression(), so it's easier to compare both methods against each other. Differential Revision: https://phabricator.services.mozilla.com/D61155
5c9241e7ce20ad0f1cfe2b852e4b86f8054f1c85: Bug 1611777 - Part 7: Add missing entries to list of valid optional chain start expressions. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:26:06 +0000 - rev 512115
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 7: Add missing entries to list of valid optional chain start expressions. r=yulia The previous list contained some invalid entries (`await` and comma-expression) and was missing some possible parse node kinds. Differential Revision: https://phabricator.services.mozilla.com/D61154
4a8a350bba27258f5821dec1e37157e39375e3d1: Bug 1611777 - Part 6: Crash for unexpected super-base in optional call. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:25:23 +0000 - rev 512114
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 6: Crash for unexpected super-base in optional call. r=yulia `super?.()` isn't valid code, so we don't need to handle this case. Differential Revision: https://phabricator.services.mozilla.com/D61153
9dba40e8b408fed3e4acd5c05b568f4dc51a8991: Bug 1611777 - Part 5: Remove unnecessary super-handling in optional delete. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:24:50 +0000 - rev 512113
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 5: Remove unnecessary super-handling in optional delete. r=yulia The child node of a DeleteOptionalChainExpr node can't be a super-property accessor, so we can remove this code. Drive-by: Reindent some stack comments. Differential Revision: https://phabricator.services.mozilla.com/D61152
95890e60c691ce8977bd1fe8287215d9312bc3ee: Bug 1611777 - Part 4: `super` can't occur on the left-hand side of an optional chain. r=yulia
André Bargull <andre.bargull@gmail.com> - Wed, 29 Jan 2020 16:24:12 +0000 - rev 512112
Push 106197 by csabou@mozilla.com at Thu, 30 Jan 2020 08:38:29 +0000
Bug 1611777 - Part 4: `super` can't occur on the left-hand side of an optional chain. r=yulia Moves the `isSuper()` method from the base class to the (non-optional) derived classes, because `super?.x` isn't valid syntax, so it's confusing to be able to ask if an optional property access is applied on `super`. The next part will further simplify `BytecodeEmitter::emitDelete{Element,Property}InOptChain()`. Differential Revision: https://phabricator.services.mozilla.com/D61151