searching for reviewer(xidorn)
8dbca01bbc5ad22577f4d8cb5faae963f9611987: Bug 1673259 - Remove unused DeclarationBlock::get_at_importance. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 26 Oct 2020 09:58:31 +0000 - rev 554381
Push 129411 by ealvarez@mozilla.com at Mon, 26 Oct 2020 10:00:55 +0000
Bug 1673259 - Remove unused DeclarationBlock::get_at_importance. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D94693
3046e284b9e3c530d39babbecc7d27a4ddfd7fc4: Bug 1669858 - Use Option::as_deref() in style code. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 08 Oct 2020 09:42:49 +0000 - rev 552068
Push 128203 by ealvarez@mozilla.com at Thu, 08 Oct 2020 09:45:17 +0000
Bug 1669858 - Use Option::as_deref() in style code. r=xidorn And drive-by simplify another function that was only doing Option::clone(). Differential Revision: https://phabricator.services.mozilla.com/D92839
078dc5a036616ec84d5e567fd02536d1479817d5: Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Sep 2020 22:33:01 +0000 - rev 548628
Push 126309 by ealvarez@mozilla.com at Mon, 14 Sep 2020 22:35:35 +0000
Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn Adjust is-where-parsing.html to work with both the new and old behavior, and add a test for the new behavior. Depends on D90049 Differential Revision: https://phabricator.services.mozilla.com/D90050
c8a8791a26edfcd8789b1c3163f87f3a46ec46eb: Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Sep 2020 15:04:22 +0000 - rev 548558
Push 126255 by ealvarez@mozilla.com at Mon, 14 Sep 2020 15:06:57 +0000
Bug 1664718 - Allow :is() and :where() to have better error recovery. r=xidorn Adjust is-where-parsing.html to work with both the new and old behavior, and add a test for the new behavior. Depends on D90049 Differential Revision: https://phabricator.services.mozilla.com/D90050
da187b003f27fee651173cb7a458894aebbe4002: Bug 1664718 - Minor cleanup: Use shorthand initialization in selectors. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 13 Sep 2020 21:57:04 +0000 - rev 548484
Push 126212 by ealvarez@mozilla.com at Sun, 13 Sep 2020 22:04:55 +0000
Bug 1664718 - Minor cleanup: Use shorthand initialization in selectors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D90049
b021c9737f2bd71713c487ccb0410bd335edd5ba: Bug 1663231 - Make @font-face and @counter-style serialization closer other browsers and style rules. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 05 Sep 2020 00:42:43 +0000 - rev 547706
Push 125715 by ealvarez@mozilla.com at Sat, 05 Sep 2020 00:45:22 +0000
Bug 1663231 - Make @font-face and @counter-style serialization closer other browsers and style rules. r=xidorn Style rules serialize on one line and so should @font-face blocks. Part of https://github.com/w3c/csswg-drafts/issues/4828. Differential Revision: https://phabricator.services.mozilla.com/D89302
b3e160c2f1104ae303020ef5738f14dabda509c5: Bug 1585074 - Audit usage of nsIDocShellTreeItem in PendingFullscreenChangeList::Iterator::Iterator r=smaug,nika,xidorn
Alphan Chen <alchen@mozilla.com> - Tue, 01 Sep 2020 01:48:06 +0000 - rev 547143
Push 125407 by smacleod@mozilla.com at Tue, 01 Sep 2020 01:51:23 +0000
Bug 1585074 - Audit usage of nsIDocShellTreeItem in PendingFullscreenChangeList::Iterator::Iterator r=smaug,nika,xidorn Differential Revision: https://phabricator.services.mozilla.com/D85988
a0c3a76a1ed6be62c111d3cbbef5d10b7b407ed8: Bug 1658525- Remove layout.css.comparison-functions.enabled. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Aug 2020 10:27:42 +0000 - rev 544261
Push 123921 by ealvarez@mozilla.com at Tue, 11 Aug 2020 10:42:56 +0000
Bug 1658525- Remove layout.css.comparison-functions.enabled. r=xidorn Shipped since FF75 (bug 1519519). Differential Revision: https://phabricator.services.mozilla.com/D86693
2b85a2e15ba335df67dc7369e7eb7ec4265c49e3: Bug 1644212 - reintroduce an attribute to limit which windows allow full screen, r=xidorn,haik
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 15 Jun 2020 15:51:48 +0000 - rev 535717
Push 119036 by gijskruitbosch@gmail.com at Mon, 15 Jun 2020 16:02:30 +0000
Bug 1644212 - reintroduce an attribute to limit which windows allow full screen, r=xidorn,haik Differential Revision: https://phabricator.services.mozilla.com/D79109
234636bce5dc5d55705625bc7e0e0af0a286e104: Bug 1641861 - Remove some useless includes from Loader.h. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 May 2020 13:48:11 +0000 - rev 532984
Push 117498 by ealvarez@mozilla.com at Fri, 29 May 2020 13:49:29 +0000
Bug 1641861 - Remove some useless includes from Loader.h. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D77456
741feae54c0f0a339b32ba05b4f71dc50c830fc6: Bug 1640861 - Remove unused ServoElementSnapshot::mIsHTMLElementInHTMLDocument. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 May 2020 11:25:12 +0000 - rev 532167
Push 117036 by ealvarez@mozilla.com at Tue, 26 May 2020 11:57:12 +0000
Bug 1640861 - Remove unused ServoElementSnapshot::mIsHTMLElementInHTMLDocument. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D76820
1dc7cd341a2a1b5ffe08800b93f34c22ee3102a1: Bug 1580603 - Refactor Fullscreen stack to Top Layer stack r=smaug,xidorn
Sean Feng <sefeng@mozilla.com> - Tue, 14 Apr 2020 19:51:36 +0000 - rev 524027
Push 112965 by sefeng@mozilla.com at Wed, 15 Apr 2020 01:50:34 +0000
Bug 1580603 - Refactor Fullscreen stack to Top Layer stack r=smaug,xidorn Fullscreen stack isn't part of the spec anymore, it's changed to a more generic version called Top Layer stack, which is being used by both fullscreen APIs and dialog elements. This patch refactors it to Top Layer stack so that it can be reused for dialog element. Top Layer stack : https://fullscreen.spec.whatwg.org/#new-stacking-layer Differential Revision: https://phabricator.services.mozilla.com/D68478
53904ff833504681060ea25fcb9a30159c90a6f9: Bug 1614348 - Make font-family serialization algorithm a bit more conservative. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 12 Feb 2020 11:32:47 +0000 - rev 513541
Push 107075 by ealvarez@mozilla.com at Wed, 12 Feb 2020 11:33:18 +0000
Bug 1614348 - Make font-family serialization algorithm a bit more conservative. r=xidorn So as to avoid serializing as identifiers font-families with spaces as part of the identifier. This avoids serializing confusing escaped sequences if the beginning of the stuff after the space happens to not be a valid ident start. This is an slightly more restrictive version of the existing logic, which happens to also match other browsers in my testing. Differential Revision: https://phabricator.services.mozilla.com/D62376
fc3002cb85dc4d2c44d8aec1246f0356097411e3: Bug 1605803 - Use cbindgen for content property. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 05 Jan 2020 13:10:39 +0000 - rev 508850
Push 104246 by ealvarez@mozilla.com at Sun, 05 Jan 2020 13:11:35 +0000
Bug 1605803 - Use cbindgen for content property. r=xidorn This cleans up and also allows us to keep the distinction between content: none and content: normal, which allows us to fix the computed style we return from getComputedStyle(). Do this last bit from the resolved value instead of StyleAdjuster, because otherwise we need to tweak every initial struct for ::before / ::after. Differential Revision: https://phabricator.services.mozilla.com/D58276
8aa7aa72d2e0b94aaac17f334782d6c7a827ef92: Bug 1606019 - Remove unused FFI function to refcount nsIReferrerInfo. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Dec 2019 22:17:35 +0000 - rev 508412
Push 103960 by ealvarez@mozilla.com at Thu, 26 Dec 2019 22:24:29 +0000
Bug 1606019 - Remove unused FFI function to refcount nsIReferrerInfo. r=xidorn We don't use RefPtr<nsIReferrerInfo> in rust. Differential Revision: https://phabricator.services.mozilla.com/D58274
273abf200022ad239b277942149e6268c4fec8b2: Bug 1604011 - Remove dead assignment from StreamLoader::OnStopRequest. r=emilio,xidorn
Alex Henrie <alexhenrie24@gmail.com> - Sun, 15 Dec 2019 10:22:50 +0000 - rev 507037
Push 103227 by ealvarez@mozilla.com at Sun, 15 Dec 2019 10:23:36 +0000
Bug 1604011 - Remove dead assignment from StreamLoader::OnStopRequest. r=emilio,xidorn Differential Revision: https://phabricator.services.mozilla.com/D57235
27fdce12f0c57fce41191959117adf6dfeb4a0e6: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 13 Dec 2019 13:27:27 +0000 - rev 506914
Push 103142 by ealvarez@mozilla.com at Fri, 13 Dec 2019 13:28:41 +0000
Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug It's been enabled since Firefox 64. Differential Revision: https://phabricator.services.mozilla.com/D56951
d23f209ada8b57eb8211a64ac8d6fbbabdb8360b: Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 12 Dec 2019 19:56:10 +0000 - rev 506754
Push 103054 by ealvarez@mozilla.com at Thu, 12 Dec 2019 19:56:38 +0000
Bug 1603455 - Remove full-screen-api.unprefix.enabled. r=xidorn,smaug It's been enabled since Firefox 64. Differential Revision: https://phabricator.services.mozilla.com/D56951
e2df01b709f9ceed696ba3c89667588ae81ae81f: Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Nov 2019 20:30:42 +0000 - rev 501660
Push 100347 by ealvarez@mozilla.com at Tue, 12 Nov 2019 20:45:05 +0000
Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D51788
6cd92affba4253d7e60ba7dddcaa8a73dc913b2b: Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 12 Nov 2019 11:49:40 +0000 - rev 501581
Push 100297 by ealvarez@mozilla.com at Tue, 12 Nov 2019 15:53:42 +0000
Bug 1593951 - Use MaybeUninit in style struct clone impls / constructors. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D51788
97514cd3237ce93aca88458d53643b2ac551128e: Bug 1589766 - Experiment with implementing zoom as a transform + transform-origin shorthand. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 26 Oct 2019 14:17:28 +0000 - rev 499129
Push 98915 by ealvarez@mozilla.com at Sat, 26 Oct 2019 14:17:57 +0000
Bug 1589766 - Experiment with implementing zoom as a transform + transform-origin shorthand. r=xidorn This is a gross hack, of course, but has the advantage of not breaking sites that use both zoom and -moz-transform / -moz-transform-origin. There should be no behavior change when the pref is off, of course, and the webcompat team wanted to experiment with this. Differential Revision: https://phabricator.services.mozilla.com/D49792
430c949e8c7f60726088b70c38c452c32ecb7089: Bug 1588737 - Simplify media query code now that lifetimes are non-lexical. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 20 Oct 2019 13:44:07 +0000 - rev 498308
Push 98383 by ealvarez@mozilla.com at Sun, 20 Oct 2019 13:45:03 +0000
Bug 1588737 - Simplify media query code now that lifetimes are non-lexical. r=xidorn We can deindent and simplify a bunch of this code now. Differential Revision: https://phabricator.services.mozilla.com/D49509
14e9efe2db1d6b90593a5283302f4db98afc535d: Bug 1588737 - Remove useless conditional compilation. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 20 Oct 2019 13:44:09 +0000 - rev 498307
Push 98383 by ealvarez@mozilla.com at Sun, 20 Oct 2019 13:45:03 +0000
Bug 1588737 - Remove useless conditional compilation. r=xidorn Servo doesn't use this flag or -webkit- prefixed media queries, so no point in doing this conditionally. Differential Revision: https://phabricator.services.mozilla.com/D49508
673c2d3025c58a5307d3ecf2da7d500dbe2b16b2: Bug 1588737 - Hide -moz-touch-enabled media query in Nightly and Early Beta. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 20 Oct 2019 13:44:16 +0000 - rev 498305
Push 98383 by ealvarez@mozilla.com at Sun, 20 Oct 2019 13:45:03 +0000
Bug 1588737 - Hide -moz-touch-enabled media query in Nightly and Early Beta. r=xidorn This is effectively superseded by the hover / any-hover media queries, which actually are standard, and is also causing trouble in the wild. Not even the browser fronted uses it, so we should be able to just remove it everywhere at once. Differential Revision: https://phabricator.services.mozilla.com/D49506
119ad04b0efc030afcf10c153b4e86c863c8a96e: Bug 1588201 - Fix test_compute_data_with_start_struct.html to avoid leaving properties set around. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 13 Oct 2019 09:28:09 +0000 - rev 497375
Push 97848 by ealvarez@mozilla.com at Sun, 13 Oct 2019 09:28:47 +0000
Bug 1588201 - Fix test_compute_data_with_start_struct.html to avoid leaving properties set around. r=xidorn This is causing problems since leaving a non-default appearance changes margins and borders. This was wallpapered by XBL failing to load a binding and leaving the element without frame as described in the bug. Differential Revision: https://phabricator.services.mozilla.com/D49061
282af999790d429705b33cb936c5e99e36e26b38: Bug 1557825 part 2 - Add tests and update devtools for 'display:block ruby'. r=xidorn
Mats Palmgren <mats@mozilla.com> - Wed, 14 Aug 2019 14:38:33 +0000 - rev 487964
Push 92553 by mpalmgren@mozilla.com at Wed, 14 Aug 2019 15:21:55 +0000
Bug 1557825 part 2 - Add tests and update devtools for 'display:block ruby'. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D40213
06c5dcd34b3654fbc29024cda29cf805a37aa896: Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Aug 2019 18:15:37 +0000 - rev 487296
Push 92226 by ealvarez@mozilla.com at Sat, 10 Aug 2019 18:21:43 +0000
Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn Differential Revision: https://phabricator.services.mozilla.com/D41418
81b56d76505a3840150909fb33b18dd7ad3274e6: Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 10 Aug 2019 16:23:52 +0000 - rev 487291
Push 92222 by ealvarez@mozilla.com at Sat, 10 Aug 2019 17:39:57 +0000
Bug 1572805 - Simplify text-emphasis-style. r=boris,xidorn Differential Revision: https://phabricator.services.mozilla.com/D41418
3415f556123b167f1bcde81e76d18037db3b2cb7: Bug 1554433 - Move system colors to values::specified::color. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 26 May 2019 13:10:00 +0000 - rev 475616
Push 86388 by ealvarez@mozilla.com at Sun, 26 May 2019 13:11:02 +0000
Bug 1554433 - Move system colors to values::specified::color. r=xidorn This should be an idempotent patch. The way to come up with this patch has been: * Run the first script attached to the bug and pipe it to xclip, then paste it in color.rs * Add the relevant #[derive] annotations and remove the color.mako.rs definition. * Reorder the values to match the ColorID definition, on which some widget prefs and caching stuff relies on. * Manually port some documentation from nsLookAndFeel.h * Run `rg 'eColorID_' | cut -d : -f 1 | sort | uniq >files` * Run the second script attached to the bug. * Manually fix usage of `LAST_COLOR` (adding the `End` variant), and adding casts to integer as needed. * Add an static assert so that people remember to update the prefs, rather than a comment on the definition :) Differential Revision: https://phabricator.services.mozilla.com/D32610
4001e13c51f497ad84815bdc01849b60eb2fd3be: Bug 1554405 - Pass old style again to StartImageLoads. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 26 May 2019 08:36:46 +0000 - rev 475606
Push 86386 by ealvarez@mozilla.com at Sun, 26 May 2019 09:32:53 +0000
Bug 1554405 - Pass old style again to StartImageLoads. r=xidorn This was accidentally regressed by bug 1528451. Differential Revision: https://phabricator.services.mozilla.com/D32569
d7a7edbebd6a08f22d78b5c86b2f2d4573eb77dd: Bug 1552628 - Remove some more dead nsCSSValue code. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 19 May 2019 00:47:18 +0000 - rev 474463
Push 85821 by ealvarez@mozilla.com at Sun, 19 May 2019 00:48:51 +0000
Bug 1552628 - Remove some more dead nsCSSValue code. r=xidorn Most of it is not used at this point, this leaves the parts that are used by MathML, which are minimal. Differential Revision: https://phabricator.services.mozilla.com/D31706
c58def4246acd844cda042938d426a35320eafba: Bug 1546499: Downgrade nsVideoFrame's unexpected-child assertion. r=xidorn
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 23 Apr 2019 20:28:52 +0000 - rev 471797
Push 84278 by dholbert@mozilla.com at Mon, 29 Apr 2019 17:50:38 +0000
Bug 1546499: Downgrade nsVideoFrame's unexpected-child assertion. r=xidorn Also, make the assertion shorter & more to the point. In particular, I'm removing the note about stray whitespace, which is based on one previous scenario that caused extra child frames; but I don't have much confidence that potential future causes of this assertion-failure will have that specific problem as their root cause. Differential Revision: https://phabricator.services.mozilla.com/D28547
4b227d4b337729892521aaa72cd00f3ef0f75590: Bug 1543808 - Refactor the selector parser to make implementing ::part() easier. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Apr 2019 13:16:56 +0000 - rev 469678
Push 83283 by ealvarez@mozilla.com at Tue, 16 Apr 2019 13:18:39 +0000
Bug 1543808 - Refactor the selector parser to make implementing ::part() easier. r=xidorn ::slotted() is already weird in the sense that it supports a pseudo-element afterwards (so ::slotted(*)::before is valid for example). ::part() is weirder because you are supposed to allow stuff like ::part(foo):hover, ::part(foo):hover::before, etc. In order to avoid making the already-complex parse_compound_selector more complex, shuffle stuff so that we pass the progress of our current compound selector around, and is the parsing code for each selector which decides whether it's ok to parse at the given point. Differential Revision: https://phabricator.services.mozilla.com/D27158
4a73ab981c299d02c3107ace8744e2fcd7c34c5c: Bug 1536584 - Remove bindings.rs. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Mar 2019 18:15:47 +0000 - rev 466158
Push 81466 by ealvarez@mozilla.com at Tue, 26 Mar 2019 18:32:31 +0000
Bug 1536584 - Remove bindings.rs. r=xidorn I kept it building the most straight-forward way possible (pub use) because it seems to me that bindings is not a bad name, and we should probably move structs.rs to be bindings.rs rather than the other way around. But that's a different bug in any case, need to think more about it. Differential Revision: https://phabricator.services.mozilla.com/D24713
7bd834c5800c93f54df331311d726dc571813d7b: Bug 1536584 - Remove bindings.rs. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Mar 2019 13:38:14 +0000 - rev 466099
Push 81442 by ealvarez@mozilla.com at Tue, 26 Mar 2019 13:42:36 +0000
Bug 1536584 - Remove bindings.rs. r=xidorn I kept it building the most straight-forward way possible (pub use) because it seems to me that bindings is not a bad name, and we should probably move structs.rs to be bindings.rs rather than the other way around. But that's a different bug in any case, need to think more about it. Differential Revision: https://phabricator.services.mozilla.com/D24713
0d33ffb859fa4e1ea031c3b2cb3274d71d66a0d5: Bug 1215878 - Optimize cascading of other wide keywords if possible. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 07 Mar 2019 12:48:07 +0000 - rev 462886
Push 79894 by ealvarez@mozilla.com at Thu, 07 Mar 2019 13:01:12 +0000
Bug 1215878 - Optimize cascading of other wide keywords if possible. r=xidorn The way the copy-on-write stuff works, and the way that we have to apply properties from most specific to less specific guarantees that always that we're going to inherit an inherited property, or reset a reset property, we have already the right value on the style. Revert relies on that, so there doesn't seem to be a reason to not use that fact more often and skip useless work earlier. Font-size is still special of course... I think I have a way to move the specialness outside of the style, but piece by piece. Differential Revision: https://phabricator.services.mozilla.com/D21882
9506816277411c422b23f1b74b2e058dda615d6d: Bug 1532134 - Remove Options from TransformOperation. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:54 +0000 - rev 462193
Push 79480 by ealvarez@mozilla.com at Sun, 03 Mar 2019 11:33:31 +0000
Bug 1532134 - Remove Options from TransformOperation. r=xidorn This may or may not be part of the plan to get rid of nsCSSValue ;) Option is not usable via FFI, and they should not be needed (we should be following the shortest serialization principle instead). These patches also do that, which matches the other transform properties. I think that slight change is fine, if we can make it work, and consistent with other properties. Alternative is adding more TransformOperation variants or such, which I rather not do. Differential Revision: https://phabricator.services.mozilla.com/D21862
2b811ffbed9b8b4c71092e90cbb11201c8d9a7c6: Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:40 +0000 - rev 462192
Push 79480 by ealvarez@mozilla.com at Sun, 03 Mar 2019 11:33:31 +0000
Bug 1532134 - Use contextual_skip_if for background-size. r=xidorn Also drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21861
5a4a2f2465b0142e901d52f1850c2fc1a6e0cc6b: Bug 1532134 - Use skip_if for translate serialization. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:30 +0000 - rev 462191
Push 79480 by ealvarez@mozilla.com at Sun, 03 Mar 2019 11:33:31 +0000
Bug 1532134 - Use skip_if for translate serialization. r=xidorn Trivial drive-by cleanup. Differential Revision: https://phabricator.services.mozilla.com/D21860
7aa72a6aa1b501c6f7a0efc7a4a4ea14d15f0030: Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:21 +0000 - rev 462190
Push 79480 by ealvarez@mozilla.com at Sun, 03 Mar 2019 11:33:31 +0000
Bug 1532134 - When deriving something with an output type, map preconditions as well. r=xidorn Otherwise, deriving ToComputedValue and ToAnimatedValue in structs or enums with other where clauses just doesn't work. Differential Revision: https://phabricator.services.mozilla.com/D21859
b5dec9e96f42cd166b4cdaf70b6765be34454aae: Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Mar 2019 11:31:06 +0000 - rev 462189
Push 79480 by ealvarez@mozilla.com at Sun, 03 Mar 2019 11:33:31 +0000
Bug 1532134 - Implement a version of #[css(skip_if)] that takes more context. r=xidorn I called it contextual_skip_if, though better names welcome. Differential Revision: https://phabricator.services.mozilla.com/D21858
65ed1a6835b990ddbe99d34279ab2240515c91dc: Bug 1528299 - Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Feb 2019 11:05:30 +0000 - rev 460063
Push 78548 by ealvarez@mozilla.com at Wed, 20 Feb 2019 11:09:16 +0000
Bug 1528299 - Make InspectorUtils.getCSStyleRules return a proper CSSStyleRule sequence. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D20456
7d4f1afbf5f20a2767b2bdee6536b942dd440c65: Bug 1528035 - Improve #[derive(Parse)]. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Feb 2019 20:45:10 +0100 - rev 459902
Push 78459 by emilio@crisal.io at Tue, 19 Feb 2019 14:30:21 +0000
Bug 1528035 - Improve #[derive(Parse)]. r=xidorn I want to do this so that I can get rid of Either<>. The reasons for getting rid of either is multiple: * It doesn't generate as nice C++ code using cbindgen. * It isn't that nice to use either from Rust. * cbindgen has bugs with zero-sized types. I started using this for ColorOrAuto and a few others, for now. Differential Revision: https://phabricator.services.mozilla.com/D19844
96fd408e650f21a4d63ea3ff09f9a3bc25676360: Bug 1524328 - Pass a document instead of a pres context to FinishStyle. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Feb 2019 19:42:25 +0100 - rev 456594
Push 77353 by emilio@crisal.io at Sun, 03 Feb 2019 02:06:41 +0000
Bug 1524328 - Pass a document instead of a pres context to FinishStyle. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D18491
43a3aa2199c12427c9784a9cdbb89f76cf1296a5: Bug 1524328 - Don't resolve counter styles in the style system. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 02 Feb 2019 19:41:44 +0100 - rev 456593
Push 77353 by emilio@crisal.io at Sun, 03 Feb 2019 02:06:41 +0000
Bug 1524328 - Don't resolve counter styles in the style system. r=xidorn Doing it during layout instead. This also has the nice side-effect of no longer needing to do a full restyle when counter-style rules are inserted. Differential Revision: https://phabricator.services.mozilla.com/D18343
fb705f84a7921bd5a77108b99e2ffab51a53c09b: Bug 1519006 - Stop null checking infallible style sheet accessors in nsDocumentViewer::CreateStyleSet r=xidorn
Cameron McCormack <cam@mcc.id.au> - Fri, 11 Jan 2019 03:12:28 +0000 - rev 453396
Push 75841 by cmccormack@mozilla.com at Fri, 11 Jan 2019 03:14:38 +0000
Bug 1519006 - Stop null checking infallible style sheet accessors in nsDocumentViewer::CreateStyleSet r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16151
45d4ae4551a1e07cb5fa97d8405e6f9badcf7554: Bug 1519001 - Rename some style sheet accessors on nsLayoutStylesheetCache to indicate they can return null r=xidorn
Cameron McCormack <cam@mcc.id.au> - Fri, 11 Jan 2019 03:12:05 +0000 - rev 453395
Push 75840 by cmccormack@mozilla.com at Fri, 11 Jan 2019 03:13:50 +0000
Bug 1519001 - Rename some style sheet accessors on nsLayoutStylesheetCache to indicate they can return null r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16150
a5450f478cd96e5f552a37d6f89c63e671958bdd: Bug 1518992 - Remove unnecessary mem::transmute in MediaListKey r=xidorn
Cameron McCormack <cam@mcc.id.au> - Thu, 10 Jan 2019 06:01:03 +0000 - rev 453340
Push 75822 by cmccormack@mozilla.com at Thu, 10 Jan 2019 21:21:32 +0000
Bug 1518992 - Remove unnecessary mem::transmute in MediaListKey r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D16147
af22225148f7cb57718a9b3f4428d57ba93f6842: Bug 1516365 - Update the Rust target version for bindgen. r=xidorn
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 25 Dec 2018 23:09:29 +0000 - rev 451940
Push 75255 by ealvarez@mozilla.com at Tue, 25 Dec 2018 23:10:24 +0000
Bug 1516365 - Update the Rust target version for bindgen. r=xidorn This brings us alignas support and also associated constants for bitfield enums. Differential Revision: https://phabricator.services.mozilla.com/D15334
6ced915a7d2d241979c9df61b7d42cba0de38c88: Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color r=xidorn
Cameron McCormack <cam@mcc.id.au> - Tue, 18 Dec 2018 09:39:07 +0000 - rev 451209
Push 74940 by cmccormack@mozilla.com at Tue, 18 Dec 2018 21:03:02 +0000
Bug 1512597 - Resolve currentcolor in fill and stroke against visited-dependent color r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D14706