Bug 1238305: Modify cppunittests to look up breakpad symbols for logged stack traces; r=ted

Bug 1528854 - Change updater-xpcshell.exe and TestAUSHelper.exe so they use subsystem windows applications in opt builds. r=firefox-build-system-reviewers,ted. This makes it easier to locally run tests in the background Differential Revision: https://phabricator.services.mozilla.com/D20789

Bug 1528648 - Update Rust dependencies. r=ted Differential Revision: https://phabricator.services.mozilla.com/D20106

Bug 1527016, Don't install nasm on Linux if it is already installed locally, r=ted

Bug 1528884 - Change how --enable-eme is handled. r=ted It used to be that --enable-eme on its own had some effect, but that's not the case anymore. The only thing it does as of bug 1300654 is to switch the defaults in the Firefox configuration. Reflect that in how we handle --enable-eme. Differential Revision: https://phabricator.services.mozilla.com/D20270

Bug 1528860 - Synchronize artifact command --job options with artifacts.JOB_DETAILS. r=ted Differential Revision: https://phabricator.services.mozilla.com/D20227

Bug 1528499 - Don't PGO the base-toolchain tasks on release branches. r=ted Differential Revision: https://phabricator.services.mozilla.com/D20080

Bug 1528304 - Update max memory recording regions. r=ted Differential Revision: https://phabricator.services.mozilla.com/D19960

Bug 1511224 - Add win64-nasm toolchain. r=ted,jya,glandium Differential Revision: https://phabricator.services.mozilla.com/D13875

Bug 1511224 - Add win64-nasm toolchain. r=ted,jya,glandium Differential Revision: https://phabricator.services.mozilla.com/D13875

Bug 1472589 - Fix parent process crash reporting in the Snap package environment. r=ted,jlorenzo 1. The unsetting of LD_LIBRARY_PATH is removed, because it's no longer necessary and interferes with environments where it's necessary to find "system" libraries like GTK; see bug 1472589 comment #1 through #4. 2. The Snap package manifest adds a dependency on the libcurl package, so that the crash reporter can send the report. This uses the GnuTLS variant because we're already pulling in GnuTLS as a dependency of some other packages (FFmpeg and CUPS, but also the non-GnuTLS cURL packages depend on it anyway via OpenLDAP). Differential Revision: https://phabricator.services.mozilla.com/D18625

Bug 1526497 - Always get clang information for bindgen. r=ted When the build system compiler is clang, and bindgen autodetection actually finds a different clang via llvm-config, or a different clang was given with --with-clang-path, we do want the proper flags to be used for that clang, so we always get the right flags for that clang instead of trying to shortcut. Bug 1526857 will take care of making things more proper, while this is a quick fix to unbreak builds in some unfortunately common kind of local setups. Differential Revision: https://phabricator.services.mozilla.com/D19328

Bug 1526505 - Update mozharness stats parsing code for per-language stats. r=firefox-build-system-reviewers,ted Differential Revision: https://phabricator.services.mozilla.com/D19247

Bug 1525733 - Require rust 1.32 to build. r=firefox-build-system-reviewers,ted Differential Revision: https://phabricator.services.mozilla.com/D19244

Bug 1428706 - [mozcrash] Add support for Python 3; r=ted Differential Revision: https://phabricator.services.mozilla.com/D19132

Bug 1525638 - Let hg ignore the build directories of WebRender standalone builds. r=ted Differential Revision: https://phabricator.services.mozilla.com/D18852

Bug 1522609 - Pass compilers and flags down to cargo on sanitizer/fuzzying/ccov builds. r=ted Depends on D18280 Differential Revision: https://phabricator.services.mozilla.com/D18281

Bug 1522609 - Pass HOST_CC/HOST_CXX/HOST_CFLAGS/HOST_CXXFLAGS down to cargo. r=ted While this isn't related to the bug, since we're going to touch the cargo compiler flags, we might as well do this too. It wasn't previously reliable to pass those flags down because what cargo uses as target for build scripts and procedural macros is determined by the rust host, which was not necessarily the same as the build system host. But as of bug 1523143, they are always the same. Differential Revision: https://phabricator.services.mozilla.com/D18280

Bug 1519353 - Import minidump_stackwalk changes from https://hg.mozilla.org/users/tmielczarek_mozilla.com/stackwalk-http. r=ted Differential Revision: https://phabricator.services.mozilla.com/D16300

Bug 1518947 - Update breakpad to revision 44384d80b32a5bb361c2ec3bee667f7ccee566d7 r=ted This includes some assorted fixes from upstream plus an adaptation of the patch in b988fa74ec18de6214b18f723e48331d9a7802ae which includes heap memory regions in the minidump. Since our support for that is more extensive than upstream breakpad the resulting change reflects this. Last but not least the fixes for bug 1489094 and bug 1511140 were split out as patches to be applied to the unmodified breakpad sources. They will be reintegrated as soon as we fork breakpad for good. Differential Revision: https://phabricator.services.mozilla.com/D16326

Bug 1524194 - Do not add stack pointer to clobber list r=ted Cherry-pick upstream patch to address a build issue with gcc 9 https://chromium.googlesource.com/linux-syscall-support/+/8048ece6c16c91acfe0d36d1d3cc0890ab6e945c Differential Revision: https://phabricator.services.mozilla.com/D18284

Bug 1524186 - Disable clang plug on Windows rusttest builds. r=ted Like bug 1505072 did on other platforms. The rust tests don't go through the whole build system, and even when the clang plugin is enabled, they don't build it. So when passing compiler flags down through cargo, the arguments enabling the plugin are passed, and compilation of C/C++ code from cargo subsequently fails. Differential Revision: https://phabricator.services.mozilla.com/D18178

Bug 1523540 - Remove WIN64_LIB and WIN64_LINK. r=ted Now that everything is lined up nicely, we don't need those anymore. We can fill cargo-linker.bat with HOST_LINKER and HOST_LINKER_LIBPATHS, which, unfortunately, can't be used as is, so we add a variant for substitution in .bat files. Differential Revision: https://phabricator.services.mozilla.com/D18034

Bug 1522735 - Set enable_sslkeylogfile for NSS gyp build r=firefox-build-system-reviewers,erahm,ted NSS 3.42 added a new build flag, enable_sslkeylogfile, to toggle the availability of the SSLKEYLOGFILE variable (see Bug 1515236 and Bug 1519209). Differential Revision: https://phabricator.services.mozilla.com/D17588

Bug 1315935 - Remove the NumberOfProcessors crash annotation because it is redundant r=ted Differential Revision: https://phabricator.services.mozilla.com/D16688

Bug 1510574 - Remove shared memory segments from generated minidumps to cut down on the number of modules r=ted Differential Revision: https://phabricator.services.mozilla.com/D16188

Bug 1515579 - Use absolute paths for compilers, etc. r=ted In bug 1259382, some workarounds were added to make the build system alter PATH and not use absolute paths for toolchain programs, because autoconf and the build system doesn't deal with spaces in those very well. But later in bug 1290040, we made find_program return Windows short paths (without spaces), which alleviates the need for those workarounds. We still, however, and unfortunately, need to alter PATH to account for the fact that MSVC DLLs are not necessarily alongside the compiler executables... Depends on D15181 Differential Revision: https://phabricator.services.mozilla.com/D15182

Bug 1515579 - Add some mk_export_correct_style to win64-aarch64 mozconfig. r=ted Like for other windows platforms. This currently doesn't make a difference, but will with next change. Differential Revision: https://phabricator.services.mozilla.com/D15181

Bug 1519042 - Remove OS_TEST. r=ted Depends on D16162 Differential Revision: https://phabricator.services.mozilla.com/D16163

Bug 1519042 - Replace the last non-third-part uses of OS_TEST with TARGET_CPU. r=ted Depends on D16161 Differential Revision: https://phabricator.services.mozilla.com/D16162

Bug 1519042 - Remove special case adding -xgot assembly flag on NetBSD. r=ted None of the values tested against OS_TEST are actually possible per split_triplet in build/moz.configure/init.configure, so the code is dead in practice. Differential Revision: https://phabricator.services.mozilla.com/D16161

Bug 1518703 - Remove R_386_PC32 check. r=froydnj,ted The test is actually redundant with the TEXTREL check in check_binary.py (R_386_PC32 relocations will only happen as text relocations) Differential Revision: https://phabricator.services.mozilla.com/D16002

Bug 1517730 - Enable the crash reporter by default on Windows/AArch64 builds r=ted Differential Revision: https://phabricator.services.mozilla.com/D15763

Bug 1496190 - Add |mach package-multi-locale|; produce multi-locale GeckoView archives. r=Callek,firefox-build-system-reviewers,ted All that is really required for this ticket is to invoke |mach android archive-geckoview| after |mach package| in the right place. But it's actively unhelpful to have this magic in mozharness -- especially since the documentation in `locales.rst` is subtly incorrect (the environment variables and Make variables don't quite work as written). So this commit adds a Mach command to do the actual work and replaces most of the mozharness magic with that command. Since the l10n Make targets check out the l10n HG repositories locally, this basically Just Works without the mozharness checkout steps when developing locally. Differential Revision: https://phabricator.services.mozilla.com/D12455

Bug 1492664 - use {artifact-reference: ..} for symbol uploads; r=ted

Bug 1515579 - Use absolute paths for compilers, etc. r=ted In bug 1259382, some workarounds were added to make the build system alter PATH and not use absolute paths for toolchain programs, because autoconf and the build system doesn't deal with spaces in those very well. But later in bug 1290040, we made find_program return Windows short paths (without spaces), which alleviates the need for those workarounds. We still, however, and unfortunately, need to alter PATH to account for the fact that MSVC DLLs are not necessarily alongside the compiler executables... Depends on D15181 Differential Revision: https://phabricator.services.mozilla.com/D15182

Bug 1515579 - Add some mk_export_correct_style to win64-aarch64 mozconfig. r=ted Like for other windows platforms. This currently doesn't make a difference, but will with next change. Differential Revision: https://phabricator.services.mozilla.com/D15181

Bug 1515843 - Remove HOST_AR/HOST_RANLIB. r=ted Now that we're not even building host static libraries, we don't need variables for the tools used to build them. Ironically, we weren't even running HOST_RANLIB. Depends on D15172 Differential Revision: https://phabricator.services.mozilla.com/D15173

Bug 1515843 - Stop building host static libraries. r=ted The build system has skipped creating target static libraries for very long, except in very specific cases. We can actually do the same for host static libraries, for which we don't even need the escape hatch to still allow to create static libraries. Depends on D15171 Differential Revision: https://phabricator.services.mozilla.com/D15172

Bug 1515843 - Use the raw OBJ_SUFFIX for host objects. r=ted OBJ_SUFFIX is modified during the profile-generation phase to be i_o instead of o/obj. _OBJ_SUFFIX is the unmodified value. We don't actually do PGO for host objects, so we don't need to build the objects with a different suffix. Differential Revision: https://phabricator.services.mozilla.com/D15171

Bug 1515577 - Don't quote shell strings when they contain a ~, except in first position. r=ted We only need to quote strings that would be treated specially by the shell, and "foo~bar" doesn't get any sort of expansion, while "~foo" gets a user expansion, and to avoid that expansion, those latter strings need to be quoted, but not the former. Differential Revision: https://phabricator.services.mozilla.com/D15065

Bug 1515550 - Search all MSVC products for the compiler components. r=ted vswhere only searches in Community, Professional and Enterprise, but one can also install BuildTools only, which has a different product name. Differential Revision: https://phabricator.services.mozilla.com/D15056

Bug 1515577 - Don't quote shell strings when they contain a ~, except in first position. r=ted We only need to quote strings that would be treated specially by the shell, and "foo~bar" doesn't get any sort of expansion, while "~foo" gets a user expansion, and to avoid that expansion, those latter strings need to be quoted, but not the former. Differential Revision: https://phabricator.services.mozilla.com/D15065

Bug 1492664 - use {artifact-reference: ..} for symbol uploads; r=ted

Bug 1515257 - Move --with-system-libvpx to python configure. r=firefox-build-system-reviewers,ted Depends on D14951 Differential Revision: https://phabricator.services.mozilla.com/D14952

Bug 1515257 - Add a check_symbol function that checks whether a symbol can be linked against. r=firefox-build-system-reviewers,ted Depends on D14950 Differential Revision: https://phabricator.services.mozilla.com/D14951

Bug 1515257 - Add a try_run method more generic than try_compile. r=firefox-build-system-reviewers,ted It will be useful to run tests like try_compile, with different flags and different kinds of sources. Depends on D14949 Differential Revision: https://phabricator.services.mozilla.com/D14950

Bug 1515257 - Add onerror argument to check_header(). r=firefox-build-system-reviewers,ted Depends on D14948 Differential Revision: https://phabricator.services.mozilla.com/D14949

Bug 1515257 - Remove VPX_AS_CONVERSION. r=firefox-build-system-reviewers,ted There's only really one place where it's used, and we can "inline" it there. Depends on D14947 Differential Revision: https://phabricator.services.mozilla.com/D14948

Bug 1515257 - Don't pretend there are ARM assembly sources in libaom. r=firefox-build-system-reviewers,ted There aren't any, and the code to actually convert them from .asm to gas that is expected by the moz.build is not even there, so if there were assembly sources, it would fail to build. Depends on D14946 Differential Revision: https://phabricator.services.mozilla.com/D14947