searching for reviewer(smaug)
8e7ad47f1222b6900d006573276e582b7de9cad9: Bug 1813437 - Change a slow MOZ_DIAGNOSTIC_ASSERT to a MOZ_ASSERT r=smaug
Paul Bone <pbone@mozilla.com> - Tue, 31 Jan 2023 02:08:38 +0000 - rev 651032
Push 177477 by pbone@mozilla.com at Tue, 31 Jan 2023 02:14:07 +0000
Bug 1813437 - Change a slow MOZ_DIAGNOSTIC_ASSERT to a MOZ_ASSERT r=smaug Differential Revision: https://phabricator.services.mozilla.com/D168230
332ac58bdc953174adba6fee4980192962674dfa: Bug 1813856 - Update BUG_COMPONENT in xpcom/base to use the new component for nsCycleCollect* files. r=smaug DONTBUILD
Andrew McCreight <continuation@gmail.com> - Tue, 31 Jan 2023 00:50:14 +0000 - rev 651031
Push 177476 by amccreight@mozilla.com at Tue, 31 Jan 2023 01:19:54 +0000
Bug 1813856 - Update BUG_COMPONENT in xpcom/base to use the new component for nsCycleCollect* files. r=smaug DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D168320
a5f44f564e04e8a4ac98c6c82861000a605233eb: Bug 1813507 - Remove mPendingDocShellBlockers, r=smaug
Artur Iunusov <aiunusov@mozilla.com> - Mon, 30 Jan 2023 19:55:47 +0000 - rev 651017
Push 177463 by opettay@mozilla.com at Mon, 30 Jan 2023 20:01:17 +0000
Bug 1813507 - Remove mPendingDocShellBlockers, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D168272
58172efe03db176c62202e391a434b61179d4ff3: Bug 1689565 - Part 3: Migrate removed tests r=dom-worker-reviewers,smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 30 Jan 2023 12:50:52 +0000 - rev 650960
Push 177421 by krosylight@mozilla.com at Mon, 30 Jan 2023 13:43:59 +0000
Bug 1689565 - Part 3: Migrate removed tests r=dom-worker-reviewers,smaug Ported most of the removed tests from D167236, except the payload test because of a misbehavior regarding to icon URL parsing (and thus fails on Chrome if ported as-is). It's still covered in dom/serviceworkers/test/test_notification_get.html, so skipping it does not decrease the coverage. Differential Revision: https://phabricator.services.mozilla.com/D167943
1de4e44dab9272c4b5ae5ddf107e5166b8beb314: Bug 1723838 - WebIDL bindings for the 'dns' WebExtensions API namespace. r=willdurand,webidl,smaug
Luca Greco <lgreco@mozilla.com> - Fri, 27 Jan 2023 20:33:25 +0000 - rev 650872
Push 177362 by luca.greco@alcacoop.it at Fri, 27 Jan 2023 20:38:52 +0000
Bug 1723838 - WebIDL bindings for the 'dns' WebExtensions API namespace. r=willdurand,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167594
2a4428926a4995fa3f4c5fad1caaf78af51b2217: Bug 1811939 - Check whether module load request was already cancelled when a load fails r=smaug
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 27 Jan 2023 17:19:57 +0000 - rev 650832
Push 177339 by rvandermeulen@mozilla.com at Fri, 27 Jan 2023 17:22:01 +0000
Bug 1811939 - Check whether module load request was already cancelled when a load fails r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167927
7ce68cf17f92c9bbe21b5da6fb896c4dbfc24d8c: Bug 1811863 - Make WorkerNavigator use more precise RFP check. r=dom-worker-reviewers,smaug
Tom Schuster <tschuster@mozilla.com> - Fri, 27 Jan 2023 14:08:58 +0000 - rev 650817
Push 177329 by tschuster@mozilla.com at Fri, 27 Jan 2023 14:11:51 +0000
Bug 1811863 - Make WorkerNavigator use more precise RFP check. r=dom-worker-reviewers,smaug This refactors the code to be closer to the main-thread Navigator implementation, but the new CallerType and old workerPrivate->UsesSystemPrincipal() is functionally identical. Differential Revision: https://phabricator.services.mozilla.com/D167821
4f13d8470d97b03bbae0637a06c8006cdf3a3aad: Bug 1806501 - Start the JS Oracle process early. r=smaug
Andreas Farre <farre@mozilla.com> - Fri, 27 Jan 2023 09:17:17 +0000 - rev 650786
Push 177308 by afarre@mozilla.com at Fri, 27 Jan 2023 09:20:25 +0000
Bug 1806501 - Start the JS Oracle process early. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167230
67775732c1a898489f6a6715f0eb5d123cbbb44c: Bug 1812035 - Fix broken about:memory tests. r=smaug
Andreas Farre <farre@mozilla.com> - Fri, 27 Jan 2023 09:17:16 +0000 - rev 650784
Push 177308 by afarre@mozilla.com at Fri, 27 Jan 2023 09:20:25 +0000
Bug 1812035 - Fix broken about:memory tests. r=smaug Tests for about:memory doesn't know about utility processes. Make sure to hide the utility process reporter when needed, and count the number of living processes, also when needed. Differential Revision: https://phabricator.services.mozilla.com/D167662
e001f4e845a43564f0588adee16baf8044c74fcb: Bug 822734 - Make `HTMLTextAreaElement` handle the mutation changes after all ranges handle them r=smaug
Masayuki Nakano <masayuki@d-toybox.com> - Fri, 27 Jan 2023 04:56:55 +0000 - rev 650773
Push 177301 by masayuki@d-toybox.com at Fri, 27 Jan 2023 05:02:29 +0000
Bug 822734 - Make `HTMLTextAreaElement` handle the mutation changes after all ranges handle them r=smaug A mutation caused by a call of `Text::SplitText` is handled by 2 method calls, `CharacterDataChanged` and `ContentInserted`, in `nsRange`. Therefore, `nsRange` stores some nodes for the later one, but `HTMLTextAreaElement::ContentInserted` is called before it and that causes another mutation which causes calling `nsRange::CharacterDataChanged` again. Therefore, the assertion detects the recursive call. For avoiding this issue, `HTMLTextAreaElement` needs to wait that all ranges handle the mutation first. Fortunately, `ContentInserted` is called with a script blocker (*1). Therefore, `HTMLTextAreaElement` can use script runner to reset the anonymous subtree. 1. https://searchfox.org/mozilla-central/rev/f1dc2743777711c821d43f9911ee7c4447d60c8e/dom/base/nsINode.cpp#1566,1610 Differential Revision: https://phabricator.services.mozilla.com/D167766
4fd7b9c658f23bcd0167eaf43165036a6beb52f5: Bug 1812828: Use AutoTArray for local arrays in ChildCommandDispatcher. r=smaug
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 27 Jan 2023 01:33:28 +0000 - rev 650763
Push 177293 by dholbert@mozilla.com at Fri, 27 Jan 2023 01:36:44 +0000
Bug 1812828: Use AutoTArray for local arrays in ChildCommandDispatcher. r=smaug This patch doesn't change user-visible behavior. The AutoTArray size that I'm using, 70, comes from the maximum values that I observed for these arrays, during a local run of Speedometer 3 on Linux. The largest 'disabledCommands' array that I encountered had length 70 (and this was the most common length that this array had); while the largest 'enabledCommands' array was only a bit smaller, with a length of 62. Differential Revision: https://phabricator.services.mozilla.com/D168016
ea9b2ad4d519447058c257e55526c3273df281f4: Bug 1811567: Test updates for RFP precision restriction updates r=smaug
Tom Ritter <tom@mozilla.com> - Thu, 26 Jan 2023 17:01:36 +0000 - rev 650699
Push 177248 by tritter@mozilla.com at Thu, 26 Jan 2023 17:07:25 +0000
Bug 1811567: Test updates for RFP precision restriction updates r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167826
a84bc3fe9d6317c4750e1e3b84fd261f87470668: Bug 1811567: Remove unnecessary restrictions on APIs when RFP is enabled r=smaug
Tom Ritter <tom@mozilla.com> - Thu, 26 Jan 2023 17:01:35 +0000 - rev 650698
Push 177248 by tritter@mozilla.com at Thu, 26 Jan 2023 17:07:25 +0000
Bug 1811567: Remove unnecessary restrictions on APIs when RFP is enabled r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167444
55680d666baa4dfc0a6b09a788a3e839d2632ff4: Bug 1773760 - part 6: remove the TokenBindingStatus enum. r=webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:36 +0000 - rev 650673
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 6: remove the TokenBindingStatus enum. r=webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167751
35f1aa6782f2c93b1cfe6de20edb20baaebf17f3: Bug 1773760 - part 5: remove the AuthenticatorTransport enum. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:35 +0000 - rev 650672
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 5: remove the AuthenticatorTransport enum. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167750
3c4258bfcc1e72298a71b1e464b5a9a022c6b440: Bug 1773760 - part 4: make PublicKeyCredentialType a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:35 +0000 - rev 650671
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 4: make PublicKeyCredentialType a DOMString. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167749
43bae636e48c247587d03fcf4b8ebaac1aa8430b: Bug 1773760 - part 3: make UserVerificationRequirement a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:35 +0000 - rev 650670
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 3: make UserVerificationRequirement a DOMString. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167748
2effc5a02677e5b80f5d54829b30f43e59cb9b36: Bug 1773760 - part 2: make AttestationConveyancePreference a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:34 +0000 - rev 650669
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 2: make AttestationConveyancePreference a DOMString. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167747
add0d611bf3a667415af119e2f09ed9b8c80d785: Bug 1773760 - part 1: make AuthenticatorAttachment a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Thu, 26 Jan 2023 15:36:34 +0000 - rev 650668
Push 177238 by jschanck@mozilla.com at Thu, 26 Jan 2023 15:47:44 +0000
Bug 1773760 - part 1: make AuthenticatorAttachment a DOMString. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167746
1432fd8955ce7ee78eab40753eb15ee274045919: Bug 1810614 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Jan 2023 12:48:22 +0000 - rev 650655
Push 177225 by ealvarez@mozilla.com at Thu, 26 Jan 2023 12:51:06 +0000
Bug 1810614 - Simplify AppWindow::SizeShellTo when sizing to the window shell. r=smaug In this case we can do easier things than going through the shell and assuming all sizes go through the window. Depends on D167027 Differential Revision: https://phabricator.services.mozilla.com/D166367
2c05658add65ba2f7513b2a76fe32be80c7c86e6: Bug 1812387 - Use the DOM rather than the frame tree to find a menu's popup. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 26 Jan 2023 12:47:37 +0000 - rev 650654
Push 177224 by ealvarez@mozilla.com at Thu, 26 Jan 2023 12:50:16 +0000
Bug 1812387 - Use the DOM rather than the frame tree to find a menu's popup. r=smaug This shouldn't change behavior in practice except in cases where styles change the frame tree as in the previous patch. When rewriting menus, I kept the frame tree walk to match what nsMenuFrame used to do, but it is really more consistent to use the DOM for this, and prevents future issues if the front-end uses styles that alter the frame tree in ways that it didn't use to before removing nsMenuFrame. Differential Revision: https://phabricator.services.mozilla.com/D167886
9e53f4f1a593312119746b66ddda38259ad9cd1a: Bug 1795506 Throw from transferFromImageBitmap when bitmap is detached, r=smaug
Angus Sawyer <angus.sawyer@gmail.com> - Thu, 26 Jan 2023 10:17:03 +0000 - rev 650643
Push 177217 by archaeopteryx@coole-files.de at Thu, 26 Jan 2023 10:19:48 +0000
Bug 1795506 Throw from transferFromImageBitmap when bitmap is detached, r=smaug Thow expected error when attempting to use bitmap that has been detached with an imageBitmapRenderingContext. Differential Revision: https://phabricator.services.mozilla.com/D166552
3d270430ac9a7748acf646101e8fe25b984137bd: Bug 1773760 - part 6: remove the TokenBindingStatus enum. r=webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:08 +0000 - rev 650608
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 6: remove the TokenBindingStatus enum. r=webidl,smaug Depends on D167750 Differential Revision: https://phabricator.services.mozilla.com/D167751
d644ed6a5b97f76a8b6c9c3949392ede0e97a91e: Bug 1773760 - part 5: remove the AuthenticatorTransport enum. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:08 +0000 - rev 650607
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 5: remove the AuthenticatorTransport enum. r=keeler,webidl,smaug Depends on D167749 Differential Revision: https://phabricator.services.mozilla.com/D167750
0276c01b26dbd0601db1c91e978b75bff8d51d1a: Bug 1773760 - part 4: make PublicKeyCredentialType a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:07 +0000 - rev 650606
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 4: make PublicKeyCredentialType a DOMString. r=keeler,webidl,smaug Depends on D167748 Differential Revision: https://phabricator.services.mozilla.com/D167749
5b5584197d5f13ce9ea9ff98a7fa2cea92abe326: Bug 1773760 - part 3: make UserVerificationRequirement a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:06 +0000 - rev 650605
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 3: make UserVerificationRequirement a DOMString. r=keeler,webidl,smaug Depends on D167747 Differential Revision: https://phabricator.services.mozilla.com/D167748
7c89625a2b884d9e6a8afafe737a8a6465bdbaa1: Bug 1773760 - part 2: make AttestationConveyancePreference a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:06 +0000 - rev 650604
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 2: make AttestationConveyancePreference a DOMString. r=keeler,webidl,smaug Depends on D167746 Differential Revision: https://phabricator.services.mozilla.com/D167747
8507daa63430035d6b8212dd7afeb9d872c51745: Bug 1773760 - part 1: make AuthenticatorAttachment a DOMString. r=keeler,webidl,smaug
John Schanck <jschanck@mozilla.com> - Wed, 25 Jan 2023 22:12:05 +0000 - rev 650603
Push 177188 by jschanck@mozilla.com at Wed, 25 Jan 2023 22:15:36 +0000
Bug 1773760 - part 1: make AuthenticatorAttachment a DOMString. r=keeler,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D167746
521f45531857c9cb1d03aebca553993c45baa0bd: Bug 1809134 - Ensure we get ContentChild::NotifiedImpendingShutdown before (the last) BrowserChild::RecvDestroy. r=smaug
Jens Stutte <jstutte@mozilla.com> - Wed, 25 Jan 2023 20:15:12 +0000 - rev 650583
Push 177176 by jstutte@mozilla.com at Wed, 25 Jan 2023 20:18:11 +0000
Bug 1809134 - Ensure we get ContentChild::NotifiedImpendingShutdown before (the last) BrowserChild::RecvDestroy. r=smaug For normal (desktop) fission, we add NotifyImpendingShutdown before we notify destroy to the browser if we know a content process will go away both during normal operations and when the parent shuts down. For e10s and Android we can only add NotifyImpendingShutdown when the parent process is shutting down, as they use a different keep alive logic that is hard to anticipate. Differential Revision: https://phabricator.services.mozilla.com/D166303
480281148c396d4b7339516cc67c4758984f7d2f: Bug 1797411 - Check whether document is fully active. r=smaug
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Wed, 25 Jan 2023 01:13:15 +0000 - rev 650458
Push 177100 by m_kato@ga2.so-net.ne.jp at Wed, 25 Jan 2023 01:15:57 +0000
Bug 1797411 - Check whether document is fully active. r=smaug Newer spec has to check current document is fully active. If not, we have to throw InvalidStateError [*1] or AbortError [*2]. *1 https://w3c.github.io/screen-orientation/#lock-method *2 https://w3c.github.io/screen-orientation/#applying-an-orientation-lock Differential Revision: https://phabricator.services.mozilla.com/D167485
184ee14383fb9de1a19319594d66bc400eeb41a3: Bug 1809002 - Document cycle collector macros. r=smaug
Andrew McCreight <continuation@gmail.com> - Wed, 25 Jan 2023 00:43:46 +0000 - rev 650457
Push 177099 by amccreight@mozilla.com at Wed, 25 Jan 2023 00:46:28 +0000
Bug 1809002 - Document cycle collector macros. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D166234
d7f1a776a9864de8203eed10aaa18d4648926f30: Bug 1806501 - Start the JS Oracle process early. r=smaug
Andreas Farre <farre@mozilla.com> - Tue, 24 Jan 2023 15:37:49 +0000 - rev 650412
Push 177062 by afarre@mozilla.com at Tue, 24 Jan 2023 15:40:50 +0000
Bug 1806501 - Start the JS Oracle process early. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167230
4a44daa59af42c650bc2e27257f702b8faf1a564: Bug 1812035 - Fix broken about:memory tests. r=smaug
Andreas Farre <farre@mozilla.com> - Tue, 24 Jan 2023 15:37:49 +0000 - rev 650411
Push 177062 by afarre@mozilla.com at Tue, 24 Jan 2023 15:40:50 +0000
Bug 1812035 - Fix broken about:memory tests. r=smaug Tests for about:memory doesn't know about utility processes. Make sure to hide the utility process reporter when needed, and count the number of living processes, also when needed. Differential Revision: https://phabricator.services.mozilla.com/D167662
a48f2317a1432569de91995caf7b04b01f8e6451: Bug 1811963 - CustomElementData::Traverse should use NoteXPCOMChild for mElementInternals. r=smaug
Andrew McCreight <continuation@gmail.com> - Tue, 24 Jan 2023 14:51:33 +0000 - rev 650400
Push 177054 by amccreight@mozilla.com at Tue, 24 Jan 2023 14:54:13 +0000
Bug 1811963 - CustomElementData::Traverse should use NoteXPCOMChild for mElementInternals. r=smaug ElementInternals is an nsISupports class, so this should use NoteXPCOMChild. Differential Revision: https://phabricator.services.mozilla.com/D167621
fa5549b8b07ff9c152fc952dd6977bf7e861c484: Bug 1811195 - Cleanup late process creation checks. r=smaug
Jens Stutte <jstutte@mozilla.com> - Tue, 24 Jan 2023 11:22:53 +0000 - rev 650380
Push 177035 by jstutte@mozilla.com at Tue, 24 Jan 2023 11:25:58 +0000
Bug 1811195 - Cleanup late process creation checks. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167396
f396ec232f8d4678e7acc2e4082b81bfad730d36: Bug 1811195 - Bail out on AppShutdownConfirmed in ContentParent::RecvCloneDocumentTreeInto r=smaug
Jens Stutte <jstutte@mozilla.com> - Tue, 24 Jan 2023 11:22:53 +0000 - rev 650379
Push 177035 by jstutte@mozilla.com at Tue, 24 Jan 2023 11:25:58 +0000
Bug 1811195 - Bail out on AppShutdownConfirmed in ContentParent::RecvCloneDocumentTreeInto r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167566
3a8153d6d8304bef116f0f4dbedbabc0cc1a9ab7: Bug 1811195 - Bail out on AppShutdownConfirmed in SharedWorkerManager::MaybeCreateRemoteWorker and BackgroundParentImpl::AllocPRemoteWorkerControllerParent r=dom-worker-reviewers,smaug
Jens Stutte <jstutte@mozilla.com> - Tue, 24 Jan 2023 11:22:53 +0000 - rev 650378
Push 177035 by jstutte@mozilla.com at Tue, 24 Jan 2023 11:25:58 +0000
Bug 1811195 - Bail out on AppShutdownConfirmed in SharedWorkerManager::MaybeCreateRemoteWorker and BackgroundParentImpl::AllocPRemoteWorkerControllerParent r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D167565
df20721143f6cef9d16e0c43ad93fe37ff4a5368: Bug 1811195 - Bail out on AppShutdownConfirmed in DocumentLoadListener::OnStartRequest. r=smaug,necko-reviewers,nika,valentin
Jens Stutte <jstutte@mozilla.com> - Tue, 24 Jan 2023 11:22:52 +0000 - rev 650377
Push 177035 by jstutte@mozilla.com at Tue, 24 Jan 2023 11:25:58 +0000
Bug 1811195 - Bail out on AppShutdownConfirmed in DocumentLoadListener::OnStartRequest. r=smaug,necko-reviewers,nika,valentin Differential Revision: https://phabricator.services.mozilla.com/D167395
b112db2a47e5d45a2265b116cfc205a9dec668a8: Bug 1811195 - Bail out on AppShutdownConfirmed in nsFrameLoader::TryRemoteBrowser. r=smaug
Jens Stutte <jstutte@mozilla.com> - Tue, 24 Jan 2023 11:22:52 +0000 - rev 650376
Push 177035 by jstutte@mozilla.com at Tue, 24 Jan 2023 11:25:58 +0000
Bug 1811195 - Bail out on AppShutdownConfirmed in nsFrameLoader::TryRemoteBrowser. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167394
efdaaeb6ecf2945e52b22b14cb5d1e3d0031934a: Bug 1804803 - Hit MOZ_CRASH(DocumentLoadListener::Open for invalid history entry due to mismatch of 'Invalid LoadId'). r=smaug
Peter Van der Beken <peterv@propagandism.org> - Tue, 24 Jan 2023 11:11:26 +0000 - rev 650374
Push 177033 by pvanderbeken@mozilla.com at Tue, 24 Jan 2023 11:14:26 +0000
Bug 1804803 - Hit MOZ_CRASH(DocumentLoadListener::Open for invalid history entry due to mismatch of 'Invalid LoadId'). r=smaug When we start the load for a reload, check that the entry we're trying to reload is still connected to session history. Differential Revision: https://phabricator.services.mozilla.com/D165049
33f1cf51cadf03759b456a57e7828e63e1b001cd: Bug 1811682 - Update expected result for /fetch/api/basic/request-upload.h2.any.js r=dom-worker-reviewers,smaug
Eden Chuang <echuang@mozilla.com> - Mon, 23 Jan 2023 20:01:53 +0000 - rev 650285
Push 176976 by echuang@mozilla.com at Mon, 23 Jan 2023 20:04:35 +0000
Bug 1811682 - Update expected result for /fetch/api/basic/request-upload.h2.any.js r=dom-worker-reviewers,smaug This is an side-effect of PFetch implementation. Currently, PFetch is only default on nightly, so when running merging to Beta, the test will fail. Differential Revision: https://phabricator.services.mozilla.com/D167523
b3389fd511a07bfdb6bd31432b25492a35da7c79: Bug 1795506 Throw from transferFromImageBitmap when bitmap is detached, r=smaug
Angus Sawyer <angus.sawyer@gmail.com> - Mon, 23 Jan 2023 15:42:38 +0000 - rev 650235
Push 176950 by archaeopteryx@coole-files.de at Mon, 23 Jan 2023 15:45:48 +0000
Bug 1795506 Throw from transferFromImageBitmap when bitmap is detached, r=smaug Thow expected error when attempting to use bitmap that has been detached with an imageBitmapRenderingContext. Differential Revision: https://phabricator.services.mozilla.com/D166552
e301f56412263a111165a0faf60d58f4a499466d: Bug 1811466 - Restore menubar activation behavior from before bug 1811466. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 22 Jan 2023 23:55:55 +0000 - rev 650191
Push 176918 by ealvarez@mozilla.com at Mon, 23 Jan 2023 00:01:31 +0000
Bug 1811466 - Restore menubar activation behavior from before bug 1811466. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D167417
4aff047adb846f3f7e08734d7535bf09205ab8d8: Bug 1809740 Support from-image for the createImageBitmap imageOrientation option r=smaug
Angus Sawyer <angus.sawyer@gmail.com> - Sun, 22 Jan 2023 21:45:48 +0000 - rev 650189
Push 176916 by opettay@mozilla.com at Sun, 22 Jan 2023 21:48:25 +0000
Bug 1809740 Support from-image for the createImageBitmap imageOrientation option r=smaug Currently only the value 'flipY' is checked in code, with 'none' being the default behaviour. Upstream web platform tests now use the value 'from-image' in tests which now fail unless 'from-image' is accepted as a valid option. More work will be required later to change the behaviour of the 'none' option. Differential Revision: https://phabricator.services.mozilla.com/D166866
3e5c9fa28ebbcebce245d4c62f36c8ee53e434d0: Bug 1787974 - Remove leading canceled timers before deciding if we added a new front timer r=smaug
Justin Link <jlink@mozilla.com> - Fri, 20 Jan 2023 17:11:13 +0000 - rev 649854
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - Remove leading canceled timers before deciding if we added a new front timer r=smaug Due to the possible presence of canceled timers at the "front" of the list, mTimers[0] won't necessarily hold the next timer to be fired unless we've cleaned up those front timers recently. Differential Revision: https://phabricator.services.mozilla.com/D166575
199888078547a5fc33239499939b9ae7777744db: Bug 1787974 - Fixed small logic change in FindNextFireTimeForCurrentThread(). r=smaug
Justin Link <jlink@mozilla.com> - Fri, 20 Jan 2023 17:11:12 +0000 - rev 649853
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - Fixed small logic change in FindNextFireTimeForCurrentThread(). r=smaug I also took a stab at documenting the behavior since I found it a bit difficult to follow. Differential Revision: https://phabricator.services.mozilla.com/D165120
f1f071954863dd6fb4a2a3a05eaf2a7f32562630: Bug 1787974 - Fixed problem where AddTimerInternal() could add a new timer in the wrong spot. r=smaug
Justin Link <jlink@mozilla.com> - Fri, 20 Jan 2023 17:11:12 +0000 - rev 649852
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - Fixed problem where AddTimerInternal() could add a new timer in the wrong spot. r=smaug The previous version used IndexOfFirstElementGt which is implemented with a binary search. That doesn't work correctly because the mTimers array that is being searched is maintained in sorted order *only if the "cancelled" timers are skipped*. This revision replaces the binary search with a linear search which can handle this without problem. Given that the number of timers present at any one time is fairly modest, a linear search is probably a more appropriate choice anyway. Also added a new function, VerifyTimerListConsistency, which is called once per wake-up in the main loop and enabled only in DEBUG builds, that checks mTimers for ordering and consistency. Differential Revision: https://phabricator.services.mozilla.com/D164294
facb9344bb5da642819667782a0224a07dffb3c2: Bug 1787974 - AddTimerInternal efficiently inserts by shifting entries until next gap r=smaug
Gerald Squelart <gsquelart@mozilla.com> - Fri, 20 Jan 2023 17:11:11 +0000 - rev 649851
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - AddTimerInternal efficiently inserts by shifting entries until next gap r=smaug This makes the code more complex, but it is needed to keep this most-used function efficient related to its old implementation using `std::push_heap`. Differential Revision: https://phabricator.services.mozilla.com/D164292
115dff27741459a78917b2a301b7e1dc4092292a: Bug 1787974 - Changing mTimers from heap to timestamp-sorted array r=smaug
Gerald Squelart <gsquelart@mozilla.com> - Fri, 20 Jan 2023 17:11:11 +0000 - rev 649850
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - Changing mTimers from heap to timestamp-sorted array r=smaug Inserting elements in the sorted array is more costly than pushing to a binary heap, but this is balanced by the removal of indirections and de/allocations, and the upcoming re-use of empty entries. In the end, this change is necessary to allow future improvements like timer- coalescing, where we'll need to see multiple timers in order. Bonus: FindNextFireTimeForCurrentThread changes a lot, because it used to have to `pop_heap` elements and then `push_heap` them back! (Sometimes resulting in subtle changes for timers with the same timeout.) So this one benefits the most. Differential Revision: https://phabricator.services.mozilla.com/D164291
4c8d9ee644096dd3330133a036a00036cb380911: Bug 1787974 - In TimerThread::Shutdown, only Take non-null entries r=smaug
Gerald Squelart <gsquelart@mozilla.com> - Fri, 20 Jan 2023 17:11:11 +0000 - rev 649849
Push 176867 by opettay@mozilla.com at Fri, 20 Jan 2023 17:17:50 +0000
Bug 1787974 - In TimerThread::Shutdown, only Take non-null entries r=smaug Differential Revision: https://phabricator.services.mozilla.com/D164290