searching for reviewer(smaug)
d8d20fd629dd7589a9e824e25e46e35024612f03: Bug 1710680 - WebGPU createXxxPipelineAsync implementation r=jimb,webidl,smaug
Dzmitry Malyshau <dmalyshau@mozilla.com> - Sat, 22 Jan 2022 15:53:47 +0000 - rev 605263
Push 156516 by dmalyshau@mozilla.com at Sat, 22 Jan 2022 15:56:08 +0000
Bug 1710680 - WebGPU createXxxPipelineAsync implementation r=jimb,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D136521
57b7b4ac1ef32e76e1a147edbec83832f20a705a: Bug 1750515 - Enable NavigationPreload API on Nightly. r=dom-worker-reviewers,smaug
Eden Chuang <echuang@mozilla.com> - Sat, 22 Jan 2022 09:32:55 +0000 - rev 605250
Push 156508 by echuang@mozilla.com at Sat, 22 Jan 2022 09:35:18 +0000
Bug 1750515 - Enable NavigationPreload API on Nightly. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D136215
25666969c318c573ee3c13bd172992a093740afa: Bug 1697256 - Check docshell existence in SetFocusInner r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 21 Jan 2022 21:49:39 +0000 - rev 605217
Push 156491 by krosylight@mozilla.com at Fri, 21 Jan 2022 21:52:02 +0000
Bug 1697256 - Check docshell existence in SetFocusInner r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111950
a428c4aa428e45a3c936ccbc8d032b2325fb6111: Bug 1697256 - Check docshell existence in SetFocusInner r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 21 Jan 2022 16:31:36 +0000 - rev 605172
Push 156464 by krosylight@mozilla.com at Fri, 21 Jan 2022 16:34:46 +0000
Bug 1697256 - Check docshell existence in SetFocusInner r=smaug Differential Revision: https://phabricator.services.mozilla.com/D111950
fd60a8c6d1e637274d705a1144d8cc4c9df883c6: Bug 1660555 - Let AbortSignal grab strong references to its followers r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 21 Jan 2022 14:40:39 +0000 - rev 605155
Push 156454 by krosylight@mozilla.com at Fri, 21 Jan 2022 15:16:52 +0000
Bug 1660555 - Let AbortSignal grab strong references to its followers r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136447
07b9e1dc7c4eb75b5d38cf005608bc5dbc15fd5d: Bug 1660555 - Make AbortFollower::mFollowingSignal a WeakPtr r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 21 Jan 2022 14:40:38 +0000 - rev 605154
Push 156454 by krosylight@mozilla.com at Fri, 21 Jan 2022 15:16:52 +0000
Bug 1660555 - Make AbortFollower::mFollowingSignal a WeakPtr r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136446
4fca71d900b970cd9b33967f988e4abcea596720: Bug 1750543 - Don't abort by signal if consuming request body by DOM methods r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 21 Jan 2022 11:18:17 +0000 - rev 605145
Push 156447 by krosylight@mozilla.com at Fri, 21 Jan 2022 11:20:42 +0000
Bug 1750543 - Don't abort by signal if consuming request body by DOM methods r=smaug There are two cases when reading request body by DOM methods: 1. It's being read before fetch() 2. or after fetch() The first case shouldn't be affected by abort signal per the spec, since the abort step is added only within fetch(). https://fetch.spec.whatwg.org/#ref-for-abortsignal-add The second case should still fail but with `TypeError: Body has already been consumed`, not AbortError. Differential Revision: https://phabricator.services.mozilla.com/D136262
03cad3a7f83a82eeef2188aaefe9dc073421ba60: Bug 1750844 - Part 1: Expose client principal to windows. r=smaug
Tim Huang <tihuang@mozilla.com> - Thu, 20 Jan 2022 21:38:55 +0000 - rev 605082
Push 156413 by tihuang@mozilla.com at Thu, 20 Jan 2022 21:41:22 +0000
Bug 1750844 - Part 1: Expose client principal to windows. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136319
24818df95358a91380ae319af64af3b2f31e6668: Bug 1748888 - Add ErrorResult parameter to PromiseNativeHandler callbacks r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 20 Jan 2022 19:11:39 +0000 - rev 605068
Push 156401 by mgaudet@mozilla.com at Thu, 20 Jan 2022 19:14:09 +0000
Bug 1748888 - Add ErrorResult parameter to PromiseNativeHandler callbacks r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136423
3d133626b40c4d117065d4bcde81ad7621bb7d82: Bug 1709790 - Implement HTMLElement.outerText. r=smaug
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Jan 2022 12:49:29 +0000 - rev 604901
Push 156292 by ealvarez@mozilla.com at Wed, 19 Jan 2022 12:51:53 +0000
Bug 1709790 - Implement HTMLElement.outerText. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136240
7eef33e2ea5628be8af4505e72f1cb5e4d015583: Bug 1750931 - Fix non-unified-build bustage in dom/events, dom/fetch and dom/streams; r=smaug
Jan Varga <jvarga@mozilla.com> - Wed, 19 Jan 2022 11:09:55 +0000 - rev 604896
Push 156288 by jvarga@mozilla.com at Wed, 19 Jan 2022 11:12:18 +0000
Bug 1750931 - Fix non-unified-build bustage in dom/events, dom/fetch and dom/streams; r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136315
1f7b6a3e4de3d21142a982902ffa2717a13a184e: Bug 1750818 - Convert TestUtils to a namespace r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Wed, 19 Jan 2022 06:45:35 +0000 - rev 604877
Push 156272 by krosylight@mozilla.com at Wed, 19 Jan 2022 06:47:59 +0000
Bug 1750818 - Convert TestUtils to a namespace r=smaug Differential Revision: https://phabricator.services.mozilla.com/D136268
463258b8afe380ac8a004b3d60bfcc9bac03f182: Bug 1741280 - Part 2: Add tests for fullscreen state of content document; r=smaug
Edgar Chen <echen@mozilla.com> - Wed, 19 Jan 2022 06:08:45 +0000 - rev 604875
Push 156271 by echen@mozilla.com at Wed, 19 Jan 2022 06:11:30 +0000
Bug 1741280 - Part 2: Add tests for fullscreen state of content document; r=smaug Depends on D131183 Differential Revision: https://phabricator.services.mozilla.com/D132461
a8af5b44abd9b80fd3626b5cae0a7d5aa572206f: Bug 1741280 - Part 1: Add more fullscreen tests; r=smaug,Gijs
Edgar Chen <echen@mozilla.com> - Wed, 19 Jan 2022 06:08:45 +0000 - rev 604874
Push 156271 by echen@mozilla.com at Wed, 19 Jan 2022 06:11:30 +0000
Bug 1741280 - Part 1: Add more fullscreen tests; r=smaug,Gijs Depends on D131185 Differential Revision: https://phabricator.services.mozilla.com/D131183
0dea715a2df517733015b72280712a2ea01be52f: Bug 1747458 - Don't allow negative idleDuration when computing CYCLE_COLLECTOR_SLICE_DURING_IDLE. r=smaug
Andrew McCreight <continuation@gmail.com> - Tue, 18 Jan 2022 20:54:45 +0000 - rev 604826
Push 156236 by amccreight@mozilla.com at Tue, 18 Jan 2022 20:57:09 +0000
Bug 1747458 - Don't allow negative idleDuration when computing CYCLE_COLLECTOR_SLICE_DURING_IDLE. r=smaug Apparently this can go negative under some conditions in automation, which is blocking some UBSan testing. Just treat it as zero in that case. This makes the calculation consistent with the calculation of FORGET_SKIPPABLE_DURING_IDLE. Differential Revision: https://phabricator.services.mozilla.com/D136260
c4f14755f2214c315598fb7a89d9ea990337e612: Bug 1748916 - Defend against potential concurrent modification. r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 18 Jan 2022 20:40:14 +0000 - rev 604822
Push 156234 by mgaudet@mozilla.com at Tue, 18 Jan 2022 20:42:52 +0000
Bug 1748916 - Defend against potential concurrent modification. r=smaug This change is inspired by a Chrome security bug [1]. Since the Chrome bug was opened it appears that the bug was actually fixed at the specification level, but it seems prudent to at least consider the possibility of getting it wrong and being defensive here. [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1045874 Differential Revision: https://phabricator.services.mozilla.com/D135293
bed0dc025ad81a82a85438dac68200397b58d798: Bug 1746650 - Finish porting suitable JS tests r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 18 Jan 2022 20:40:14 +0000 - rev 604821
Push 156234 by mgaudet@mozilla.com at Tue, 18 Jan 2022 20:42:52 +0000
Bug 1746650 - Finish porting suitable JS tests r=smaug Remaining tests rely on shell only features like the promise rejection tracker, or rely on CCWs getting created where the new implementation will not create them (as the compartment ends up being determined by the parent object). Differential Revision: https://phabricator.services.mozilla.com/D135292
4dbb1c49c8edaba38032dbcba45a3e5603040a10: Bug 1746650 - Port cross-compartment wrapping test, and fix bug with cross compartment sources. r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Tue, 18 Jan 2022 20:40:13 +0000 - rev 604820
Push 156234 by mgaudet@mozilla.com at Tue, 18 Jan 2022 20:42:52 +0000
Bug 1746650 - Port cross-compartment wrapping test, and fix bug with cross compartment sources. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135291
37009356a0c3978130bf236ae973bad3b7b474a3: Bug 1749522 - When plain text encoding speculation fails, restart the plaintext mode of the tokenizer. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 17 Jan 2022 09:16:10 +0000 - rev 604670
Push 156128 by hsivonen@mozilla.com at Mon, 17 Jan 2022 09:23:27 +0000
Bug 1749522 - When plain text encoding speculation fails, restart the plaintext mode of the tokenizer. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135830
32d9429008ec32f65f3990cc7e6c8854932ff582: Bug 1746653 - Support ReadableStream in Sandbox's wantGlobalObject r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 14 Jan 2022 21:09:23 +0000 - rev 604626
Push 156097 by mgaudet@mozilla.com at Fri, 14 Jan 2022 21:12:07 +0000
Bug 1746653 - Support ReadableStream in Sandbox's wantGlobalObject r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135289
f83f8d048441ce3c353c06f988bf63843f14ee27: Bug 1741943 - Don't Expose interfaces that the current JS Streams implementation does not expose r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 14 Jan 2022 21:09:21 +0000 - rev 604621
Push 156097 by mgaudet@mozilla.com at Fri, 14 Jan 2022 21:12:07 +0000
Bug 1741943 - Don't Expose interfaces that the current JS Streams implementation does not expose r=smaug Differential Revision: https://phabricator.services.mozilla.com/D131551
6e94875e1ef32abb08f9a66bd43dc06b0f8f979d: Bug 1734873 - Fetch/Response/Blob ReadableStream integration r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Fri, 14 Jan 2022 21:09:20 +0000 - rev 604620
Push 156097 by mgaudet@mozilla.com at Fri, 14 Jan 2022 21:12:07 +0000
Bug 1734873 - Fetch/Response/Blob ReadableStream integration r=smaug Differential Revision: https://phabricator.services.mozilla.com/D131550
00bd44272452cbd30574ab4ed6e6d48639cf38a3: Bug 1669552 - Add TestUtils support for WPT r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 14 Jan 2022 18:36:59 +0000 - rev 604610
Push 156087 by krosylight@mozilla.com at Fri, 14 Jan 2022 18:39:20 +0000
Bug 1669552 - Add TestUtils support for WPT r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135942
4b0ad7ededf361d7a19ec6d469f2b3c3ff8f3095: Bug 1748364 - Make browser_navigation.js work with parent controlled doc channel. r=smaug
Andrew McCreight <continuation@gmail.com> - Fri, 14 Jan 2022 15:54:43 +0000 - rev 604592
Push 156074 by amccreight@mozilla.com at Fri, 14 Jan 2022 16:33:23 +0000
Bug 1748364 - Make browser_navigation.js work with parent controlled doc channel. r=smaug This test was hanging while waiting for the navigation to finish, when browser.tabs.documentchannel.parent-controlled is set to true. The browser navigated back just fine, but somehow the load event was not firing. The primary change here is to use BrowserTestUtils.waitForLocationChange() instead of BrowserTestUtils.browserLoaded() to wait for the navigation back to finish. This matches what is done in the goBack function in docshell/test/browser/head.js. Also, I fixed the quirks warning for file_navigation.html. Differential Revision: https://phabricator.services.mozilla.com/D135763
a2d8eae8d006eac01e6c4072390e7c3ad42419c2: Bug 1749522 - When plain text encoding speculation fails, restart the plaintext mode of the tokenizer. r=smaug
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 14 Jan 2022 13:36:24 +0000 - rev 604582
Push 156064 by hsivonen@mozilla.com at Fri, 14 Jan 2022 14:34:15 +0000
Bug 1749522 - When plain text encoding speculation fails, restart the plaintext mode of the tokenizer. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135830
670645ea7061bd29c550af5e41f8b84e75a96762: Bug 1739957 - Clear event listener. r=smaug
Peter Van der Beken <peterv@propagandism.org> - Thu, 13 Jan 2022 19:56:56 +0000 - rev 604518
Push 156018 by pvanderbeken@mozilla.com at Thu, 13 Jan 2022 19:59:20 +0000
Bug 1739957 - Clear event listener. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D134713
26bba575001c3a56b953cc19f3999b947e30fe92: Bug 1743207 - Implement ByteLengthQueuingStrategy interface r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 13 Jan 2022 19:01:20 +0000 - rev 604506
Push 156010 by mgaudet@mozilla.com at Thu, 13 Jan 2022 19:03:49 +0000
Bug 1743207 - Implement ByteLengthQueuingStrategy interface r=smaug Differential Revision: https://phabricator.services.mozilla.com/D134084
32e5726834766b1b2b66a1cec454aa12fc3cac6a: Bug 1743207 - Extract BaseQueuingStrategy r=smaug
Matthew Gaudet <mgaudet@mozilla.com> - Thu, 13 Jan 2022 19:01:20 +0000 - rev 604505
Push 156010 by mgaudet@mozilla.com at Thu, 13 Jan 2022 19:03:49 +0000
Bug 1743207 - Extract BaseQueuingStrategy r=smaug Differential Revision: https://phabricator.services.mozilla.com/D134082
eb3f5bc5be10bd491ecdaff0f344acdc72a024e1: Bug 1745862 - part 2: Make `IsSetAndValid` of `RangeBoundaryBase` and `EditorDOMPointBase` return `false` when it refers a node which is being removed from parent r=smaug,mbrodesser
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 13 Jan 2022 13:25:16 +0000 - rev 604475
Push 155986 by masayuki@d-toybox.com at Thu, 13 Jan 2022 13:27:48 +0000
Bug 1745862 - part 2: Make `IsSetAndValid` of `RangeBoundaryBase` and `EditorDOMPointBase` return `false` when it refers a node which is being removed from parent r=smaug,mbrodesser `IsSetAndValid` method of `RangeBoundaryBase` and `EditorDOMPointBase` should return `false` if points a removed node. However, while a node is being removed, the node still keeps referring the parent, but it has already removed from the child node chain of the parent. In this moment, returning `true` may not be expected by the callers because the point becomes invalid soon with the parent being cleared. Differential Revision: https://phabricator.services.mozilla.com/D135190
fd3872532e71dac49671f4617de2305013cb1572: Bug 1745720 - use 'chromelinkclick' command event to avoid instantiating ClickHandlerChild except for link clicks, r=smaug,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 13 Jan 2022 12:38:54 +0000 - rev 604472
Push 155984 by gijskruitbosch@gmail.com at Thu, 13 Jan 2022 12:41:17 +0000
Bug 1745720 - use 'chromelinkclick' command event to avoid instantiating ClickHandlerChild except for link clicks, r=smaug,mconley Instead of relying on untrusted click/auxclick events anywhere instantiating the actor, and then having to look for links, after this patch we'll only instantiate the actor for actual link clicks. This patch moves to using a chrome-only command event (with type `chromelinkclick`) dispatched from the link click post-visitor to accomplish that. In future we should probably move both this and the middle-click-to-paste handling into DOM code (or, for the latter, remove it) but this is a less invasive solution. This also moves the middle-click-to-paste handling into its own listener. It needs to listen to page events in general (not just links) but is disabled everywhere by default, so registering an actor for everyone doesn't seem like a good trade-off. To avoid duplicating all the logic (we do need to avoid doing middle-click navigation based on the clipboard when clicking on links!), as well as keeping patch size down, the actual control flow goes through the click handler actor still. Differential Revision: https://phabricator.services.mozilla.com/D134011
26a792be5ec35f69881393f138cc5496d7994717: Bug 1745720 - use 'chromelinkclick' command event to avoid instantiating ClickHandlerChild except for link clicks, r=smaug,mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 13 Jan 2022 00:00:57 +0000 - rev 604448
Push 155964 by gijskruitbosch@gmail.com at Thu, 13 Jan 2022 00:27:50 +0000
Bug 1745720 - use 'chromelinkclick' command event to avoid instantiating ClickHandlerChild except for link clicks, r=smaug,mconley Instead of relying on untrusted click/auxclick events anywhere instantiating the actor, and then having to look for links, after this patch we'll only instantiate the actor for actual link clicks. This patch moves to using a chrome-only command event (with type `chromelinkclick`) dispatched from the link click post-visitor to accomplish that. In future we should probably move both this and the middle-click-to-paste handling into DOM code (or, for the latter, remove it) but this is a less invasive solution. This also moves the middle-click-to-paste handling into its own listener. It needs to listen to page events in general (not just links) but is disabled everywhere by default, so registering an actor for everyone doesn't seem like a good trade-off. To avoid duplicating all the logic (we do need to avoid doing middle-click navigation based on the clipboard when clicking on links!), as well as keeping patch size down, the actual control flow goes through the click handler actor still. Differential Revision: https://phabricator.services.mozilla.com/D134011
74f95111f7f45617d99498e19c6d5e79118fd4ae: Bug 1748644 - MIDI ports should stop responding to parent message once they've been disconnected from the document that owned them r=smaug
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 12 Jan 2022 15:03:34 +0000 - rev 604406
Push 155930 by gsvelto@mozilla.com at Wed, 12 Jan 2022 15:05:59 +0000
Bug 1748644 - MIDI ports should stop responding to parent message once they've been disconnected from the document that owned them r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135700
9210bf384d60faf3e13db7ccec436cd801df7fb0: Bug 1741182: Harmonize WorkerRunnable derived classes' overrides of Cancel. r=dom-worker-reviewers,smaug
Jens Stutte <jstutte@mozilla.com> - Wed, 12 Jan 2022 14:43:09 +0000 - rev 604404
Push 155928 by jstutte@mozilla.com at Wed, 12 Jan 2022 14:55:21 +0000
Bug 1741182: Harmonize WorkerRunnable derived classes' overrides of Cancel. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D135679
84cae67e60f6b081df528ed75aa7a939eed45ec1: Bug 1742540 - Add test case to reproduce leaks. r=smaug
Shelly Lin <shellylin@gmail.com> - Wed, 12 Jan 2022 13:21:11 +0000 - rev 604392
Push 155920 by opettay@mozilla.com at Wed, 12 Jan 2022 13:24:25 +0000
Bug 1742540 - Add test case to reproduce leaks. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135094
0d9949fa97e2987ff94edff4bb78ad2777964184: Bug 1742540 - Close input stream when destructing StreamBlobImpl. r=smaug
Shelly Lin <shellylin@gmail.com> - Wed, 12 Jan 2022 13:21:11 +0000 - rev 604391
Push 155920 by opettay@mozilla.com at Wed, 12 Jan 2022 13:24:25 +0000
Bug 1742540 - Close input stream when destructing StreamBlobImpl. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D133717
faf471bc70995bb0076b527fa63f3f745f0b308e: Bug 1748466 - Make ShouldKeepTimerRunningWhileWaitingForFirstContentfulPaint return early for initial about:blank documents, r=smaug.
Florian Quèze <florian@queze.net> - Wed, 12 Jan 2022 11:04:47 +0000 - rev 604372
Push 155904 by fqueze@mozilla.com at Wed, 12 Jan 2022 11:07:10 +0000
Bug 1748466 - Make ShouldKeepTimerRunningWhileWaitingForFirstContentfulPaint return early for initial about:blank documents, r=smaug. Differential Revision: https://phabricator.services.mozilla.com/D135691
9909c2970b9bbe1aac6d59857871b2ac6fa19e13: Bug 1745378 - Enable form-associated custom elements by default; r=smaug,annevk
Edgar Chen <echen@mozilla.com> - Wed, 12 Jan 2022 10:08:09 +0000 - rev 604314
Push 155898 by echen@mozilla.com at Wed, 12 Jan 2022 10:10:30 +0000
Bug 1745378 - Enable form-associated custom elements by default; r=smaug,annevk Differential Revision: https://phabricator.services.mozilla.com/D135578
f5d5f154bb330937b2d191fb61be5ef75e4ccfcd: Bug 1743623 - Part 3: Remove worker-specific override from JS GC zeal options. r=dom-worker-reviewers,smaug
Tooru Fujisawa <arai_a@mac.com> - Tue, 11 Jan 2022 15:55:51 +0000 - rev 604251
Push 155859 by arai_a@mac.com at Tue, 11 Jan 2022 15:58:24 +0000
Bug 1743623 - Part 3: Remove worker-specific override from JS GC zeal options. r=dom-worker-reviewers,smaug Also fixed the case of the preference name (gcZeal => gczeal). Differential Revision: https://phabricator.services.mozilla.com/D133977
f9891534f80f88e5cd4b52883fa2b6ad0f23c280: Bug 1743623 - Part 2: Remove worker-specific override from JS GC memory options. r=dom-worker-reviewers,smaug
Tooru Fujisawa <arai_a@mac.com> - Tue, 11 Jan 2022 15:55:50 +0000 - rev 604250
Push 155859 by arai_a@mac.com at Tue, 11 Jan 2022 15:58:24 +0000
Bug 1743623 - Part 2: Remove worker-specific override from JS GC memory options. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D133976
51820e97c1ebcf08dbc9816e08899b05cab7f62e: Bug 1743623 - Part 3: Remove worker-specific override from JS GC zeal options. r=dom-worker-reviewers,smaug
Tooru Fujisawa <arai_a@mac.com> - Tue, 11 Jan 2022 12:03:54 +0000 - rev 604158
Push 155840 by arai_a@mac.com at Tue, 11 Jan 2022 12:27:12 +0000
Bug 1743623 - Part 3: Remove worker-specific override from JS GC zeal options. r=dom-worker-reviewers,smaug Also fixed the case of the preference name (gcZeal => gczeal). Differential Revision: https://phabricator.services.mozilla.com/D133977
824c5cd5ea17ac8eb402e3696f3a323ee437dcae: Bug 1743623 - Part 2: Remove worker-specific override from JS GC memory options. r=dom-worker-reviewers,smaug
Tooru Fujisawa <arai_a@mac.com> - Tue, 11 Jan 2022 12:03:54 +0000 - rev 604157
Push 155840 by arai_a@mac.com at Tue, 11 Jan 2022 12:27:12 +0000
Bug 1743623 - Part 2: Remove worker-specific override from JS GC memory options. r=dom-worker-reviewers,smaug Differential Revision: https://phabricator.services.mozilla.com/D133976
14ca6fe48a2be7b31d3298b7f11b6c9637278bd8: Bug 1742540 - Add test case to reproduce leaks. r=smaug
Shelly Lin <shellylin@gmail.com> - Tue, 11 Jan 2022 10:45:03 +0000 - rev 604136
Push 155832 by opettay@mozilla.com at Tue, 11 Jan 2022 10:47:31 +0000
Bug 1742540 - Add test case to reproduce leaks. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135094
3ec889d687e4c2b02ddce8fa3e3482f466b5f8c3: Bug 1742540 - Close input stream when destructing StreamBlobImpl. r=smaug
Shelly Lin <shellylin@gmail.com> - Tue, 11 Jan 2022 10:45:02 +0000 - rev 604135
Push 155832 by opettay@mozilla.com at Tue, 11 Jan 2022 10:47:31 +0000
Bug 1742540 - Close input stream when destructing StreamBlobImpl. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D133717
582cebc1d4f0450e33d627dcc5714be91a5fd7a7: Bug 1697539 - Test case, r=smaug
Kershaw Chang <kershaw@mozilla.com> - Tue, 11 Jan 2022 04:08:00 +0000 - rev 604124
Push 155823 by kjang@mozilla.com at Tue, 11 Jan 2022 04:10:27 +0000
Bug 1697539 - Test case, r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135499
7a69785c9c46970d61c8e1369df5380f5d5b65f2: Bug 1697539 - Throw an "InvalidStateError" if the state is not opened, r=smaug
Kershaw Chang <kershaw@mozilla.com> - Tue, 11 Jan 2022 04:07:59 +0000 - rev 604123
Push 155823 by kjang@mozilla.com at Tue, 11 Jan 2022 04:10:27 +0000
Bug 1697539 - Throw an "InvalidStateError" if the state is not opened, r=smaug `xhr.send()` in worker thread should have the same check as in main thread. Differential Revision: https://phabricator.services.mozilla.com/D135196
cca392552a576ac475c654d887c1a1dee3ae0f2c: Bug 1733536 - Enable <dialog> by default. r=smaug,annevk,Jamie,sefeng
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 10 Jan 2022 16:51:55 +0000 - rev 604084
Push 155796 by ealvarez@mozilla.com at Mon, 10 Jan 2022 16:54:15 +0000
Bug 1733536 - Enable <dialog> by default. r=smaug,annevk,Jamie,sefeng It's been enabled on Nightly for a long while, and the only remaining issue is about focus (https://github.com/whatwg/html/pull/4184 and co, mostly). But: * We get compat reports on release / ESR because of <dialog> not being enabled. * Accessibility of hand-rolled dialogs is usually worse. * I don't think tweaking the focus behavior slightly will have much compat fallout in practice, compared to websites just assuming <dialog> exists and is implemented, and breaking otherwise. So, being pragmatic, I think it's probably better to have it enabled than not. Thoughts? Differential Revision: https://phabricator.services.mozilla.com/D134966
582722ee7fc82ce54a4a188a0212659818417c44: Bug 1112134 - Limit Cache/CacheStorage to SecureContext r=edenchuang,webidl,smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 10 Jan 2022 14:36:12 +0000 - rev 604067
Push 155783 by krosylight@mozilla.com at Mon, 10 Jan 2022 14:38:30 +0000
Bug 1112134 - Limit Cache/CacheStorage to SecureContext r=edenchuang,webidl,smaug Differential Revision: https://phabricator.services.mozilla.com/D134560
f6b75d021d28c4d9bf83bbad7928783acdd8c548: Bug 1748146 - Return early in AbortSignal::SignalAbort r=smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Fri, 07 Jan 2022 17:52:40 +0000 - rev 603994
Push 155726 by krosylight@mozilla.com at Fri, 07 Jan 2022 17:55:03 +0000
Bug 1748146 - Return early in AbortSignal::SignalAbort r=smaug Currently only AbortSignalImpl::SignalAbort returns early. Both can be called directly, so both should return early. Currently not really testable since this is only problematic in dom/streams and it's still hidden by a build flag. Differential Revision: https://phabricator.services.mozilla.com/D135278
95c758aeaf7ce5813d5791e720f56bddbaab4236: Bug 1748912 - Add null check in CanonicalBrowsingContext::RemoveFromSessionHistory. r=smaug
Andrew McCreight <continuation@gmail.com> - Fri, 07 Jan 2022 14:16:07 +0000 - rev 603978
Push 155716 by amccreight@mozilla.com at Fri, 07 Jan 2022 14:18:26 +0000
Bug 1748912 - Add null check in CanonicalBrowsingContext::RemoveFromSessionHistory. r=smaug Differential Revision: https://phabricator.services.mozilla.com/D135270
7718ef477a15e4d6a40b26bd62c30b9962d39b94: Bug 1747199 - Remove ClientIsValidPrincipalInfo() from ClientManagerParent::RecvExpect/ForgetFutureSource(). r=dom-worker-reviewers,smaug
Eden Chuang <echuang@mozilla.com> - Thu, 06 Jan 2022 07:52:58 +0000 - rev 603887
Push 155650 by echuang@mozilla.com at Thu, 06 Jan 2022 07:55:24 +0000
Bug 1747199 - Remove ClientIsValidPrincipalInfo() from ClientManagerParent::RecvExpect/ForgetFutureSource(). r=dom-worker-reviewers,smaug ClientValidPrincipalInfo() can be removed from ClientManagerParent::RecvExpect/ForgetFutureSource(). In some redirection cases, ClientChannelHelperParent::CreateClient() will be called in ClientChannelHelper::AsyncOnChannelRedirect(). It would create a new ClientInfo for the new channel's reservedInfo with the new channel's principal, and then propagate the ClientInfo to ClientManagerParent::RecvExpectFutureSource(). https://searchfox.org/mozilla-central/source/dom/clients/manager/ClientChannelHelper.cpp#121,215-216,227,239,251 However, the new channel's principal is not guaranteed to be valid with ClientIsValidPrincipalInfo(). But we don't need to validate it since it could be redirected again. We actually care about is if the principal is valid for the last redirection since we will create an actual ClientSource for it. We did the checking indirectly in [[ https://searchfox.org/mozilla-central/source/dom/clients/manager/ClientSourceParent.cpp#217,221 | ClientSourceParent::Init() ]]. The ClientInfo used to create ClientSourceParent should be equivalent with used to create FutureClientSourceParent. We also do the ClientInfo equivalence checking [[ https://searchfox.org/mozilla-central/source/dom/clients/manager/ClientManagerService.cpp#254,275-277 | here ]] So here comes out the conclusion that ClientValidPrincipalInfo() can be removed from ClientManagerParent::RecvExpect/ForgetFutureSource(). Differential Revision: https://phabricator.services.mozilla.com/D134957