searching for reviewer(sheehan)
48872f359bc6769f1e32a11c7be69305ca980544: Bug 1709084: Don't encode debugger arg as ascii r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 04 May 2021 15:07:07 +0000 - rev 578484
Push 142501 by mhentges@mozilla.com at Tue, 04 May 2021 15:23:57 +0000
Bug 1709084: Don't encode debugger arg as ascii r=sheehan We're mostly using Python 3 today, so the old `.encode("ascii")` conversion is no longer needed. Differential Revision: https://phabricator.services.mozilla.com/D114152
1da658a5571f8e2f6cc2ef50fdf266ddd4040e64: Bug 1704764: Remove OSError catch for fetching nonexistent registry key r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 27 Apr 2021 20:16:14 +0000 - rev 577726
Push 142027 by mhentges@mozilla.com at Tue, 27 Apr 2021 22:36:18 +0000
Bug 1704764: Remove OSError catch for fetching nonexistent registry key r=sheehan Since Python 3, attempting to fetch a registry key that doesn't exist throws `FileNotFoundError`, not `WindowsError: [Error 2]`. Differential Revision: https://phabricator.services.mozilla.com/D112647
433ff01137a559f99accac8acac4570fcf2b09ac: Bug 1705444: Pipe IPDL test status to exit code r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Wed, 21 Apr 2021 15:34:42 +0000 - rev 576974
Push 141654 by mhentges@mozilla.com at Wed, 21 Apr 2021 15:37:07 +0000
Bug 1705444: Pipe IPDL test status to exit code r=sheehan By returning non-zero when tests fail, `make` can pick up the failure. Differential Revision: https://phabricator.services.mozilla.com/D112789
270cc692033e787ea3aa756e62928ae1c3f3cffa: Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Mon, 19 Apr 2021 23:17:06 +0000 - rev 576699
Push 141482 by dluca@mozilla.com at Tue, 20 Apr 2021 01:08:41 +0000
Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan Glean is throwing an error if a string metric is `None`. Since `get_cpu_brand()` can return `None`, only update telemetry if it's set. Depends on D110847 Differential Revision: https://phabricator.services.mozilla.com/D110858
32a4f65504f6517613e302feae241cda650dc380: Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Mon, 19 Apr 2021 23:17:06 +0000 - rev 576683
Push 141476 by mhentges@mozilla.com at Tue, 20 Apr 2021 00:36:10 +0000
Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan Glean is throwing an error if a string metric is `None`. Since `get_cpu_brand()` can return `None`, only update telemetry if it's set. Depends on D110847 Differential Revision: https://phabricator.services.mozilla.com/D110858
e1bedcefd2d76107adc8b4425c17eae02a1fe870: Bug 1704838: Resolve mach_bootstrap compatibility with Python 2 r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Mon, 19 Apr 2021 16:37:36 +0000 - rev 576587
Push 141431 by mhentges@mozilla.com at Mon, 19 Apr 2021 19:11:52 +0000
Bug 1704838: Resolve mach_bootstrap compatibility with Python 2 r=sheehan Python 2 isn't as happy with spread operators and doesn't support "sys.base_prefix". Differential Revision: https://phabricator.services.mozilla.com/D111898
d4d3ba582763bb645a9c68e9b8c1534b658ef989: Bug 1703055: Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan
Mitchell Hentges <mhentges@mozilla.com> - Mon, 19 Apr 2021 16:37:35 +0000 - rev 576586
Push 141431 by mhentges@mozilla.com at Mon, 19 Apr 2021 19:11:52 +0000
Bug 1703055: Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan To avoid erroneously importing a package from the system, we remove system site package. This is another positive step towards further insulating the Firefox build from the state of the environment. This may cause failures if some mach commands have been sneakily importing system packages instead of properly vendoring them. Differential Revision: https://phabricator.services.mozilla.com/D110847
6c8059ed68ffc5dc7482e71599545595ebe322f1: Bug 1705763: Remove build/genrc.sh file r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Mon, 19 Apr 2021 16:37:15 +0000 - rev 576585
Push 141430 by mhentges@mozilla.com at Mon, 19 Apr 2021 19:11:19 +0000
Bug 1705763: Remove build/genrc.sh file r=sheehan This file has been unchanged (other than license changes) since the 1998 "free the lizard" commit. It's not referenced from any other file. It's time to retire, `genrc.sh`. Differential Revision: https://phabricator.services.mozilla.com/D112374
bbfa187adf60cf70ca4fcc6f42ed638c307c8f0a: Bug 1694531: Add docs for quarantined Try builds r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Wed, 14 Apr 2021 16:59:47 +0000 - rev 575945
Push 141054 by mhentges@mozilla.com at Wed, 14 Apr 2021 17:06:55 +0000
Bug 1694531: Add docs for quarantined Try builds r=sheehan Removes irrelevant mercurial-specific information about pushing to try, adds note about removing the qurantine attribute from Try builds. Differential Revision: https://phabricator.services.mozilla.com/D107298
39a9276cbc0182bc81be97596eacad2fddced35e: Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 13 Apr 2021 14:46:27 +0000 - rev 575671
Push 140874 by mhentges@mozilla.com at Tue, 13 Apr 2021 14:48:54 +0000
Bug 1703092: Don't provide cpu_brand in telemetry if None r=sheehan Glean is throwing an error if a string metric is `None`. Since `get_cpu_brand()` can return `None`, only update telemetry if it's set. Depends on D110847 Differential Revision: https://phabricator.services.mozilla.com/D110858
189b85571855a21e85a11f41f188efb9214f0a79: Bug 1703055: Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 13 Apr 2021 14:46:27 +0000 - rev 575670
Push 140874 by mhentges@mozilla.com at Tue, 13 Apr 2021 14:48:54 +0000
Bug 1703055: Don't include global site packages in python path r=firefox-build-system-reviewers,glandium,sheehan To avoid erroneously importing a package from the system, we remove system site package. This is another positive step towards further insulating the Firefox build from the state of the environment. This may cause failures if some mach commands have been sneakily importing system packages instead of properly vendoring them. Differential Revision: https://phabricator.services.mozilla.com/D110847
71e9852a8a9a9e0b4d6a762dc4ac15ebb861495e: Bug 1703079: Remove redundant, unused "mozilla_dir" argument r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 06 Apr 2021 17:03:41 +0000 - rev 574587
Push 140260 by mhentges@mozilla.com at Tue, 06 Apr 2021 18:21:06 +0000
Bug 1703079: Remove redundant, unused "mozilla_dir" argument r=sheehan If a custom `topsrcdir` is needed, it can be directly passed in. I don't see how a separate `mozilla_dir` parameter is necessary - it appears redundant to me. Differential Revision: https://phabricator.services.mozilla.com/D110841
12c13c531aa030d028f0b331bc16be3823c60acd: Bug 1702279: Sentry should patch absolute paths without leading slash r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Thu, 01 Apr 2021 16:30:57 +0000 - rev 574030
Push 140006 by mhentges@mozilla.com at Thu, 01 Apr 2021 16:33:22 +0000
Bug 1702279: Sentry should patch absolute paths without leading slash r=sheehan Due to strange module-name generation we do (e.g.: `mach.commands.be68b9824a51408e815262b2e8f21d6b`), Sentry's conversion of absolute paths to local paths fails - instead, the path remains absolute, but without the leading forward slash. (Except on Windows, where `c:/` is maintained). We resolve this by not requiring the leading slash when patching absolute paths. Differential Revision: https://phabricator.services.mozilla.com/D110436
614a656ae1639bbb391701c0e077d13482728817: Bug 1702353: Don't submit exception to Sentry if revision can't be found r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Thu, 01 Apr 2021 16:23:57 +0000 - rev 574029
Push 140005 by mhentges@mozilla.com at Thu, 01 Apr 2021 16:26:23 +0000
Bug 1702353: Don't submit exception to Sentry if revision can't be found r=sheehan This can occur if the user is using cinnabar and it fails to find the equivalent hg revision for their current base commit. It's significantly less valuable to have exceptions with an "anonymous release", so we skip these exceptions instead. Differential Revision: https://phabricator.services.mozilla.com/D110481
12bfa814a6bdd5a7314bf4b8bdb766f7455ee596: Bug 1702257: Prepend Sentry releases with "hg-rev-" r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Wed, 31 Mar 2021 15:52:02 +0000 - rev 573913
Push 139911 by mhentges@mozilla.com at Wed, 31 Mar 2021 15:54:25 +0000
Bug 1702257: Prepend Sentry releases with "hg-rev-" r=sheehan The Sentry CI task versioning scheme should match the generated Sentry issues. Differential Revision: https://phabricator.services.mozilla.com/D110422
eed530931ca05b277c29539784ac24dea224f368: Bug 1645425: Annotate Sentry reports with base revision r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 30 Mar 2021 16:22:58 +0000 - rev 573769
Push 139820 by mhentges@mozilla.com at Tue, 30 Mar 2021 16:25:24 +0000
Bug 1645425: Annotate Sentry reports with base revision r=sheehan To track whether issues being reported are for old versions, we attach an hg revision hash as a release version with each report. We use the base_ref because: * It's a public revision that we can look up, and * Since we only submit Sentry events when mach is unmodified, it's essentially acting as a version identifier. Differential Revision: https://phabricator.services.mozilla.com/D108307
6def98bb889f93c8c3522b07b3b2f2026b250a2b: Bug 1699613 - Allow the build resources usage report to display arbitrary resource usage json files. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 22 Mar 2021 21:46:53 +0000 - rev 572509
Push 139200 by mh@glandium.org at Mon, 22 Mar 2021 21:49:16 +0000
Bug 1699613 - Allow the build resources usage report to display arbitrary resource usage json files. r=firefox-build-system-reviewers,sheehan,mhentges AFAIK, while mochitests have resource-usage.json data with the same format as build_resources.json, there isn't much of anything to display that data in a human-friendly manner. As a helper of sort for all the tasks that already expose their json data without a nice way to display it, allow the build resources usage report UI that `mach resource-usage` displays (or build_resources.html on build tasks on treeherder), to load arbitrary json files if their url is dropped on the page (from e.g. drag-and-dropping the link to the file from treeherder). Differential Revision: https://phabricator.services.mozilla.com/D109030
a7db102dce7a89a322f054d855c52e40cdf14f86: Bug 1699397 - Upgrade mach environment to glean-sdk 36.0.0. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 22 Mar 2021 21:41:44 +0000 - rev 572507
Push 139198 by mh@glandium.org at Mon, 22 Mar 2021 21:44:09 +0000
Bug 1699397 - Upgrade mach environment to glean-sdk 36.0.0. r=firefox-build-system-reviewers,sheehan,mhentges Differential Revision: https://phabricator.services.mozilla.com/D108921
9f192e1b76d668f70349f4845557e9622ee34bc7: Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Mar 2021 02:27:22 +0000 - rev 571541
Push 138741 by mh@glandium.org at Wed, 17 Mar 2021 02:29:43 +0000
Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges The build always uses them anyways, but configure tests don't, and some of them fail as a consequence in some cases (example: when UBsan is enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had similar problems in the past, such as bug 1513605. By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure tests use the flags as well. While here, we also remove DSO_CFLAGS, which was always empty, and we stop passing -fPIC to wasm compiles, because it has no effect there. Differential Revision: https://phabricator.services.mozilla.com/D108560
32bc2074fce00f82ad2b2cb27ff45da9151cf20a: Bug 1697950 - Partial support for mach bootstrap on arm64 mac. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Mar 2021 02:11:51 +0000 - rev 571540
Push 138740 by mh@glandium.org at Wed, 17 Mar 2021 02:14:16 +0000
Bug 1697950 - Partial support for mach bootstrap on arm64 mac. r=firefox-build-system-reviewers,sheehan,mhentges This is enough to make the instructions on the Google doc unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D108132
86089c4629b536b7212977fffe302dad8bdc0767: Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 17 Mar 2021 01:27:39 +0000 - rev 571537
Push 138737 by mh@glandium.org at Wed, 17 Mar 2021 01:30:06 +0000
Bug 1698706 - Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges The build always uses them anyways, but configure tests don't, and some of them fail as a consequence in some cases (example: when UBsan is enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had similar problems in the past, such as bug 1513605. By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure tests use the flags as well. While here, we also remove DSO_CFLAGS, which was always empty, and we stop passing -fPIC to wasm compiles, because it has no effect there. Differential Revision: https://phabricator.services.mozilla.com/D108560
351dbe902dd499ed1b44eaca25ecae7809a923b0: Bug 1698889: Consistently alias paths in Sentry reports r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Tue, 16 Mar 2021 20:30:30 +0000 - rev 571507
Push 138711 by mhentges@mozilla.com at Tue, 16 Mar 2021 22:09:07 +0000
Bug 1698889: Consistently alias paths in Sentry reports r=sheehan When Sentry slurps context, it doesn't normalize os path separators for us. So, we adapt our path aliasing to always catch both forward slashes and backslashes. Removed the `needle is None` guard because it because obsolete after 1695366, which removed the case where `topsrcdir` was `None`. Differential Revision: https://phabricator.services.mozilla.com/D108667
b4541867e67d3c223c309f9558dd55c423d0e433: Bug 1695366: Only submit Sentry events when Mach is unmodified r=sheehan
Mitchell Hentges <mhentges@mozilla.com> - Fri, 12 Mar 2021 22:29:28 +0000 - rev 570965
Push 138468 by mhentges@mozilla.com at Fri, 12 Mar 2021 23:18:58 +0000
Bug 1695366: Only submit Sentry events when Mach is unmodified r=sheehan If the "mach" file and all "*.py" files are unchanged, then the reported exception is likely legitimate and can be reproduced on the public tree. Differential Revision: https://phabricator.services.mozilla.com/D108262
36a2493882897a706c9883a77565a8f1765288f3: Bug 1697960 - Don't prompt for telemetry when glean couldn't be installed. r=firefox-build-system-reviewers,mhentges,sheehan
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 Mar 2021 21:14:40 +0000 - rev 570957
Push 138460 by mh@glandium.org at Fri, 12 Mar 2021 21:17:03 +0000
Bug 1697960 - Don't prompt for telemetry when glean couldn't be installed. r=firefox-build-system-reviewers,mhentges,sheehan Bootstrap runs mach create-mach-environment, which may or may not successfully install glean. When it doesn't, it's not useful to ask whether to enable telemetry when it's not going to work. Differential Revision: https://phabricator.services.mozilla.com/D108131
7d48c2dddaa0edab66e6462868d667d34dc357e8: Bug 1695973: Remove retry limit from bootstrap prompt r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Fri, 12 Mar 2021 16:07:11 +0000 - rev 570894
Push 138417 by mhentges@mozilla.com at Fri, 12 Mar 2021 16:36:47 +0000
Bug 1695973: Remove retry limit from bootstrap prompt r=firefox-build-system-reviewers,sheehan,glandium The retry limit doesn't add much value - if user doesn't want to answer a prompt, they can CTRL-C. Additionally, `prompt_yesno` doesn't have a retry limit, so this increases prompt behaviour consistency. Differential Revision: https://phabricator.services.mozilla.com/D107122
8be40f7d8996519cc138099e5c7868116a16715f: Bug 1697042 - Remove "DeprecatedCommands" logic. r=mhentges,sheehan
Alex Lopez <alex.lopez.zorzano@gmail.com> - Thu, 11 Mar 2021 21:42:28 +0000 - rev 570772
Push 138347 by mhentges@mozilla.com at Fri, 12 Mar 2021 03:29:11 +0000
Bug 1697042 - Remove "DeprecatedCommands" logic. r=mhentges,sheehan Since there's no DeprecatedCommands class defined in-tree, we can remove logic that checks that a class has that name. Differential Revision: https://phabricator.services.mozilla.com/D107836
08bdfba628a3759b606ffea49bb86ab2d3063a77: Bug 1697847 - Update crossbeam-utils in the tree. r=firefox-build-system-reviewers,mhentges,sheehan
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 11 Mar 2021 18:15:44 +0000 - rev 570737
Push 138314 by ealvarez@mozilla.com at Thu, 11 Mar 2021 22:36:02 +0000
Bug 1697847 - Update crossbeam-utils in the tree. r=firefox-build-system-reviewers,mhentges,sheehan We're already vendoring 0.8 so no reason not to do this. We're still held back by an ancient tokio version, which I filed bug 1697845 for. There are no breaking changes that affect any of our internal consumers. Differential Revision: https://phabricator.services.mozilla.com/D108046
3740bdc264511d8408dcd3ea83be5774e3e21c3c: Bug 1695994: Removes some mach unused parameters and dead code r=sheehan,firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Wed, 10 Mar 2021 15:08:34 +0000 - rev 570513
Push 138167 by mhentges@mozilla.com at Wed, 10 Mar 2021 15:59:44 +0000
Bug 1695994: Removes some mach unused parameters and dead code r=sheehan,firefox-build-system-reviewers,glandium * `_format_metadata()` had unused parameters * `debugger_args` weren't used after being `shellutil.split(...)` * There was dead python2-specific-code after a `return` statement Differential Revision: https://phabricator.services.mozilla.com/D106970
d028ccac0035c255900126522d7df1b2cfe9d19a: Bug 1697098 - Default to --enable-bootstrap for arm64 mac builds. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 09 Mar 2021 21:27:52 +0000 - rev 570381
Push 138077 by mh@glandium.org at Tue, 09 Mar 2021 22:52:17 +0000
Bug 1697098 - Default to --enable-bootstrap for arm64 mac builds. r=firefox-build-system-reviewers,andi,sheehan,mhentges Differential Revision: https://phabricator.services.mozilla.com/D107601
00d3fcc38474ba7152f280d79816b7312d605956: Bug 1683797: Remove obsolete "build_targets" option from CI r=sheehan,releng-reviewers,jmaher
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Mar 2021 14:45:26 +0000 - rev 570305
Push 138028 by mhentges@mozilla.com at Tue, 09 Mar 2021 15:50:58 +0000
Bug 1683797: Remove obsolete "build_targets" option from CI r=sheehan,releng-reviewers,jmaher Rusttests were the only remaining usage. Differential Revision: https://phabricator.services.mozilla.com/D106295
a97de4385cf6803b4cadb8bdcf5a24ecbcee580e: Bug 1683797: Don't use "build targets" to build rusttests r=sheehan,firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Mar 2021 14:45:25 +0000 - rev 570304
Push 138028 by mhentges@mozilla.com at Tue, 09 Mar 2021 15:50:58 +0000
Bug 1683797: Don't use "build targets" to build rusttests r=sheehan,firefox-build-system-reviewers,glandium When "build targets" are used, the sccache server isn't being used/integrated properly with make. By moving rusttests to a separate build "application", `client.mk` is invoked normally, and sccache is happy. * Move rusttests to a new build "application". * Move and denormalize rusttests mozconfigs. The new rusttests mozconfigs should expand to be mostly identical to their old versions, except with `MOZ_AUTOMATION_*=0` and `--enable-application=tools/rusttests`. They will differ a bit from their old variants because some of them originally didn't source from their respective `$app_mozconfigs/common`. * Modify `baseconfig.mk` to change tiers if running rusttests. * Adjust CI config to use new "rusttests" build application. Differential Revision: https://phabricator.services.mozilla.com/D106294
697524537cc4d91ba6f65c4ff5886dcebb4cc238: Bug 1683797: Removes redundant path parsing r=sheehan,firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Mar 2021 14:45:25 +0000 - rev 570303
Push 138028 by mhentges@mozilla.com at Tue, 09 Mar 2021 15:50:58 +0000
Bug 1683797: Removes redundant path parsing r=sheehan,firefox-build-system-reviewers,glandium We already know the project name, we should unbundle it from the project path. This change is possible due to the work in 1664083, and puts us back to the state before 1255185. Differential Revision: https://phabricator.services.mozilla.com/D106293
3457334cbaf9f6afac6c5e8e9e2d46b988e9ff9f: Bug 1683797: Removes unnecessary lines from client.mk r=sheehan,firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 09 Mar 2021 14:45:24 +0000 - rev 570302
Push 138028 by mhentges@mozilla.com at Tue, 09 Mar 2021 15:50:58 +0000
Bug 1683797: Removes unnecessary lines from client.mk r=sheehan,firefox-build-system-reviewers,glandium CWD and BUILDSTATUS are never used. Differential Revision: https://phabricator.services.mozilla.com/D102661
689a1cf89246f297d1920a97be757be9fca9eea2: Bug 1696091 - Add arm64 mac rustup. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 08 Mar 2021 21:31:25 +0000 - rev 570146
Push 137943 by mh@glandium.org at Mon, 08 Mar 2021 21:40:23 +0000
Bug 1696091 - Add arm64 mac rustup. r=firefox-build-system-reviewers,sheehan,mhentges Differential Revision: https://phabricator.services.mozilla.com/D107028
eb4dc4d7458a10b75eeb087ad620d55000a0c247: Bug 1696091 - Upgrade rustup to 1.23.1. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 08 Mar 2021 21:31:24 +0000 - rev 570145
Push 137943 by mh@glandium.org at Mon, 08 Mar 2021 21:40:23 +0000
Bug 1696091 - Upgrade rustup to 1.23.1. r=firefox-build-system-reviewers,sheehan,mhentges Differential Revision: https://phabricator.services.mozilla.com/D107027
e6af2e83be51b739fa7b6d491e5d62a645eb3c6b: Bug 1696091 - Convert python/mozboot/mozboot/rust.py's __main__ to python 3. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 08 Mar 2021 21:31:24 +0000 - rev 570144
Push 137943 by mh@glandium.org at Mon, 08 Mar 2021 21:40:23 +0000
Bug 1696091 - Convert python/mozboot/mozboot/rust.py's __main__ to python 3. r=firefox-build-system-reviewers,sheehan,mhentges - Replace urllib2.urlopen with requests.get. We use requests because http_download_and_hash, which is also used by __main__ uses it already. - Convert byte strings to unicode strings. - Don't wrap sys.stdout, and instead explicitly flush when wanted. Differential Revision: https://phabricator.services.mozilla.com/D107026
3af883f4bba95c2f340ded6c5f4afcfb9da3da6c: Bug 1696097 - Add missing sysroot dependency to source-test tasks. r=andi,sheehan
Mike Hommey <mh+mozilla@glandium.org> - Wed, 03 Mar 2021 21:10:56 +0000 - rev 569541
Push 137682 by mh@glandium.org at Wed, 03 Mar 2021 21:13:21 +0000
Bug 1696097 - Add missing sysroot dependency to source-test tasks. r=andi,sheehan Differential Revision: https://phabricator.services.mozilla.com/D107036
c4da2e122b22d646634c9486286077192df426dd: Bug 1694785 - Add debian-debug archive to apt sources in docker images. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 08:17:03 +0000 - rev 569236
Push 137491 by mh@glandium.org at Tue, 02 Mar 2021 08:19:33 +0000
Bug 1694785 - Add debian-debug archive to apt sources in docker images. r=firefox-build-system-reviewers,sheehan,mhentges We're going to need them for -dbgsym packages shortly. Differential Revision: https://phabricator.services.mozilla.com/D106401
6ceacb906b5ec8ca996b937963aaf613964ee816: Bug 1694318 - Remove the js rust crate. r=jandem,sheehan
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 08:09:35 +0000 - rev 569233
Push 137490 by mh@glandium.org at Tue, 02 Mar 2021 08:12:07 +0000
Bug 1694318 - Remove the js rust crate. r=jandem,sheehan The sm-rust-bindings task that builds and runs tests for it actually only doesn't fail by three(!) distinct happenstances of chance: - It somehow doesn't hit a race condition that can happen, but that attempting to change the build process for jsglue.cpp did, - The second call to `cargo test` without `--feature debugmozjs` only works because nothing was cleaned up from the first and the second build uses artifacts from the first that are otherwise not there if only running the second. - The addition of rust code to spidermonkey (the jsrust crate in js/src/rust) somehow didsn't cause problems in the current configuration, but in other configurations (which fixing the second thing above unveils) the build fails because of the multiple definition of rust_eh_personality between the jsrust staticlib and the rust stdlib that rustc links to test programs. On top of all the above, the content of the crate in mozilla-central has not received updates from upstream servo in years, and doesn't reflect what servo actually uses. Differential Revision: https://phabricator.services.mozilla.com/D106389
7343545da718a5267f8ca8f4947c8cc0dc2d4265: Bug 1694784 - Run the linux64 PGO profiling step on the ubuntu1804-test image. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 02:06:38 +0000 - rev 569211
Push 137480 by mh@glandium.org at Tue, 02 Mar 2021 02:09:18 +0000
Bug 1694784 - Run the linux64 PGO profiling step on the ubuntu1804-test image. r=firefox-build-system-reviewers,sheehan,mhentges Initially, they were using a debian7-amd64-build image, when linux64 were the only 3-step PGO builds. There wasn't really a profound reason not to use another image. Then later bug 632954 and bug 1561147 added android and linux32, using desktop1604-test images, the test image back then, with no rationale given as to why using different image than builds, but there's also no reason not to use the test images. As we're going to remove things from the build images that will probably prevent the profiling step to run, we might as well use the test image (now ubuntu1804-test) everywhere. Differential Revision: https://phabricator.services.mozilla.com/D106356
1d6c269de136c49265e44a926a95a11bb15d3e8c: Bug 1694784 - Move valgrind install to the valgrind docker image. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 02:06:38 +0000 - rev 569210
Push 137480 by mh@glandium.org at Tue, 02 Mar 2021 02:09:18 +0000
Bug 1694784 - Move valgrind install to the valgrind docker image. r=firefox-build-system-reviewers,andi,sheehan,mhentges We don't need the valgrind package for the valgrind.h header anymore, because it's in the sysroot, and we only needed the package in the build docker image because of the header. We still do need it in the valgrind build image, because we run valgrind in the builds using that image. The valgrind build image Dockerfile doesn't need an update because valgrind will be pulled through the install of valgrind-dbg that already happens there. Differential Revision: https://phabricator.services.mozilla.com/D106355
548cb3f5b4a95c2c78e9d1233fcbcbebb1f6b698: Bug 1694784 - Remove the debian8-i386-build docker image. r=firefox-build-system-reviewers,andi,mhentges,sheehan
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 02:06:37 +0000 - rev 569209
Push 137480 by mh@glandium.org at Tue, 02 Mar 2021 02:09:18 +0000
Bug 1694784 - Remove the debian8-i386-build docker image. r=firefox-build-system-reviewers,andi,mhentges,sheehan Now that all builds are using a sysroot, they don't need a specifically different docker image to cross-build from x86-64. This also means we don't need to build 32-bits specific packages anymore, so we don't need the docker image to build them either (although in theory, we might need it if we even need to build packages for the sysroot later on, but we'll be able to dig this out if we actually come to that). Subsequently, this means we don't need the debian8-i386-raw image either. Differential Revision: https://phabricator.services.mozilla.com/D106354
e26c2b5cd2cebebd4620c971fab2ab96b6bc16ca: Bug 1694784 - Switch Linux builds to using sysroots. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 02:06:37 +0000 - rev 569208
Push 137480 by mh@glandium.org at Tue, 02 Mar 2021 02:09:18 +0000
Bug 1694784 - Switch Linux builds to using sysroots. r=firefox-build-system-reviewers,andi,sheehan,mhentges Differential Revision: https://phabricator.services.mozilla.com/D106353
c1f943c83a23b54d38567af4bb3322924b09ac12: Bug 1694784 - Add a flag allowing to pick a sysroot manually. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 02 Mar 2021 02:06:36 +0000 - rev 569207
Push 137480 by mh@glandium.org at Tue, 02 Mar 2021 02:09:18 +0000
Bug 1694784 - Add a flag allowing to pick a sysroot manually. r=firefox-build-system-reviewers,sheehan,mhentges Spidermonkey package builds don't have MOZ_AUTOMATION set (for good reasons), which means they don't automatically get the sysroot through MOZ_FETCHES_DIR. We need a way for that particular build to set its sysroot. Because the setup for sysroot is more elaborated than adding --sysroot to C{,XX}FLAGS, it's more convenient to have an option for this. And while at it, we might as well make that a full-fledged option, although, we only make it available when targetting Linux (although it could be useful for other OSes, but there's overlap with other options on Android, and Mac, so for now, Linux-only will do). This also allows to pass --without-sysroot along with --enable-bootstrap, where the bootstrapped sysroot is not used. Differential Revision: https://phabricator.services.mozilla.com/D106352
fc9dc45f4b483c0045bd4fc6b32909153aae4971: Bug 1694323 - Upgrade psutil to 5.8.0. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Feb 2021 02:45:59 +0000 - rev 568548
Push 137084 by mh@glandium.org at Wed, 24 Feb 2021 02:48:18 +0000
Bug 1694323 - Upgrade psutil to 5.8.0. r=firefox-build-system-reviewers,andi,sheehan,mhentges It is the first version that comes with wheels for most platforms. Differential Revision: https://phabricator.services.mozilla.com/D106066
157a73961937e5e70a18e8906c68f2fa7f88bb3a: Bug 1694296 - Remove the debian8-amd64-build-base docker image. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Feb 2021 02:17:14 +0000 - rev 568546
Push 137082 by mh@glandium.org at Wed, 24 Feb 2021 02:19:36 +0000
Bug 1694296 - Remove the debian8-amd64-build-base docker image. r=firefox-build-system-reviewers,andi,sheehan,mhentges It was added back when we were using Debian 7-based images, and we were using a more recent version of Gtk than available in Debian 7 in the normal Firefox build. We've since upgraded to Debian 8 and removed the difference. Differential Revision: https://phabricator.services.mozilla.com/D106055
f38a5ca56cb323bf779ac9d54a8fde8224812a06: Bug 1693725 - Make --enable-bootstrap install missing toolchains. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Wed, 24 Feb 2021 02:13:10 +0000 - rev 568544
Push 137080 by mh@glandium.org at Wed, 24 Feb 2021 02:15:28 +0000
Bug 1693725 - Make --enable-bootstrap install missing toolchains. r=firefox-build-system-reviewers,andi,sheehan,mhentges This means --enable-bootstrap now is the same as what --enable-bootstrap=install currently does. --enable-bootstrap=install is at the same time desupported. We also remove --enable-bootstrap=update, which is not worth supporting. Differential Revision: https://phabricator.services.mozilla.com/D105719
972015c5c2a692739851d891b6c8de585f698add: Bug 1694344 - Fix --with-ccache after bug 1693689. r=firefox-build-system-reviewers,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 23 Feb 2021 20:52:00 +0000 - rev 568513
Push 137062 by mh@glandium.org at Tue, 23 Feb 2021 20:55:21 +0000
Bug 1694344 - Fix --with-ccache after bug 1693689. r=firefox-build-system-reviewers,sheehan,mhentges Because --with-ccache without a value fulfills a @depends_if, we need to check for the length. And because we check the length, we can just use a @depends. Differential Revision: https://phabricator.services.mozilla.com/D106084
0776d1d44892053e8a05905227cf8f6e5437babd: Bug 1693689 - Avoid bootstrapping toolchains unless needed. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Tue, 23 Feb 2021 03:34:04 +0000 - rev 568359
Push 136998 by mh@glandium.org at Tue, 23 Feb 2021 03:36:26 +0000
Bug 1693689 - Avoid bootstrapping toolchains unless needed. r=firefox-build-system-reviewers,andi,sheehan,mhentges - Only bootstrap sccache when building with --with-ccache=sccache or CCACHE=sccache - Don't bootstrap dump_syms or nasm on builds that don't compile Differential Revision: https://phabricator.services.mozilla.com/D105704
ae1ac7549cebfe5266eef44973b3f84c2417a391: Bug 1693717 - Remove paths_have_priority argument to check_prog. r=firefox-build-system-reviewers,andi,sheehan,mhentges
Mike Hommey <mh+mozilla@glandium.org> - Mon, 22 Feb 2021 22:20:42 +0000 - rev 568323
Push 136972 by mh@glandium.org at Mon, 22 Feb 2021 22:23:32 +0000
Bug 1693717 - Remove paths_have_priority argument to check_prog. r=firefox-build-system-reviewers,andi,sheehan,mhentges It hasn't been used since bug 1482435. Differential Revision: https://phabricator.services.mozilla.com/D105715