searching for reviewer(sg)
6bbcff6c9413843d4c253cd887b89c2e85ac4bfd: Bug 1496997 - Remove rest of child intercept code from dom/serviceworkers r=asuth,dom-workers-and-storage-reviewers,sg,jdescottes,nchevobbe
Yaron Tausky <ytausky@mozilla.com> - Tue, 08 Jun 2021 21:02:54 +0000 - rev 582390
Push 144584 by ytausky@mozilla.com at Tue, 08 Jun 2021 21:05:43 +0000
Bug 1496997 - Remove rest of child intercept code from dom/serviceworkers r=asuth,dom-workers-and-storage-reviewers,sg,jdescottes,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D101763
52428b37d9ec1900a075caf4c4becbf6b2020396: Bug 1496997 - Remove a chunk of child intercept code from dom/serviceworkers r=asuth,dom-workers-and-storage-reviewers,sg
Yaron Tausky <ytausky@mozilla.com> - Tue, 08 Jun 2021 21:02:54 +0000 - rev 582389
Push 144584 by ytausky@mozilla.com at Tue, 08 Jun 2021 21:05:43 +0000
Bug 1496997 - Remove a chunk of child intercept code from dom/serviceworkers r=asuth,dom-workers-and-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D101632
10f3e7d643a76f69c026f17f3b867cd3e7473070: Bug 1700676 - Unregister the lock itself before unblock other locks; r=dom-storage-reviewers,sg,janv
Tom Tung <shes050117@gmail.com> - Fri, 16 Apr 2021 01:09:11 +0000 - rev 576337
Push 141249 by shes050117@gmail.com at Fri, 16 Apr 2021 01:11:46 +0000
Bug 1700676 - Unregister the lock itself before unblock other locks; r=dom-storage-reviewers,sg,janv Differential Revision: https://phabricator.services.mozilla.com/D109640
d05d2e1fc2a1e6f9decdce457d906e53b89d399e: Bug 1655953 - Remove mutex lock for protecting the padding file; r=dom-workers-and-storage-reviewers,sg,asuth,janv
Tom Tung <ttung@mozilla.com> - Fri, 16 Apr 2021 01:09:10 +0000 - rev 576335
Push 141249 by shes050117@gmail.com at Fri, 16 Apr 2021 01:11:46 +0000
Bug 1655953 - Remove mutex lock for protecting the padding file; r=dom-workers-and-storage-reviewers,sg,asuth,janv Depends on D81680 Differential Revision: https://phabricator.services.mozilla.com/D85279
c1f839b8a6c4d380328a2315e33681da2d97a069: Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail; r=dom-workers-and-storage-reviewers,sg,janv
Tom Tung <ttung@mozilla.com> - Fri, 16 Apr 2021 01:09:10 +0000 - rev 576334
Push 141249 by shes050117@gmail.com at Fri, 16 Apr 2021 01:11:46 +0000
Bug 1648399 - Add test cases to ensure that a cache/ls directory in permanent origin directory shouldn't cause storage init to fail; r=dom-workers-and-storage-reviewers,sg,janv Depends on D80824 Differential Revision: https://phabricator.services.mozilla.com/D81680
615d4abfd69e8d9952440e4e813df29ed79a90e3: Bug 1334986 - changed the parameters in declarations and definitions of Transaction Base::VerifyRequestParams. r=sg
Snehaa2296 <snehasai01@gmail.com> - Wed, 14 Apr 2021 11:44:24 +0000 - rev 575892
Push 141017 by kgupta@mozilla.staktrace.com at Wed, 14 Apr 2021 11:46:48 +0000
Bug 1334986 - changed the parameters in declarations and definitions of Transaction Base::VerifyRequestParams. r=sg Depends on D106257 Differential Revision: https://phabricator.services.mozilla.com/D106584
52ad8ad061ae6f623f937efc76e664bddab610aa: Bug 1687318 - Changed unscoped enum FileFlag to scoped enum class. r=sg
p1nk <camperdue42@gmail.com> - Thu, 25 Mar 2021 09:18:04 +0000 - rev 573042
Push 139448 by sgiesecke@mozilla.com at Thu, 25 Mar 2021 09:20:29 +0000
Bug 1687318 - Changed unscoped enum FileFlag to scoped enum class. r=sg Differential Revision: https://phabricator.services.mozilla.com/D109462
bb08fc2c750e013498236a40c2f8eed5c99538d5: Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers
Jan Varga <jvarga@mozilla.com> - Wed, 24 Mar 2021 12:27:53 +0000 - rev 572856
Push 139365 by jvarga@mozilla.com at Wed, 24 Mar 2021 12:30:15 +0000
Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers This patch: - adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros - adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros - adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros - replaces non-propagating uses of NS_WARNING with redundant messages by QM_WARNONLY_TRY - replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...)) - replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY - replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY. - replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY - replaces uses of QM_TRY with additional Maybe wrapping for doing a fallback with QM_TRY(QM_OR_ELSE_WARN(...)) Differential Revision: https://phabricator.services.mozilla.com/D108424
fd02d8dbadf0d8a39f8cf34fda4aaec4b2c62c76: Bug 1700498 - nsTSetInserter::operator* returns a proxy - r=sg
Gerald Squelart <gsquelart@mozilla.com> - Wed, 24 Mar 2021 10:25:23 +0000 - rev 572844
Push 139355 by gsquelart@mozilla.com at Wed, 24 Mar 2021 10:27:47 +0000
Bug 1700498 - nsTSetInserter::operator* returns a proxy - r=sg Previously `operator*` returned the iterator, and the templated `operator=` would handle the value insertion. However that `operator=` prevented a defaulted copy-assignment operator, which is used in some algorithms to overwrite the iterator itself. So now `operator*` returns a proxy, which implements the templated `operator=` that is used to insert a value. This allows the nsTSetInserter to have a its defaulted `operator=`. Side-effect: `E` (the hash's KeyClass) is not needed anymore in nsTSetInserter, so it's only templated on the set type. Tech note: `std::back_insert_iterator` doesn't use a value, but has explicitly-defined `operator=(const typename Container::value_type&)` and `operator=(typename Container::value_type&&)`. Unfortunately, some of our stored value types are references (e.g.: `nsStringHashKey::KeyType` is `const nsAString&`), which, due to reference collapsing, would have made both `operator=`'s have the same signature! That's why this implementation uses a proxy sub-type with a single templated `operator=` that can handle anything. Differential Revision: https://phabricator.services.mozilla.com/D109587
2a3316bd2409459708d287c82deaeb04ed29e28e: Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers
Jan Varga <jvarga@mozilla.com> - Wed, 24 Mar 2021 04:40:10 +0000 - rev 572822
Push 139340 by jvarga@mozilla.com at Wed, 24 Mar 2021 04:42:37 +0000
Bug 1686191 - Have a way to specifically report warnings around QM_TRY; r=asuth,sg,dom-storage-reviewers This patch: - adds QM_WARNONLY_TRY/QM_NOTEONLY_TRY macros - adds QM_WARNONLY_TRY_UNWRAP/QM_NOTEONLY_TRY_UNWRAP macros - adds QM_OR_ELSE_WARN/QM_OR_ELSE_NOTE sub macros - replaces non-propagating uses of NS_WARNING with redundant messages by QM_WARNONLY_TRY - replaces uses of QM_TRY with orElse by QM_TRY(QM_OR_ELSE_WARN(...)) - replaces uses of QM_TRY inside an extra lambda with QM_WARNONLY_TRY - replaces uses of QM_TRY with QM_VOID with QM_WARNONLY_TRY. - replaces uses of QM_TRY with unwanted warnings with QM_NOTEONLY_TRY - replaces uses of QM_TRY with additional Maybe wrapping for doing a fallback with QM_TRY(QM_OR_ELSE_WARN(...)) Differential Revision: https://phabricator.services.mozilla.com/D108424
027cc5c8b2b66ba1be5b48a1e81be91fbd04a765: Bug 1694008 - add null check for getting nsIPK11TokenDB service (to prevent crash). r=kaie,sg DONTBUILD
Magnus Melin <mkmelin+mozilla@iki.fi> - Fri, 19 Mar 2021 13:21:58 +0000 - rev 572117
Push 138991 by mkmelin@iki.fi at Fri, 19 Mar 2021 13:24:22 +0000
Bug 1694008 - add null check for getting nsIPK11TokenDB service (to prevent crash). r=kaie,sg DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D109055
47b068651034043112384ba17f5ec85c56ef121b: Bug 1500116 - Allow mActorDestroyed to be set to true more than one time; r=dom-storage-reviewers,sg
Tom Tung <shes050117@gmail.com> - Thu, 18 Mar 2021 18:45:43 +0000 - rev 571853
Push 138931 by archaeopteryx@coole-files.de at Thu, 18 Mar 2021 18:48:07 +0000
Bug 1500116 - Allow mActorDestroyed to be set to true more than one time; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D108918
0c05f550cd505f8c4b90f78efefe44d88e62049c: Bug 1697115 - Rationalize QuotaManager::ResetUsageForClient arguments; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:39 +0000 - rev 571565
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rationalize QuotaManager::ResetUsageForClient arguments; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107616
9a0b8feeb17e435889551cdf1821cd6451053ce2: Bug 1697115 - Rationalize QuotaManager::DecreaseUsageForClient arguments; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:39 +0000 - rev 571564
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rationalize QuotaManager::DecreaseUsageForClient arguments; r=dom-storage-reviewers,sg Note that the method DecreaseUsageForOrigin has been renamed to DecreaseUsageForClient. Differential Revision: https://phabricator.services.mozilla.com/D107615
622ad02cf19ff72b9e4f13df3bdfc705df8f2c75: Bug 1697115 - Rationalize QuotaManager::NoteOriginDirectoryCreated arguments and return type; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:39 +0000 - rev 571563
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rationalize QuotaManager::NoteOriginDirectoryCreated arguments and return type; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107614
4a29789e1ae7ebaaff18bf59548c4c03533f38d0: Bug 1697115 - Rationalize QuotaManager::EnsureQuotaForOrigin arguments; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:38 +0000 - rev 571562
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rationalize QuotaManager::EnsureQuotaForOrigin arguments; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107612
863dd161688763b2304f779b50f5dc6623adfa00: Bug 1697115 - Rationalize QuotaManager::InitQuotaForOrigin arguments; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:38 +0000 - rev 571561
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rationalize QuotaManager::InitQuotaForOrigin arguments; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107611
815c6296df887017ba12d7f433a52f5c9155046a: Bug 1697115 - Use FullOriginMetadata instead of OriginMetadata in QuotaManager::LoadQuota::LoadQuotaFromCache; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:38 +0000 - rev 571560
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Use FullOriginMetadata instead of OriginMetadata in QuotaManager::LoadQuota::LoadQuotaFromCache; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107610
a622940123e6a02c13e6ab542e216d9f93319bbb: Bug 1697115 - Rename mTimestamp to mLastAccessTime in FullOriginMetadata; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 17 Mar 2021 06:56:37 +0000 - rev 571559
Push 138749 by jvarga@mozilla.com at Wed, 17 Mar 2021 06:59:21 +0000
Bug 1697115 - Rename mTimestamp to mLastAccessTime in FullOriginMetadata; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107609
f9a8f6b334ef14efffca86881e67d4764db617bd: Bug 1571631 - Remove MOZ_MUST_USE definition. r=sg
Chris Peterson <cpeterson@mozilla.com> - Wed, 17 Mar 2021 03:01:21 +0000 - rev 571543
Push 138742 by cpeterson@mozilla.com at Wed, 17 Mar 2021 03:03:47 +0000
Bug 1571631 - Remove MOZ_MUST_USE definition. r=sg Depends on D108345 Differential Revision: https://phabricator.services.mozilla.com/D108346
32c92dfb8fe712b1461344793ea970a454edfa43: Bug 1571631 - Replace MOZ_MUST_USE with [[nodiscard]] in mfbt. r=sg
Chris Peterson <cpeterson@mozilla.com> - Wed, 17 Mar 2021 03:01:21 +0000 - rev 571542
Push 138742 by cpeterson@mozilla.com at Wed, 17 Mar 2021 03:03:47 +0000
Bug 1571631 - Replace MOZ_MUST_USE with [[nodiscard]] in mfbt. r=sg Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's __attribute__((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers. Depends on D108344 Differential Revision: https://phabricator.services.mozilla.com/D108345
1de71b8527c2de37dc9946b7f05dba92fa781ef8: Bug 1686031 - Rename OriginMetadata.h to CommonMetadata.h; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 11 Mar 2021 05:53:17 +0000 - rev 570652
Push 138254 by jvarga@mozilla.com at Thu, 11 Mar 2021 05:55:43 +0000
Bug 1686031 - Rename OriginMetadata.h to CommonMetadata.h; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107608
f5f020daba36d957a2a3fa106c1ad1768b7df1a3: Bug 1686031 - Rename GetDirectoryMetadataWithOriginMetadata2 to LoadFullOriginMetadata and GetDirectoryMetadataWithOriginMetadata2WithRestore to LoadFullOriginMetadataWithRestore; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 10 Mar 2021 08:34:53 +0000 - rev 570451
Push 138125 by jvarga@mozilla.com at Wed, 10 Mar 2021 09:14:26 +0000
Bug 1686031 - Rename GetDirectoryMetadataWithOriginMetadata2 to LoadFullOriginMetadata and GetDirectoryMetadataWithOriginMetadata2WithRestore to LoadFullOriginMetadataWithRestore; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107607
9ef8072221e8949de8036b96d48adb33837a5b4b: Bug 1686031 - Replace GetDirectoryResultWithOriginMetadata with FullOriginMetadata; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 10 Mar 2021 08:34:52 +0000 - rev 570450
Push 138125 by jvarga@mozilla.com at Wed, 10 Mar 2021 09:14:26 +0000
Bug 1686031 - Replace GetDirectoryResultWithOriginMetadata with FullOriginMetadata; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107605
fdbbd2ea32c3c17632e91b338bdfbbc9f8a07197: Bug 1695906 - Use NotNull for StorageOperationsBase::OriginProps::mDirectory; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 10 Mar 2021 08:34:52 +0000 - rev 570449
Push 138125 by jvarga@mozilla.com at Wed, 10 Mar 2021 09:14:26 +0000
Bug 1695906 - Use NotNull for StorageOperationsBase::OriginProps::mDirectory; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106908
913f16ccb0652722586c078963c72d1bb844b956: Bug 1686031 - Fix storage upgrades and restoration of the metadata file to use proper persistence type internally; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 10 Mar 2021 05:53:03 +0000 - rev 570431
Push 138114 by jvarga@mozilla.com at Wed, 10 Mar 2021 06:58:23 +0000
Bug 1686031 - Fix storage upgrades and restoration of the metadata file to use proper persistence type internally; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106907
43a39c4915482bf1e684fc5829f4640f259572aa: Bug 1686031 - Rename GetDirectoryMetadataWithOriginMetadata2 to LoadFullOriginMetadata and GetDirectoryMetadataWithOriginMetadata2WithRestore to LoadFullOriginMetadataWithRestore; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Tue, 09 Mar 2021 19:02:00 +0000 - rev 570358
Push 138061 by jvarga@mozilla.com at Tue, 09 Mar 2021 19:04:34 +0000
Bug 1686031 - Rename GetDirectoryMetadataWithOriginMetadata2 to LoadFullOriginMetadata and GetDirectoryMetadataWithOriginMetadata2WithRestore to LoadFullOriginMetadataWithRestore; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107607
9be2fd0b5b6a4ece2514a70d1c8b3bf3ca8b9ded: Bug 1686031 - Replace GetDirectoryResultWithOriginMetadata with FullOriginMetadata; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Tue, 09 Mar 2021 19:02:00 +0000 - rev 570357
Push 138061 by jvarga@mozilla.com at Tue, 09 Mar 2021 19:04:34 +0000
Bug 1686031 - Replace GetDirectoryResultWithOriginMetadata with FullOriginMetadata; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D107605
f483f50d292a1da61bc1294bb832522b1aa65b85: Bug 1695906 - Use NotNull for StorageOperationsBase::OriginProps::mDirectory; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Tue, 09 Mar 2021 19:01:59 +0000 - rev 570356
Push 138061 by jvarga@mozilla.com at Tue, 09 Mar 2021 19:04:34 +0000
Bug 1695906 - Use NotNull for StorageOperationsBase::OriginProps::mDirectory; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106908
470d617d76739c4d09327b034e582fa7ec445671: Bug 1686031 - Fix storage upgrades and restoration of the metadata file to use proper persistence type internally; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Tue, 09 Mar 2021 19:01:59 +0000 - rev 570355
Push 138061 by jvarga@mozilla.com at Tue, 09 Mar 2021 19:04:34 +0000
Bug 1686031 - Fix storage upgrades and restoration of the metadata file to use proper persistence type internally; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106907
c69b2c1ef6f9c9eb8b7f192495d4f190525255a0: Bug 1686031 - Fix GetDirectoryMetadataWithOriginMetadata2 and GetDirectoryMetadataWithOriginMetadata2WithRestore to return proper persistence type; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 05 Mar 2021 04:48:38 +0000 - rev 569789
Push 137825 by jvarga@mozilla.com at Fri, 05 Mar 2021 04:51:03 +0000
Bug 1686031 - Fix GetDirectoryMetadataWithOriginMetadata2 and GetDirectoryMetadataWithOriginMetadata2WithRestore to return proper persistence type; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106906
fe6d06b48c5f5d89ca9bea0bbac05854d5832039: Bug 1695903 - QM: Add PersistenceTypeFromFile method; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 21:05:57 +0000 - rev 569741
Push 137788 by jvarga@mozilla.com at Thu, 04 Mar 2021 21:37:13 +0000
Bug 1695903 - QM: Add PersistenceTypeFromFile method; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106904
bc41e3cc67544f8c9803907d0104a831cb5d555f: Bug 1686031 - Add mPersistenceType to OriginMetadata; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 18:03:02 +0000 - rev 569703
Push 137766 by jvarga@mozilla.com at Thu, 04 Mar 2021 18:05:28 +0000
Bug 1686031 - Add mPersistenceType to OriginMetadata; r=dom-storage-reviewers,sg The existing members of OriginMetadata have been extracted to a parent struct called PrincipalMetadata. Methods like GetOriginUsage, GetInfoFromValidatedPrincipalInfo, GetInfoFromPrincipal and GetInfoForChrome have been changed to take/return PrincipalMetadata instead of OriginMetadata. Having the persistence type doesn't make sense in those methods because the origin is not tied to a specific persistence type in context of the methods. Some places temporarily pass PERSISTENCE_TYPE_INVALID and will be fixed in following patches. Differential Revision: https://phabricator.services.mozilla.com/D106400
336c31529dbb0068c3291576535af7e27b49de14: Bug 1686031 - Introduce OriginInfo::FlattenToOriginMetadata and make use of it; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:42 +0000 - rev 569651
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Introduce OriginInfo::FlattenToOriginMetadata and make use of it; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106399
e14e574f9f4be9bff2d2ff72b2e6a29df72c787d: Bug 1686031 - Move mGroup from GroupInfo to GroupInfoPair; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:41 +0000 - rev 569650
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Move mGroup from GroupInfo to GroupInfoPair; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106398
7c04f2a9a36524c8ed1dc79081030c18a584bbcf: Bug 1686031 - Change SaveCacheVersion, CreateCacheTables and UpgradeCacheFrom1To2 to take a reference instead of a raw pointer; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:41 +0000 - rev 569649
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Change SaveCacheVersion, CreateCacheTables and UpgradeCacheFrom1To2 to take a reference instead of a raw pointer; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106397
4f7704ba36ed8759199ca400bd3aa6ceb5636d8f: Bug 1686031 - Construct OriginMetadata with real suffix in DirectoryLockImpl::OriginMetadata; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:40 +0000 - rev 569648
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Construct OriginMetadata with real suffix in DirectoryLockImpl::OriginMetadata; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106396
7f46c92e18337584cdaf7a30a84b96997e52b531: Bug 1686031 - Construct OriginMetadata with real suffix in PersistedOp::DoDirectoryWork; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:40 +0000 - rev 569647
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Construct OriginMetadata with real suffix in PersistedOp::DoDirectoryWork; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106395
93933a2da1a76b14bdbf28dd63f12b4015a4d52c: Bug 1686031 - Construct OriginMetadata with real suffix in GetOriginUsageOp::DoDirectoryWork; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:40 +0000 - rev 569646
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Construct OriginMetadata with real suffix in GetOriginUsageOp::DoDirectoryWork; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D106394
6a2d82b48f78828314fbb7a7d94f655aabc39cee: Bug 1686031 - Add suffix to OriginInfoPair and quota info cache; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 11:07:39 +0000 - rev 569645
Push 137731 by jvarga@mozilla.com at Thu, 04 Mar 2021 11:10:24 +0000
Bug 1686031 - Add suffix to OriginInfoPair and quota info cache; r=dom-storage-reviewers,sg This fixes the two spots where we were always passing an empty suffix to OriginMetadata. Differential Revision: https://phabricator.services.mozilla.com/D106131
aada018490c4fe60ebd8cc76e014c6dcd734de85: Bug 1695883 - Add explicit fallible mozStorageTransaction::Start method for starting the transaction; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Thu, 04 Mar 2021 04:38:06 +0000 - rev 569609
Push 137712 by jvarga@mozilla.com at Thu, 04 Mar 2021 04:40:29 +0000
Bug 1695883 - Add explicit fallible mozStorageTransaction::Start method for starting the transaction; r=dom-storage-reviewers,sg The new method is mandatory because mozStorageTransaction constructor no longer starts the transaction. It must be started explicitely. All consumers have been adjusted, but only dom/quota, dom/indexedDB, dom/cache, dom/localstorage and dom/storage handle the error. Other components like netwerk/cache, netwerk/cookie and toolkit/components currently only warn on failure to start a transaction. Bug 1696129, 1696130 and 1696133 have been filed for proper handling of transaction start failures in those components. Differential Revision: https://phabricator.services.mozilla.com/D106893
316fdd5817ae62591d1c63f983ab608765096ce7: Bug 1694231 - Add support for nested mozStorageTransaction using savepoints; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Wed, 03 Mar 2021 18:53:14 +0000 - rev 569533
Push 137674 by jvarga@mozilla.com at Wed, 03 Mar 2021 19:13:20 +0000
Bug 1694231 - Add support for nested mozStorageTransaction using savepoints; r=dom-storage-reviewers,sg The nesting level is tracked on the storage connection. The thread safety is ensured by holding a lock while a transaction is being started/commited/rolled back. For these purposes, the sharedDBMutex has been exposed on mozIStorageConnection interface and additional helper methods have been added to the interface as well. Differential Revision: https://phabricator.services.mozilla.com/D106019
5978eab7b4a3964ceb73931018df219f4a5aba76: Bug 1694161 - some fixes for the MacOS non unified environment. r=sg
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Sat, 27 Feb 2021 08:05:46 +0000 - rev 569019
Push 137355 by bpostelnicu@mozilla.com at Sat, 27 Feb 2021 08:08:17 +0000
Bug 1694161 - some fixes for the MacOS non unified environment. r=sg Differential Revision: https://phabricator.services.mozilla.com/D106616
0fb8a1114e84d41299e78edcbb1b6a741c7961a0: Bug 1694161 - some fixes for the MacOS non unified environment. r=sg
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Fri, 26 Feb 2021 16:39:18 +0000 - rev 568964
Push 137310 by bpostelnicu@mozilla.com at Fri, 26 Feb 2021 16:41:38 +0000
Bug 1694161 - some fixes for the MacOS non unified environment. r=sg Depends on D105977 Differential Revision: https://phabricator.services.mozilla.com/D106616
bcd5eeee60ce9eb964d63ec8f23695b2bd20d065: Bug 1693101 - Codegen.py should only include ProfilerLabels.h when a profiler label will be generated, r=sg,peterv
Florian Quèze <florian@queze.net> - Tue, 23 Feb 2021 17:52:18 +0000 - rev 568500
Push 137051 by fqueze@mozilla.com at Tue, 23 Feb 2021 18:50:54 +0000
Bug 1693101 - Codegen.py should only include ProfilerLabels.h when a profiler label will be generated, r=sg,peterv Differential Revision: https://phabricator.services.mozilla.com/D105341
dcc12ac96da9116a71d129cc01347a55f0865a90: Bug 1693741 - Retry removing or renaming of origin directories in StorageOperationBase::MaybeRenameOrigin; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 19 Feb 2021 19:48:31 +0000 - rev 568147
Push 136862 by jvarga@mozilla.com at Fri, 19 Feb 2021 21:46:43 +0000
Bug 1693741 - Retry removing or renaming of origin directories in StorageOperationBase::MaybeRenameOrigin; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D105733
f90b95cab4ef77339b6dc43b1da9b0bf5c20e03e: Bug 1693737 - Add CallWithDelayedRetriesIfAccessDenied helper method; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 19 Feb 2021 19:48:30 +0000 - rev 568146
Push 136862 by jvarga@mozilla.com at Fri, 19 Feb 2021 21:46:43 +0000
Bug 1693737 - Add CallWithDelayedRetriesIfAccessDenied helper method; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D105732
5badb148963fe474201b68a661678656b1cf5b1d: Bug 1693741 - Share code for origin renaming between storage upgrade classes; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 19 Feb 2021 19:48:30 +0000 - rev 568145
Push 136862 by jvarga@mozilla.com at Fri, 19 Feb 2021 21:46:43 +0000
Bug 1693741 - Share code for origin renaming between storage upgrade classes; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D105731
767c2bd73245bf9e4274281e2eed8f27dbb63c4c: Bug 1693741 - Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 19 Feb 2021 19:48:30 +0000 - rev 568144
Push 136862 by jvarga@mozilla.com at Fri, 19 Feb 2021 21:46:43 +0000
Bug 1693741 - Check for existing targets before renaming origin directories during storage upgrade from v0.0 to v1.0; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D105730
ecc890a10c29d722939d2a7c90e7a3b4dec22a7d: Bug 1693741 - Handle origin renaming during storage upgrade from v0.0 to v1.0 in a dedicated method; r=dom-storage-reviewers,sg
Jan Varga <jvarga@mozilla.com> - Fri, 19 Feb 2021 19:48:29 +0000 - rev 568143
Push 136862 by jvarga@mozilla.com at Fri, 19 Feb 2021 21:46:43 +0000
Bug 1693741 - Handle origin renaming during storage upgrade from v0.0 to v1.0 in a dedicated method; r=dom-storage-reviewers,sg Differential Revision: https://phabricator.services.mozilla.com/D105729