searching for reviewer(nika)
63ef4a835e6c7012d527417b843a3995c66ebac7: Bug 1678310: Expose siteOriginNoSuffix on nsIPrincipal r=baku,nika
Christoph Kerschbaumer <ckerschb@christophkerschbaumer.com> - Sat, 28 Nov 2020 07:21:32 +0000 - rev 558606
Push 131679 by ccoroiu@mozilla.com at Sat, 28 Nov 2020 07:56:21 +0000
Bug 1678310: Expose siteOriginNoSuffix on nsIPrincipal r=baku,nika Differential Revision: https://phabricator.services.mozilla.com/D97605
124e488aae3abf81f24593043ed3073dcc1645a7: Bug 1589103 Unskip browser_privilegedmozilla_process_pref.js r=nika
neha <nkochar@mozilla.com> - Fri, 27 Nov 2020 20:06:08 +0000 - rev 558590
Push 131669 by nlayzell@mozilla.com at Fri, 27 Nov 2020 20:08:46 +0000
Bug 1589103 Unskip browser_privilegedmozilla_process_pref.js r=nika Depends on D98086 Differential Revision: https://phabricator.services.mozilla.com/D98087
484813dea46a20436776138bc01bd320a89458e3: Bug 1589103 Don't wait for SSTabRestored event. This event doesn't get fired when back/forward causes processes switching. r=nika
neha <nkochar@mozilla.com> - Fri, 27 Nov 2020 20:03:09 +0000 - rev 558589
Push 131669 by nlayzell@mozilla.com at Fri, 27 Nov 2020 20:08:46 +0000
Bug 1589103 Don't wait for SSTabRestored event. This event doesn't get fired when back/forward causes processes switching. r=nika Differential Revision: https://phabricator.services.mozilla.com/D98086
de2efe85ed497d61254ee567e3c4d64f3bc16973: Bug 1677541 - Remove unnecessary includes from xpcpublic.h. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:07:06 +0000 - rev 558370
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1677541 - Remove unnecessary includes from xpcpublic.h. r=nika Differential Revision: https://phabricator.services.mozilla.com/D94867 Depends on D94763
f83b80d1aa07cbe28327a0c726f2d52c14e65574: Bug 1660470 - Avoid including MediaControlIPC.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:06:19 +0000 - rev 558365
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including MediaControlIPC.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93564 Depends on D93563
f5374b13d61987635198f29a51cd4e5c56359917: Bug 1660470 - Avoid including MediaSessionIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:06:14 +0000 - rev 558364
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including MediaSessionIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93563 Depends on D93560
b3f5b41533e23dfc7ecd58642bc3ac25b0087610: Bug 1660470 - Avoid including URIUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:06:09 +0000 - rev 558363
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including URIUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93560 Depends on D93559
049348b7e0d862e84648e0f227ece455766a538c: Bug 1660470 - Avoid including PropertyBagUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:06:03 +0000 - rev 558362
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including PropertyBagUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93559 Depends on D93558
59d9e21b9126e1469f134751ee0dc4f3e92b4bdc: Bug 1660470 - Avoid including ReferrerInfoUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:56 +0000 - rev 558361
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including ReferrerInfoUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93558 Depends on D93557
69e2c95ff92b9b123f746b10d65f7a866e69d1e5: Bug 1660470 - Avoid including CSPMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:50 +0000 - rev 558360
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including CSPMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93557 Depends on D93556
387c34582c0247e19b183d365369c30873df71d3: Bug 1660470 - Avoid including BindingIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:44 +0000 - rev 558359
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including BindingIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93556 Depends on D93555
79a76b7cbd44ca1d11458a488c36e17a40f521ca: Bug 1660470 - Avoid including ServiceWorkerIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:38 +0000 - rev 558358
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including ServiceWorkerIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93555 Depends on D93552
c27dc74a06b39bbc2c9d383337eae2a3eda1fd4f: Bug 1660470 - Avoid including PermissionMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:33 +0000 - rev 558357
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including PermissionMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93552 Depends on D93550
0d3b1360e5e89cc0cd6c59aaa9c861b243d520a6: Bug 1660470 - Split SerializedStructuredCloneBuffer.h from IPCMessageUtils.h. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:26 +0000 - rev 558356
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Split SerializedStructuredCloneBuffer.h from IPCMessageUtils.h. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93550 Depends on D93546
10d165db0694399c60f674684e323b907f2e3393: Bug 1660470 - Move void_t/null_t to a new IPCCore.h header. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:20 +0000 - rev 558355
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Move void_t/null_t to a new IPCCore.h header. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93546 Depends on D93544
b0ea0cb1d07abf2e42843a44bdcb65de3cd5a16c: Bug 1660470 - Avoid including ProtocolUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:07 +0000 - rev 558354
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including ProtocolUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93544 Depends on D93543
d43822cff2f3d8340f4bdbda46bdb4f658a4513e: Bug 1660470 - Split ShmemMessageUtils.h from Shmem.h. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:05:02 +0000 - rev 558353
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Split ShmemMessageUtils.h from Shmem.h. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93543 Depends on D93321
73a763fb74282d896d446fc3ce8c0036caeafaaf: Bug 1660470 - Move IPDLParamTraits for FileDescriptor out of FileDescriptor.h. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:55 +0000 - rev 558352
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Move IPDLParamTraits for FileDescriptor out of FileDescriptor.h. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93321 Depends on D93248
c8b64b1dcaf0dded9ed6b1bdd4da62e0a891c229: Bug 1660470 - Avoid including FetchIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:50 +0000 - rev 558351
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including FetchIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93248 Depends on D93246
c587df43720e9fd92b4bb3492d6250334bfd7418: Bug 1660470 - Avoid including nsGUIEventIPC.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:44 +0000 - rev 558350
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including nsGUIEventIPC.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93246 Depends on D93245
666727f2d0b2c5215af982e6e353c8cb8149d020: Bug 1660470 - Avoid including PermissionDelegateIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:39 +0000 - rev 558349
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including PermissionDelegateIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93245 Depends on D93244
b189a72b54a7eb49feca3c30397388a173e7006b: Bug 1660470 - Avoid including DataStorageIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:34 +0000 - rev 558348
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including DataStorageIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93244 Depends on D93243
1f7590a3c06c17664f105887cca001b6d8dcb17c: Bug 1660470 - Avoid including ErrorIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:28 +0000 - rev 558347
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including ErrorIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93243 Depends on D93242
c3d87b114e568743dcb81becb44045c414d97ba7: Bug 1660470 - Avoid including dom/cache/IPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:22 +0000 - rev 558346
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including dom/cache/IPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93242 Depends on D93241
a2b72f7ed2a506c27dcd7a9d0b74998e6e28c082: Bug 1660470 - Avoid including ClientIPCUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:17 +0000 - rev 558345
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including ClientIPCUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93241 Depends on D93240
b35f6638db0c438fb55681ae836d09a8de4d8ff3: Bug 1660470 - Avoid including NeckoMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:12 +0000 - rev 558344
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including NeckoMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93240 Depends on D93239
d324ca922186c456d890aa859abad3be697bcff0: Bug 1660470 - Avoid including DocShellMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:08 +0000 - rev 558343
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including DocShellMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93239 Depends on D93238
e6bd12dabc996da648671ae806daeb6426a6a653: Bug 1660470 - Avoid including WidgetMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:04:01 +0000 - rev 558342
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including WidgetMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93238 Depends on D93237
024ec63a0cba517b94f8b1fdba4b7c7c0c5f7ba8: Bug 1660470 - Avoid including VRMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:03:56 +0000 - rev 558341
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including VRMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93237 Depends on D93236
1091038d01df5444387bb50d7d6fd70b19c5e5dd: Bug 1660470 - Avoid including GamepadMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:03:52 +0000 - rev 558340
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including GamepadMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93236 Depends on D93235
48b0a7ccbe8ae1172482dd2d29aa6bf16b26794b: Bug 1660470 - Avoid including IPCMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:03:47 +0000 - rev 558339
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including IPCMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93235 Depends on D93234
8335f089e0d9415ab602312103f76a354ef718f0: Bug 1660470 - Avoid including GfxMessageUtils.h from header files. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:03:38 +0000 - rev 558338
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Avoid including GfxMessageUtils.h from header files. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93234 Depends on D93233
be2a7a17d1629845eea587a2f42a233fb222f653: Bug 1660470 - Include C++ header files only from cpp file. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:03:32 +0000 - rev 558337
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Include C++ header files only from cpp file. r=nika Differential Revision: https://phabricator.services.mozilla.com/D93233 Depends on D87865
93fabad45659d172b723c9606215d3acaab54df1: Bug 1660470 - Add missing include directives/forward declarations. r=nika
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 16:21:38 +0000 - rev 558336
Push 131543 by malexandru@mozilla.com at Mon, 23 Nov 2020 17:03:38 +0000
Bug 1660470 - Add missing include directives/forward declarations. r=nika Differential Revision: https://phabricator.services.mozilla.com/D87865
8a1861088a72534727768242aa546e8f717965e2: Bug 1677284 - Avoid using PackingStrategy::Variant fallback for CPUUsageWatcherError. r=nika,emilio
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 23 Nov 2020 15:49:02 +0000 - rev 558325
Push 131541 by sgiesecke@mozilla.com at Mon, 23 Nov 2020 15:52:36 +0000
Bug 1677284 - Avoid using PackingStrategy::Variant fallback for CPUUsageWatcherError. r=nika,emilio This also adds an UnusedZeroEnum template to Result.h, which can be used for specializing UnusedZero for scoped enum types. Differential Revision: https://phabricator.services.mozilla.com/D97074
d57553438d94c340a3c617449aab27665bd665fa: Bug 1675329: Add an API for returning an exit code from the application. r=dthayer,necko-reviewers,dragana,nika
Dave Townsend <dtownsend@oxymoronical.com> - Fri, 20 Nov 2020 19:13:34 +0000 - rev 558236
Push 131475 by dtownsend@mozilla.com at Fri, 20 Nov 2020 19:26:07 +0000
Bug 1675329: Add an API for returning an exit code from the application. r=dthayer,necko-reviewers,dragana,nika Callers can pass an exit code to nsIAppStartup::Quit and it will be returned from the process when it exits. Note that I have using uint16_t as the exit code because on Windows the exit code can be a uint and elsewhere it is an int. A uint16_t will safely convert to either of those and no-one will ever need more than 64k exit codes! Differential Revision: https://phabricator.services.mozilla.com/D96857
fb54693d6b4c88df07d11f80773dea749d3cb66b: Bug 1671382 - reset() RaiiShmem if its allocator is invalid. r=nika
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 20 Nov 2020 00:17:38 +0000 - rev 558129
Push 131409 by jgilbert@mozilla.com at Fri, 20 Nov 2020 00:57:45 +0000
Bug 1671382 - reset() RaiiShmem if its allocator is invalid. r=nika Differential Revision: https://phabricator.services.mozilla.com/D96297
6ad5891e7cc074abf631e6066feebb00df8959dd: Bug 1661833 - Fix duplicate OnStateChange events during process switches, r=nika
Anny Gakhokidze <agakhokidze@mozilla.com> - Thu, 19 Nov 2020 23:21:04 +0000 - rev 558119
Push 131403 by agakhokidze@mozilla.com at Thu, 19 Nov 2020 23:26:17 +0000
Bug 1661833 - Fix duplicate OnStateChange events during process switches, r=nika Differential Revision: https://phabricator.services.mozilla.com/D96228
2956f1a4e43a7aec8a12924e89bc48679fbad7f3: Bug 1672263: Use ThrowInvalidStateError with useful messages in JSWindowActorChild. r=nika
Kris Maglione <maglione.k@gmail.com> - Tue, 10 Nov 2020 22:04:49 +0000 - rev 558074
Push 131371 by maglione.k@gmail.com at Thu, 19 Nov 2020 18:37:55 +0000
Bug 1672263: Use ThrowInvalidStateError with useful messages in JSWindowActorChild. r=nika Currently, when JS callers try to access certain JSWindowActors before an actor is initialized, or after it's destroyed, we throw a generic `NS_ERROR_INVALID_STATE_ERROR` exception without any useful information about the failure. This patch changes that to use `ThrowInvalidStateError`, with a message including the property name, the actor name, and details about whether the error occurred because the actor has not been initialized or because it has already been destroyed. Differential Revision: https://phabricator.services.mozilla.com/D96628
2ca4e50483b9093c431bcf29f5844e09eab10fe4: Bug 1676996 - Don't try to process-switch a remote frame to local. r=nika
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 19 Nov 2020 17:44:30 +0000 - rev 558068
Push 131365 by ealvarez@mozilla.com at Thu, 19 Nov 2020 17:48:13 +0000
Bug 1676996 - Don't try to process-switch a remote frame to local. r=nika The guess in comment 3 is basically right, here's the relevant bits that happen in that trace in order: [content] nsFrameLoaderOwner::ChangeRemotenessCommon: frame becomes remote for the content process. [parent] WindowGlobalParent::SendMakeFrameLocal (mIsDocumentLoad=true) [content] ContentChild::SendCloneDocumentTreeInto [parent] ContentParent::RecvCloneDocumentTreeInto [content] WindowGlobalChild::RecvMakeFrameLocal So basically the source frame we're cloning is mid-switch-to-local: local already from the parent process POV, but still remote for the child. I think ignoring the clone in this case is fine (which will make the print iframe just about:blank). I've decided it to handle it in ChangeRemoteness but I could also handle it in RecvCloneDocumentTreeInto with a check like if (cp->GetRemoteType() == GetRemoteType()) or such I think. Let me know if you'd prefer that. Differential Revision: https://phabricator.services.mozilla.com/D97144
45221414fcf874cd34c5ffb5d9f27670084b3bf7: Bug 1676709 - Send a "browsing-context-attached" notification when attached, r=nika
Henrik Skupin <mail@hskupin.info> - Wed, 18 Nov 2020 22:19:10 +0000 - rev 557923
Push 131294 by hskupin@mozilla.com at Wed, 18 Nov 2020 23:18:57 +0000
Bug 1676709 - Send a "browsing-context-attached" notification when attached, r=nika Differential Revision: https://phabricator.services.mozilla.com/D97002
9fa1b2f465b24c34d05c7bbb4c980a126be2a50a: Bug 1677676 - P5: Allow clippy lints we're not interested in. r=nika
Dan Glastonbury <dan.glastonbury@gmail.com> - Tue, 17 Nov 2020 15:29:28 +0000 - rev 557686
Push 131194 by dglastonbury@mozilla.com at Tue, 17 Nov 2020 23:55:43 +0000
Bug 1677676 - P5: Allow clippy lints we're not interested in. r=nika Depends on D97264 Differential Revision: https://phabricator.services.mozilla.com/D97265
e3f64880a9701d3dd47bedc73af4f80fe24a566c: Bug 1677676 - P4: Remove extra field name in $StringRepr creation. r=nika
Dan Glastonbury <dan.glastonbury@gmail.com> - Tue, 17 Nov 2020 15:24:07 +0000 - rev 557685
Push 131194 by dglastonbury@mozilla.com at Tue, 17 Nov 2020 23:55:43 +0000
Bug 1677676 - P4: Remove extra field name in $StringRepr creation. r=nika Depends on D97263 Differential Revision: https://phabricator.services.mozilla.com/D97264
2167c83881b56f059b01e66482bd8e4b4ddaa9b6: Bug 1677676 - P3: Use pointer casts instead of mem::transmute. r=nika
Dan Glastonbury <dan.glastonbury@gmail.com> - Tue, 17 Nov 2020 15:22:56 +0000 - rev 557684
Push 131194 by dglastonbury@mozilla.com at Tue, 17 Nov 2020 23:55:43 +0000
Bug 1677676 - P3: Use pointer casts instead of mem::transmute. r=nika Clippy doesn't like mem::transmute. Depends on D97262 Differential Revision: https://phabricator.services.mozilla.com/D97263
b512c265658e5fb79d74e556b970fa834af43c19: Bug 1677676 - P2: Replace use of .offset(_ as isize) with .add(_). r=nika
Dan Glastonbury <dan.glastonbury@gmail.com> - Tue, 17 Nov 2020 15:21:17 +0000 - rev 557683
Push 131194 by dglastonbury@mozilla.com at Tue, 17 Nov 2020 23:55:43 +0000
Bug 1677676 - P2: Replace use of .offset(_ as isize) with .add(_). r=nika Depends on D97261 Differential Revision: https://phabricator.services.mozilla.com/D97262
4046f5868da84b99373609447d86ac45f308fba1: Bug 1677676 - P1: Correctly implement unsafe FFI functions. r=nika
Dan Glastonbury <dan.glastonbury@gmail.com> - Tue, 17 Nov 2020 15:20:41 +0000 - rev 557682
Push 131194 by dglastonbury@mozilla.com at Tue, 17 Nov 2020 23:55:43 +0000
Bug 1677676 - P1: Correctly implement unsafe FFI functions. r=nika Use: ```rust pub unsafe extern "C" fn foo() { ... } ``` instead of: ```rust pub extern "C" foo() { unsafe { ... } } ``` Differential Revision: https://phabricator.services.mozilla.com/D97261
87f72a8ec898093c54d7920a2dfa5b85540b7a1d: Bug 1634065 - remove the nested event loop in nsComponentManagerImpl::GetServiceLocked r=nika
Dana Keeler <dkeeler@mozilla.com> - Tue, 17 Nov 2020 16:30:06 +0000 - rev 557597
Push 131148 by dkeeler@mozilla.com at Tue, 17 Nov 2020 17:34:04 +0000
Bug 1634065 - remove the nested event loop in nsComponentManagerImpl::GetServiceLocked r=nika If the implementation of an XPCOM service constructor involves dispatching an event to another thread and blocking the current thread on that event, a deadlock can occur if the target thread is also attempting to obtain that service at the same time. For instance, say nsIExampleService needs to be constructed on the main thread, but some code in thread T is attempting to get a handle on it. Suppose the implementation checks which thread it's running on and dispatches a synchronous event to the main thread to do the actual construction work in the case that it is not on the main thread. Further suppose that before that event is run, other code on the main thread also attempts to get a handle on nsIExampleService. The XPCOM service machinery sees that another thread is in the process of constructing nsIExampleService, so it must wait for that to complete. However, the thread that is attempting to do this construction is waiting for an event to be run on the main thread. Thus, these two threads are deadlocked. Before this patch, the XPCOM service machinery worked around this problem by processing events on the second thread until it could proceed. However, this caused a nested event loop, which is bad for stability because all guarantees relating to when events will run are violated. In particular, this could cause reentrency into the TLS implementation, which is not expected and has caused intermittent crashes. This patch removes the nested event loop in nsComponentManagerImpl::GetServiceLocked in favor of not synchronously dispatching events in XPCOM service constructors. One way to fix such constructors is to move the event dispatch and blocking outside of the XPCOM service machinery. See the other patch in this bug for an example. Differential Revision: https://phabricator.services.mozilla.com/D92800
cec7a6eee54fc4bc427b9c967aefed0e95db17f7: Bug 1674382 - Further restrict where we record APZ_ZOOM_ACTIVITY. r=nika
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 16 Nov 2020 22:38:46 +0000 - rev 557487
Push 131097 by kgupta@mozilla.staktrace.com at Tue, 17 Nov 2020 02:17:20 +0000
Bug 1674382 - Further restrict where we record APZ_ZOOM_ACTIVITY. r=nika Differential Revision: https://phabricator.services.mozilla.com/D96894
414f92a9b18d57b4223c34fbd2361f1c88447239: Bug 1674382 - Fix typo in function name. r=nika
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 13 Nov 2020 18:29:31 +0000 - rev 557486
Push 131097 by kgupta@mozilla.staktrace.com at Tue, 17 Nov 2020 02:17:20 +0000
Bug 1674382 - Fix typo in function name. r=nika Differential Revision: https://phabricator.services.mozilla.com/D96893
c8c3b7df2f3004104b855d0b918153ead2d5263d: Bug 1676632 - Throw more descriptive actor errors. r=smaug,nika
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 16 Nov 2020 21:18:49 +0000 - rev 557455
Push 131074 by ealvarez@mozilla.com at Mon, 16 Nov 2020 23:38:13 +0000
Bug 1676632 - Throw more descriptive actor errors. r=smaug,nika Differential Revision: https://phabricator.services.mozilla.com/D96704