searching for reviewer(nbp)
8873669c60146a7031db604709680c04cbb483ae: Bug 1773584 - Remove MemoryProtectionExceptionHandler and PageProtectingVector. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 23 Jun 2022 07:28:42 +0000 - rev 621864
Push 165085 by jdemooij@mozilla.com at Thu, 23 Jun 2022 07:31:06 +0000
Bug 1773584 - Remove MemoryProtectionExceptionHandler and PageProtectingVector. r=nbp `PageProtectingVector` has been unused since bug 1342023. `MemoryProtectionExceptionHandler` was only used to annotate crashes affecting `LifoAlloc` memory. Differential Revision: https://phabricator.services.mozilla.com/D149993
55e1f543d0efd8644f73ee24c182defba62be739: Bug 1774501 - Update to env_logger 0.9 in various in-tree crates. r=nbp,keeler,xpcom-reviewers,rhunt,nika
Mike Hommey <mh+mozilla@glandium.org> - Thu, 16 Jun 2022 20:44:03 +0000 - rev 621217
Push 164725 by mh@glandium.org at Thu, 16 Jun 2022 20:57:06 +0000
Bug 1774501 - Update to env_logger 0.9 in various in-tree crates. r=nbp,keeler,xpcom-reviewers,rhunt,nika Differential Revision: https://phabricator.services.mozilla.com/D149453
b5817546051afe529d1f23501215f9e70712ac54: Bug 1773400 - Bump jsparagus for bug 1770509. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Thu, 09 Jun 2022 15:06:44 +0000 - rev 620322
Push 164279 by arai_a@mac.com at Thu, 09 Jun 2022 15:09:11 +0000
Bug 1773400 - Bump jsparagus for bug 1770509. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D148770
882008647ea484b1e174c3700f905594699bbf9e: Bug 1770904: Ensure ballast in scalar replacement r=nbp
Iain Ireland <iireland@mozilla.com> - Tue, 31 May 2022 13:39:02 +0000 - rev 619319
Push 163732 by iireland@mozilla.com at Tue, 31 May 2022 13:42:30 +0000
Bug 1770904: Ensure ballast in scalar replacement r=nbp Differential Revision: https://phabricator.services.mozilla.com/D147341
a99ac0bf0a59acefc66da158752063eb02e6753e: Bug 1771186 - Bump jsparagus. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Tue, 31 May 2022 11:05:01 +0000 - rev 619307
Push 163721 by arai_a@mac.com at Tue, 31 May 2022 11:07:24 +0000
Bug 1771186 - Bump jsparagus. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D147394
fd7b64f8a004380e45ec7d5d11532bf32bf98039: Bug 1770919 - Allow ARM64 simulator to run on ARM64. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Fri, 27 May 2022 06:40:33 +0000 - rev 619071
Push 163597 by lhansen@mozilla.com at Fri, 27 May 2022 06:47:38 +0000
Bug 1770919 - Allow ARM64 simulator to run on ARM64. r=nbp Remove the gating in moz.configure that prevents the arm64 simulator from being compiled on an arm64 system. Avoid using the fjcvt instruction when running on arm64 hardware, since the simulator does not appear to support it while cpu detection does support it. (The alternative would be to implement the instruction on the simulator.) Differential Revision: https://phabricator.services.mozilla.com/D147199
c1687f633995d560a98aaae71c48f39b2523f8de: Bug 1769518 - Support Rooted<Result<V,E>> as long as V and E have GCPolicy<> defined for them. (Use IgnoreGCPolicy for whichever of them does not need tracing.) r=emilio,nbp,jonco
Steve Fink <sfink@mozilla.com> - Thu, 26 May 2022 17:22:35 +0000 - rev 619016
Push 163564 by sfink@mozilla.com at Thu, 26 May 2022 18:08:38 +0000
Bug 1769518 - Support Rooted<Result<V,E>> as long as V and E have GCPolicy<> defined for them. (Use IgnoreGCPolicy for whichever of them does not need tracing.) r=emilio,nbp,jonco Differential Revision: https://phabricator.services.mozilla.com/D146468
38e3d6fdad95eec268ee01dcecf5f1156d383a21: Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:42 +0000 - rev 618421
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D145012
c7f736572e6985936d0a0ac821c4c7b26568c268: Bug 1757833 - Add Profiler markers to track compression cost r=nbp
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:41 +0000 - rev 618420
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Add Profiler markers to track compression cost r=nbp Differential Revision: https://phabricator.services.mozilla.com/D144738
b99e6832b403e7ee36b4e2976bd304df152f067d: Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:41 +0000 - rev 618419
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp Differential Revision: https://phabricator.services.mozilla.com/D145346
55f25a8c05b6baff652e506320baf33b0bfb952f: Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:41 +0000 - rev 618418
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp This simplifies profiling since now we can see the results within a single build based on the preference (though there is still a slight cost to copying the bytecode). Setting to (the default) 0 disables compression. Differential Revision: https://phabricator.services.mozilla.com/D144737
eac7a4d5d57ae8e749adcf3b480e92dc4f1a9cc4: Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:40 +0000 - rev 618417
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp This leaves the code in ScriptLoader and ScriptLoadHandler a lot more readable. ScriptBytecodeCompressedDataLayout and ScriptBytecodeDataLayout simplify locating data in the ScriptLoadRequest bytecode buffer when compressing and decompressing it. The interface is still error-prone. For example, these classes don't check that the returned pointers are within the bounds of the buffer. Differential Revision: https://phabricator.services.mozilla.com/D145011
0ee73f99c1cd6f4aa8e29603e66405d61b3a1d9f: Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp
Bryan Thrall <bthrall@mozilla.com> - Fri, 20 May 2022 18:25:40 +0000 - rev 618416
Push 163265 by bthrall@mozilla.com at Fri, 20 May 2022 18:28:29 +0000
Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp The SRI hash at the beginning of ScriptLoadRequest::mScriptBytecode is left uncompressed because ScriptLoader::OnIncrementalData() tries to decode it as soon as enough data is read (instead of waiting until OnStreamComplete()). ScriptLoader writes the length of the uncompressed bytecode to the buffer to make it easy for ScriptLoadHandler to allocate an buffer of the right size to decompress the bytecode. These changes are based on the bytecode compression implemented for WASM in dom/fetch/FetchUtil.cpp. Differential Revision: https://phabricator.services.mozilla.com/D141524
6a7d3034db0a4a7b2e74616da744264198297492: Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:49 +0000 - rev 618177
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D145012
faa0393886dbf16e6f8487f7d0389fb74d3bcbf3: Bug 1757833 - Add Profiler markers to track compression cost r=nbp
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:49 +0000 - rev 618176
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Add Profiler markers to track compression cost r=nbp Differential Revision: https://phabricator.services.mozilla.com/D144738
4bffe0cf490e484ad3361ae5f6462857e34ab754: Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:49 +0000 - rev 618175
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp Differential Revision: https://phabricator.services.mozilla.com/D145346
189b81cc13fdf830f5039cfd00d9fb57cb6d7844: Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:48 +0000 - rev 618174
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp This simplifies profiling since now we can see the results within a single build based on the preference (though there is still a slight cost to copying the bytecode). Setting to (the default) 0 disables compression. Differential Revision: https://phabricator.services.mozilla.com/D144737
a59c66e4fb684b47f303ceceebdf0e32c18bd15a: Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:48 +0000 - rev 618173
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp This leaves the code in ScriptLoader and ScriptLoadHandler a lot more readable. ScriptBytecodeCompressedDataLayout and ScriptBytecodeDataLayout simplify locating data in the ScriptLoadRequest bytecode buffer when compressing and decompressing it. The interface is still error-prone. For example, these classes don't check that the returned pointers are within the bounds of the buffer. Differential Revision: https://phabricator.services.mozilla.com/D145011
2b5d9869fbcb825037e50eb909111dfd99cf996c: Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp
Bryan Thrall <bthrall@mozilla.com> - Wed, 18 May 2022 21:03:47 +0000 - rev 618172
Push 163091 by bthrall@mozilla.com at Wed, 18 May 2022 21:06:36 +0000
Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp The SRI hash at the beginning of ScriptLoadRequest::mScriptBytecode is left uncompressed because ScriptLoader::OnIncrementalData() tries to decode it as soon as enough data is read (instead of waiting until OnStreamComplete()). ScriptLoader writes the length of the uncompressed bytecode to the buffer to make it easy for ScriptLoadHandler to allocate an buffer of the right size to decompress the bytecode. These changes are based on the bytecode compression implemented for WASM in dom/fetch/FetchUtil.cpp. Differential Revision: https://phabricator.services.mozilla.com/D141524
c8117edaf05472417eecda94a1b10ee4fa8dcbed: Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:05 +0000 - rev 618026
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Add PerfStat probes for bytecode cache reads, writes, compression, and decompression r=nbp,necko-reviewers,kershaw Differential Revision: https://phabricator.services.mozilla.com/D145012
a46efd9967d080af81b9a7d8c977d8d24c528222: Bug 1757833 - Add Profiler markers to track compression cost r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:04 +0000 - rev 618025
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Add Profiler markers to track compression cost r=nbp Differential Revision: https://phabricator.services.mozilla.com/D144738
f33955b6a7cc9df8521b2377887d0a8e90dd5f50: Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:04 +0000 - rev 618024
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Add mochitest for compressed bytecode caching r=nbp Differential Revision: https://phabricator.services.mozilla.com/D145346
71f1afa82581f8d4f92746708dba3445c3052ff2: Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:04 +0000 - rev 618023
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Add browser.cache.jsbc_compression_level static preference r=nbp This simplifies profiling since now we can see the results within a single build based on the preference (though there is still a slight cost to copying the bytecode). Setting to (the default) 0 disables compression. Differential Revision: https://phabricator.services.mozilla.com/D144737
868407dccba9bded863a792a6b0c8c29797c78c0: Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:03 +0000 - rev 618022
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Extract methods ScriptBytecodeCompress and ScriptBytecodeDecompress r=nbp This leaves the code in ScriptLoader and ScriptLoadHandler a lot more readable. ScriptBytecodeCompressedDataLayout and ScriptBytecodeDataLayout simplify locating data in the ScriptLoadRequest bytecode buffer when compressing and decompressing it. The interface is still error-prone. For example, these classes don't check that the returned pointers are within the bounds of the buffer. Differential Revision: https://phabricator.services.mozilla.com/D145011
79873d83d02b1b749a8ce9a8905475e510c5e567: Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp
Bryan Thrall <bthrall@mozilla.com> - Tue, 17 May 2022 16:29:03 +0000 - rev 618021
Push 162990 by bthrall@mozilla.com at Tue, 17 May 2022 16:31:53 +0000
Bug 1757833 - Compress Stencil bytecode before writing to cache r=nbp The SRI hash at the beginning of ScriptLoadRequest::mScriptBytecode is left uncompressed because ScriptLoader::OnIncrementalData() tries to decode it as soon as enough data is read (instead of waiting until OnStreamComplete()). ScriptLoader writes the length of the uncompressed bytecode to the buffer to make it easy for ScriptLoadHandler to allocate an buffer of the right size to decompress the bytecode. These changes are based on the bytecode compression implemented for WASM in dom/fetch/FetchUtil.cpp. Differential Revision: https://phabricator.services.mozilla.com/D141524
bf5d0e1ffcfd8113df1dc6f6224c256e7d91d7fc: Bug 1670885 - Use posix_spawn() on macOS to launch new processes in the JS shell r=nbp
Gabriele Svelto <gsvelto@mozilla.com> - Sat, 07 May 2022 07:34:36 +0000 - rev 616598
Push 162432 by gsvelto@mozilla.com at Sat, 07 May 2022 07:37:08 +0000
Bug 1670885 - Use posix_spawn() on macOS to launch new processes in the JS shell r=nbp fork() allocates memory on some versions of macOS (possibly all of them, but certainly on macOS 10.15). This can lead to all sort of problems when using our own memory allocator, as non-fork()-safe locks might be left in an incosistent state causing crashes or deadlocks in the child process. Use posix_spawn() instead to work around this problem. Differential Revision: https://phabricator.services.mozilla.com/D145765
f0e5faac065b2adc2d28e09dec181993d2aaee00: Bug 1763012: Mark fallible div/mod as guards r=jandem,nbp
Iain Ireland <iireland@mozilla.com> - Thu, 05 May 2022 21:23:27 +0000 - rev 616377
Push 162327 by iireland@mozilla.com at Thu, 05 May 2022 23:10:31 +0000
Bug 1763012: Mark fallible div/mod as guards r=jandem,nbp This is a fairly conservative fix, but I didn't see any slowdown on Octane or Speedometer. Differential Revision: https://phabricator.services.mozilla.com/D144321
8dcec19a555a83fbe12e3b37a22f870914654d8c: Bug 1763012: Mark fallible div/mod as guards r=jandem,nbp
Iain Ireland <iireland@mozilla.com> - Wed, 04 May 2022 17:19:28 +0000 - rev 616187
Push 162229 by iireland@mozilla.com at Wed, 04 May 2022 22:44:41 +0000
Bug 1763012: Mark fallible div/mod as guards r=jandem,nbp This is a fairly conservative fix, but I didn't see any slowdown on Octane or Speedometer. Differential Revision: https://phabricator.services.mozilla.com/D144321
7c2d512c1442977ffea9f56e99ad7117afad9843: Bug 1767562 - Bump jsparagus for bug 1766730. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 04 May 2022 13:27:48 +0000 - rev 616137
Push 162200 by arai_a@mac.com at Wed, 04 May 2022 13:30:13 +0000
Bug 1767562 - Bump jsparagus for bug 1766730. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D145434
5a96885b7658fe06ed22b28817c8bf7745deb804: Bug 1638464 - Do not access HelperThreadState() if it has not been initialized or has been torn down r=nbp
Steve Fink <sfink@mozilla.com> - Fri, 29 Apr 2022 22:20:45 +0000 - rev 615726
Push 161979 by sfink@mozilla.com at Fri, 29 Apr 2022 22:23:09 +0000
Bug 1638464 - Do not access HelperThreadState() if it has not been initialized or has been torn down r=nbp Differential Revision: https://phabricator.services.mozilla.com/D145004
ede0b744903b2a85a5e90d68be6d8b31c2dcdcbe: Bug 1713180 - [arm64] Use scratch register to break most move cycles. r=nbp
Ryan Hunt <rhunt@eqrion.net> - Fri, 15 Apr 2022 22:00:50 +0000 - rev 614459
Push 161187 by rhunt@eqrion.net at Fri, 15 Apr 2022 22:03:12 +0000
Bug 1713180 - [arm64] Use scratch register to break most move cycles. r=nbp This commit modifies ARM64's move emitter to use a scratch GPR as the storage for most cycles that need to be broken. The only exception is for SIMD128 cycles, which fall back to allocating space on the stack. Differential Revision: https://phabricator.services.mozilla.com/D143762
c6d4b07e4582532a80158d3da826f66591f428cd: Bug 1764366 part 5 - Use a template for reading double vs float. r=nbp
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Apr 2022 12:35:50 +0000 - rev 614339
Push 161101 by jdemooij@mozilla.com at Thu, 14 Apr 2022 12:38:19 +0000
Bug 1764366 part 5 - Use a template for reading double vs float. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143616
23ffbe7551339ee360f01b178947a245a495351b: Bug 1764366 part 3 - Shrink MachineState. r=nbp,iain
Jan de Mooij <jdemooij@mozilla.com> - Thu, 14 Apr 2022 12:35:49 +0000 - rev 614337
Push 161101 by jdemooij@mozilla.com at Thu, 14 Apr 2022 12:38:19 +0000
Bug 1764366 part 3 - Shrink MachineState. r=nbp,iain The MachineState class became pretty large, especially on ARM64 it was about 1 KB due to the large number of (float) registers. This patch fixes that by refactoring MachineState to store a pointer to the register dumps (for bailouts) or the register sets + spill location (for safepoints). This lets us recover the register address when we want to read/write it. Differential Revision: https://phabricator.services.mozilla.com/D143588
4028e43ade5de83515301ac44f9204d3efc32fe9: Bug 1752209 - Put cahe type into the cache key in StartupCache/ScriptPreloader. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 14:08:07 +0000 - rev 614216
Push 161046 by arai_a@mac.com at Wed, 13 Apr 2022 14:46:33 +0000
Bug 1752209 - Put cahe type into the cache key in StartupCache/ScriptPreloader. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143576
7b7ac774209cd5a8c7561bd109b6e98841b21809: Bug 1752212 - Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 14:08:07 +0000 - rev 614215
Push 161046 by arai_a@mac.com at Wed, 13 Apr 2022 14:46:33 +0000
Bug 1752212 - Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143575
6340c6d93f10892855824c7987cc1a5e2e280136: Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 14:08:06 +0000 - rev 614214
Push 161046 by arai_a@mac.com at Wed, 13 Apr 2022 14:46:33 +0000
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143574
8f10b666008a6ece0b513787ca332c766d11ce34: Bug 1752209 - Put cahe type into the cache key in StartupCache/ScriptPreloader. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 11:41:11 +0000 - rev 614186
Push 161034 by arai_a@mac.com at Wed, 13 Apr 2022 11:43:37 +0000
Bug 1752209 - Put cahe type into the cache key in StartupCache/ScriptPreloader. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143576
557c428fb6bcbc17a4ef6923567abc399ec35e4b: Bug 1752212 - Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 11:41:11 +0000 - rev 614185
Push 161034 by arai_a@mac.com at Wed, 13 Apr 2022 11:43:37 +0000
Bug 1752212 - Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143575
e38fbd381ed38b552856dcf5a972ef648405a491: Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 13 Apr 2022 11:41:10 +0000 - rev 614184
Push 161034 by arai_a@mac.com at Wed, 13 Apr 2022 11:43:37 +0000
Bug 1752212 - Part 1: Pass loader type to PathifyURI. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143574
dd63c067b873c02ed1bf7ca3141a7eefcf556408: Bug 1764228 - Use cachePath instead of uri as parameter name in {Read,Write}CachedStencil parameter. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Tue, 12 Apr 2022 09:17:17 +0000 - rev 614043
Push 160935 by arai_a@mac.com at Tue, 12 Apr 2022 09:19:35 +0000
Bug 1764228 - Use cachePath instead of uri as parameter name in {Read,Write}CachedStencil parameter. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143442
16c1e24e61eb1f8bbe73aa25abfcc53364ff6239: Bug 1763276 - Bump jsparagus for bug 1282976. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Tue, 12 Apr 2022 09:16:08 +0000 - rev 614042
Push 160934 by arai_a@mac.com at Tue, 12 Apr 2022 09:18:27 +0000
Bug 1763276 - Bump jsparagus for bug 1282976. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D143440
c9a3661cb9f2bc12d871b37fd5bcb33aea701dbd: Bug 1752606 - wasm: Don't emit load-compare-branch after catchable calls in ion. r=lth,nbp
Ryan Hunt <rhunt@eqrion.net> - Tue, 12 Apr 2022 01:24:40 +0000 - rev 614023
Push 160923 by rhunt@eqrion.net at Tue, 12 Apr 2022 01:27:05 +0000
Bug 1752606 - wasm: Don't emit load-compare-branch after catchable calls in ion. r=lth,nbp This commit drops the load-compare-branch after catchable calls in ion, and replaces them with a scheme where MWasmCall may be a control instruction and therefore the unwinding path can jump directly to the pre pad successor block. This is done with several steps. 1. MVariadicControlInstruction is added 2. MWasmCall is split into: - MWasmCallBase, a mixin class that does not inherit M*Instruction. Almost all state and logic for MWasmCall is kept here. - MWasmCallCatchable, inheriting MVariadicControlInstruction and MWasmCallBase. A control instruction with two successors: fallthrough and the pre pad. - MWasmCallUncatchable, inheriting from MVariadicInstruction and MWasmCallBase. 3. Lowering for the two instruction is done identically, and there is still a single LWasmCall. Not a LWasmCallCatchable/Uncatchable. This was chosen to share code, and because at this point I cannot see any purpose in having two separate instructions. 4. Codegen of LWasmCatch continues to have some special logic for catchable calls before and after the call. 5. WasmIonCompile invokes a catchableCall() when performing a direct, indirect, or import call. This determines whether the call is catchable, constructs the correct instruction type, and sets up the fallthrough and pre-pad blocks. 6. A MWasmCallLandingPad marker instruction is added. This instruction emits no code, but sets up the try note entry point. It also performs release asserts for correctness. 7. The responsibility for creating a try note is moved from CodeGenerator ::visitWasmCall to FunctionCompiler, as the try note is needed in MWasmCallCatchable and MWasmCallLandingPad. 8. The documentation block is updated as best I can. I've removed the large diagram as I'm having a hard time keeping it up to date and don't find it very useful. Differential Revision: https://phabricator.services.mozilla.com/D139657
eb0def741d00bd2d8be352c1368f5f73397e6ed7: Bug 1763054 - adjust the encoding of arm64 fp constants. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Wed, 06 Apr 2022 11:49:19 +0000 - rev 613510
Push 160679 by lhansen@mozilla.com at Wed, 06 Apr 2022 11:55:02 +0000
Bug 1763054 - adjust the encoding of arm64 fp constants. r=nbp Following Clang11, encode a 0.0 as MOVI and a -0.0 as MOVI+FNEG. This avoids gpr->fpr moves and loads from memory everywhere and probably insulates us a little from microarchitectural differences. Differential Revision: https://phabricator.services.mozilla.com/D143018
b40009360d2bfefcfeed8b7138a784aa97c67028: Bug 1763099 - Part 7: Remove duplicated check for numeric comparisons. r=jandem,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 05 Apr 2022 14:08:57 +0000 - rev 613416
Push 160616 by andre.bargull@gmail.com at Tue, 05 Apr 2022 14:11:41 +0000
Bug 1763099 - Part 7: Remove duplicated check for numeric comparisons. r=jandem,nbp `compare->isNumericComparison()` is already checked at the start of the loop, so we don't have to check for it another time when handling strict equality operators. Depends on D142927 Differential Revision: https://phabricator.services.mozilla.com/D142928
a081fd1e77d232c93e1499c055b32f5a8a927a46: Bug 1763099 - Part 6: Remove MBasicBlock::discardDef(). r=jandem,nbp
André Bargull <andre.bargull@gmail.com> - Tue, 05 Apr 2022 14:08:57 +0000 - rev 613415
Push 160616 by andre.bargull@gmail.com at Tue, 05 Apr 2022 14:11:41 +0000
Bug 1763099 - Part 6: Remove MBasicBlock::discardDef(). r=jandem,nbp Both callers to `MBasicBlock::discardDef()` can be changed to call `MBasicBlock::discard()`. Depends on D142926 Differential Revision: https://phabricator.services.mozilla.com/D142927
bb3b4cc867dd5e9fbc5a21a5b913711a71dcb0f9: Bug 1763054 - Make ARM64 loadConstantDouble/Float32 the source of truth. r=nbp
Lars T Hansen <lhansen@mozilla.com> - Tue, 05 Apr 2022 09:55:01 +0000 - rev 613392
Push 160604 by lhansen@mozilla.com at Tue, 05 Apr 2022 09:57:23 +0000
Bug 1763054 - Make ARM64 loadConstantDouble/Float32 the source of truth. r=nbp Remove local decisions about how to load FP constants and centralize that knowledge in loadConstantDouble / loadConstantFloat32. Code that needs to load eg -0.0 can just pass that value to those functions and expect optimal code. Note in those functions that the optimal way of loading negative zero is to load it PC-relative from memory, not to construct it with a multi-instruction sequence. Differential Revision: https://phabricator.services.mozilla.com/D142917
71a7fb0e772ab5cc3f1eb29b01bb092e77a278f7: Bug 1761218 - Bump jsparagus for bug 1760989 and bug 1761755. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 30 Mar 2022 17:11:00 +0000 - rev 612819
Push 160310 by arai_a@mac.com at Wed, 30 Mar 2022 17:13:21 +0000
Bug 1761218 - Bump jsparagus for bug 1760989 and bug 1761755. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D142468
be7ae56cea9d9e3412ac549aef1ebf9c71d7e4fd: Bug 1760930 - Bump jsparagus for bug 1760605. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 23 Mar 2022 13:43:18 +0000 - rev 611645
Push 159866 by arai_a@mac.com at Wed, 23 Mar 2022 13:45:41 +0000
Bug 1760930 - Bump jsparagus for bug 1760605. r=nbp Differential Revision: https://phabricator.services.mozilla.com/D141840
d2d7b3b5fe70b8ea68344b495bcda0ee2075e5f2: Bug 1759206 - Part 2: Use ModuleObject instead of script for encoding module bytecode cache. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 23 Mar 2022 12:51:39 +0000 - rev 611641
Push 159864 by arai_a@mac.com at Wed, 23 Mar 2022 12:54:28 +0000
Bug 1759206 - Part 2: Use ModuleObject instead of script for encoding module bytecode cache. r=nbp Depends on D141743 Differential Revision: https://phabricator.services.mozilla.com/D141744
0e76b6d814cc323f122a5a0de273239264c8f076: Bug 1759206 - Part 1: Add module variant of JS::FinishIncrementalEncoding. r=nbp
Tooru Fujisawa <arai_a@mac.com> - Wed, 23 Mar 2022 12:51:38 +0000 - rev 611640
Push 159864 by arai_a@mac.com at Wed, 23 Mar 2022 12:54:28 +0000
Bug 1759206 - Part 1: Add module variant of JS::FinishIncrementalEncoding. r=nbp Depends on D141742 Differential Revision: https://phabricator.services.mozilla.com/D141743