searching for reviewer(mconley)
681812df950d10a92470dc22582dd3d425533cba: Bug 1767855 - Make tab warming use the process priority hint. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 17:45:03 +0000 - rev 618411
Push 163260 by ealvarez@mozilla.com at Fri, 20 May 2022 17:47:29 +0000
Bug 1767855 - Make tab warming use the process priority hint. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D145501
72f023837df4e5128f13d9cb8e52165255903d42: Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley,geckoview-reviewers,agi
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 09:14:42 +0000 - rev 618373
Push 163231 by ealvarez@mozilla.com at Fri, 20 May 2022 10:13:55 +0000
Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley,geckoview-reviewers,agi For desktop this should basically have no impact (maybe impacts tab warming, but if we wanted we could set the priority hint from the tab switcher the same way we set renderLayers), but Fenix always has renderLayers as true, effectively, so we were never de-prioritizing the background tab processes. Differential Revision: https://phabricator.services.mozilla.com/D145351
7b3a02a659ef62675630788be9e16898f65b7ec0: Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley,geckoview-reviewers,agi
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 20 May 2022 00:48:32 +0000 - rev 618321
Push 163195 by ealvarez@mozilla.com at Fri, 20 May 2022 01:08:10 +0000
Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley,geckoview-reviewers,agi For desktop this should basically have no impact (maybe impacts tab warming, but if we wanted we could set the priority hint from the tab switcher the same way we set renderLayers), but Fenix always has renderLayers as true, effectively, so we were never de-prioritizing the background tab processes. Differential Revision: https://phabricator.services.mozilla.com/D145351
be91ae588a2526842affc322b0672e501e20d841: Bug 1703866 - Use a lazy pref getter in SelectParent.jsm. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 05 May 2022 20:55:24 +0000 - rev 616361
Push 162320 by ealvarez@mozilla.com at Thu, 05 May 2022 20:57:45 +0000
Bug 1703866 - Use a lazy pref getter in SelectParent.jsm. r=mconley Otherwise the pref set in browser/base/content/test/forms/browser_selectpopup_colors.js doesn't always work. Differential Revision: https://phabricator.services.mozilla.com/D145635
7b715c304c65caa8fe677f27f1eadf9742485ced: Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 04 May 2022 19:03:15 +0000 - rev 616199
Push 162238 by ealvarez@mozilla.com at Wed, 04 May 2022 22:49:53 +0000
Bug 1767346 - Use browsing context activeness rather than renderLayers to determine process priority. r=mccr8,mconley For desktop this should basically have no impact (maybe impacts tab warming, but if we wanted we could set the priority hint from the tab switcher the same way we set renderLayers), but Fenix always has renderLayers as true, effectively, so we were never de-prioritizing the background tab processes. Differential Revision: https://phabricator.services.mozilla.com/D145351
5c06e2e2096d9293829c6770aa75b93847455262: Bug 1765634 - Simple Storybook for local development r=mconley,hjones
Mark Striemer <mstriemer@mozilla.com> - Wed, 27 Apr 2022 20:10:16 +0000 - rev 615526
Push 161826 by mstriemer@mozilla.com at Wed, 27 Apr 2022 20:12:43 +0000
Bug 1765634 - Simple Storybook for local development r=mconley,hjones This provides a basic Storybook set up for us to develop with Storybook locally. Quick start (MacOS, Linux, WSL): ./mach npm --prefix=browser/components/storybook ci ./mach npm --prefix=browser/components/storybook run storybook Differential Revision: https://phabricator.services.mozilla.com/D144223
1b4ac129a74b876b057fe8bc92a1981726a086ef: Bug 1762042 - Deal with nodesFromRect returning elements inside the video controls but not the video itself in PictureInPictureChild. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Apr 2022 14:39:00 +0000 - rev 615476
Push 161784 by ealvarez@mozilla.com at Wed, 27 Apr 2022 14:41:24 +0000
Bug 1762042 - Deal with nodesFromRect returning elements inside the video controls but not the video itself in PictureInPictureChild. r=mconley Before, these nodes were being retargeted and the video element was being returned instead. Now we return the clickable control directly. Since we pass aOnlyVisible, when the toggle is fully opaque we don't return the video element itself otherwise, and this code was bailing out. Differential Revision: https://phabricator.services.mozilla.com/D144794
e709dbc438325af08a083b46f4993ff455d1a6f7: Bug 1762042 - Avoid retargeting in NodesFromRect. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 27 Apr 2022 14:39:00 +0000 - rev 615475
Push 161784 by ealvarez@mozilla.com at Wed, 27 Apr 2022 14:41:24 +0000
Bug 1762042 - Avoid retargeting in NodesFromRect. r=mconley This is a ChromeOnly method so it makes sense to avoid retargeting to the root scope and just return the raw elements. Differential Revision: https://phabricator.services.mozilla.com/D144588
0cec4dbebc878afa2979d00017b343c4cedf300d: Bug 1762042 - Avoid retargeting in NodesFromRect. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 26 Apr 2022 14:30:29 +0000 - rev 615349
Push 161710 by ealvarez@mozilla.com at Tue, 26 Apr 2022 14:32:50 +0000
Bug 1762042 - Avoid retargeting in NodesFromRect. r=mconley This is a ChromeOnly method so it makes sense to avoid retargeting to the root scope and just return the raw elements. Differential Revision: https://phabricator.services.mozilla.com/D144588
549ab6fd1f57392342a7c184af6820da982c7b21: Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Niklas Baumgardner <nbaumgardner@mozilla.com> - Mon, 25 Apr 2022 14:21:18 +0000 - rev 615233
Push 161629 by nbaumgardner@mozilla.com at Mon, 25 Apr 2022 14:23:44 +0000
Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod Depends on D139742 Differential Revision: https://phabricator.services.mozilla.com/D143622
e881fd99de24fa48159390544dac07f373931d1c: Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
Mike Conley <mconley@mozilla.com> - Mon, 25 Apr 2022 14:21:18 +0000 - rev 615232
Push 161629 by nbaumgardner@mozilla.com at Mon, 25 Apr 2022 14:23:44 +0000
Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod Original patch by Guanlin Cheng <chenggu3@msu.edu>. Differential Revision: https://phabricator.services.mozilla.com/D139742
ec0089ae2dc0b0ff7bc0c144af1d2bbc12546862: Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley
Hunter Jones <whjones526@gmail.com> - Thu, 21 Apr 2022 21:58:39 +0000 - rev 615049
Push 161513 by mconley@mozilla.com at Thu, 21 Apr 2022 22:01:03 +0000
Bug 1678390: Prevent Picture-in-Picture windows from opening on top of one another r=mconley Differential Revision: https://phabricator.services.mozilla.com/D97847
2b6a67ada4d39a06d4a1c9a546770c900a86295d: Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Niklas Baumgardner <nbaumgardner@mozilla.com> - Thu, 21 Apr 2022 17:58:17 +0000 - rev 615018
Push 161491 by nbaumgardner@mozilla.com at Thu, 21 Apr 2022 18:37:57 +0000
Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod Depends on D139742 Differential Revision: https://phabricator.services.mozilla.com/D143622
2f9ad49eb1317ae7446372cc0267d0bd73ae52d4: Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
Mike Conley <mconley@mozilla.com> - Thu, 21 Apr 2022 17:58:17 +0000 - rev 615017
Push 161491 by nbaumgardner@mozilla.com at Thu, 21 Apr 2022 18:37:57 +0000
Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod Original patch by Guanlin Cheng <chenggu3@msu.edu>. Differential Revision: https://phabricator.services.mozilla.com/D139742
164e5a97cc417b8f3871b3f7579c744ba8de0f69: Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod
Niklas Baumgardner <nbaumgardner@mozilla.com> - Wed, 20 Apr 2022 21:22:45 +0000 - rev 614851
Push 161417 by nbaumgardner@mozilla.com at Wed, 20 Apr 2022 21:28:14 +0000
Bug 1654054 - Fluent migration for videocontrols. r=fluent-reviewers,mconley,flod Depends on D139742 Differential Revision: https://phabricator.services.mozilla.com/D143622
dde97d8007132c1d62463be3fb4209c19576c28e: Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod
Mike Conley <mconley@mozilla.com> - Wed, 20 Apr 2022 21:22:45 +0000 - rev 614850
Push 161417 by nbaumgardner@mozilla.com at Wed, 20 Apr 2022 21:28:14 +0000
Bug 1654054 - Port videocontrols to Fluent. r=mconley,fluent-reviewers,pip-reviewers,flod Original patch by Guanlin Cheng <chenggu3@msu.edu>. Differential Revision: https://phabricator.services.mozilla.com/D139742
8a3bcb8c17a5aca67f167029d3965f47a06bdfdd: Bug 1538464 - Ensure Pocket context menu items work as expected in sidebar extension or other windows. r=mconley
Scott <scott.downe@gmail.com> - Wed, 20 Apr 2022 13:22:38 +0000 - rev 614747
Push 161369 by sdowne@getpocket.com at Wed, 20 Apr 2022 13:25:03 +0000
Bug 1538464 - Ensure Pocket context menu items work as expected in sidebar extension or other windows. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D143539
7f523f9cd22dd9dffb5db8a7de2631fd5c759e02: Bug 1739450 - Part 2: Collect session history when wireframes are collected. r=peterv,mconley
Andreas Farre <farre@mozilla.com> - Tue, 19 Apr 2022 15:19:22 +0000 - rev 614620
Push 161289 by afarre@mozilla.com at Tue, 19 Apr 2022 15:22:27 +0000
Bug 1739450 - Part 2: Collect session history when wireframes are collected. r=peterv,mconley Because wireframes are collected together with the session history entry for its docshell, we need to collect session history to make sure that collected wireframes show up. Differential Revision: https://phabricator.services.mozilla.com/D143368
bfa3af44ba5f52c5af7c37508bd17a6670476909: Bug 1755274 - disable browser_telemetry_togglePiP.js on Linux_64_Nofis_debug for frequent failures. r=intermittent-reviewers,pip-reviewers,jmaher,mconley
Butkovits Atila <abutkovits@mozilla.com> - Thu, 07 Apr 2022 23:58:57 +0000 - rev 613696
Push 160808 by abutkovits@mozilla.com at Fri, 08 Apr 2022 00:01:19 +0000
Bug 1755274 - disable browser_telemetry_togglePiP.js on Linux_64_Nofis_debug for frequent failures. r=intermittent-reviewers,pip-reviewers,jmaher,mconley Differential Revision: https://phabricator.services.mozilla.com/D142950
f2148f12bdbf14292ed17c75067a44b31f4b7b9f: Bug 1762909 - Remove dead Adobe Flash hang code in BrowserGlue r=mconley
irwp <irwp@protonmail.com> - Wed, 06 Apr 2022 20:13:08 +0000 - rev 613564
Push 160722 by mconley@mozilla.com at Wed, 06 Apr 2022 20:15:31 +0000
Bug 1762909 - Remove dead Adobe Flash hang code in BrowserGlue r=mconley Differential Revision: https://phabricator.services.mozilla.com/D143073
b19863195e7a711aed00cb8ca4e197a4d5610511: Bug 1762380 - removed pip play/pause button border when the pip window is focused r=mconley
Janvi Bajoria <janvibajo1@gmail.com> - Tue, 05 Apr 2022 16:24:08 +0000 - rev 613437
Push 160635 by mconley@mozilla.com at Tue, 05 Apr 2022 16:26:27 +0000
Bug 1762380 - removed pip play/pause button border when the pip window is focused r=mconley Differential Revision: https://phabricator.services.mozilla.com/D142825
3bd08b99153b8a9263847531ea0c54f18773aebd: Bug 1760899 - Connect new save to Pocket tag picker to the new save panel. r=gvn,mconley
Scott <scott.downe@gmail.com> - Thu, 31 Mar 2022 20:20:38 +0000 - rev 612952
Push 160402 by sdowne@getpocket.com at Thu, 31 Mar 2022 20:23:02 +0000
Bug 1760899 - Connect new save to Pocket tag picker to the new save panel. r=gvn,mconley Differential Revision: https://phabricator.services.mozilla.com/D142420
cafe8f49eb3f3ee1db59c0a0d3fd73f258402a98: Bug 1665251, handle activating the pip toggle with the keyboard, r=mconley
Neil Deakin <neil@mozilla.com> - Thu, 31 Mar 2022 18:45:03 +0000 - rev 612936
Push 160392 by neil@mozilla.com at Thu, 31 Mar 2022 18:47:29 +0000
Bug 1665251, handle activating the pip toggle with the keyboard, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D142222
f6ad79017f6b7f73be112173b89eb498250dcf7c: Bug 1761926 - Make sure not to fall back to native theme colors for checkbox borders in custom themes. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 30 Mar 2022 18:56:15 +0000 - rev 612837
Push 160324 by ealvarez@mozilla.com at Wed, 30 Mar 2022 18:58:37 +0000
Bug 1761926 - Make sure not to fall back to native theme colors for checkbox borders in custom themes. r=mconley The issue is that when a custom theme is used, `--input-border-color` may or may not be set (depending on the theme), and when it's not set we'd fall back to the native colors for checkbox borders, but not for checkbox backgrounds (which use --button-bgcolor, which is always set), causing poor contrast depending on the theme. Differential Revision: https://phabricator.services.mozilla.com/D142321
67bff9e4ad1175dc8f6238a7105f81114b1bdeb3: Bug 1761238 - Use ThreeDShadow rather than ThreeDDarkShadow on checkboxes by default. r=dao,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 29 Mar 2022 08:59:29 +0000 - rev 612681
Push 160203 by ealvarez@mozilla.com at Tue, 29 Mar 2022 09:07:41 +0000
Bug 1761238 - Use ThreeDShadow rather than ThreeDDarkShadow on checkboxes by default. r=dao,mconley That works nicely for both light and dark mode. Differential Revision: https://phabricator.services.mozilla.com/D142172
7d4ee994441f5a16fd8e721bec799c06589a8ce5: Bug 1751010: Expose command line arguments early enough to detect private browsing mode before window painting r=nika,nalexander,mconley
Ben Hearsum <bhearsum@mozilla.com> - Thu, 24 Mar 2022 13:07:39 +0000 - rev 611797
Push 159971 by bhearsum@mozilla.com at Thu, 24 Mar 2022 13:10:00 +0000
Bug 1751010: Expose command line arguments early enough to detect private browsing mode before window painting r=nika,nalexander,mconley Differential Revision: https://phabricator.services.mozilla.com/D139988
f3b5736196b2d9abab8a8d276637d045ccf33256: Bug 1757927 - close pip window when video src is undefined. r=mconley
Katherine Patenio <kpatenio@mozilla.com> - Wed, 23 Mar 2022 19:47:47 +0000 - rev 611713
Push 159911 by kpatenio@mozilla.com at Wed, 23 Mar 2022 19:50:09 +0000
Bug 1757927 - close pip window when video src is undefined. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D141145
a71532f849065544ca115bdf5c52bdd9c49bad0f: no bug - doc: Add 'front end' to the Firefox doc r=mconley DONTBUILD
Sylvestre Ledru <sledru@mozilla.com> - Mon, 21 Mar 2022 16:01:13 +0000 - rev 611354
Push 159690 by sledru@mozilla.com at Mon, 21 Mar 2022 19:29:41 +0000
no bug - doc: Add 'front end' to the Firefox doc r=mconley DONTBUILD To avoid some confusion between the product and the front end component/team Differential Revision: https://phabricator.services.mozilla.com/D141560
84fa6be07a61b1a2d10d81ede54779ca5a042ab6: Bug 1759919 - Don't stop looking for intersecting frames too early in case there are fully-opaque transformed elements. r=miko,mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 17 Mar 2022 15:37:31 +0000 - rev 610892
Push 159558 by ealvarez@mozilla.com at Thu, 17 Mar 2022 15:39:55 +0000
Bug 1759919 - Don't stop looking for intersecting frames too early in case there are fully-opaque transformed elements. r=miko,mconley nsDisplayTransform::HitTest clips the rect it passes to its children, and thus intersecting the whole area isn't relevant. Depends on D141300 Differential Revision: https://phabricator.services.mozilla.com/D141301
52120ef3072fb35403ed82bdbf1a629cbeebdb2c: Bug 1759919 - Improve getWireframe() handling of canvas background. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 17 Mar 2022 15:37:31 +0000 - rev 610891
Push 159558 by ealvarez@mozilla.com at Thu, 17 Mar 2022 15:39:55 +0000
Bug 1759919 - Improve getWireframe() handling of canvas background. r=mconley Don't include it twice, and compute it explicitly since PresShell's GetCanvasBackground gets computed during painting otherwise. Differential Revision: https://phabricator.services.mozilla.com/D141300
7e98526a1f3f94408deb50cf225cbd41f8d24760: Bug 1759498 - Clean up panel footer button styling after Proton. r=mconley
Dão Gottwald <dao@mozilla.com> - Wed, 16 Mar 2022 12:28:22 +0000 - rev 610771
Push 159471 by dgottwald@mozilla.com at Wed, 16 Mar 2022 12:41:35 +0000
Bug 1759498 - Clean up panel footer button styling after Proton. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D140971
831481b0bc7890b04f5c2ccc8324e6d684791868: Bug 1759498 - Clean up panel footer button styling after Proton. r=mconley
Dão Gottwald <dao@mozilla.com> - Tue, 15 Mar 2022 21:07:57 +0000 - rev 610727
Push 159443 by dgottwald@mozilla.com at Tue, 15 Mar 2022 21:13:32 +0000
Bug 1759498 - Clean up panel footer button styling after Proton. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D140971
0fa2c4b2fc9a0f2b35e57b04090e03c6869d55e1: Bug 1756703 - Add extra keys to pictureinpicture.create telemetry event. r=pip-reviewers,mconley,kpatenio
Niklas Baumgardner <nbaumgardner@mozilla.com> - Sun, 13 Mar 2022 00:45:01 +0000 - rev 610483
Push 159286 by nbaumgardner@mozilla.com at Sun, 13 Mar 2022 00:48:00 +0000
Bug 1756703 - Add extra keys to pictureinpicture.create telemetry event. r=pip-reviewers,mconley,kpatenio Differential Revision: https://phabricator.services.mozilla.com/D140252
678fcec5884bf5acf137e82910bc9381e7450f25: Bug 1756703 - Revive FX_PICTURE_IN_PICTURE_WINDOW_OPEN_DURATION histogram. r=pip-reviewers,mconley
Niklas Baumgardner <nbaumgardner@mozilla.com> - Sun, 13 Mar 2022 00:45:00 +0000 - rev 610482
Push 159286 by nbaumgardner@mozilla.com at Sun, 13 Mar 2022 00:48:00 +0000
Bug 1756703 - Revive FX_PICTURE_IN_PICTURE_WINDOW_OPEN_DURATION histogram. r=pip-reviewers,mconley Differential Revision: https://phabricator.services.mozilla.com/D140251
8ed10a16a22a1bf4f8694091c5ccccb7568f7c69: Bug 1756703 - Create closed_method telemetry event for PiP. r=mconley
Niklas Baumgardner <nbaumgardner@mozilla.com> - Sun, 13 Mar 2022 00:45:00 +0000 - rev 610481
Push 159286 by nbaumgardner@mozilla.com at Sun, 13 Mar 2022 00:48:00 +0000
Bug 1756703 - Create closed_method telemetry event for PiP. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D140250
2365c2fe841bd8c2a22f1aed9e41a09270ec61c7: Bug 1755887, the picture-in-picture shortcut should open the focused video, if any, otherwise, should find a video in the nested subframe that has focus, r=mconley
Neil Deakin <neil@mozilla.com> - Fri, 11 Mar 2022 00:29:05 +0000 - rev 610294
Push 159183 by neil@mozilla.com at Fri, 11 Mar 2022 00:31:41 +0000
Bug 1755887, the picture-in-picture shortcut should open the focused video, if any, otherwise, should find a video in the nested subframe that has focus, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D140663
93212b85e5b7ee196bedfd3843dcdd7900e0fd92: Bug 1755748 - Keep PiP tabs in active state. r=mconley,dthayer
Niklas Baumgardner <nbaumgardner@mozilla.com> - Thu, 10 Mar 2022 23:33:26 +0000 - rev 610292
Push 159181 by nbaumgardner@mozilla.com at Fri, 11 Mar 2022 00:14:17 +0000
Bug 1755748 - Keep PiP tabs in active state. r=mconley,dthayer Differential Revision: https://phabricator.services.mozilla.com/D140394
fdd0881524c3c97e8286cdb7b9aa6561a01bf8f6: Bug 1755670 - remove ifdefs from videocontrols.css r=Gijs,desktop-theme-reviewers,pip-reviewers,dao,mconley
Sarah Clements <sclements@mozilla.com> - Tue, 01 Mar 2022 14:19:10 +0000 - rev 609279
Push 158690 by sclements@mozilla.com at Tue, 01 Mar 2022 14:26:32 +0000
Bug 1755670 - remove ifdefs from videocontrols.css r=Gijs,desktop-theme-reviewers,pip-reviewers,dao,mconley Differential Revision: https://phabricator.services.mozilla.com/D139822
b42b18204f2042636f96f8d724ccb0af921aeeff: Bug 1753861 - end drag sessions before opening any subdialogs, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 01 Mar 2022 12:39:16 +0000 - rev 609265
Push 158682 by gijskruitbosch@gmail.com at Tue, 01 Mar 2022 12:41:35 +0000
Bug 1753861 - end drag sessions before opening any subdialogs, r=mconley When opening new 'real' windows, the window mediator/watcher code takes care of this. For windows inside frames, such as the SubDialog code uses, it does not. The reason this is needed is related to a few different things: - drag processing is different on different OSes. For example, on Windows, once we're getting a 'drop' event we'll get a 'dragend' (which sorts out the tabstrip dragging) immediately afterwards. On macOS, this goes via the event loop. So some of the timing of this is unpredictable. - dialogs can call 'sizeToContent', which in turn checks if the window can even be resized by the calling principal, which suspends drag operations (see bug 329385), which ends the drag *without* notifying dragend, which in turn makes things sad. - dialog opening code such as the prompter code spins event loops. This messes with event handling some more. As SubDialog is the common bit between all 3 types of prompts (browser window, tab, content modal) that don't open separate 'real' external windows, this seems the logical place to put this. Unfortunately no tests because simulating native drag events is... not straightforward. Differential Revision: https://phabricator.services.mozilla.com/D139557
cd1ca5184c73edfc4af351ad4c89ea994311625b: Bug 1754639 - Renew startup cache telemetry r=mconley
Doug Thayer <dothayer@mozilla.com> - Mon, 28 Feb 2022 21:55:28 +0000 - rev 609211
Push 158650 by dothayer@mozilla.com at Mon, 28 Feb 2022 21:57:49 +0000
Bug 1754639 - Renew startup cache telemetry r=mconley (Will be submitting a telemetry renewal request as well.) Differential Revision: https://phabricator.services.mozilla.com/D139860
2b61ceef478aa9c2eeba546410a7fff4e90dd425: Bug 1757169 - Rewrite autoscroll icon bounds clamping to work on desktop pixels. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 28 Feb 2022 18:41:47 +0000 - rev 609188
Push 158635 by ealvarez@mozilla.com at Mon, 28 Feb 2022 18:44:11 +0000
Bug 1757169 - Rewrite autoscroll icon bounds clamping to work on desktop pixels. r=mconley The old calculation based on device pixels _might_ be correct, but it sure was sketchy. This is more straight-forward / easier to follow. Depends on D139777 Differential Revision: https://phabricator.services.mozilla.com/D139778
8c1888a6aef9f836761169ebb78c79856e65519d: Bug 1757169 - Fix another caller of screenForRect to use desktop pixels. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 28 Feb 2022 18:41:46 +0000 - rev 609187
Push 158635 by ealvarez@mozilla.com at Mon, 28 Feb 2022 18:44:11 +0000
Bug 1757169 - Fix another caller of screenForRect to use desktop pixels. r=mconley I missed this one in https://phabricator.services.mozilla.com/D138039 :( Differential Revision: https://phabricator.services.mozilla.com/D139777
85735b23c448ad77eb7f04da788a9ba95e6ab10f: Bug 1746016 - Save to Pocket refresh home panel. r=gvn,fluent-reviewers,mconley,andreio,flod,ckerschb
Scott <scott.downe@gmail.com> - Wed, 23 Feb 2022 21:12:49 +0000 - rev 608562
Push 158389 by sdowne@getpocket.com at Wed, 23 Feb 2022 22:10:04 +0000
Bug 1746016 - Save to Pocket refresh home panel. r=gvn,fluent-reviewers,mconley,andreio,flod,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D137708
fa4077e7e8d6276c0645c87fc4967faffcb64406: Bug 1743384 - add test, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 23 Feb 2022 12:57:08 +0000 - rev 608494
Push 158346 by gijskruitbosch@gmail.com at Wed, 23 Feb 2022 12:59:29 +0000
Bug 1743384 - add test, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D132350
7cea02651ac288d4b9abeef60ce9a5a9d5e9a5bc: Bug 1746016 - Save to Pocket refresh home panel. r=gvn,fluent-reviewers,mconley,andreio,flod
Scott <scott.downe@gmail.com> - Thu, 17 Feb 2022 19:00:07 +0000 - rev 608097
Push 158077 by sdowne@getpocket.com at Thu, 17 Feb 2022 20:23:25 +0000
Bug 1746016 - Save to Pocket refresh home panel. r=gvn,fluent-reviewers,mconley,andreio,flod Differential Revision: https://phabricator.services.mozilla.com/D137708
bcf3efefe2bee0465c563c7d6d0f137627f4fe72: Bug 1753995 - Remove non-test usage of WindowUtils.screenPixelsPerCSSPixel. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 07 Feb 2022 18:23:35 +0000 - rev 606926
Push 157378 by ealvarez@mozilla.com at Mon, 07 Feb 2022 18:26:03 +0000
Bug 1753995 - Remove non-test usage of WindowUtils.screenPixelsPerCSSPixel. r=mconley It does the same as window.devicePixelRatio. However a bunch of this code is copy-pasted code trying to scale a canvas, but not messing with full zoom is the right thing to do. The full zoom value in the top level browser.xhtml page is always 1 anyways, and WindowsPreviewPerTab looking at the current browser tab's full zoom is just bizarre... Differential Revision: https://phabricator.services.mozilla.com/D138020
27f85298d1a3e1391ba346ef3bf1ff4152be8017: Bug 1150377 - stop sorting the columns in the application handler list for right/middle clicks, r=mconley
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 24 Jan 2022 16:58:32 +0000 - rev 605357
Push 156578 by gijskruitbosch@gmail.com at Mon, 24 Jan 2022 17:28:48 +0000
Bug 1150377 - stop sorting the columns in the application handler list for right/middle clicks, r=mconley Differential Revision: https://phabricator.services.mozilla.com/D136747
f16516a913a04fd3486043afd632b841c67f0612: Bug 1750753 - Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 24 Jan 2022 11:56:13 +0000 - rev 605325
Push 156553 by ealvarez@mozilla.com at Mon, 24 Jan 2022 11:58:33 +0000
Bug 1750753 - Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D136277
320b13d2bea918a32d093402213c7d5fd649c500: Bug 1670108 - Make site-specific adapters using independent video wrapper classes. r=robwu,mconley
Micah Tigley <mtigley@mozilla.com> - Wed, 19 Jan 2022 16:36:36 +0000 - rev 604921
Push 156305 by mtigley@mozilla.com at Wed, 19 Jan 2022 16:38:57 +0000
Bug 1670108 - Make site-specific adapters using independent video wrapper classes. r=robwu,mconley Differential Revision: https://phabricator.services.mozilla.com/D109073
b7de29bd274cdb3bffe21657c0bde362fdeee8ed: Bug 1750753 - Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 18 Jan 2022 23:15:01 +0000 - rev 604843
Push 156249 by ealvarez@mozilla.com at Tue, 18 Jan 2022 23:17:24 +0000
Bug 1750753 - Use BrowsingContext.embedderElement rather than Window.frameElement in LayoutUtils. r=mconley Differential Revision: https://phabricator.services.mozilla.com/D136277