searching for reviewer(mccr8)
a445650b18589a643e3a4ea08c052493374aa1dd: Bug 1730534 - Fix release mode assertions so they actually happen in release builds r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 16:40:54 +0000 - rev 592353
Push 149943 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 16:44:46 +0000
Bug 1730534 - Fix release mode assertions so they actually happen in release builds r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D125983
8c9135ac1d10acf72a53e121875cedb75ac8a421: Bug 1536061 - Support tracing gray roots incrementally in the cycle collector r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 10:00:12 +0000 - rev 592297
Push 149914 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 10:02:47 +0000
Bug 1536061 - Support tracing gray roots incrementally in the cycle collector r=mccr8 This stores the iterator state between slices to allow us to trace these incrementally. Differential Revision: https://phabricator.services.mozilla.com/D125559
08cdd990b6757716a85c25e15f400f6cde7e9a30: Bug 1536061 - Change the gray root trace hook to allow gray roots to be marked incrementally r=sfink,mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 10:00:11 +0000 - rev 592296
Push 149914 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 10:02:47 +0000
Bug 1536061 - Change the gray root trace hook to allow gray roots to be marked incrementally r=sfink,mccr8 This adds a slice budget parameter and boolean return value to indicate whether tracing has finished. Differential Revision: https://phabricator.services.mozilla.com/D125558
fc881c57d1195f6efdc0ddd8fa67e0177a81ff20: Bug 1730534 - Part 4: Assert that there's only one JSHolderMap::Iter at any time r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 06:33:09 +0000 - rev 592279
Push 149902 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 06:35:45 +0000
Bug 1730534 - Part 4: Assert that there's only one JSHolderMap::Iter at any time r=mccr8 This iterator can update the map for removed items so it's not safe to have more than one live at any one time. Differential Revision: https://phabricator.services.mozilla.com/D125431
0f72a8c5f8c5099dce1dfc6dea302f4128a59659: Bug 1730534 - Part 3: Add an iterator for JSHolderMap r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 06:33:09 +0000 - rev 592278
Push 149902 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 06:35:45 +0000
Bug 1730534 - Part 3: Add an iterator for JSHolderMap r=mccr8 This adds an iterator over JSHolderMap and replaces use of the ForEach method with it. Differential Revision: https://phabricator.services.mozilla.com/D125429
007cbeea4325f28729bb4fb5b1904a55c8824eeb: Bug 1730534 - Part 2: Add an iterator for JSHolderMap's EntryVector r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 06:33:08 +0000 - rev 592277
Push 149902 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 06:35:45 +0000
Bug 1730534 - Part 2: Add an iterator for JSHolderMap's EntryVector r=mccr8 This replaces use of the ForEach method that takes an EntryVector with an iterator. Differential Revision: https://phabricator.services.mozilla.com/D125427
83d53ed76e0ff20dff195622dff403501ec42c94: Bug 1730534 - Part 1: Assert state of SegmentedVector iterator is valid r=mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Fri, 17 Sep 2021 06:33:08 +0000 - rev 592276
Push 149902 by jcoppeard@mozilla.com at Fri, 17 Sep 2021 06:35:45 +0000
Bug 1730534 - Part 1: Assert state of SegmentedVector iterator is valid r=mccr8 The next patches remove elements from a segmented vector that is being iterated. This patch adds assertions to ensure that we don't attempt to use an iterator that points to a removed element. The assertions are added to Done() because all the other methods call that. Differential Revision: https://phabricator.services.mozilla.com/D125426
5e884be161d42fc7f02111bee4b5f0e6c7c00670: Bug 1725008 - Implement FuzzingFunctions.crash() r=glandium,mccr8
Tyson Smith <twsmith@mozilla.com> - Wed, 15 Sep 2021 18:24:04 +0000 - rev 592096
Push 149802 by amccreight@mozilla.com at Wed, 15 Sep 2021 18:50:54 +0000
Bug 1725008 - Implement FuzzingFunctions.crash() r=glandium,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D125000
51ff715c43aeb1ab17c2f38a9c9263ce3fab9ea3: Bug 1730140 - Remove the gray root buffer and mark gray roots after the start of collection r=sfink,mccr8
Jon Coppeard <jcoppeard@mozilla.com> - Tue, 14 Sep 2021 07:49:39 +0000 - rev 591874
Push 149673 by jcoppeard@mozilla.com at Tue, 14 Sep 2021 07:52:10 +0000
Bug 1730140 - Remove the gray root buffer and mark gray roots after the start of collection r=sfink,mccr8 This removes gray root buffering from the first marking slice and traces the gray roots directly in a later slice. This relies on Heap<T> read barriers being sufficient to ensure correctness. This is conservative in that it makes no effort to skip tracing roots added after the start of GC. It also doesn't trace roots removed after the start of GC, but this is OK because barriers ensure marking of any observed values. The gray root tracing callback will be called once per sweep group, which means we will trace all zone holders and xpconnect gray roots for every group rather than just once. This should not be a problem in practice as we expect the number of zones and hence zone groups to decrease with fission. On the plus side we no longer have to do a virtual dispatch per root traced (for the buffering tracer), allocate memory for the buffer, or trace each root twice. Note that this doesn't make the gray root marking itself incremental yet. Differential Revision: https://phabricator.services.mozilla.com/D125188
beaa29229ad19b0f08ade34640190e371ce57295: Bug 1730595: Remove unused constants from nsDOMOfflineResourceList.cpp. r=mccr8
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 13 Sep 2021 23:38:57 +0000 - rev 591849
Push 149659 by dholbert@mozilla.com at Mon, 13 Sep 2021 23:41:22 +0000
Bug 1730595: Remove unused constants from nsDOMOfflineResourceList.cpp. r=mccr8 The removed entries all have zero usages in this file; i.e. they're all dead code. Differential Revision: https://phabricator.services.mozilla.com/D125466
b6fdb5fcdd0fbf8630794ed3fdac54dbe0bc93a7: Bug 1729011 - Change dead link to MDN in nsCOMPtr.h to reference source docs. r=xpcom-reviewers,mccr8 DONTBUILD
Bryce Seager van Dyk <bvandyk@mozilla.com> - Fri, 03 Sep 2021 15:14:01 +0000 - rev 590950
Push 149151 by bvandyk@mozilla.com at Fri, 03 Sep 2021 15:16:22 +0000
Bug 1729011 - Change dead link to MDN in nsCOMPtr.h to reference source docs. r=xpcom-reviewers,mccr8 DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D124461
de92d70a4e19441e7047639347cd35ce4d11bd1f: Bug 1725335 - Streamline ownership and locking in MessageTask, r=ipc-reviewers,mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 01 Sep 2021 15:26:54 +0000 - rev 590477
Push 148983 by nlayzell@mozilla.com at Wed, 01 Sep 2021 15:29:18 +0000
Bug 1725335 - Streamline ownership and locking in MessageTask, r=ipc-reviewers,mccr8 This simplifies the logic around MessageTask's lifecycle to make ownership as clear as possible and reduce the number of redundant checks. This new change no longer clears the mChannel member when the MessageTask is disconnected, instead relying on isInList() to check whether the MessageTask is still in the channel's mPending list. This is already being automatically managed as the mPending list is modified, and should avoid potential usage mistakes. Differential Revision: https://phabricator.services.mozilla.com/D123140
1952a66a1448f3e089a06ba9f65ecf97634d8ae6: Bug 1727422 - Support arbitrary integer keys in nsTHashMap, r=xpcom-reviewers,mccr8
Nika Layzell <nika@thelayzells.com> - Wed, 25 Aug 2021 16:31:08 +0000 - rev 589935
Push 148631 by nlayzell@mozilla.com at Wed, 25 Aug 2021 17:08:58 +0000
Bug 1727422 - Support arbitrary integer keys in nsTHashMap, r=xpcom-reviewers,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D123547
4534179de22c013eb97e8226a538096d7a648721: Bug 1678149 - Use a mozilla::Queue in TaskQueue r=xpcom-reviewers,mccr8
kriswright <kwright@mozilla.com> - Wed, 25 Aug 2021 14:10:06 +0000 - rev 589919
Push 148615 by kwright@mozilla.com at Wed, 25 Aug 2021 14:29:14 +0000
Bug 1678149 - Use a mozilla::Queue in TaskQueue r=xpcom-reviewers,mccr8 It looks like we can do a mostly direct swap from `std::Queue` to `mozilla::Queue` without needing to expose any new API, so that's what I've done here. Differential Revision: https://phabricator.services.mozilla.com/D123523
da77c9ae418c6d8cf77634a059fc4909a8fe4fe0: Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 23 Aug 2021 10:54:11 +0000 - rev 589578
Push 148433 by krosylight@mozilla.com at Mon, 23 Aug 2021 10:56:36 +0000
Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug Differential Revision: https://phabricator.services.mozilla.com/D123163
d21b3f88a2b43207bbf8830057e56eb9eae5690b: Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 23 Aug 2021 00:35:40 +0000 - rev 589533
Push 148410 by krosylight@mozilla.com at Mon, 23 Aug 2021 00:38:05 +0000
Bug 1726648 - Add a helper to trim brackets from nsID r=mccr8,smaug Differential Revision: https://phabricator.services.mozilla.com/D123163
da16c4f3a988833a6d419950f5850b2271b58772: Bug 1308094 - Remove PL_strdup and PL_strfree from BloatEntry r=xpcom-reviewers,mccr8
Nicklas Boman <smurfd@gmail.com> - Tue, 17 Aug 2021 19:34:32 +0000 - rev 589157
Push 148183 by amccreight@mozilla.com at Tue, 17 Aug 2021 19:40:33 +0000
Bug 1308094 - Remove PL_strdup and PL_strfree from BloatEntry r=xpcom-reviewers,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D122149
cb4975bbd705c04f71ccd74b42e1ce48d0876f0e: Bug 1725256 - Add process & remote type documentation, r=handyman,mccr8
Nika Layzell <nika@thelayzells.com> - Tue, 17 Aug 2021 18:01:51 +0000 - rev 589142
Push 148172 by nlayzell@mozilla.com at Tue, 17 Aug 2021 18:04:13 +0000
Bug 1725256 - Add process & remote type documentation, r=handyman,mccr8 This patch adds basic documentation for the core process architecture, with a focus on the capabilities of specific content process remote types. Details are also included about the capabilities of individual helper processes. These docs have some overlap with the documentation for adding new child process types being added in D121871, but with a different focus, intended more as an overview, and an intended audience of people interested in the browser's general process architecture. I considered adding more detail about the specific capabilities restricted by each sandboxing policy, however I don't know the specifics well enough to document them accurately. I think a separate document, linked to from this one, about our OS-level sandboxing for each process type could be useful. Differential Revision: https://phabricator.services.mozilla.com/D122395
1d7502f30921f47859886810c3370593d0f2737e: Bug 1725593 - Get rid of SendCheckAndSuggest sync IPC. r=masayuki,ipc-reviewers,mccr8
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 16 Aug 2021 01:40:00 +0000 - rev 589012
Push 148078 by m_kato@ga2.so-net.ne.jp at Mon, 16 Aug 2021 01:42:25 +0000
Bug 1725593 - Get rid of SendCheckAndSuggest sync IPC. r=masayuki,ipc-reviewers,mccr8 Depends on D122579 Differential Revision: https://phabricator.services.mozilla.com/D122580
2f14f5616dca4f3f6008b2e6f162d0a8d3b5ccb3: Bug 1724777, optimize suppressed MicroTask handling, r=mccr8
Olli Pettay <Olli.Pettay@helsinki.fi> - Thu, 12 Aug 2021 16:01:08 +0000 - rev 588713
Push 147971 by opettay@mozilla.com at Thu, 12 Aug 2021 16:41:49 +0000
Bug 1724777, optimize suppressed MicroTask handling, r=mccr8 The test is in theory racy, but trying to limit the cases when it might behave badly by running it on opt desktop builds only. Without the patch the 'period' check takes over 400ms locally and with the patch 1-3ms. The changes are just trying to optimize execution, not change the behavior. Use of SuppressedMicroTasks is perhaps a bit odd, but it helps keeping SavedMicroTaskQueue and similar code simple. Differential Revision: https://phabricator.services.mozilla.com/D122290
d56957d4c13bd057e45737933a62c800a6f1ec88: Bug 1723050 - Part 16: Replace typedef by using in dom/ipc/ r=mccr8
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 09 Aug 2021 13:37:28 +0000 - rev 588204
Push 147708 by krosylight@mozilla.com at Mon, 09 Aug 2021 13:41:27 +0000
Bug 1723050 - Part 16: Replace typedef by using in dom/ipc/ r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D121314
c68fb250c8ed60d13d816f7683affbcc01287ce3: Bug 1724451, activate the relevant processes when restoring a bfcached page on the foreground tab, r=mccr8
Olli Pettay <Olli.Pettay@helsinki.fi> - Fri, 06 Aug 2021 17:39:21 +0000 - rev 588109
Push 147641 by opettay@mozilla.com at Fri, 06 Aug 2021 17:41:46 +0000
Bug 1724451, activate the relevant processes when restoring a bfcached page on the foreground tab, r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D122008
8c6dba83423f172fc304a79b70f8e6bf79d716ed: Bug 1719319: Make consistency error non-fatal on relase. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Wed, 04 Aug 2021 00:04:28 +0000 - rev 587745
Push 147427 by maglione.k@gmail.com at Wed, 04 Aug 2021 02:16:11 +0000
Bug 1719319: Make consistency error non-fatal on relase. r=mccr8 I still haven't figured out why this is happening, so since we can make it non-fatal on release builds, we should, given the crash volume. I don't want to completely silence the issue in non-release builds, since something is clearly still wrong. Differential Revision: https://phabricator.services.mozilla.com/D121686
963b9b0d8867e66aa88f9b52db5f5278161118b0: Bug 1723730 - Add temporary TSan suppression. r=mccr8,decoder
Kris Wright <kwright@mozilla.com> - Tue, 03 Aug 2021 20:39:06 +0000 - rev 587729
Push 147415 by kwright@mozilla.com at Tue, 03 Aug 2021 23:44:13 +0000
Bug 1723730 - Add temporary TSan suppression. r=mccr8,decoder Differential Revision: https://phabricator.services.mozilla.com/D121664
aa73303f5c1b1e284adc58b3833b90b76c59c389: Bug 1723176 - Add temporary TSan suppression. r=decoder,mccr8
Kris Wright <kwright@mozilla.com> - Tue, 03 Aug 2021 20:39:05 +0000 - rev 587728
Push 147415 by kwright@mozilla.com at Tue, 03 Aug 2021 23:44:13 +0000
Bug 1723176 - Add temporary TSan suppression. r=decoder,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D121549
b04a54bb11fbe1573cd08d0175106a00b1c74eb5: Bug 1723170 - Add temporary TSan suppression. r=decoder,mccr8
Kris Wright <kwright@mozilla.com> - Tue, 03 Aug 2021 20:39:05 +0000 - rev 587727
Push 147415 by kwright@mozilla.com at Tue, 03 Aug 2021 23:44:13 +0000
Bug 1723170 - Add temporary TSan suppression. r=decoder,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D121548
b4ad83d43d805e48d06e23bddda324d3ff16a40c: Bug 1723142 - Add temporary TSan suppression. r=decoder,mccr8
Kris Wright <kwright@mozilla.com> - Tue, 03 Aug 2021 20:39:05 +0000 - rev 587726
Push 147415 by kwright@mozilla.com at Tue, 03 Aug 2021 23:44:13 +0000
Bug 1723142 - Add temporary TSan suppression. r=decoder,mccr8 This call appears in the top frames of 2 different stacks (Bug 1723351 and Bug 1723142) so from my understanding it will suppress both test fails. I included both bug numbers for reference. Differential Revision: https://phabricator.services.mozilla.com/D121546
ace1ca36013843a2ebf046196571b56278505514: Bug 1723321 - Add temporary TSan suppression. r=decoder,mccr8
Kris Wright <kwright@mozilla.com> - Tue, 03 Aug 2021 20:39:04 +0000 - rev 587725
Push 147415 by kwright@mozilla.com at Tue, 03 Aug 2021 23:44:13 +0000
Bug 1723321 - Add temporary TSan suppression. r=decoder,mccr8 This commit also adds a newline to the entry directly above the new suppression, since it was missing one. Differential Revision: https://phabricator.services.mozilla.com/D121545
5d6457f23f722173b407a09d042075c457e12556: Bug 1722754 - Fix up links and formating. r=mccr8
Bobby Holley <bobbyholley@gmail.com> - Thu, 29 Jul 2021 15:22:45 +0000 - rev 587020
Push 147112 by bholley@mozilla.com at Thu, 29 Jul 2021 15:25:15 +0000
Bug 1722754 - Fix up links and formating. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D121115
cde509bd4d5d1fa5b97373bd68bd0a74c24f36cd: Bug 1722754 - Mechanically import old MDN docs. r=mccr8
Bobby Holley <bobbyholley@gmail.com> - Thu, 29 Jul 2021 15:22:44 +0000 - rev 587019
Push 147112 by bholley@mozilla.com at Thu, 29 Jul 2021 15:25:15 +0000
Bug 1722754 - Mechanically import old MDN docs. r=mccr8 Generated with: pandoc -t rst https://raw.githubusercontent.com/mdn/archived-content/main/files/en-us/mozilla/gecko/script_security/index.html > index.rst pandoc -t rst https://raw.githubusercontent.com/mdn/archived-content/b7b6516b2b522533e8ba51cb944700ace7dace4d/files/en-us/mozilla/tech/xray_vision/index.html > xray_vision.rst Per the instructions at: https://firefox-source-docs.mozilla.org/tools/moztreedocs/mdn-import.html Images refetched from archive.org. Differential Revision: https://phabricator.services.mozilla.com/D121116
c7bbd484becfe335d9d2d81ea41da1bea773366f: Bug 1722453 part 4 - Use a reserved slot instead of private slot for XPCWrappedNativeTearOff. r=jonco,mccr8
Jan de Mooij <jdemooij@mozilla.com> - Thu, 29 Jul 2021 07:06:08 +0000 - rev 586953
Push 147084 by jdemooij@mozilla.com at Thu, 29 Jul 2021 07:08:54 +0000
Bug 1722453 part 4 - Use a reserved slot instead of private slot for XPCWrappedNativeTearOff. r=jonco,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D120939
21a34ba39e9804e0f2070391bfb703a841119877: Bug 1722453 part 3 - Use a reserved slot instead of private slot for XPCWrappedNativeProto. r=jonco,mccr8
Jan de Mooij <jdemooij@mozilla.com> - Thu, 29 Jul 2021 07:06:07 +0000 - rev 586952
Push 147084 by jdemooij@mozilla.com at Thu, 29 Jul 2021 07:08:54 +0000
Bug 1722453 part 3 - Use a reserved slot instead of private slot for XPCWrappedNativeProto. r=jonco,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D120938
385f462e70b91d280b45c25f246dbc920648f84b: Bug 1722453 part 2 - Use a reserved slot instead of private slot for telemetry histogram objects. r=jonco,mccr8
Jan de Mooij <jdemooij@mozilla.com> - Thu, 29 Jul 2021 07:06:07 +0000 - rev 586951
Push 147084 by jdemooij@mozilla.com at Thu, 29 Jul 2021 07:08:54 +0000
Bug 1722453 part 2 - Use a reserved slot instead of private slot for telemetry histogram objects. r=jonco,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D120937
c0e958baeeb7e6c0d3668a1be4d65ddadf173e8a: Bug 1719319: Part 2 - Make sure URLPreloader startup is marked complete at the same time as ScriptPreloader. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 27 Jul 2021 20:29:10 +0000 - rev 586783
Push 146986 by maglione.k@gmail.com at Tue, 27 Jul 2021 20:31:35 +0000
Bug 1719319: Part 2 - Make sure URLPreloader startup is marked complete at the same time as ScriptPreloader. r=mccr8 We need to make sure we stop adding entries before we start the cache write task (which is triggered by the ScriptPreloader's cache write task after startup is marked complete) so that the hashtable we're writing can't be modified while we're iterating it from that thread. Differential Revision: https://phabricator.services.mozilla.com/D120531
f9da889b97e82c3e8f99530d2af098e2056a5509: Bug 1719319: Don't try to use the URLPreloader cache before it's fully initialized. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Tue, 27 Jul 2021 20:29:09 +0000 - rev 586782
Push 146986 by maglione.k@gmail.com at Tue, 27 Jul 2021 20:31:35 +0000
Bug 1719319: Don't try to use the URLPreloader cache before it's fully initialized. r=mccr8 Anything accessed before that time won't benefit from caching, and having entries inserted into the hashtable before the cache file is read may lead to undefined behavior. This bug shouldn't be exploitable, since it only affects file reads that happen long before any untrusted code has a chance to run. Differential Revision: https://phabricator.services.mozilla.com/D120391
78e3c985ebb1ece65372a9f7df684585ec5236e1: Bug 1716849: Add crash annotation for error when aborting for failed module import. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Thu, 22 Jul 2021 16:58:02 +0000 - rev 586456
Push 146752 by maglione.k@gmail.com at Thu, 22 Jul 2021 18:13:08 +0000
Bug 1716849: Add crash annotation for error when aborting for failed module import. r=mccr8 There are a number of modules that we import from C++ and can't continue running without. We have a number of crashes for some of those failed loads. A lot of them are from OOMs or corruption, but we're not sure about the rest. This patch adds a crash annotation with the details of the error wherever we abort for failing to load a module. Differential Revision: https://phabricator.services.mozilla.com/D120290
4031a41a2a9fc7516b89d57cb2837571f9f008fb: Bug 1720688 - Handle invalid attribute values for "Nested"/"NestedUpTo" and "Priority", r=mccr8
Kashav Madan <kshvmdn@gmail.com> - Thu, 22 Jul 2021 02:24:43 +0000 - rev 586405
Push 146707 by kmadan@mozilla.com at Thu, 22 Jul 2021 02:27:36 +0000
Bug 1720688 - Handle invalid attribute values for "Nested"/"NestedUpTo" and "Priority", r=mccr8 This KeyErrors since we build the ast before we typecheck attributes. Differential Revision: https://phabricator.services.mozilla.com/D120376
c0659c98c192ae4afead55516f0f40a592d3c8fb: Bug 1720688 - Support extended attribute syntax in protocol declarations, r=mccr8
Kashav Madan <kshvmdn@gmail.com> - Thu, 22 Jul 2021 02:24:43 +0000 - rev 586404
Push 146707 by kmadan@mozilla.com at Thu, 22 Jul 2021 02:27:36 +0000
Bug 1720688 - Support extended attribute syntax in protocol declarations, r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D119975
ef812b3d914d15863fae327a77824da5692a3922: Bug 1716849: Add crash annotation for error when aborting for failed module import. r=mccr8
Kris Maglione <maglione.k@gmail.com> - Thu, 22 Jul 2021 01:28:22 +0000 - rev 586401
Push 146704 by maglione.k@gmail.com at Thu, 22 Jul 2021 01:30:48 +0000
Bug 1716849: Add crash annotation for error when aborting for failed module import. r=mccr8 There are a number of modules that we import from C++ and can't continue running without. We have a number of crashes for some of those failed loads. A lot of them are from OOMs or corruption, but we're not sure about the rest. This patch adds a crash annotation with the details of the error wherever we abort for failing to load a module. Differential Revision: https://phabricator.services.mozilla.com/D120290
097173dd4f93792c051c44a74e806b89bb7525d5: Bug 1714583 - allow nsIFile::Create to skip creating ancestor directories, to fix IOUtils::makeDirectory, to fix UNC default download folders, r=barret,xpcom-reviewers,mccr8
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Wed, 21 Jul 2021 18:38:12 +0000 - rev 586352
Push 146671 by gijskruitbosch@gmail.com at Wed, 21 Jul 2021 18:56:53 +0000
Bug 1714583 - allow nsIFile::Create to skip creating ancestor directories, to fix IOUtils::makeDirectory, to fix UNC default download folders, r=barret,xpcom-reviewers,mccr8 Differential Revision: https://phabricator.services.mozilla.com/D120338
312aa83dc7ed1f06a7e9ce26788388a41cdabcb4: Bug 1721349 - Move mSubmitter from HTMLFormSubmission to FormData and make it participate in cycle collection; r=mccr8
Edgar Chen <echen@mozilla.com> - Wed, 21 Jul 2021 09:52:20 +0000 - rev 586304
Push 146630 by echen@mozilla.com at Wed, 21 Jul 2021 09:54:49 +0000
Bug 1721349 - Move mSubmitter from HTMLFormSubmission to FormData and make it participate in cycle collection; r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D120334
4efdd0314268c16d4be71aef5ac6c7f76e9f367e: Bug 1719108. Check in a few places in imagelib if it's too late in shutdown to dispatch runnables. r=mccr8
Timothy Nikkel <tnikkel@gmail.com> - Tue, 13 Jul 2021 20:31:57 +0000 - rev 585455
Push 146245 by tnikkel@mozilla.com at Tue, 13 Jul 2021 20:46:06 +0000
Bug 1719108. Check in a few places in imagelib if it's too late in shutdown to dispatch runnables. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D119712
fe76633b0f3beb4b44d489e839626ca1d379482f: Bug 1719795 part 6 - Remove null check for JS::GetClass return value. r=mccr8
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:34 +0000 - rev 585395
Push 146195 by jdemooij@mozilla.com at Tue, 13 Jul 2021 09:34:38 +0000
Bug 1719795 part 6 - Remove null check for JS::GetClass return value. r=mccr8 Every JSObject has a non-null JSClass and a lot of code depends on this. Differential Revision: https://phabricator.services.mozilla.com/D119618
991fd9b37ce8b10a97ca6f848f43b0e5fba82c63: Bug 1719795 part 5 - Change JSCLASS_PRIVATE_IS_NSISUPPORTS JSClasses to use a reserved slot instead. r=mccr8,jonco
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:34 +0000 - rev 585394
Push 146195 by jdemooij@mozilla.com at Tue, 13 Jul 2021 09:34:38 +0000
Bug 1719795 part 5 - Change JSCLASS_PRIVATE_IS_NSISUPPORTS JSClasses to use a reserved slot instead. r=mccr8,jonco This is a step towards removing object private slots. Classes with JSCLASS_PRIVATE_IS_NSISUPPORTS now use JSCLASS_SLOT0_IS_NSISUPPORTS instead. For most classes this means we need to add an extra reserved slot and remove the private slot. Global objects (SimpleGlobalObject and the XPConnect BackstagePass and Sandbox globals) however can use the JSCLASS_GLOBAL_APPLICATION_SLOTS already there. These slots were only used for WebIDL DOM globals until now. Differential Revision: https://phabricator.services.mozilla.com/D119502
69fbadc353c3986f1b1f4256f717b7546f61e194: Bug 1719795 part 4 - Remove unused AutoClonePrivateGuard. r=mccr8
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:34 +0000 - rev 585393
Push 146195 by jdemooij@mozilla.com at Tue, 13 Jul 2021 09:34:38 +0000
Bug 1719795 part 4 - Remove unused AutoClonePrivateGuard. r=mccr8 Depends on D119500 Differential Revision: https://phabricator.services.mozilla.com/D119501
cebc11755de6e13f6e3d013903d29364a99020d8: Bug 1719795 part 2 - Use SandboxPrivate::GetPrivate more. r=mccr8
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:33 +0000 - rev 585391
Push 146195 by jdemooij@mozilla.com at Tue, 13 Jul 2021 09:34:38 +0000
Bug 1719795 part 2 - Use SandboxPrivate::GetPrivate more. r=mccr8 Depends on D119498 Differential Revision: https://phabricator.services.mozilla.com/D119499
202535112cbd59ce431474a70bc5aab39e946fac: Bug 1719795 part 1 - Add a helper function for getting a SimpleGlobalObject's native global. r=mccr8
Jan de Mooij <jdemooij@mozilla.com> - Tue, 13 Jul 2021 09:31:32 +0000 - rev 585390
Push 146195 by jdemooij@mozilla.com at Tue, 13 Jul 2021 09:34:38 +0000
Bug 1719795 part 1 - Add a helper function for getting a SimpleGlobalObject's native global. r=mccr8 Differential Revision: https://phabricator.services.mozilla.com/D119498
4d66254ef407e4cafaa3fc2eda572d01840eacfc: Bug 1703692 - Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8
Kashav Madan <kshvmdn@gmail.com> - Sat, 26 Jun 2021 20:25:29 +0000 - rev 584501
Push 145709 by kmadan@mozilla.com at Sat, 26 Jun 2021 20:28:03 +0000
Bug 1703692 - Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8 And include it in Session Store flushes to avoid dropping updates in case the browser is unavailable. Differential Revision: https://phabricator.services.mozilla.com/D118385
6745b363a745e3e8667ad43f8061375b878f14f3: Bug 1703692 - Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8
Kashav Madan <kshvmdn@gmail.com> - Sat, 26 Jun 2021 05:49:12 +0000 - rev 584488
Push 145701 by kmadan@mozilla.com at Sat, 26 Jun 2021 05:51:46 +0000
Bug 1703692 - Store the latest embedder's permanent key on CanonicalBrowsingContext, r=nika,mccr8 And include it in Session Store flushes to avoid dropping updates in case the browser is unavailable. Differential Revision: https://phabricator.services.mozilla.com/D118385
1880c02699795256b0b554ef3c1bfd4d30d13920: Bug 1718262 - Remove duplicated declaration of NS_GetCurrentThread. r=mccr8
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 25 Jun 2021 18:35:09 +0000 - rev 584457
Push 145674 by jmuizelaar@mozilla.com at Fri, 25 Jun 2021 18:37:35 +0000
Bug 1718262 - Remove duplicated declaration of NS_GetCurrentThread. r=mccr8 The other definition is in nsThreadUtils.h Differential Revision: https://phabricator.services.mozilla.com/D118831