searching for reviewer(mayhemer)
e5816310d6890da627ef1ee5f76daf86a48be4ec: Bug 1655716 - Introduce TYPE_INTERNAL_FETCH_PRELOAD and use in HTMLLinkElement::AsValueToContentPolicy() - r=emilio,mayhemer,ckerschb
Frederik Braun <fbraun@mozilla.com> - Tue, 11 Aug 2020 12:33:14 +0000 - rev 544269
Push 123929 by fbraun@mozilla.com at Tue, 11 Aug 2020 12:54:08 +0000
Bug 1655716 - Introduce TYPE_INTERNAL_FETCH_PRELOAD and use in HTMLLinkElement::AsValueToContentPolicy() - r=emilio,mayhemer,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D85980
d1e2ee395d42d652a84ce64be679cbe2048fa792: Bug 1657173 - Make <link rel=preload as=style> not block onload incorrectly. r=mayhemer
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 11 Aug 2020 09:41:28 +0000 - rev 544252
Push 123916 by ealvarez@mozilla.com at Tue, 11 Aug 2020 09:45:59 +0000
Bug 1657173 - Make <link rel=preload as=style> not block onload incorrectly. r=mayhemer And fix the only WPT for this while at it which was using the wrong URL (and thus would always pass). This actually makes me a bit uncomfortable given the amount of times I've seen the pattern: <link href="important.css" rel="preload" as="style" onload="this.rel = 'stylesheet'"> As that means that important.css won't block the load event. But let's try. Differential Revision: https://phabricator.services.mozilla.com/D86049
09921685a632ade2b9da3e027f433c12902bccd3: Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 04 Aug 2020 10:01:09 +0000 - rev 543202
Push 123299 by amarchesini@mozilla.com at Tue, 04 Aug 2020 10:38:34 +0000
Bug 1656980 - CookieService::GetCookiesSince needs to check the CookieService initialization state, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D85824
706fd7c55ac6bab176ec782643efcfbf1ed63068: Bug 1647950 - stop redirect setup if the channel is canceled in child, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Mon, 03 Aug 2020 16:49:13 +0000 - rev 543149
Push 123259 by juhsu@mozilla.com at Mon, 03 Aug 2020 17:55:03 +0000
Bug 1647950 - stop redirect setup if the channel is canceled in child, r=mayhemer,necko-reviewers In child process, if the channel starts to setupRedirect after cancelled, we should fail the redirection setup and fail the redirect check. Differential Revision: https://phabricator.services.mozilla.com/D84881
9253b3465e9e57897421f824135c16aa6ba151c6: Bug 1654614 - resume channel event queue for parent intercepted channel, r=mayhemer,necko-reviewers,jdm
Junior Hsu <juhsu@mozilla.com> - Fri, 24 Jul 2020 14:48:07 +0000 - rev 542088
Push 122628 by juhsu@mozilla.com at Fri, 24 Jul 2020 17:58:09 +0000
Bug 1654614 - resume channel event queue for parent intercepted channel, r=mayhemer,necko-reviewers,jdm Differential Revision: https://phabricator.services.mozilla.com/D84572
502c4fb165fcab9b215cd1b91be87bdc4ff7171b: Bug 1652189 - SendOnStartRequestSent only for main document, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Fri, 24 Jul 2020 05:13:26 +0000 - rev 542087
Push 122627 by juhsu@mozilla.com at Fri, 24 Jul 2020 17:57:11 +0000
Bug 1652189 - SendOnStartRequestSent only for main document, r=mayhemer,necko-reviewers Even if loadflag contains LOAD_DOCUMENT_NEEDS_COOKIE, we update cookie only for the main documen https://searchfox.org/mozilla-central/rev/9b282b34b5aa0f836beb735656c55efb2cc4c617/dom/ipc/ContentParent.cpp#5704 Hence, we don't need to wait for main thread IPC to proceed HttpChannelChild::OnStartRequest Differential Revision: https://phabricator.services.mozilla.com/D84275
6dea4da50bf5921f32d8aa32ace96b67299b11ad: Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers,dragana
Shane Caraveo <scaraveo@mozilla.com> - Thu, 23 Jul 2020 18:50:49 +0000 - rev 541908
Push 122568 by honzab.moz@firemni.cz at Fri, 24 Jul 2020 08:51:46 +0000
Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers,dragana Differential Revision: https://phabricator.services.mozilla.com/D83006
5698ddfe5e51cc48683c9964051f2d1a457c9214: Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike
Jared Wein <jwein@mozilla.com> - Mon, 20 Jul 2020 10:05:58 +0000 - rev 541219
Push 122117 by gijskruitbosch@gmail.com at Mon, 20 Jul 2020 10:10:53 +0000
Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike Differential Revision: https://phabricator.services.mozilla.com/D81623
48fd0d4340232b8e176653226fd69b3ce8dc8fb3: Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike
Jared Wein <jwein@mozilla.com> - Sun, 19 Jul 2020 17:10:46 +0000 - rev 541168
Push 122085 by gijskruitbosch@gmail.com at Sun, 19 Jul 2020 17:16:33 +0000
Bug 1649250 - Add experimental features that were introduced in Firefox Nightly 70 and higher. r=jbauman,kvark,jwatt,mayhemer,emilio,masayuki,baku,gl,preferences-reviewers,jdescottes,Pike Differential Revision: https://phabricator.services.mozilla.com/D81623
82b8d1e9468a3817e55579cb2fea9d36568cc3ac: Bug 1650409 - Null check preload URL parsing. r=mayhemer
Cameron McCormack <cam@mcc.id.au> - Sat, 18 Jul 2020 13:54:22 +0000 - rev 541144
Push 122070 by cmccormack@mozilla.com at Sun, 19 Jul 2020 03:40:00 +0000
Bug 1650409 - Null check preload URL parsing. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D84035
0cabef091ee349b80772c963fe333d5dae4947fd: Bug 1637745. r=Gijs,necko-reviewers,mayhemer
Marco Bonardo <mbonardo@mozilla.com> - Fri, 17 Jul 2020 13:45:58 +0000 - rev 541137
Push 122063 by mak77@bonardo.net at Sat, 18 Jul 2020 10:13:15 +0000
Bug 1637745. r=Gijs,necko-reviewers,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D80345
d745eb8f40b3c813657476ebc0001c8982db7a71: Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers
Shane Caraveo <scaraveo@mozilla.com> - Fri, 17 Jul 2020 12:28:48 +0000 - rev 540919
Push 121988 by honzab.moz@firemni.cz at Fri, 17 Jul 2020 12:29:40 +0000
Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D83006
5d5fb35f83ed07f16b4ed242e7dd7d091af16748: Bug 1645204 - Fix WebRequest.jsm r=robwu,necko-reviewers,mayhemer
Sebastian Streich <sstreich@mozilla.com> - Thu, 16 Jul 2020 14:58:03 +0000 - rev 540774
Push 121908 by rvandermeulen@mozilla.com at Thu, 16 Jul 2020 17:43:09 +0000
Bug 1645204 - Fix WebRequest.jsm r=robwu,necko-reviewers,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D80953
617c0511e0c83ab648b3e857d8769ca54e134477: Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers
Shane Caraveo <scaraveo@mozilla.com> - Wed, 15 Jul 2020 14:35:32 +0000 - rev 540604
Push 121812 by scaraveo@mozilla.com at Wed, 15 Jul 2020 17:14:33 +0000
Bug 1649813 test dns api failure when forwarding dns to socks proxy r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D83006
0bd9187a960a0bfb3f731ba9aafc39fe9cf0e955: Bug 1645051 - Calculated smart max cache size shouldn't overwrite browser.cache.disk.capacity pref r=necko-reviewers,mayhemer
Michal Novotny <michal.novotny@gmail.com> - Tue, 14 Jul 2020 16:54:22 +0000 - rev 540431
Push 121707 by mnovotny@mozilla.com at Tue, 14 Jul 2020 17:14:27 +0000
Bug 1645051 - Calculated smart max cache size shouldn't overwrite browser.cache.disk.capacity pref r=necko-reviewers,mayhemer Differential Revision: https://phabricator.services.mozilla.com/D83377
5184aa5c6b0da87f60ed06e555e416b39a1ea9b4: Bug 1649673 - Isolate speculative connections per first-party when privacy.partition.network_state is set to true, r=mayhemer,necko-reviewers
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 10 Jul 2020 11:54:34 +0000 - rev 539878
Push 121336 by amarchesini@mozilla.com at Fri, 10 Jul 2020 12:06:26 +0000
Bug 1649673 - Isolate speculative connections per first-party when privacy.partition.network_state is set to true, r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D81810
c067a02faf4678b99e128cdc2753078a8429d51e: Bug 1650211 - Ignore cookie settings during the shutdown, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 09 Jul 2020 14:14:41 +0000 - rev 539621
Push 121233 by amarchesini@mozilla.com at Thu, 09 Jul 2020 16:00:10 +0000
Bug 1650211 - Ignore cookie settings during the shutdown, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D82498
e106c60b7be4926cd8a897bf1157bc6ad6b35b83: Bug 1607212 - Update TSan suppressions for fixed Necko cache race. r=mayhemer
Christian Holler <choller@mozilla.com> - Thu, 09 Jul 2020 14:13:27 +0000 - rev 539610
Push 121225 by choller@mozilla.com at Thu, 09 Jul 2020 14:33:03 +0000
Bug 1607212 - Update TSan suppressions for fixed Necko cache race. r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D82899
d90c8b4228bde30e5d3ced226975b5f353b68e63: Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Thu, 09 Jul 2020 11:05:58 +0000 - rev 539596
Push 121214 by amarchesini@mozilla.com at Thu, 09 Jul 2020 12:57:31 +0000
Bug 1650656 - Call CookieCommons::SchemeToSchemeType only when the scheme is supported, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D82491
8396d94496e0a24c3edfb4a4862d14ddb8528396: Bug 1649965 - only waiting for main thread OnStartRequestSent for LOAD_DOCUMENT_NEEDS_COOKIE, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Wed, 08 Jul 2020 15:47:36 +0000 - rev 539391
Push 121096 by juhsu@mozilla.com at Wed, 08 Jul 2020 16:03:29 +0000
Bug 1649965 - only waiting for main thread OnStartRequestSent for LOAD_DOCUMENT_NEEDS_COOKIE, r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80682
14420a624d0a6b882e6ef06e717e2231d4b437a2: Bug 1645901 - handle cookie setting in child process for Set-Cookie response, r=baku,mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 07 Jul 2020 15:19:09 +0000 - rev 539258
Push 121019 by juhsu@mozilla.com at Wed, 08 Jul 2020 02:30:41 +0000
Bug 1645901 - handle cookie setting in child process for Set-Cookie response, r=baku,mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D82130
eb15ef7bbe26bd068d4723e7a34b7d3054c91908: Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 07 Jul 2020 21:46:34 +0000 - rev 539246
Push 121010 by juhsu@mozilla.com at Wed, 08 Jul 2020 00:03:12 +0000
Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers We're shorter the name! Depends on D81274 Differential Revision: https://phabricator.services.mozilla.com/D81275
48adf08a73711ac85c9a3002628eb5418076b27e: Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 07 Jul 2020 21:46:01 +0000 - rev 539245
Push 121010 by juhsu@mozilla.com at Wed, 08 Jul 2020 00:03:12 +0000
Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers Endpoint would be passed by a series of std::move via nsHttpChannel -> HttpChannelParent -> HttpBackgroundChannelParent ---> HttpBackgroundChannelChild -> HttpChannelChild | | Resolve promise after successfully send IPC<-/ Depends on D81273 Differential Revision: https://phabricator.services.mozilla.com/D81274
e34eddef39c842c48f1a5579bf9465ba6a3fb02b: Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 07 Jul 2020 21:45:08 +0000 - rev 539244
Push 121010 by juhsu@mozilla.com at Wed, 08 Jul 2020 00:03:12 +0000
Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers NeckoTargetChannelEvent uses a protected member function, which couldn't compile with instantiation of HttpChannelChild https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/netwerk/ipc/ChannelEventQueue.h#64 Depends on D81272 Differential Revision: https://phabricator.services.mozilla.com/D81273
65e6c73de900d697b3720c5d11408636d5f62635: Bug 1649807 - Ignore Pragma: no-cache if Cache-Control is specified. r=mayhemer,necko-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 Jul 2020 14:04:31 +0000 - rev 538850
Push 120768 by ealvarez@mozilla.com at Sun, 05 Jul 2020 18:26:20 +0000
Bug 1649807 - Ignore Pragma: no-cache if Cache-Control is specified. r=mayhemer,necko-reviewers See bug 1599160 comment 43 for an example in the wild (though it has been fixed since) which prevents us from caching resources unnecessarily. Differential Revision: https://phabricator.services.mozilla.com/D81879
24628212bbf298b14c803e4c9e22f1bf5b89aca9: Bug 1607426 - Add a mutex to protect nsPACMan::mLoader r=mayhemer
Kershaw Chang <kershaw@mozilla.com> - Fri, 03 Jul 2020 12:31:31 +0000 - rev 538740
Push 120703 by kjang@mozilla.com at Fri, 03 Jul 2020 13:40:18 +0000
Bug 1607426 - Add a mutex to protect nsPACMan::mLoader r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D73286
8881ac68a975fbd1560aeca746f60b7e6503157d: Bug 1648035 - remove the false alarm assertion given mChild could be destroied by ActorDestory, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Thu, 02 Jul 2020 01:07:34 +0000 - rev 538363
Push 120532 by juhsu@mozilla.com at Thu, 02 Jul 2020 01:08:09 +0000
Bug 1648035 - remove the false alarm assertion given mChild could be destroied by ActorDestory, r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D81625
68dc9e49b744691851ca852f6b5d61a7ec44908b: Bug 1618271 - Fail DNS requests when proxy is in use r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 01 Jul 2020 16:49:19 +0000 - rev 538288
Push 120495 by valentin.gosu@gmail.com at Wed, 01 Jul 2020 16:50:05 +0000
Bug 1618271 - Fail DNS requests when proxy is in use r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80889
f900ff75a000e83d228da49da2dbdbd0de6fc192: Bug 1618271 - Move network.proxy.type to StaticPrefList.yaml r=mayhemer,necko-reviewers
Valentin Gosu <valentin.gosu@gmail.com> - Wed, 01 Jul 2020 16:49:05 +0000 - rev 538287
Push 120495 by valentin.gosu@gmail.com at Wed, 01 Jul 2020 16:50:05 +0000
Bug 1618271 - Move network.proxy.type to StaticPrefList.yaml r=mayhemer,necko-reviewers Differential Revision: https://phabricator.services.mozilla.com/D80888
ccfa8f4641dbb93b9878190985d632d5df96b53a: Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 30 Jun 2020 18:34:51 +0000 - rev 538155
Push 120441 by amarchesini@mozilla.com at Wed, 01 Jul 2020 05:20:00 +0000
Bug 1649404 - Enforce the reading completeness in any PermissionManager methods, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81681
3a12b1eccd8ff22d687b35bc7ef0af1e4b9747b0: Bug 1578230 - do not process transactions blocked on tunnel before a final response, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 18:37:28 +0000 - rev 538088
Push 120397 by juhsu@mozilla.com at Tue, 30 Jun 2020 19:46:57 +0000
Bug 1578230 - do not process transactions blocked on tunnel before a final response, r=mayhemer,necko-reviewers Depends on D80261 Differential Revision: https://phabricator.services.mozilla.com/D81620
352726f9bd296da32170dcd3c49c660bdff3e390: Bug 1578230 - skip 1xx pre-response for H2 CONNECT proxy, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Mon, 29 Jun 2020 23:33:44 +0000 - rev 538087
Push 120397 by juhsu@mozilla.com at Tue, 30 Jun 2020 19:46:57 +0000
Bug 1578230 - skip 1xx pre-response for H2 CONNECT proxy, r=mayhemer,necko-reviewers We already able to allow more headers after 1xx for H2. https://searchfox.org/mozilla-central/rev/5e6c7717255ca9638b2856c2b2058919aec1d21d/netwerk/protocol/http/Http2Session.cpp#1547-1550 What we need to do is a special handle in H2 Tunneling: Create the transport shims and decide if we need secondary TLS when we have a final response. Differential Revision: https://phabricator.services.mozilla.com/D80261
cc60e258290ea538e6f63b60d1c3080917d0e5a9: Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:35:22 +0000 - rev 538061
Push 120380 by juhsu@mozilla.com at Tue, 30 Jun 2020 17:19:39 +0000
Bug 1646592 - P4 Remove the depedency between OnStartRequestSent and AttachStreamFilter, r=mayhemer,necko-reviewers We're shorter the name! Differential Revision: https://phabricator.services.mozilla.com/D81275
3a514b227127c94f54f690ba3ad179eb4eb96bf1: Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:35:12 +0000 - rev 538060
Push 120380 by juhsu@mozilla.com at Tue, 30 Jun 2020 17:19:39 +0000
Bug 1646592 - P3 Sending endpoint of stream filter via PHttpBackgroundChannel, r=mayhemer,necko-reviewers Endpoint would be passed by a series of std::move via nsHttpChannel -> HttpChannelParent -> HttpBackgroundChannelParent ---> HttpBackgroundChannelChild -> HttpChannelChild | | Resolve promise after successfully send IPC<-/ Differential Revision: https://phabricator.services.mozilla.com/D81274
de9ba1eaded125fa3c3c1ea50154dbe59ef608db: Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:54 +0000 - rev 538059
Push 120380 by juhsu@mozilla.com at Tue, 30 Jun 2020 17:19:39 +0000
Bug 1646592 - P2 remove NeckoTargetChannelEvent which could not be specialized for HttpChannelChild, r=mayhemer,necko-reviewers NeckoTargetChannelEvent uses a protected member function, which couldn't compile with instantiation of HttpChannelChild https://searchfox.org/mozilla-central/rev/cfaa250d14e344834932de4c2eed0061701654da/netwerk/ipc/ChannelEventQueue.h#64 Differential Revision: https://phabricator.services.mozilla.com/D81273
ce326495d23b554b1c28a4ddc3bd2a25b717df95: Bug 1648898 - Fix data race on STS loop start. r=mayhemer
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 30 Jun 2020 11:06:31 +0000 - rev 537981
Push 120333 by jyavenard@mozilla.com at Tue, 30 Jun 2020 11:19:17 +0000
Bug 1648898 - Fix data race on STS loop start. r=mayhemer The STS dispatched the first event before setting mThread member. It was possible that the STS::Run() task got started before mThread was set and causing one of the nsISerialEventTarget methods to read mThread/mInitialised/mShuttingDown value as null or zero and they would have returned an error. We rewrite and simplify the access to mThread such that it's a lockless operation. ApplyPortRemapPreference assert that it's running on the taskqueue; however if called before initialization, it would have been run on whatever thread called ApplyPortRemap. Differential Revision: https://phabricator.services.mozilla.com/D81334
b3c38ba32f0b6d62ac3164d6e00c5576ffd62d75: Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Tue, 30 Jun 2020 09:44:00 +0000 - rev 537964
Push 120323 by amarchesini@mozilla.com at Tue, 30 Jun 2020 09:49:51 +0000
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81292
d529ccb6638b92890550fc5c8a13092b6b72e450: Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:39 +0000 - rev 537898
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P13 Avoid ODA message being processed when the channel is already failed, r=mayhemer,kershaw,necko-reviewers One line fix with a bunch of explanation. When we perform networking on the socket process, OnDataAvailable could be sent directly from socket process to child process. Therefore, it could be racy with OnStartRequest which is from parent process to child process by nature. This patch is to resolve the failure (cancel) by parent process. For example, https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/nsHttpChannel.cpp#2713 Bug 1641496 introduce a status check to avoid ODA message being process [2] https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpBackgroundChannelChild.cpp#163-171 It prevents putting ODA to the channel event queue in child process. However, this is based on that `OnStartRequest` already finished excution, which is usually true if OnStartRequest is sent via PHttpChannel. https://searchfox.org/mozilla-central/rev/027893497316897b8f292bde48dbb6da2391a331/netwerk/protocol/http/HttpChannelChild.cpp#417-422 ChannelEventQueue::RunOrEnque simply runs the OnStartRequest given there on the same thread and the queue is empty, since no blocking events from different thread are before OnStartRequest. Now we are moving the next chapter. OnStartRequest is queued given we want to switch thread. The failure status, which is initiated in parent process, is set in HttpChannelChild::OnStartRequest which could be later than the status check [2] Therefore, we need another check to prevent ODA, which is already in the event queue, being processed. We intentionally keep [2] for performance. Differential Revision: https://phabricator.services.mozilla.com/D79771
cad764eb15a4a42cfdb2468ce762029130c0b9fc: Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:32 +0000 - rev 537897
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P12 top-level IPC stream filter should happen before OnStartRequest, r=mayhemer,necko-reviewers The WebRequest will suspend the channel in nsHttpChannel::PrepareToConnect(), apply the stream filter, send the main thread IPC and resume. That is, PHttpChannel::AttachStreamFilter should be handled in Child before OnStartRequest goes to listener. Differential Revision: https://phabricator.services.mozilla.com/D79770
f75cc7d5f40e5973936997f7a0f66707860c9be0: Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:24 +0000 - rev 537896
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P11 Move classification IPC methods back to PHttpChannel. r=mayhemer,necko-reviewers Bug 1015466 move them from PContent to Pbg since it believes those events are fine to received before OnStopRequest. Bug 1588241 move it back to PContent since those events are before OnStartRequest. Now we're moving OnStartRequest to pBg, so here's another ping-pong time :) Differential Revision: https://phabricator.services.mozilla.com/D79587
2289e685031e878fee593b86cea90025b43d1fe9: Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:34:06 +0000 - rev 537895
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P10 wait PHttpChannel::OnStartRequestSent for permission/cookie update from parent, r=mayhemer,necko-reviewers Depends on D77751 Differential Revision: https://phabricator.services.mozilla.com/D77752
673030046319948020e1e2100e2db3cf753dbaba: Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:54 +0000 - rev 537894
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P9 send OnAfterLastPart via pBg IPC to avoid race between OS*R, r=mayhemer,necko-reviewers Depends on D77750 Differential Revision: https://phabricator.services.mozilla.com/D77751
045271cd2ca65fd83484574c24cb508e3aaa6579: Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:41 +0000 - rev 537893
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P8 suspend event queue in HttpChannelChild which needs listener for redirection, r=mayhemer,necko-reviewers Now OnStartRequest is passed to child process via pBg. Every IPC which is passed thru main thread could become a race. For the redirection flow in child process is: (1) HTC::ConnectParent(): Let parent know this is the targeted child, so OnStartRequest could start here. (2) HTC::CompleteRedirectSetup(listener): Now we're finish the setup, including listener. From now on, we're ready to accept OnStartRequest Hence, between (1) and (2), and need to suspend the eventQ to prevent OnStartRequest pump without listener. On the other hand, if the redirection is vetoed by parent, (2) will not be sent. RecvDeleteSelf instead. Resuming the eventQ to prevent leakage. Depends on D77749 Differential Revision: https://phabricator.services.mozilla.com/D77750
4214217c588cd8f5a21acf197698905528f1ea17: Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:19 +0000 - rev 537890
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P5 allow OnProgress/OnStatus going thru pBg IPC, r=mayhemer,necko-reviewers Depends on D76971 Differential Revision: https://phabricator.services.mozilla.com/D76972
e6c12eec1cef32987b7a0b79ccf4420ee097b868: Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:33:01 +0000 - rev 537889
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P4 Remove On[Start|Stop]Request/OnTransportAndData in PHttpChannel, r=mayhemer,nika,necko-reviewers We move OnStartRequest from PHttpChannel to PHttpBackgroundChannel, thus adjusting message-metadata.ini Depends on D76970 Differential Revision: https://phabricator.services.mozilla.com/D76971
d59b42f58f861e049c1270035ea7568acc0605b9: Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:53 +0000 - rev 537888
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P3 send OS*R and ODA via pHttpChannel for multipart channel, r=mayhemer,necko-reviewers Depends on D76969 Differential Revision: https://phabricator.services.mozilla.com/D76970
cbcd3ee87d283caccf60c8b9dc40dabb819e5942: Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:38 +0000 - rev 537887
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P2 remove OnStartRequestSent since OnStartRequest is passed thru pBg, r=mayhemer,necko-reviewers Depends on D73529 Differential Revision: https://phabricator.services.mozilla.com/D76969
b8f55064bfeb151f77c084d04f3def3bcd96679a: Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer
Junior Hsu <juhsu@mozilla.com> - Tue, 30 Jun 2020 00:32:25 +0000 - rev 537886
Push 120281 by juhsu@mozilla.com at Tue, 30 Jun 2020 00:39:52 +0000
Bug 1633935 - P1 allow OnStartRequest go thru pBg IPC, r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D73529
f16199c7d45e574841e27330397e0a4c67456d61: Bug 1648898 - Fix data race on STS loop start. r=mayhemer
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 29 Jun 2020 22:59:20 +0000 - rev 537880
Push 120275 by jyavenard@mozilla.com at Mon, 29 Jun 2020 23:00:30 +0000
Bug 1648898 - Fix data race on STS loop start. r=mayhemer The STS dispatched the first event before setting mThread member. It was possible that the STS::Run() task got started before mThread was set and causing one of the nsISerialEventTarget methods to read mThread/mInitialised/mShuttingDown value as null or zero and they would have returned an error. We rewrite and simplify the access to mThread such that it's a lockless operation. ApplyPortRemapPreference assert that it's running on the taskqueue; however if called before initialization, it would have been run on whatever thread called ApplyPortRemap. Differential Revision: https://phabricator.services.mozilla.com/D81334
34d09061d8272ede6d1bf4ce0cb91b223eabd5d2: Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 29 Jun 2020 14:37:19 +0000 - rev 537803
Push 120221 by amarchesini@mozilla.com at Mon, 29 Jun 2020 14:38:51 +0000
Bug 1648134 - Permission Manager does not save changes when scope is changed., r=mayhemer Differential Revision: https://phabricator.services.mozilla.com/D81292