searching for reviewer(mattwoodrow)
fb95cf4f316a571a38efd4ff0d4aedba5c9f0089: Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
Jeff Gilbert <jgilbert@mozilla.com> - Sun, 27 Sep 2020 22:18:23 +0000 - rev 550644
Push 127404 by jgilbert@mozilla.com at Mon, 28 Sep 2020 20:29:31 +0000
Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow GfxInfo generally wants to be main-thread, so WebGL (especially out-of-process) runs into problems sometimes. Also rename to UNUSED_FEATURE_WEBGL_MSAA, pending removal. Differential Revision: https://phabricator.services.mozilla.com/D91208
45c484bdca6daa812fc49fc26a242e3b598a2919: Bug 1667656 - Replace AppendToString of nsIntRegion with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:14:07 +0000 - rev 550532
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of nsIntRegion with ostream usage. r=mattwoodrow As with nsRegion, nsIntRegion has an implicit constructor for IntRect and so some dangling Stringify(IntRect) sites also get converted here. Depends on D91525 Differential Revision: https://phabricator.services.mozilla.com/D91526
1f509962b47d7d7267620a12205c08213accfe80: Bug 1667656 - Replace AppendToString of nsRegion with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:14:00 +0000 - rev 550531
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of nsRegion with ostream usage. r=mattwoodrow Apparently a bunch of Stringify(nsRect) sites were getting converted to Stringify(nsRegion(nsRect)) due to the the nsRegion implicit constructor, so this updates those too. Depends on D91524 Differential Revision: https://phabricator.services.mozilla.com/D91525
dbdb25f76b6659b2e456319ab62eebd8619fa9dd: Bug 1667656 - Replace AppendToString of nsSize with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:13:52 +0000 - rev 550530
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of nsSize with ostream usage. r=mattwoodrow Depends on D91523 Differential Revision: https://phabricator.services.mozilla.com/D91524
35229b94dda0ed2ecdc6d17f4575a0cc5a7dd866: Bug 1667656 - Remove unused IntRectAbsoluteTyped AppendToString function. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:13:44 +0000 - rev 550529
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Remove unused IntRectAbsoluteTyped AppendToString function. r=mattwoodrow Depends on D91522 Differential Revision: https://phabricator.services.mozilla.com/D91523
82e59358644eec1efbeb479b00e28520c66fb8f6: Bug 1667656 - Replace AppendToString of RectAbsoluteTyped with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:12:15 +0000 - rev 550528
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of RectAbsoluteTyped with ostream usage. r=mattwoodrow Depends on D91521 Differential Revision: https://phabricator.services.mozilla.com/D91522
f96d6169dad731822325e5f96ecb7468e8e9b760: Bug 1667656 - Replace AppendToString of IntRectTyped with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:12:03 +0000 - rev 550527
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of IntRectTyped with ostream usage. r=mattwoodrow Depends on D91520 Differential Revision: https://phabricator.services.mozilla.com/D91521
102d19749009f839781e867943991de802479c63: Bug 1667656 - Replace AppendToString of RectTyped with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 01:11:55 +0000 - rev 550526
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of RectTyped with ostream usage. r=mattwoodrow Depends on D91519 Differential Revision: https://phabricator.services.mozilla.com/D91520
f90514d94891ebe634b4dc8893e37e41e59dc42b: Bug 1667656 - Replace AppendToString of IntPointTyped with ostream usage. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 00:44:02 +0000 - rev 550525
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Replace AppendToString of IntPointTyped with ostream usage. r=mattwoodrow Depends on D91518 Differential Revision: https://phabricator.services.mozilla.com/D91519
b1785ca5c008e6cf524ffa1ffa8d3f5e5351ef02: Bug 1667656 - Remove unused Point3DTyped AppendToString function. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 00:37:25 +0000 - rev 550524
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Remove unused Point3DTyped AppendToString function. r=mattwoodrow Depends on D91517 Differential Revision: https://phabricator.services.mozilla.com/D91518
67ac8857fac01cc71040fff423bc7c92105728cc: Bug 1667656 - Use ostream operator instead of AppendToString for PointTyped. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 28 Sep 2020 00:36:32 +0000 - rev 550523
Push 127336 by kgupta@mozilla.com at Mon, 28 Sep 2020 02:44:49 +0000
Bug 1667656 - Use ostream operator instead of AppendToString for PointTyped. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D91517
2065d62cfbb5fae2e783033ca959984c22549f4c: Bug 1667176 - Use ostream operator instead of AppendToString for nsRectAbsolute. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:25 +0000 - rev 550336
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Use ostream operator instead of AppendToString for nsRectAbsolute. r=mattwoodrow Depends on D91340 Differential Revision: https://phabricator.services.mozilla.com/D91341
24f512e008763e63a37042112b5b9fdb52479504: Bug 1667176 - Use ostream operator instead of AppendToString for nsRect. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:25 +0000 - rev 550335
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Use ostream operator instead of AppendToString for nsRect. r=mattwoodrow Depends on D91339 Differential Revision: https://phabricator.services.mozilla.com/D91340
30d353e489af41d149f152951a22b4d9502dc9fb: Bug 1667176 - Use ostream operator instead of AppendToString for nsPoint. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:24 +0000 - rev 550334
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Use ostream operator instead of AppendToString for nsPoint. r=mattwoodrow Depends on D91338 Differential Revision: https://phabricator.services.mozilla.com/D91339
8a101a1e048b7174d6ff59b3ff32cb5affb3753f: Bug 1667176 - Replace AppendToString for DeviceColor with ostream operator. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:24 +0000 - rev 550333
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Replace AppendToString for DeviceColor with ostream operator. r=mattwoodrow Depends on D91337 Differential Revision: https://phabricator.services.mozilla.com/D91338
8689146f4d0464dc64a21eefe2fafe3fcaab44c0: Bug 1667176 - Remove unused sRGBColor AppendToString function. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:24 +0000 - rev 550332
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Remove unused sRGBColor AppendToString function. r=mattwoodrow Depends on D91336 Differential Revision: https://phabricator.services.mozilla.com/D91337
8154aba8823727fae78701b683fe14aae4c39413: Bug 1667176 - Remove the ViewID AppendToString function, and convert call sites to stream writes. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:24 +0000 - rev 550331
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Remove the ViewID AppendToString function, and convert call sites to stream writes. r=mattwoodrow Depends on D91335 Differential Revision: https://phabricator.services.mozilla.com/D91336
df3d474c3a911682bd8c868cab4268b735f5712e: Bug 1667176 - Remove the void* AppendToString function, and fix the typo that exposed. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:23 +0000 - rev 550330
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Remove the void* AppendToString function, and fix the typo that exposed. r=mattwoodrow Depends on D91334 Differential Revision: https://phabricator.services.mozilla.com/D91335
bad3de147b6b688b2822eda85621cc7c700e7e57: Bug 1667176 - Collapse ScrollableLayerGuid stringification functions. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:23 +0000 - rev 550329
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Collapse ScrollableLayerGuid stringification functions. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D91334
a5cf7b49d17f3ac97fce88e32918e55997c82b44: Bug 1667176 - Move ScrollableLayerGuid functions into a .cpp file. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:23 +0000 - rev 550328
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Move ScrollableLayerGuid functions into a .cpp file. r=mattwoodrow Depends on D91332 Differential Revision: https://phabricator.services.mozilla.com/D91333
748a1bdc27c12dbb0f3ab7e1214125ccd8c84a6e: Bug 1667176 - Miscellaneous unified build fixes. r=mattwoodrow
Kartikaya Gupta <kgupta@mozilla.com> - Fri, 25 Sep 2020 08:57:23 +0000 - rev 550327
Push 127248 by kgupta@mozilla.com at Fri, 25 Sep 2020 11:16:16 +0000
Bug 1667176 - Miscellaneous unified build fixes. r=mattwoodrow Upcoming patches shift around which files get unified and expose these build failures. Differential Revision: https://phabricator.services.mozilla.com/D91332
7ed2e1d98e9c2cf8c185d410f8b1c0edd0419953: Bug 1619370 - Return the rect from BrowserChild::GetVisibleRect() in app units r=mattwoodrow
Miko Mynttinen <mikokm@gmail.com> - Fri, 25 Sep 2020 09:38:06 +0000 - rev 550312
Push 127239 by mikokm@gmail.com at Fri, 25 Sep 2020 09:41:28 +0000
Bug 1619370 - Return the rect from BrowserChild::GetVisibleRect() in app units r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D91272
3dcacf3ae5a17f941a42443c80553498e969821d: Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
Jeff Gilbert <jgilbert@mozilla.com> - Fri, 25 Sep 2020 05:43:24 +0000 - rev 550289
Push 127222 by jgilbert@mozilla.com at Fri, 25 Sep 2020 05:46:18 +0000
Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow GfxInfo generally wants to be main-thread, so WebGL (especially out-of-process) runs into problems sometimes. Also remove obsolete FEATURE_WEBGL_MSAA. Differential Revision: https://phabricator.services.mozilla.com/D91208
3ea0c63fe8b82178f910a9a4da1f484e13c7a971: Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 24 Sep 2020 23:46:12 +0000 - rev 550272
Push 127208 by jgilbert@mozilla.com at Fri, 25 Sep 2020 00:13:40 +0000
Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow GfxInfo generally wants to be main-thread, so WebGL (especially out-of-process) runs into problems sometimes. Also remove obsolete FEATURE_WEBGL_MSAA. Differential Revision: https://phabricator.services.mozilla.com/D91208
1e467d7ca5ffc9a821f378e785124723944d2a32: Bug 1666698 - Only synchronise textures after a copy serially. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 23 Sep 2020 21:34:47 +0000 - rev 550102
Push 127090 by jyavenard@mozilla.com at Thu, 24 Sep 2020 02:18:03 +0000
Bug 1666698 - Only synchronise textures after a copy serially. r=mattwoodrow Attempt to lock textures from the same D3D11 devices on multiple threads at once can lead to deadlocks as observed with AMD cards. Differential Revision: https://phabricator.services.mozilla.com/D91098
1bfa8388071262f29f5ac97d9748ad20f1d1cde1: Bug 1662839 - Set author style disabled state correctly on newly created iframes. r=mattwoodrow
Cameron McCormack <cam@mcc.id.au> - Thu, 24 Sep 2020 01:24:57 +0000 - rev 550100
Push 127088 by cmccormack@mozilla.com at Thu, 24 Sep 2020 01:39:05 +0000
Bug 1662839 - Set author style disabled state correctly on newly created iframes. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90953
ec8c384530a1f2d4e73981a28882a23fdae22f7c: Bug 1646573: Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow
Kris Maglione <maglione.k@gmail.com> - Wed, 23 Sep 2020 18:26:25 +0000 - rev 550060
Push 127056 by maglione.k@gmail.com at Wed, 23 Sep 2020 18:29:01 +0000
Bug 1646573: Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90341
cd7ec0e4fea49d2f59d759a10ed0d83efa412ade: Bug 1646573: Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow
Kris Maglione <maglione.k@gmail.com> - Tue, 22 Sep 2020 17:41:39 +0000 - rev 549683
Push 126936 by maglione.k@gmail.com at Tue, 22 Sep 2020 17:45:38 +0000
Bug 1646573: Part 3 - Fix OriginalFrameSrcLoad with DocumentChannel. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90341
1af7632512d65006b91deaecb1626736fa845963: Bug 1580117 - Remove invalid assertion from RecvGetSnapshot. r=mattwoodrow
J. Ryan Stinnett <jryans@gmail.com> - Thu, 17 Sep 2020 19:59:15 +0000 - rev 549423
Push 126771 by jryans@gmail.com at Mon, 21 Sep 2020 09:53:30 +0000
Bug 1580117 - Remove invalid assertion from RecvGetSnapshot. r=mattwoodrow Since the compositor can be paused at any time (due to window state changes), it's possible (and tests confirm it can happen) that `RecvGetSnapshot` is called while the compositor is paused. This change removes the assertion and instead skips the snapshot work in this case. Depends on D85955 Differential Revision: https://phabricator.services.mozilla.com/D90587
8e12f264d17f9fb5523953d450e36d1925567b69: Bug 1580117 - Skip preloaded browsers in minimized windows. r=mattwoodrow,Gijs
J. Ryan Stinnett <jryans@gmail.com> - Thu, 17 Sep 2020 16:57:35 +0000 - rev 549422
Push 126771 by jryans@gmail.com at Mon, 21 Sep 2020 09:53:30 +0000
Bug 1580117 - Skip preloaded browsers in minimized windows. r=mattwoodrow,Gijs If the browser window is minimized, it's unlikely that a preloaded browser will be useful in the near future. This change skips creating one in such a case. This avoids an issue in the graphics layer where about:newtab content marks itself as `renderLayers = true`, and will try to composite content in windows which are not compositing (because they are hidden). As an additional level of safety, we also check the preloaded browser's owner window's minimized state just before setting `renderLayers`, in case it may have changed after the preloaded browser was created. Differential Revision: https://phabricator.services.mozilla.com/D85955
e4e2a6da094d596666e6422ba98a50f7813713f3: Bug 1664049 - Allow capturing recorded frames from NativeLayerSnapshotter. r=mattwoodrow
Markus Stange <mstange.moz@gmail.com> - Fri, 18 Sep 2020 01:26:32 +0000 - rev 549356
Push 126715 by mstange@themasta.com at Fri, 18 Sep 2020 19:37:46 +0000
Bug 1664049 - Allow capturing recorded frames from NativeLayerSnapshotter. r=mattwoodrow This makes the recording API work in the macOS + WR compositor configuration. Differential Revision: https://phabricator.services.mozilla.com/D89868
3695534b2938dd87887831a96d2fc9374b3174f2: Bug 1653060 - P5. Ensure no task gets dispatched after shutdown. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 17 Sep 2020 06:35:15 +0000 - rev 549292
Push 126677 by jyavenard@mozilla.com at Fri, 18 Sep 2020 12:41:38 +0000
Bug 1653060 - P5. Ensure no task gets dispatched after shutdown. r=mattwoodrow And fix thread-safety access to sRemoteDecoderManagerChildThread static while at it. Differential Revision: https://phabricator.services.mozilla.com/D90506
fe83737b9acf113c2de737c098c2f9c65e1e441c: Bug 1653060 - P4. Wait until all MediaRemoteDecoderManagerParent have closed before killing process. r=mattwoodrow.
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 18 Sep 2020 11:07:13 +0000 - rev 549291
Push 126677 by jyavenard@mozilla.com at Fri, 18 Sep 2020 12:41:38 +0000
Bug 1653060 - P4. Wait until all MediaRemoteDecoderManagerParent have closed before killing process. r=mattwoodrow. We unfortunately can't use the AsyncShutdownService in either the GPU or RDD process. So we add a little utility class AsyncBlockers that will resolve its promise once all services have deregistered from it. We use it to temporily suspend the RDDParent or GPUParent from killing the process, up to 10s. This allows for cleaner shutdown as the parent process doesn't guarantee the order in which processes are killed (even though it should). Differential Revision: https://phabricator.services.mozilla.com/D90487
22b8a193cae12f8b5820b866e961d73026962328: Bug 1653060 - P3. Use nsCOMPtr. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 18 Sep 2020 11:07:15 +0000 - rev 549290
Push 126677 by jyavenard@mozilla.com at Fri, 18 Sep 2020 12:41:38 +0000
Bug 1653060 - P3. Use nsCOMPtr. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90486
d143ac59991ff804d792008b64383c6997078c94: Bug 1653060 - P4. Wait until all MediaRemoteDecoderManagerParent have closed before killing process. r=mattwoodrow.
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 18 Sep 2020 02:51:50 +0000 - rev 549265
Push 126660 by jyavenard@mozilla.com at Fri, 18 Sep 2020 09:49:31 +0000
Bug 1653060 - P4. Wait until all MediaRemoteDecoderManagerParent have closed before killing process. r=mattwoodrow. We unfortunately can't use the AsyncShutdownService in either the GPU or RDD process. So we add a little utility class AsyncBlockers that will resolve its promise once all services have deregistered from it. We use it to temporily suspend the RDDParent or GPUParent from killing the process, up to 10s. This allows for cleaner shutdown as the parent process doesn't guarantee the order in which processes are killed (even though it should). Differential Revision: https://phabricator.services.mozilla.com/D90487
6943102ffe2ab0788dd769a62cbc8ec9d83e3500: Bug 1653060 - P3. Use nsCOMPtr. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 17 Sep 2020 06:57:58 +0000 - rev 549264
Push 126660 by jyavenard@mozilla.com at Fri, 18 Sep 2020 09:49:31 +0000
Bug 1653060 - P3. Use nsCOMPtr. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90486
a6b09fc8e9f803277a0e97e6f7aadea33f8e836b: Bug 1663227 - P3. Have RemoteImageHandler handles image's lifecycle even in the parent. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 17 Sep 2020 06:30:08 +0000 - rev 549135
Push 126574 by jyavenard@mozilla.com at Thu, 17 Sep 2020 08:49:01 +0000
Bug 1663227 - P3. Have RemoteImageHandler handles image's lifecycle even in the parent. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90207
29db5f8655d0d0da728c086b3f5ae84e53400896: Bug 1663227 - P2. Wrap image in a RemoteImageHolder and use move semantics. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 17 Sep 2020 06:21:44 +0000 - rev 549134
Push 126574 by jyavenard@mozilla.com at Thu, 17 Sep 2020 08:49:01 +0000
Bug 1663227 - P2. Wrap image in a RemoteImageHolder and use move semantics. r=mattwoodrow We add a RemoteImageHolder container class that will take ownership of the image transferred across IPC. Should the image not be received for whatever the reason by the RemoteDecoderChild (either because the decode promise got disconnected or because the handler exited early), the parent will be notified to recycle the image. IPDL binding code still uses a lot of copies across which we can't all remove. As such, the object ArrayOfRemoteVideoData is made to be refcounted so that we move a pointer instead, bypassing const issues. Differential Revision: https://phabricator.services.mozilla.com/D90204
297fb1f347b0726104dfdf6d53e242c835ec5985: Bug 1661316 - Use `visibleRect` for partial pre-render check instead of `dirtyRect`. r=mattwoodrow
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Thu, 17 Sep 2020 00:52:16 +0000 - rev 549070
Push 126563 by hikezoe.birchill@mozilla.com at Thu, 17 Sep 2020 03:29:10 +0000
Bug 1661316 - Use `visibleRect` for partial pre-render check instead of `dirtyRect`. r=mattwoodrow With RDL the dirty rect might be empty if the target transformed frame is marked as `mForceDescendIntoIfVisible`. Differential Revision: https://phabricator.services.mozilla.com/D90497
2afcb3e0312c0de161bd770d6aa96c05037abfdf: Bug 1657036, make docshell active temporarily while taking screenshot if it isn't already, r=mattwoodrow
Neil Deakin <neil@mozilla.com> - Wed, 16 Sep 2020 02:14:41 +0000 - rev 548922
Push 126472 by neil@mozilla.com at Wed, 16 Sep 2020 14:01:16 +0000
Bug 1657036, make docshell active temporarily while taking screenshot if it isn't already, r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90339
ce029dee9e29e967502d22a0439ba206de3ba8c7: Bug 1663227 - P1. Always process decoded video promise to avoid leaks. r=mattwoodrow
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 15 Sep 2020 21:02:21 +0000 - rev 548895
Push 126454 by jyavenard@mozilla.com at Wed, 16 Sep 2020 11:04:16 +0000
Bug 1663227 - P1. Always process decoded video promise to avoid leaks. r=mattwoodrow This is a quick & dirty solution designed for easy uplift to beta. Differential Revision: https://phabricator.services.mozilla.com/D90203
36693e01331a1c0210598c2378734924cea81517: Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow
Markus Stange <mstange.moz@gmail.com> - Tue, 15 Sep 2020 20:47:19 +0000 - rev 548836
Push 126408 by mstange@themasta.com at Tue, 15 Sep 2020 21:01:55 +0000
Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow This requires passing down the window size down in a different way, because the NativeLayerRootSnapshotter does not know the window size otherwise. At the same time, this patch also removes WindowNLRS and makes the NativeLayerRoot implement the profiler_screenshots::Window interface directly. Differential Revision: https://phabricator.services.mozilla.com/D89864
11ba748e25bfa1e6d7218c2ef0d3572366c65be1: Bug 1664135 - Null-check the return value of CreateSnapshotter(). r=mattwoodrow
Markus Stange <mstange.moz@gmail.com> - Tue, 15 Sep 2020 14:20:14 +0000 - rev 548835
Push 126408 by mstange@themasta.com at Tue, 15 Sep 2020 21:01:55 +0000
Bug 1664135 - Null-check the return value of CreateSnapshotter(). r=mattwoodrow This can return null when the creation of the GL context for the snapshotter fails, for example. Differential Revision: https://phabricator.services.mozilla.com/D89863
ea8cc0187a75ed67eb1f7bc0d1fb8e8f7d3ad748: Bug 1664735 - support vectorized texelFetchPtr. r=mattwoodrow
Lee Salzman <lsalzman@mozilla.com> - Tue, 15 Sep 2020 19:07:15 +0000 - rev 548820
Push 126399 by lsalzman@mozilla.com at Tue, 15 Sep 2020 19:24:37 +0000
Bug 1664735 - support vectorized texelFetchPtr. r=mattwoodrow Gradient shaders end up calling fetch_from_gpu_cache_2 with a vectorized address. This currently disables SWGL texelFetchPtr optimization for repeated uses of texelFetchOffsets. In principle this optimization can still work in vector mode. We just need to use an I32 instead of a direct pointer into the buffer in this case. I've added a texelFetchUnchecked wrapper to automagically disambiguate between scalar and vector cases. Differential Revision: https://phabricator.services.mozilla.com/D90059
acc2af307fe81ac0c1e12a1a3d7e3137b77af3c6: Bug 1664735 - micro-optimizations for WR sample_gradient. r=mattwoodrow
Lee Salzman <lsalzman@mozilla.com> - Tue, 15 Sep 2020 19:07:03 +0000 - rev 548819
Push 126399 by lsalzman@mozilla.com at Tue, 15 Sep 2020 19:24:37 +0000
Bug 1664735 - micro-optimizations for WR sample_gradient. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90054
5219686dc46502c8566905a6206c88b245cd69cd: Bug 1664735 - support vectorized texelFetchPtr. r=mattwoodrow
Lee Salzman <lsalzman@mozilla.com> - Tue, 15 Sep 2020 07:44:47 +0000 - rev 548668
Push 126328 by lsalzman@mozilla.com at Tue, 15 Sep 2020 07:49:55 +0000
Bug 1664735 - support vectorized texelFetchPtr. r=mattwoodrow Gradient shaders end up calling fetch_from_gpu_cache_2 with a vectorized address. This currently disables SWGL texelFetchPtr optimization for repeated uses of texelFetchOffsets. In principle this optimization can still work in vector mode. We just need to use an I32 instead of a direct pointer into the buffer in this case. I've added a texelFetchUnchecked wrapper to automagically disambiguate between scalar and vector cases. Differential Revision: https://phabricator.services.mozilla.com/D90059
b9ca78d0a835ee9432d00637a96b3067b5d799dd: Bug 1664735 - micro-optimizations for WR sample_gradient. r=mattwoodrow
Lee Salzman <lsalzman@mozilla.com> - Tue, 15 Sep 2020 07:44:36 +0000 - rev 548667
Push 126328 by lsalzman@mozilla.com at Tue, 15 Sep 2020 07:49:55 +0000
Bug 1664735 - micro-optimizations for WR sample_gradient. r=mattwoodrow Differential Revision: https://phabricator.services.mozilla.com/D90054
d8996fcd35686b2652b87ce5ee348b238c74a0fb: Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow
Markus Stange <mstange.moz@gmail.com> - Sun, 13 Sep 2020 21:41:24 +0000 - rev 548622
Push 126303 by mstange@themasta.com at Mon, 14 Sep 2020 22:01:25 +0000
Bug 1664047 - Only call UpdateSnapshot when ScreenshotGrabber calls GetWindowContents, which it only does if the profiler is running (and Screenshots are enabled). r=mattwoodrow This requires passing down the window size down in a different way, because the NativeLayerRootSnapshotter does not know the window size otherwise. At the same time, this patch also removes WindowNLRS and makes the NativeLayerRoot implement the profiler_screenshots::Window interface directly. Depends on D89863 Differential Revision: https://phabricator.services.mozilla.com/D89864
070815d3ff0275d795f1a2fa3b9ff738449fcb57: Bug 1664135 - Null-check the return value of CreateSnapshotter(). r=mattwoodrow
Markus Stange <mstange.moz@gmail.com> - Sun, 13 Sep 2020 21:34:50 +0000 - rev 548621
Push 126303 by mstange@themasta.com at Mon, 14 Sep 2020 22:01:25 +0000
Bug 1664135 - Null-check the return value of CreateSnapshotter(). r=mattwoodrow This can return null when the creation of the GL context for the snapshotter fails, for example. Differential Revision: https://phabricator.services.mozilla.com/D89863
ad6fce90a3b796b9b5eb716fbf81f9869ee6a863: Bug 1660565 - Disable WebRender when running under Rosetta - r=mattwoodrow
Haik Aftandilian <haftandilian@mozilla.com> - Sun, 13 Sep 2020 21:34:22 +0000 - rev 548599
Push 126286 by haftandilian@mozilla.com at Mon, 14 Sep 2020 18:42:31 +0000
Bug 1660565 - Disable WebRender when running under Rosetta - r=mattwoodrow Disable WebRender when running under Rosetta to workaround graphics-related crashes. Use the Apple-documented sysctl.proc_translated sysctl to detect when running under Rosetta using the same code in the Sandboxing module (Sandbox.mm.) Differential Revision: https://phabricator.services.mozilla.com/D89961