searching for reviewer(mats)
37180b0bf14ad69cb4e0d952f2c88b26a5e99175: Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 28 Sep 2022 02:56:41 +0000 - rev 636526
Push 170365 by ealvarez@mozilla.com at Wed, 28 Sep 2022 03:00:28 +0000
Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats It's unused on mozilla-central, and Thunderbird can just use the canvas frame as regular (X)HTML documents, so just use a canvas frame instead of an nsRootBoxFrame for XUL as well. nsRootBoxFrame was needed because of various XUL-specific things like tooltips and so on lived there. But with the move away from XUL, that functionality has been added to nsCanvasFrame already, behind a principal check instead. This also allows simplifying our background propagation setup, which was only half-working for XUL documents (this bug is a consequence of that). With this, most of the callers of nsCSSRendering::IsCanvasFrame can go. They're only two of the frames that would return true for that that actually paint backgrounds (nsCanvasFrame and nsRootBoxFrame), so the codepaths in display list building and painting can just check frame->IsCanvasFrame() instead. The remaining caller to that function is nsContainerFrame::SyncWindowProperties, and the change is also legit, in the sense that the only thing SyncWindowProperties() really cares about is propagating the max/min-width constraints from the root element's style to the view/widget, and the only frame that would return true from IsCanvasFrame and have a view is the viewport frame which is the root of the frame tree. Differential Revision: https://phabricator.services.mozilla.com/D90846
503c84054f683f305d4b02ffce4c9ea96ace860c: Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Sep 2022 08:18:58 +0000 - rev 636478
Push 170329 by ealvarez@mozilla.com at Tue, 27 Sep 2022 08:22:45 +0000
Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats It's unused on mozilla-central, and Thunderbird can just use the canvas frame as regular (X)HTML documents, so just use a canvas frame instead of an nsRootBoxFrame for XUL as well. nsRootBoxFrame was needed because of various XUL-specific things like tooltips and so on lived there. But with the move away from XUL, that functionality has been added to nsCanvasFrame already, behind a principal check instead. This also allows simplifying our background propagation setup, which was only half-working for XUL documents (this bug is a consequence of that). With this, most of the callers of nsCSSRendering::IsCanvasFrame can go. They're only two of the frames that would return true for that that actually paint backgrounds (nsCanvasFrame and nsRootBoxFrame), so the codepaths in display list building and painting can just check frame->IsCanvasFrame() instead. The remaining caller to that function is nsContainerFrame::SyncWindowProperties, and the change is also legit, in the sense that the only thing SyncWindowProperties() really cares about is propagating the max/min-width constraints from the root element's style to the view/widget, and the only frame that would return true from IsCanvasFrame and have a view is the viewport frame which is the root of the frame tree. Differential Revision: https://phabricator.services.mozilla.com/D90846
93310707d7c5a3b85040c950bc19e322541f6fbc: Bug 1733978 - Don't overwrite the ISize of child frames when optimizing nested grid layout r=mats
Sean Feng <sefeng@mozilla.com> - Wed, 10 Nov 2021 16:18:11 +0000 - rev 598908
Push 152931 by sefeng@mozilla.com at Wed, 10 Nov 2021 16:42:02 +0000
Bug 1733978 - Don't overwrite the ISize of child frames when optimizing nested grid layout r=mats The optimized code path for nested grid layout should only set the BSize of the child frames, since this is what the optimization is for. Without the change, the ISize is always going to be set to 0 for child frames which may break the layout. Sometimes, it is not an issue because the ISize of the grid area gets updated, so the cached measurement becomes invalid, and the ISize of the child frame gets set to the correct one again. Differential Revision: https://phabricator.services.mozilla.com/D130828
70cf18aea44de6c55589ffb83d19ed44fd88dfca: Bug 1738520 - Make #[css(field_bound)] and #[css(iterable)] work properly. r=mats
Mats Palmgren <mats@mozilla.com> - Thu, 04 Nov 2021 18:31:55 +0000 - rev 598314
Push 152618 by ealvarez@mozilla.com at Thu, 04 Nov 2021 18:40:51 +0000
Bug 1738520 - Make #[css(field_bound)] and #[css(iterable)] work properly. r=mats For now, use IntoIterator to figure the right type to add the bound. If we need this on types that are iterable but don't provide IntoIterator, we can add another attribute field or something. Differential Revision: https://phabricator.services.mozilla.com/D129962
ef84e5e1b1f900a74cd670e24b4d22bc0f1b7f73: Bug 1738663 - Add a pref to expose all shorthands in the computed style. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Nov 2021 14:22:51 +0000 - rev 597957
Push 152469 by ealvarez@mozilla.com at Tue, 02 Nov 2021 14:50:08 +0000
Bug 1738663 - Add a pref to expose all shorthands in the computed style. r=layout-reviewers,mats Make it always false for now, as we still need a solution for layout-dependent shorthands like margin, padding, border, etc. Differential Revision: https://phabricator.services.mozilla.com/D130039
d061755b95da763c7020c9a0426ff8cd352586d6: Bug 1738663 - Remove unneeded special-case for backdrop-filter in GenerateCSS2PropertiesWebIDL. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Nov 2021 14:22:08 +0000 - rev 597956
Push 152468 by ealvarez@mozilla.com at Tue, 02 Nov 2021 14:49:38 +0000
Bug 1738663 - Remove unneeded special-case for backdrop-filter in GenerateCSS2PropertiesWebIDL. r=layout-reviewers,mats This was needed when backdrop-filter-enabledness depended on WebRender-enabledness, but now it's available everywhere. Depends on D130027 Differential Revision: https://phabricator.services.mozilla.com/D130028
36619d5ef1e0b1b6de68ef1b4fd97b163775ccb6: Bug 1738663 - Remove some unneeded special-cases in GenerateComputedDOMStyleGenerated. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Nov 2021 14:21:38 +0000 - rev 597955
Push 152467 by ealvarez@mozilla.com at Tue, 02 Nov 2021 14:48:34 +0000
Bug 1738663 - Remove some unneeded special-cases in GenerateComputedDOMStyleGenerated. r=layout-reviewers,mats Depends on D130018 Differential Revision: https://phabricator.services.mozilla.com/D130026
95eb93857e87e1b8570e5edf3f33f3b1a1336d49: Bug 1738658 - Serialize text-decoration using Servo. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 02 Nov 2021 14:21:38 +0000 - rev 597954
Push 152467 by ealvarez@mozilla.com at Tue, 02 Nov 2021 14:48:34 +0000
Bug 1738658 - Serialize text-decoration using Servo. r=layout-reviewers,mats The code introduced in the preceding patch deals with currentColor correctly, so we should be able to do this now. This uncovers a bug in the existing serialization code when a non-auto text-decoration-thickness was used, caught by css/css-text-decor/parsing/text-decoration-computed.html. Differential Revision: https://phabricator.services.mozilla.com/D130018
d0de171b76ee8bcbdcfef289d25f6cc52d3ee9b7: Bug 1735445: more typo and clarity fixes in the CSS Gap Decorations draft. r=mats NPOTB DONTBUILD
Daniel Holbert <dholbert@cs.stanford.edu> - Thu, 21 Oct 2021 14:49:28 +0000 - rev 596620
Push 151932 by mpalmgren@mozilla.com at Thu, 21 Oct 2021 15:55:24 +0000
Bug 1735445: more typo and clarity fixes in the CSS Gap Decorations draft. r=mats NPOTB DONTBUILD (Note, this commit just updates the bikeshed file.) Differential Revision: https://phabricator.services.mozilla.com/D128981
64351ba1fe22681e33e1c0b6c583b40333f1f1a8: Bug 1735445: Fix some typos in the CSS Gap Decorations draft. rs=mats NPOTB DONTBUILD
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 19 Oct 2021 17:16:48 +0000 - rev 596391
Push 151787 by dholbert@mozilla.com at Tue, 19 Oct 2021 17:19:10 +0000
Bug 1735445: Fix some typos in the CSS Gap Decorations draft. rs=mats NPOTB DONTBUILD The html changes were generated by this command: curl https://api.csswg.org/bikeshed/ -F \ file=@layout/docs/css-gap-decorations/Overview.bs -F force=1 > \ layout/docs/css-gap-decorations/Overview.html Differential Revision: https://phabricator.services.mozilla.com/D128915
0479e0a4cc15b77b14e1f9de8f5358bdbf2313ec: Bug 1591366 - Improve nested grid layout performance r=mats
Sean Feng <sefeng@mozilla.com> - Mon, 20 Sep 2021 19:52:45 +0000 - rev 592546
Push 150060 by sefeng@mozilla.com at Mon, 20 Sep 2021 19:55:13 +0000
Bug 1591366 - Improve nested grid layout performance r=mats This patch improves nested grid layout performance by caching the grid items' block axis measurement to avoid potentially doing exponential reflows. Differential Revision: https://phabricator.services.mozilla.com/D115711
ba73f7aecc51a5549491dc45ebfa4b7ed4cd21db: Bug 1596184 - Get rid of nsStackFrame. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 20 Sep 2021 12:05:32 +0000 - rev 592486
Push 150018 by ealvarez@mozilla.com at Mon, 20 Sep 2021 12:07:54 +0000
Bug 1596184 - Get rid of nsStackFrame. r=layout-reviewers,mats There are no legacy-stack uses anymore. Differential Revision: https://phabricator.services.mozilla.com/D126077
a2b6f6abda6e98c62b0c0fcee7b74b43ac68795d: Bug 1591366 - Improve nested grid layout performance r=mats
Sean Feng <sefeng@mozilla.com> - Fri, 17 Sep 2021 21:06:52 +0000 - rev 592405
Push 149972 by sefeng@mozilla.com at Fri, 17 Sep 2021 21:29:21 +0000
Bug 1591366 - Improve nested grid layout performance r=mats This patch improves nested grid layout performance by caching the grid items' block axis measurement to avoid potentially doing exponential reflows. Differential Revision: https://phabricator.services.mozilla.com/D115711
e03a563a24f619900e687f0475c95e15c8afef5f: Bug 1728740 - Create WPT reftest for the zero-position of text-underline-offset. r=layout-reviewers,mats
Jonathan Kew <jkew@mozilla.com> - Thu, 02 Sep 2021 18:12:18 +0000 - rev 590869
Push 149108 by jkew@mozilla.com at Thu, 02 Sep 2021 19:47:27 +0000
Bug 1728740 - Create WPT reftest for the zero-position of text-underline-offset. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D124321
e41bfdf79fb8318639ac4fa99981a210e79ed74a: Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 01 Aug 2021 21:57:28 +0000 - rev 587437
Push 147265 by ealvarez@mozilla.com at Sun, 01 Aug 2021 21:59:52 +0000
Bug 1665476 - Remove nsRootBoxFrame to unify background propagation between XUL and non-XUL documents. r=layout-reviewers,mats It's unused on mozilla-central, and Thunderbird can just use the canvas frame as regular (X)HTML documents, so just use a canvas frame instead of an nsRootBoxFrame for XUL as well. nsRootBoxFrame was needed because of various XUL-specific things like tooltips and so on lived there. But with the move away from XUL, that functionality has been added to nsCanvasFrame already, behind a principal check instead. This also allows simplifying our background propagation setup, which was only half-working for XUL documents (this bug is a consequence of that). With this, most of the callers of nsCSSRendering::IsCanvasFrame can go. They're only two of the frames that would return true for that that actually paint backgrounds (nsCanvasFrame and nsRootBoxFrame), so the codepaths in display list building and painting can just check frame->IsCanvasFrame() instead. The remaining caller to that function is nsContainerFrame::SyncWindowProperties, and the change is also legit, in the sense that the only thing SyncWindowProperties() really cares about is propagating the max/min-width constraints from the root element's style to the view/widget, and the only frame that would return true from IsCanvasFrame and have a view is the viewport frame which is the root of the frame tree. Differential Revision: https://phabricator.services.mozilla.com/D90846
ccc6e271d9dbd7bbb3b0c640ff267cb6120322a9: Bug 1663475 - Paint caret geometry from the containing block. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 23 Jul 2021 12:50:31 +0000 - rev 586545
Push 146803 by ealvarez@mozilla.com at Fri, 23 Jul 2021 12:52:57 +0000
Bug 1663475 - Paint caret geometry from the containing block. r=mats This matches other browsers and shouldn't be too terrible, though I'm not quite a fan of it. Differential Revision: https://phabricator.services.mozilla.com/D89483
fbcaf33d96a4bc9a8880edb22f6d5e59908db16a: Bug 1716045 - Unify font-family storage. r=mats,jfkthame
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 18 Jun 2021 19:35:50 +0000 - rev 583831
Push 145278 by ealvarez@mozilla.com at Fri, 18 Jun 2021 19:38:29 +0000
Bug 1716045 - Unify font-family storage. r=mats,jfkthame This changes font-family storage to reuse the rust types, removing a bunch of code while at it. This allows us to, for example, use a single static font family for -moz-bullet and clone it, rather than creating a lot of expensive copies. Differential Revision: https://phabricator.services.mozilla.com/D118011
f0ad5df7104dca64bf5ff97370760e93bd30637b: Bug 1691192: Give crashtest 471360.html an upper-bound on its looping so that it doesn't cycle forever and block the harness from proceeding. r=mats
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 05 May 2021 01:46:36 +0000 - rev 578558
Push 142552 by dholbert@mozilla.com at Wed, 05 May 2021 01:48:59 +0000
Bug 1691192: Give crashtest 471360.html an upper-bound on its looping so that it doesn't cycle forever and block the harness from proceeding. r=mats Differential Revision: https://phabricator.services.mozilla.com/D113998
1a498df37bd505aa3b1711fd1f7c165b51091b89: Bug 1690423 - Part 3: No need to handle transferred size suggestion for the minimum contribution on non-replaced elements. r=mats
Boris Chiou <boris.chiou@gmail.com> - Mon, 12 Apr 2021 21:06:56 +0000 - rev 575554
Push 140797 by bchiou@mozilla.com at Mon, 12 Apr 2021 21:09:33 +0000
Bug 1690423 - Part 3: No need to handle transferred size suggestion for the minimum contribution on non-replaced elements. r=mats The spec says: the content-based minimum size for a grid item in a given dimension is its specified size suggestion if it exists, otherwise its transferred size suggestion if that exists and the element is replaced, else its content size suggestion. So for non-replaced elements, we don't have to take transferred size suggestion into account. Add some tests when using the preferred size with percentage value and min-size:auto in grid items, and a test for overflow:auto. Differential Revision: https://phabricator.services.mozilla.com/D110479
8c8b2e32217eccdddb1278a8b7518771c8fe63c0: Bug 1690423 - Part 2: Unified auto block-size behavior with UseAutoBSize flag in nsIFrame::ComputeSize(). r=mats
Boris Chiou <boris.chiou@gmail.com> - Mon, 12 Apr 2021 21:06:55 +0000 - rev 575553
Push 140797 by bchiou@mozilla.com at Mon, 12 Apr 2021 21:09:33 +0000
Bug 1690423 - Part 2: Unified auto block-size behavior with UseAutoBSize flag in nsIFrame::ComputeSize(). r=mats For grid layout, we set UseAutoBSize flag during measuring reflow to resolve the grid track sizing. We still have to respect aspect ratio for the calculation of the content contribution. Differential Revision: https://phabricator.services.mozilla.com/D104936
49ed09f9753a72fa09a7467a7dd344919f4c8b27: Bug 1690423 - Part 1: Fix stretched grid items with aspect-ratio. r=mats
Boris Chiou <boris.chiou@gmail.com> - Mon, 12 Apr 2021 21:06:55 +0000 - rev 575552
Push 140797 by bchiou@mozilla.com at Mon, 12 Apr 2021 21:09:33 +0000
Bug 1690423 - Part 1: Fix stretched grid items with aspect-ratio. r=mats Based on https://drafts.csswg.org/css-grid/#grid-item-sizing, the grid items should ignore aspect-ratio if it's stretched in that axis. 1. If the alignment value is stretch: don't apply aspect ratio. 2. If the alignment value is normal: apply aspect ratio if we have one. 3. Other values: apply aspect ratio if we have one. Note: We also clamp margin block min size in nsBlockFrame::ComputeFinalSize(), so grid-aspect-ratio-021.html is still passed without this patch. However, we add this test case just in case and let other browsers catch this. Differential Revision: https://phabricator.services.mozilla.com/D105082
ebe6536a936f93085eba716d175826ff64722fb8: Bug 708901 - Migrate to nsTHashSet in dom/grid. r=mats
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 24 Mar 2021 17:56:48 +0000 - rev 572918
Push 139401 by sgiesecke@mozilla.com at Wed, 24 Mar 2021 17:59:45 +0000
Bug 708901 - Migrate to nsTHashSet in dom/grid. r=mats Differential Revision: https://phabricator.services.mozilla.com/D109330
eee75f33f0606f786585a427680d1f03df9b4fbe: Bug 708901 - Migrate to nsTHashSet in dom/grid. r=mats
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 24 Mar 2021 16:59:01 +0000 - rev 572898
Push 139392 by sgiesecke@mozilla.com at Wed, 24 Mar 2021 17:01:55 +0000
Bug 708901 - Migrate to nsTHashSet in dom/grid. r=mats Differential Revision: https://phabricator.services.mozilla.com/D109330
acd959de0b618f741b2d6ec7ccb86e53686c9914: Bug 1697998 - Invalidate a bit more aggressively when a pseudo-element matches, in order to also invalidate the cached pseudo-styles on the parent. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Mar 2021 21:05:01 +0000 - rev 571342
Push 138599 by ealvarez@mozilla.com at Mon, 15 Mar 2021 21:07:28 +0000
Bug 1697998 - Invalidate a bit more aggressively when a pseudo-element matches, in order to also invalidate the cached pseudo-styles on the parent. r=mats This should probably be fine. If it becomes a perf issue somehow we can implement the RESTYLE_PSEUDOS hint or what not. Differential Revision: https://phabricator.services.mozilla.com/D108338
83d93b876225b37ec0a8afd837eeb939fc0e4ae3: Bug 1691397 - Intrinsic sizes that depend on percentage-sized abspos ancestors should account for containing-block padding correctly. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 25 Feb 2021 15:05:50 +0000 - rev 568783
Push 137218 by ealvarez@mozilla.com at Thu, 25 Feb 2021 15:08:12 +0000
Bug 1691397 - Intrinsic sizes that depend on percentage-sized abspos ancestors should account for containing-block padding correctly. r=layout-reviewers,mats Abspos boxes resolve against the pading box, and we were failing to increase the percentage basis in that case if box-sizing was content-box. This is partially the cause of bug 1691374. Differential Revision: https://phabricator.services.mozilla.com/D104389
07b09bbae186a0676f1050c8c3074074101d242e: Bug 1674268 - Add a wpt reftest table-item-flex-percentage-min-width.html. r=dholbert,mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 22 Feb 2021 19:59:18 +0000 - rev 568293
Push 136950 by aethanyc@gmail.com at Mon, 22 Feb 2021 20:16:52 +0000
Bug 1674268 - Add a wpt reftest table-item-flex-percentage-min-width.html. r=dholbert,mats This test is developed by Mats Palmgren, and fixed by bug 1674302. Differential Revision: https://phabricator.services.mozilla.com/D105843
373fe3a0806a72574a9a95cac9dd25e9881380c9: Bug 1690422 - Take box-sizing into account when computing the intrinsic size with the preferred aspect ratio. r=TYLin,mats
Boris Chiou <boris.chiou@gmail.com> - Wed, 17 Feb 2021 02:41:24 +0000 - rev 567815
Push 136617 by bchiou@mozilla.com at Wed, 17 Feb 2021 02:43:48 +0000
Bug 1690422 - Take box-sizing into account when computing the intrinsic size with the preferred aspect ratio. r=TYLin,mats We resolve the auto value in IntrinsicForAxis by the ratio determining size and the preferred aspect ratio. However, this should take box-sizing into account when using aspect-ratio property. Differential Revision: https://phabricator.services.mozilla.com/D104293
a45742c9557d9b0306ba621ab5285878284f26b9: Bug 1693061 - Don't make -moz-user-input differences rebuild frames. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Feb 2021 20:00:15 +0000 - rev 567747
Push 136582 by ealvarez@mozilla.com at Tue, 16 Feb 2021 20:02:35 +0000
Bug 1693061 - Don't make -moz-user-input differences rebuild frames. r=layout-reviewers,mats We don't use it for anything resembling frame construction, so this should be safe. This goes back to bug 78695. Differential Revision: https://phabricator.services.mozilla.com/D105353
ceaebebccb5e67929ed7ba66d60954a9f218dc26: Bug 1691875 Part 3 - Always compute inner table's border and padding before initializing its ReflowInput. r=layout-reviewers,jfkthame,mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 15 Feb 2021 18:30:03 +0000 - rev 567581
Push 136490 by aethanyc@gmail.com at Mon, 15 Feb 2021 19:57:11 +0000
Bug 1691875 Part 3 - Always compute inner table's border and padding before initializing its ReflowInput. r=layout-reviewers,jfkthame,mats This is a preparation patch for bug 1674302. We'll need border padding to reduce the size for inner table size overrides. Differential Revision: https://phabricator.services.mozilla.com/D104643
3fabd86d59e6a6d473fa8f216f6715eb8065131c: Bug 1691875 Part 2 - Pass the area occupied by caption into CreateReflowInputForInnerTable(). r=mats,jfkthame
Ting-Yu Lin <tlin@mozilla.com> - Mon, 15 Feb 2021 18:30:03 +0000 - rev 567580
Push 136490 by aethanyc@gmail.com at Mon, 15 Feb 2021 19:57:11 +0000
Bug 1691875 Part 2 - Pass the area occupied by caption into CreateReflowInputForInnerTable(). r=mats,jfkthame If the table wrapper frame has a caption, several sizes that are used to initialized inner table's ReflowInput needs to be reduced: 1. the available block-size, 2. containing block size, 3. StyleSizeOverrides (will be considered in bug 1674302). This patch gives CreateReflowInputForInnerTable() an argument to pass the space occupied by the caption in order to reduce the above sizes. Note the old code doesn't reduce the constrained available block-size when recreating ReflowInput for a table grid item, but this patch does. Also, this patch goes ahead to recreate ReflowInput when the area occupied by caption is non-empty, which may or may not affect the containing block size for grid item. But for now, I keep it simple because bug 16743202 is going to add logic that needs to recreate ReflowInput when there is any size overrides. I tend not to over-optimize the performance. Differential Revision: https://phabricator.services.mozilla.com/D104642
9ab10a81eb56099cf471400400fa827a2359f201: Bug 1527734 - Use ReflowInput::mContainingBlockSize instead of GridItemCBSizeProperty(). r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 09 Feb 2021 00:59:39 +0000 - rev 566518
Push 136000 by aethanyc@gmail.com at Tue, 09 Feb 2021 01:02:01 +0000
Bug 1527734 - Use ReflowInput::mContainingBlockSize instead of GridItemCBSizeProperty(). r=mats Grid container stores the containing block size on a table wrapper grid item in GridItemCBSizeProperty(), but the size is also passed as a parameter when creating table wrapper's ReflowInput, and is stored in ReflowInput::mContainingBlockSize. We can use mContainingBlockSize directly instead of GridItemCBSizeProperty(). The test 002.html is inspired from the testcases in bug 1527734. 003.html and 004.html are inspired from the testcase in bug 1521088. 004.html is 003.html with 'width:500px' added to <table>, which we still fail with this patch. Differential Revision: https://phabricator.services.mozilla.com/D104144
34171554d0c4071eda974af4fe4f4a2b80e79cb8: Bug 1630789 - Add web-platform tests for grid line names with repeat(auto) with multiple values r=mats
Emily McDonough <emcdonough@mozilla.com> - Fri, 05 Feb 2021 18:14:04 +0000 - rev 566236
Push 135855 by emcdonough@mozilla.com at Fri, 05 Feb 2021 20:31:11 +0000
Bug 1630789 - Add web-platform tests for grid line names with repeat(auto) with multiple values r=mats Differential Revision: https://phabricator.services.mozilla.com/D71418
48895a7f84a63b732793e57c98079c4367d5f089: Bug 1690901 Part 3 - Rename OuterDoReflowChild() to ReflowChild() for nsTableWrapperFrame. r=layout-reviewers,mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Feb 2021 04:46:44 +0000 - rev 566114
Push 135791 by aethanyc@gmail.com at Fri, 05 Feb 2021 04:53:12 +0000
Bug 1690901 Part 3 - Rename OuterDoReflowChild() to ReflowChild() for nsTableWrapperFrame. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D104107
33171dca5ccde8fb8d8128520e6d7205997d0a75: Bug 1690901 Part 2 - Split and rename nsTableWrapperFrame::OuterBeginReflowChild() into two methods for caption and inner table. r=layout-reviewers,mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Feb 2021 04:46:42 +0000 - rev 566113
Push 135791 by aethanyc@gmail.com at Fri, 05 Feb 2021 04:53:12 +0000
Bug 1690901 Part 2 - Split and rename nsTableWrapperFrame::OuterBeginReflowChild() into two methods for caption and inner table. r=layout-reviewers,mats Split OuterBeginReflowChild() so that we don't need to branch logic for caption and inner table. Rename the methods because OuterBeginReflowChild() only creates the ReflowInput, and has nothing to do with actual reflow. We could give both methods the same name like `CreateChildReflowInput` and rely on function overloading to call the correct method depending on the frame type, but I prefer clearer method names. Differential Revision: https://phabricator.services.mozilla.com/D104106
4d1fbb7ea482236b80d5bd9994cd67c818377c6e: Bug 1690901 Part 1 - Make GetCaptionSide() and HasSideCaption() const methods. r=layout-reviewers,mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 05 Feb 2021 04:43:38 +0000 - rev 566112
Push 135791 by aethanyc@gmail.com at Fri, 05 Feb 2021 04:53:12 +0000
Bug 1690901 Part 1 - Make GetCaptionSide() and HasSideCaption() const methods. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D104105
2631bbcab4f9810ebb3d509e261b91dcbff78bfa: Bug 1684788 - Remove misguided MOZ_RELEASE_ASSERT and use a null check instead. r=mats
Markus Stange <mstange.moz@gmail.com> - Wed, 20 Jan 2021 01:32:02 +0000 - rev 563873
Push 134529 by mstange@themasta.com at Wed, 20 Jan 2021 01:54:46 +0000
Bug 1684788 - Remove misguided MOZ_RELEASE_ASSERT and use a null check instead. r=mats Differential Revision: https://phabricator.services.mozilla.com/D101505
df791c74125a1181edfef01ee7d67d46fcafc584: Bug 1351248 - Simplify nsIFrame::IsFocusable API. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 03 Jan 2021 23:30:51 +0000 - rev 561868
Push 133443 by ealvarez@mozilla.com at Sun, 03 Jan 2021 23:33:31 +0000
Bug 1351248 - Simplify nsIFrame::IsFocusable API. r=layout-reviewers,mats We always compute the tabindex value, so just return it to the caller all the time. This allows us to use early-returns which makes the code a bit easier to follow. This patch shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D100423
c3eb53d6395af1163960e45110fa8753a9381765: Bug 1618584 - Simplify marquee widget to not use XUL. r=bgrins,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 18 Dec 2020 11:55:00 +0000 - rev 561260
Push 133103 by ealvarez@mozilla.com at Fri, 18 Dec 2020 11:58:13 +0000
Bug 1618584 - Simplify marquee widget to not use XUL. r=bgrins,mats And also to use more similar markup and setup between horizontal/vertical marquee. Differential Revision: https://phabricator.services.mozilla.com/D99869
d68dc9908fc8002271337ae7e33893022266c7f1: Bug 1682703: [css-grid-3] Remove in-tree masonry draft spec, now that it lives in csswg repo. r=mats DONTBUILD
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 16 Dec 2020 05:17:36 +0000 - rev 560906
Push 132913 by dholbert@mozilla.com at Wed, 16 Dec 2020 05:54:41 +0000
Bug 1682703: [css-grid-3] Remove in-tree masonry draft spec, now that it lives in csswg repo. r=mats DONTBUILD The draft spec now officially lives at https://drafts.csswg.org/css-grid-3/ and we don't need this in-tree version anymore. This commit entirely removes the directory layout/docs/css-grid-3/ and also removes the line for this directory from tools/rewriting/ThirdPartyPaths.txt. Differential Revision: https://phabricator.services.mozilla.com/D99850
34938f7c55a3faae7b1d75aa1ed684f651512d2b: Bug 1681375 - Allow scrolled-content-block to have a height for editable elements. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Dec 2020 18:15:24 +0000 - rev 560657
Push 132741 by ealvarez@mozilla.com at Mon, 14 Dec 2020 18:22:11 +0000
Bug 1681375 - Allow scrolled-content-block to have a height for editable elements. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D99460
20ba0abd37d1a4409099fa83f0cc6bf15cfbba92: Bug 1682295 - Remove some text-decoration prefs that are always on. r=layout-reviewers,mats
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 14 Dec 2020 16:14:35 +0000 - rev 560639
Push 132730 by ealvarez@mozilla.com at Mon, 14 Dec 2020 17:23:57 +0000
Bug 1682295 - Remove some text-decoration prefs that are always on. r=layout-reviewers,mats Differential Revision: https://phabricator.services.mozilla.com/D99675
b51a3956edfc3359b3750b83044a65e837d6b995: Bug 1677353 - Ignore padding when computing definite percentages if we're abspos boxes. r=mats
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 12 Dec 2020 11:18:56 +0000 - rev 560440
Push 132658 by ealvarez@mozilla.com at Sat, 12 Dec 2020 11:21:27 +0000
Bug 1677353 - Ignore padding when computing definite percentages if we're abspos boxes. r=mats As percentages in abspos boxes resolve against the padding box. Differential Revision: https://phabricator.services.mozilla.com/D99455
5c604651dca41d9703b219d59f0e9e974a1ac6a0: Bug 1666592 - Prevent PullItemsNextInFlow() from reparenting child's NIF if NIF's parent is already this container. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Dec 2020 01:05:32 +0000 - rev 560290
Push 132560 by aethanyc@gmail.com at Fri, 11 Dec 2020 01:09:38 +0000
Bug 1666592 - Prevent PullItemsNextInFlow() from reparenting child's NIF if NIF's parent is already this container. r=mats We can do this because all the children in aItems are going to be moved to this container's principal child list. It's fine to leave the child's next-in-flow in other lists of the same parent. Differential Revision: https://phabricator.services.mozilla.com/D92024
cdb6f451342a83b150ba80d6347789ca98a08b88: Bug 1674774 Part 3 - Move flex item's position when flex container has a vertical-rl writing-mode. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 01 Dec 2020 05:45:59 +0000 - rev 558883
Push 131806 by aethanyc@gmail.com at Tue, 01 Dec 2020 05:54:04 +0000
Bug 1674774 Part 3 - Move flex item's position when flex container has a vertical-rl writing-mode. r=mats The flex container fragment's tentative block-size can be different from its final size if there is any unbreakable child that has a block-size larger than the available block-size. The two passed reftests are such examples. Differential Revision: https://phabricator.services.mozilla.com/D97522
7448c4ef16ca58b3451a4aaad75cbb06c459447a: Bug 1674774 Part 2 - Fix the border-box size which is used to position flex container's children. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 01 Dec 2020 05:45:56 +0000 - rev 558882
Push 131806 by aethanyc@gmail.com at Tue, 01 Dec 2020 05:54:04 +0000
Bug 1674774 Part 2 - Fix the border-box size which is used to position flex container's children. r=mats If the flex container frame's tentative border-box size is different from its final size, and it's in vertical-rl writing mode, we need to adjust children's position. This is implemented in Part 3. Differential Revision: https://phabricator.services.mozilla.com/D97521
7f28e2783cf187a0b610559f70833264d585d384: Bug 1674774 Part 1 - Move two variables' definition closer to their usage. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Tue, 01 Dec 2020 05:45:49 +0000 - rev 558881
Push 131806 by aethanyc@gmail.com at Tue, 01 Dec 2020 05:54:04 +0000
Bug 1674774 Part 1 - Move two variables' definition closer to their usage. r=mats Differential Revision: https://phabricator.services.mozilla.com/D97519
bf11f56d91cb7cf31564095d6e4467beeb8a4687: Bug 1677917 - Change BlockReflowInput's skipsides setup to be sane. r=mats,TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 30 Nov 2020 17:49:04 +0000 - rev 558745
Push 131759 by ealvarez@mozilla.com at Mon, 30 Nov 2020 18:51:57 +0000
Bug 1677917 - Change BlockReflowInput's skipsides setup to be sane. r=mats,TYLin Precomputing the skipBEnd bit is odd / wrong. Using the PreReflow version causes no regression, and allows us to simplify the code. It also reverts the test annotations added to bug 1675376 which were caused by the extra argument to GetLogicalSkipSides() somehow. Differential Revision: https://phabricator.services.mozilla.com/D97418
edf35fea5913c869fd35f1e523967478edfcaa18: Bug 1674774 Part 3 - Move flex item's position when flex container has a vertical-rl writing-mode. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 30 Nov 2020 18:02:03 +0000 - rev 558739
Push 131753 by aethanyc@gmail.com at Mon, 30 Nov 2020 18:10:05 +0000
Bug 1674774 Part 3 - Move flex item's position when flex container has a vertical-rl writing-mode. r=mats The flex container fragment's tentative block-size can be different from its final size if there is any unbreakable child that has a block-size larger than the available block-size. The two passed reftests are such examples. Differential Revision: https://phabricator.services.mozilla.com/D97522
52c3e2fefc0331b27e852ea8ac361d3edb5c4882: Bug 1674774 Part 2 - Fix the border-box size which is used to position flex container's children. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 30 Nov 2020 18:03:09 +0000 - rev 558738
Push 131753 by aethanyc@gmail.com at Mon, 30 Nov 2020 18:10:05 +0000
Bug 1674774 Part 2 - Fix the border-box size which is used to position flex container's children. r=mats If the flex container frame's tentative border-box size is different from its final size, and it's in vertical-rl writing mode, we need to adjust children's position. This is implemented in Part 3. Differential Revision: https://phabricator.services.mozilla.com/D97521
d4fa50b48efd8768bd9015a343966d0520862241: Bug 1674774 Part 1 - Move two variables' definition closer to their usage. r=mats
Ting-Yu Lin <tlin@mozilla.com> - Mon, 30 Nov 2020 18:02:35 +0000 - rev 558737
Push 131753 by aethanyc@gmail.com at Mon, 30 Nov 2020 18:10:05 +0000
Bug 1674774 Part 1 - Move two variables' definition closer to their usage. r=mats Differential Revision: https://phabricator.services.mozilla.com/D97519