searching for reviewer(markh)
8fa2316b02404d9fde7a88fe6948df683a2f84a0: Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Vijay Budhram <vbudhram@mozilla.com> - Thu, 14 Nov 2019 21:01:23 +0000 - rev 502074
Push 100591 by vbudhram@mozilla.com at Thu, 14 Nov 2019 22:53:55 +0000
Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh Differential Revision: https://phabricator.services.mozilla.com/D50931
ef26ae2ee4c22fc88d6590244862066f1974c6ce: Bug 1595953 - Connect UITour-lib.js docs to sphinx-js to publish on firefox-source-docs. r=markh
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Wed, 13 Nov 2019 02:40:03 +0000 - rev 501706
Push 100377 by mozilla@noorenberghe.ca at Wed, 13 Nov 2019 03:57:16 +0000
Bug 1595953 - Connect UITour-lib.js docs to sphinx-js to publish on firefox-source-docs. r=markh Differential Revision: https://phabricator.services.mozilla.com/D52772
f61b8acc6660bb1588b43472e59361a858662ad7: Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh
rfkelly <rfkelly@mozilla.com> - Fri, 08 Nov 2019 06:28:54 +0000 - rev 501228
Push 100076 by rkelly@mozilla.com at Fri, 08 Nov 2019 07:35:28 +0000
Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh Differential Revision: https://phabricator.services.mozilla.com/D50770
dd5c1030d23b94e5a7e9a03f5c1c84928de7f58e: Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh
Vijay Budhram <vbudhram@mozilla.com> - Wed, 06 Nov 2019 16:51:03 +0000 - rev 500900
Push 99872 by vbudhram@mozilla.com at Wed, 06 Nov 2019 16:51:44 +0000
Bug 1590231 - Update sync preferences panel to match decouple designs r=fluent-reviewers,markh Differential Revision: https://phabricator.services.mozilla.com/D50931
1f54684288812e601e16e1eccef44360e6737632: Bug 1582263 - Move devices list to top level of sync ping. r=markh
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 05 Nov 2019 17:21:12 +0000 - rev 500721
Push 99789 by tchiovoloni@mozilla.com at Tue, 05 Nov 2019 22:07:12 +0000
Bug 1582263 - Move devices list to top level of sync ping. r=markh Move devices list to top level of sync ping Differential Revision: https://phabricator.services.mozilla.com/D49194
bc70189de0004f410b6e5d8bf287a7eb5500c087: Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Thom Chiovoloni <tchiovoloni@mozilla.com> - Fri, 25 Oct 2019 21:38:01 +0000 - rev 499115
Push 98901 by tchiovoloni@mozilla.com at Fri, 25 Oct 2019 22:37:13 +0000
Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment Differential Revision: https://phabricator.services.mozilla.com/D49166
37f900e2a6c9e0fb315fdef1a25412d1cec9fd24: Bug 1590948 - Properly inspect `context` param when handling `fxa_status` webchannel message. r=markh
rfkelly <rfkelly@mozilla.com> - Fri, 25 Oct 2019 00:23:09 +0000 - rev 498966
Push 98814 by ccoroiu@mozilla.com at Fri, 25 Oct 2019 05:51:38 +0000
Bug 1590948 - Properly inspect `context` param when handling `fxa_status` webchannel message. r=markh Differential Revision: https://phabricator.services.mozilla.com/D50408
3d7b77564cb7ca0800deedbb46de66a8b630d1f6: Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Thom Chiovoloni <tchiovoloni@mozilla.com> - Tue, 15 Oct 2019 22:57:58 +0000 - rev 498779
Push 98679 by tchiovoloni@mozilla.com at Wed, 23 Oct 2019 20:03:52 +0000
Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment Differential Revision: https://phabricator.services.mozilla.com/D49166
6626f6c6c10edc2b654901b5eba748b09f92ec14: Bug 1567196 - Ignore invalid password date values. r=markh
Sam Foster <sfoster@mozilla.com> - Tue, 15 Oct 2019 00:23:42 +0000 - rev 497501
Push 97933 by sfoster@mozilla.com at Tue, 15 Oct 2019 06:51:21 +0000
Bug 1567196 - Ignore invalid password date values. r=markh Depends on D48941 Differential Revision: https://phabricator.services.mozilla.com/D49218
b4479a9504d01e25d876bf0c63581869baee20fb: Bug 1586446 - Ignore duplicate outgoing tags in the bookmarks mirror. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Sun, 13 Oct 2019 23:56:04 +0000 - rev 497383
Push 97856 by kcambridge@mozilla.com at Mon, 14 Oct 2019 02:19:54 +0000
Bug 1586446 - Ignore duplicate outgoing tags in the bookmarks mirror. r=markh Differential Revision: https://phabricator.services.mozilla.com/D49076
8550494c9226b2566c741c2aaa809b32ff67575f: Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Mon, 14 Oct 2019 00:22:10 +0000 - rev 497382
Push 97855 by kcambridge@mozilla.com at Mon, 14 Oct 2019 02:00:38 +0000
Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh Differential Revision: https://phabricator.services.mozilla.com/D49049
12ff69a8f36063cfc440216c21c6bacb53540ffd: Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Edouard Oger <eoger@fastmail.com> - Fri, 11 Oct 2019 17:06:57 +0000 - rev 497307
Push 97796 by eoger@mozilla.com at Fri, 11 Oct 2019 17:08:47 +0000
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D48410
93fd57365bcd84e90cc8e89639ea04998ad1e7e9: Bug 1588005 - Enable the bookmarks mirror by default. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Fri, 11 Oct 2019 04:01:51 +0000 - rev 497257
Push 97756 by kcambridge@mozilla.com at Fri, 11 Oct 2019 05:10:37 +0000
Bug 1588005 - Enable the bookmarks mirror by default. r=markh Differential Revision: https://phabricator.services.mozilla.com/D48933
4695136f7e822e205c86e6a2e0e570f749baaeb7: Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Edouard Oger <eoger@fastmail.com> - Thu, 10 Oct 2019 21:08:01 +0000 - rev 497195
Push 97726 by eoger@mozilla.com at Thu, 10 Oct 2019 21:24:27 +0000
Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D48410
74f222c707654e731b7458c6f89698f1321b34af: Bug 1580172 - Fix Fxa CAD button in dark mode theme r=markh
Vijay Budhram <vbudhram@mozilla.com> - Tue, 08 Oct 2019 00:02:47 +0000 - rev 496762
Push 97426 by vbudhram@mozilla.com at Tue, 08 Oct 2019 13:10:53 +0000
Bug 1580172 - Fix Fxa CAD button in dark mode theme r=markh Differential Revision: https://phabricator.services.mozilla.com/D48438
0ff644ae9d66c24d49861f78a0be3061c87160f9: Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
Edouard Oger <eoger@fastmail.com> - Mon, 07 Oct 2019 15:25:38 +0000 - rev 496540
Push 97316 by eoger@mozilla.com at Mon, 07 Oct 2019 15:26:23 +0000
Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh Differential Revision: https://phabricator.services.mozilla.com/D48272
315df8dc3c419cfeb4d34b511e681ca975cfeaa8: Bug 1584293 - Refactor the FxA disconnect dialog. r=markh,flod,fluent-reviewers
Edouard Oger <eoger@fastmail.com> - Fri, 04 Oct 2019 14:06:35 +0000 - rev 496336
Push 97177 by eoger@mozilla.com at Fri, 04 Oct 2019 14:07:43 +0000
Bug 1584293 - Refactor the FxA disconnect dialog. r=markh,flod,fluent-reviewers Differential Revision: https://phabricator.services.mozilla.com/D48098
0e871ed50b6c30999fba87362058c60112fc8195: Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
Lina Cambridge <lina@yakshaving.ninja> - Thu, 03 Oct 2019 22:40:55 +0000 - rev 496267
Push 97139 by kcambridge@mozilla.com at Thu, 03 Oct 2019 23:09:26 +0000
Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger Instead of using the list of FxA devices from the Sync clients engine, we now fetch the list of Send Tab devices from FxA. This works like this: * `FxAccountsDevice#getDeviceList` has been split up into `recentDeviceList` and `refreshDeviceList`. * `recentDeviceList` synchronously returns the last fetched list, so that consumers like Send Tab can use it right away. * `refreshDeviceList` is asynchronous, and refreshes the last fetched list. Refreshes are limited to once every minute by default, matching the minimum sync interval (Send Tab passes the `ignoreCached` option to override the limit if the user clicks the "refresh" button). Concurrent calls to `refreshDeviceList` are also serialized, to ensure the list is only fetched once. * The list is flagged as stale when a device is connected or disconnected. It's still kept around, but the next call to `refreshDeviceList` will fetch a new list from the server. * The Send Tab UI refreshes FxA devices in the background. Matching FxA devices to Sync client records is best effort; we don't do it if Sync isn't configured or hasn't run yet. This only impacts the fallback case if the target doesn't support FxA commands. Differential Revision: https://phabricator.services.mozilla.com/D47521
b2053e82f1596004c7ac9aba1484e42cb1c88063: Bug 1570568 - Update Fxa menu to reflect decoupling r=eoger,markh
Vijay Budhram <vbudhram@mozilla.com> - Thu, 03 Oct 2019 18:04:56 +0000 - rev 496227
Push 97108 by vbudhram@mozilla.com at Thu, 03 Oct 2019 18:05:29 +0000
Bug 1570568 - Update Fxa menu to reflect decoupling r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D46891
ac0a69cbf49de19f0a71901d29daf306e156bdfa: Bug 1577449 - Replace Learn about Send Tab link. r=markh
Edouard Oger <eoger@fastmail.com> - Tue, 24 Sep 2019 22:50:36 +0000 - rev 494812
Push 96249 by eoger@mozilla.com at Tue, 24 Sep 2019 22:54:44 +0000
Bug 1577449 - Replace Learn about Send Tab link. r=markh Differential Revision: https://phabricator.services.mozilla.com/D46631
ff421051717eaeeee9bde1b0d8334530afeb5670: Bug 1576654 - Show Sent! notifications in every context. r=markh
Edouard Oger <eoger@fastmail.com> - Tue, 24 Sep 2019 18:01:09 +0000 - rev 494755
Push 96214 by eoger@mozilla.com at Tue, 24 Sep 2019 18:01:45 +0000
Bug 1576654 - Show Sent! notifications in every context. r=markh Differential Revision: https://phabricator.services.mozilla.com/D46798
f54538dd8a6f9c41839e35d99ae5106103f75721: Bug 1576654 - Show Sent! notifications in every context. r=markh
Edouard Oger <eoger@fastmail.com> - Tue, 24 Sep 2019 00:20:17 +0000 - rev 494721
Push 96187 by eoger@mozilla.com at Tue, 24 Sep 2019 14:37:42 +0000
Bug 1576654 - Show Sent! notifications in every context. r=markh Differential Revision: https://phabricator.services.mozilla.com/D46798
0c2c86f22204ad5c7e3abcb11957fd18f9c41c38: Bug 1580115 - Fix fxa menu disconnected avatar r=eoger,markh
Vijay Budhram <vbudhram@mozilla.com> - Tue, 24 Sep 2019 02:53:02 +0000 - rev 494637
Push 96135 by vbudhram@mozilla.com at Tue, 24 Sep 2019 02:53:49 +0000
Bug 1580115 - Fix fxa menu disconnected avatar r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D46799
98360b03e1931b4ac2b8136033bcd694aac85f80: Bug 1572212 - Add sync side button back r=eoger,markh
Vijay Budhram <vbudhram@mozilla.com> - Fri, 20 Sep 2019 17:01:06 +0000 - rev 494524
Push 96053 by vbudhram@mozilla.com at Mon, 23 Sep 2019 14:11:49 +0000
Bug 1572212 - Add sync side button back r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D46514
378901831720b88f4c11a79a97475f85ab57d137: Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Vijay Budhram <vbudhram@mozilla.com> - Fri, 20 Sep 2019 17:00:51 +0000 - rev 494448
Push 96011 by vbudhram@mozilla.com at Sat, 21 Sep 2019 20:24:08 +0000
Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D45725
4ce6c9d4041a0ed36ebe9f8998a6e02ca4fc6526: Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh
Vijay Budhram <vbudhram@mozilla.com> - Thu, 19 Sep 2019 19:27:02 +0000 - rev 494114
Push 95826 by vbudhram@mozilla.com at Thu, 19 Sep 2019 20:34:05 +0000
Bug 1575706 - Add account sub menu to fxa toolbar menu r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D45725
8ff648dfb55b2680837e991c69a1f6a703ff3a83: Bug 1580270 - Remove `Async.jankYielder` from bookmarks mirror transactions. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 17 Sep 2019 06:27:26 +0000 - rev 493525
Push 95528 by kcambridge@mozilla.com at Tue, 17 Sep 2019 06:29:45 +0000
Bug 1580270 - Remove `Async.jankYielder` from bookmarks mirror transactions. r=markh `Async.jankYielder` can yield for long periods of time. When used in a `Sqlite.jsm` transaction, it blocks all other transactions on the connection, and can cause a shutdown hang if the transaction is in an `executeBeforeShutdown` block. This commit removes `jankYielder` from `SyncedBookmarksMirror::store`, and also makes `store` abortable. Differential Revision: https://phabricator.services.mozilla.com/D45453
faabf87693c1ee934d1e16a3cdbac0fb9ecb84c8: Bug 1579728 - Use completion ops to upload synced bookmark tombstones. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 17 Sep 2019 06:27:12 +0000 - rev 493524
Push 95527 by kcambridge@mozilla.com at Tue, 17 Sep 2019 06:28:42 +0000
Bug 1579728 - Use completion ops to upload synced bookmark tombstones. r=markh The latest version of Dogear adds completion ops for deleting local items (to apply incoming tombstones), inserting new local tombstones (to stage deletions for non-syncable and invalid items), and uploading tombstones (to avoid an extra scan of `moz_bookmarks_deleted`). These ops are only emitted for GUIDs that exist in both trees. We'll remove any local tombstones for items that don't exist or are already deleted on the server, and flag any remote tombstones for items that don't exist in Places as merged. Differential Revision: https://phabricator.services.mozilla.com/D45310
9a3b2a7742fb620c3caca4f7fa4891804b08053a: Bug 1579445 - Refresh the FxA device list on Send Tab menu open. r=markh
Edouard Oger <eoger@fastmail.com> - Thu, 12 Sep 2019 22:42:31 +0000 - rev 492978
Push 95241 by eoger@mozilla.com at Thu, 12 Sep 2019 22:49:00 +0000
Bug 1579445 - Refresh the FxA device list on Send Tab menu open. r=markh Differential Revision: https://phabricator.services.mozilla.com/D45189
e8257acd87021bc4c61013c439547e9740c21c91: Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
Edouard Oger <eoger@fastmail.com> - Wed, 11 Sep 2019 01:17:46 +0000 - rev 492859
Push 95202 by eoger@mozilla.com at Thu, 12 Sep 2019 17:56:15 +0000
Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh Differential Revision: https://phabricator.services.mozilla.com/D44484
546c728819e12aa84b1ebeecd98e0c78b4cf22d4: Bug 1577788 - Fix unique constraint errors when syncing bookmarks with tags. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Sun, 08 Sep 2019 23:55:58 +0000 - rev 492186
Push 94794 by kcambridge@mozilla.com at Mon, 09 Sep 2019 02:46:40 +0000
Bug 1577788 - Fix unique constraint errors when syncing bookmarks with tags. r=markh Our `INSTEAD OF INSERT` trigger for local tags reused existing tag folders if they already existed, but not existing tag entries. This caused us to insert duplicate tag entries for items whose tags didn't change, which, in turn, threw unique constraint violations when we tried to insert rows for tag entries that already existed into `itemsAdded`. This commit gives tag entries the same treatment as tag folders. This commit also improves debug logging during application, so we can pinpoint errors like this better in the future. Differential Revision: https://phabricator.services.mozilla.com/D44769
068a65420ddda3940ba6b138dc17f1b19c8c5bf7: Bug 1573959 - Update FxA toolbar menu utm param r=markh
Vijay Budhram <vbudhram@mozilla.com> - Thu, 22 Aug 2019 16:53:17 +0000 - rev 489481
Push 93373 by cbrindusan@mozilla.com at Thu, 22 Aug 2019 18:07:56 +0000
Bug 1573959 - Update FxA toolbar menu utm param r=markh Differential Revision: https://phabricator.services.mozilla.com/D43093
7f4c0860c4985c997b8b22b9ee33790f7b5b0ced: Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 13 Aug 2019 22:58:16 +0000 - rev 487840
Push 92484 by kcambridge@mozilla.com at Tue, 13 Aug 2019 23:29:12 +0000
Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh When a local or remote item changed, we'd potentially scan three tables (with an expensive `LEFT JOIN`!) to check if anything changed...then scan the same tables again to build the local and remote trees. This check was originally meant to avoid unnecessary merges. However, the bottleneck isn't merging now; it's reading from the database. Since the merger has been rewritten in Rust, is synchronous, doesn't keep a transaction open for the entire merge (see the `total_sync_changes` check), and only emits ops for items that actually changed, it's more efficient to build and merge optimistically, and bail before applying if nothing changed. This commit also moves `validateLocalRoots` into Rust. Differential Revision: https://phabricator.services.mozilla.com/D41690
595541e822af93be0fa5fd11203715ce28154df3: Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 13 Aug 2019 18:48:25 +0000 - rev 487797
Push 92458 by kcambridge@mozilla.com at Tue, 13 Aug 2019 20:34:07 +0000
Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh This commit introduces a new `Watchdog` class that signals an abort, either after a delay or at shutdown, and wires up the buffered engine to use it. Differential Revision: https://phabricator.services.mozilla.com/D41311
9f104a3a13047f800a012e47f41f0f1320157f8f: Bug 1572615 - Make bookmark merges abortable. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 13 Aug 2019 18:48:10 +0000 - rev 487796
Push 92458 by kcambridge@mozilla.com at Tue, 13 Aug 2019 20:34:07 +0000
Bug 1572615 - Make bookmark merges abortable. r=markh This commit changes `mozISyncedBookmarksMerger.merge` to return a cancelable operation, and adds an abort `signal` option to `SyncedBookmarksMirror.apply`. Aborting the signal's `AbortController`, or finalizing the mirror, interrupts the merge. Differential Revision: https://phabricator.services.mozilla.com/D41310
f927dbea0cd3af3b93222ff4ffc6a5b18559c07b: Bug 1567569 - Add VR and TV device icons. r=markh
Edouard Oger <eoger@fastmail.com> - Tue, 13 Aug 2019 02:52:07 +0000 - rev 487682
Push 92407 by eoger@mozilla.com at Tue, 13 Aug 2019 14:42:46 +0000
Bug 1567569 - Add VR and TV device icons. r=markh Differential Revision: https://phabricator.services.mozilla.com/D41464
6709b85b9571b152ae46056ee414dcad7a158b75: Bug 1572621 - Merge services-sync.js into all.js. r=markh
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 09 Aug 2019 09:18:41 +0000 - rev 487176
Push 92140 by nnethercote@mozilla.com at Fri, 09 Aug 2019 09:20:44 +0000
Bug 1572621 - Merge services-sync.js into all.js. r=markh Differential Revision: https://phabricator.services.mozilla.com/D41323
4c8140acc8ea31f6e0d6dea7b699615015e717cf: Bug 1572621 - Merge services-common.js into all.js. r=markh
Nicholas Nethercote <nnethercote@mozilla.com> - Fri, 09 Aug 2019 09:18:27 +0000 - rev 487175
Push 92140 by nnethercote@mozilla.com at Fri, 09 Aug 2019 09:20:44 +0000
Bug 1572621 - Merge services-common.js into all.js. r=markh Differential Revision: https://phabricator.services.mozilla.com/D41322
d365e6ff73828aabc42db807ebd8377da5333765: Bug 1569620 - Update Fxa toolbar menu to latest skyline ux designs r=markh
Vijay Budhram <vbudhram@mozilla.com> - Wed, 07 Aug 2019 18:07:23 +0000 - rev 487019
Push 92091 by archaeopteryx@coole-files.de at Thu, 08 Aug 2019 20:13:05 +0000
Bug 1569620 - Update Fxa toolbar menu to latest skyline ux designs r=markh Differential Revision: https://phabricator.services.mozilla.com/D40103
34e6203ba194355d79b180d85ac3e20a280a732f: Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 08 Aug 2019 15:18:36 +0000 - rev 486952
Push 92059 by mbanner@mozilla.com at Thu, 08 Aug 2019 16:29:33 +0000
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh Differential Revision: https://phabricator.services.mozilla.com/D40878
7aa97ba7cce9f5b5a298f71880965068cce68689: Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Jared Wein <jwein@mozilla.com> - Thu, 08 Aug 2019 01:38:51 +0000 - rev 486912
Push 92034 by mbanner@mozilla.com at Thu, 08 Aug 2019 12:47:25 +0000
Bug 1571567 - Fix no-fallthrough errors in /services. r=markh Differential Revision: https://phabricator.services.mozilla.com/D40878
3d0713667370c699573a8a1a86f99ac88b49f40d: Bug 1568866 - Update send to device panel for skyline r=markh
Vijay Budhram <vbudhram@mozilla.com> - Wed, 07 Aug 2019 18:07:06 +0000 - rev 486812
Push 91964 by nbeleuzu@mozilla.com at Wed, 07 Aug 2019 18:37:14 +0000
Bug 1568866 - Update send to device panel for skyline r=markh Differential Revision: https://phabricator.services.mozilla.com/D40049
338b1c471939f0a45394b3e145cd22074477fe78: Bug 1567238 - Refactor the bookmarks mirror merge triggers to do less work. r=tcsc,markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 06 Aug 2019 23:48:03 +0000 - rev 486657
Push 91858 by kcambridge@mozilla.com at Wed, 07 Aug 2019 00:10:59 +0000
Bug 1567238 - Refactor the bookmarks mirror merge triggers to do less work. r=tcsc,markh This commit reduces the number of database writes and table scans needed to merge synced bookmarks. * Remove `fetchNew{Local, Remote}Contents`. Fetching the tree already scans the table, so we can piggyback on it to fetch content info for deduping. * Store completion ops in temp tables to only update changed parts of the local tree, and remove the `mergeStates` table and views. * Replace the `itemsToMerge` view with an indexed `itemsToApply` temp table. * Replace the `updateGuidsAndSyncFlags` trigger with a `changeGuidOps` table and a `changeGuids` trigger. * Replace the `updateLocalItems` trigger with an `apply_remote_items` function to bulk upsert new and updated items. * Replace the `structureToMerge` view with an `applyNewLocalStructureOps` table that holds parents and positions for moved items, and an `applyNewLocalStructure` trigger to update them. * Remove tombstones for revived items, update change counters, and flag mirror items as merged directly in `update_local_items_in_places`, instead of indirecting through temp tables. * Don't mark items flagged for reupload as merged, since we'll write them back to the mirror after upload. * Use a scalar subquery instead of a join in the `localTags` view to look up the tags root ID. * Replace `relatedIdsToReupload` with a `Store::prepare` method that flags all bookmarks with keyword-URL mismatches for reupload. * Trigger frecency updates for origins once, not for every item. * Remove two extra scans on `itemsAdded` and `itemsChanged` when recording observer notifications for changed keywords. * Notify all `bookmark-added` listeners in a single batch. This also fixes some edge cases: * Update root positions correctly after deleting a non-syncable root or item. * Keyword-URL mismatches may reupload more items than before, but now ensure that all bookmarks with the same URL have the same keyword. * Only set items with deduped GUIDs to `SYNC_STATUS_NORMAL` after merging. * Bump the last modified time for modified items only. Differential Revision: https://phabricator.services.mozilla.com/D39889
75fb52a6d1f887a07799be573de556164cf26679: Bug 1568866 - Update send to device panel for skyline r=markh
Vijay Budhram <vbudhram@mozilla.com> - Tue, 06 Aug 2019 15:00:30 +0000 - rev 486539
Push 91784 by ccoroiu@mozilla.com at Tue, 06 Aug 2019 16:07:39 +0000
Bug 1568866 - Update send to device panel for skyline r=markh Differential Revision: https://phabricator.services.mozilla.com/D40049
11de4b3dec2b4730c34f90a6f53c7cd9f5c18597: Bug 1562328 - Add https to the img-src in the CSP to allow for displaying Sync avatars. r=MattN,markh
Jared Wein <jwein@mozilla.com> - Tue, 30 Jul 2019 22:44:46 +0000 - rev 485446
Push 91301 by jwein@mozilla.com at Tue, 30 Jul 2019 22:45:33 +0000
Bug 1562328 - Add https to the img-src in the CSP to allow for displaying Sync avatars. r=MattN,markh Differential Revision: https://phabricator.services.mozilla.com/D38737
bdc4220a693057614ba1ab251d88ff5994832848: Bug 1562328 - Hook up Sync's UIState and login sharing pref to Sync button custom element. r=MattN,fluent-reviewers,markh,Pike
Jared Wein <jwein@mozilla.com> - Tue, 30 Jul 2019 22:44:33 +0000 - rev 485444
Push 91301 by jwein@mozilla.com at Tue, 30 Jul 2019 22:45:33 +0000
Bug 1562328 - Hook up Sync's UIState and login sharing pref to Sync button custom element. r=MattN,fluent-reviewers,markh,Pike Differential Revision: https://phabricator.services.mozilla.com/D38031
98bedd1bb061e2ec8a858b11227f1f27e599d39c: Bug 1556276 p2 - Build metrics-flow and legal FxA URLs. r=markh
Edouard Oger <eoger@fastmail.com> - Thu, 25 Jul 2019 01:12:31 +0000 - rev 484162
Push 90856 by eoger@mozilla.com at Thu, 25 Jul 2019 05:11:30 +0000
Bug 1556276 p2 - Build metrics-flow and legal FxA URLs. r=markh Differential Revision: https://phabricator.services.mozilla.com/D39033
0f861296caf449d69b533e5946f6566311ba130a: Bug 1556276 p1 - Allow extraParams to be passed when constructing FxA URLs. r=markh
Edouard Oger <eoger@fastmail.com> - Wed, 24 Jul 2019 18:34:06 +0000 - rev 484161
Push 90856 by eoger@mozilla.com at Thu, 25 Jul 2019 05:11:30 +0000
Bug 1556276 p1 - Allow extraParams to be passed when constructing FxA URLs. r=markh Differential Revision: https://phabricator.services.mozilla.com/D39032
e3f6a6813aa73d4696b000275d030e615ba27725: Bug 1525161 - sync sponsored stories preference r=markh
premk <prem.kumar.krishnan@live.com> - Thu, 13 Jun 2019 00:14:54 +0000 - rev 478586
Push 87773 by mhammond@mozilla.com at Thu, 13 Jun 2019 00:15:47 +0000
Bug 1525161 - sync sponsored stories preference r=markh Differential Revision: https://phabricator.services.mozilla.com/D34739
cb797ecd262005e6713bb01dc775d89689724273: Bug 1558388 - Ensure the bookmarks mirror reports shutdown blocker state correctly. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Wed, 12 Jun 2019 03:48:31 +0000 - rev 478391
Push 87683 by kcambridge@mozilla.com at Wed, 12 Jun 2019 04:14:01 +0000
Bug 1558388 - Ensure the bookmarks mirror reports shutdown blocker state correctly. r=markh Differential Revision: https://phabricator.services.mozilla.com/D34471