searching for reviewer(markh)
cc2de07855f8455f16fb0bc950e1f5d6ed3774a0: Bug 1671170 - Downgrade smallvec to 1.3. r=markh
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 05 Dec 2020 17:12:44 +0000 - rev 559592
Push 132162 by ealvarez@mozilla.com at Sat, 05 Dec 2020 17:15:16 +0000
Bug 1671170 - Downgrade smallvec to 1.3. r=markh See https://github.com/servo/rust-smallvec/issues/243 and the PRs in the comments. Differential Revision: https://phabricator.services.mozilla.com/D98802
552acbcfb43cbf51d421f88e81e8e8ae46fdbd1b: Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
Tim Giles <tgiles@mozilla.com> - Tue, 17 Nov 2020 21:38:33 +0000 - rev 557677
Push 131190 by btara@mozilla.com at Tue, 17 Nov 2020 23:53:11 +0000
Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh Depends on D89078 Differential Revision: https://phabricator.services.mozilla.com/D91198
20a2fcd590849afe966038c9ce503dabaf2fe4a8: Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh
Tim Giles <tgiles@mozilla.com> - Tue, 17 Nov 2020 15:02:42 +0000 - rev 557585
Push 131142 by cbrindusan@mozilla.com at Tue, 17 Nov 2020 15:34:17 +0000
Bug 1613620 - Provide an option to remove all logins at once from about:logins. r=prathiksha,fluent-reviewers,sfoster,markh Depends on D89078 Differential Revision: https://phabricator.services.mozilla.com/D91198
413a70305cc689eb203f9bfb461a15415aea075c: Bug 699844 - Remove the live bookmark migrator as it is not needed now. r=mak,markh
Mark Banner <standard8@mozilla.com> - Mon, 26 Oct 2020 12:32:52 +0000 - rev 554508
Push 129419 by mbanner@mozilla.com at Mon, 26 Oct 2020 12:38:29 +0000
Bug 699844 - Remove the live bookmark migrator as it is not needed now. r=mak,markh Differential Revision: https://phabricator.services.mozilla.com/D93314
2c2fd8e25f290228865dda20a9c020c7d157809a: Bug 699844 - Remove remaining uses of bookmark annotations from Sync. r=markh
Mark Banner <standard8@mozilla.com> - Mon, 26 Oct 2020 12:32:47 +0000 - rev 554507
Push 129419 by mbanner@mozilla.com at Mon, 26 Oct 2020 12:38:29 +0000
Bug 699844 - Remove remaining uses of bookmark annotations from Sync. r=markh Differential Revision: https://phabricator.services.mozilla.com/D93313
b5b1739460ccf9e845f6499060020da5900b97b0: Bug 1670536 - reset ecosystem_client_id when the user signs out. r=chutten,markh
Ryan Kelly <rfkelly@mozilla.com> - Tue, 13 Oct 2020 20:04:51 +0000 - rev 552899
Push 128580 by rkelly@mozilla.com at Wed, 14 Oct 2020 02:47:04 +0000
Bug 1670536 - reset ecosystem_client_id when the user signs out. r=chutten,markh Differential Revision: https://phabricator.services.mozilla.com/D93188
154846e026f2849441347c30eea129d8e0179550: Bug 1668244 - Vertically aligned the sign out icon r=Itiel,markh
lougeniac64 <lougeniaC64@users.noreply.github.com> - Mon, 12 Oct 2020 16:06:53 +0000 - rev 552742
Push 128471 by lobailey@mozilla.com at Mon, 12 Oct 2020 16:47:12 +0000
Bug 1668244 - Vertically aligned the sign out icon r=Itiel,markh Differential Revision: https://phabricator.services.mozilla.com/D92283
842045716617e64f585d9d14a3f9ccb5f38989a5: Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Thu, 08 Oct 2020 02:45:00 +0000 - rev 552048
Push 128190 by rkelly@mozilla.com at Thu, 08 Oct 2020 04:49:52 +0000
Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh Differential Revision: https://phabricator.services.mozilla.com/D92319
f0cbfb83a48e2cb0c0bb8b2d3a64a8aac506f461: Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Wed, 07 Oct 2020 02:09:02 +0000 - rev 551813
Push 128078 by rkelly@mozilla.com at Wed, 07 Oct 2020 05:41:55 +0000
Bug 1647588 - Derive AET ecosystemUserId from kB when the user signs in. r=markh Differential Revision: https://phabricator.services.mozilla.com/D92319
3dea0c7bf97f4fb426e23c5b2bf62adf708bb78c: Bug 1668704 - upgrade serde to 1.0.116 so we can vendor in Nimbus SDK r=markh
Dan Mosedale <dmose@mozilla.org> - Fri, 02 Oct 2020 01:10:38 +0000 - rev 551205
Push 127736 by dmosedale@mozilla.com at Fri, 02 Oct 2020 02:17:40 +0000
Bug 1668704 - upgrade serde to 1.0.116 so we can vendor in Nimbus SDK r=markh Differential Revision: https://phabricator.services.mozilla.com/D92164
38ee4af29718884820d7a0d32ff9b601f68b4173: Bug 1661407 - refactor FxA key handling to use "scoped keys". r=markh
Ryan Kelly <rfkelly@mozilla.com> - Thu, 01 Oct 2020 10:06:24 +0000 - rev 551054
Push 127641 by rkelly@mozilla.com at Thu, 01 Oct 2020 11:10:54 +0000
Bug 1661407 - refactor FxA key handling to use "scoped keys". r=markh Differential Revision: https://phabricator.services.mozilla.com/D90361
2c30e0f255d98a08153413f0dce1166c6332b5c6: Bug 1664307 - Revise the pairing modal. r=markh,fluent-reviewers,preferences-reviewers,flod,Gijs
Edouard Oger <eoger@fastmail.com> - Fri, 11 Sep 2020 18:29:26 +0000 - rev 548371
Push 126140 by eoger@mozilla.com at Fri, 11 Sep 2020 18:33:28 +0000
Bug 1664307 - Revise the pairing modal. r=markh,fluent-reviewers,preferences-reviewers,flod,Gijs Differential Revision: https://phabricator.services.mozilla.com/D89824
416a44f9c59de1a40b59717e3ee33d1b4677b32e: Bug 1663541 - don't try to write `uid` to storage in `updateUserAccountData`. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Tue, 08 Sep 2020 01:19:56 +0000 - rev 547804
Push 125790 by rkelly@mozilla.com at Tue, 08 Sep 2020 01:22:58 +0000
Bug 1663541 - don't try to write `uid` to storage in `updateUserAccountData`. r=markh Differential Revision: https://phabricator.services.mozilla.com/D89405
b8fc2cb2dce2831bc7622a976d8dd3cd0eb965fe: Bug 1661631 - set ecosystem telemetry to disabled by default. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Fri, 28 Aug 2020 04:12:32 +0000 - rev 546738
Push 125187 by rkelly@mozilla.com at Fri, 28 Aug 2020 04:16:56 +0000
Bug 1661631 - set ecosystem telemetry to disabled by default. r=markh Differential Revision: https://phabricator.services.mozilla.com/D88525
aa2660c9edbe2666e0a54d52e667afdf40fc3423: Bug 1661475 - Add a "Manage devices" item to the Send Tab menu. r=markh
Edouard Oger <eoger@fastmail.com> - Thu, 27 Aug 2020 21:50:46 +0000 - rev 546686
Push 125168 by eoger@mozilla.com at Thu, 27 Aug 2020 21:55:39 +0000
Bug 1661475 - Add a "Manage devices" item to the Send Tab menu. r=markh Differential Revision: https://phabricator.services.mozilla.com/D88420
3078e96b71fd667a3020998ec734aebc5c4082f7: Bug 1659895 - enable the account-ecosystem ping by default. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Mon, 24 Aug 2020 00:51:02 +0000 - rev 545788
Push 124801 by rkelly@mozilla.com at Mon, 24 Aug 2020 00:57:15 +0000
Bug 1659895 - enable the account-ecosystem ping by default. r=markh This has been enabled on Nightly for a while and we've observed no ill effects; ref Bug 1635667 for work to validate that it's submitting the expected data. Differential Revision: https://phabricator.services.mozilla.com/D87979
e4fd76a13124da583ff987578ee777bea2d7c048: Bug 1657463 - Allow users to delete their data when signing out r=markh,fluent-reviewers,flod
lougeniac64 <lougeniaC64@users.noreply.github.com> - Wed, 19 Aug 2020 04:55:51 +0000 - rev 545373
Push 124541 by lobailey@mozilla.com at Wed, 19 Aug 2020 18:34:16 +0000
Bug 1657463 - Allow users to delete their data when signing out r=markh,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D86065
32c70539a91150494430d8bec3f2a68dfa1aa387: Bug 1657626 - Remove send from fxa toolbar menu r=markh
Vijay Budhram <vbudhram@mozilla.com> - Wed, 12 Aug 2020 23:26:45 +0000 - rev 544484
Push 124069 by vbudhram@mozilla.com at Thu, 13 Aug 2020 01:34:54 +0000
Bug 1657626 - Remove send from fxa toolbar menu r=markh Differential Revision: https://phabricator.services.mozilla.com/D86846
367054bd65f01d4b364b7ebc8339aa9a0601d9d0: Bug 1658242 - Enable ecosystem telemetry for Nightly users; r=markh
Ryan Kelly <rfkelly@mozilla.com> - Tue, 11 Aug 2020 02:40:55 +0000 - rev 544323
Push 123963 by rkelly@mozilla.com at Tue, 11 Aug 2020 21:11:25 +0000
Bug 1658242 - Enable ecosystem telemetry for Nightly users; r=markh Differential Revision: https://phabricator.services.mozilla.com/D86501
a82f018d47b7c82a17005523addb310b7065a970: Bug 1656947 - Vendor application-services to import fix on webext-storage component. r=markh
Luca Greco <lgreco@mozilla.com> - Mon, 10 Aug 2020 00:32:24 +0000 - rev 544081
Push 123805 by luca.greco@alcacoop.it at Mon, 10 Aug 2020 10:03:48 +0000
Bug 1656947 - Vendor application-services to import fix on webext-storage component. r=markh Differential Revision: https://phabricator.services.mozilla.com/D86487
c9e22cbde5e927cb99abb4597785bd7173a75171: Bug 1658237 - Skip test_EcosystemTelemetry.js on Thunderbird. r=markh
Geoff Lankow <geoff@darktrojan.net> - Mon, 10 Aug 2020 03:59:30 +0000 - rev 544064
Push 123789 by geoff@darktrojan.net at Mon, 10 Aug 2020 04:02:40 +0000
Bug 1658237 - Skip test_EcosystemTelemetry.js on Thunderbird. r=markh I've removed the Linux32 annotation because Firefox no longer runs tests on Linux32. Differential Revision: https://phabricator.services.mozilla.com/D86498
a3c4d47cd724ee825de3fcc729c5d78c4b4eca0b: Bug 1655390 - handle null profileCache in FxAccountsProfile.ensureProfile; r=markh
Ryan Kelly <rfkelly@mozilla.com> - Tue, 28 Jul 2020 00:20:04 +0000 - rev 542278
Push 122754 by rkelly@mozilla.com at Tue, 28 Jul 2020 00:56:47 +0000
Bug 1655390 - handle null profileCache in FxAccountsProfile.ensureProfile; r=markh Differential Revision: https://phabricator.services.mozilla.com/D84952
331e641213d5545e29a69784bb8e494cb31d7050: Bug 1635657 - synthesize placeholder ecosystemAnonId when not present on FxA server r=markh,rfkelly
lougeniac64 <lougeniaC64@users.noreply.github.com> - Mon, 27 Jul 2020 01:46:50 +0000 - rev 542232
Push 122720 by lobailey@mozilla.com at Mon, 27 Jul 2020 19:49:40 +0000
Bug 1635657 - synthesize placeholder ecosystemAnonId when not present on FxA server r=markh,rfkelly Differential Revision: https://phabricator.services.mozilla.com/D84617
67168dd1cfc4f0248a37949f0f5b0a7e28f04b52: Bug 1635656 - add support for storing and fetching FxA ecosystem telemetry ids. r=rfkelly,markh
Ryan Kelly <rfkelly@mozilla.com> - Tue, 21 Jul 2020 23:05:04 +0000 - rev 541607
Push 122363 by lobailey@mozilla.com at Wed, 22 Jul 2020 14:58:33 +0000
Bug 1635656 - add support for storing and fetching FxA ecosystem telemetry ids. r=rfkelly,markh Differential Revision: https://phabricator.services.mozilla.com/D77762
9c735f9393c992faa4b7bee47d709a647fcd9726: Bug 1639843 - Added reason field to command-received telemetry events r=markh,rfkelly
lougeniac64 <lougeniaC64@users.noreply.github.com> - Mon, 13 Jul 2020 21:46:49 +0000 - rev 540290
Push 121609 by lobailey@mozilla.com at Mon, 13 Jul 2020 22:02:14 +0000
Bug 1639843 - Added reason field to command-received telemetry events r=markh,rfkelly Differential Revision: https://phabricator.services.mozilla.com/D82096
24acc23d72b096365ead8733169948e12e5bd3fb: Bug 1642556 - Write a sync log after sending a tab. r=markh
Vlad Filippov <vlad.filippov@gmail.com> - Tue, 30 Jun 2020 14:29:11 +0000 - rev 538031
Push 120361 by vlad@vladikoff.com at Tue, 30 Jun 2020 14:37:03 +0000
Bug 1642556 - Write a sync log after sending a tab. r=markh Differential Revision: https://phabricator.services.mozilla.com/D81191
1045c703cba0a251dda0fa89e9e1410e02c66a79: Bug 1642855 - remove flowID from plaintext send-tab payload. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Wed, 24 Jun 2020 16:37:31 +0000 - rev 537912
Push 120291 by rkelly@mozilla.com at Tue, 30 Jun 2020 02:55:58 +0000
Bug 1642855 - remove flowID from plaintext send-tab payload. r=markh Differential Revision: https://phabricator.services.mozilla.com/D80793
0f3b01e74838a500cd7114f27f5e78ad55964a4e: Bug 1642556 - Write a sync log after sending a tab. r=markh
Vlad Filippov <vlad.filippov@gmail.com> - Tue, 30 Jun 2020 01:55:09 +0000 - rev 537906
Push 120288 by vlad@vladikoff.com at Tue, 30 Jun 2020 02:52:50 +0000
Bug 1642556 - Write a sync log after sending a tab. r=markh Differential Revision: https://phabricator.services.mozilla.com/D81191
df0a1af35e2324952ca57edbdbd443502c652044: (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
lougeniac64 <lougeniaC64@users.noreply.github.com> - Sat, 27 Jun 2020 19:15:17 +0000 - rev 537732
Push 120188 by kcambridge@mozilla.com at Sat, 27 Jun 2020 19:17:41 +0000
(Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh Differential Revision: https://phabricator.services.mozilla.com/D80975
8cd7fabbe2703b2c2a70b3139f0cc2a4cb6621b6: (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
lougeniac64 <lougeniaC64@users.noreply.github.com> - Sat, 27 Jun 2020 06:26:22 +0000 - rev 537702
Push 120175 by kcambridge@mozilla.com at Sat, 27 Jun 2020 06:27:13 +0000
(Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh Differential Revision: https://phabricator.services.mozilla.com/D80975
fec02fef5e73cf4e56373bb830e8591647f192ca: (Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh
lougeniac64 <lougeniaC64@users.noreply.github.com> - Fri, 26 Jun 2020 21:19:17 +0000 - rev 537679
Push 120159 by kcambridge@mozilla.com at Fri, 26 Jun 2020 23:46:43 +0000
(Bug 1635487) Wired up sync logging for extension pref storage r=lina,markh Differential Revision: https://phabricator.services.mozilla.com/D80975
1bc0f8673080236da0c0e046b483cbcc87aa9fa9: Bug 1645267 - should use a lazy getter for the logger in browser-sync. r=markh
Vlad Filippov <vlad.filippov@gmail.com> - Tue, 16 Jun 2020 14:02:10 +0000 - rev 535876
Push 119120 by vlad@vladikoff.com at Tue, 16 Jun 2020 14:05:14 +0000
Bug 1645267 - should use a lazy getter for the logger in browser-sync. r=markh Differential Revision: https://phabricator.services.mozilla.com/D79776
03e3995a8488558ddeaa9ff0f54bc4f948df66b8: Bug 1611058 - Do not fallback to old SendTab if new SendTab fails. r=rfkelly,markh
Vlad Filippov <vlad.filippov@gmail.com> - Thu, 11 Jun 2020 19:51:03 +0000 - rev 535193
Push 118798 by vlad@vladikoff.com at Thu, 11 Jun 2020 21:06:29 +0000
Bug 1611058 - Do not fallback to old SendTab if new SendTab fails. r=rfkelly,markh Differential Revision: https://phabricator.services.mozilla.com/D78807
89b2ab5018a8c1482e46d9f709da604cf6574370: Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r=markh
Thom Chiovoloni <tchiovoloni@mozilla.com> - Fri, 05 Jun 2020 01:10:10 +0000 - rev 534074
Push 118124 by tchiovoloni@mozilla.com at Fri, 05 Jun 2020 02:27:05 +0000
Bug 1629116 - Add an overrideTelemetryName to bridged extension storage. r=markh Add an overrideTelemetryName to bridged extension storage. Differential Revision: https://phabricator.services.mozilla.com/D78413
546ec17e41dbbca5fc7e79db2c5a103cc393eacb: Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Mon, 01 Jun 2020 06:07:51 +0000 - rev 533192
Push 117639 by kcambridge@mozilla.com at Mon, 01 Jun 2020 06:13:17 +0000
Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh This new method fetches pending synced changes from the extension storage store, and passes them to `storage.onChanged` listeners. This allows extensions that listen for these events to know when a sync happened, which Kinto supported as well. To guard against misuse, this method is implemented on a separate `mozISyncedExtensionStorageArea` interface. To avoid multiple inheritance (if `mozI{Synced, Configurable}ExtensionStorageArea` both inherited from `mozIExtensionStorageArea`, which base method is called when?), both of these internal-ish interfaces now inherit from `nsISupports` instead. Finally, because `fetchPendingSyncChanges` can return changes for multiple extensions, `mozIExtensionStorageListener.onChanged` now takes the affected extension ID as its first argument. Differential Revision: https://phabricator.services.mozilla.com/D76976
d6c79e77d6b99d99ca48b446a6b3c375bbcad6d0: Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Mon, 01 Jun 2020 00:54:27 +0000 - rev 533177
Push 117628 by mhammond@mozilla.com at Mon, 01 Jun 2020 00:55:30 +0000
Bug 1641005 - Implement `mozISyncedExtensionStorageArea.fetchPendingSyncChanges()`. r=markh This new method fetches pending synced changes from the extension storage store, and passes them to `storage.onChanged` listeners. This allows extensions that listen for these events to know when a sync happened, which Kinto supported as well. To guard against misuse, this method is implemented on a separate `mozISyncedExtensionStorageArea` interface. To avoid multiple inheritance (if `mozI{Synced, Configurable}ExtensionStorageArea` both inherited from `mozIExtensionStorageArea`, which base method is called when?), both of these internal-ish interfaces now inherit from `nsISupports` instead. Finally, because `fetchPendingSyncChanges` can return changes for multiple extensions, `mozIExtensionStorageListener.onChanged` now takes the affected extension ID as its first argument. Differential Revision: https://phabricator.services.mozilla.com/D76976
442f8bd2e723e114e5b507ab4496dd6c2a32b233: Bug 1640528 - Allow extension storage to be enabled and disabled independently of add-ons. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Mon, 25 May 2020 01:12:16 +0000 - rev 531838
Push 116909 by mhammond@mozilla.com at Mon, 25 May 2020 01:13:24 +0000
Bug 1640528 - Allow extension storage to be enabled and disabled independently of add-ons. r=markh By default, toggling the add-ons engine also toggles extension storage. However, it's also possible to enable extension storage without add-ons by setting an override pref. If the override pref is set, we'll treat extension storage as an engine that can be toggled independently. If it's not set, we'll ignore attempts to toggle the engine separately. Differential Revision: https://phabricator.services.mozilla.com/D76635
106dc3f2e4417b54693cb4c447c4a5b50c32092a: Bug 1639727 - Fix `trackRemainingChanges` in the tabs and prefs Sync engines. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Thu, 21 May 2020 07:13:12 +0000 - rev 531405
Push 116630 by kcambridge@mozilla.com at Thu, 21 May 2020 07:14:37 +0000
Bug 1639727 - Fix `trackRemainingChanges` in the tabs and prefs Sync engines. r=markh This commit fixes two issues: moves `trackRemainingChanges` to the engine, since that's where it defined (not on the store), and skips setting `modified` if all records have been successfully uploaded. Differential Revision: https://phabricator.services.mozilla.com/D76270
d3c89deff8e52d8f0ceda7bb16994902e0e53bca: Bug 1638557 - Remove the `MOZ_NEW_WEBEXT_STORAGE` build flag. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 19 May 2020 00:48:03 +0000 - rev 530736
Push 116340 by kcambridge@mozilla.com at Tue, 19 May 2020 01:32:25 +0000
Bug 1638557 - Remove the `MOZ_NEW_WEBEXT_STORAGE` build flag. r=markh Now that we've landed all the pieces for Rust `storage.sync`, and intend to ship it for everyone in 78, we don't need to hide it behind a build flag. Setting the `webextensions.storage.sync.kinto` pref to false toggles the new Rust backend at runtime. Differential Revision: https://phabricator.services.mozilla.com/D75872
5eb88ab60051972d8f799c75cf38e7dbe52d948f: Bug 1636792 - Rename `StorageOp` to `Punt` for consistency with FxA. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 19 May 2020 00:48:57 +0000 - rev 530735
Push 116339 by kcambridge@mozilla.com at Tue, 19 May 2020 01:31:25 +0000
Bug 1636792 - Rename `StorageOp` to `Punt` for consistency with FxA. r=markh Differential Revision: https://phabricator.services.mozilla.com/D75869
caf0bbf24490b0e0ebb7c080beb5b0c4662948d6: Bug 1487529 - Don't sync addons prevented by policy. r=markh
Michael Kaply <mozilla@kaply.com> - Wed, 13 May 2020 17:13:23 +0000 - rev 529683
Push 115845 by mozilla@kaply.com at Wed, 13 May 2020 18:45:20 +0000
Bug 1487529 - Don't sync addons prevented by policy. r=markh Differential Revision: https://phabricator.services.mozilla.com/D74889
86a1d0814d033b37f20480330d4f1beda993e82d: Bug 1636365 - Add more docs for `BridgedEngine`, and remove `BridgedTracker`. r=markh,rfkelly
Lina Cambridge <lina@yakshaving.ninja> - Wed, 13 May 2020 03:56:55 +0000 - rev 529553
Push 115767 by kcambridge@mozilla.com at Wed, 13 May 2020 05:04:37 +0000
Bug 1636365 - Add more docs for `BridgedEngine`, and remove `BridgedTracker`. r=markh,rfkelly Now that we have a `Tracker` base class without persistence, we can have bridged engines subclass it directly. Differential Revision: https://phabricator.services.mozilla.com/D74375
40d980163482d1966828d74ee9d648e6de596c84: Bug 1636365 - Split out persistence from `Tracker` into `LegacyTracker`. r=markh,rfkelly
Lina Cambridge <lina@yakshaving.ninja> - Wed, 13 May 2020 03:56:53 +0000 - rev 529552
Push 115767 by kcambridge@mozilla.com at Wed, 13 May 2020 05:04:37 +0000
Bug 1636365 - Split out persistence from `Tracker` into `LegacyTracker`. r=markh,rfkelly The tracker base class currently does two things: bump the score in response to observer notifications, and store a list of changed IDs. The bookmarks, form autofill, and now bridged trackers need to hack around this to opt out of persistence, since they handle change tracking in the storage layer. This commit keeps the score logic in `Tracker`, but moves all the persistence code into an intermediate `LegacyTracker` class, and changes all engines that need persistence to inherit from it. `ignoreAll` is more interesting. We want new-style stores to emit observer notifications with change sources, so that the tracker knows to ignore changes made by Sync. Ignoring all observer notifications during a sync is a blunter version of this. But, not every new store supports change sources, so we reimplement `ignoreAll` manually for ones that don't. Differential Revision: https://phabricator.services.mozilla.com/D74374
be02f68833f2b2d97dddcc2f09d90fb7028be215: Bug 804479 - Re-enable all Sync tests on debug builds. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 12 May 2020 22:10:03 +0000 - rev 529491
Push 115738 by kcambridge@mozilla.com at Tue, 12 May 2020 22:11:10 +0000
Bug 804479 - Re-enable all Sync tests on debug builds. r=markh Differential Revision: https://phabricator.services.mozilla.com/D74980
f603312246a6441b793d6450cc9ca8e8bb043ded: Bug 1636053 - correctly include deviceID in the sync ping. r=markh
Ryan Kelly <rfkelly@mozilla.com> - Thu, 07 May 2020 10:47:24 +0000 - rev 528609
Push 115204 by rkelly@mozilla.com at Thu, 07 May 2020 10:48:52 +0000
Bug 1636053 - correctly include deviceID in the sync ping. r=markh Differential Revision: https://phabricator.services.mozilla.com/D74217
aec4fe84eabf6c595a883dcd64370a66f55acffe: Bug 1634191 - Wire up Golden Gate to the new Rust extension storage interface. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Tue, 05 May 2020 06:59:32 +0000 - rev 528038
Push 114931 by kcambridge@mozilla.com at Tue, 05 May 2020 07:00:59 +0000
Bug 1634191 - Wire up Golden Gate to the new Rust extension storage interface. r=markh This commit adds syncing support to the `StorageSyncArea` class, via the Golden Gate library. It also changes the `BridgedEngine` trait: `initialize` and `finalize` haven't been useful in practice, since that's managed by the storage service, and the `LazyStore` takes care of setting up the storage connection on first use. But, what we do need is a way to signal a sync is starting, so that the engine can set up temp tables. That's handled by the new `sync_started`. Finally, this commit changes `BridgedEngine::set_uploaded` to take a `sync15_traits::Guid` instead of a `String`. Differential Revision: https://phabricator.services.mozilla.com/D73415
56ce8aa215c0e73a630155730fd51cfaef3a336c: Bug 1632734 - refactor FxAccounts.device public methods to use `withCurrentAccountState`. r=eoger,markh
Ryan Kelly <rfkelly@mozilla.com> - Mon, 04 May 2020 02:48:20 +0000 - rev 528021
Push 114923 by rkelly@mozilla.com at Tue, 05 May 2020 02:12:58 +0000
Bug 1632734 - refactor FxAccounts.device public methods to use `withCurrentAccountState`. r=eoger,markh Differential Revision: https://phabricator.services.mozilla.com/D73011
427d247d7c2f9b10c48b5f5714613b6489d0bbd4: Bug 1634191 - Pass BSO fields along with Sync record payloads to bridged Rust engines. r=markh
Lina Cambridge <lina@yakshaving.ninja> - Mon, 04 May 2020 22:25:00 +0000 - rev 528012
Push 114914 by kcambridge@mozilla.com at Mon, 04 May 2020 22:26:54 +0000
Bug 1634191 - Pass BSO fields along with Sync record payloads to bridged Rust engines. r=markh This commit splits `CryptoWrapper` into a base `RawCryptoWrapper` class, which only handles encryption and decryption without parsing the cleartext's contents, and the existing `CryptoWrapper` class, which works like before. Our bridged engine subclasses `RawCryptoWrapper`, and implements some methods to convert records to and from envelopes. Envelopes are a concept we introduced in `sync15_traits` to pass along metadata from the BSO wrapper (like the modified time from the server, and ID, to ensure they match) in addition to the cleartext. This lets us reuse `sync15_traits::Payload` to parse record payloads in Rust, and avoids parsing the cleartext in JS, only to stringify it again when we pass it to the bridged Rust engine. Differential Revision: https://phabricator.services.mozilla.com/D73581
55299ca145f36448b0084ff2d65d7cc4ee24e845: Bug 1634626 - Add interrupt support for `StorageSyncArea`. r=markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 04 May 2020 21:32:52 +0000 - rev 528004
Push 114906 by kcambridge@mozilla.com at Mon, 04 May 2020 21:53:29 +0000
Bug 1634626 - Add interrupt support for `StorageSyncArea`. r=markh,tcsc This commit adds a `mozIInterruptible` implementation to `StorageSyncArea`, and changes `LazyStore` to get an a-s interrupt handle and interrupt pending operations. Differential Revision: https://phabricator.services.mozilla.com/D73414
21428ee332e8cfe90b15ff820ff3eb047c1d618c: Bug 1634626 - Refactor interruption in Golden Gate. r=markh,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Mon, 04 May 2020 21:32:29 +0000 - rev 528003
Push 114906 by kcambridge@mozilla.com at Mon, 04 May 2020 21:53:29 +0000
Bug 1634626 - Refactor interruption in Golden Gate. r=markh,tcsc This commit removes the `nsICancelable` return values from all `mozIBridgedSyncEngine` methods, and replaces them with a `mozIInterruptible` interface that can be implemented by store classes that support interrupting. The `nsICancelable` pattern was intended to make each operation interruptible, without affecting the others. But we can't guarantee that with SQLite, because it only has a way to interrupt all running statements on a connection, not specific ones. Further, this pattern doesn't match what we currently do in a-s, where we create an internal "interrupt scope" for each operation, and hand out an "interrupt handle" for interrupting all in-progress operations. Storage classes like `StorageSyncArea` can opt in to interruption by implementing `mozIInterruptible`. It's a separate interface to protect against accidental misuse: because it interrupts all statements on the connection, it might lose writes if the current operation is a `set`, for example. But it's useful for testing and debugging, so we still expose it. This commit also changes Golden Gate ferries to hold weak references to the `BridgedEngine`, so that they don't block teardown. Differential Revision: https://phabricator.services.mozilla.com/D73413