Bug 1813505 - Make browser_view_selectionByMouse.js work with the result menu button. r=mak Differential Revision: https://phabricator.services.mozilla.com/D168242

Bug 1801871 - Update Bookmark Star panel to use editBookmark.js r=mak,Standard8 Enable delayed apply logic for the star panel. Refactor some existing code using async/await rather than `catch()` everywhere. https://treeherder.mozilla.org/jobs?revision=fb6ba9ef08f132c72b6c2918067fc3db54a94650&repo=try Differential Revision: https://phabricator.services.mozilla.com/D166237

Bug 1813155 - Quick suggest provider should not be active for search strings that contain only spaces. r=mak I broke this in D167218. We didn't have a test for it. Differential Revision: https://phabricator.services.mozilla.com/D168139

Bug 1811870 - Enable urlbar result menu in Nightly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D167693

Bug 1813117 - Add comment to BrowserGlue about the removed migration 134. r=mak DONTBUILD This is a follow up to D167889. See https://phabricator.services.mozilla.com/D167889#5529599 Differential Revision: https://phabricator.services.mozilla.com/D168124

Bug 1801299 - Fix outside click behavior for the urlbar result menu. r=mak Differential Revision: https://phabricator.services.mozilla.com/D167919

Bug 1808932: Take abandonment event even when closing the result view while the input does not have focus. r=mak Differential Revision: https://phabricator.services.mozilla.com/D167641

Bug 1812410 - reinstate Micah Tigley as peer/owner for downloads/PiP, r=mhowell,mak,zeid DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D167856

Bug 1706933: When sync removes a bookmark with a keyword, should also remove the keyword if necessary r=mak,lina Differential Revision: https://phabricator.services.mozilla.com/D167333

Bug 1811870 - Enable urlbar result menu in Nightly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D167693

Bug 1791657: Show page title if it is in places. r=adw,mak Depends on D159243 Differential Revision: https://phabricator.services.mozilla.com/D157891

Bug 1811870 - Enable urlbar result menu in Nightly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D167693

Bug 1808768 - Bookmarks manager shows duplicate tags in the input field r=mak Query the database for the deduped set of tags. Similar to the logic used in `instantEditBookmark.js`. Differential Revision: https://phabricator.services.mozilla.com/D167195

Bug 1810647 - Prepare for enable urlbar result menu in Nightly. r=mak,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D167004

Bug 1808918, use Untitled as the default filename when saving a file rather than index, r=mak Differential Revision: https://phabricator.services.mozilla.com/D167028

Bug 1806007: Introduce engagementTelemetry subdir. r=adw,mak Differential Revision: https://phabricator.services.mozilla.com/D166020

Bug 1804411 - Downloads panel animations should honour prefers-reduced-motion settings. r=sfoster,mak Differential Revision: https://phabricator.services.mozilla.com/D166444

Bug 1803089 - do a better job displaying useful info for data/blob URLs in the download helper app dialog, r=mak Differential Revision: https://phabricator.services.mozilla.com/D166781

Bug 1803089 - do a better job displaying useful info for data/blob URLs in the download helper app dialog, r=mak Differential Revision: https://phabricator.services.mozilla.com/D166781

Bug 1779400 - Let omnibox API work in private windows r=mak Differential Revision: https://phabricator.services.mozilla.com/D166681

Bug 1808915: Remove snapshots and session manager functionality. r=Standard8,mak Differential Revision: https://phabricator.services.mozilla.com/D166519

Bug 1802885, improve filename sanitization when filename begins with a period, r=mak Differential Revision: https://phabricator.services.mozilla.com/D165466

Bug 1801869 - Update Bookmarks Library panel to use editBookmark.js r=mak Ensure that we can safely load `editBookmark.js` as the `gEditItemOverlay` instance without breaking the library panel. As the library does not currently support OK/Cancel operation, this does not perform any "delayed apply" logic, we simply save on blur as usual. The tricky part was getting bulk tagging to work. With the current design of the `BookmarkState` class, it only supports modifying a **single** bookmark, and it will break when trying to add a tag to multiple bookmarks at once. This is where we left off with the previous revision... I believe in this case, it makes sense to simply revert back to the logic we had in `instantEditBookmark.js` to perform the bulk tag operation. https://treeherder.mozilla.org/jobs?repo=try&revision=a1f58a770b16edd519da6e0d55e2f3c529d8f8de Differential Revision: https://phabricator.services.mozilla.com/D164250

Bug 1808718 - fix about:logging module wrapping so it doesn't become unusable with too many log modules, r=mak Differential Revision: https://phabricator.services.mozilla.com/D166080

Bug 1790026 - Add test for urlbar result menu on search engine historical suggestions. r=mak Differential Revision: https://phabricator.services.mozilla.com/D165863

Bug 1805225 - Fix browser_pdfjs_preview.js timeout failure on devedition builds. r=mak Differential Revision: https://phabricator.services.mozilla.com/D165681

Bug 1807664: Enable quickactions oneoff button explicitly. r=mak Differential Revision: https://phabricator.services.mozilla.com/D165575

Bug 1807250: Support tip_persist type. r=mak Differential Revision: https://phabricator.services.mozilla.com/D165540

Bug 1806524: Add links of telemetry doc built from metrics.yaml to telemetry.rst r=adw,mak Differential Revision: https://phabricator.services.mozilla.com/D165378

Bug 1806524: Add more descriptions for the telemetry. r=mak Differential Revision: https://phabricator.services.mozilla.com/D165377

Bug 1806491 - Add urlbar result menu for history suggestions. r=mak,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D165061

Bug 1781090 - avoid updating the download icon for hidden windows, r=florian,mak Differential Revision: https://phabricator.services.mozilla.com/D152658

Bug 1806306 - Convert AsyncShutdown imports to direct ES imports. r=mak,webdriver-reviewers,application-update-reviewers,bytesized Differential Revision: https://phabricator.services.mozilla.com/D164981

Bug 1806306 - Convert AsyncShutdown modules to ES modules. r=mak Differential Revision: https://phabricator.services.mozilla.com/D164980

Bug 1805717: Introduce search_mode property. r=mak,jteow Differential Revision: https://phabricator.services.mozilla.com/D164794

Bug 1805717: Introduce search_mode property. r=mak,jteow Differential Revision: https://phabricator.services.mozilla.com/D164794

Bug 1804314: Introduce persisted_search_terms_* interaction type. r=mak,jteow Differential Revision: https://phabricator.services.mozilla.com/D163803

Bug 1804314: Introduce persisted_search_terms_* interaction type. r=mak,jteow Differential Revision: https://phabricator.services.mozilla.com/D163803

Bug 1805678 - clean up cruft in browserPlacesViews, r=mak `.footer` is no longer used on extraClasses, so I got rid of that. I simplified the `.entry` bits because they were unnecessarily verbose. Honestly I think we may be able to remove the getter/setter for `options` entirely, but I got bored of trying to modernize things... PlacesPanelMenuView was introduced in bug 963095 and then replaced as part of Photon (with PlacesPanelview) and then I removed the only callsite (that was already behind a pref) in bug 1354117, so that was just dead code, AFAICT, so I removed it. Differential Revision: https://phabricator.services.mozilla.com/D164757

Bug 1805678 - ensure bookmark menu button submenus don't reuse root/view element references, r=mak Only the bookmarks menu button is doing this peculiar re-using of options. I tried various fixes: keeping the inheritance but replacing only the rootElt/viewElt (and using Object.assign to clone the options so modifications don't 'transmit' to the ancestor menus) but it was messy and net code increase for a pretty crufty UI surface. I also wasn't sure if that would end up negatively influencing (now or in the future) e.g. menus shown from the main bookmarks toolbar view (which would show up as a 'parent' view for the menus we open from there), and thought that reusing the options was likely to cause further confusion in future as well, should we add more, uh, options, to them. So in the end I stuck with Keeping It Simple - I just repeat the one-off repeating entry class. I'm not even sure how needed this is - in particular, I wonder why we don't need it for other submenus for 'real' bookmark folders! But I didn't investigate this too much. If you're sure that we can get rid of some more of it, happy to do that in a followup. Note that the addition of _init() was not ultimmately needed to fix this bug (I think), but it brought the initialization sequence and when we set `_placesView` more in line with what we did before and what I already did for `PlacesToolbar`, so that seemed like a good thing to avoid further/other issues. Differential Revision: https://phabricator.services.mozilla.com/D164756

Bug 1805678 - clean up cruft in browserPlacesViews, r=mak `.footer` is no longer used on extraClasses, so I got rid of that. I simplified the `.entry` bits because they were unnecessarily verbose. Honestly I think we may be able to remove the getter/setter for `options` entirely, but I got bored of trying to modernize things... PlacesPanelMenuView was introduced in bug 963095 and then replaced as part of Photon (with PlacesPanelview) and then I removed the only callsite (that was already behind a pref) in bug 1354117, so that was just dead code, AFAICT, so I removed it. Differential Revision: https://phabricator.services.mozilla.com/D164757

Bug 1805678 - ensure bookmark menu button submenus don't reuse root/view element references, r=mak Only the bookmarks menu button is doing this peculiar re-using of options. I tried various fixes: keeping the inheritance but replacing only the rootElt/viewElt (and using Object.assign to clone the options so modifications don't 'transmit' to the ancestor menus) but it was messy and net code increase for a pretty crufty UI surface. I also wasn't sure if that would end up negatively influencing (now or in the future) e.g. menus shown from the main bookmarks toolbar view (which would show up as a 'parent' view for the menus we open from there), and thought that reusing the options was likely to cause further confusion in future as well, should we add more, uh, options, to them. So in the end I stuck with Keeping It Simple - I just repeat the one-off repeating entry class. I'm not even sure how needed this is - in particular, I wonder why we don't need it for other submenus for 'real' bookmark folders! But I didn't investigate this too much. If you're sure that we can get rid of some more of it, happy to do that in a followup. Note that the addition of _init() was not ultimmately needed to fix this bug (I think), but it brought the initialization sequence and when we set `_placesView` more in line with what we did before and what I already did for `PlacesToolbar`, so that seemed like a good thing to avoid further/other issues. Differential Revision: https://phabricator.services.mozilla.com/D164756

Bug 1804561: Handle the interaction type 'refined' as a subset of 'returned'. r=mak Differential Revision: https://phabricator.services.mozilla.com/D164180

Bug 1795687 - disallow opening content prefs in shutdown, r=mak This prevents the issue described in the bug in two ways: - avoid attempting to start a connection in shutdown - call connection.close() even if we fail to add a shutdown blocker. It does both because if we did only the first, we would still have a potential race where when _getConnection is called, we would not be in shutdown, but by the time we try to close the connection, we could be. If we only did the second, we'd keep retrying which is also bad. Differential Revision: https://phabricator.services.mozilla.com/D163225

Bug 1803800 - load browserPlacesViews.js only once and immediately from browser scripts, r=mak,florian,Standard8 Unfortunately lazy script getters load the file once for each accessed symbol, which redeclares "let" and "const" and "class" variables, which was a problem here. But also, loading the file multiple times is bad for performance (it is not a module so we actually reload it) and the "lazy" variables get dereferenced immediately from markup that is present both in browser.xhtml and the hidden window on macOS, so I doubt lazy loading was getting us anything performance-wise. This patch simplifies things by 'just' loading the file from the markup. Differential Revision: https://phabricator.services.mozilla.com/D163934

Bug 1803800, r=mak Differential Revision: https://phabricator.services.mozilla.com/D163933

Bug 1803800, r=mak Differential Revision: https://phabricator.services.mozilla.com/D163932

Bug 1657551 - Part 6: Have a static ConcurrentStatementsHolder::Create function that handles errors returned from mozIStorageConnection::AsyncClone and transform some MOZ_ASSERT into NS_ENSURE_SUCCESS. r=mak Depends on D163050 Differential Revision: https://phabricator.services.mozilla.com/D163083

Bug 1804520 - Stop using the callback argument for SearchSuggestionController. r=mak Differential Revision: https://phabricator.services.mozilla.com/D164116

Bug 1803767: Enable needed quickactions prefs. r=mak Differential Revision: https://phabricator.services.mozilla.com/D163800