Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak Differential Revision: https://phabricator.services.mozilla.com/D32669

Bug 1552547 part 2. Stop using [array] in mozIStorageBindingParams. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31659

Bug 1552547 part 1. Stop using [array] in mozIStorageAsyncConnection.executeAsync. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31658

Bug 1551779 part 6. Stop using [array] for replaceFaviconData. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31243

Bug 1551779 part 5. Stop using [array] for getTagsForURI. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31242

Bug 1551779 part 4. Stop using [array] for getItemAnnotationNames. r=mak The old code used variants with SetAsAUTF8String, which would get converted to a string when going into JS. We can just use Array<AUTF8String> directly instead. C++ callers would need to change, but there aren't any. Differential Revision: https://phabricator.services.mozilla.com/D31241

Bug 1551779 part 3. Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31239

Bug 1551779 part 2. Stop using [array] for get/setParents in nsINavHistoryService. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31238

Bug 1551779 part 1. Stop using [array] for get/setTransitions in nsINavHistoryService. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31237

Bug 1552106 - Remove obsolete display and vertical-align properties from urlbarView row children. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31400

Bug 1551834 - Move legacy autocomplete attributes from shared browser.xul markup to the legacy-urlbar binding. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31227

Bug 1515589 - Implement newlines="stripsurroundingwhitespace" behavior directly in UrlbarInput. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31064

Bug 1485288 - Fix intermittent browser/base/content/test/urlbar/browser_urlbarStop.js by waiting for URLBarSetURI to be called by using a progress listener. r=mak When the load is stopped, tabbrowser calls URLBarSetURI [1] and then calls onStateChange [2] on its progress listeners. That's the URLBarSetURI call that updates the urlbar value in this case. So to properly wait until the urlbar value has been updated, add our own progress listener in the test. [1] https://searchfox.org/mozilla-central/rev/cc280c4be94ff8cf64a27cc9b3d6831ffa49fa45/browser/base/content/tabbrowser.js#5036 [2] https://searchfox.org/mozilla-central/rev/cc280c4be94ff8cf64a27cc9b3d6831ffa49fa45/browser/base/content/tabbrowser.js#5071 Differential Revision: https://phabricator.services.mozilla.com/D31018

Bug 1551102. Stop using [array] in nsIContentPrefService2. r=mak Though maybe we should just remove getCachedBySubdomainAndName, given that it's only used in tests? Differential Revision: https://phabricator.services.mozilla.com/D30834

Bug 1550423 - When a result's title or URL overflows, expose the full value in a tooltip. r=mak Differential Revision: https://phabricator.services.mozilla.com/D30470

Bug 1550036 - UrlbarView should ignore vertical overflow events when applying the fade-out effect. r=mak Differential Revision: https://phabricator.services.mozilla.com/D30381

Bug 1543041 - Port bug 1355073 to quantumbar. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29838

Bug 1545742 - Quantumbar: Remove the proper nsIController on uninit and customize start so that left/right arrow and home/end keys work after exiting customize mode. r=mak When UrlbarInput.uninit is called after customize mode ends, uninit calls this.inputField.controllers.removeControllerAt(0), which is supposed to remove the input's CopyCutController inserted in the constructor. But the controller at index 0 at that point is not the CopyCutController. Instead it's some built-in controller that supports these commands (at least these): cmd_charPrevious, cmd_charPrevious, cmd_beginLine, cmd_endLine. (Verified by adding logging to nsXULControllers::GetControllerForCommand.) That's why arrow left/right and home/end don't work after ending customize mode. The problem is that this.inputField.controllers in the constructor and this.inputField.controllers in uninit (when customize mode ends) are not the same. I wasn't able to track down why, but I'm guessing that the textbox or something in its state is being reset or cloned when customized mode ends or maybe right after it starts. The CopyCutController isn't in the controllers array at all on uninit. (Verified by adding support for cmd_adw and iterating through the controllers array, looking for a controller supporting cmd_adw.) Note that urlbarBindings.xml has a try-catch around removeController(), I'm guessing for what turns out to be this reason: https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/browser/base/content/urlbarBindings.xml#190 However, CopyCutController *is* in the controllers array when customize mode starts. So I added a new gURLBarHandler.customizeStart method that calls a new UrlbarInput.removeCopyCutController method. Other things I tried or thought of doing: Call gURLBarHandler._reset on customize start instead of end. Problem with that is that the UrlbarInput ends up getting immediately recreated because some other parts of the browser access gURLBar at that time. (Of course I replaced the `gURLBar = this.urlbar` assignment in _reset with another lazy getter definition.) Just don't worry about removing CopyCutController at all. That seems bad because then we'd leak it, unless the controller is removed or the controllers array is emptied at some point by XUL, and I'm not at all certain about that. (Although I guess this is effectively what awesomebar does, given the link above!) Differential Revision: https://phabricator.services.mozilla.com/D29613

Bug 1546035 - Remove local and remote livemarks when syncing. r=mak,tcsc This commit exports livemarks before syncing for the first time, to avoid losing livemarks that Sync may have resurrected. As of v0.2.4, Dogear treats livemarks as non-syncable, and deletes them on both sides. This also bumps the mirror schema version, to trigger a first sync. Differential Revision: https://phabricator.services.mozilla.com/D28543

Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak This test uncovered a couple of problems: (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key. handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event. So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys. (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results. It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433 Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled. Differential Revision: https://phabricator.services.mozilla.com/D29300

Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak This test uncovered a couple of problems: (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key. handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event. So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys. (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results. It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433 Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled. Differential Revision: https://phabricator.services.mozilla.com/D29300

Bug 1544443 - Upgrade to SQLite 3.28.0. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29379

Bug 1544030 - Fix quantumbar popup's vertical borders and position on Mac once again. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29340

Bug 1547801 - Correctly handle case-insensitive matching in tag queries for international strings. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29334

Bug 1545394 - Keep stale rows in the view while receiving new results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D28049

Bug 1545200 - Squelch spurious synchronous operation warnings in `Connection::operationSupported`. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27959

Bug 1524550 - Remove UrlbarQueryContext's lastKey property. r=mak This assumes that the current direction in bug 1522278 is the one we want, which it's looking like it is. Differential Revision: https://phabricator.services.mozilla.com/D27854

Bug 1522278 - Use nsIEditActionListener to detect when the user deletes autofilled substrings. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27637

Bug 1543661 - Instead of rounding to integer, use more precision when setting px values. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27390

Bug 1541929 - Don't autofill the first result in some cases. r=mak We need to handle autofilling the first result separately from autofilling results in general (which happens in UrlbarInput.setValueFromResult), so add a new UrlbarInput.autofillFirstResult method. The controller calls it instead of setValueFromResult. I ported the logic from nsAutoCompleteController, as described in the bug. Other changes are related to the new test for this. As part of this work, I was interested in learning how awesomebar handles browser_autoFill_typed.js, so I added it to the legacy tests, with a small tweak in the test for awesomebar. Differential Revision: https://phabricator.services.mozilla.com/D26852

Bug 1544002 - nsNavHistoryResult::mRefreshParticipants should participate in cycle collection. r=mak It is an array of cycle collected objects. Differential Revision: https://phabricator.services.mozilla.com/D27337

Bug 1525548 - Centralise closing the address bar popup into the head file for urlbar tests. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26759

Bug 1541924 - Enforce that BookmarkJSONUtils.importFromURL can only be used with chrome and file URLs. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26921

Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26192

Bug 1543295 - Pass the text length when creating an `nsString` from a SQLite text result. r=mak This commit updates mozStorage to always: * Pass the length, using sqlite3_{column, value}_bytes16, when creating an nsDependentString from a pointer. * Call sqlite3_{column, value}_bytes{16} after sqlite3_{column, value}_{text, blob, text16}, per the recommendation in https://www.sqlite.org/c3ref/column_blob.html. Some callers did this before, or in unclear order, since C++ doesn't specify one for evaluating function arguments. * Pass the byte length to sqlite3_result_text16. Differential Revision: https://phabricator.services.mozilla.com/D26848

Bug 1542990 - Use "Toolkit :: Storage" for kvstore bugs. DONTBUILD r=mak,myk Differential Revision: https://phabricator.services.mozilla.com/D26657

Bug 1536508 - Generate a mouseover as well as a mouseout to avoid issues in devedition with browser_UrlbarInput_tooltip.js. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26531

Bug 1533054 - Add tests for selection key navigation: up/down, page-up/down, tab r=mak Differential Revision: https://phabricator.services.mozilla.com/D25901

Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak Differential Revision: https://phabricator.services.mozilla.com/D24910

Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak Differential Revision: https://phabricator.services.mozilla.com/D24910

Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc The `nsresult` codes that mozStorage returns are often too generic. For example, `NS_ERROR_FAILURE` might be anything from a SQL syntax error to an invalid column name in a trigger. This commit adds a `Conn::call_and_wrap_error` helper that checks the last SQLite error, and returns that instead of `nsresult`. Not all errors are SQLite errors, however, so we only use this for mozStorage methods that return `convertResultCode`. Differential Revision: https://phabricator.services.mozilla.com/D25179

Bug 1539104 - Add a way to detect supported storage connection operations. r=mak In retrospect, overloading `Connection::connectionReady` to mean "is ready _and_ supports this operation" wasn't a good idea. This commit reverts that change (cfd44c936a9b), and adds two new methods: * `Connection::operationSupported`, to check if a connection supports sync or async operations. This method is public. * `Connection::ensureOperationSupported`, that asserts or returns an error if the connection doesn't support an operation. This is private. `operationSupported` is used by callers like `Service::minimizeMemory` to detect if the connection supports sync operations, since both sync and async connections implement `mozIStorageConnection` now. Finally, some callers used `!mDBConn` to check if the connection was ready, while others used `connectionReady()`. This commit changes them to use the latter. Differential Revision: https://phabricator.services.mozilla.com/D24974

Bug 1538367 - Fix quantumbar popup's vertical position on Mac. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25753

Bug 1540662 - Fix the UITour starting an address bar search with QuantumBar enabled. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25588

Bug 1524200 - Add more debugging message to Sanitizer.jsm, r=mak Differential Revision: https://phabricator.services.mozilla.com/D25289

Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak Normally autocomplete results are cached based upon the search string but to get the desired behaviour we want two different sets of results for the same search string depending on how the autocomplete search was started: a) Via automatically focusing a password field. b) Every other method of starting an autocomplete search. In order to not have cached results used, the result code for case (a) [an empty result] will be `RESULT_FAILURE` and I've updated the autocomplete code to not re-use an error result. In the coming months we may be rewriting our content autocomplete code but that would be too risky to uplift to 67 so for now I'm tracking when satchel automatically opens the popup upon focus and then using that state in the autocomplete result creation code to know whether to include the footer. Differential Revision: https://phabricator.services.mozilla.com/D25173

Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25222

Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25222

Bug 1523602 - Re-use existing rows when receiving results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25047

Bug 1523602 - Re-use existing rows when receiving results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25047