searching for reviewer(mak)
cab022901ff73cabd94dea46418167cf118055ad: Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak
Dão Gottwald <dao@mozilla.com> - Mon, 27 May 2019 09:00:00 +0000 - rev 475697
Push 86417 by dgottwald@mozilla.com at Mon, 27 May 2019 09:08:27 +0000
Bug 1554542 - Fix browser.urlbar.doubleClickSelectsAll handling. r=mak Differential Revision: https://phabricator.services.mozilla.com/D32669
5f2932daeff2c6370358feceb7d55f60952a47a1: Bug 1552547 part 2. Stop using [array] in mozIStorageBindingParams. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 20 May 2019 16:30:12 +0000 - rev 474578
Push 85882 by bzbarsky@mozilla.com at Mon, 20 May 2019 17:42:24 +0000
Bug 1552547 part 2. Stop using [array] in mozIStorageBindingParams. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31659
63d2eaf71d022b0fdaca6f12ca8ec4219d46f4c7: Bug 1552547 part 1. Stop using [array] in mozIStorageAsyncConnection.executeAsync. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Mon, 20 May 2019 16:17:51 +0000 - rev 474577
Push 85882 by bzbarsky@mozilla.com at Mon, 20 May 2019 17:42:24 +0000
Bug 1552547 part 1. Stop using [array] in mozIStorageAsyncConnection.executeAsync. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31658
fb8cc6cad30a0f94d5858cc35b20ce77acc605d2: Bug 1551779 part 6. Stop using [array] for replaceFaviconData. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 14:20:17 +0000 - rev 474113
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 6. Stop using [array] for replaceFaviconData. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31243
5db31f792bf4ee2c800edfc88d69e7d825ab3e44: Bug 1551779 part 5. Stop using [array] for getTagsForURI. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 14:03:54 +0000 - rev 474112
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 5. Stop using [array] for getTagsForURI. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31242
87a537f8e5a89204a95ec7395e9024688e16dfae: Bug 1551779 part 4. Stop using [array] for getItemAnnotationNames. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 14:54:15 +0000 - rev 474111
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 4. Stop using [array] for getItemAnnotationNames. r=mak The old code used variants with SetAsAUTF8String, which would get converted to a string when going into JS. We can just use Array<AUTF8String> directly instead. C++ callers would need to change, but there aren't any. Differential Revision: https://phabricator.services.mozilla.com/D31241
4c91b3e1fedeb142e9e79460b772c73902016392: Bug 1551779 part 3. Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 15:13:44 +0000 - rev 474110
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 3. Stop using [array] for nsINavHistoryService.getObservers and nsINavBookmarksService.getObservers. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31239
f5db7f234584c20947fc4fa592b1263d1582df0b: Bug 1551779 part 2. Stop using [array] for get/setParents in nsINavHistoryService. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 13:06:11 +0000 - rev 474109
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 2. Stop using [array] for get/setParents in nsINavHistoryService. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31238
722c158c53865db371646a40084e26a8dd788ea3: Bug 1551779 part 1. Stop using [array] for get/setTransitions in nsINavHistoryService. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Thu, 16 May 2019 12:19:49 +0000 - rev 474108
Push 85659 by bzbarsky@mozilla.com at Thu, 16 May 2019 15:15:02 +0000
Bug 1551779 part 1. Stop using [array] for get/setTransitions in nsINavHistoryService. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31237
aa58df721b0cb74590eb5fb1cffe081824c03ab1: Bug 1552106 - Remove obsolete display and vertical-align properties from urlbarView row children. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 16 May 2019 11:19:31 +0000 - rev 474070
Push 85640 by dgottwald@mozilla.com at Thu, 16 May 2019 11:44:08 +0000
Bug 1552106 - Remove obsolete display and vertical-align properties from urlbarView row children. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31400
9e68d485f7ccea5d8f065fb5f833858e71b4b04a: Bug 1551834 - Move legacy autocomplete attributes from shared browser.xul markup to the legacy-urlbar binding. r=mak
Dão Gottwald <dao@mozilla.com> - Wed, 15 May 2019 15:59:56 +0000 - rev 473977
Push 85575 by dgottwald@mozilla.com at Wed, 15 May 2019 16:30:15 +0000
Bug 1551834 - Move legacy autocomplete attributes from shared browser.xul markup to the legacy-urlbar binding. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31227
f2177d43f7d9c4953915d8cd8db019824832ea05: Bug 1515589 - Implement newlines="stripsurroundingwhitespace" behavior directly in UrlbarInput. r=mak
Dão Gottwald <dao@mozilla.com> - Tue, 14 May 2019 16:01:18 +0000 - rev 473804
Push 85471 by dgottwald@mozilla.com at Tue, 14 May 2019 16:03:09 +0000
Bug 1515589 - Implement newlines="stripsurroundingwhitespace" behavior directly in UrlbarInput. r=mak Differential Revision: https://phabricator.services.mozilla.com/D31064
4934e59477f4d9cb7ab742973b4c31ee3b9bd261: Bug 1485288 - Fix intermittent browser/base/content/test/urlbar/browser_urlbarStop.js by waiting for URLBarSetURI to be called by using a progress listener. r=mak
Drew Willcoxon <adw@mozilla.com> - Tue, 14 May 2019 09:37:30 +0000 - rev 473801
Push 85468 by dwillcoxon@mozilla.com at Tue, 14 May 2019 15:18:56 +0000
Bug 1485288 - Fix intermittent browser/base/content/test/urlbar/browser_urlbarStop.js by waiting for URLBarSetURI to be called by using a progress listener. r=mak When the load is stopped, tabbrowser calls URLBarSetURI [1] and then calls onStateChange [2] on its progress listeners. That's the URLBarSetURI call that updates the urlbar value in this case. So to properly wait until the urlbar value has been updated, add our own progress listener in the test. [1] https://searchfox.org/mozilla-central/rev/cc280c4be94ff8cf64a27cc9b3d6831ffa49fa45/browser/base/content/tabbrowser.js#5036 [2] https://searchfox.org/mozilla-central/rev/cc280c4be94ff8cf64a27cc9b3d6831ffa49fa45/browser/base/content/tabbrowser.js#5071 Differential Revision: https://phabricator.services.mozilla.com/D31018
49dd0db0018af5f94f38a4dec13ad0246964827d: Bug 1551102. Stop using [array] in nsIContentPrefService2. r=mak
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 14 May 2019 11:42:20 +0000 - rev 473774
Push 85445 by bzbarsky@mozilla.com at Tue, 14 May 2019 11:48:53 +0000
Bug 1551102. Stop using [array] in nsIContentPrefService2. r=mak Though maybe we should just remove getCachedBySubdomainAndName, given that it's only used in tests? Differential Revision: https://phabricator.services.mozilla.com/D30834
1e371ad57bd0be4039954e30bc0832350e9f3656: Bug 1550423 - When a result's title or URL overflows, expose the full value in a tooltip. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 09 May 2019 13:06:53 +0000 - rev 473243
Push 85116 by dgottwald@mozilla.com at Thu, 09 May 2019 15:00:37 +0000
Bug 1550423 - When a result's title or URL overflows, expose the full value in a tooltip. r=mak Differential Revision: https://phabricator.services.mozilla.com/D30470
37883d51ffd1e3809cfda2b9efd11df72878f20d: Bug 1550036 - UrlbarView should ignore vertical overflow events when applying the fade-out effect. r=mak
Dão Gottwald <dao@mozilla.com> - Wed, 08 May 2019 15:49:33 +0000 - rev 473090
Push 85020 by dgottwald@mozilla.com at Wed, 08 May 2019 15:50:57 +0000
Bug 1550036 - UrlbarView should ignore vertical overflow events when applying the fade-out effect. r=mak Differential Revision: https://phabricator.services.mozilla.com/D30381
d499ab0ad0da468509074f5d46bfb9b57995e4ea: Bug 1543041 - Port bug 1355073 to quantumbar. r=mak
phoenixabhishek <phoenixgyaan@gmail.com> - Mon, 06 May 2019 16:36:28 +0000 - rev 472732
Push 84806 by mak77@bonardo.net at Mon, 06 May 2019 16:59:01 +0000
Bug 1543041 - Port bug 1355073 to quantumbar. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29838
1963ed5da9820e633eae778edd690ed5c529ee31: Bug 1545742 - Quantumbar: Remove the proper nsIController on uninit and customize start so that left/right arrow and home/end keys work after exiting customize mode. r=mak
Drew Willcoxon <adw@mozilla.com> - Fri, 03 May 2019 16:03:00 +0000 - rev 472531
Push 84707 by dwillcoxon@mozilla.com at Fri, 03 May 2019 16:04:05 +0000
Bug 1545742 - Quantumbar: Remove the proper nsIController on uninit and customize start so that left/right arrow and home/end keys work after exiting customize mode. r=mak When UrlbarInput.uninit is called after customize mode ends, uninit calls this.inputField.controllers.removeControllerAt(0), which is supposed to remove the input's CopyCutController inserted in the constructor. But the controller at index 0 at that point is not the CopyCutController. Instead it's some built-in controller that supports these commands (at least these): cmd_charPrevious, cmd_charPrevious, cmd_beginLine, cmd_endLine. (Verified by adding logging to nsXULControllers::GetControllerForCommand.) That's why arrow left/right and home/end don't work after ending customize mode. The problem is that this.inputField.controllers in the constructor and this.inputField.controllers in uninit (when customize mode ends) are not the same. I wasn't able to track down why, but I'm guessing that the textbox or something in its state is being reset or cloned when customized mode ends or maybe right after it starts. The CopyCutController isn't in the controllers array at all on uninit. (Verified by adding support for cmd_adw and iterating through the controllers array, looking for a controller supporting cmd_adw.) Note that urlbarBindings.xml has a try-catch around removeController(), I'm guessing for what turns out to be this reason: https://searchfox.org/mozilla-central/rev/7944190ad1668a94223b950a19f1fffe8662d6b8/browser/base/content/urlbarBindings.xml#190 However, CopyCutController *is* in the controllers array when customize mode starts. So I added a new gURLBarHandler.customizeStart method that calls a new UrlbarInput.removeCopyCutController method. Other things I tried or thought of doing: Call gURLBarHandler._reset on customize start instead of end. Problem with that is that the UrlbarInput ends up getting immediately recreated because some other parts of the browser access gURLBar at that time. (Of course I replaced the `gURLBar = this.urlbar` assignment in _reset with another lazy getter definition.) Just don't worry about removing CopyCutController at all. That seems bad because then we'd leak it, unless the controller is removed or the controllers array is emptied at some point by XUL, and I'm not at all certain about that. (Although I guess this is effectively what awesomebar does, given the link above!) Differential Revision: https://phabricator.services.mozilla.com/D29613
76e8b769a7c00797dcaeef19cbaaa564f1f373b6: Bug 1546035 - Remove local and remote livemarks when syncing. r=mak,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Thu, 02 May 2019 08:03:36 +0000 - rev 472331
Push 84605 by kcambridge@mozilla.com at Thu, 02 May 2019 17:59:36 +0000
Bug 1546035 - Remove local and remote livemarks when syncing. r=mak,tcsc This commit exports livemarks before syncing for the first time, to avoid losing livemarks that Sync may have resurrected. As of v0.2.4, Dogear treats livemarks as non-syncable, and deletes them on both sides. This also bumps the mirror schema version, to trigger a first sync. Differential Revision: https://phabricator.services.mozilla.com/D28543
a7ad04ab4ba4a7444f9091a810d7f4eaa6247f5a: Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 01 May 2019 17:42:19 +0000 - rev 472158
Push 84494 by dwillcoxon@mozilla.com at Wed, 01 May 2019 17:48:18 +0000
Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak This test uncovered a couple of problems: (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key. handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event. So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys. (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results. It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433 Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled. Differential Revision: https://phabricator.services.mozilla.com/D29300
9242458b79d5ae6e9d48c9a2a591680d79c13211: Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 01 May 2019 02:30:47 +0000 - rev 472059
Push 84444 by dwillcoxon@mozilla.com at Wed, 01 May 2019 02:32:32 +0000
Bug 1539804 - Quantumbar: Re-enable browser_urlbarStopSearchOnSelection.js and fix a couple of related problems. r=mak This test uncovered a couple of problems: (1) UrlbarController.handleKeyNavigation relies on event.defaultPrevented to tell whether the one-offs handled the key event. That's a problem when combined with deferring the down arrow key. handleKeyNavigation is called twice in that case. The first time, the event is deferred (so executeAction = false), and handleKeyNavigation calls event.preventDefault. The second time, the event is being replayed, but defaultPrevented is true from the previous call regardless of whether the one-offs actually handled the event. So handleKeyNavigation always returns early because it thinks the one-offs always handled the event, so it never properly replays down arrow keys. (2) UrlbarProviderUnifiedComplete's query promise is never resolved when the query is canceled. That's a problem in general of course but I tripped over it in this test because I need to check results after the query is canceled, and the test ended up hanging since UrlbarTestUtils waits for the query to finish in order to get its results. It's not a problem in UnifiedComplete itself per se because of course awesomebar uses UnifiedComplete too, and it doesn't have this problem. The difference is that nsAutoCompleteController::StopSearch calls input->OnSearchComplete() (via PostSearchCleanup): https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/toolkit/components/autocomplete/nsAutoCompleteController.cpp#1433 Quantumbar's UnifiedComplete provider is missing that behavior, so this patch adds it by resolving its query promise when the query is canceled. Differential Revision: https://phabricator.services.mozilla.com/D29300
e5eae28c1a24c6347a5cc74648d4e73be6919c17: Bug 1544443 - Upgrade to SQLite 3.28.0. r=mak
Ryan VanderMeulen <ryanvm@gmail.com> - Tue, 30 Apr 2019 16:51:39 +0000 - rev 472007
Push 84399 by rvandermeulen@mozilla.com at Tue, 30 Apr 2019 16:53:04 +0000
Bug 1544443 - Upgrade to SQLite 3.28.0. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29379
1c84fa9854cfb679f1c336be44dafc952142aee9: Bug 1544030 - Fix quantumbar popup's vertical borders and position on Mac once again. r=mak
Dão Gottwald <dao@mozilla.com> - Tue, 30 Apr 2019 15:03:21 +0000 - rev 471984
Push 84384 by dgottwald@mozilla.com at Tue, 30 Apr 2019 15:24:34 +0000
Bug 1544030 - Fix quantumbar popup's vertical borders and position on Mac once again. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29340
139a838ca42fb715041775925f0aa5a994700e74: Bug 1547801 - Correctly handle case-insensitive matching in tag queries for international strings. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 30 Apr 2019 14:56:25 +0000 - rev 471979
Push 84381 by mbanner@mozilla.com at Tue, 30 Apr 2019 14:58:52 +0000
Bug 1547801 - Correctly handle case-insensitive matching in tag queries for international strings. r=mak Differential Revision: https://phabricator.services.mozilla.com/D29334
29c131c2fd402f750064800c41037f534cea5cfd: Bug 1545394 - Keep stale rows in the view while receiving new results. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 19 Apr 2019 20:09:13 +0000 - rev 470262
Push 83629 by dgottwald@mozilla.com at Fri, 19 Apr 2019 20:32:14 +0000
Bug 1545394 - Keep stale rows in the view while receiving new results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D28049
a3acb30248ff81e6a0a10a61783fa25896e23e21: Bug 1545200 - Squelch spurious synchronous operation warnings in `Connection::operationSupported`. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Wed, 17 Apr 2019 19:10:28 +0000 - rev 469965
Push 83459 by kcambridge@mozilla.com at Thu, 18 Apr 2019 00:31:24 +0000
Bug 1545200 - Squelch spurious synchronous operation warnings in `Connection::operationSupported`. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27959
4cda78f998e8c858fa9307800395d4a9214a66ef: Bug 1524550 - Remove UrlbarQueryContext's lastKey property. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 17 Apr 2019 15:19:23 +0000 - rev 469909
Push 83419 by dwillcoxon@mozilla.com at Wed, 17 Apr 2019 18:11:30 +0000
Bug 1524550 - Remove UrlbarQueryContext's lastKey property. r=mak This assumes that the current direction in bug 1522278 is the one we want, which it's looking like it is. Differential Revision: https://phabricator.services.mozilla.com/D27854
47050699cd5c391afa95189016a00fbb726dc6b1: Bug 1522278 - Use nsIEditActionListener to detect when the user deletes autofilled substrings. r=mak
Drew Willcoxon <adw@mozilla.com> - Wed, 17 Apr 2019 15:19:23 +0000 - rev 469908
Push 83419 by dwillcoxon@mozilla.com at Wed, 17 Apr 2019 18:11:30 +0000
Bug 1522278 - Use nsIEditActionListener to detect when the user deletes autofilled substrings. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27637
d525a800fe208083107f96d2101661e3cf4b1021: Bug 1543661 - Instead of rounding to integer, use more precision when setting px values. r=mak
Dão Gottwald <dao@mozilla.com> - Mon, 15 Apr 2019 13:05:03 +0000 - rev 469531
Push 83199 by dgottwald@mozilla.com at Mon, 15 Apr 2019 15:50:20 +0000
Bug 1543661 - Instead of rounding to integer, use more precision when setting px values. r=mak Differential Revision: https://phabricator.services.mozilla.com/D27390
ea02b41a2b1d797cfaa4b1ebdf9d07405608fb06: Bug 1541929 - Don't autofill the first result in some cases. r=mak
Drew Willcoxon <adw@mozilla.com> - Mon, 15 Apr 2019 13:15:30 +0000 - rev 469530
Push 83198 by dwillcoxon@mozilla.com at Mon, 15 Apr 2019 15:49:37 +0000
Bug 1541929 - Don't autofill the first result in some cases. r=mak We need to handle autofilling the first result separately from autofilling results in general (which happens in UrlbarInput.setValueFromResult), so add a new UrlbarInput.autofillFirstResult method. The controller calls it instead of setValueFromResult. I ported the logic from nsAutoCompleteController, as described in the bug. Other changes are related to the new test for this. As part of this work, I was interested in learning how awesomebar handles browser_autoFill_typed.js, so I added it to the legacy tests, with a small tweak in the test for awesomebar. Differential Revision: https://phabricator.services.mozilla.com/D26852
b7402a73e252b096234bf3814b5a75bbc0258f94: Bug 1544002 - nsNavHistoryResult::mRefreshParticipants should participate in cycle collection. r=mak
Andrew McCreight <continuation@gmail.com> - Mon, 15 Apr 2019 10:11:38 +0000 - rev 469510
Push 83183 by amccreight@mozilla.com at Mon, 15 Apr 2019 14:09:43 +0000
Bug 1544002 - nsNavHistoryResult::mRefreshParticipants should participate in cycle collection. r=mak It is an array of cycle collected objects. Differential Revision: https://phabricator.services.mozilla.com/D27337
c261aea0226a3f60a31923b9a98e80826eb18833: Bug 1525548 - Centralise closing the address bar popup into the head file for urlbar tests. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 12 Apr 2019 12:52:50 +0000 - rev 469282
Push 83050 by mbanner@mozilla.com at Fri, 12 Apr 2019 12:56:36 +0000
Bug 1525548 - Centralise closing the address bar popup into the head file for urlbar tests. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26759
c49b36c011b2e462a9cf66a31ace780e3ef66b73: Bug 1541924 - Enforce that BookmarkJSONUtils.importFromURL can only be used with chrome and file URLs. r=mak
Mark Banner <standard8@mozilla.com> - Fri, 12 Apr 2019 12:34:44 +0000 - rev 469279
Push 83047 by mbanner@mozilla.com at Fri, 12 Apr 2019 12:44:04 +0000
Bug 1541924 - Enforce that BookmarkJSONUtils.importFromURL can only be used with chrome and file URLs. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26921
cec02915533974e9ad62aad07838cdbfdb477f15: Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 11 Apr 2019 11:47:18 +0000 - rev 469006
Push 82909 by dgottwald@mozilla.com at Thu, 11 Apr 2019 12:19:03 +0000
Bug 1541910 - Use the chrome/content separator color for the urlbar results popup's top and bottom borders consistently across platforms and remove left and right borders. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26192
b0a8a5c4533e067ea614da696b1ea622a92333f4: Bug 1543295 - Pass the text length when creating an `nsString` from a SQLite text result. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Thu, 11 Apr 2019 03:19:39 +0000 - rev 468935
Push 82874 by kcambridge@mozilla.com at Thu, 11 Apr 2019 03:20:28 +0000
Bug 1543295 - Pass the text length when creating an `nsString` from a SQLite text result. r=mak This commit updates mozStorage to always: * Pass the length, using sqlite3_{column, value}_bytes16, when creating an nsDependentString from a pointer. * Call sqlite3_{column, value}_bytes{16} after sqlite3_{column, value}_{text, blob, text16}, per the recommendation in https://www.sqlite.org/c3ref/column_blob.html. Some callers did this before, or in unclear order, since C++ doesn't specify one for evaluating function arguments. * Pass the byte length to sqlite3_result_text16. Differential Revision: https://phabricator.services.mozilla.com/D26848
bd12a191e5af168f52a03e0546cf4b02054d5414: Bug 1542990 - Use "Toolkit :: Storage" for kvstore bugs. DONTBUILD r=mak,myk
Lina Cambridge <lina@yakshaving.ninja> - Tue, 09 Apr 2019 18:11:57 +0000 - rev 468629
Push 82702 by kcambridge@mozilla.com at Tue, 09 Apr 2019 18:13:10 +0000
Bug 1542990 - Use "Toolkit :: Storage" for kvstore bugs. DONTBUILD r=mak,myk Differential Revision: https://phabricator.services.mozilla.com/D26657
6efaae3bcd67bc0881a114c5c7dbd319e6b4abc2: Bug 1536508 - Generate a mouseover as well as a mouseout to avoid issues in devedition with browser_UrlbarInput_tooltip.js. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 09 Apr 2019 07:31:31 +0000 - rev 468495
Push 82626 by mbanner@mozilla.com at Tue, 09 Apr 2019 07:44:35 +0000
Bug 1536508 - Generate a mouseover as well as a mouseout to avoid issues in devedition with browser_UrlbarInput_tooltip.js. r=mak Differential Revision: https://phabricator.services.mozilla.com/D26531
eb068229a2d5579aa9555ea307ebdfcd06fafc9e: Bug 1533054 - Add tests for selection key navigation: up/down, page-up/down, tab r=mak
Drew Willcoxon <adw@mozilla.com> - Thu, 04 Apr 2019 12:11:32 +0000 - rev 468451
Push 82594 by dwillcoxon@mozilla.com at Mon, 08 Apr 2019 22:15:03 +0000
Bug 1533054 - Add tests for selection key navigation: up/down, page-up/down, tab r=mak Differential Revision: https://phabricator.services.mozilla.com/D25901
c36ad62407f38e7d8c2bcba0250dfceb5c02d728: Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Tue, 26 Mar 2019 15:17:42 +0000 - rev 468196
Push 82442 by btara@mozilla.com at Fri, 05 Apr 2019 16:22:06 +0000
Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak Differential Revision: https://phabricator.services.mozilla.com/D24910
a13bf582f195439790257dcd375838f2aced5da3: Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Thu, 04 Apr 2019 23:05:23 +0000 - rev 468081
Push 82376 by gijskruitbosch@gmail.com at Fri, 05 Apr 2019 00:43:24 +0000
Bug 1540170 - release assert if something tries to start the history service before profile startup, r=mak Differential Revision: https://phabricator.services.mozilla.com/D24910
b052410b667385a66f5b9916b1e91bef80f8fc09: Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc
Lina Cambridge <lina@yakshaving.ninja> - Tue, 02 Apr 2019 16:56:41 +0000 - rev 467662
Push 82107 by kcambridge@mozilla.com at Tue, 02 Apr 2019 19:43:41 +0000
Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc The `nsresult` codes that mozStorage returns are often too generic. For example, `NS_ERROR_FAILURE` might be anything from a SQL syntax error to an invalid column name in a trigger. This commit adds a `Conn::call_and_wrap_error` helper that checks the last SQLite error, and returns that instead of `nsresult`. Not all errors are SQLite errors, however, so we only use this for mozStorage methods that return `convertResultCode`. Differential Revision: https://phabricator.services.mozilla.com/D25179
db20a3f4324ec9fc29bb21bda77672e7e7640529: Bug 1539104 - Add a way to detect supported storage connection operations. r=mak
Lina Cambridge <lina@yakshaving.ninja> - Tue, 02 Apr 2019 18:49:21 +0000 - rev 467645
Push 82095 by kcambridge@mozilla.com at Tue, 02 Apr 2019 19:34:45 +0000
Bug 1539104 - Add a way to detect supported storage connection operations. r=mak In retrospect, overloading `Connection::connectionReady` to mean "is ready _and_ supports this operation" wasn't a good idea. This commit reverts that change (cfd44c936a9b), and adds two new methods: * `Connection::operationSupported`, to check if a connection supports sync or async operations. This method is public. * `Connection::ensureOperationSupported`, that asserts or returns an error if the connection doesn't support an operation. This is private. `operationSupported` is used by callers like `Service::minimizeMemory` to detect if the connection supports sync operations, since both sync and async connections implement `mozIStorageConnection` now. Finally, some callers used `!mDBConn` to check if the connection was ready, while others used `connectionReady()`. This commit changes them to use the latter. Differential Revision: https://phabricator.services.mozilla.com/D24974
c1f4e710ff8e2a002640afd221e23f57646df3d8: Bug 1538367 - Fix quantumbar popup's vertical position on Mac. r=mak
Dão Gottwald <dao@mozilla.com> - Tue, 02 Apr 2019 14:39:38 +0000 - rev 467603
Push 82073 by dgottwald@mozilla.com at Tue, 02 Apr 2019 14:40:50 +0000
Bug 1538367 - Fix quantumbar popup's vertical position on Mac. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25753
157c5b2beb40afc89e9c8aeb934f469d702fe71b: Bug 1540662 - Fix the UITour starting an address bar search with QuantumBar enabled. r=mak
Mark Banner <standard8@mozilla.com> - Tue, 02 Apr 2019 10:05:01 +0000 - rev 467571
Push 82053 by mbanner@mozilla.com at Tue, 02 Apr 2019 11:19:14 +0000
Bug 1540662 - Fix the UITour starting an address bar search with QuantumBar enabled. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25588
a1d82278bf83c250901f7b29b2adbabffa86714b: Bug 1524200 - Add more debugging message to Sanitizer.jsm, r=mak
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 01 Apr 2019 13:46:56 +0000 - rev 467058
Push 81936 by amarchesini@mozilla.com at Mon, 01 Apr 2019 13:48:22 +0000
Bug 1524200 - Add more debugging message to Sanitizer.jsm, r=mak Differential Revision: https://phabricator.services.mozilla.com/D25289
03cf8c67770c88d26912bd7f948188724cd053f7: Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak
Matthew Noorenberghe <mozilla@noorenberghe.ca> - Sat, 30 Mar 2019 04:20:20 +0000 - rev 466929
Push 81889 by mozilla@noorenberghe.ca at Sat, 30 Mar 2019 04:33:02 +0000
Bug 1538952 - Don't automatically open the password autocomplete popup when we only have the footer to show. r=jaws,mak Normally autocomplete results are cached based upon the search string but to get the desired behaviour we want two different sets of results for the same search string depending on how the autocomplete search was started: a) Via automatically focusing a password field. b) Every other method of starting an autocomplete search. In order to not have cached results used, the result code for case (a) [an empty result] will be `RESULT_FAILURE` and I've updated the autocomplete code to not re-use an error result. In the coming months we may be rewriting our content autocomplete code but that would be too risky to uplift to 67 so for now I'm tracking when satchel automatically opens the popup upon focus and then using that state in the autocomplete result creation code to know whether to include the footer. Differential Revision: https://phabricator.services.mozilla.com/D25173
a1cfb4874e277b523330f3595ac138897b49f41a: Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 29 Mar 2019 14:53:52 +0000 - rev 466784
Push 81817 by dgottwald@mozilla.com at Fri, 29 Mar 2019 14:55:00 +0000
Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25222
9eca658703d92afe37923f313c9f662d16b98627: Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak
Dão Gottwald <dao@mozilla.com> - Fri, 29 Mar 2019 10:39:34 +0000 - rev 466756
Push 81795 by dgottwald@mozilla.com at Fri, 29 Mar 2019 12:05:01 +0000
Bug 1524510 - Freeze quantum bar results when the user interacts with them. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25222
6f4934ff6383443613d872fad8a68a7f54fba232: Bug 1523602 - Re-use existing rows when receiving results. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 28 Mar 2019 17:08:04 +0000 - rev 466623
Push 81711 by dgottwald@mozilla.com at Thu, 28 Mar 2019 17:10:23 +0000
Bug 1523602 - Re-use existing rows when receiving results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25047
6385899fe7b9ccd58f9ea0091e9d158416f83605: Bug 1523602 - Re-use existing rows when receiving results. r=mak
Dão Gottwald <dao@mozilla.com> - Thu, 28 Mar 2019 12:59:57 +0000 - rev 466576
Push 81677 by dgottwald@mozilla.com at Thu, 28 Mar 2019 13:15:39 +0000
Bug 1523602 - Re-use existing rows when receiving results. r=mak Differential Revision: https://phabricator.services.mozilla.com/D25047