searching for reviewer(jwalden)
61484a56d30a2bbc5a3d6903e6258ae3acd714bf: Bug 1686052 - Part 12: Update test262 exclusions. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:27 +0000 - rev 581985
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 12: Update test262 exclusions. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D101401
5acae134bbb8264c82d5c997abb3a4f0ce55ccda: Bug 1686052 - Part 11: Updating ICU requires a clobber. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:27 +0000 - rev 581984
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 11: Updating ICU requires a clobber. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D101399
bb0fccdb6e4843672b6f860888c09d6cd34a5456: Bug 1686052 - Part 9: Remove no longer needed locale maximization when removing likely subtags. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:26 +0000 - rev 581982
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 9: Remove no longer needed locale maximization when removing likely subtags. r=jwalden The two ICU bugs (ICU-10220 and ICU-12345) have been resolved and it's now no longer necessary to call `uloc_addLikelySubtags` before calling `uloc_minimizeSubtags`. Drive-by change: - Replaced `strlen` with `std::char_traits<char>::length`. Differential Revision: https://phabricator.services.mozilla.com/D101396
2ff57c5c3ccef662b540d166aa2e7943b3d56ec0: Bug 1686052 - Part 8: Remove guards around previous ICU draft APIs. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:25 +0000 - rev 581981
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 8: Remove guards around previous ICU draft APIs. r=jwalden builtin/TestingFunctions.cpp: `ucal_getHostTimeZone()` has been promoted to "stable" in ICU 68, so we can remove the `ifndef U_HIDE_DRAFT_API` guard. intl/ListFormat: `UListFormatter{Type,Width}` were also promoted to "stable" in ICU 68. This allows to enable "type" and "style" options for `Intl.ListFormat` by default. Differential Revision: https://phabricator.services.mozilla.com/D101395
f44ca702dcf3407ae119b7d2fa73a7962600a0bb: Bug 1686052 - Part 7: Bump minimum required ICU version to 68.2. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:25 +0000 - rev 581980
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 7: Bump minimum required ICU version to 68.2. r=jwalden Change the system requirement to ICU 68 in order to remove some conditional code in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D101394
59f05c0546d8f3709276a77d97b20a2cae82c145: Bug 1686052 - Part 6: Update expected tests results. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:25 +0000 - rev 581979
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 6: Update expected tests results. r=jwalden Updating to CLDR 38 means a couple of format strings have changed, update the expected results accordingly. Differential Revision: https://phabricator.services.mozilla.com/D101393
b7afcd23f7047f16d650f84919b3cefd139cd59b: Bug 1686052 - Part 5: Update numbering and measuring unit systems. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:24 +0000 - rev 581978
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 5: Update numbering and measuring unit systems. r=jwalden Updates the numbering and measuring unit systems data to CLDR 38 by running `make_intl_data.py numbering` and `make_intl_data.py units`. Differential Revision: https://phabricator.services.mozilla.com/D101392
dfddac0a5a30758bc3b9ad6f09e1b452b5bd29d1: Bug 1686052 - Part 4: Update tzdata in ICU data files to 2021a. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:19 +0000 - rev 581977
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 4: Update tzdata in ICU data files to 2021a. r=jwalden ICU 68.2 ships with tzdata 2020d, so update again to 2021a. Differential Revision: https://phabricator.services.mozilla.com/D101391
be466ae533b65a8e214aa71cff8091204c767ed6: Bug 1686052 - Part 3: Update in-tree ICU to release 68.2. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:10 +0000 - rev 581976
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 3: Update in-tree ICU to release 68.2. r=jwalden Update to ICU 68.2 by running "update-icu.sh" with "maint/maint-68" as the target. Differential Revision: https://phabricator.services.mozilla.com/D101389
dfcf9f05fd7525124e57b1a8009ccd293a60b958: Bug 1686052 - Part 2: Update ICU build script to use new "sources.txt" file. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:09 +0000 - rev 581975
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 2: Update ICU build script to use new "sources.txt" file. r=jwalden <https://unicode-org.atlassian.net/browse/ICU-10879> added a separate "sources.txt" file which lists all source files per directory. Differential Revision: https://phabricator.services.mozilla.com/D101366
a0b54333e664bd49615a320c88c16aea85019e16: Bug 1686052 - Part 1: Update or remove ICU patches. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Jun 2021 17:42:09 +0000 - rev 581974
Push 144380 by andre.bargull@gmail.com at Fri, 04 Jun 2021 18:07:57 +0000
Bug 1686052 - Part 1: Update or remove ICU patches. r=jwalden Update the patch from bug 1614941, because CLDR 38 adds its own patterns for "MMMMd" and "yMMMM", which both conflict with our customised patterns. The customised patterns were updated per the discussion in <https://bugzilla.mozilla.org/show_bug.cgi?id=1614941#c32>. Remove the patches from bug 1433303 and bug 1534160. Both are no longer needed, because they've been integrated into upstream. Differential Revision: https://phabricator.services.mozilla.com/D101365
4529553d5feed6780de26fd2e89b1b808c96e6fa: Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden
Mike Hommey <mh+mozilla@glandium.org> - Wed, 10 Mar 2021 23:52:39 +0000 - rev 570618
Push 138240 by mh@glandium.org at Thu, 11 Mar 2021 00:32:13 +0000
Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden Which means they move from MFBT to mozglue. Differential Revision: https://phabricator.services.mozilla.com/D103728
ee57bce47f644351ec57616384173f17b3d8a1ac: Bug 1669616 - Test unreachable code warning when token lookahead sees a BigInt literal. r=jwalden DONTBUILD
Jason Orendorff <jason.orendorff@gmail.com> - Tue, 02 Mar 2021 14:06:22 +0000 - rev 569319
Push 137530 by jorendorff@mozilla.com at Tue, 02 Mar 2021 14:08:56 +0000
Bug 1669616 - Test unreachable code warning when token lookahead sees a BigInt literal. r=jwalden DONTBUILD Differential Revision: https://phabricator.services.mozilla.com/D96124
b200811e596b5cbfed0a1020252704ae0b041ae6: Bug 1670124 - Forbid \8 and \9 in strict mode strings and template literals. r=jwalden
Ganesh Sundar C <77ganesh.nitt@gmail.com> - Thu, 25 Feb 2021 10:58:09 +0000 - rev 568742
Push 137197 by evilpies@gmail.com at Thu, 25 Feb 2021 11:00:32 +0000
Bug 1670124 - Forbid \8 and \9 in strict mode strings and template literals. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D95580
2b7df5f4ad7043e722a888e4f0b2fc01f95b7eb4: Bug 1670124 - Forbid \8 and \9 in strict mode strings and template literals. r=jwalden
Ganesh Sundar C <77ganesh.nitt@gmail.com> - Wed, 24 Feb 2021 22:58:30 +0000 - rev 568695
Push 137167 by evilpies@gmail.com at Wed, 24 Feb 2021 23:53:49 +0000
Bug 1670124 - Forbid \8 and \9 in strict mode strings and template literals. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D95580
6d83474e81bb922f715d73450a4518d19ab145f9: Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden
Mike Hommey <mh+mozilla@glandium.org> - Tue, 16 Feb 2021 21:20:03 +0000 - rev 567763
Push 136595 by mh@glandium.org at Tue, 16 Feb 2021 21:22:39 +0000
Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden Which means they move from MFBT to mozglue. Differential Revision: https://phabricator.services.mozilla.com/D103728
cac4879f50b4acad49eb7f6f48151a58fd18d34d: Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden
Mike Hommey <mh+mozilla@glandium.org> - Fri, 12 Feb 2021 20:21:49 +0000 - rev 567380
Push 136385 by mh@glandium.org at Fri, 12 Feb 2021 20:24:18 +0000
Bug 1690167 - Move Sprintf.h and IntegerPrintfMacros.h next to Printf.h. r=jwalden Which means they move from MFBT to mozglue. Differential Revision: https://phabricator.services.mozilla.com/D103728
4074040827feb4951a35750c7d4850eb1f515d6f: Bug 1686831 - Handle trailing zero removal in double-conversion. r=nika,jwalden,Gankra
Mike Hommey <mh+mozilla@glandium.org> - Fri, 29 Jan 2021 04:25:53 +0000 - rev 565279
Push 135335 by mh@glandium.org at Fri, 29 Jan 2021 21:14:07 +0000
Bug 1686831 - Handle trailing zero removal in double-conversion. r=nika,jwalden,Gankra Bug 608915 switched nsString::AppendFloat to double-conversion, while handling trailing zero removal on its own. This can be made more effectively when doing so in double-conversion itself, support for which was merged upstream in https://github.com/google/double-conversion/pull/149. This makes the used_exponential_notation outparam unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D102698
138245e7f88e7dcf0ba328e16e88bd9c4c88a9e4: Bug 1689581 - Disable large-buffers jit-tests on TSan builds. r=jwalden
Jan de Mooij <jdemooij@mozilla.com> - Fri, 29 Jan 2021 11:29:57 +0000 - rev 565173
Push 135283 by jdemooij@mozilla.com at Fri, 29 Jan 2021 11:32:26 +0000
Bug 1689581 - Disable large-buffers jit-tests on TSan builds. r=jwalden This fixes frequent and mysterious failures for the SM(tsan) job. Differential Revision: https://phabricator.services.mozilla.com/D103463
cf6dd6eab4272ceaaf0024324473d79615f39869: Bug 1686831 - Handle trailing zero removal in double-conversion. r=nika,jwalden,Gankra
Mike Hommey <mh+mozilla@glandium.org> - Wed, 27 Jan 2021 01:06:34 +0000 - rev 564976
Push 135159 by mh@glandium.org at Thu, 28 Jan 2021 06:19:13 +0000
Bug 1686831 - Handle trailing zero removal in double-conversion. r=nika,jwalden,Gankra Bug 608915 switched nsString::AppendFloat to double-conversion, while handling trailing zero removal on its own. This can be made more effectively when doing so in double-conversion itself, support for which was merged upstream in https://github.com/google/double-conversion/pull/149. This makes the used_exponential_notation outparam unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D102698
c73bdf2d4ca14f5789af74cc71f17e3b5dbb16ef: Bug 1654116 - Part 2: Enable Intl.DisplayNames by default. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Dec 2020 15:23:09 +0000 - rev 560798
Push 132852 by csabou@mozilla.com at Tue, 15 Dec 2020 16:46:49 +0000
Bug 1654116 - Part 2: Enable Intl.DisplayNames by default. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D93231
433766579bf1163d1dec9c98fd95c81c0694f7e1: Bug 1654116 - Part 1: Only case-canonicalise script and region subtags. r=jwalden
André Bargull <andre.bargull@gmail.com> - Tue, 15 Dec 2020 15:07:53 +0000 - rev 560797
Push 132852 by csabou@mozilla.com at Tue, 15 Dec 2020 16:46:49 +0000
Bug 1654116 - Part 1: Only case-canonicalise script and region subtags. r=jwalden Instead of returning the fully canonicalised script resp. region subtag, only return the case-canonicalised subtag when no localised name was found. Note: Language tags are still fully canoncalised. Spec issues: - https://github.com/tc39/proposal-intl-displaynames/issues/81 - https://github.com/tc39/proposal-intl-displaynames/issues/82 Differential Revision: https://phabricator.services.mozilla.com/D93230
7264e6cb9041e1adc22654aff320747deb717ae5: Bug 1680724 - Add a utility function that converts a T* to a Maybe<T&>. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 08 Dec 2020 17:49:22 +0000 - rev 559865
Push 132306 by sgiesecke@mozilla.com at Tue, 08 Dec 2020 17:52:30 +0000
Bug 1680724 - Add a utility function that converts a T* to a Maybe<T&>. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D98783
7e8f6ccaf0035887944291f493265a8b8e2f0c33: Bug 1673027 - Part 2: Update tzdata in ICU data files to 2020d. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Dec 2020 17:23:41 +0000 - rev 559556
Push 132136 by cbrindusan@mozilla.com at Fri, 04 Dec 2020 19:40:34 +0000
Bug 1673027 - Part 2: Update tzdata in ICU data files to 2020d. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D94605
6b890120ec206c6e5d8a6f1d190dde4dc3b261e2: Bug 1673027 - Part 1: Remove "US/Pacific-New" time zone link. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 04 Dec 2020 17:23:16 +0000 - rev 559555
Push 132136 by cbrindusan@mozilla.com at Fri, 04 Dec 2020 19:40:34 +0000
Bug 1673027 - Part 1: Remove "US/Pacific-New" time zone link. r=jwalden tzdata 2020b removed the "US/Pacific-New" time zone link, but the link is still present in CLDR/ICU, so we need to manually remove it before processing the ICU time zone files. Also reformats the complete file through Black because the linter was complaining about it. (The `u` prefix for Unicode strings wasn't removed when Black was applied on all in-tree files and apparently this is now causing linter warnings.) Differential Revision: https://phabricator.services.mozilla.com/D94604
3ba6cafe48d866c33c51fea45927e3b919b8c3ed: Bug 1665462 - Use moving Vector::appendAll overload at a few places, or use move assignment. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 29 Oct 2020 15:04:13 +0000 - rev 555167
Push 129796 by sgiesecke@mozilla.com at Thu, 29 Oct 2020 21:13:02 +0000
Bug 1665462 - Use moving Vector::appendAll overload at a few places, or use move assignment. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D90547
fc6b7d8f4d9808b47f1daba5683639ddeefc2976: Bug 1665462 - Add moving Vector::appendAll(Vector&&) overload. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 29 Oct 2020 19:41:43 +0000 - rev 555166
Push 129796 by sgiesecke@mozilla.com at Thu, 29 Oct 2020 21:13:02 +0000
Bug 1665462 - Add moving Vector::appendAll(Vector&&) overload. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D90522
d54d820d6a8d24a86d6e03d976280182cbd7758d: Bug 1674033 - Remove files in order to unbust win asan reporter. r=jwalden
Cosmin Sabou <csabou@mozilla.com> - Thu, 29 Oct 2020 02:55:42 +0000 - rev 555122
Push 129767 by ccoroiu@mozilla.com at Thu, 29 Oct 2020 17:01:32 +0000
Bug 1674033 - Remove files in order to unbust win asan reporter. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D95102
ff7124e703ef86512c34b62b080b0381a55963be: Bug 1674033 - Remove files in order to unbust win asan reporter. r=jwalden
Cosmin Sabou <csabou@mozilla.com> - Thu, 29 Oct 2020 02:55:42 +0000 - rev 555014
Push 129707 by csabou@mozilla.com at Thu, 29 Oct 2020 04:00:53 +0000
Bug 1674033 - Remove files in order to unbust win asan reporter. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D95102
454ea3b162565554234c7a28c7106110b6523da0: Bug 1672353 - Disable clang warnings when compiling ICU. r=jwalden,andi
Tom Schuster <evilpies@gmail.com> - Sat, 24 Oct 2020 21:23:15 +0000 - rev 554361
Push 129391 by evilpies@gmail.com at Sat, 24 Oct 2020 21:25:50 +0000
Bug 1672353 - Disable clang warnings when compiling ICU. r=jwalden,andi Differential Revision: https://phabricator.services.mozilla.com/D94291
f1815c07c36e671a096f3c522f86e51f66903b11: Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 18 Sep 2020 06:33:12 +0000 - rev 549268
Push 126663 by sgiesecke@mozilla.com at Fri, 18 Sep 2020 09:50:50 +0000
Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D90133
25b16cbae15238a7b2b0c4e15ed1a619c831deea: Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Thu, 17 Sep 2020 08:44:30 +0000 - rev 549174
Push 126600 by sgiesecke@mozilla.com at Thu, 17 Sep 2020 14:21:09 +0000
Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D90133
ffed28f0b547fdd531181c4c5a477b0181a55fb2: Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 16 Sep 2020 14:56:02 +0000 - rev 548934
Push 126477 by sgiesecke@mozilla.com at Wed, 16 Sep 2020 15:01:49 +0000
Bug 1664844 - Add DebugOnly::inspect member function. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D90133
18c4068ca106bc3d5d74b6caefb99928eb8cb068: Bug 1659962 - Add additional MOZ_ARG_* macros; r=jwalden
Jan Varga <jvarga@mozilla.com> - Wed, 19 Aug 2020 14:31:40 +0000 - rev 545338
Push 124523 by jvarga@mozilla.com at Wed, 19 Aug 2020 15:57:42 +0000
Bug 1659962 - Add additional MOZ_ARG_* macros; r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D87579
b3aed0b0c1b47e0a80318c5f367b4bb7f6808ef3: Bug 1657117: Call `ToObject(options)` before validating the language tag parameter in Intl.Locale. r=jwalden
André Bargull <andre.bargull@gmail.com> - Wed, 19 Aug 2020 08:55:47 +0000 - rev 545300
Push 124496 by cbrindusan@mozilla.com at Wed, 19 Aug 2020 09:54:40 +0000
Bug 1657117: Call `ToObject(options)` before validating the language tag parameter in Intl.Locale. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D85864
1283143e3d557b54a6262253d6003af733203a14: Bug 1654696 - Implement code coverage JSAPI. r=nbp,jwalden
Evan Welsh <2943271+ewlsh@users.noreply.github.com> - Sat, 08 Aug 2020 03:23:31 +0000 - rev 544003
Push 123751 by abutkovits@mozilla.com at Sat, 08 Aug 2020 03:47:32 +0000
Bug 1654696 - Implement code coverage JSAPI. r=nbp,jwalden Differential Revision: https://phabricator.services.mozilla.com/D85808
920beb95b042d91ef8efba97ac1109c5bdc81059: Bug 1223932 - remove mfbt/GuardObjects.h; r=jwalden
Nathan Froyd <froydnj@mozilla.com> - Fri, 31 Jul 2020 18:58:32 +0000 - rev 543121
Push 123238 by nfroyd@mozilla.com at Mon, 03 Aug 2020 14:13:34 +0000
Bug 1223932 - remove mfbt/GuardObjects.h; r=jwalden We no longer need this for reasons outlined in the previous commit. Depends on D85168 Differential Revision: https://phabricator.services.mozilla.com/D85169
23c9686e257b5922fd9c6d80b5909e6bebd3559c: Bug 1654094 - Update ICU care-and-feeding docs for automatic big-endian support. r=jwalden
Mike Hommey <mh+mozilla@glandium.org> - Fri, 31 Jul 2020 18:58:05 +0000 - rev 543014
Push 123167 by mh@glandium.org at Sat, 01 Aug 2020 06:38:56 +0000
Bug 1654094 - Update ICU care-and-feeding docs for automatic big-endian support. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D85358
d9daf481f520ad61960773b15a3c1c44e28b8675: Bug 1223932 - delete guard object uses from the tree; r=jwalden
Nathan Froyd <froydnj@mozilla.com> - Thu, 30 Jul 2020 14:22:38 +0000 - rev 542639
Push 123010 by malexandru@mozilla.com at Thu, 30 Jul 2020 15:44:14 +0000
Bug 1223932 - delete guard object uses from the tree; r=jwalden CLOSED TREE We don't need these macros anymore, for two reasons: 1. We have static analysis to provide the same sort of checks via `MOZ_RAII` and friends. 2. clang now warns for the "temporary that should have been a declaration" case. The extra requirements on class construction also show up during debug tests as performance problems. This change was automated by using the following sed script: ``` # Remove declarations in classes. /MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d /MOZ_GUARD_OBJECT_NOTIFIER_INIT/d # Remove individual macros, carefully. { # We don't have to worry about substrings here because the closing # parenthesis "anchors" the match. s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g; # Remove the longer identifier first. s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g; s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g; } # Remove the actual include. \@# *include "mozilla/GuardObjects.h"@d ``` and running: ``` find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null mach clang-format ``` Differential Revision: https://phabricator.services.mozilla.com/D85168
ac9c811bc427ed15bca6b1b6410cf1f9f1ea8a59: Bug 1223932 - delete guard object uses from the tree; r=jwalden
Nathan Froyd <froydnj@mozilla.com> - Thu, 30 Jul 2020 14:22:38 +0000 - rev 542631
Push 123003 by nfroyd@mozilla.com at Thu, 30 Jul 2020 14:25:04 +0000
Bug 1223932 - delete guard object uses from the tree; r=jwalden We don't need these macros anymore, for two reasons: 1. We have static analysis to provide the same sort of checks via `MOZ_RAII` and friends. 2. clang now warns for the "temporary that should have been a declaration" case. The extra requirements on class construction also show up during debug tests as performance problems. This change was automated by using the following sed script: ``` # Remove declarations in classes. /MOZ_DECL_USE_GUARD_OBJECT_NOTIFIER/d /MOZ_GUARD_OBJECT_NOTIFIER_INIT/d # Remove individual macros, carefully. { # We don't have to worry about substrings here because the closing # parenthesis "anchors" the match. s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_TO_PARENT)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)/)/g; s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_IN_IMPL)/)/g; # Remove the longer identifier first. s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM_TO_PARENT//g; s/MOZ_GUARD_OBJECT_NOTIFIER_ONLY_PARAM//g; } # Remove the actual include. \@# *include "mozilla/GuardObjects.h"@d ``` and running: ``` find . -name \*.cpp -o -name \*.h | grep -v 'GuardObjects.h' |xargs sed -i -f script 2>/dev/null mach clang-format ``` Differential Revision: https://phabricator.services.mozilla.com/D85168
73c606e0647d1a1a43da4b476e3a4f388ec00464: Bug 1652914 - Part 2: Remove unused MOZ_STATIC_ASSERT macro. r=jwalden
Chris Peterson <cpeterson@mozilla.com> - Fri, 17 Jul 2020 02:48:36 +0000 - rev 542588
Push 122969 by cpeterson@mozilla.com at Thu, 30 Jul 2020 06:26:07 +0000
Bug 1652914 - Part 2: Remove unused MOZ_STATIC_ASSERT macro. r=jwalden Depends on D83736 Differential Revision: https://phabricator.services.mozilla.com/D83737
14853017df3574ba696bfc601d9993a38208255c: Bug 1652914 - Part 1: Replace MOZ_STATIC_ASSERT with static_assert in C code. r=jwalden
Chris Peterson <cpeterson@mozilla.com> - Fri, 17 Jul 2020 02:48:19 +0000 - rev 542587
Push 122969 by cpeterson@mozilla.com at Thu, 30 Jul 2020 06:26:07 +0000
Bug 1652914 - Part 1: Replace MOZ_STATIC_ASSERT with static_assert in C code. r=jwalden static_assert is available in both C++11 and C11. While C++11's static_assert is a keyword, C11's static_assert is a macro defined in assert.h (that expands to the C11 keywoard _Static_assert). libar's header files are included in both C and C++ code, so we must #include assert.h to use static_assert. https://en.cppreference.com/w/c/language/_Static_assert Differential Revision: https://phabricator.services.mozilla.com/D83736
7a48c29889f0df5bbd5d7376d6e20a53c37a73c3: Bug 1655169 - Use AsyncIteratorHelperPrototypeClass as protoclass. r=jwalden
Adam Vandolder <avandolder@mozilla.com> - Fri, 24 Jul 2020 21:54:05 +0000 - rev 542127
Push 122655 by avandolder@mozilla.com at Fri, 24 Jul 2020 22:50:19 +0000
Bug 1655169 - Use AsyncIteratorHelperPrototypeClass as protoclass. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D84863
b3837fc631658eb4dd4261fe086279984f6311ae: Bug 1653292: Update range of accepted numbers for fractionalSecondDigits. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 24 Jul 2020 11:07:02 +0000 - rev 542025
Push 122580 by archaeopteryx@coole-files.de at Fri, 24 Jul 2020 11:43:01 +0000
Bug 1653292: Update range of accepted numbers for fractionalSecondDigits. r=jwalden `DefaultNumberOption()` was updated to allow `fallback` to be `undefined` and the code was slightly reordered to match the current spec text. "fractionalSecondDigits" can now also be handled in the common loop to detect if it is present when either "dateStyle" or "timeStyle" is used. Differential Revision: https://phabricator.services.mozilla.com/D83948
5c653e761010abe911bdd2166276551ed2cd0b46: Bug 1653291 - Part 4: Require 'locales' and 'options' arguments. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 24 Jul 2020 09:30:41 +0000 - rev 542024
Push 122580 by archaeopteryx@coole-files.de at Fri, 24 Jul 2020 11:43:01 +0000
Bug 1653291 - Part 4: Require 'locales' and 'options' arguments. r=jwalden Drive-by change: Enable now passing test262 tests which weren't updated in the last test262 update. Differential Revision: https://phabricator.services.mozilla.com/D83947
0f66e6b2e06c216a8d8a1f16c89b2a8d5942225d: Bug 1653291 - Part 3: Zero initialise the script and region char arrays. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 24 Jul 2020 09:29:03 +0000 - rev 542023
Push 122580 by archaeopteryx@coole-files.de at Fri, 24 Jul 2020 11:43:01 +0000
Bug 1653291 - Part 3: Zero initialise the script and region char arrays. r=jwalden Zero initialisation is cheap for this case (two `mov` for script and a single `mov` for region types). Differential Revision: https://phabricator.services.mozilla.com/D83946
c57a391c70639ece732ac2b2899de634d5be97c8: Bug 1653291 - Part 2: Canonicalise "month" for Intl.DisplayNames. r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 24 Jul 2020 09:30:39 +0000 - rev 542022
Push 122580 by archaeopteryx@coole-files.de at Fri, 24 Jul 2020 11:43:01 +0000
Bug 1653291 - Part 2: Canonicalise "month" for Intl.DisplayNames. r=jwalden "month" is the only date-time type which may return an empty string (only for Undecimber, though). Handle this case and also assert all other date-time types always return a non-empty result. Differential Revision: https://phabricator.services.mozilla.com/D83945
29b831c685f0736894e4e5236cfecedfeedc3dab: Bug 1653291 - Part 1: Canonicalise input arguments to Intl.DisplayNames.p.of(). r=jwalden
André Bargull <andre.bargull@gmail.com> - Fri, 24 Jul 2020 09:30:31 +0000 - rev 542021
Push 122580 by archaeopteryx@coole-files.de at Fri, 24 Jul 2020 11:43:01 +0000
Bug 1653291 - Part 1: Canonicalise input arguments to Intl.DisplayNames.p.of(). r=jwalden Moves the fallback handling from JS into C++ code, because the language, script, and region tags were already canonicalised in C++, so handling the fallback path in C++ altogether avoids repeated canonicalisation. Drive-by: Change `Intl_DisplayNames_of` to call `ToString(code)` before `getDisplayNamesInternals()` following comments from a previous review. Differential Revision: https://phabricator.services.mozilla.com/D83944
5bbe7e5166e7ff7eb9f7594d942d8d6b6eb691c9: Bug 1606568 - Add public BigInt API. r=jwalden
Philip Chimento <philip.chimento@gmail.com> - Wed, 22 Jul 2020 02:53:06 +0000 - rev 541560
Push 122335 by csabou@mozilla.com at Wed, 22 Jul 2020 03:27:04 +0000
Bug 1606568 - Add public BigInt API. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D82480
18a0675bd755d8bad9a5825e43f94294f4375da9: Bug 1606568 - Prevent excessive instantiation of BigInt parsing template. r=jwalden
Philip Chimento <philip.chimento@gmail.com> - Wed, 22 Jul 2020 02:54:05 +0000 - rev 541559
Push 122335 by csabou@mozilla.com at Wed, 22 Jul 2020 03:27:04 +0000
Bug 1606568 - Prevent excessive instantiation of BigInt parsing template. r=jwalden Differential Revision: https://phabricator.services.mozilla.com/D82479