searching for reviewer(jonco)
a3f7beb7db59c8dee686f2786a5831ec80beec3a: Bug 1617287 - Eliminate race on copying of element pointer when allocating an inner function JSScript r=jonco
Matthew Gaudet <mgaudet@mozilla.com> - Mon, 24 Feb 2020 18:16:06 +0000 - rev 515323
Push 108150 by mgaudet@mozilla.com at Mon, 24 Feb 2020 19:28:04 +0000
Bug 1617287 - Eliminate race on copying of element pointer when allocating an inner function JSScript r=jonco Depends on D63889 Differential Revision: https://phabricator.services.mozilla.com/D63890
7885d7f5a7f72389a7e2831baad7d7899c0cf4f7: Bug 1617413 - Fixes for running hazard analysis on developer systems r=jonco
Steve Fink <sfink@mozilla.com> - Mon, 24 Feb 2020 17:14:46 +0000 - rev 515321
Push 108149 by sfink@mozilla.com at Mon, 24 Feb 2020 19:27:09 +0000
Bug 1617413 - Fixes for running hazard analysis on developer systems r=jonco Differential Revision: https://phabricator.services.mozilla.com/D63776
67d3214edd947a39fd992776a45144e158d7db91: Bug 1617144 - Look in multiple places for a usable `quote()` function r=jonco
Steve Fink <sfink@mozilla.com> - Mon, 24 Feb 2020 17:38:46 +0000 - rev 515320
Push 108149 by sfink@mozilla.com at Mon, 24 Feb 2020 19:27:09 +0000
Bug 1617144 - Look in multiple places for a usable `quote()` function r=jonco Differential Revision: https://phabricator.services.mozilla.com/D63755
02c6807e387b0164650749db0a1885ba165e06ff: Bug 1614518 - Implement `mach hazards` command set for running the GC rooting hazard analysis. r=ahal,jonco,froydnj
Steve Fink <sfink@mozilla.com> - Thu, 20 Feb 2020 18:27:50 +0000 - rev 514833
Push 107858 by sfink@mozilla.com at Thu, 20 Feb 2020 18:36:33 +0000
Bug 1614518 - Implement `mach hazards` command set for running the GC rooting hazard analysis. r=ahal,jonco,froydnj Differential Revision: https://phabricator.services.mozilla.com/D62384
987a7f91bc32e15bd27798e17d05ba9bc66eae90: Bug 1615145 - Combine JSScript and LazyScript GC arena. r=jonco
Ted Campbell <tcampbell@mozilla.com> - Thu, 13 Feb 2020 11:49:50 +0000 - rev 513777
Push 107238 by tcampbell@mozilla.com at Thu, 13 Feb 2020 14:40:57 +0000
Bug 1615145 - Combine JSScript and LazyScript GC arena. r=jonco Combine AllocKind::SCRIPT and AllocKind::LAZY_SCRIPT arenas. This impacts code that scans the arenas directly but required checks were added in a previous patch. This removes background finalization of those LazyScript types. Depends on D62687 Differential Revision: https://phabricator.services.mozilla.com/D62688
4db8bac77334902afec3850352b4ab3c468673e3: Bug 1615143 - Eliminate TraceKind::LazyScript. r=jonco
Ted Campbell <tcampbell@mozilla.com> - Thu, 13 Feb 2020 14:33:33 +0000 - rev 513774
Push 107238 by tcampbell@mozilla.com at Thu, 13 Feb 2020 14:40:57 +0000
Bug 1615143 - Eliminate TraceKind::LazyScript. r=jonco Now that JSScript and LazyScript share a trace method, we can use a single TraceKind within the GC. To acheive this we also must remove eager marking of LazyScripts. Differential Revision: https://phabricator.services.mozilla.com/D62681
92dd7149719c1537792107db865bedbc5f87688c: Bug 1610193 - Do not proxy-preserve weakmap keys with a darker color than the map itself r=jonco
Steve Fink <sfink@mozilla.com> - Tue, 11 Feb 2020 11:26:14 +0000 - rev 513388
Push 106985 by sfink@mozilla.com at Tue, 11 Feb 2020 17:11:42 +0000
Bug 1610193 - Do not proxy-preserve weakmap keys with a darker color than the map itself r=jonco Differential Revision: https://phabricator.services.mozilla.com/D62077
626d523c3f035b5691f77bdecd9268fc17856a89: Bug 1608808 - Part 12: Automatically generate shell-option string for WeakRef tests. r=jonco
André Bargull <andre.bargull@gmail.com> - Tue, 28 Jan 2020 12:46:56 +0000 - rev 512024
Push 106118 by ccoroiu@mozilla.com at Tue, 28 Jan 2020 13:04:08 +0000
Bug 1608808 - Part 12: Automatically generate shell-option string for WeakRef tests. r=jonco This makes it easier to update test262, because it's no longer required to manually mark each WeakRef test in js/src/tests/jstests.list. Differential Revision: https://phabricator.services.mozilla.com/D60512
16255d8df9bd956958a0df0ecf7d24becd2e9756: Bug 1603330 - Update test to prevent JIT keeps the retval of wr.deref(). r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 23 Jan 2020 14:15:51 +0000 - rev 511506
Push 105838 by allstars.chh@gmail.com at Thu, 23 Jan 2020 15:31:41 +0000
Bug 1603330 - Update test to prevent JIT keeps the retval of wr.deref(). r=jonco Move allocation into a function call can prevent JIT keeps the return value of weakRef.deref(). Differential Revision: https://phabricator.services.mozilla.com/D60662
a9b4a04062431d0cf74ba0ffb0143dc447d76845: Bug 1604829 - Increment mark count only when the cell is marked. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 23 Jan 2020 13:20:40 +0000 - rev 511504
Push 105836 by allstars.chh@gmail.com at Thu, 23 Jan 2020 15:30:10 +0000
Bug 1604829 - Increment mark count only when the cell is marked. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D60832
382b9d9cfb25725c2e82a3917a7294297eeb49a3: Bug 1610621 : ClearKeptObjects() should return undefined. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Wed, 22 Jan 2020 11:03:20 +0000 - rev 511222
Push 105720 by allstars.chh@gmail.com at Wed, 22 Jan 2020 19:31:29 +0000
Bug 1610621 : ClearKeptObjects() should return undefined. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D60633
f4da27fec1c49193e7935535f14c57f1a03760c6: Bug 1609636 - Part 2: Add mochitests for WeakRef in browser. r=smaug,jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 20 Jan 2020 12:35:30 +0000 - rev 510719
Push 105483 by allstars.chh@gmail.com at Mon, 20 Jan 2020 13:02:58 +0000
Bug 1609636 - Part 2: Add mochitests for WeakRef in browser. r=smaug,jonco Differential Revision: https://phabricator.services.mozilla.com/D60155
5764c08f9aecff99d862fb57bc9d725c62558000: Bug 1609636 - Part 1: Add ClearKeptObjects API. r=jonco,smaug
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Mon, 20 Jan 2020 12:49:11 +0000 - rev 510718
Push 105483 by allstars.chh@gmail.com at Mon, 20 Jan 2020 13:02:58 +0000
Bug 1609636 - Part 1: Add ClearKeptObjects API. r=jonco,smaug From WeakRef proposal, [1], ECMAScript implementations are expected to call ClearKeptObjects when a synchronous sequence of ECMAScript execution completes. [1]: https://tc39.es/proposal-weakrefs/#sec-clear-kept-objects Differential Revision: https://phabricator.services.mozilla.com/D60154
412e576fe9939431630821f80a7c9c4954fccc85: Bug 1608128 - Check if records have been cleared. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 10 Jan 2020 15:16:46 +0000 - rev 509916
Push 104929 by allstars.chh@gmail.com at Mon, 13 Jan 2020 10:00:33 +0000
Bug 1608128 - Check if records have been cleared. r=jonco To fix the failure in test262/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js Differential Revision: https://phabricator.services.mozilla.com/D59500
d4ac3919864b67e16a86cee704cdea47bad6dff7: Bug 1607215 - Prevent data race in gcState_ between main thread and sweepMarkTask. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 09 Jan 2020 15:35:05 +0000 - rev 509584
Push 104696 by allstars.chh@gmail.com at Thu, 09 Jan 2020 15:40:29 +0000
Bug 1607215 - Prevent data race in gcState_ between main thread and sweepMarkTask. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D59343
912fed7c57108c93f42f3ef0c99ed8aad2a1cebc: Bug 1603701 - Part 4: define clearKeptObjects in test262-host.js. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 09 Jan 2020 14:14:08 +0000 - rev 509582
Push 104694 by allstars.chh@gmail.com at Thu, 09 Jan 2020 15:21:00 +0000
Bug 1603701 - Part 4: define clearKeptObjects in test262-host.js. r=jonco clearKeptObjects will be called in asyncGCDeref. This is needed for the following test: test262/built-ins/WeakRef/prototype/deref/gc-cleanup-not-prevented-with-wr-deref.js Differential Revision: https://phabricator.services.mozilla.com/D59305
7eaae56528c4ede59fcd699ee7fe6ef44a7a6e5a: Bug 1603701 - Part 3: fix WeakRef failure. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 09 Jan 2020 14:13:17 +0000 - rev 509581
Push 104694 by allstars.chh@gmail.com at Thu, 09 Jan 2020 15:21:00 +0000
Bug 1603701 - Part 3: fix WeakRef failure. r=jonco To fix the failures in: js/src/tests/test262/built-ins/WeakRef/length.js test262/built-ins/WeakRef/prototype/deref/length.js Differential Revision: https://phabricator.services.mozilla.com/D59304
0bfe04276fe3ef96058cdfe826f638b43090053f: Bug 1603701 - Part 2: update WeakRef tests in test262. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 09 Jan 2020 15:06:38 +0000 - rev 509580
Push 104694 by allstars.chh@gmail.com at Thu, 09 Jan 2020 15:21:00 +0000
Bug 1603701 - Part 2: update WeakRef tests in test262. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D59303
16dadfc1d2ef54e9a9ebc81a5ebfde6e330b38f9: Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 09 Jan 2020 15:06:36 +0000 - rev 509579
Push 104694 by allstars.chh@gmail.com at Thu, 09 Jan 2020 15:21:00 +0000
Bug 1603701 - Part 1: Enable test262 WeakRef tests on infra. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D59302
9be6fc42a26ff4663b83a56f2b1244f4552ed27b: Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Tue, 07 Jan 2020 14:50:21 +0000 - rev 509322
Push 104553 by allstars.chh@gmail.com at Wed, 08 Jan 2020 08:23:14 +0000
Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco Throw error if the wrapped WeakRef is a dead wrapper. Also do the checking earlier so we can bail out early before setting the target slot. Differential Revision: https://phabricator.services.mozilla.com/D58522
f27409c81df2264eeccee5740da195ad581bf94c: Bug 1167452 - When verifying weakmap marking, consider whether key's zone is collecting r=jonco
Steve Fink <sfink@mozilla.com> - Tue, 07 Jan 2020 09:43:42 +0000 - rev 509214
Push 104522 by sfink@mozilla.com at Tue, 07 Jan 2020 22:34:13 +0000
Bug 1167452 - When verifying weakmap marking, consider whether key's zone is collecting r=jonco Differential Revision: https://phabricator.services.mozilla.com/D58860
3d6643bfcb63fb86c13027d573b91ce9735c5a7c: Bug 1606745 - Prevent debug functions from being discarded during linking r=jonco
Steve Fink <sfink@mozilla.com> - Mon, 06 Jan 2020 18:46:58 +0000 - rev 508992
Push 104364 by sfink@mozilla.com at Mon, 06 Jan 2020 21:19:19 +0000
Bug 1606745 - Prevent debug functions from being discarded during linking r=jonco Differential Revision: https://phabricator.services.mozilla.com/D58581
048554c9449e103f296b6d66bb265ed370fd4d17: Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Fri, 03 Jan 2020 13:01:10 +0000 - rev 508767
Push 104187 by allstars.chh@gmail.com at Fri, 03 Jan 2020 14:16:15 +0000
Bug 1605633 - Check if it's a dead wrapper in WeakRef constructor. r=jonco Throw error if the wrapped WeakRef is a dead wrapper. Differential Revision: https://phabricator.services.mozilla.com/D58522
ee35112c00d17ba5cbf2777ec837e6084890c484: Bug 1605066 part 2 - Don't track property types for non-singleton environment objects. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Fri, 20 Dec 2019 03:18:45 +0000 - rev 507997
Push 103734 by jdemooij@mozilla.com at Fri, 20 Dec 2019 06:51:09 +0000
Bug 1605066 part 2 - Don't track property types for non-singleton environment objects. r=jonco Ion is only interested in the global lexical environment, a singleton. Don't waste time tracking property types for other environments. Depends on D57776 Differential Revision: https://phabricator.services.mozilla.com/D57777
404d35386c05f241abc1f7e507623e0536e435fd: Bug 1605066 part 1 - Tidy up and de-duplicate environment object allocation code. r=jonco
Jan de Mooij <jdemooij@mozilla.com> - Fri, 20 Dec 2019 03:18:45 +0000 - rev 507996
Push 103734 by jdemooij@mozilla.com at Fri, 20 Dec 2019 06:51:09 +0000
Bug 1605066 part 1 - Tidy up and de-duplicate environment object allocation code. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D57776
7c86675ec7b24b6e6c7c953196aa18c7b264f076: Bug 1584892 - Use the default max nursery size for workers in the shell r=jonco
Paul Bone <pbone@mozilla.com> - Mon, 16 Dec 2019 10:26:27 +0000 - rev 507328
Push 103364 by pbone@mozilla.com at Mon, 16 Dec 2019 23:17:39 +0000
Bug 1584892 - Use the default max nursery size for workers in the shell r=jonco Differential Revision: https://phabricator.services.mozilla.com/D47871
d1ac49b9eb3efcc46210bb7ad810c80ba74f7dd7: Bug 1587093 - Implement WeakRef object in js shell. r=jonco
Yoshi Cheng-Hao Huang <allstars.chh@gmail.com> - Thu, 12 Dec 2019 21:19:11 +0000 - rev 506843
Push 103110 by allstars.chh@gmail.com at Fri, 13 Dec 2019 06:09:19 +0000
Bug 1587093 - Implement WeakRef object in js shell. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D51789
48aeab9d789798196928c97a10659c32b973d823: Bug 1602480 - Move tracing of BaseScript::data_ into BaseScript::traceChildren. r=jonco
Ted Campbell <tcampbell@mozilla.com> - Mon, 09 Dec 2019 19:13:33 +0000 - rev 506256
Push 102765 by tcampbell@mozilla.com at Tue, 10 Dec 2019 14:22:29 +0000
Bug 1602480 - Move tracing of BaseScript::data_ into BaseScript::traceChildren. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D56383
3f5b37785d2a68d614bf4d58dad74cd22d096331: Bug 1599659 - Predicate to test context for live SABs. r=jonco
Lars T Hansen <lhansen@mozilla.com> - Thu, 05 Dec 2019 18:36:21 +0000 - rev 505705
Push 102436 by lhansen@mozilla.com at Thu, 05 Dec 2019 18:36:56 +0000
Bug 1599659 - Predicate to test context for live SABs. r=jonco SABs become foreground-finalizable so that we can access the runtime during finalization. Then a simple counter on the runtime will track live SABs for the runtime, and the predicate on the context can get its information from the runtime. Fallout: SABs are now enabled on the globals used for jsapi-tests. Differential Revision: https://phabricator.services.mozilla.com/D55783
cb6ec14a123ad63a9c0e2fc9f86427902dbe5c79: Bug 1552363 - Initialize FreeSpan in default constructor r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 05 Dec 2019 17:35:49 +0000 - rev 505701
Push 102432 by sfink@mozilla.com at Thu, 05 Dec 2019 18:22:08 +0000
Bug 1552363 - Initialize FreeSpan in default constructor r=jonco Differential Revision: https://phabricator.services.mozilla.com/D55879
2921275a761f948319c743f15a4f9031efaf730b: Bug 1599659 - Predicate to test context for live SABs. r=jonco
Lars T Hansen <lhansen@mozilla.com> - Thu, 05 Dec 2019 14:54:24 +0000 - rev 505651
Push 102402 by lhansen@mozilla.com at Thu, 05 Dec 2019 14:56:19 +0000
Bug 1599659 - Predicate to test context for live SABs. r=jonco SABs become foreground-finalizable so that we can access the runtime during finalization. Then a simple counter on the runtime will track live SABs for the runtime, and the predicate on the context can get its information from the runtime. Fallout: SABs are now enabled on the globals used for jsapi-tests. Differential Revision: https://phabricator.services.mozilla.com/D55783
dead6c366e3ea4bdfb964041167ba00a57d117fb: Bug 1596943 - DEBUG-only diagnostics for weakmap marking problems r=jonco
Steve Fink <sfink@mozilla.com> - Wed, 04 Dec 2019 18:08:28 +0000 - rev 505515
Push 102310 by sfink@mozilla.com at Wed, 04 Dec 2019 18:12:00 +0000
Bug 1596943 - DEBUG-only diagnostics for weakmap marking problems r=jonco Differential Revision: https://phabricator.services.mozilla.com/D55715
1f2f66ee67038c614a2da8f65e50b886d5c42d05: Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco
Ted Campbell <tcampbell@mozilla.com> - Mon, 02 Dec 2019 14:31:04 +0000 - rev 505035
Push 102114 by shindli@mozilla.com at Tue, 03 Dec 2019 09:53:21 +0000
Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco Allow storing manually-barriered GC pointers in ScriptWarmUpData. This updates the 'trace' method as needed. When switching types, the user must first 'clear' the old type and then 'init' the new type. We continue to use WarmUpCount(0) as the default safe state. Depends on D55033 Differential Revision: https://phabricator.services.mozilla.com/D55034
bb3d55c2eb0510c072bd5a33995ecd838532de42: Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco
Ted Campbell <tcampbell@mozilla.com> - Mon, 02 Dec 2019 19:38:28 +0000 - rev 504946
Push 102056 by tcampbell@mozilla.com at Mon, 02 Dec 2019 20:19:30 +0000
Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco Allow storing manually-barriered GC pointers in ScriptWarmUpData. This updates the 'trace' method as needed. When switching types, the user must first 'clear' the old type and then 'init' the new type. We continue to use WarmUpCount(0) as the default safe state. Depends on D55033 Differential Revision: https://phabricator.services.mozilla.com/D55034
9c728f162f0ae034639861cbd1cb44932a4bfeed: Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 05:51:09 +0000 - rev 504926
Push 102042 by sfink@mozilla.com at Mon, 02 Dec 2019 18:33:28 +0000
Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54580
745bab598970274b9b1dc050aef274c781e3f89d: Bug 1597206 - Refactor GCMarker state management r=jonco
Steve Fink <sfink@mozilla.com> - Mon, 02 Dec 2019 18:25:14 +0000 - rev 504925
Push 102042 by sfink@mozilla.com at Mon, 02 Dec 2019 18:33:28 +0000
Bug 1597206 - Refactor GCMarker state management r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54579
a6b2ec4c398101c0f363ec654ed499d1c75f4d5f: Bug 1597206 - Refactor enterWeakMarkingMode slightly r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 05:51:06 +0000 - rev 504924
Push 102042 by sfink@mozilla.com at Mon, 02 Dec 2019 18:33:28 +0000
Bug 1597206 - Refactor enterWeakMarkingMode slightly r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54564
3b0ec4d5b6d1f9ca6e9beb96b79237155adad944: Bug 1600596: Remove unused functions UninlinedIsInsideNursery and PushArena. r=jonco
André Bargull <andre.bargull@gmail.com> - Mon, 02 Dec 2019 17:18:03 +0000 - rev 504920
Push 102038 by apavel@mozilla.com at Mon, 02 Dec 2019 18:23:29 +0000
Bug 1600596: Remove unused functions UninlinedIsInsideNursery and PushArena. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D55435
7074213657a3908c2805fa75d8dcebb76bc64ea1: Bug 1474914: Skip elementsRangeWriteBarrierPost for nursery objects. r=jonco
André Bargull <andre.bargull@gmail.com> - Mon, 02 Dec 2019 12:50:30 +0000 - rev 504856
Push 102001 by apavel@mozilla.com at Mon, 02 Dec 2019 14:35:48 +0000
Bug 1474914: Skip elementsRangeWriteBarrierPost for nursery objects. r=jonco `StoreBuffer::putSlot` when called with a nursery object as its `obj` parameter is a no-op, because `StoreBuffer::put` is a no-op when `Edge::maybeInRememberedSet` return false, which, in the case of `SlotsEdge`, happens when `SlotsEdge::object()` is in the nursery. This enables us to skip the linear traversal of the elements array in `elementsRangeWriteBarrierPost` when the current object is in the nursery. Differential Revision: https://phabricator.services.mozilla.com/D55420
5ea098cc9ef02f4391d2ed8c8f0a64625a9042fa: Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco
Ted Campbell <tcampbell@mozilla.com> - Mon, 02 Dec 2019 14:31:04 +0000 - rev 504850
Push 102000 by tcampbell@mozilla.com at Mon, 02 Dec 2019 14:34:16 +0000
Bug 1591598 - Support storing LazyScript/Scope in ScriptWarmUpData. r=jandem,jonco Allow storing manually-barriered GC pointers in ScriptWarmUpData. This updates the 'trace' method as needed. When switching types, the user must first 'clear' the old type and then 'init' the new type. We continue to use WarmUpCount(0) as the default safe state. Depends on D55033 Differential Revision: https://phabricator.services.mozilla.com/D55034
38cc7c4b3c011e4309ea651e11051003cf9ec6a0: Bug 1600149 - Don't cleanup coverage in Realm::finishRoots. r=jonco
Ted Campbell <tcampbell@mozilla.com> - Fri, 29 Nov 2019 14:00:37 +0000 - rev 504725
Push 101914 by tcampbell@mozilla.com at Fri, 29 Nov 2019 14:56:04 +0000
Bug 1600149 - Don't cleanup coverage in Realm::finishRoots. r=jonco The coverage tables stored on the Zone are weak references. Entries are removed when JSScripts are finalized. This patch removes the erroneous calls to clearScriptLCov in Realm::finishRoots. Without this, the map gets destroyed during shutdown before it is finished being used by the JSScript finalizers. Differential Revision: https://phabricator.services.mozilla.com/D55183
273f738dab5f1de2229c5d5148ea8be94f91fdef: Bug 1600019 - Part 5: Avoid rooting a handle-value. r=jonco
André Bargull <andre.bargull@gmail.com> - Fri, 29 Nov 2019 12:34:15 +0000 - rev 504710
Push 101903 by dluca@mozilla.com at Fri, 29 Nov 2019 12:41:26 +0000
Bug 1600019 - Part 5: Avoid rooting a handle-value. r=jonco Depends on D55089 Differential Revision: https://phabricator.services.mozilla.com/D55090
3de775ee7d0eb9a927898978f1a5ffa8c56c80ba: Bug 1600019 - Part 4: Prefer js::Call over JS::Call for engine-internal calls. r=jonco
André Bargull <andre.bargull@gmail.com> - Thu, 28 Nov 2019 16:56:37 +0000 - rev 504709
Push 101903 by dluca@mozilla.com at Fri, 29 Nov 2019 12:41:26 +0000
Bug 1600019 - Part 4: Prefer js::Call over JS::Call for engine-internal calls. r=jonco `js::Call` avoids copying the arguments into a separate `InvokeArgs` struct, therefore it's generally preferred for calls within SpiderMonkey. Depends on D55088 Differential Revision: https://phabricator.services.mozilla.com/D55089
bc921ac2bd1b711a0fc309ed73e6baf87afda730: Bug 1600019 - Part 3: Use NewObjectWithGivenProto when |prototype| argument is guaranteed to be non-null. r=jonco
André Bargull <andre.bargull@gmail.com> - Thu, 28 Nov 2019 16:56:37 +0000 - rev 504708
Push 101903 by dluca@mozilla.com at Fri, 29 Nov 2019 12:41:26 +0000
Bug 1600019 - Part 3: Use NewObjectWithGivenProto when |prototype| argument is guaranteed to be non-null. r=jonco `NewObjectWithClassProto` when called with a non-null prototype calls `NewObjectWithGivenTaggedProto`, but that function can be called more directly through `NewObjectWithGivenProto`. Depends on D55087 Differential Revision: https://phabricator.services.mozilla.com/D55088
ad0a7949dd8ee263de1fa1cecb26eb10a9c23f8e: Bug 1600019 - Part 2: Handle the case when FinalizationRecordVectorObject's records slot is uninitialised. r=jonco
André Bargull <andre.bargull@gmail.com> - Thu, 28 Nov 2019 16:56:37 +0000 - rev 504707
Push 101903 by dluca@mozilla.com at Fri, 29 Nov 2019 12:41:26 +0000
Bug 1600019 - Part 2: Handle the case when FinalizationRecordVectorObject's records slot is uninitialised. r=jonco Depends on D55086 Differential Revision: https://phabricator.services.mozilla.com/D55087
889b0858a957583778a29f6296e501ad4e10d485: Bug 1600019 - Part 1: Handle OOM in registerWithFinalizationGroup. r=jonco
André Bargull <andre.bargull@gmail.com> - Thu, 28 Nov 2019 16:56:36 +0000 - rev 504706
Push 101903 by dluca@mozilla.com at Fri, 29 Nov 2019 12:41:26 +0000
Bug 1600019 - Part 1: Handle OOM in registerWithFinalizationGroup. r=jonco Differential Revision: https://phabricator.services.mozilla.com/D55086
93dc2c1e666ad116c51c5c566346d441ef6b8f4c: Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 00:51:00 +0000 - rev 504179
Push 101791 by nerli@mozilla.com at Thu, 28 Nov 2019 04:25:16 +0000
Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54580
f8cb8d38ae2fb35b8fd532ec894efff30704bd2a: Bug 1597206 - Refactor GCMarker state management r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 00:49:37 +0000 - rev 504178
Push 101791 by nerli@mozilla.com at Thu, 28 Nov 2019 04:25:16 +0000
Bug 1597206 - Refactor GCMarker state management r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54579
54a221309941ac058828583de00b6b0902e6bcd8: Bug 1597206 - Refactor enterWeakMarkingMode slightly r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 00:49:30 +0000 - rev 504177
Push 101791 by nerli@mozilla.com at Thu, 28 Nov 2019 04:25:16 +0000
Bug 1597206 - Refactor enterWeakMarkingMode slightly r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54564
334b41001234a56dcb32fe26792d9d730db9eea0: Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco
Steve Fink <sfink@mozilla.com> - Thu, 28 Nov 2019 00:51:00 +0000 - rev 504170
Push 101785 by sfink@mozilla.com at Thu, 28 Nov 2019 00:55:46 +0000
Bug 1597206 - Do not populate weak keys during RegularMarking yet, and allow aborting weak marking during RegularMarking r=jonco Differential Revision: https://phabricator.services.mozilla.com/D54580