searching for reviewer(handyman)
d31313f495aa20866d041d044cca726b570f392c: Bug 1657404 - Add diag asserts to catch potential double IPDL shutdown r=handyman
Chris Martin <cmartin@mozilla.com> - Mon, 04 Jan 2021 20:38:39 +0000 - rev 561942
Push 133493 by cmartin@mozilla.com at Mon, 04 Jan 2021 21:36:04 +0000
Bug 1657404 - Add diag asserts to catch potential double IPDL shutdown r=handyman Based on evidence from crash reports in Bug 1682589, there may be a bug where IPDL intermittently calls `ActorDestroy()` twice on GamepadEventChannelParent, leading to a crash. This attempts to catch this behavior in Nightly (assuming that I'm correct and it does exist). If not, I will have to find some other explanation for the crash behavior from that bug. Differential Revision: https://phabricator.services.mozilla.com/D100714
f737176fe4c7c6bb742315b5fcc44acc7e75af3d: Bug 1657404 - Back out changeset 6792f28b99bd keeping 349854c5ad56 r=handyman
Chris Martin <cmartin@mozilla.com> - Thu, 17 Dec 2020 18:21:06 +0000 - rev 561169
Push 133056 by cmartin@mozilla.com at Thu, 17 Dec 2020 18:50:35 +0000
Bug 1657404 - Back out changeset 6792f28b99bd keeping 349854c5ad56 r=handyman Differential Revision: https://phabricator.services.mozilla.com/D100031
bb64138c956e3fe1e3edf0e6b437586720c3ea38: Bug 1680955 - Update FallbackGamepad to use new GamepadHandle type r=handyman
Chris Martin <cmartin@mozilla.com> - Tue, 08 Dec 2020 17:27:04 +0000 - rev 559877
Push 132316 by cmartin@mozilla.com at Tue, 08 Dec 2020 18:47:01 +0000
Bug 1680955 - Update FallbackGamepad to use new GamepadHandle type r=handyman Starting with one of my earlier patches in Bug 1657404, FreeBSD started seeing an error, ``` ld.lld: error: undefined hidden symbol: mozilla::dom::SetGamepadLightIndicatorColor ``` We don't build this codepath as part of our regular Firefox testing, and so I didn't see the issue. Luckily, Jan Beich <jbeich@FreeBSD.org> noticed the issue and offered up this patch. They unfortunately can't be given credit because they are protesting our requirement for 2FA in Phabricator. Differential Revision: https://phabricator.services.mozilla.com/D98973
ec6a64b639a82e957376c09a71aef7ce62b3a5aa: Bug 1657404 - Implement a strongly-typed, service-dependent gamepad handle r=handyman,aklotz
Chris Martin <cmartin@mozilla.com> - Wed, 02 Dec 2020 23:06:05 +0000 - rev 559161
Push 131976 by cmartin@mozilla.com at Wed, 02 Dec 2020 23:24:22 +0000
Bug 1657404 - Implement a strongly-typed, service-dependent gamepad handle r=handyman,aklotz Currently, the gamepad code uses a uint32_t as a handle and does some trickery with it by trying to create a unique ID and adding an offset to it for VR code. This can (and has) led to errors where the developer forgets to perform the arithmetic and sends the wrong number to the wrong manager. This change created a strongly-typed handle that remembers which service it belongs to. This should eliminate such accidents. Differential Revision: https://phabricator.services.mozilla.com/D96273
6792f28b99bdd9a218d3cac9b07db5a1c70c83ea: Bug 1657404 - Refactor GamepadPlatformService r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 02 Dec 2020 22:36:35 +0000 - rev 559160
Push 131976 by cmartin@mozilla.com at Wed, 02 Dec 2020 23:24:22 +0000
Bug 1657404 - Refactor GamepadPlatformService r=handyman A substantial refactor of GamepadPlatformService: 1. Easier to understand lifetime 2. Correct usage of mutexes to protect shared state 3. Clear separation of "service owner" and "service user" 4. Simplify logic in some places 5. Better variable names Differential Revision: https://phabricator.services.mozilla.com/D96664
349854c5ad56f0885a5b84ba80f881b9ac9900ff: Bug 1657404 - Gamepad: Make a singleton to hold monitoring observers r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 02 Dec 2020 22:32:30 +0000 - rev 559159
Push 131976 by cmartin@mozilla.com at Wed, 02 Dec 2020 23:24:22 +0000
Bug 1657404 - Gamepad: Make a singleton to hold monitoring observers r=handyman Currently, the list of monitoring observers is stored in the GamepadPlatformService. But it's possible for testing to start before an event channel has been created, or to exist longer. That could result in the GamepadPlatformManager being created-destroyed multiple times along with this list. Probably the simplest thing to do here is just have the list be its own indepedent entity Differential Revision: https://phabricator.services.mozilla.com/D96663
0ce25a58f2f43ed4f4e186ec97ba128a723b2c5d: Bug 1657404 - Move gamepad test promise logic to GamepadServiceTest r=handyman
Chris Martin <cmartin@mozilla.com> - Tue, 10 Nov 2020 22:31:37 +0000 - rev 556681
Push 130681 by cmartin@mozilla.com at Tue, 10 Nov 2020 22:34:02 +0000
Bug 1657404 - Move gamepad test promise logic to GamepadServiceTest r=handyman Currently, this promise is being created at one level of abstraction but fulfilled at another. This will be important soon, as this promise is about to become more complex. Differential Revision: https://phabricator.services.mozilla.com/D96270
5ea464cd1c26e39dbcb40658bf09b98430b4590c: Bug 1657404 - Change GamepadManager to explicitly have 1 event channel r=handyman
Chris Martin <cmartin@mozilla.com> - Thu, 15 Oct 2020 17:47:32 +0000 - rev 553222
Push 128766 by cmartin@mozilla.com at Thu, 15 Oct 2020 19:23:01 +0000
Bug 1657404 - Change GamepadManager to explicitly have 1 event channel r=handyman Currently, the GamepadManager contains an nsTArray of event channels. However, logically the code only ever allows this array to have either 0 or 1 entries. This change replaces the nsTArray with a nullable pointer. Differential Revision: https://phabricator.services.mozilla.com/D93594
e818ba719e0f51c01bc2e257390228406a92cbc5: Bug 1657404 - Change PGamepadTestChannel to "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 14 Oct 2020 20:33:55 +0000 - rev 553066
Push 128674 by cmartin@mozilla.com at Wed, 14 Oct 2020 21:04:50 +0000
Bug 1657404 - Change PGamepadTestChannel to "refcounted protocol" r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93023
219491bd4447adef0e9a20d4db227adf65f76a37: Bug 1657404 - Prepare GamepadTestChannelChild for "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 14 Oct 2020 20:33:32 +0000 - rev 553065
Push 128674 by cmartin@mozilla.com at Wed, 14 Oct 2020 21:04:50 +0000
Bug 1657404 - Prepare GamepadTestChannelChild for "refcounted protocol" r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93022
29eb6e04191769bb4594af06346326cf03c3ec45: Bug 1657404 - Prepare GamepadTestChannelParent for "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 14 Oct 2020 20:33:13 +0000 - rev 553064
Push 128674 by cmartin@mozilla.com at Wed, 14 Oct 2020 21:04:50 +0000
Bug 1657404 - Prepare GamepadTestChannelParent for "refcounted protocol" r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93021
c5a399870fbaf51c138ed64506cf6aaeea05b929: Bug 1657404 - Remove old IPDL workaround from GamepadTestChannelParent r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 14 Oct 2020 20:32:56 +0000 - rev 553063
Push 128674 by cmartin@mozilla.com at Wed, 14 Oct 2020 21:04:50 +0000
Bug 1657404 - Remove old IPDL workaround from GamepadTestChannelParent r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93019
8132dd9390233328c8da7072f36859424a2b079d: Bug 1657404 - Change PGamepadEventChannel to "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 14 Oct 2020 15:58:36 +0000 - rev 553024
Push 128651 by cmartin@mozilla.com at Wed, 14 Oct 2020 16:01:03 +0000
Bug 1657404 - Change PGamepadEventChannel to "refcounted protocol" r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93119
5729967eff6d48c5aa73641f5e89caaf59df9cb7: Bug 1657404 - Use WeakPtr for observer pattern in GamepadPlatformService r=handyman
Chris Martin <cmartin@mozilla.com> - Fri, 09 Oct 2020 16:42:53 +0000 - rev 552544
Push 128362 by cmartin@mozilla.com at Fri, 09 Oct 2020 17:59:40 +0000
Bug 1657404 - Use WeakPtr for observer pattern in GamepadPlatformService r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93085
a79143c550d76146e692c1f16ee4a93552655a8f: Bug 1657404 - Change PGamepadTestChannel to "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Fri, 09 Oct 2020 16:42:30 +0000 - rev 552513
Push 128355 by cmartin@mozilla.com at Fri, 09 Oct 2020 17:22:29 +0000
Bug 1657404 - Change PGamepadTestChannel to "refcounted protocol" r=handyman Depends on D93022 Differential Revision: https://phabricator.services.mozilla.com/D93023
ae904c76b6cc078513ec55803396773b67a5ca75: Bug 1657404 - Prepare GamepadTestChannelChild for "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Fri, 09 Oct 2020 16:42:17 +0000 - rev 552512
Push 128355 by cmartin@mozilla.com at Fri, 09 Oct 2020 17:22:29 +0000
Bug 1657404 - Prepare GamepadTestChannelChild for "refcounted protocol" r=handyman Depends on D93021 Differential Revision: https://phabricator.services.mozilla.com/D93022
b225f6a01afeaf6368ab71f890132a3e4d52bbe6: Bug 1657404 - Prepare GamepadTestChannelParent for "refcounted protocol" r=handyman
Chris Martin <cmartin@mozilla.com> - Fri, 09 Oct 2020 16:42:09 +0000 - rev 552511
Push 128355 by cmartin@mozilla.com at Fri, 09 Oct 2020 17:22:29 +0000
Bug 1657404 - Prepare GamepadTestChannelParent for "refcounted protocol" r=handyman Depends on D93019 Differential Revision: https://phabricator.services.mozilla.com/D93021
e6e1924fb688aaabfef3b12453b84bddd489e1a1: Bug 1657404 - Remove old IPDL workaround from GamepadTestChannelParent r=handyman
Chris Martin <cmartin@mozilla.com> - Fri, 09 Oct 2020 16:41:41 +0000 - rev 552510
Push 128355 by cmartin@mozilla.com at Fri, 09 Oct 2020 17:22:29 +0000
Bug 1657404 - Remove old IPDL workaround from GamepadTestChannelParent r=handyman Differential Revision: https://phabricator.services.mozilla.com/D93019
b7881b7504732f8e9b9aa832921a2e2fff4e32dc: Bug 1658416 - Defer simulated gamepad adds until monitoring starts r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 07 Oct 2020 17:25:24 +0000 - rev 551965
Push 128145 by cmartin@mozilla.com at Wed, 07 Oct 2020 20:33:32 +0000
Bug 1658416 - Defer simulated gamepad adds until monitoring starts r=handyman Since the test code will be waiting on a promise from the addGamepad message, we can simply defer fulfilling the promise until monitoring starts if it hasn't already. Since every other message relies on the index given by the fulfilled promise, it ensures that we won't get any simulated events until monitoring starts Differential Revision: https://phabricator.services.mozilla.com/D86748
ed5c70dc6a6ca094174cd330b1f321090134904c: Bug 1658416 - Allow gamepad test channel to observe gamepad monitoring state r=handyman
Chris Martin <cmartin@mozilla.com> - Wed, 07 Oct 2020 17:25:26 +0000 - rev 551964
Push 128145 by cmartin@mozilla.com at Wed, 07 Oct 2020 20:33:32 +0000
Bug 1658416 - Allow gamepad test channel to observe gamepad monitoring state r=handyman Each existing GamepadTestChannel needs to know when gamepad monitoring is started or stopped so it knows whether it's safe to deliver messages. Differential Revision: https://phabricator.services.mozilla.com/D86747
09dab8d09582076c6d40bea47e22066e5c65f79e: Bug 1666571 - Part 2. Support CALL [disp32] for Avast. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 25 Sep 2020 23:18:02 +0000 - rev 550476
Push 127305 by cbrindusan@mozilla.com at Fri, 25 Sep 2020 23:56:15 +0000
Bug 1666571 - Part 2. Support CALL [disp32] for Avast. r=handyman The last Avast Antivirus's hook function contains `CALL [disp32]` instruction. Our detour needs to be able to handle that pattern. Differential Revision: https://phabricator.services.mozilla.com/D91155
01469002e85d42096e4b5094b955fe764e339afd: Bug 1666571 - Part 1. Support more patterns of OpCode 0xFF. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 25 Sep 2020 23:18:15 +0000 - rev 550475
Push 127305 by cbrindusan@mozilla.com at Fri, 25 Sep 2020 23:56:15 +0000
Bug 1666571 - Part 1. Support more patterns of OpCode 0xFF. r=handyman This patch optimizes our detour's code handling Opcode 0xFF, expanding its coverage to INC and DEC reg64 as well as PUSH and CALL. Testcases for these scenarios are of course included. Differential Revision: https://phabricator.services.mozilla.com/D91154
8d3754d87d25cbbd014f2a88cd52e217f00e2c9a: Bug 1665486 - Disable CFG for FunctionBroker hook returns r=handyman
David Major <dmajor@mozilla.com> - Thu, 24 Sep 2020 17:28:18 +0000 - rev 550202
Push 127162 by dmajor@mozilla.com at Thu, 24 Sep 2020 17:32:04 +0000
Bug 1665486 - Disable CFG for FunctionBroker hook returns r=handyman Due to a bug in clang, some brokered function thunks don't get CFG-approved. As a workaround this patch disables CFG when we return to the original thunks. Note that, unlike previous issues with CFG and hooks, this affects 64-bit builds too. Differential Revision: https://phabricator.services.mozilla.com/D91181
67acd8531789a0294b99b616e51c64273d29052b: Bug 1665486 - Disable CFG for FunctionBroker hook returns r=handyman
David Major <dmajor@mozilla.com> - Thu, 24 Sep 2020 07:38:29 +0000 - rev 550166
Push 127140 by dmajor@mozilla.com at Thu, 24 Sep 2020 14:04:41 +0000
Bug 1665486 - Disable CFG for FunctionBroker hook returns r=handyman Due to a bug in clang, some brokered function thunks don't get CFG-approved. As a workaround this patch disables CFG when we return to the original thunks. Note that, unlike previous issues with CFG and hooks, this affects 64-bit builds too. Differential Revision: https://phabricator.services.mozilla.com/D91181
9c8401590bab1719ff59b0bb4460048b5634b770: Bug 1665351 - Disable CFG for plugin hook stub calls r=handyman
David Major <dmajor@mozilla.com> - Fri, 18 Sep 2020 16:27:03 +0000 - rev 549343
Push 126707 by dmajor@mozilla.com at Fri, 18 Sep 2020 18:01:22 +0000
Bug 1665351 - Disable CFG for plugin hook stub calls r=handyman As we saw in bug 1598119, 32-bit nop-space patches aren't compatible with clang 11's CFG because they return to the second instruction of the hooked function. The `FunctionHook`s for plugins were pulling raw function pointers out of the interceptor stubs, so they didn't get the benefit of the stub's `operator()` that already has the CFG annotation. As a bandaid, this patch marks all users of `BasicFunctionHook::OriginalFunction()` with the CFG annotation as well. A more thorough fix might be to somehow pass through to the stub's `operator()`, but we need something before merge day and I'm not confident in being able to do that regression-free in time. Differential Revision: https://phabricator.services.mozilla.com/D90629
109f3a4de56716d3e1162c2368fe37b8a377f72f: Bug 1660886 - Release PWebGL when ClientWebGLContext is done with it. r=handyman,jld
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 27 Aug 2020 00:50:32 +0000 - rev 546651
Push 125150 by jgilbert@mozilla.com at Thu, 27 Aug 2020 17:33:03 +0000
Bug 1660886 - Release PWebGL when ClientWebGLContext is done with it. r=handyman,jld Differential Revision: https://phabricator.services.mozilla.com/D88067
84d533ce303cb4018207a33e9502fe8d4a935cda: Bug 1659398 - Don't resolve redirecion of JMP for DuplicateHandle. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 26 Aug 2020 20:26:36 +0000 - rev 546373
Push 125072 by cbrindusan@mozilla.com at Wed, 26 Aug 2020 21:34:34 +0000
Bug 1659398 - Don't resolve redirecion of JMP for DuplicateHandle. r=handyman In Win7 and later, some exported functions in kernel32.dll are just a stub jumping to a function in kernelbase.dll. After the fix for Bug 1642626, our detour resolves such a stub in kernel32.dll and detours a corresponding function in kernelbase.dll. This new behavior caused a problem in Win8 when we detour `DuplicateHandle` because our detour cannot handle the assembly pattern of `KERNELBASE!DuplicateHandle`. Win8's `KERNELBASE!DuplicateHandle` has jump instructions whose destination is within the region where we move instructions to a trampoline. In the example below, the address `000007f954ad271c` is a destination of the `JMP` instructions, but when we detour `KERNELBASE!DuplicateHandle`, we move the original instructions to a trampoline, and that address will point to an invalid instruction, jumping to which address causes a crash. A proposed fix is to detour `KERNEL32!DuplicateHandle` without resolving redirection, that is the behavior before bug 1642626. ``` KERNEL32!DuplicateHandle: 000007f9`54cd2d5c ff2556b61100 jmp qword ptr [KERNEL32!_imp_DuplicateHandle] --> KERNELBASE!DuplicateHandle ``` ``` KERNELBASE!DuplicateHandle: 000007f9`54ad2710 4883ec48 sub rsp,48h 000007f9`54ad2714 4c8bd1 mov r10,rcx 000007f9`54ad2717 83faf4 cmp edx,0FFFFFFF4h 000007f9`54ad271a 733b jae KERNELBASE!DuplicateHandle+0x43 (000007f9`54ad2757) 000007f9`54ad271c 8b842480000000 mov eax,dword ptr [rsp+80h] ... 000007f9`54b8f0de 65488b042560000000 mov rax,qword ptr gs:[60h] 000007f9`54b8f0e7 488b5020 mov rdx,qword ptr [rax+20h] 000007f9`54b8f0eb 488b5220 mov rdx,qword ptr [rdx+20h] 000007f9`54b8f0ef e92836f4ff jmp KERNELBASE!DuplicateHandle+0xc (000007f9`54ad271c) 000007f9`54b8f0f4 65488b042560000000 mov rax,qword ptr gs:[60h] 000007f9`54b8f0fd 488b5020 mov rdx,qword ptr [rax+20h] 000007f9`54b8f101 488b5228 mov rdx,qword ptr [rdx+28h] 000007f9`54b8f105 e91236f4ff jmp KERNELBASE!DuplicateHandle+0xc (000007f9`54ad271c) 000007f9`54b8f10a 65488b042560000000 mov rax,qword ptr gs:[60h] 000007f9`54b8f113 488b5020 mov rdx,qword ptr [rax+20h] 000007f9`54b8f117 488b5230 mov rdx,qword ptr [rdx+30h] 000007f9`54b8f11b e9fc35f4ff jmp KERNELBASE!DuplicateHandle+0xc (000007f9`54ad271c) ``` Differential Revision: https://phabricator.services.mozilla.com/D88136
5dfbee61f2540fa8d7658274514e020fe14c2b53: Bug 1655680 - Support JAE rel32 in our detour. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 05 Aug 2020 07:21:00 +0000 - rev 543354
Push 123404 by dluca@mozilla.com at Wed, 05 Aug 2020 07:27:44 +0000
Bug 1655680 - Support JAE rel32 in our detour. r=handyman After the fix for bug 1642626, we need to detour `KERNELBASE!CloseHandle` instead of K32's stub, which contains `JAE rel32`. I also found a mistake in the fix for bug 1642626. When we put a conditional jump in a trampoline, we need to reverse a condition, but the JAE case mistakenly filled JAE straight. This patch corrects it to filling JB. Differential Revision: https://phabricator.services.mozilla.com/D85477
978c7a6ddb55e53f9230112f5455a4970ee5d7b4: Bug 1607940 - IPC TexImage. r=lsalzman,nika,handyman
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 21 Jul 2020 22:57:01 +0000 - rev 541538
Push 122321 by jgilbert@mozilla.com at Tue, 21 Jul 2020 23:08:39 +0000
Bug 1607940 - IPC TexImage. r=lsalzman,nika,handyman Differential Revision: https://phabricator.services.mozilla.com/D83291
282eafdb9753ab010a385419bb3138ae22b56fa6: Bug 1607940 - Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj
Jeff Gilbert <jgilbert@mozilla.com> - Tue, 21 Jul 2020 22:56:52 +0000 - rev 541536
Push 122321 by jgilbert@mozilla.com at Tue, 21 Jul 2020 23:08:39 +0000
Bug 1607940 - Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj * Use clearer pref names. * Default (and only support) IPDL dispatching. * Make DispatchCommands async-only. * Sync ipdl command per sync webgl entrypoint. * Eat the boilerplate cost, since there's not too many. * Run SerializedSize off same path as Serialize. * All shmem uploads go through normal DispatchCommands. * Defer pruning of dead code for now so we can iterate quickly. * Use Read/Write(begin,end) instead of (begin,size). * This would have prevented a bug where we read/wrote N*sizeof(T)*sizeof(T). Differential Revision: https://phabricator.services.mozilla.com/D81495
0381f81c9c08479d0ecca2a250132f6fac50ab8b: Bug 1601792: Remove VMSharingPolicyShared's template parameters and use inline variables instead; r=handyman
Aaron Klotz <aklotz@mozilla.com> - Wed, 15 Jul 2020 17:43:30 +0000 - rev 541492
Push 122286 by aklotz@mozilla.com at Tue, 21 Jul 2020 19:33:48 +0000
Bug 1601792: Remove VMSharingPolicyShared's template parameters and use inline variables instead; r=handyman Differential Revision: https://phabricator.services.mozilla.com/D83573
afc05ca167e72fbb3d4d8c3aec0c396e0f0aae0d: Bug 1652463: Add rule to allow socket process to create server side of our IPC pipes. r=handyman
Bob Owen <bobowencode@gmail.com> - Mon, 20 Jul 2020 18:00:42 +0000 - rev 541431
Push 122238 by bobowencode@gmail.com at Tue, 21 Jul 2020 12:37:14 +0000
Bug 1652463: Add rule to allow socket process to create server side of our IPC pipes. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D83976
4d3569a5cd9f51997729b7c33df1737b59ee6bbc: Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert
Doug Thayer <dothayer@mozilla.com> - Wed, 08 Jul 2020 02:46:46 +0000 - rev 539264
Push 121020 by dothayer@mozilla.com at Wed, 08 Jul 2020 02:50:46 +0000
Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert Depends on D77634 Differential Revision: https://phabricator.services.mozilla.com/D79536
21605186687e044a1421b41f94260800d241ccd0: Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert
Doug Thayer <dothayer@mozilla.com> - Tue, 07 Jul 2020 17:04:34 +0000 - rev 539190
Push 120987 by dothayer@mozilla.com at Tue, 07 Jul 2020 19:30:47 +0000
Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert Depends on D77634 Differential Revision: https://phabricator.services.mozilla.com/D79536
fc144caf5d065041df3359c5cb1d7d9e997c93b8: Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert
Doug Thayer <dothayer@mozilla.com> - Tue, 07 Jul 2020 04:36:34 +0000 - rev 539055
Push 120895 by dothayer@mozilla.com at Tue, 07 Jul 2020 05:17:36 +0000
Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert Depends on D77634 Differential Revision: https://phabricator.services.mozilla.com/D79536
313b964013b697fd4844e18831ccd8f9b0b31be7: Bug 1642626 - Part3: Handle a detour pattern of multple jumps. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 02 Jul 2020 16:43:14 +0000 - rev 538492
Push 120613 by cbrindusan@mozilla.com at Thu, 02 Jul 2020 19:08:02 +0000
Bug 1642626 - Part3: Handle a detour pattern of multple jumps. r=handyman AVG AntiVirus hooks ntdll!NtMapViewOfSection by planting two JMP instructions, jumping to a trampoline area first, then jumping to aswhook.dll. ``` ntdll!NtMapViewOfSection: 00007ffa`6d77c560 e9d33cfebf jmp 00007ffa`2d760238 00007ffa`2d760238 ff25f2ffffff jmp qword ptr [00007ffa`2d760230] --> 00007ffa`541e2ad0 aswhook+0x2ad0: 00007ffa`541e2ad0 4055 push rbp 00007ffa`541e2ad2 53 push rbx 00007ffa`541e2ad3 56 push rsi ``` With this patch, our detour can detour on top of that pattern. The first part is to remove the MEM_IMAGE check from IsPageAccessible. The second part is to introduce a loop in ResolveRedirectedAddress to resolve a chain of jumps. Differential Revision: https://phabricator.services.mozilla.com/D81582
9e7f867825890e1156f62f1c5d29dd42d224a9f7: Bug 1642626 - Part2: Handle JAE and Opcode83 on x64 without REX Prefix. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 02 Jul 2020 16:43:01 +0000 - rev 538491
Push 120613 by cbrindusan@mozilla.com at Thu, 02 Jul 2020 19:08:02 +0000
Bug 1642626 - Part2: Handle JAE and Opcode83 on x64 without REX Prefix. r=handyman Depends on D81580 Differential Revision: https://phabricator.services.mozilla.com/D81581
9b129ac9f2d76c3aef651eb47360f4224cdd8211: Bug 1642626 - Part1: Take out jump detection from ReadOnlyTargetFunction. r=handyman
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 02 Jul 2020 16:42:54 +0000 - rev 538490
Push 120613 by cbrindusan@mozilla.com at Thu, 02 Jul 2020 19:08:02 +0000
Bug 1642626 - Part1: Take out jump detection from ReadOnlyTargetFunction. r=handyman This patch moves the logics of jump detection from ResolveRedirectedAddress to ReadOnlyTargetFunction to simplify ReadOnlyTargetFunction. Differential Revision: https://phabricator.services.mozilla.com/D81580
699212a443c35f37bc998f21cad29cb9fc2e8c95: Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert
Doug Thayer <dothayer@mozilla.com> - Thu, 02 Jul 2020 02:51:49 +0000 - rev 538384
Push 120542 by dothayer@mozilla.com at Thu, 02 Jul 2020 06:48:01 +0000
Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert Depends on D77634 Differential Revision: https://phabricator.services.mozilla.com/D79536
cf23b456ba12548659a8cea0ab16ba6aa0b63c13: Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert
Doug Thayer <dothayer@mozilla.com> - Wed, 01 Jul 2020 17:10:05 +0000 - rev 538305
Push 120502 by dothayer@mozilla.com at Wed, 01 Jul 2020 18:06:04 +0000
Bug 1627075 - Include WebGLParent.h in WebGLChild.h r=handyman,jgilbert Depends on D77634 Differential Revision: https://phabricator.services.mozilla.com/D79536
35af9c8f56b539ff30ae4f750a1d3725e99c2eb3: Bug 1629419 - Replaced size call with .empty r=handyman
nd419 <5161147+neeldug@users.noreply.github.com> - Thu, 25 Jun 2020 13:22:07 +0000 - rev 537430
Push 119984 by cbrindusan@mozilla.com at Thu, 25 Jun 2020 14:36:36 +0000
Bug 1629419 - Replaced size call with .empty r=handyman Differential Revision: https://phabricator.services.mozilla.com/D80049
f5eed997b2588b113920456f980d6c36c3f9cff8: Bug 1629419 - Replaced size call with .empty r=handyman
nd419 <5161147+neeldug@users.noreply.github.com> - Tue, 23 Jun 2020 12:29:40 +0000 - rev 536903
Push 119693 by ccoroiu@mozilla.com at Tue, 23 Jun 2020 12:31:43 +0000
Bug 1629419 - Replaced size call with .empty r=handyman Differential Revision: https://phabricator.services.mozilla.com/D80037
2739940a4fb7b7e4bd4f1ec3907a2b286b3fbe8d: Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 15 Jun 2020 18:26:07 +0000 - rev 535741
Push 119048 by jgilbert@mozilla.com at Mon, 15 Jun 2020 18:27:39 +0000
Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D79014
fd4a74ec97a5d9540157f30dfc6184031c2499ac: Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 15 Jun 2020 18:26:02 +0000 - rev 535739
Push 119048 by jgilbert@mozilla.com at Mon, 15 Jun 2020 18:27:39 +0000
Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D78800
16c5dd2cfd600a62c80ca17cfb35c0868e016056: Bug 1632249 - Support compositing out-of-process WebGL. r=handyman,lsalzman,nical,geckoview-reviewers,agi,imanol
Jeff Gilbert <jgilbert@mozilla.com> - Mon, 15 Jun 2020 18:25:55 +0000 - rev 535736
Push 119048 by jgilbert@mozilla.com at Mon, 15 Jun 2020 18:27:39 +0000
Bug 1632249 - Support compositing out-of-process WebGL. r=handyman,lsalzman,nical,geckoview-reviewers,agi,imanol * Majorly simplity CanvasRenderer * Replace GLScreenBuffer with trivial GLSwapChain * Use descriptor structs so that future SharedSurface changes aren't so painful to propagate * Mortgage/strip out more OffscreenCanvas code for now Differential Revision: https://phabricator.services.mozilla.com/D75055
d5b7fe789001225baaab1ceee4ed1f8ec9021292: Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 11 Jun 2020 06:37:50 +0000 - rev 535053
Push 118699 by jgilbert@mozilla.com at Thu, 11 Jun 2020 06:39:18 +0000
Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D79014
6f19f43e0a0bad72fa370191f4cc7f86f58566c2: Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 11 Jun 2020 06:37:40 +0000 - rev 535051
Push 118699 by jgilbert@mozilla.com at Thu, 11 Jun 2020 06:39:18 +0000
Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D78800
204b899f436d99f0eae759af3ccfcbaabfbbb428: Bug 1632249 - Support compositing out-of-process WebGL. r=handyman,lsalzman,nical,geckoview-reviewers,agi,imanol
Jeff Gilbert <jgilbert@mozilla.com> - Thu, 11 Jun 2020 06:37:35 +0000 - rev 535048
Push 118699 by jgilbert@mozilla.com at Thu, 11 Jun 2020 06:39:18 +0000
Bug 1632249 - Support compositing out-of-process WebGL. r=handyman,lsalzman,nical,geckoview-reviewers,agi,imanol * Majorly simplity CanvasRenderer * Replace GLScreenBuffer with trivial GLSwapChain * Use descriptor structs so that future SharedSurface changes aren't so painful to propagate * Mortgage/strip out more OffscreenCanvas code for now Differential Revision: https://phabricator.services.mozilla.com/D75055
c93972b05d4f105953213185bd4e0da2403dedd1: Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Wed, 10 Jun 2020 22:21:19 +0000 - rev 535007
Push 118674 by jgilbert@mozilla.com at Wed, 10 Jun 2020 22:22:33 +0000
Bug 1632249 - Mark mCapturedFrameInvalidated even if mIsCanvasDirty. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D79014
b15d91e64a2589d47ad023d61dbd45135669eb60: Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman
Jeff Gilbert <jgilbert@mozilla.com> - Wed, 10 Jun 2020 22:21:09 +0000 - rev 535005
Push 118674 by jgilbert@mozilla.com at Wed, 10 Jun 2020 22:22:33 +0000
Bug 1632249 - NON_PREMULT TextureClient iff NON_PREMULT CanvasClient. r=handyman Differential Revision: https://phabricator.services.mozilla.com/D78800