searching for reviewer(gw)
f613e818e43507bc9f900f3756a6921890427775: Bug 1550582 - Add wrench reftest r=gw
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:45:25 +0000 - rev 473926
Push 85539 by jnicol@mozilla.com at Wed, 15 May 2019 10:46:49 +0000
Bug 1550582 - Add wrench reftest r=gw Rename the old overlapping corners testcase and add comments to make the tests' purposes clearer: * The existing one is testing that a corner is clipped correctly when it overlaps with an adjacent corner. * The new one is testing that corners and segments are clipped correctly when opposite edges of the border overlap. Depends on D30814 Differential Revision: https://phabricator.services.mozilla.com/D30815
93299787ec39d62a5832b7494fd3cf5dcdcbca7c: Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw
Jamie Nicol <jnicol@mozilla.com> - Wed, 15 May 2019 10:43:25 +0000 - rev 473925
Push 85539 by jnicol@mozilla.com at Wed, 15 May 2019 10:46:49 +0000
Bug 1550582 - Ensure the overlap is filled correctly when opposite border edges overlap. r=gw To fix bug 1496540 it was made so that webrender clips border corner segments so that they do not overlap with their opposing edges. However, cases where opposing _edges_ both overlap with eachother (rather than just a corner overlapping with an edge), the corners are clipped too far and a gap is left in the middle. Additionally, no clipping was added to the edge segments. So rather than there be a gap there is an area that is painted twice, which is apparent if the colour is semi-transparent. This fixes these issues by identifying when opposing edges overlap and calculating the midpoint, then clipping the edges and corners to that midpoint instead. Differential Revision: https://phabricator.services.mozilla.com/D30814
73254a69497b209b372ed209ce9d004080ea8052: Bug 1532174 - Repace WR RelativeTransform with CoordinateSpaceMapping, improve flattening semantics. r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Fri, 10 May 2019 02:22:51 +0000 - rev 473396
Push 85202 by dmalyshau@mozilla.com at Fri, 10 May 2019 11:44:12 +0000
Bug 1532174 - Repace WR RelativeTransform with CoordinateSpaceMapping, improve flattening semantics. r=gw This change makes get_relative_transform() to no longer rely on any flattening done before in the pipeline. This makes it correct is some of the cases we failed previously (see ini files removed). It now does flattening on every flat coordinate system it passes through, and it's used for SpaceMapper. The old RelativeTransform is now replaced with CoordinateSpaceMapping, which reduces the zoo of our types :) Differential Revision: https://phabricator.services.mozilla.com/D30600
2bcdd7ab7d95f0b24a920803df72b7e4525a96e9: Bug 1543974 - Add render task scheduling tests. r=gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 07 May 2019 17:25:27 +0200 - rev 473015
Push 84970 by ncsoregi@mozilla.com at Wed, 08 May 2019 03:42:10 +0000
Bug 1543974 - Add render task scheduling tests. r=gw Differential Revision: https://phabricator.services.mozilla.com/D30021
5a44b50a07cfcbc201d54f9adab7993a5815c34d: Bug 1532174 - Refactor WR fast transform, use when returning relative transforms r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 08 May 2019 02:32:15 +0000 - rev 473007
Push 84967 by dmalyshau@mozilla.com at Wed, 08 May 2019 02:33:12 +0000
Bug 1532174 - Refactor WR fast transform, use when returning relative transforms r=gw Based on https://phabricator.services.mozilla.com/D30229 Instead of converting from the scale-offset to the transform right away in `get_relative_transform`, we only do it if there is a jump between coordinate spaces. Differential Revision: https://phabricator.services.mozilla.com/D30228
a8b4591d504eef634e7c88e774591a84666cf8cc: Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark
Kartikaya Gupta <kgupta@mozilla.com> - Mon, 06 May 2019 12:16:15 +0000 - rev 472894
Push 84887 by kgupta@mozilla.com at Tue, 07 May 2019 13:35:15 +0000
Bug 1547833 - Check for the KHR_debug extension before trying to use it. r=gw,kvark Differential Revision: https://phabricator.services.mozilla.com/D29824
8f066e5c42c8d093eca140056720b3808065f7e7: Bug 1543974 - Add render task scheduling tests. r=gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 07 May 2019 03:03:16 +0000 - rev 472867
Push 84873 by nsilva@mozilla.com at Tue, 07 May 2019 08:09:19 +0000
Bug 1543974 - Add render task scheduling tests. r=gw Differential Revision: https://phabricator.services.mozilla.com/D30021
83e1c60d2283bb0141b0d26412db6b0b6b36b48c: Bug 1548635 - Add mechanism to skip wrench reftests on specific platforms. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 02 May 2019 20:49:08 +0000 - rev 472353
Push 84623 by kgupta@mozilla.com at Thu, 02 May 2019 20:50:52 +0000
Bug 1548635 - Add mechanism to skip wrench reftests on specific platforms. r=gw This allows us to blacklist certain configurations. Previously we could only use platform(...) which was more of a whitelist. Differential Revision: https://phabricator.services.mozilla.com/D29729
579ea06d0627df7728013d3aede49cfac61c82cd: Bug 1548635 - Some tweaks for wrench on Android. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 02 May 2019 20:49:07 +0000 - rev 472352
Push 84623 by kgupta@mozilla.com at Thu, 02 May 2019 20:50:52 +0000
Bug 1548635 - Some tweaks for wrench on Android. r=gw This makes some minor tweaks: - Use a /sdcard/wrench/ folder for the args and reftests. For me bundling the reftests as assets didn't work (app would panic trying to load those files). Plus it seems better to not always bundle the reftests with the app. - Always dump a full backtrace on Android - Build both x86 and armv7 architectures of wrench into the same APK for better compatibility. - Update documentation. Differential Revision: https://phabricator.services.mozilla.com/D29728
c0f3a0adee3ccb1bda58b1d0820bb1b961ec3c54: Bug 1548131 - WR reset texture allocation r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 01 May 2019 22:43:16 +0000 - rev 472239
Push 84534 by dmalyshau@mozilla.com at Thu, 02 May 2019 01:43:12 +0000
Bug 1548131 - WR reset texture allocation r=gw Introduce a new texture allocation operation "reset", which acts like a "realloc" but without the contents preserved. Use it for the picture texture cache. Differential Revision: https://phabricator.services.mozilla.com/D29539
09753a1a153d348d456a0c785fcffeb9a77dd065: Bug 1525420 - Use KHR_blend_equation_advanced for mix-blend mode implementation r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 01 May 2019 20:45:22 +0000 - rev 472177
Push 84510 by dmalyshau@mozilla.com at Wed, 01 May 2019 20:47:46 +0000
Bug 1525420 - Use KHR_blend_equation_advanced for mix-blend mode implementation r=gw Use natively supported mix-blend modes, where appropriate. Disabled by default. Differential Revision: https://phabricator.services.mozilla.com/D26350
f210be8c82a050a4ea525db1568e7c137d9038b1: Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark
Nicolas Silva <nsilva@mozilla.com> - Mon, 29 Apr 2019 17:53:00 +0200 - rev 472140
Push 84479 by apavel@mozilla.com at Wed, 01 May 2019 16:06:16 +0000
Bug 1533735 - Refactor render task pass assignment in preparation for the render graph work. r=gw,kvark In addition, batch together render tasks for the cached render tasks. Differential Revision: https://phabricator.services.mozilla.com/D23839
4521516e7c466d25f37c82d028204db6c0dacc2c: Bug 1525641 - Revise WR backface visibility semantics, separate picture and primitive logic r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Mon, 29 Apr 2019 16:45:38 +0000 - rev 471792
Push 84273 by dmalyshau@mozilla.com at Mon, 29 Apr 2019 17:46:43 +0000
Bug 1525641 - Revise WR backface visibility semantics, separate picture and primitive logic r=gw This changes our backface visibility semantics to a slightly more complex rule, as described by Matt (and reinterpret by me in the context of WR) in bug 1525641 during our work week. We are now propagating is_backface_visible to pictures and evaluate it in the context of the local transform for a picture if it's outside of preserve-3d context. We also refactor get_relative_transform() a bit. Note: this fixes all of the existing backface-visibility bugs: 1525641, 1546110, 1546818 It also passes the Wrench tests, but the try push is still pending for surprises. Differential Revision: https://phabricator.services.mozilla.com/D29009
a8eca5bd4f5bfe01d3df76d0ddb4fa255e4333ff: Bug 1542826 - Add a pref to control the debug server. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:31:11 +0000 - rev 471386
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Add a pref to control the debug server. r=gw Differential Revision: https://phabricator.services.mozilla.com/D28358
4cb155acf32fa409192e7b0ac2ded81a1c288016: Bug 1542826 - Rebuild the debugger front-end. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:31:09 +0000 - rev 471385
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Rebuild the debugger front-end. r=gw This patch is the output of rebuilding the debugger frontend with a recent npm installation. The changes to dist/ and the addition of package-lock.json are a result of the build. The changes to package.json and main.js were done manually to work around an incompatible change in beufy 0.6.7 (the lib/ folder changed to dist/). Differential Revision: https://phabricator.services.mozilla.com/D28357
6f62c7dd1b13c5397ac629ddf902c8fc1ba0ed28: Bug 1542826 - Add more debug flags to disable various things. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:29:15 +0000 - rev 471384
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Add more debug flags to disable various things. r=gw Differential Revision: https://phabricator.services.mozilla.com/D28356
004c7b730f409df214eca1aa529100f13a8d04a3: Bug 1542826 - Expose a mozconfig flag to build the WR debugger feature. r=gw,froydnj
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:31:16 +0000 - rev 471381
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Expose a mozconfig flag to build the WR debugger feature. r=gw,froydnj We can't yet enable the build by default since it pulls in networking functions into libgkrust which runs afoul of the checks added in bug 1376621. Differential Revision: https://phabricator.services.mozilla.com/D28353
59a08c05c327a26a92386a1f0da29f585994c1a3: Bug 1542826 - Allow enabling/disabling the debug server at runtime. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:28:32 +0000 - rev 471379
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Allow enabling/disabling the debug server at runtime. r=gw This adds a RendererOption flag to control whether the debug server is enabled. This allows the debug server feature to be built without enabling the feature by default; it can then be enabled on a per-renderer basis via the RendererOption. Differential Revision: https://phabricator.services.mozilla.com/D28352
e980a61a57d13ac9d17bf3de66fcd69bf21765ea: Bug 1542826 - Reduce featureset enabled on image crate. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Thu, 25 Apr 2019 19:28:23 +0000 - rev 471378
Push 84068 by kgupta@mozilla.com at Thu, 25 Apr 2019 20:46:09 +0000
Bug 1542826 - Reduce featureset enabled on image crate. r=gw The debugger in WebRender uses the image crate to generate PNGs, and so it only really needs the png codec feature from the image crate. Differential Revision: https://phabricator.services.mozilla.com/D28351
bc316493ddae00897a98f9a0601f9764e7c4daa9: Bug 1546371 - Switch render backend and API away from FramebufferPixel r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 25 Apr 2019 13:02:47 +0000 - rev 471315
Push 84031 by dmalyshau@mozilla.com at Thu, 25 Apr 2019 15:38:51 +0000
Bug 1546371 - Switch render backend and API away from FramebufferPixel r=gw The gist of the problem I introduced with the framebuffer coordinate system is that we provided the window rect (effectively) twice: 1. when computing the document rectangle (and Y-inverting it) 2. when rendering If between these points the window got resized (during scene building), we end up with our document aligned to bottom left corner. The user expects content to still be aligned to the top left, so that's what is visible as a bug. The change here switched scene building to only care about device coordinate space, restraining the framebuffer coordinates to be mostly an implementation detail of the renderer/device (the way it was originally meant to be, when introduced). This way the current window size is only considered once during rendering. Differential Revision: https://phabricator.services.mozilla.com/D28731
a2c91afc264b92185833dfb6ace3ca2d4a7c8c7e: Bug 1414961 - check for EXT_blend_func_extended when using GL ES. r=gw
Lee Salzman <lsalzman@mozilla.com> - Wed, 24 Apr 2019 05:15:04 +0000 - rev 470713
Push 83930 by lsalzman@mozilla.com at Wed, 24 Apr 2019 17:16:48 +0000
Bug 1414961 - check for EXT_blend_func_extended when using GL ES. r=gw Differential Revision: https://phabricator.services.mozilla.com/D28569
f3516e1416f00fc8e157effc0842c97929be362a: Bug 1542826 - Add a pref to control the debug server. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:57:27 +0000 - rev 470564
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Add a pref to control the debug server. r=gw Differential Revision: https://phabricator.services.mozilla.com/D28358
1dba743761b70dcf224def15834f5d32559ea72e: Bug 1542826 - Rebuild the debugger front-end. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:57:09 +0000 - rev 470563
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Rebuild the debugger front-end. r=gw This patch is the output of rebuilding the debugger frontend with a recent npm installation. The changes to dist/ and the addition of package-lock.json are a result of the build. The changes to package.json and main.js were done manually to work around an incompatible change in beufy 0.6.7 (the lib/ folder changed to dist/). Differential Revision: https://phabricator.services.mozilla.com/D28357
a02e469be7b353670593dc7ca2db4595cb01b30a: Bug 1542826 - Add more debug flags to disable various things. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:56:23 +0000 - rev 470562
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Add more debug flags to disable various things. r=gw Differential Revision: https://phabricator.services.mozilla.com/D28356
e5af8cd01080bb5a1008bdcecfffd7c5dfb66690: Bug 1542826 - Build the debugger feature in webrender by default. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:55:20 +0000 - rev 470559
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Build the debugger feature in webrender by default. r=gw This builds the feature but leaves it disabled by default at runtime. Differential Revision: https://phabricator.services.mozilla.com/D28353
314f9bc7dafe4595e64f5412c7bcac5b757da465: Bug 1542826 - Allow enabling/disabling the debug server at runtime. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:55:11 +0000 - rev 470558
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Allow enabling/disabling the debug server at runtime. r=gw This adds a RendererOption flag to control whether the debug server is enabled. This allows the debug server feature to be built without enabling the feature by default; it can then be enabled on a per-renderer basis via the RendererOption. Differential Revision: https://phabricator.services.mozilla.com/D28352
7df230ea51228062b25e0349512eb0471b582b8a: Bug 1542826 - Reduce featureset enabled on image crate. r=gw
Kartikaya Gupta <kgupta@mozilla.com> - Tue, 23 Apr 2019 19:55:06 +0000 - rev 470557
Push 83827 by kgupta@mozilla.com at Tue, 23 Apr 2019 19:59:11 +0000
Bug 1542826 - Reduce featureset enabled on image crate. r=gw The debugger in WebRender uses the image crate to generate PNGs, and so it only really needs the png codec feature from the image crate. Differential Revision: https://phabricator.services.mozilla.com/D28351
9550416c06abcb24b583cecc7cc09220e3208318: Bug 1536121 - rearchitect the webrender display-list. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 17:29:58 +0000 - rev 470536
Push 83811 by abeingessner@mozilla.com at Tue, 23 Apr 2019 17:31:46 +0000
Bug 1536121 - rearchitect the webrender display-list. r=gw disclaimer: this isn't an *amazing* cleanup, but more of a major step that unlocks the ability to do more minor cleanups and refinements. There's some messy things and inconsistencies here and there, but we can hopefully iron them out over time. 1. The primary change here is to move from struct { common_fields, enum(specific_fields) } to enum (maybe_common_fields, specific_fields) most notably this drops the common fields from a ton of things that don't need them PopXXX, SetXXX, ClipChain, etc. 2. Additionally some types have had some redundant states shaved off, for instance, rect no longer has *both* bounds and a clip_rect, as the intersection of the two can be used. This was done a bit conservatively as some adjustments will need to be done to the backend to fully eliminate some states, and this can be done more incrementally. 2.5. As a minor side-effect of 2, we now early-reject some primitives whose bounds and clip_rect are disjoint. 3. A HitTest display item has been added, which is just a Rect without color. In addition to the minor space wins from this, this makes it much easier to debug display lists 4. Adds a bunch of comments to the display list, making it easier to understand things. The end result of all these changes is a significantly smaller and easier to understand display list. Especially on pages like gmail which have so many clip chains. However this ultimately just makes text an even greater percentage of pages (often 70-80%). Differential Revision: https://phabricator.services.mozilla.com/D27439
63ab1f26526681b3a14ba1e839a9f0ad13eb390d: Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 17:29:38 +0000 - rev 470535
Push 83811 by abeingessner@mozilla.com at Tue, 23 Apr 2019 17:31:46 +0000
Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw * make all enums repr(u8) (compiler bug blocking this long fixed) * add display list stats feature * remove cache markers (abandoned design) * don't always push empty SetFilters before PushStackingContext * remove dead pub methods Differential Revision: https://phabricator.services.mozilla.com/D25845
0fc395a2ac7155ffece75daf20d103144374fbfe: Bug 1536121 - rearchitect the webrender display-list. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 02:32:50 +0000 - rev 470455
Push 83742 by abeingessner@mozilla.com at Tue, 23 Apr 2019 04:06:18 +0000
Bug 1536121 - rearchitect the webrender display-list. r=gw disclaimer: this isn't an *amazing* cleanup, but more of a major step that unlocks the ability to do more minor cleanups and refinements. There's some messy things and inconsistencies here and there, but we can hopefully iron them out over time. 1. The primary change here is to move from struct { common_fields, enum(specific_fields) } to enum (maybe_common_fields, specific_fields) most notably this drops the common fields from a ton of things that don't need them PopXXX, SetXXX, ClipChain, etc. 2. Additionally some types have had some redundant states shaved off, for instance, rect no longer has *both* bounds and a clip_rect, as the intersection of the two can be used. This was done a bit conservatively as some adjustments will need to be done to the backend to fully eliminate some states, and this can be done more incrementally. 2.5. As a minor side-effect of 2, we now early-reject some primitives whose bounds and clip_rect are disjoint. 3. A HitTest display item has been added, which is just a Rect without color. In addition to the minor space wins from this, this makes it much easier to debug display lists 4. Adds a bunch of comments to the display list, making it easier to understand things. The end result of all these changes is a significantly smaller and easier to understand display list. Especially on pages like gmail which have so many clip chains. However this ultimately just makes text an even greater percentage of pages (often 70-80%). Differential Revision: https://phabricator.services.mozilla.com/D27439
43003251156190b170a66b2c213d94d7d02cbf10: Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Tue, 23 Apr 2019 02:32:48 +0000 - rev 470454
Push 83742 by abeingessner@mozilla.com at Tue, 23 Apr 2019 04:06:18 +0000
Bug 1536121 - cleanup display list code a little bit to prep for refactor. r=gw * make all enums repr(u8) (compiler bug blocking this long fixed) * add display list stats feature * remove cache markers (abandoned design) * don't always push empty SetFilters before PushStackingContext * remove dead pub methods Differential Revision: https://phabricator.services.mozilla.com/D25845
f0c87ec1d694d43288d8ec0a01e290e753ccfeb4: Bug 1544374 - Make FilterOp not copy. r=gw
Nicolas Silva <nsilva@mozilla.com> - Tue, 16 Apr 2019 07:43:04 +0000 - rev 469675
Push 83280 by nsilva@mozilla.com at Tue, 16 Apr 2019 12:51:49 +0000
Bug 1544374 - Make FilterOp not copy. r=gw Differential Revision: https://phabricator.services.mozilla.com/D27480
9feaaddc3761202159be41a34280f3cec61a58d4: Bug 1444434 - Bind pixel pack buffer before trying to map it for readback r=gw
Barret Rennie <barret@brennie.ca> - Mon, 15 Apr 2019 23:39:10 +0000 - rev 469604
Push 83249 by brennie@mozilla.com at Mon, 15 Apr 2019 23:44:08 +0000
Bug 1444434 - Bind pixel pack buffer before trying to map it for readback r=gw Differential Revision: https://phabricator.services.mozilla.com/D26946
4febe6f32b23f8d40d597b6a6a9675ba989835bb: Bug 1525642 - ensure that w~=1 when assuming a transform is just a translation. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Thu, 11 Apr 2019 20:52:21 +0000 - rev 469100
Push 82971 by nerli@mozilla.com at Thu, 11 Apr 2019 20:57:55 +0000
Bug 1525642 - ensure that w~=1 when assuming a transform is just a translation. r=gw Differential Revision: https://phabricator.services.mozilla.com/D27163
c1073f5dd4992875f21bff35f87dfadb1253b43f: Bug 1538711 - Fix tile cache clip chain in WR r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 03 Apr 2019 16:28:19 +0000 - rev 467848
Push 82240 by dmalyshau@mozilla.com at Wed, 03 Apr 2019 22:07:32 +0000
Bug 1538711 - Fix tile cache clip chain in WR r=gw Differential Revision: https://phabricator.services.mozilla.com/D25667
03ef11b535d4c05d400a7b3d9965cbea6e2b6d2a: Bug 1528674 - WR improve picture texture cache allocaton r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 28 Mar 2019 03:02:45 +0000 - rev 466530
Push 81658 by dmalyshau@mozilla.com at Thu, 28 Mar 2019 05:31:44 +0000
Bug 1528674 - WR improve picture texture cache allocaton r=gw The change contains a number of incremental improvements with the main goal of: - allocating exactly as many tile as required by the app - respecting the picture caching option Differential Revision: https://phabricator.services.mozilla.com/D24740
bbb6a31ebf07466c79b44d31cb5d6ea26a73d544: Bug 1528674 - WR improve picture texture cache allocaton r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 26 Mar 2019 21:18:09 +0000 - rev 466249
Push 81496 by dmalyshau@mozilla.com at Tue, 26 Mar 2019 21:33:32 +0000
Bug 1528674 - WR improve picture texture cache allocaton r=gw The change contains a number of incremental improvements with the main goal of: - allocating exactly as many tile as required by the app - respecting the picture caching option Differential Revision: https://phabricator.services.mozilla.com/D24740
1d405e872db459002abc43d312ffe8c240e1f83f: Bug 1441308 - Map document layers to z ranges r=gw
Doug Thayer <dothayer@mozilla.com> - Fri, 22 Mar 2019 18:28:51 +0000 - rev 465775
Push 81233 by dothayer@mozilla.com at Fri, 22 Mar 2019 18:54:42 +0000
Bug 1441308 - Map document layers to z ranges r=gw As discussed in IRC. AFAICT the ORTHO_NEAR|FAR_PLANE should match up with the ranges of valid ZBufferIds, but please double-check me. Differential Revision: https://phabricator.services.mozilla.com/D23599
31eb0acf3a1dd86cbbb21315d32826241e29e227: Bug 1441308 - Correct Renderer issues with multiple documents r=gw
Doug Thayer <dothayer@mozilla.com> - Fri, 22 Mar 2019 18:28:46 +0000 - rev 465774
Push 81233 by dothayer@mozilla.com at Fri, 22 Mar 2019 18:54:42 +0000
Bug 1441308 - Correct Renderer issues with multiple documents r=gw This corrects A) An issue encountered with our strategy for skipping the end_pass call for all but an offscreen render target. See the comment above the end_pass call for details, and B) An issue with depth clearing where we do not clear the whole rect if there are multiple non-intersecting documents. Differential Revision: https://phabricator.services.mozilla.com/D23056
d8b4d6ec9b4063e162d5c65db0ef124b4d036842: Bug 1441308 - Map document layers to z ranges r=gw
Doug Thayer <dothayer@mozilla.com> - Thu, 21 Mar 2019 23:15:23 +0000 - rev 465588
Push 81167 by dothayer@mozilla.com at Fri, 22 Mar 2019 06:31:43 +0000
Bug 1441308 - Map document layers to z ranges r=gw As discussed in IRC. AFAICT the ORTHO_NEAR|FAR_PLANE should match up with the ranges of valid ZBufferIds, but please double-check me. Differential Revision: https://phabricator.services.mozilla.com/D23599
e2f83e4816dd56d96c81017297e6f5002d4dc1b1: Bug 1441308 - Correct Renderer issues with multiple documents r=gw
Doug Thayer <dothayer@mozilla.com> - Fri, 22 Mar 2019 03:15:18 +0000 - rev 465587
Push 81167 by dothayer@mozilla.com at Fri, 22 Mar 2019 06:31:43 +0000
Bug 1441308 - Correct Renderer issues with multiple documents r=gw This corrects A) An issue encountered with our strategy for skipping the end_pass call for all but an offscreen render target. See the comment above the end_pass call for details, and B) An issue with depth clearing where we do not clear the whole rect if there are multiple non-intersecting documents. Differential Revision: https://phabricator.services.mozilla.com/D23056
93c9a0e2da6e07fc65917024e20ab82cd4dc9805: Bug 1527751 - properly apply transformed clips in brush shader. r=gw
Alexis Beingessner <a.beingessner@gmail.com> - Mon, 18 Mar 2019 21:05:56 +0000 - rev 464930
Push 80788 by ncsoregi@mozilla.com at Tue, 19 Mar 2019 04:11:30 +0000
Bug 1527751 - properly apply transformed clips in brush shader. r=gw Differential Revision: https://phabricator.services.mozilla.com/D23905
495ee696b1107c490ff7fa1d2dc618ddb9ae5cb2: Bug 1511433 - Ensure address variables in fragment shaders are highp precision. r=gw
Jamie Nicol <jnicol@mozilla.com> - Sun, 17 Mar 2019 20:54:29 +0000 - rev 464765
Push 80698 by jnicol@mozilla.com at Mon, 18 Mar 2019 10:50:25 +0000
Bug 1511433 - Ensure address variables in fragment shaders are highp precision. r=gw In GLES 3 GLSL, the default precision for ints is highp (32 bit) in vertex shaders, but only mediump (16 bit) in fragment shaders. To render linear and radial gradients the fragment shader must fetch the gradient stops from the gpu cache, using an address variable. This variable is a 16 bit int, so if the stops data is located at too high an address (row 32 or greater) then this value will have overflown and we fetch from the wrong location. This was resulting in garbage being drawn instead of the correct gradients. To fix this, any address used in a fragment shader must be marked as highp. This includes the varying input which supplies the address, and the arguments to any functions used for the fetch. Differential Revision: https://phabricator.services.mozilla.com/D23669
64f68305520218d7655672aceebbae9122d38729: Bug 1527325 - Don't re-export contents of WR API units r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Thu, 14 Mar 2019 01:44:05 +0000 - rev 463949
Push 80466 by dmalyshau@mozilla.com at Thu, 14 Mar 2019 03:19:05 +0000
Bug 1527325 - Don't re-export contents of WR API units r=gw The cleans up our WR use statements further, easying the merge conflicts. Note: this PR is subject to instant rot, it is preferred to land quickly. Differential Revision: https://phabricator.services.mozilla.com/D23373
950174a8c708a11f76452a83ed77b32e2213a8de: Bug 1527325 - Don't re-export contents of WR API units r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Wed, 13 Mar 2019 19:30:56 +0000 - rev 463891
Push 80431 by dmalyshau@mozilla.com at Wed, 13 Mar 2019 20:11:31 +0000
Bug 1527325 - Don't re-export contents of WR API units r=gw The cleans up our WR use statements further, easying the merge conflicts. Note: this PR is subject to instant rot, it is preferred to land quickly. Differential Revision: https://phabricator.services.mozilla.com/D23373
bb76bbd404c07c0e11d8ab5b6dafa9a798660735: Bug 1532245. Factor out component transfer code to a function in brush_blend shader for webreder. r=gw
Timothy Nikkel <tnikkel@gmail.com> - Mon, 11 Mar 2019 21:34:30 -0500 - rev 463632
Push 80257 by btara@mozilla.com at Tue, 12 Mar 2019 10:01:38 +0000
Bug 1532245. Factor out component transfer code to a function in brush_blend shader for webreder. r=gw Some phones can't compile the shader as is: "ERROR: 0:1448: '' : No default label can be nested inside other control flow nested within their corresponding switch" https://github.com/servo/webrender/wiki/Driver-issues#bug-1532245---switch-statement-inside-control-flow-inside-switch-statement-fails-to-compile-on-some-android-phones Differential Revision: https://phabricator.services.mozilla.com/D22853
c32dcf4e6f92de2e9523312a41fa71b77503f7e2: Bug 1532245. Factor out component transfer code to a function in brush_blend shader for webreder. r=gw
Timothy Nikkel <tnikkel@gmail.com> - Mon, 11 Mar 2019 17:01:40 -0500 - rev 463630
Push 80257 by btara@mozilla.com at Tue, 12 Mar 2019 10:01:38 +0000
Bug 1532245. Factor out component transfer code to a function in brush_blend shader for webreder. r=gw Some phones can't compile the shader as is: "ERROR: 0:1448: '' : No default label can be nested inside other control flow nested within their corresponding switch" https://github.com/servo/webrender/wiki/Driver-issues#bug-1532245---switch-statement-inside-control-flow-inside-switch-statement-fails-to-compile-on-some-android-phones Differential Revision: https://phabricator.services.mozilla.com/D22853
2c83d53042c614a6dcc19fa576401ea916e4c2d4: Bug 1532174 - Roll back env_logger to 0.5 r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 12 Mar 2019 02:54:05 +0000 - rev 463592
Push 80240 by dmalyshau@mozilla.com at Tue, 12 Mar 2019 02:54:54 +0000
Bug 1532174 - Roll back env_logger to 0.5 r=gw needed to avoid duplicate dependencies Differential Revision: https://phabricator.services.mozilla.com/D23072
c154ee9861abc7f3e3a29210785a3d2d8e854fd0: Bug 1532174 - Refactor get_relative_transform to not return an option r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 12 Mar 2019 02:27:29 +0000 - rev 463590
Push 80238 by dmalyshau@mozilla.com at Tue, 12 Mar 2019 02:31:50 +0000
Bug 1532174 - Refactor get_relative_transform to not return an option r=gw Just a refactor without any semantical changes. Makes it for cleaner client code. Also prepares for caching of the world transforms. Differential Revision: https://phabricator.services.mozilla.com/D23015
46ad1441e7f2eb2ee61dfaf9cd16cb04564b1d8b: Bug 1532174 - Strongly typed vertex data stores in WR r=gw
Dzmitry Malyshau <dmalyshau@mozilla.com> - Tue, 12 Mar 2019 02:26:51 +0000 - rev 463589
Push 80237 by dmalyshau@mozilla.com at Tue, 12 Mar 2019 02:30:41 +0000
Bug 1532174 - Strongly typed vertex data stores in WR r=gw Establishes a clear link of TransformData with the shader. Associates a vertex data type permanently, which makes the code cleaner and allow finding the relevant bits quickly with search. Differential Revision: https://phabricator.services.mozilla.com/D23006