searching for reviewer(glandium)
c0c12c3310fc5c6ce0bdb84539d42f8e5efadc7e: Bug 1686510 - Add a diff task for linux64 reproducible builds (except wasm sandboxing) r=glandium
David Major <dmajor@mozilla.com> - Fri, 15 Jan 2021 14:23:47 +0000 - rev 563287
Push 134271 by dmajor@mozilla.com at Fri, 15 Jan 2021 14:26:14 +0000
Bug 1686510 - Add a diff task for linux64 reproducible builds (except wasm sandboxing) r=glandium The previous blockers for having this task are no longer an issue, as far as I can tell. The only perma-failure is bug 1612035. Until that's addressed we can remove those files with `pre-diff-commands` and have something rather than nothing. Differential Revision: https://phabricator.services.mozilla.com/D101630
0bcc7f83fbab751e6b929f908ac5f7c01dde86bc: Bug 1686321 - Pass patches as arguments to build-compiler-rt.sh r=glandium
David Major <dmajor@mozilla.com> - Thu, 14 Jan 2021 03:41:08 +0000 - rev 563024
Push 134136 by dmajor@mozilla.com at Thu, 14 Jan 2021 09:24:37 +0000
Bug 1686321 - Pass patches as arguments to build-compiler-rt.sh r=glandium rename_gcov_flush_clang_11.patch doesn't apply cleanly to clang 12 and will need to be forked. Turning the filename into a parameter will let us have the tasks exist side by side. Differential Revision: https://phabricator.services.mozilla.com/D101495
c1607d3080b7540385083cb782ff56bf1449d4af: Bug 1686507 - Raise diff-reproducible-linux32-generated-files to tier 1 r=glandium
David Major <dmajor@mozilla.com> - Wed, 13 Jan 2021 23:05:42 +0000 - rev 562979
Push 134116 by dmajor@mozilla.com at Wed, 13 Jan 2021 23:55:24 +0000
Bug 1686507 - Raise diff-reproducible-linux32-generated-files to tier 1 r=glandium Unlike the binary diffs, the generated-files diffs have been stable for a long time. If these tasks ever start failing, it would be good to learn about that at tier-1 speed. Differential Revision: https://phabricator.services.mozilla.com/D101629
f8b6bf76608ad8a803e3c0507f67f40f36bf264f: Bug 1684110 - Stop defining aliases for 'A'-functions in windows.h wrapper. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Tue, 12 Jan 2021 04:44:03 +0000 - rev 562976
Push 134114 by VYV03354@nifty.ne.jp at Wed, 13 Jan 2021 22:53:41 +0000
Bug 1684110 - Stop defining aliases for 'A'-functions in windows.h wrapper. r=glandium so that people do not accidentally use 'A'-functions. Depends on D100420 Differential Revision: https://phabricator.services.mozilla.com/D101273
22427da59d4db5b83ea0bfab9ee9c2fe7c6f032a: Bug 1684110 - Define UNICODE on some directories. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 13 Jan 2021 22:49:59 +0000 - rev 562975
Push 134114 by VYV03354@nifty.ne.jp at Wed, 13 Jan 2021 22:53:41 +0000
Bug 1684110 - Define UNICODE on some directories. r=glandium so that people do not accidentally use 'A'-functions. Differential Revision: https://phabricator.services.mozilla.com/D100420
c03f86696776a2125f5c8e86db11bc0b85f11928: Bug 1677914 - enable chain of trust on mac builders. r=taskgraph-reviewers,jmaher,glandium
Aki Sasaki <asasaki@mozilla.com> - Wed, 13 Jan 2021 01:01:11 +0000 - rev 562867
Push 134050 by asasaki@mozilla.com at Wed, 13 Jan 2021 01:21:08 +0000
Bug 1677914 - enable chain of trust on mac builders. r=taskgraph-reviewers,jmaher,glandium Differential Revision: https://phabricator.services.mozilla.com/D97470
51c7245d0f28f0b490cf32a4d0e11c16d77d0b2d: Bug 1684936 - update NodeJS to 10.23.1 for latest sec fixes r=glandium
Dan Mosedale <dmose@mozilla.org> - Thu, 07 Jan 2021 17:06:42 +0000 - rev 562823
Push 134015 by dmosedale@mozilla.com at Tue, 12 Jan 2021 19:38:42 +0000
Bug 1684936 - update NodeJS to 10.23.1 for latest sec fixes r=glandium Differential Revision: https://phabricator.services.mozilla.com/D100810
7e1ed116d07fee5bf19a7dc7ffa0d02df5accdf7: Bug 1682219 - [geckodriver] Build with Rust 1.49 for Linux. r=glandium
Henrik Skupin <mail@hskupin.info> - Tue, 12 Jan 2021 15:52:39 +0000 - rev 562814
Push 134007 by hskupin@mozilla.com at Tue, 12 Jan 2021 18:23:41 +0000
Bug 1682219 - [geckodriver] Build with Rust 1.49 for Linux. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D100877
a4bf5887fc2a534109f2ce0c58bddc8336689203: Bug 1680402. Use stderr in printf_stderr instead of reopening fd 2. r=glandium
Jeff Muizelaar <jmuizelaar@mozilla.com> - Tue, 12 Jan 2021 14:54:48 +0000 - rev 562805
Push 134002 by jmuizelaar@mozilla.com at Tue, 12 Jan 2021 15:37:13 +0000
Bug 1680402. Use stderr in printf_stderr instead of reopening fd 2. r=glandium Currently, printf_stderr doesn't show up when running with ./mach run. This is because we run with -attach-console and that redirects stderr to a different file descriptor using freopen in UseParentConsole. The change from just using stderr directly happened in bug 340443 and was done to avoid some linking issues. That problem doesn't seem to apply anymore so you'd expect we'd be able to go back to the straightforward implemention that works even if stderr has been redirected. Unforunately, Windows takes not buffering stderr very seriously and fprintf will write out the results character by character. This can cause log output lines to be intermixed which breaks log parsing in CI. We keep using fdopen to create a new FILE* that's buffered but instead of hard coding fd 2, we get the actual fd that corresponds to stderr using fileno. The mozglue implementation was cargo culted from xpcom, so we update it as well. Differential Revision: https://phabricator.services.mozilla.com/D98550
ec3d60a618670ef6bbd233c0ef27865cc968709e: Bug 1685353: Disable -Woverloaded-virtual for GCC r=firefox-build-system-reviewers,sheehan,andi,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 12 Jan 2021 14:18:22 +0000 - rev 562797
Push 133994 by mhentges@mozilla.com at Tue, 12 Jan 2021 14:21:06 +0000
Bug 1685353: Disable -Woverloaded-virtual for GCC r=firefox-build-system-reviewers,sheehan,andi,glandium In addition to warning on regular methods overloading virtual functions, GCC also watches for static functions doing such overloads. :andi confirmed that this is not valuable, so the warning is being disabled for GCC. Differential Revision: https://phabricator.services.mozilla.com/D101367
eb5d5af5144fd15ab0d3ad912be6b0ba1d5ed41c: Bug 1683213: Don't warn on range-loop-analysis r=sheehan,sg,firefox-build-system-reviewers,andi,glandium
Mitchell Hentges <mhentges@mozilla.com> - Mon, 11 Jan 2021 15:30:45 +0000 - rev 562676
Push 133910 by mhentges@mozilla.com at Mon, 11 Jan 2021 16:48:48 +0000
Bug 1683213: Don't warn on range-loop-analysis r=sheehan,sg,firefox-build-system-reviewers,andi,glandium As described in https://quuxplusone.github.io/blog/2020/08/26/wrange-loop-analysis/ range-loop-analysis warnings sometimes recommend inferior code. Also removes pragmas that manually disable this warning. Differential Revision: https://phabricator.services.mozilla.com/D100155
211eda8dbd44a2f1806f0b4a3845eec0791127e2: Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 05 Jan 2021 20:14:25 +0000 - rev 562487
Push 133802 by mhentges@mozilla.com at Fri, 08 Jan 2021 18:55:37 +0000
Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium pylint_requirements.txt fail to install with the new pip resolver due to a conflict between astroid and lazy-object-proxy. Rather than bumping those packages and handling the potential fallout, the package-upgrade has been deferred and we will use the legacy resolver in the interrim. Differential Revision: https://phabricator.services.mozilla.com/D99940
f5b1f05af451b77cffa667770ba80ebea1a63ceb: Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 05 Jan 2021 20:09:38 +0000 - rev 562486
Push 133802 by mhentges@mozilla.com at Fri, 08 Jan 2021 18:55:37 +0000
Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium The `wheel` package was failing with Mac Big Sur. It's been updated, but our `virtualenv` package has its own vendored `wheel` package that is out-of-date. This should solve "assert len(base_version) == 2" and "would build wheel with unsupported tag" errors. Differential Revision: https://phabricator.services.mozilla.com/D99482
129bc6a92cbb5c78f57936035ff6fae91eae0226: Bug 1684914: stop passing `-flto=thin` to gcc since it doesn't actually work r=glandium,mhentges
Connor Sheehan <sheehan@mozilla.com> - Fri, 08 Jan 2021 15:54:54 +0000 - rev 562459
Push 133782 by cosheehan@mozilla.com at Fri, 08 Jan 2021 15:57:20 +0000
Bug 1684914: stop passing `-flto=thin` to gcc since it doesn't actually work r=glandium,mhentges Passing `-flto=thin` worked previously but the value passed was just ignored and full lto was performed. On newer versions of gcc passing an unknown value causes failure. So this commit checks if `-flto=thin` is passed and fails with an error message if so, else full lto is enabled if any other value is passed. Differential Revision: https://phabricator.services.mozilla.com/D100953
04b7cd1b0d65f7559ca32ca32ccb1bf0a872633c: Bug 1588710 - stack-clash-protection: enable when clang 11.0.1 is used r=firefox-build-system-reviewers,glandium
Sylvestre Ledru <sledru@mozilla.com> - Fri, 08 Jan 2021 02:39:50 +0000 - rev 562412
Push 133751 by mh@glandium.org at Fri, 08 Jan 2021 02:43:08 +0000
Bug 1588710 - stack-clash-protection: enable when clang 11.0.1 is used r=firefox-build-system-reviewers,glandium Differential Revision: https://phabricator.services.mozilla.com/D99759
cb69fe3e4c462012836d2d63309ff335adf4e0a3: Bug 1588710 - Linux/Android: enable -fstack-clash-protection r=tjr,firefox-build-system-reviewers,glandium
Sylvestre Ledru <sledru@mozilla.com> - Thu, 07 Jan 2021 16:40:09 +0000 - rev 562375
Push 133738 by sledru@mozilla.com at Thu, 07 Jan 2021 23:03:09 +0000
Bug 1588710 - Linux/Android: enable -fstack-clash-protection r=tjr,firefox-build-system-reviewers,glandium This is a new feature in clang (already existing in gcc) provided from version 11. Not usefull on Mac & Windows and is supported on intel cpu + ppc64 + s390x https://releases.llvm.org/11.0.0/tools/clang/docs/ReleaseNotes.html#new-compiler-flags Fedora/Redhat would like to have this option to move from gcc to clang in these distros. More on this: https://blog.qualys.com/vulnerabilities-research/2017/06/19/the-stack-clash https://pagure.io/fesco/issue/2020 https://reviews.llvm.org/D68720 https://www.phoronix.com/scan.php?page=news_item&px=LLVM-Stack-Clash-Protection-20 It seems that the performance impact is neglible: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=a47c98b909b61035dae2e1e00883f2ade0fef129&newProject=try&newRevision=62108fa48bd15fe01f1a0f1ffab133af9b4207cc&framework=13 Differential Revision: https://phabricator.services.mozilla.com/D95999
7a7372cdf019983c034cef3b411626fea878ef4b: Bug 1684231 - Fix build warnings about importing local symbols. r=glandium
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Thu, 07 Jan 2021 07:40:48 +0000 - rev 562248
Push 133691 by VYV03354@nifty.ne.jp at Thu, 07 Jan 2021 12:06:32 +0000
Bug 1684231 - Fix build warnings about importing local symbols. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D100476
931f753c12c019a760ded711608d78388c20f304: Bug 1682219 - [geckodriver] Build with Rust 1.49 for Linux. r=glandium
Henrik Skupin <mail@hskupin.info> - Thu, 07 Jan 2021 08:09:19 +0000 - rev 562226
Push 133673 by hskupin@mozilla.com at Thu, 07 Jan 2021 08:11:45 +0000
Bug 1682219 - [geckodriver] Build with Rust 1.49 for Linux. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D100877
a428dc6c16ddde993452912253c9e3cc62176949: Bug 1682806 - Improve the AArch64 stack walker heuristics to work around broken unwinding information r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Wed, 23 Dec 2020 08:53:35 +0000 - rev 562193
Push 133651 by gsvelto@mozilla.com at Wed, 06 Jan 2021 19:21:53 +0000
Bug 1682806 - Improve the AArch64 stack walker heuristics to work around broken unwinding information r=glandium Differential Revision: https://phabricator.services.mozilla.com/D99882
ed96e8c21b5a64eea14f8efe7b595fd76117fb80: Bug 1682947 - Use MADV_FREE_REUSE before using decommitted memory again on OSX, as per https://bugs.chromium.org/p/chromium/issues/detail?id=823915 r=glandium
Steve Fink <sfink@mozilla.com> - Wed, 23 Dec 2020 21:00:44 +0000 - rev 562056
Push 133552 by sfink@mozilla.com at Tue, 05 Jan 2021 16:13:05 +0000
Bug 1682947 - Use MADV_FREE_REUSE before using decommitted memory again on OSX, as per https://bugs.chromium.org/p/chromium/issues/detail?id=823915 r=glandium Differential Revision: https://phabricator.services.mozilla.com/D99932
fe8bfd66cd8101391b723359f93ee1d79cf1c382: Bug 1682947 - Handle madvise returning EAGAIN. r=glandium
Steve Fink <sfink@mozilla.com> - Thu, 24 Dec 2020 22:00:12 +0000 - rev 561961
Push 133502 by sfink@mozilla.com at Mon, 04 Jan 2021 23:41:46 +0000
Bug 1682947 - Handle madvise returning EAGAIN. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D100404
591d32364c0f6ae20e26701299bfd572380223e1: Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Mon, 04 Jan 2021 15:20:21 +0000 - rev 561899
Push 133461 by mhentges@mozilla.com at Mon, 04 Jan 2021 15:23:08 +0000
Bug 1680802: Install pylint requirements with legacy resolver r=firefox-build-system-reviewers,sheehan,glandium pylint_requirements.txt fail to install with the new pip resolver due to a conflict between astroid and lazy-object-proxy. Rather than bumping those packages and handling the potential fallout, the package-upgrade has been deferred and we will use the legacy resolver in the interrim. Differential Revision: https://phabricator.services.mozilla.com/D99940
3e9350fd509db93186b4a72ab6cd1291ab00691f: Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 17 Dec 2020 17:41:39 +0000 - rev 561898
Push 133461 by mhentges@mozilla.com at Mon, 04 Jan 2021 15:23:08 +0000
Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium The `wheel` package was failing with Mac Big Sur. It's been updated, but our `virtualenv` package has its own vendored `wheel` package that is out-of-date. This should solve "assert len(base_version) == 2" and "would build wheel with unsupported tag" errors. Differential Revision: https://phabricator.services.mozilla.com/D99482
a0e3802dd1e12fc1f29e753e30970b2234a33a09: Bug 1677994: Clarify that configure executes progs without using shell r=firefox-build-system-reviewers,dmajor,glandium
Mitchell Hentges <mhentges@mozilla.com> - Mon, 04 Jan 2021 15:18:33 +0000 - rev 561897
Push 133460 by mhentges@mozilla.com at Mon, 04 Jan 2021 15:20:55 +0000
Bug 1677994: Clarify that configure executes progs without using shell r=firefox-build-system-reviewers,dmajor,glandium Some distros include flags when they specify the location of a binary, such as: `XARGS=xargs -r`. This was confusing in `configure`, since: * We require that environment variables contain only path overrides (without flags). * The error message thrown when configure chokes was unclear: "why would `$ xargs -r` fail?" This patch should make our "path-only" requirement more clear. Differential Revision: https://phabricator.services.mozilla.com/D100044
9d5f4c9e6fdf71853bf496c79a4101018b26e2e1: Bug 1683213: Don't warn on range-loop-analysis for clang < 10 r=sheehan,sg,firefox-build-system-reviewers,andi,glandium
Mitchell Hentges <mhentges@mozilla.com> - Mon, 04 Jan 2021 15:15:46 +0000 - rev 561896
Push 133459 by mhentges@mozilla.com at Mon, 04 Jan 2021 15:18:57 +0000
Bug 1683213: Don't warn on range-loop-analysis for clang < 10 r=sheehan,sg,firefox-build-system-reviewers,andi,glandium Old clang shakes its fist when `auto&& item : range` is used with a range that returns values instead of references. Modern `clang` doesn't warn for this scenario, so we disable the warning. Also removes pragmas that manually disable this warning. Differential Revision: https://phabricator.services.mozilla.com/D100155
b4a2022ff76d1a6dc286da9e5e0d6b428216fb7d: Bug 1682556 - Increase vm_copy() threshold. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 Dec 2020 01:35:22 +0000 - rev 561683
Push 133311 by ealvarez@mozilla.com at Wed, 23 Dec 2020 01:37:47 +0000
Bug 1682556 - Increase vm_copy() threshold. r=glandium The current implementation is a regression on microbenchmarks that reallocate allocations that go over gPageSize * 32 compared to memcpy(). Differential Revision: https://phabricator.services.mozilla.com/D100217
c0446a031b8e576f6c121bb7fd3c3e9e88dd117b: Bug 1682204 - Clear arena_t::mId in the constructor r=glandium
Paul Bone <pbone@mozilla.com> - Thu, 17 Dec 2020 23:24:53 +0000 - rev 561206
Push 133082 by pbone@mozilla.com at Thu, 17 Dec 2020 23:27:39 +0000
Bug 1682204 - Clear arena_t::mId in the constructor r=glandium Differential Revision: https://phabricator.services.mozilla.com/D99638
19db3f7eb20494347c52b4cf212ef3e6bf256074: Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 15 Dec 2020 20:52:15 +0000 - rev 560861
Push 132893 by mhentges@mozilla.com at Tue, 15 Dec 2020 22:20:53 +0000
Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium The `wheel` package was failing with Mac Big Sur. It's been updated, but our `virtualenv` package has its own vendored `wheel` package that is out-of-date. This should solve "assert len(base_version) == 2" and "would build wheel with unsupported tag" errors. Differential Revision: https://phabricator.services.mozilla.com/D99482
3fbd3ae18e3fb25f11f0add79947ba3417dcdc3a: Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 15 Dec 2020 18:17:53 +0000 - rev 560835
Push 132870 by mhentges@mozilla.com at Tue, 15 Dec 2020 20:14:45 +0000
Bug 1680802: Bump vendored virtualenv package r=firefox-build-system-reviewers,sheehan,glandium The `wheel` package was failing with Mac Big Sur. It's been updated, but our `virtualenv` package has its own vendored `wheel` package that is out-of-date. This updates `virtualenv` to "20.2.2". This should solve "assert len(base_version) == 2" and "would build wheel with unsupported tag" errors. Differential Revision: https://phabricator.services.mozilla.com/D99482
3b4e21adbc94196813c65b7f23eb08aed9755999: Bug 1681112 - python3 - python/mozbuild/mozbuild/configure/lint.py fix types.CodeType arguments. r=glandium
Bob Clary <bclary@bclary.com> - Wed, 09 Dec 2020 00:52:39 +0000 - rev 560690
Push 132762 by bclary@mozilla.com at Mon, 14 Dec 2020 21:28:44 +0000
Bug 1681112 - python3 - python/mozbuild/mozbuild/configure/lint.py fix types.CodeType arguments. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D98983
f0b02db0189473f12beb4b483dab17708ffde615: Bug 1588710 - Linux/Android: enable -fstack-clash-protection r=tjr,firefox-build-system-reviewers,glandium
Sylvestre Ledru <sledru@mozilla.com> - Mon, 14 Dec 2020 16:02:52 +0000 - rev 560635
Push 132727 by sledru@mozilla.com at Mon, 14 Dec 2020 17:22:07 +0000
Bug 1588710 - Linux/Android: enable -fstack-clash-protection r=tjr,firefox-build-system-reviewers,glandium This is a new feature in clang (already existing in gcc) provided from version 11. Not usefull on Mac & Windows and is supported on intel cpu + ppc64 + s390x https://releases.llvm.org/11.0.0/tools/clang/docs/ReleaseNotes.html#new-compiler-flags Fedora/Redhat would like to have this option to move from gcc to clang in these distros. More on this: https://blog.qualys.com/vulnerabilities-research/2017/06/19/the-stack-clash https://pagure.io/fesco/issue/2020 https://reviews.llvm.org/D68720 https://www.phoronix.com/scan.php?page=news_item&px=LLVM-Stack-Clash-Protection-20 It seems that the performance impact is neglible: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=a47c98b909b61035dae2e1e00883f2ade0fef129&newProject=try&newRevision=62108fa48bd15fe01f1a0f1ffab133af9b4207cc&framework=13 Differential Revision: https://phabricator.services.mozilla.com/D95999
f12f5989419ac645e641036d9c3851170362fdef: Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium
Gabriele Svelto <gsvelto@mozilla.com> - Mon, 14 Dec 2020 15:53:41 +0000 - rev 560627
Push 132722 by gsvelto@mozilla.com at Mon, 14 Dec 2020 15:56:04 +0000
Bug 1670885 - Replace deprecated NSSpinLocks with os_unfair_locks in the memory allocator r=glandium Differential Revision: https://phabricator.services.mozilla.com/D99280
80b917c0690a2bca3806a740bb542c5ec5f75274: Bug 1623520 - Add the asan unpoison patch to clang-cl-2stage r=firefox-build-system-reviewers,glandium
David Major <dmajor@mozilla.com> - Fri, 11 Dec 2020 05:06:12 +0000 - rev 560300
Push 132568 by mh@glandium.org at Fri, 11 Dec 2020 05:08:58 +0000
Bug 1623520 - Add the asan unpoison patch to clang-cl-2stage r=firefox-build-system-reviewers,glandium This is needed for cross-compiled win64-asan builds. Differential Revision: https://phabricator.services.mozilla.com/D99411
ac54ee8d90e5ce166dd231574d98382fba7316b4: Bug 1681003 - When realloc() grows an allocation, allow switching out of public arenas if plain malloc() would've done that. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 10 Dec 2020 10:59:09 +0000 - rev 560176
Push 132486 by ealvarez@mozilla.com at Thu, 10 Dec 2020 11:01:39 +0000
Bug 1681003 - When realloc() grows an allocation, allow switching out of public arenas if plain malloc() would've done that. r=glandium Otherwise we may grow thread-local arenas a lot. Differential Revision: https://phabricator.services.mozilla.com/D98924
6de0b9494ed9681b5d6c40c6ec670b408631e407: Bug 1533760 - Solaris should use linker symbols file too r=glandium
Petr Sumbera <petr.sumbera@oracle.com> - Thu, 10 Dec 2020 07:50:32 +0000 - rev 560145
Push 132475 by mh@glandium.org at Thu, 10 Dec 2020 08:08:40 +0000
Bug 1533760 - Solaris should use linker symbols file too r=glandium This was missed from fix for: Bug 1651082 - Add support for Solaris linker Differential Revision: https://phabricator.services.mozilla.com/D97876
bee2ef0fc0e783a1e6e0a9d850437280f6457dbf: Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r=glandium,gsvelto
Edmund Wong <Edmund Wong> - Tue, 08 Dec 2020 11:38:38 +0000 - rev 560142
Push 132472 by mh@glandium.org at Thu, 10 Dec 2020 07:03:18 +0000
Bug 1675676 - Add --with-crashreporter-url for ac_add_options to allow specifying alternative crash-stats server url. r=glandium,gsvelto Differential Revision: https://phabricator.services.mozilla.com/D96322
3239d2c504d35d138c3a36cbac1fccd429567440: Bug 1681243 - Use noexcept on arena_t's fallible allocator, even on Windows r=glandium
David Major <dmajor@mozilla.com> - Wed, 09 Dec 2020 14:10:26 +0000 - rev 560012
Push 132391 by dmajor@mozilla.com at Wed, 09 Dec 2020 14:43:07 +0000
Bug 1681243 - Use noexcept on arena_t's fallible allocator, even on Windows r=glandium In clang-cl builds, thanks to clang-cl's defining of `_MSC_VER`, this function was not marked `noexcept`. This led clang to believe that it could call `arena_t`'s constructor without checking for null. I suppose we could scope the condition down to real MSVC, but since we don't support that anymore, we can just stop checking. Differential Revision: https://phabricator.services.mozilla.com/D99137
aeaa3b2c2670669bb0529443c8e36d37cc8e7f3a: Bug 1681075 - Manually inline arena_salloc. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 09 Dec 2020 08:19:49 +0000 - rev 559968
Push 132364 by ealvarez@mozilla.com at Wed, 09 Dec 2020 08:22:40 +0000
Bug 1681075 - Manually inline arena_salloc. r=glandium It's small and only has one caller. Differential Revision: https://phabricator.services.mozilla.com/D98923
7c8dd800fa54d6ee46a2f67983709f5ca61df820: Bug 1677797 - Change autoconf to avoid using a hard-coded file descriptor r=glandium
Tom Ritter <tom@mozilla.com> - Tue, 08 Dec 2020 22:04:09 +0000 - rev 559901
Push 132336 by tritter@mozilla.com at Tue, 08 Dec 2020 22:06:40 +0000
Bug 1677797 - Change autoconf to avoid using a hard-coded file descriptor r=glandium In Bug 1671424 we changed the way we configure firefox and it broke the codeql database generation job. This job wraps the entire build process in a way similar to codeql --command="./mach build" Specifically, the previous way we executed the configure shell script made codeql disable itself because it was named configure (codeql disables itself during configuration.) codeql injects via LD_PRELOAD, and it opens a configuration file and a logging file (getting fd 3 and 4 respectively.) autoconf grabs file descriptor 4 and uses it a temporary redirection point either to a file or stdout. When it does so, it closes the original file descriptor 4 and points it at the new location, which also affects the codeql code, resulting in undesired logging output going into the configure script. Because this file descriptor trick is only used to avoid duplicating a few lines of code, I removed the trick and duplicated the code. Differential Revision: https://phabricator.services.mozilla.com/D98642
9b2463939876c47408504fca3790f6dd34f2e1e6: Bug 1680547: Bump glean_sdk to a version with a source package r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 08 Dec 2020 15:50:08 +0000 - rev 559855
Push 132298 by mhentges@mozilla.com at Tue, 08 Dec 2020 16:14:18 +0000
Bug 1680547: Bump glean_sdk to a version with a source package r=firefox-build-system-reviewers,glandium Our old version of `glean_sdk` only had pip wheels, which meant that un-wheeled machines had no option for building the package. Differential Revision: https://phabricator.services.mozilla.com/D98795
1a5dcdffe6c181fd18e38bdf9de96f77a99ca400: Bug 1680162: Install python packages after system packages r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Tue, 08 Dec 2020 15:35:05 +0000 - rev 559854
Push 132297 by mhentges@mozilla.com at Tue, 08 Dec 2020 16:13:21 +0000
Bug 1680162: Install python packages after system packages r=firefox-build-system-reviewers,glandium Native python packages will probably require python headers. For some systems, these are available in a separate system package (such as python[3]-dev). If the user is bootstrapping with "--no-system-changes", we just try to install these native packages and fail gracefully if required headers aren't installed. Differential Revision: https://phabricator.services.mozilla.com/D98530
adbd3858fa50f54a36461ce96688feff9d7f09b6: Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert
Martin Stransky <stransky@redhat.com> - Tue, 08 Dec 2020 15:26:09 +0000 - rev 559852
Push 132295 by stransky@redhat.com at Tue, 08 Dec 2020 16:11:57 +0000
Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert - Remove MOZ_WAYLAND_CFLAGS and /ipc/chromium/chromium-config.mozbuild from ffmpeg58/moz.build - Build ffvpx with vaapi support at ffvpx/moz.build - Move gfx related headers from DMABUFSurfaceImage.h to DMABUFSurfaceImage.cpp and implement the gfx methods there. - Remove GL headers from DMABufSurface.h and forward declare GLuint/GLContext there. - Move mutex/MessageLoop/task related headers from nsWaylandDisplay.h to nsWaylandDisplay.cpp. - Move mozva.cpp to mozva.c due to linking issues Depends on D90556 Differential Revision: https://phabricator.services.mozilla.com/D90557
d741ce965068526ccc2099a6b8106f788e88a8b5: Bug 1681075 - Deduplicate some common code in Ralloc. r=glandium
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 08 Dec 2020 11:24:10 +0000 - rev 559816
Push 132278 by ealvarez@mozilla.com at Tue, 08 Dec 2020 11:26:34 +0000
Bug 1681075 - Deduplicate some common code in Ralloc. r=glandium Differential Revision: https://phabricator.services.mozilla.com/D98922
7a0074e53c54f606e52cdd8c931b5fcfcb83130f: Bug 1674770 - update parking_lot to get tsan fixes. r=glandium
Alexis Beingessner <a.beingessner@gmail.com> - Fri, 04 Dec 2020 17:02:33 +0000 - rev 559543
Push 132125 by abeingessner@mozilla.com at Fri, 04 Dec 2020 17:05:58 +0000
Bug 1674770 - update parking_lot to get tsan fixes. r=glandium Although this doesn't fix the particular false positive we hit, more fixes is good to get Differential Revision: https://phabricator.services.mozilla.com/D98649
13936ff79b4ca5d7b6cdb6dfa32e406952022c14: Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert
Martin Stransky <stransky@redhat.com> - Fri, 04 Dec 2020 09:41:46 +0000 - rev 559421
Push 132090 by stransky@redhat.com at Fri, 04 Dec 2020 09:49:44 +0000
Bug 1660336 Build ffvpx FFmpegVideoDecoder module with VAAPI support, r=jya,glandium,jgilbert - Remove MOZ_WAYLAND_CFLAGS and /ipc/chromium/chromium-config.mozbuild from ffmpeg58/moz.build - Build ffvpx with vaapi support at ffvpx/moz.build - Move gfx related headers from DMABUFSurfaceImage.h to DMABUFSurfaceImage.cpp and implement the gfx methods there. - Remove GL headers from DMABufSurface.h and forward declare GLuint/GLContext there. - Move mutex/MessageLoop/task related headers from nsWaylandDisplay.h to nsWaylandDisplay.cpp. Depends on D90556 Differential Revision: https://phabricator.services.mozilla.com/D90557
f43e981bbc3f8615d630f9169e407fa271fe9aaf: Bug 1680654 - Update rustc version used in test_toolchain_configure. r=glandium,firefox-build-system-reviewers DONTBUILD
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 04 Dec 2020 05:12:08 +0000 - rev 559395
Push 132083 by mh@glandium.org at Fri, 04 Dec 2020 05:16:07 +0000
Bug 1680654 - Update rustc version used in test_toolchain_configure. r=glandium,firefox-build-system-reviewers DONTBUILD The min version was updated to 1.47.0 in bug 1680080. Differential Revision: https://phabricator.services.mozilla.com/D98707
975163dad54fe43a4b049cd91d34872a0763b1c1: Bug 1680402. Use stderr in printf_stderr instead of reopening fd 2. r=glandium
Jeff Muizelaar <jmuizelaar@mozilla.com> - Fri, 04 Dec 2020 02:46:57 +0000 - rev 559382
Push 132075 by jmuizelaar@mozilla.com at Fri, 04 Dec 2020 02:49:31 +0000
Bug 1680402. Use stderr in printf_stderr instead of reopening fd 2. r=glandium Currently, printf_stderr doesn't show up when running with ./mach run. This is because we run with -attach-console and that redirects stderr to a different file descriptor using freopen in UseParentConsole. The change from just using stderr directly happened in bug 340443 and was done to avoid some linking issues. That problem doesn't seem to apply anymore so we should be able to go back to the straightforward implemention that works even if stderr has been redirected. The mozglue implementation was cargo culted from xpcom, and there wasn't a reason other than that for the fdopen(dup()) there. Differential Revision: https://phabricator.services.mozilla.com/D98550
0c24a54b815ada0fa904461f93496f7207f1662e: Bug 1680080 - Optimize proc macros / build dependencies. r=glandium,firefox-build-system-reviewers,mhentges
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 04 Dec 2020 01:35:51 +0000 - rev 559374
Push 132071 by ealvarez@mozilla.com at Fri, 04 Dec 2020 01:38:18 +0000
Bug 1680080 - Optimize proc macros / build dependencies. r=glandium,firefox-build-system-reviewers,mhentges On a very parallel debug build, I see a long time just waiting for bindgen / style compilation / geckoservo. Turns out that a bunch of this is just proc macros / build scripts. Optimizing it saves between 10 and 17 seconds of my debug build. We might want to consider running bindgen much like cbindgen rather than rebuilding it all the time, which should help a lot more, but my guess is that this should still help with the pretty hot custom derives that the style crate runs. This needs rust 1.41, so the requirement for tools/crashreporter needs to be bumped as a consequence. To make things simpler, it was bumped to 1.47 while we're at it. Differential Revision: https://phabricator.services.mozilla.com/D98366
2da7a091b64bb2f1b204fc9667e842c9961bd96b: Bug 1661153: Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium
Mitchell Hentges <mhentges@mozilla.com> - Thu, 03 Dec 2020 22:58:52 +0000 - rev 559353
Push 132058 by mhentges@mozilla.com at Thu, 03 Dec 2020 23:01:24 +0000
Bug 1661153: Removes _ensure_zstd() and usages r=firefox-build-system-reviewers,glandium Removes a bunch of zstandard installations that were ran from within the mach virtualenv, which should already have zstandard installed. Differential Revision: https://phabricator.services.mozilla.com/D98387
1d14ed65ed8d60f5ea38577eecbac49a7d783ea6: Bug 1680461 - Fixup for bug 1680172: Keep building geckodriver for linux with rustc 1.47. r=glandium CLOSED TREE
Mike Hommey <mh+mozilla@glandium.org> - Thu, 03 Dec 2020 11:30:38 +0000 - rev 559240
Push 132008 by smolnar@mozilla.com at Thu, 03 Dec 2020 11:56:21 +0000
Bug 1680461 - Fixup for bug 1680172: Keep building geckodriver for linux with rustc 1.47. r=glandium CLOSED TREE rather than the Android builds, which we restore to 1.48, effectively backing out changeset 6c5df06cb71b. Differential Revision: https://phabricator.services.mozilla.com/D98578