searching for reviewer(gl)
17cec9244fa904f4f5033ab272eeba8fdd2ff429: Bug 1559589 - Ensure Font Editor supports "normal" as computed style value for line-height; r=gl
Razvan Caliman <rcaliman@mozilla.com> - Fri, 21 Jun 2019 17:28:21 +0000 - rev 479862
Push 88327 by rcaliman@mozilla.com at Fri, 21 Jun 2019 23:24:37 +0000
Bug 1559589 - Ensure Font Editor supports "normal" as computed style value for line-height; r=gl Remove conversion for computed `line-height` value to unitless value to prevent Font Editor from crashing when the patch from [Bug 1536871](https://bugzilla.mozilla.org/show_bug.cgi?id=1536871) is applied (the default computed value for `line-height` is no longer numeric). Add support for `normal` keyword value for `line-height` as the default returned by `getComputedStyle()`, similar to existing behavior for `letter-spacing`. Fix misnomer of the class in `LetterSpacing.js` component. Differential Revision: https://phabricator.services.mozilla.com/D35394
752a2894ca73fa5c4f307bd360f1fec0f9599dbf: Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl
Micah Tigley <mtigley@mozilla.com> - Sat, 08 Jun 2019 21:35:42 +0000 - rev 478000
Push 87464 by mtigley@mozilla.com at Sat, 08 Jun 2019 21:47:55 +0000
Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl Differential Revision: https://phabricator.services.mozilla.com/D33734
f4ea30c29aa78e70ee1596638d08e8e3146700c9: Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 07 Jun 2019 00:00:55 +0000 - rev 477731
Push 87320 by mtigley@mozilla.com at Fri, 07 Jun 2019 00:27:56 +0000
Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl Differential Revision: https://phabricator.services.mozilla.com/D33734
91643c6f9a42b80a9e63db58931f8b4be8c6e69b: Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl
Micah Tigley <mtigley@mozilla.com> - Thu, 06 Jun 2019 19:18:16 +0000 - rev 477680
Push 87299 by mtigley@mozilla.com at Thu, 06 Jun 2019 20:56:59 +0000
Bug 1556533 - Fix RDM simulating orientationchange event when the page is refreshed. r=gl Differential Revision: https://phabricator.services.mozilla.com/D33734
7ba95be07ebfa5e197cf12c8aafd249550d03730: Bug 1555064 - (Part 2) Centralize the list of supported pseudo-classes. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Thu, 30 May 2019 16:14:53 +0000 - rev 476748
Push 87016 by rcaliman@mozilla.com at Tue, 04 Jun 2019 08:29:39 +0000
Bug 1555064 - (Part 2) Centralize the list of supported pseudo-classes. r=gl Depends on D32867 Reference the shared list of pseudo-elements throughout the codebase: - markup view context menu + test - Rule editor - box model highlighter - node actor - new Rules view Differential Revision: https://phabricator.services.mozilla.com/D32868
6c342fe3a57b217f4c48c2e59848936797518846: Bug 1555064 - (Part 1) Generalize creation and handling of pseudo-class toggles in the Rules view. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 03 Jun 2019 15:22:18 +0000 - rev 476747
Push 87016 by rcaliman@mozilla.com at Tue, 04 Jun 2019 08:29:39 +0000
Bug 1555064 - (Part 1) Generalize creation and handling of pseudo-class toggles in the Rules view. r=gl - Removes the hardcoded references from `index.xhtml` and `rules.js` and uses a centralized list of pseudo-classes to generate the checkboxes for the supported pseudo-class locks at runtime. - Streamlines the handling for pseudo-class locks state. Fixes Bug 1536676 as a side-effect. - Updates tests. Differential Revision: https://phabricator.services.mozilla.com/D32867
8a78a9ae379fbc974e114294b3abdbb732be82ed: Bug 1554695 - RDM reports incorrect angle when rotated. r=gl
Micah Tigley <mtigley@mozilla.com> - Mon, 03 Jun 2019 20:24:02 +0000 - rev 476693
Push 86989 by mtigley@mozilla.com at Mon, 03 Jun 2019 21:21:56 +0000
Bug 1554695 - RDM reports incorrect angle when rotated. r=gl Differential Revision: https://phabricator.services.mozilla.com/D33546
096dd8162ff915f4e34df0f914aef9e51ecd1f96: Bug 1556135 - only check if the current node is null in getClosestBackgroundImage. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Sat, 01 Jun 2019 23:16:01 +0000 - rev 476532
Push 86908 by yura.zenevich@gmail.com at Sun, 02 Jun 2019 00:10:09 +0000
Bug 1556135 - only check if the current node is null in getClosestBackgroundImage. r=gl Differential Revision: https://phabricator.services.mozilla.com/D33396
28b379c201867f1c0f0dc7d05346a25a1012d63d: Bug 1555304 - Fix size of print simulation icon; r=gl
Florens Verschelde <florens@fvsch.com> - Wed, 29 May 2019 17:50:01 +0000 - rev 476113
Push 86667 by florens@fvsch.com at Wed, 29 May 2019 18:15:50 +0000
Bug 1555304 - Fix size of print simulation icon; r=gl Differential Revision: https://phabricator.services.mozilla.com/D33002
b638269d62f17d7a33f6d5194fcfe3a2d6fb13d9: Bug 1357774 - Part 2: Add the ability to update orientation state of a simulated device in RDM r=gl
Micah Tigley <mtigley@mozilla.com> - Wed, 22 May 2019 20:07:13 +0000 - rev 475026
Push 86123 by mtigley@mozilla.com at Wed, 22 May 2019 21:50:42 +0000
Bug 1357774 - Part 2: Add the ability to update orientation state of a simulated device in RDM r=gl This patch gives the RDM UI the ability to update the screen orientation based on the orientation of the simulated device screen. It fixes the following issues: - Initializing the orientation state of the selected device when RDM is opened. - Updating orientation state when the rotate button in the RDM toolbar is pressed. - Updating the orientation state when a new device is selected. There are three actions creators that are responsible for notifying the ResponsiveUI manager, `changeDevice`, `restoreDeviceState`, and `rotateViewport`. In particular: - `restoreDeviceState` is dispatched when the Responsive UI has finished initializing. If a previous RDM session had a device selected, then this action creator will also dispatch the `changeDevice` action to update the RDM UI to reflect the currently selected device. - `changeDevice` is dispatched when a device is selected. - `rotateViewport` is dispatched when the rotate button is clicked in the RDM toolbar. When either of these actions is dispatched, we post a "viewport-orientation-change" message to the window that notifies the manager to update the screen orientation accordingly. Finally, when RDM is closed, we need to ensure the original physical screen orientation is restored. We do this by calling the `setRDMPaneOrientation` on the docShell's document in the content frame script. Differential Revision: https://phabricator.services.mozilla.com/D30440
011f651a85180ba658c1bce7cae914d83d1c47df: Bug 1544223 - Don't advance to the next property or value when parsing ; or : inside a CSS block; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Wed, 22 May 2019 10:46:55 +0000 - rev 474922
Push 86077 by pbrosset@mozilla.com at Wed, 22 May 2019 12:10:33 +0000
Bug 1544223 - Don't advance to the next property or value when parsing ; or : inside a CSS block; r=gl Differential Revision: https://phabricator.services.mozilla.com/D31973
e61809618043028020fccde2731fb499fc2c4110: Bug 1526975: Filter out implicit grid line names in text-property-editor's autocomplete. r=gl,bradwerth
Micah Tigley <mtigley@mozilla.com> - Tue, 21 May 2019 21:29:02 +0000 - rev 474868
Push 86030 by mtigley@mozilla.com at Tue, 21 May 2019 21:41:10 +0000
Bug 1526975: Filter out implicit grid line names in text-property-editor's autocomplete. r=gl,bradwerth Differential Revision: https://phabricator.services.mozilla.com/D21308
1d79999a70f3ffd534c55fd4093d7c766a04f942: Bug 1521188 - Make findGridParentContainerForNode not depend on the walker; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Tue, 21 May 2019 14:30:33 +0000 - rev 474762
Push 85975 by pbrosset@mozilla.com at Tue, 21 May 2019 15:28:01 +0000
Bug 1521188 - Make findGridParentContainerForNode not depend on the walker; r=gl Differential Revision: https://phabricator.services.mozilla.com/D31633
d4c346b146a1b9f123fa3a704f23ff1196209fae: Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 20 May 2019 16:03:00 +0000 - rev 474709
Push 85949 by rcaliman@mozilla.com at Tue, 21 May 2019 09:40:16 +0000
Bug 1552275 - Fix Copy Link context menu in DevTools Inspector markup view. r=gl - Fixes the references to the correct event handler & InspectorFront after a previous mass refactoring in Bug 1529364. - Augments a test to ensure the clipboard content is correct executing the context menu action to copy a link. Differential Revision: https://phabricator.services.mozilla.com/D31765
7b90628fa1e7f153e574c07626b6af5378593a45: Bug 1550794 - Add telemetry probe to count number of node selections. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Fri, 17 May 2019 16:42:48 +0000 - rev 474513
Push 85840 by rcaliman@mozilla.com at Mon, 20 May 2019 10:19:44 +0000
Bug 1550794 - Add telemetry probe to count number of node selections. r=gl Adds a new permanent telemetry probe (scalar) to count the number of times a node selection is made in the Inspector. This count will be correlated with other existing probes (open count, duration open) to establish a more accurate baseline for Inspector usage and correct for accidental usage. When opening the Inspector via the context menu ("Inspect Element"), the selection is counted twice: once when automatically selecting the `<body>` to build the dom tree and once more for selecting the actual target node. This side-effect does not pollute our data. We assign a higher weight to the behavior of "Inspect Element" as being intentional usage of the Inspector so the higher node selection count works in our favor. Differential Revision: https://phabricator.services.mozilla.com/D31231
b38eabe183170953e88e5a91d367ca2eb044e62f: Bug 1322385 Part 2: Add a test that RDM content triggers typeahead find correctly. r=gl
Brad Werth <bwerth@mozilla.com> - Thu, 16 May 2019 18:12:37 +0000 - rev 474232
Push 85703 by bwerth@mozilla.com at Thu, 16 May 2019 22:09:40 +0000
Bug 1322385 Part 2: Add a test that RDM content triggers typeahead find correctly. r=gl Differential Revision: https://phabricator.services.mozilla.com/D29085
72820b3eb2f053dde3339ec9679139b9dd78df4a: Bug 1551816 - Bail out rendering urls in rule-view if they're not valid; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Thu, 16 May 2019 14:54:07 +0000 - rev 474121
Push 85665 by pbrosset@mozilla.com at Thu, 16 May 2019 15:45:10 +0000
Bug 1551816 - Bail out rendering urls in rule-view if they're not valid; r=gl Differential Revision: https://phabricator.services.mozilla.com/D31230
bfb8f26e725bd8b2abd17c4dbcc3d4ffe2cf280c: Bug 1405514 - Changes box model values' cursor and active/focus stylings. r=gl
Danielle Leblanc-Cyr <danielleleb12@gmail.com> - Mon, 13 May 2019 10:51:48 -0400 - rev 473683
Push 85390 by apavel@mozilla.com at Mon, 13 May 2019 21:59:12 +0000
Bug 1405514 - Changes box model values' cursor and active/focus stylings. r=gl
784c0c4b688bde6491539ad89a5f44b939c4fd7e: Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 11 May 2019 17:54:16 +0000 - rev 473538
Push 85284 by ntim.bugs@gmail.com at Sat, 11 May 2019 17:54:56 +0000
Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D28334
c8a2cbf18f3c8434aa69b21db050fe7af1f19251: Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe
Tim Nguyen <ntim.bugs@gmail.com> - Sat, 11 May 2019 16:08:13 +0000 - rev 473534
Push 85280 by ntim.bugs@gmail.com at Sat, 11 May 2019 16:11:46 +0000
Bug 1223368 - Refactor searchbox style to be consistent across tools. r=fvsch,gl,Honza,nchevobbe Differential Revision: https://phabricator.services.mozilla.com/D28334
40dad5764be780d7f1cae6e79075923386bd82f5: Bug 1540314: Devtools promise actor: Use ActorPool 'destroy' method. r=gl
Jim Blandy <jimb@mozilla.com> - Fri, 03 May 2019 01:19:20 +0000 - rev 472920
Push 84909 by jblandy@mozilla.com at Tue, 07 May 2019 16:12:00 +0000
Bug 1540314: Devtools promise actor: Use ActorPool 'destroy' method. r=gl The prior code calls '.cleanup()', but ActorPools have no 'cleanup' method. I think it means to call 'destroy'. Differential Revision: https://phabricator.services.mozilla.com/D29755
01e77d5c83c48d6a96b4a03e4deb7afc3e090f50: Bug 1509255 - Simulate 'orientationchange' event when RDM viewport is rotated. r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 03 May 2019 16:32:22 +0000 - rev 472535
Push 84711 by mtigley@mozilla.com at Fri, 03 May 2019 16:34:00 +0000
Bug 1509255 - Simulate 'orientationchange' event when RDM viewport is rotated. r=gl Differential Revision: https://phabricator.services.mozilla.com/D29308
20874bfade8ee324a3d4b1c54501a690e8d34a6b: Bug 1509255 - Simulate 'orientationchange' event when RDM viewport is rotated. r=gl
Micah Tigley <mtigley@mozilla.com> - Fri, 03 May 2019 14:00:37 +0000 - rev 472492
Push 84683 by mtigley@mozilla.com at Fri, 03 May 2019 14:01:40 +0000
Bug 1509255 - Simulate 'orientationchange' event when RDM viewport is rotated. r=gl Differential Revision: https://phabricator.services.mozilla.com/D29308
31a0bd977b2fc13c35cc4f54ab54a9887f8fdb50: Bug 1322385 Part 2: Add a test that RDM content triggers typeahead find correctly. r=gl
Brad Werth <bwerth@mozilla.com> - Mon, 29 Apr 2019 22:01:07 +0000 - rev 472018
Push 84407 by bwerth@mozilla.com at Tue, 30 Apr 2019 18:02:23 +0000
Bug 1322385 Part 2: Add a test that RDM content triggers typeahead find correctly. r=gl Differential Revision: https://phabricator.services.mozilla.com/D29085
143b77783b2e662853ea6dc151043ebb803bde6d: Bug 1544713 - make full page audit non-blocking. Fire 'audit-event' events when the full page audit completes or fails. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Mon, 29 Apr 2019 21:08:31 +0000 - rev 471854
Push 84322 by yura.zenevich@gmail.com at Mon, 29 Apr 2019 23:23:50 +0000
Bug 1544713 - make full page audit non-blocking. Fire 'audit-event' events when the full page audit completes or fails. r=gl Differential Revision: https://phabricator.services.mozilla.com/D28854
9b357ff266758e6826c3addf13916697b8f131be: Bug 1538681 Part 2: Add a perma-fail test that scrollbars appear in proper location after resizing viewport. r=botond,gl
Brad Werth <bwerth@mozilla.com> - Mon, 29 Apr 2019 17:54:52 +0000 - rev 471799
Push 84279 by bwerth@mozilla.com at Mon, 29 Apr 2019 17:56:02 +0000
Bug 1538681 Part 2: Add a perma-fail test that scrollbars appear in proper location after resizing viewport. r=botond,gl The test is marked as perma-fail because there are complications with getting RDM and WindowSnapshot.js to work together. 4 approaches are discussed in the test itself, and one is attempted, which perma-fails. The approach that is attempted is the most likely to be turned into an unexpected pass in the future, so the test is being added as perma-fail. Differential Revision: https://phabricator.services.mozilla.com/D28900
5c2540f3ed73ff48f6f523c7e67f9ce2da38dfa1: Bug 1541824 - Make Copy All Changes button sticky in Changes panel. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 24 Apr 2019 07:58:50 +0000 - rev 471314
Push 84030 by rcaliman@mozilla.com at Thu, 25 Apr 2019 15:38:14 +0000
Bug 1541824 - Make Copy All Changes button sticky in Changes panel. r=gl Ensure the button to copy all changes remains in view even when the Changes panel is overflowing vertically. Differential Revision: https://phabricator.services.mozilla.com/D28487
16017cdd86fdf73082e3bee6aafecedc5e542305: Bug 1546441 - Fix 3-pane mode icon for RTL mode. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Wed, 24 Apr 2019 15:29:46 +0000 - rev 470698
Push 83917 by rcaliman@mozilla.com at Wed, 24 Apr 2019 15:59:12 +0000
Bug 1546441 - Fix 3-pane mode icon for RTL mode. r=gl Differential Revision: https://phabricator.services.mozilla.com/D28619
1455fb3278d1320e43352ea847649a26b749e58e: Bug 1544684 - reset filters when a new accessible is selected. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 17 Apr 2019 15:23:44 +0000 - rev 469911
Push 83421 by yura.zenevich@gmail.com at Wed, 17 Apr 2019 18:12:50 +0000
Bug 1544684 - reset filters when a new accessible is selected. r=gl Differential Revision: https://phabricator.services.mozilla.com/D27915
433d9fd2908a8eee53c66985e4815e795275c596: Bug 1544678 - fixing a11y audit when checking an accessible object with no bounds. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 17 Apr 2019 12:28:04 +0000 - rev 469893
Push 83406 by yura.zenevich@gmail.com at Wed, 17 Apr 2019 16:28:55 +0000
Bug 1544678 - fixing a11y audit when checking an accessible object with no bounds. r=gl Differential Revision: https://phabricator.services.mozilla.com/D27884
4e987641febce56ca92c086093965f2192531387: Bug 1543045 - Break strings for long CSS property names and values. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Fri, 12 Apr 2019 08:58:09 +0000 - rev 469258
Push 83032 by rcaliman@mozilla.com at Fri, 12 Apr 2019 10:06:35 +0000
Bug 1543045 - Break strings for long CSS property names and values. r=gl Introduce `overflow-wrap: break-word` to CSS declarations in Rules view and Changes panel to prevent long strings from causing unwanted horizontal scroll Differential Revision: https://phabricator.services.mozilla.com/D27120
9f42988f15dfbfd0ea802c58455156bcc4e70a9e: Bug 1536808 - Add ability to edit devices r=gl
Micah Tigley <mtigley@mozilla.com> - Wed, 10 Apr 2019 17:37:33 +0000 - rev 468878
Push 82829 by mtigley@mozilla.com at Wed, 10 Apr 2019 22:07:22 +0000
Bug 1536808 - Add ability to edit devices r=gl Differential Revision: https://phabricator.services.mozilla.com/D22180
f5d262c8ae962a64dd0ca4916aa2c1638970ebba: Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 18:36:04 +0000 - rev 468846
Push 82825 by yura.zenevich@gmail.com at Wed, 10 Apr 2019 20:42:32 +0000
Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl Differential Revision: https://phabricator.services.mozilla.com/D26459
7bcd00bbcb716f26f996162dd7c7d89feb7a2e3f: Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 10 Apr 2019 00:58:44 +0000 - rev 468712
Push 82745 by yura.zenevich@gmail.com at Wed, 10 Apr 2019 03:20:18 +0000
Bug 1541666 - ensure that actors are alive when calling async API to the server. r=gl Differential Revision: https://phabricator.services.mozilla.com/D26459
9a36c745e301779141b1f53fce007c8dd1063990: Bug 1542367 - Remove the 'Done' button at the bottom of the device modal. r=gl
Micah Tigley <mtigley@mozilla.com> - Tue, 09 Apr 2019 20:16:07 +0000 - rev 468666
Push 82728 by mtigley@mozilla.com at Tue, 09 Apr 2019 21:20:54 +0000
Bug 1542367 - Remove the 'Done' button at the bottom of the device modal. r=gl Differential Revision: https://phabricator.services.mozilla.com/D26637
165b1912cabc6dc5fc6277995d80fbd1d7fd98e1: Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Micah Tigley <mtigley@mozilla.com> - Mon, 08 Apr 2019 20:22:12 +0000 - rev 468480
Push 82614 by mtigley@mozilla.com at Tue, 09 Apr 2019 02:11:03 +0000
Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl Differential Revision: https://phabricator.services.mozilla.com/D25142
4fef2150bef9f1274c59862511b619756ee8381e: Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl
Micah Tigley <mtigley@mozilla.com> - Mon, 08 Apr 2019 14:58:57 +0000 - rev 468370
Push 82542 by mtigley@mozilla.com at Mon, 08 Apr 2019 15:00:50 +0000
Bug 1534984 - Add a button for toggling print styles simulation in the Rule View toolbar r=gl Differential Revision: https://phabricator.services.mozilla.com/D25142
3195ecf25c27784dbe29b69d6df73839cfdf56c3: Bug 1538108 - Hide the computed expander and shorthand overridden list in the new rules view when the computed values are empty r=gl
Mellina Yonashiro <yonashiro.mellina@gmail.com> - Mon, 08 Apr 2019 01:27:47 -0400 - rev 468343
Push 82522 by dluca@mozilla.com at Mon, 08 Apr 2019 10:50:02 +0000
Bug 1538108 - Hide the computed expander and shorthand overridden list in the new rules view when the computed values are empty r=gl
ef359a791d6a5da56734432e5edca6873cdcf2ba: Bug 1536237 - Add support for letter spacing in Font Editor. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Tue, 02 Apr 2019 17:51:50 +0000 - rev 467643
Push 82094 by rcaliman@mozilla.com at Tue, 02 Apr 2019 19:34:00 +0000
Bug 1536237 - Add support for letter spacing in Font Editor. r=gl - Reads the value for the letter-spacing CSS property and shows it in the Font Editor. When it is default, show the "normal" identifier. As soon as the user tries to edit it using the value slider, switch to an em-based value. - Tweaks the unit conversion method to support letter-spacing: using correct reference node for em units, returning high-precision results even for pixels (allow sub-pixel precision) Differential Revision: https://phabricator.services.mozilla.com/D25087
e78a1f8b81db22f436bcecc335b39f105ff772f8: Bug 1536237 - Add support for letter spacing in Font Editor. r=gl
Razvan Caliman <rcaliman@mozilla.com> - Mon, 01 Apr 2019 09:45:11 +0000 - rev 467049
Push 81928 by rcaliman@mozilla.com at Mon, 01 Apr 2019 10:57:59 +0000
Bug 1536237 - Add support for letter spacing in Font Editor. r=gl - Reads the value for the letter-spacing CSS property and shows it in the Font Editor. When it is default, show the "normal" identifier. As soon as the user tries to edit it using the value slider, switch to an em-based value. - Tweaks the unit conversion method to support letter-spacing: using correct reference node for em units, returning high-precision results even for pixels (allow sub-pixel precision) Differential Revision: https://phabricator.services.mozilla.com/D25087
5b860d8c3379fb714f6a681af763584ef01fc3cf: Bug 1409085 - Tell RDM when picking to stop simulating touch; r=mtigley,gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 29 Mar 2019 09:47:35 +0000 - rev 466752
Push 81791 by pbrosset@mozilla.com at Fri, 29 Mar 2019 10:49:52 +0000
Bug 1409085 - Tell RDM when picking to stop simulating touch; r=mtigley,gl Differential Revision: https://phabricator.services.mozilla.com/D25231
e724e61a88017c8301b14f574ddb4c85ce722b65: Bug 1538676 - Hide the auto-expanded overridden longhands when value is empty; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Mon, 25 Mar 2019 13:56:20 +0000 - rev 465932
Push 81343 by pbrosset@mozilla.com at Mon, 25 Mar 2019 14:04:41 +0000
Bug 1538676 - Hide the auto-expanded overridden longhands when value is empty; r=gl Differential Revision: https://phabricator.services.mozilla.com/D24690
e72a35251ff8bc1c17eced9428d9961520b8e378: Bug 1536819 - Fix node.offsetParent is null error in Rule View r=gl
Michael Ratcliffe <mratcliffe@mozilla.com> - Fri, 22 Mar 2019 12:28:09 +0000 - rev 465685
Push 81187 by mratcliffe@mozilla.com at Fri, 22 Mar 2019 12:28:50 +0000
Bug 1536819 - Fix node.offsetParent is null error in Rule View r=gl The editing of selectors in the rule view is broken (see https://bugzil.la/1536867) but that is not related to this issue. Differential Revision: https://phabricator.services.mozilla.com/D24210
7dc16c389ba412f96d9487dd8032f744d93c8a38: Bug 1535315 - Hide computed expander when computed properties are undefined; r=gl
Patrick Brosset <pbrosset@mozilla.com> - Fri, 22 Mar 2019 02:06:46 +0000 - rev 465623
Push 81175 by pbrosset@mozilla.com at Fri, 22 Mar 2019 09:19:36 +0000
Bug 1535315 - Hide computed expander when computed properties are undefined; r=gl Differential Revision: https://phabricator.services.mozilla.com/D24364
6728cf304a8b1715e186a6021166cecd9925edb2: Bug 1343014 Part 1: Make RDM viewport dimension inputs have input type "number". r=gl
Brad Werth <bwerth@mozilla.com> - Wed, 20 Mar 2019 20:44:34 +0000 - rev 465312
Push 81014 by bwerth@mozilla.com at Thu, 21 Mar 2019 02:02:58 +0000
Bug 1343014 Part 1: Make RDM viewport dimension inputs have input type "number". r=gl This also changes the styling to prevent "spinners" from appearing. Differential Revision: https://phabricator.services.mozilla.com/D24054
fbdd97d8e41dd07bdcef93eae73a9c7e5fd72713: Bug 1487857 - Part I: Rearranging devices setting view to new design. r=gl,flod
Micah Tigley <mtigley@mozilla.com> - Tue, 19 Mar 2019 18:59:24 +0000 - rev 465143
Push 80924 by mtigley@mozilla.com at Tue, 19 Mar 2019 22:25:46 +0000
Bug 1487857 - Part I: Rearranging devices setting view to new design. r=gl,flod This is part 1 of implementing the redesigned device settings panel. In this patch we are rearranging the existing device settings view to match the new design. Differential Revision: https://phabricator.services.mozilla.com/D15734
8d9b4e8dce578a417cc0f2f98eaebe3cef47370f: Bug 1343014 Part 1: Make RDM viewport dimension inputs have input type "number". r=gl
Brad Werth <bwerth@mozilla.com> - Tue, 19 Mar 2019 20:11:24 +0000 - rev 465117
Push 80908 by bwerth@mozilla.com at Tue, 19 Mar 2019 20:22:21 +0000
Bug 1343014 Part 1: Make RDM viewport dimension inputs have input type "number". r=gl This also changes the styling to prevent "spinners" from appearing. Differential Revision: https://phabricator.services.mozilla.com/D24054
18a534223b49a21db9ae33658f38732aff268617: Bug 1521151 - Make Flexbox Inspector canvas take zoom into account when scrolling r=gl
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 19 Mar 2019 15:33:43 +0000 - rev 465058
Push 80865 by mratcliffe@mozilla.com at Tue, 19 Mar 2019 15:59:55 +0000
Bug 1521151 - Make Flexbox Inspector canvas take zoom into account when scrolling r=gl The Flexbox Inspector uses platform APIs that don't take zoom into account whilst the Grid Inspector uses APIs that do take zoom into account. This means that the zoom calculations when repositioning the canvas need to be different when called from the Flexbox Inspector than when called from the grid inspector. I have added a `zoomWindow` option to `canvas.js::updateCanvasElement()` that allows us to optionally apply zoom to the current canvas position and the flexbox issue reported in the bug now works just fine. All the usual other test cases work just fine with this patch applied. Differential Revision: https://phabricator.services.mozilla.com/D23887
137d3d35a3645f6b1ca4bbbb3eb2dbbeeeea0d73: Bug 1536096 - Unship the combined flexbox highlighter r=gl
Michael Ratcliffe <mratcliffe@mozilla.com> - Tue, 19 Mar 2019 03:36:09 +0000 - rev 465022
Push 80835 by mratcliffe@mozilla.com at Tue, 19 Mar 2019 12:13:29 +0000
Bug 1536096 - Unship the combined flexbox highlighter r=gl ### Try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2aaa84ba4f14dec2cf05b9fabb6ef1c334053897 Differential Revision: https://phabricator.services.mozilla.com/D23860
572526065fb20152c1a9a01e91a21bc7eb8f63d0: Bug 1501665 Part 13: Add a test of Responsive Design Mode resizing of meta viewports. r=gl
Brad Werth <bwerth@mozilla.com> - Mon, 18 Mar 2019 15:00:17 +0000 - rev 464850
Push 80735 by shindli@mozilla.com at Mon, 18 Mar 2019 16:26:01 +0000
Bug 1501665 Part 13: Add a test of Responsive Design Mode resizing of meta viewports. r=gl This test uses a Document with a fixed-width meta viewport. This test simulates resizing the RDM pane from a wide landscape size to a small square size, and back again. It does this again with meta viewport support turned on. Differential Revision: https://phabricator.services.mozilla.com/D22438