Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D54144

Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D54144

Bug 1598194 - Make FaultyLib-specific code FaultyLib-specific rather than Android-specific. r=gerald The custom linker used on Android (FaultyLib), can be enabled on non-Android, and in the near future, may not always be enabled on Android, so the FaultyLib-specific parts of the profile need to not be specific to Android, but to the linker being enabled instead. Differential Revision: https://phabricator.services.mozilla.com/D54073

Bug 1597972 - Remove the JS frames array from being stack allocated; r=gerald The native allocations feature added stackwalking that can happen anywhere that memory is allocated. This means that stackwalking happens in places where the execution already has a very large execution stack. Stackwalking was relying on stack-allocated buffers used for merging stacks. This was taking up 64kb of stack space. On Linux, this was causing a stack overflow, as there is only 256kb of stack space. I encountered a crash while using GDB. Using pointer arithmetic, I determined that the stack size before stack walking was around 20kb, and during stackwalking, we overflowed the stack (>256kb). The largest culprit was the JS::ProfilingFrameIterator::Frame jsFrames[MAX_JS_FRAMES]. In addition, Bug 1468789 added another member to the Frame class, also increasing the size of the stack allocation. I changed the implementation to allocate some memory on the CorePS class, and share that with every stackwalk that happens. I tested this loading a large news site, and didn't get any crashes. Differential Revision: https://phabricator.services.mozilla.com/D54072

Bug 1468789 - Part 3: Serialize innerWindowID for js/jit frames. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D51861

Bug 1468789 - Part 2: Collect inner window id information for js interpreter frames and add a mechanism to get that for jit frames r=gerald,jandem,mstange Differential Revision: https://phabricator.services.mozilla.com/D51860

Bug 1582741 - Add values to the native allocation payload; r=gerald This commit adds the memory address of the allocation and the thread id of the allocation to the payload. These both are required for properly processing the balanced allocations on the front-end. All of the native allocation payloads are now stored on the main thread, and so are disassociated from the thread where they were generated. Differential Revision: https://phabricator.services.mozilla.com/D51938

Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald This change makes it so that all allocations (from any thread in a process) are stored on the main thread in the profile. This way it's easy to balance allocations with frees. Memory happens more in a per-process model, than a per-thread model. The front-end can then process the information and display it in more interesting ways. Before allocations and deallocations were only stored on the thread where they were being generated. It was easy to miss deallocations with the old model. Differential Revision: https://phabricator.services.mozilla.com/D51937

Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald This patch creates a HashSet that tracks the allocations that are tracked by the profiler. This way, we only collect markers for deallocations that have a matching allocation. A following commit makes it so that all of the markers are collected on the main thread, but for now this is still done on a per-thread basis. Differential Revision: https://phabricator.services.mozilla.com/D51935

Bug 1582741 - Add values to the native allocation payload; r=gerald This commit adds the memory address of the allocation and the thread id of the allocation to the payload. These both are required for properly processing the balanced allocations on the front-end. All of the native allocation payloads are now stored on the main thread, and so are disassociated from the thread where they were generated. Differential Revision: https://phabricator.services.mozilla.com/D51938

Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald This change makes it so that all allocations (from any thread in a process) are stored on the main thread in the profile. This way it's easy to balance allocations with frees. Memory happens more in a per-process model, than a per-thread model. The front-end can then process the information and display it in more interesting ways. Before allocations and deallocations were only stored on the thread where they were being generated. It was easy to miss deallocations with the old model. Differential Revision: https://phabricator.services.mozilla.com/D51937

Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald This patch creates a HashSet that tracks the allocations that are tracked by the profiler. This way, we only collect markers for deallocations that have a matching allocation. A following commit makes it so that all of the markers are collected on the main thread, but for now this is still done on a per-thread basis. Differential Revision: https://phabricator.services.mozilla.com/D51935

Bug 1572337: Remove old responsiveness profiler measurement r=gerald Differential Revision: https://phabricator.services.mozilla.com/D44060

Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald Differential Revision: https://phabricator.services.mozilla.com/D41619

Bug 1572337: Remove old responsiveness profiler measurement r=gerald Differential Revision: https://phabricator.services.mozilla.com/D44060

Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald Differential Revision: https://phabricator.services.mozilla.com/D41619

Bug 1592818 - Add unit tests for IPCMarkerPayload; r=gerald Differential Revision: https://phabricator.services.mozilla.com/D51198

Bug 1588295 - Change popup test to use the js feature rather than stackwalk; r=gerald This test is relying on a profiler feature that is not available in every platform. This patch changes it to use the "js" feature, which should be supported everywhere. Differential Revision: https://phabricator.services.mozilla.com/D49948

Bug 1557447 part 2 - Remove unnecessary declarations from bug 1575448; r=gerald Differential Revision: https://phabricator.services.mozilla.com/D46389

Bug 1413750 - Handle shift by 32 bits. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D49226

Bug 1587503 - Provide a mechanism to inspect the current profiler configuration; r=gerald This patch creates a new API to the nsIProfiler interface, through the activeConfiguration property. It exposes the internal configuration of the profiler. In addition, this information is serialized into the profile meta object. Differential Revision: https://phabricator.services.mozilla.com/D48733

Bug 1512500 - Record parent page information in profiler r=gerald,nika Differential Revision: https://phabricator.services.mozilla.com/D47426

Bug 1583271 - Part 4: Update profiler page information tests r=gerald Differential Revision: https://phabricator.services.mozilla.com/D47268

Bug 1583271 - Part 1: Change profiler page information IDs to BrowsingContextID and InnerWindowID r=gerald,nika We were keeping nsDocShell::mHistoryId and nsDocShell::mOSHE as keys. They weren't quite good because: 1. While loading an iframe, they were being registered twice with the same ids(for about:blank and the real URL) sometimes. 2. It wasn't possible to access to the parent mHistoryId and mOSHE from a child processes if the parent is in a different process. That may not be the case for now, but it will be after fission. So we had to find other IDs to: 1. Determine the Tab of the frames. 2. Determine the URLs of the frames. For the first use case, we were using nsDocShell::mHistoryId for that purpose but that was wrong. The closest thing that we can get to a tab ID is BrowsingContext ID because they don't change after a navigation. But iframes have different BrowsingContext's, so we still need to create a tree to construct a tab content. That can be either in the front-end or capture time. For the second use case, we were using a key pair of mHistoryId and mOSHE. We now chose to keep inner window IDs for that purpose. Inner window IDs are unique for each navigation loads because inner window correspond to each JS window global objects. That's why we can use that without any problem. But one problem is that we cannot handle `history.pushState` and `history.replaceState` changes with that change since window global objects won't change during those. But that was the best thing we can do after fission. So this will be a small sacrifice for us to keep that functionality working after fission. In that patch we also remove the registration/unregistration calls. We are going to add those calls in the next patch. Differential Revision: https://phabricator.services.mozilla.com/D47065

Bug 1564475 - Add a mechanism to collect profiler backtraces; r=njn,gerald The profiler backtraces inside a memory hook are re-entrant for the profile lock. This patch adds additional guards to protect against this in order to allow for a profiler backtrace during native allocations. Differential Revision: https://phabricator.services.mozilla.com/D42195

Bug 1557564 - Enable Base Profiler in Windows. r=aklotz,gerald Bug 1556993 fixed the crash in PoisonIOInterposer (due to missing stdout&stderr fd's), bug 1559379 fixed the mozglue memory issue that the unit test experienced, and this patch also includes a fix for the test failure in browser_checkdllblockliststate.js. So now Base Profiler can be enabled by default on Windows, still using `MOZ_BASE_PROFILER_...` env-vars for now (upcoming bug will merge these with non-BASE env-vars soon). Differential Revision: https://phabricator.services.mozilla.com/D44091

Bug 1577934 - Remove using namespace std from dom/media audio tests r=gerald Differential Revision: https://phabricator.services.mozilla.com/D44290

Bug 1573090 - Part 3: Run rustfmt on tools/profiler/rust-helper/. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D43143

Bug 1573090 - Part 2: Look up ELF symbol tables directly when pre-symbolicating Gecko profiles on Linux. r=gerald Whereas previously MozDescribeCodeAddress would have handled demangling, we need to explicitly do that from our new GetFunction method. The string we generate is now more useful for the profiler to merge -- having dropped the address in the previous patch, and the file & line number and library in this patch. While we're at it, try to demangle Rust symbols too. Ideally we'd add Rust symbol handling to DemangleSymbol in StackWalk.cpp, but that lives in mozglue, which currently cannot have any Rust crate dependencies. Differential Revision: https://phabricator.services.mozilla.com/D43142

Bug 1573090 - Part 1: Use a CodeAddressService when pre-symbolicating Gecko profiles. r=gerald This speeds up pre-symbolication substantially. We add a new class ProfilerCodeAddressService as the next patch will add some functionality. This also changes the format of the string we generate when symbolicating, by dropping the leading address and space if we do have a string that MozDescribeCodeAddress gave us. (We'll change this format again in the next patch.) Differential Revision: https://phabricator.services.mozilla.com/D43141

Bug 1574187 - Stabilize profilerOverhead data in profile json. r=gerald Depends on D42285 Differential Revision: https://phabricator.services.mozilla.com/D42286

Bug 1574187 - Add a samples object that contains all the samples in profilerOverhead. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D42285

Bug 1573273: Add ProfilerLabelBegin and ProfilerLabelEnd to mozglue; r=gerald While mozglue continues to be the correct location for calling the affected code in this patch, the calls requiring profiler labels will soon be originating from firefox.exe via the launcher process. mozglue will be supplying the launcher process with an interface that consists of what are effectively "OnBeginDllLoad" and "OnEndDllLoad" callback notifications; obviously an RAII class is not going to be useful for that case. We still want to keep the RAII stuff around, however, since we still need it for cases where we need to fall back to using the legacy DLL blocklist. Differential Revision: https://phabricator.services.mozilla.com/D41807

Bug 1572235: Expose a method to remove markers leftover from previous runs of the profiler. r=gerald Differential Revision: https://phabricator.services.mozilla.com//D41275

Bug 1521929 - Remove RSS and USS measurements from the profiler; r=gerald,mixedpuppy Differential Revision: https://phabricator.services.mozilla.com/D40287

Bug 1571292 - -Wbool-operation: fix a warning (! instead of ~) r=gerald Differential Revision: https://phabricator.services.mozilla.com/D40574

Bug 1561881 - Always capture the memory counters when profiling r=gerald Differential Revision: https://phabricator.services.mozilla.com/D36186

Bug 1552286 - Move back GeckoJavaSampler to GeckoView and enable for it and fennec r=nalexander,gerald Bug 1303806 moved `GeckoJavaSampler` to be Fennec-only as part of a general push to slim GeckoView down. But there is no reason to restrict to Fennec and it is useful for other non-Fennec GeckoView vehicles. This patch moves the `GeckoJavaSampler` inside `geckoview` and changes profiler code to make Java sampling work in both GeckoView and Fennec. Depends on D33522 Differential Revision: https://phabricator.services.mozilla.com/D33502

Bug 1547472 - Ref count the ProfilerScreenshots structure r=gerald,jesup Differential Revision: https://phabricator.services.mozilla.com/D32524

Bug 1550422 - P27. Fix long line. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D32247

Bug 1551106 part 2. Stop using [array] in profiler's GetFeatures/GetAllFeatures. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D30968

Bug 1551106 part 1. Stop using [array] in StartProfiler. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D30967

Bug 1548371 - Fix --enable-task-tracer build. r=gerald Differential Revision: https://phabricator.services.mozilla.com/D29559

Bug 1532867 - Force unsigned arithmetic. r=gerald "For negative a, the behavior of a << b is undefined." https://en.cppreference.com/w/cpp/language/operator_arithmetic Differential Revision: https://phabricator.services.mozilla.com/D29459

Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel * Remove redundant virtual keywords * Mark all destructors of inheriting classes as virtual for clarity * Mark all classes without virtual destructor as final (exposed errors) * Make destructor virtual where it needed to be (some were missing) * Replace empty ({}) code declaration in header with = default * Remove virtual unused methods I probably missed some, it quickly became a rabbit hole. Differential Revision: https://phabricator.services.mozilla.com/D26060

Bug 1538081 - Part 4: Tests. r=froydnj,gerald Depends on D25024 Differential Revision: https://phabricator.services.mozilla.com/D25025

Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald Depends on D25023 Differential Revision: https://phabricator.services.mozilla.com/D25024

Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald Depends on D24583 Differential Revision: https://phabricator.services.mozilla.com/D25023

Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald Differential Revision: https://phabricator.services.mozilla.com/D24583

Bug 1538081 - Part 4: Tests. r=froydnj,gerald Depends on D25024 Differential Revision: https://phabricator.services.mozilla.com/D25025