searching for reviewer(gerald)
7d738ecde3127cda72344c8d17573691cb258dd5: Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 27 Nov 2019 14:27:39 +0000 - rev 504043
Push
101707 by canaltinova@gmail.com at Wed, 27 Nov 2019 14:36:11 +0000
Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D54144
4c2af658ce763a3dfad55acee7d922e33ffe08b7: Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 27 Nov 2019 12:54:13 +0000 - rev 504022
Push
101694 by canaltinova@gmail.com at Wed, 27 Nov 2019 13:19:50 +0000
Bug 1590706 - Part 1: Add a field inside ActivePS to hold the active BrowsingContext ID. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D54144
de739f20d4f9cd9a5848057c6d0e0d7ceb86910f: Bug 1598194 - Make FaultyLib-specific code FaultyLib-specific rather than Android-specific. r=gerald
Mike Hommey <mh+mozilla@glandium.org> - Mon, 25 Nov 2019 23:04:24 +0000 - rev 503759
Push
101529 by mh@glandium.org at Mon, 25 Nov 2019 23:11:34 +0000
Bug 1598194 - Make FaultyLib-specific code FaultyLib-specific rather than Android-specific. r=gerald
The custom linker used on Android (FaultyLib), can be enabled on
non-Android, and in the near future, may not always be enabled on
Android, so the FaultyLib-specific parts of the profile need to not be
specific to Android, but to the linker being enabled instead.
Differential Revision:
https://phabricator.services.mozilla.com/D54073
298ae54c2b278bc3d6a75c4b40a31324cc3e7b03: Bug 1597972 - Remove the JS frames array from being stack allocated; r=gerald
Greg Tatum <gtatum@mozilla.com> - Fri, 22 Nov 2019 19:50:25 +0000 - rev 503477
Push
101341 by gtatum@mozilla.com at Fri, 22 Nov 2019 22:21:39 +0000
Bug 1597972 - Remove the JS frames array from being stack allocated; r=gerald
The native allocations feature added stackwalking that can happen anywhere that
memory is allocated. This means that stackwalking happens in places where the
execution already has a very large execution stack. Stackwalking was relying
on stack-allocated buffers used for merging stacks. This was taking up 64kb of
stack space. On Linux, this was causing a stack overflow, as there is only 256kb of
stack space. I encountered a crash while using GDB. Using pointer arithmetic,
I determined that the stack size before stack walking was around 20kb, and during
stackwalking, we overflowed the stack (>256kb). The largest culprit was the
JS::ProfilingFrameIterator::Frame jsFrames[MAX_JS_FRAMES]. In addition,
Bug 1468789 added another member to the Frame class, also increasing the size
of the stack allocation.
I changed the implementation to allocate some memory on the CorePS class, and
share that with every stackwalk that happens. I tested this loading a large news
site, and didn't get any crashes.
Differential Revision:
https://phabricator.services.mozilla.com/D54072
e4ed5d091e3dd498dbeb416ece8399ffcf13d52e: Bug 1468789 - Part 3: Serialize innerWindowID for js/jit frames. r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Thu, 14 Nov 2019 14:15:03 +0000 - rev 502182
Push
100654 by canaltinova@gmail.com at Fri, 15 Nov 2019 13:29:30 +0000
Bug 1468789 - Part 3: Serialize innerWindowID for js/jit frames. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D51861
1c3c775faf994b0cb12be28fc5afca9f444569af: Bug 1468789 - Part 2: Collect inner window id information for js interpreter frames and add a mechanism to get that for jit frames r=gerald,jandem,mstange
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 15 Nov 2019 08:01:30 +0000 - rev 502181
Push
100654 by canaltinova@gmail.com at Fri, 15 Nov 2019 13:29:30 +0000
Bug 1468789 - Part 2: Collect inner window id information for js interpreter frames and add a mechanism to get that for jit frames r=gerald,jandem,mstange
Differential Revision:
https://phabricator.services.mozilla.com/D51860
e2b8a34e2aac27d21773cb2d3da1278f47550e4f: Bug 1582741 - Add values to the native allocation payload; r=gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 13 Nov 2019 16:19:16 +0000 - rev 501819
Push
100439 by gtatum@mozilla.com at Wed, 13 Nov 2019 20:05:58 +0000
Bug 1582741 - Add values to the native allocation payload; r=gerald
This commit adds the memory address of the allocation and the thread id
of the allocation to the payload. These both are required for properly
processing the balanced allocations on the front-end. All of the native
allocation payloads are now stored on the main thread, and so are
disassociated from the thread where they were generated.
Differential Revision:
https://phabricator.services.mozilla.com/D51938
439f620efb11ff3e421a3ffdab1deb6b76b79281: Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 13 Nov 2019 16:19:11 +0000 - rev 501818
Push
100439 by gtatum@mozilla.com at Wed, 13 Nov 2019 20:05:58 +0000
Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald
This change makes it so that all allocations (from any thread in a
process) are stored on the main thread in the profile. This way it's
easy to balance allocations with frees. Memory happens more in a
per-process model, than a per-thread model. The front-end can then
process the information and display it in more interesting ways.
Before allocations and deallocations were only stored on the
thread where they were being generated. It was easy to miss
deallocations with the old model.
Differential Revision:
https://phabricator.services.mozilla.com/D51937
b37cf462c34198a34ffe38ec1b9fc0ca56ab9a25: Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 13 Nov 2019 16:17:38 +0000 - rev 501816
Push
100439 by gtatum@mozilla.com at Wed, 13 Nov 2019 20:05:58 +0000
Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald
This patch creates a HashSet that tracks the allocations that are tracked by the profiler.
This way, we only collect markers for deallocations that have a matching allocation. A
following commit makes it so that all of the markers are collected on the main thread, but
for now this is still done on a per-thread basis.
Differential Revision:
https://phabricator.services.mozilla.com/D51935
fb009d42d01204cd1b2eeb55e8d9ddb82c3c4136: Bug 1582741 - Add values to the native allocation payload; r=gerald
Greg Tatum <gtatum@mozilla.com> - Tue, 12 Nov 2019 17:29:07 +0000 - rev 501629
Push
100330 by gtatum@mozilla.com at Tue, 12 Nov 2019 19:53:02 +0000
Bug 1582741 - Add values to the native allocation payload; r=gerald
This commit adds the memory address of the allocation and the thread id
of the allocation to the payload. These both are required for properly
processing the balanced allocations on the front-end. All of the native
allocation payloads are now stored on the main thread, and so are
disassociated from the thread where they were generated.
Differential Revision:
https://phabricator.services.mozilla.com/D51938
8a685f29970028ba5d40dc2211f73e68647db6b9: Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald
Greg Tatum <gtatum@mozilla.com> - Tue, 12 Nov 2019 16:55:46 +0000 - rev 501628
Push
100330 by gtatum@mozilla.com at Tue, 12 Nov 2019 19:53:02 +0000
Bug 1592625 - All threads' allocation markers get stored on the main thread; r=gerald
This change makes it so that all allocations (from any thread in a
process) are stored on the main thread in the profile. This way it's
easy to balance allocations with frees. Memory happens more in a
per-process model, than a per-thread model. The front-end can then
process the information and display it in more interesting ways.
Before allocations and deallocations were only stored on the
thread where they were being generated. It was easy to miss
deallocations with the old model.
Differential Revision:
https://phabricator.services.mozilla.com/D51937
cd7174320d45cc4d43412e9bc667d7a9bcc9559a: Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald
Greg Tatum <gtatum@mozilla.com> - Tue, 12 Nov 2019 17:29:06 +0000 - rev 501626
Push
100330 by gtatum@mozilla.com at Tue, 12 Nov 2019 19:53:02 +0000
Bug 1582741 - Balance the frees to the allocations in native allocation tracking; r=njn,gerald
This patch creates a HashSet that tracks the allocations that are tracked by the profiler.
This way, we only collect markers for deallocations that have a matching allocation. A
following commit makes it so that all of the markers are collected on the main thread, but
for now this is still done on a per-thread basis.
Differential Revision:
https://phabricator.services.mozilla.com/D51935
fef6230f3cb225c98a21f757f4fc26c77195fa26: Bug 1572337: Remove old responsiveness profiler measurement r=gerald
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:08:07 +0000 - rev 501383
Push
100169 by rjesup@wgate.com at Sat, 09 Nov 2019 10:13:02 +0000
Bug 1572337: Remove old responsiveness profiler measurement r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D44060
3d2bf6bfe93154fa81e73c8bb6f7fa49db8887a3: Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald
Randell Jesup <rjesup@wgate.com> - Fri, 08 Nov 2019 21:07:29 +0000 - rev 501378
Push
100169 by rjesup@wgate.com at Sat, 09 Nov 2019 10:13:02 +0000
Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D41619
913d6bd8228416202233162e0fb6c567ae93e709: Bug 1572337: Remove old responsiveness profiler measurement r=gerald
Randell Jesup <rjesup@wgate.com> - Thu, 07 Nov 2019 12:53:35 +0000 - rev 501084
Push
99977 by rjesup@wgate.com at Thu, 07 Nov 2019 14:04:19 +0000
Bug 1572337: Remove old responsiveness profiler measurement r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D44060
4eda65e054d8ebe2247c25f4c49abb000d5e6646: Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald
Randell Jesup <rjesup@wgate.com> - Thu, 07 Nov 2019 12:53:26 +0000 - rev 501081
Push
99974 by rjesup@wgate.com at Thu, 07 Nov 2019 13:55:52 +0000
Bug 1572337: ensure MainThread is registered with the profiler properly r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D41619
ff07f6f5fc7df913184059d03dd16c5a928448b0: Bug 1592818 - Add unit tests for IPCMarkerPayload; r=gerald
Jim Porter <jporter@mozilla.com> - Tue, 05 Nov 2019 03:56:38 +0000 - rev 500504
Push
99651 by jporter@mozilla.com at Tue, 05 Nov 2019 04:20:48 +0000
Bug 1592818 - Add unit tests for IPCMarkerPayload; r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D51198
6b5c158150f9b65088939c41fe2c56ed7efd9cef: Bug 1588295 - Change popup test to use the js feature rather than stackwalk; r=gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 23 Oct 2019 14:07:47 +0000 - rev 498720
Push
98635 by gtatum@mozilla.com at Wed, 23 Oct 2019 14:09:24 +0000
Bug 1588295 - Change popup test to use the js feature rather than stackwalk; r=gerald
This test is relying on a profiler feature that is not available in every
platform. This patch changes it to use the "js" feature, which should be
supported everywhere.
Differential Revision:
https://phabricator.services.mozilla.com/D49948
debb6f82c687e67f5493ce1db5fcf7b12888d0b8: Bug 1557447 part 2 - Remove unnecessary declarations from bug 1575448; r=gerald
Jim Porter <jporter@mozilla.com> - Thu, 17 Oct 2019 23:39:44 +0000 - rev 498067
Push
98260 by jporter@mozilla.com at Thu, 17 Oct 2019 23:52:21 +0000
Bug 1557447 part 2 - Remove unnecessary declarations from
bug 1575448; r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D46389
e620adbcbb8e04e77c40973cc30021b4f6d6ff85: Bug 1413750 - Handle shift by 32 bits. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 15 Oct 2019 20:18:08 +0000 - rev 497780
Push
98067 by jyavenard@mozilla.com at Wed, 16 Oct 2019 05:49:18 +0000
Bug 1413750 - Handle shift by 32 bits. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D49226
d5a6d3421d546b79418ddd279e8dc24b739e2cff: Bug 1587503 - Provide a mechanism to inspect the current profiler configuration; r=gerald
Greg Tatum <gtatum@mozilla.com> - Fri, 11 Oct 2019 18:22:42 +0000 - rev 497323
Push
97811 by gtatum@mozilla.com at Fri, 11 Oct 2019 19:49:26 +0000
Bug 1587503 - Provide a mechanism to inspect the current profiler configuration; r=gerald
This patch creates a new API to the nsIProfiler interface, through the activeConfiguration
property. It exposes the internal configuration of the profiler. In addition, this information
is serialized into the profile meta object.
Differential Revision:
https://phabricator.services.mozilla.com/D48733
1bebf33be0d5404dfb486d92bca7ba5c36384c58: Bug 1512500 - Record parent page information in profiler r=gerald,nika
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 09 Oct 2019 21:25:19 +0000 - rev 497064
Push
97630 by canaltinova@gmail.com at Wed, 09 Oct 2019 21:34:11 +0000
Bug 1512500 - Record parent page information in profiler r=gerald,nika
Differential Revision:
https://phabricator.services.mozilla.com/D47426
07b6734ecc4e41c3a2135490c12ff5b193446805: Bug 1583271 - Part 4: Update profiler page information tests r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 09 Oct 2019 20:58:21 +0000 - rev 497063
Push
97630 by canaltinova@gmail.com at Wed, 09 Oct 2019 21:34:11 +0000
Bug 1583271 - Part 4: Update profiler page information tests r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D47268
aa846af7a710188875c8039aea018650a0873fd5: Bug 1583271 - Part 1: Change profiler page information IDs to BrowsingContextID and InnerWindowID r=gerald,nika
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 09 Oct 2019 21:25:11 +0000 - rev 497060
Push
97630 by canaltinova@gmail.com at Wed, 09 Oct 2019 21:34:11 +0000
Bug 1583271 - Part 1: Change profiler page information IDs to BrowsingContextID and InnerWindowID r=gerald,nika
We were keeping nsDocShell::mHistoryId and nsDocShell::mOSHE as keys. They
weren't quite good because:
1. While loading an iframe, they were being registered twice with the same
ids(for about:blank and the real URL) sometimes.
2. It wasn't possible to access to the parent mHistoryId and mOSHE from a child
processes if the parent is in a different process. That may not be the case for
now, but it will be after fission.
So we had to find other IDs to:
1. Determine the Tab of the frames.
2. Determine the URLs of the frames.
For the first use case, we were using nsDocShell::mHistoryId for that purpose
but that was wrong. The closest thing that we can get to a tab ID is
BrowsingContext ID because they don't change after a navigation. But iframes
have different BrowsingContext's, so we still need to create a tree to
construct a tab content. That can be either in the front-end or capture time.
For the second use case, we were using a key pair of mHistoryId and mOSHE. We
now chose to keep inner window IDs for that purpose. Inner window IDs are
unique for each navigation loads because inner window correspond to each JS
window global objects. That's why we can use that without any problem. But one
problem is that we cannot handle `history.pushState` and `history.replaceState`
changes with that change since window global objects won't change during those.
But that was the best thing we can do after fission. So this will be a small
sacrifice for us to keep that functionality working after fission.
In that patch we also remove the registration/unregistration calls. We are
going to add those calls in the next patch.
Differential Revision:
https://phabricator.services.mozilla.com/D47065
57a891548aca1c8e0a8eb4680b1ebc2c17169fd9: Bug 1564475 - Add a mechanism to collect profiler backtraces; r=njn,gerald
Greg Tatum <gtatum@mozilla.com> - Wed, 18 Sep 2019 18:46:19 +0000 - rev 493958
Push
95779 by gtatum@mozilla.com at Thu, 19 Sep 2019 02:57:55 +0000
Bug 1564475 - Add a mechanism to collect profiler backtraces; r=njn,gerald
The profiler backtraces inside a memory hook are re-entrant for the
profile lock. This patch adds additional guards to protect against this
in order to allow for a profiler backtrace during native allocations.
Differential Revision:
https://phabricator.services.mozilla.com/D42195
299dc828295affd36fcb7381c5a3b4f4e7757198: Bug 1557564 - Enable Base Profiler in Windows. r=aklotz,gerald
Toshihito Kikuchi <tkikuchi@mozilla.com> - Tue, 03 Sep 2019 23:27:46 +0000 - rev 491619
Push
94407 by aklotz@mozilla.com at Tue, 03 Sep 2019 23:33:54 +0000
Bug 1557564 - Enable Base Profiler in Windows. r=aklotz,gerald
Bug 1556993 fixed the crash in PoisonIOInterposer (due to missing stdout&stderr
fd's),
bug 1559379 fixed the mozglue memory issue that the unit test
experienced, and this patch also includes a fix for the test failure in
browser_checkdllblockliststate.js.
So now Base Profiler can be enabled by default on Windows, still using
`MOZ_BASE_PROFILER_...` env-vars for now (upcoming bug will merge these with
non-BASE env-vars soon).
Differential Revision:
https://phabricator.services.mozilla.com/D44091
e714dd56f2de11115529a26112a4013a4b2726af: Bug 1577934 - Remove using namespace std from dom/media audio tests r=gerald
Eric Rahm <erahm@mozilla.com> - Sun, 01 Sep 2019 06:47:26 +0000 - rev 491055
Push
94207 by erahm@mozilla.com at Sun, 01 Sep 2019 06:48:07 +0000
Bug 1577934 - Remove using namespace std from dom/media audio tests r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D44290
a82e5f008873bfae613dde49f1ef44a439050c5b: Bug 1573090 - Part 3: Run rustfmt on tools/profiler/rust-helper/. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:23 +0000 - rev 489563
Push
93439 by cmccormack@mozilla.com at Fri, 23 Aug 2019 07:16:31 +0000
Bug 1573090 - Part 3: Run rustfmt on tools/profiler/rust-helper/. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D43143
9a33b94c2471e4aea327866d4c5dd2d04e18f938: Bug 1573090 - Part 2: Look up ELF symbol tables directly when pre-symbolicating Gecko profiles on Linux. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:16 +0000 - rev 489562
Push
93439 by cmccormack@mozilla.com at Fri, 23 Aug 2019 07:16:31 +0000
Bug 1573090 - Part 2: Look up ELF symbol tables directly when pre-symbolicating Gecko profiles on Linux. r=gerald
Whereas previously MozDescribeCodeAddress would have handled demangling,
we need to explicitly do that from our new GetFunction method. The string we
generate is now more useful for the profiler to merge -- having dropped the
address in the previous patch, and the file & line number and library in this
patch.
While we're at it, try to demangle Rust symbols too.
Ideally we'd add Rust symbol handling to DemangleSymbol in
StackWalk.cpp, but that lives in mozglue, which currently cannot have
any Rust crate dependencies.
Differential Revision:
https://phabricator.services.mozilla.com/D43142
e76bdefd65400dfbb63813067794ffdd97053ed5: Bug 1573090 - Part 1: Use a CodeAddressService when pre-symbolicating Gecko profiles. r=gerald
Cameron McCormack <cam@mcc.id.au> - Fri, 23 Aug 2019 05:45:14 +0000 - rev 489561
Push
93439 by cmccormack@mozilla.com at Fri, 23 Aug 2019 07:16:31 +0000
Bug 1573090 - Part 1: Use a CodeAddressService when pre-symbolicating Gecko profiles. r=gerald
This speeds up pre-symbolication substantially.
We add a new class ProfilerCodeAddressService as the next patch will add
some functionality.
This also changes the format of the string we generate when
symbolicating, by dropping the leading address and space if we do have a
string that MozDescribeCodeAddress gave us. (We'll change this format
again in the next patch.)
Differential Revision:
https://phabricator.services.mozilla.com/D43141
819d45761f2f047021814b400b8a225475f08695: Bug 1574187 - Stabilize profilerOverhead data in profile json. r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 16 Aug 2019 12:18:01 +0000 - rev 488551
Push
92800 by canaltinova@gmail.com at Fri, 16 Aug 2019 15:31:32 +0000
Bug 1574187 - Stabilize profilerOverhead data in profile json. r=gerald
Depends on D42285
Differential Revision:
https://phabricator.services.mozilla.com/D42286
14b3bc9347aad65ffd22acd92cc2f96c46c7de3f: Bug 1574187 - Add a samples object that contains all the samples in profilerOverhead. r=gerald
Nazım Can Altınova <canaltinova@gmail.com> - Fri, 16 Aug 2019 12:17:29 +0000 - rev 488550
Push
92800 by canaltinova@gmail.com at Fri, 16 Aug 2019 15:31:32 +0000
Bug 1574187 - Add a samples object that contains all the samples in profilerOverhead. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D42285
02d5d29830cf35a3c467bc6fa21864230ea73475: Bug 1573273: Add ProfilerLabelBegin and ProfilerLabelEnd to mozglue; r=gerald
Aaron Klotz <aklotz@mozilla.com> - Wed, 14 Aug 2019 03:46:41 +0000 - rev 487927
Push
92547 by aklotz@mozilla.com at Wed, 14 Aug 2019 14:36:41 +0000
Bug 1573273: Add ProfilerLabelBegin and ProfilerLabelEnd to mozglue; r=gerald
While mozglue continues to be the correct location for calling the affected
code in this patch, the calls requiring profiler labels will soon be
originating from firefox.exe via the launcher process.
mozglue will be supplying the launcher process with an interface that consists
of what are effectively "OnBeginDllLoad" and "OnEndDllLoad" callback
notifications; obviously an RAII class is not going to be useful for that case.
We still want to keep the RAII stuff around, however, since we still need it
for cases where we need to fall back to using the legacy DLL blocklist.
Differential Revision:
https://phabricator.services.mozilla.com/D41807
c9c7f28c239366c6b6de7fb7bdd727f095e95f27: Bug 1572235: Expose a method to remove markers leftover from previous runs of the profiler. r=gerald
Will Hawkins <whawkins@mozilla.com> - Fri, 09 Aug 2019 21:04:57 +0300 - rev 487537
Push
92320 by malexandru@mozilla.com at Mon, 12 Aug 2019 21:59:56 +0000
Bug 1572235: Expose a method to remove markers leftover from previous runs of the profiler. r=gerald
Differential Revision: https://phabricator.services.mozilla.com//D41275
49893566430d4b9e247d45abd48219ba1bd6bec6: Bug 1521929 - Remove RSS and USS measurements from the profiler; r=gerald,mixedpuppy
Greg Tatum <gtatum@mozilla.com> - Mon, 05 Aug 2019 15:37:18 +0000 - rev 486248
Push
91726 by gtatum@mozilla.com at Mon, 05 Aug 2019 20:23:54 +0000
Bug 1521929 - Remove RSS and USS measurements from the profiler; r=gerald,mixedpuppy
Differential Revision:
https://phabricator.services.mozilla.com/D40287
9ed9c76181b005e65469e6cdb2f78a03ce712146: Bug 1571292 - -Wbool-operation: fix a warning (! instead of ~) r=gerald
Sylvestre Ledru <sledru@mozilla.com> - Sun, 04 Aug 2019 22:00:40 +0000 - rev 486140
Push
91654 by gsquelart@mozilla.com at Sun, 04 Aug 2019 22:02:12 +0000
Bug 1571292 - -Wbool-operation: fix a warning (! instead of ~) r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D40574
05f2566c282ad4d40317fc9bfd06a82a08ab39f5: Bug 1561881 - Always capture the memory counters when profiling r=gerald
Julien Wajsberg <felash@gmail.com> - Thu, 27 Jun 2019 14:02:30 +0000 - rev 480554
Push
88759 by jwajsberg@mozilla.com at Fri, 28 Jun 2019 13:25:37 +0000
Bug 1561881 - Always capture the memory counters when profiling r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D36186
360223a7a4d735a9fa60b610201b11e149beed8d: Bug 1552286 - Move back GeckoJavaSampler to GeckoView and enable for it and fennec r=nalexander,gerald
Nazım Can Altınova <canaltinova@gmail.com> - Wed, 05 Jun 2019 10:58:47 +0000 - rev 477608
Push
87251 by canaltinova@gmail.com at Thu, 06 Jun 2019 11:00:20 +0000
Bug 1552286 - Move back GeckoJavaSampler to GeckoView and enable for it and fennec r=nalexander,gerald
Bug 1303806 moved `GeckoJavaSampler` to be Fennec-only as part of a general push
to slim GeckoView down. But there is no reason to restrict to Fennec and it is useful
for other non-Fennec GeckoView vehicles.
This patch moves the `GeckoJavaSampler` inside `geckoview` and changes profiler
code to make Java sampling work in both GeckoView and Fennec.
Depends on D33522
Differential Revision:
https://phabricator.services.mozilla.com/D33502
cc4f2327ff1941b6fbe29fee50df3172a1a80256: Bug 1547472 - Ref count the ProfilerScreenshots structure r=gerald,jesup
Barret Rennie <barret@brennie.ca> - Fri, 24 May 2019 23:53:28 +0000 - rev 475526
Push
86360 by brennie@mozilla.com at Fri, 24 May 2019 23:54:48 +0000
Bug 1547472 - Ref count the ProfilerScreenshots structure r=gerald,jesup
Differential Revision:
https://phabricator.services.mozilla.com/D32524
5dd10a365ba9d6ddfe78f995c9ae44efdfb8a0ff: Bug 1550422 - P27. Fix long line. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 23 May 2019 00:22:21 +0000 - rev 475076
Push
86147 by jyavenard@mozilla.com at Thu, 23 May 2019 01:05:13 +0000
09369fc85b211379428243a53c1e5d00d95f99fb: Bug 1551106 part 2. Stop using [array] in profiler's GetFeatures/GetAllFeatures. r=gerald
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 21 May 2019 14:43:10 +0000 - rev 474759
Push
85972 by bzbarsky@mozilla.com at Tue, 21 May 2019 14:44:06 +0000
Bug 1551106 part 2. Stop using [array] in profiler's GetFeatures/GetAllFeatures. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D30968
f454d7e7502cdade0993677166911085b231963d: Bug 1551106 part 1. Stop using [array] in StartProfiler. r=gerald
Boris Zbarsky <bzbarsky@mit.edu> - Tue, 21 May 2019 14:42:57 +0000 - rev 474758
Push
85972 by bzbarsky@mozilla.com at Tue, 21 May 2019 14:44:06 +0000
Bug 1551106 part 1. Stop using [array] in StartProfiler. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D30967
523bbc540caf41b1b840e35268790322fa8711f9: Bug 1548371 - Fix --enable-task-tracer build. r=gerald
Markus Stange <mstange@themasta.com> - Thu, 02 May 2019 11:09:11 +0000 - rev 472328
Push
84602 by mstange@themasta.com at Thu, 02 May 2019 17:47:54 +0000
Bug 1548371 - Fix --enable-task-tracer build. r=gerald
Differential Revision:
https://phabricator.services.mozilla.com/D29559
be38681e82877a61527772e5831ccd6399aec61d: Bug 1532867 - Force unsigned arithmetic. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 01 May 2019 07:20:23 +0000 - rev 472216
Push
84523 by jyavenard@mozilla.com at Wed, 01 May 2019 23:15:17 +0000
Bug 1532867 - Force unsigned arithmetic. r=gerald
"For negative a, the behavior of a << b is undefined." https://en.cppreference.com/w/cpp/language/operator_arithmetic
Differential Revision:
https://phabricator.services.mozilla.com/D29459
884f5dc55873c9345ee945cd6d5427e8ab398071: Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 11 Apr 2019 12:36:51 +0000 - rev 469151
Push
82995 by jyavenard@mozilla.com at Thu, 11 Apr 2019 23:28:35 +0000
Bug 1540581 - P6. Tidy some C++ declarations in gfx/. r=gerald,jrmuizel
* Remove redundant virtual keywords
* Mark all destructors of inheriting classes as virtual for clarity
* Mark all classes without virtual destructor as final (exposed errors)
* Make destructor virtual where it needed to be (some were missing)
* Replace empty ({}) code declaration in header with = default
* Remove virtual unused methods
I probably missed some, it quickly became a rabbit hole.
Differential Revision:
https://phabricator.services.mozilla.com/D26060
ac91a1c2e3f530dad623df6983ace85d6ba40a77: Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:24:34 +0000 - rev 466933
Push
81890 by cmccormack@mozilla.com at Sat, 30 Mar 2019 04:44:27 +0000
Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Depends on D25024
Differential Revision:
https://phabricator.services.mozilla.com/D25025
a01e770ef4f534b9ab9989be2080be0c59e6cbda: Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:26:26 +0000 - rev 466932
Push
81890 by cmccormack@mozilla.com at Sat, 30 Mar 2019 04:44:27 +0000
Bug 1538081 - Part 3: Add operator<<(ostream&) definitions for a few common types. r=froydnj,gerald
Depends on D25023
Differential Revision:
https://phabricator.services.mozilla.com/D25024
3ae52b39cf6fa20b0ca827dad49610e6b154997c: Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:15 +0000 - rev 466931
Push
81890 by cmccormack@mozilla.com at Sat, 30 Mar 2019 04:44:27 +0000
Bug 1538081 - Part 2: Add MOZ_DEFINE_DBG. r=froydnj,gerald
Depends on D24583
Differential Revision:
https://phabricator.services.mozilla.com/D25023
b9e91906edae1ca73ce9f69aa8ad26b9e588deef: Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 04:25:13 +0000 - rev 466930
Push
81890 by cmccormack@mozilla.com at Sat, 30 Mar 2019 04:44:27 +0000
Bug 1538081 - Part 1: Add MOZ_DBG macro. r=froydnj,gerald
Differential Revision:
https://phabricator.services.mozilla.com/D24583
ced61a86c74c6ce2a966b2ac7880cfe3e7a8e0d8: Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Cameron McCormack <cam@mcc.id.au> - Sat, 30 Mar 2019 00:21:26 +0000 - rev 466899
Push
81881 by cmccormack@mozilla.com at Sat, 30 Mar 2019 00:22:32 +0000
Bug 1538081 - Part 4: Tests. r=froydnj,gerald
Depends on D25024
Differential Revision:
https://phabricator.services.mozilla.com/D25025