searching for reviewer(froydnj)
45abb8f9b9b31c5d14a4b116fe80dbe569e257b6: Bug 1163021 - add debug assert that directory service usage happens only on the main thread, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 13 Sep 2019 16:08:48 +0000 - rev 493106
Push 95327 by gijskruitbosch@gmail.com at Fri, 13 Sep 2019 16:54:15 +0000
Bug 1163021 - add debug assert that directory service usage happens only on the main thread, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45832
abcbc3635aefb5f3355ca2913bb5f0b0a5fc2441: Bug 1580182 - Allow mozilla::SupportsWeakPtr be on base classes as well, r=froydnj
Honza Bambas <honzab.moz@firemni.cz> - Wed, 11 Sep 2019 19:44:17 +0000 - rev 493021
Push 95270 by honzab.moz@firemni.cz at Fri, 13 Sep 2019 08:29:55 +0000
Bug 1580182 - Allow mozilla::SupportsWeakPtr be on base classes as well, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45515
b23b78103bc0d1e74e06b9148d5e0999a6f266c3: Bug 1580908 - Part 10: Revendor dependencies. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:32 +0000 - rev 492922
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 10: Revendor dependencies. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45719
fb4dc0ba6fe0e33ff01c8b5f2d2334d2f03b38f7: Bug 1580908 - Part 9: Deduplicate a few dependencies. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:28 +0000 - rev 492921
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 9: Deduplicate a few dependencies. r=froydnj Generated with: - cargo update -p Inflector -p phf_generator -p phf -p phf_shared -p phf_codegen -p dirs -p rayon -p tokio-threadpool -p crossbeam-deque -p redox_users -p flate2 -p arrayref - cargo update -p tempfile --precise 3.0.5 Differential Revision: https://phabricator.services.mozilla.com/D45718
f44fe7069e3b055e0b09da373df55e2ae6ca7594: Bug 1580908 - Part 7: Update glob to 0.3. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:17 +0000 - rev 492918
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 7: Update glob to 0.3. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45715
41fa683393b5f17ff6ba27f4931bc9761e762af7: Bug 1580908 - Part 5: Update rand to 0.6 in bits_client. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:13 +0000 - rev 492917
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 5: Update rand to 0.6 in bits_client. r=froydnj I deliberately didn't update to the latest rand version to avoid introducing yet another version. The update to rand 0.7 will have to wait a bit more as dependencies aren't ready yet Differential Revision: https://phabricator.services.mozilla.com/D45714
4cd6ca31c9e8bbe5644e185baf553cc6aaaaa851: Bug 1580908 - Part 4: Update num-traits to 0.2 in js to dedupe it. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:09 +0000 - rev 492916
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 4: Update num-traits to 0.2 in js to dedupe it. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45713
3e5a9fd54da03d4ce7638f9371cabe236262b4c6: Bug 1580908 - Part 3: Deduplicate memmap by updating it to 0.7 in profiler_helper. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:06 +0000 - rev 492915
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 3: Deduplicate memmap by updating it to 0.7 in profiler_helper. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45712
bdb344b505fba827d6740f9a2849f45b2ae3a8e2: Bug 1580908 - Part 2: Update env_logger to 0.6. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:46:02 +0000 - rev 492914
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 2: Update env_logger to 0.6. r=froydnj This is one less dependency on regex 0.2 Differential Revision: https://phabricator.services.mozilla.com/D45711
641f75b6c5d8d475ea7645aca80cb7237764cead: Bug 1580908 - Part 1: Update uuid to 0.7 to dedupe it. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Thu, 12 Sep 2019 21:45:58 +0000 - rev 492913
Push 95234 by eijebong@bananium.fr at Thu, 12 Sep 2019 21:49:11 +0000
Bug 1580908 - Part 1: Update uuid to 0.7 to dedupe it. r=froydnj This also removes a dependency on rand 0.4 getting it closer to being able to remove that. Differential Revision: https://phabricator.services.mozilla.com/D45710
17d05bce77f482ac2ad613b1b769a1d6961a73a4: Bug 1580497 - Fix topobjdir in 1-tier PGO builds; r=froydnj
Mike Shal <mshal@mozilla.com> - Thu, 12 Sep 2019 19:30:17 +0000 - rev 492891
Push 95216 by mshal@mozilla.com at Thu, 12 Sep 2019 20:08:33 +0000
Bug 1580497 - Fix topobjdir in 1-tier PGO builds; r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45707
8c5640edebc663298f77cab04a849690e9e042d1: Bug 1577937 - StaticDataMutex for when you want a DataMutex but Static r=froydnj
Chris H-C <chutten@mozilla.com> - Thu, 12 Sep 2019 19:58:01 +0000 - rev 492889
Push 95214 by archaeopteryx@coole-files.de at Thu, 12 Sep 2019 19:59:30 +0000
Bug 1577937 - StaticDataMutex for when you want a DataMutex but Static r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45558
8dd82e13bdf6ec7198b4c4ea62e6c51d43e4f3ec: Bug 1577937 - Throw a StaticDataMutex around sTelemetry r=janerik,froydnj
Chris H-C <chutten@mozilla.com> - Thu, 12 Sep 2019 19:58:01 +0000 - rev 492888
Push 95214 by archaeopteryx@coole-files.de at Thu, 12 Sep 2019 19:59:30 +0000
Bug 1577937 - Throw a StaticDataMutex around sTelemetry r=janerik,froydnj It could very well happen that someone calls into a static method of TelemetryImpl during Telemetry shutdown. There could be a race where sTelemetry is non-null at the top of a method like CanRecordExtended, but is null by the time we try to use it. So let's put a StaticDataMutex around it. This isn't trying to mutex the data itself. Instead I'm just trying to protect places where the pointer is being read or changed. Differential Revision: https://phabricator.services.mozilla.com/D44905
1723bbf66ebdc249ad3d192d6fa4a6fe2fb66896: Bug 1580664 - #include <sys/types.h> in jsctypes-test.h - r=froydnj
Gerald Squelart <gsquelart@mozilla.com> - Thu, 12 Sep 2019 13:06:49 +0000 - rev 492818
Push 95172 by nfroyd@mozilla.com at Thu, 12 Sep 2019 13:07:27 +0000
Bug 1580664 - #include <sys/types.h> in jsctypes-test.h - r=froydnj After removing <wchar.h> from TypeTraits.h in bug 1580458, there was a build failure in jsctypes-test.h on some platforms, because of an undefined `off_t`, which can be found in sys/types.h. Differential Revision: https://phabricator.services.mozilla.com/D45618
439344dd137997adfc3545763c15b0c315159069: Bug 1556347 - Set MOZ_HEADLESS for gtests and headless fuzzing. r=froydnj
Christian Holler <choller@mozilla.com> - Wed, 11 Sep 2019 19:33:43 +0000 - rev 492738
Push 95116 by choller@mozilla.com at Wed, 11 Sep 2019 20:29:13 +0000
Bug 1556347 - Set MOZ_HEADLESS for gtests and headless fuzzing. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45246
3ed264b9dc879feabccc1699ba05b3a87ee84bf8: Bug 1556347 - Set MOZ_HEADLESS for gtests and headless fuzzing. r=froydnj
Christian Holler <choller@mozilla.com> - Tue, 10 Sep 2019 15:26:39 +0000 - rev 492526
Push 94965 by choller@mozilla.com at Tue, 10 Sep 2019 15:28:18 +0000
Bug 1556347 - Set MOZ_HEADLESS for gtests and headless fuzzing. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45246
9dd37b1e1cbb13ba70f5a3badafd64253655d669: Bug 1580128 - Simplify required env variables for fuzzing interface. r=froydnj
Christian Holler <choller@mozilla.com> - Tue, 10 Sep 2019 14:33:58 +0000 - rev 492522
Push 94962 by choller@mozilla.com at Tue, 10 Sep 2019 15:25:28 +0000
Bug 1580128 - Simplify required env variables for fuzzing interface. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45318
90d9e9be37138da5721acfac318e7efda87f72dd: Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 10 Sep 2019 12:08:02 +0000 - rev 492510
Push 94955 by dluca@mozilla.com at Tue, 10 Sep 2019 14:39:57 +0000
Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44982
4f6f99cfc655d1046ca8dab36ea9bd3532c0db9d: Bug 1575479 - Encapsulate mBaseHashtableET::mData. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 10 Sep 2019 13:51:09 +0000 - rev 492509
Push 94955 by dluca@mozilla.com at Tue, 10 Sep 2019 14:39:57 +0000
Bug 1575479 - Encapsulate mBaseHashtableET::mData. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45004
dcbc7c69fb6450f79cc7f3743fe88a57b2e826e6: Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 09 Sep 2019 14:27:24 +0000 - rev 492489
Push 94937 by ccoroiu@mozilla.com at Tue, 10 Sep 2019 11:40:47 +0000
Bug 1575479 - Add support for STL iterators and range-based for to nsBaseHashtable. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44982
6d54a8115393018d4e2b51c6c106cdbb9b369e50: Bug 1575479 - Encapsulate mBaseHashtableET::mData. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Fri, 06 Sep 2019 14:14:06 +0000 - rev 492488
Push 94937 by ccoroiu@mozilla.com at Tue, 10 Sep 2019 11:40:47 +0000
Bug 1575479 - Encapsulate mBaseHashtableET::mData. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45004
6a5d823c5ae4baa5aae89d197915f1dfaf7d3c61: Bug 1579859 - don't use nsDirectoryService::Get to get gre dir on a non-main thread, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Mon, 09 Sep 2019 18:27:33 +0000 - rev 492292
Push 94872 by gijskruitbosch@gmail.com at Mon, 09 Sep 2019 18:32:22 +0000
Bug 1579859 - don't use nsDirectoryService::Get to get gre dir on a non-main thread, r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45209
7e03c315ddd3b8cd0123ce0fde71dc82daf68d04: Bug 1579504 - Increase max-run-time for linux64-base-toolchains(-clang)/debug tasks; r=froydnj
Geoff Brown <gbrown@mozilla.com> - Mon, 09 Sep 2019 16:21:29 +0000 - rev 492276
Push 94856 by gbrown@mozilla.com at Mon, 09 Sep 2019 16:28:07 +0000
Bug 1579504 - Increase max-run-time for linux64-base-toolchains(-clang)/debug tasks; r=froydnj Increase max-run-time to avoid intermittent failures due to variance in robustcheckout performance. Differential Revision: https://phabricator.services.mozilla.com/D45200
84bdce39768a5aa773223a20eacf8f389b466cdb: Bug 1579351 - Add constant complexity for MemMoveAnnotation when looking for specific `std::atomic`. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Mon, 09 Sep 2019 13:30:16 +0000 - rev 492249
Push 94834 by bpostelnicu@mozilla.com at Mon, 09 Sep 2019 14:13:22 +0000
Bug 1579351 - Add constant complexity for MemMoveAnnotation when looking for specific `std::atomic`. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45027
da82816d4978ef7a7190514c652a05efc600c45e: Bug 1566174 - Part 1: Add ffmpeg and chromedriver fetch tasks for browsertime. r=froydnj
Nick Alexander <nalexander@mozilla.com> - Fri, 30 Aug 2019 21:57:03 +0000 - rev 492085
Push 94727 by nalexander@mozilla.com at Fri, 06 Sep 2019 19:31:34 +0000
Bug 1566174 - Part 1: Add ffmpeg and chromedriver fetch tasks for browsertime. r=froydnj Browsertime needs these to produce videos, and to invoke Chrome, respectively. Differential Revision: https://phabricator.services.mozilla.com/D43698
782406529ec417dbc20a3c591e7b946732ada0cf: Bug 1579425 - Part 2: Revendor dependencies. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Fri, 06 Sep 2019 17:49:58 +0000 - rev 492082
Push 94724 by eijebong@bananium.fr at Fri, 06 Sep 2019 19:21:03 +0000
Bug 1579425 - Part 2: Revendor dependencies. r=froydnj Depends on D45046 Differential Revision: https://phabricator.services.mozilla.com/D45047
2a3eff133e23381fdaeb6ab616891ae83effb27f: Bug 1579425 - Part 1: Update goblin and object. r=froydnj
Bastien Orivel <eijebong@bananium.fr> - Fri, 06 Sep 2019 17:49:51 +0000 - rev 492081
Push 94724 by eijebong@bananium.fr at Fri, 06 Sep 2019 19:21:03 +0000
Bug 1579425 - Part 1: Update goblin and object. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D45046
22543ec3f22067412e37f5bcbd0f7cc113a3def5: Bug 1569350 - Added more primitives to our static-analysis from MSVC 2019. r=froydnj
Andi-Bogdan Postelnicu <bpostelnicu@mozilla.com> - Thu, 05 Sep 2019 12:57:18 +0000 - rev 491908
Push 94594 by aklotz@mozilla.com at Thu, 05 Sep 2019 17:53:11 +0000
Bug 1569350 - Added more primitives to our static-analysis from MSVC 2019. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44827
4b142ed27f93e3e7d772a4f748897af7840225c7: Bug 1578647 - Add RemoveElementAt/RemoveElementsAt overloads accepting const_iterator. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Sep 2019 16:39:29 +0000 - rev 491829
Push 94533 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 08:32:09 +0000
Bug 1578647 - Add RemoveElementAt/RemoveElementsAt overloads accepting const_iterator. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44674
57036eb8f9785bd8a4454a294e7622d0b0f0ab47: Bug 1578649 - Make ArrayIterator<Element&, ArrayType> convertible to ArrayIterator<const Element&, ArrayType>. r=froydnj
Simon Giesecke <sgiesecke@mozilla.com> - Wed, 04 Sep 2019 18:48:05 +0000 - rev 491828
Push 94533 by ccoroiu@mozilla.com at Thu, 05 Sep 2019 08:32:09 +0000
Bug 1578649 - Make ArrayIterator<Element&, ArrayType> convertible to ArrayIterator<const Element&, ArrayType>. r=froydnj This matches the requirement imposed by the Container concept that its iterator type should be convertible to its const_iterator type. Differential Revision: https://phabricator.services.mozilla.com/D44673
66c5c577e5f339543483d963869942b14076310c: Bug 1577872 - Bump MinGW version for updater fix r=froydnj
Tom Ritter <tom@mozilla.com> - Tue, 03 Sep 2019 20:45:55 +0000 - rev 491629
Push 94416 by tritter@mozilla.com at Wed, 04 Sep 2019 02:49:47 +0000
Bug 1577872 - Bump MinGW version for updater fix r=froydnj This picks up 0a1d495478d8ed1a94fc77b9dbb428b7e0372588 needed by Tor for the updater. Differential Revision: https://phabricator.services.mozilla.com/D44535
fe25291a6919fda43493b21746564283ad1fa775: Bug 1577700 - Add a function for obtaining a Span of char from a Span of uint8_t. r=froydnj
Henri Sivonen <hsivonen@hsivonen.fi> - Fri, 30 Aug 2019 13:16:19 +0000 - rev 491032
Push 94189 by hsivonen@mozilla.com at Sat, 31 Aug 2019 11:08:10 +0000
Bug 1577700 - Add a function for obtaining a Span of char from a Span of uint8_t. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D44124
87d437ca92a92161ad2d3dba4c4947ab16ca1ec4: Bug 1577528 - Remove hardcoded clang version in ccov mozconfigs r=froydnj
David Major <dmajor@mozilla.com> - Fri, 30 Aug 2019 13:46:11 +0000 - rev 490866
Push 94098 by dmajor@mozilla.com at Fri, 30 Aug 2019 14:03:51 +0000
Bug 1577528 - Remove hardcoded clang version in ccov mozconfigs r=froydnj So that we don't have to keep bumping them by hand with every compiler upgrade. This pattern was taken from the other uses of https://searchfox.org/mozilla-central/search?q=CLANG_LIB_DIR&case=true Differential Revision: https://phabricator.services.mozilla.com/D43990
3e2987e01215fb9ce600074886866766da1444dd: Bug 1577263: Use memcmp for nsID::Equals. r=froydnj
Kris Maglione <maglione.k@gmail.com> - Wed, 28 Aug 2019 19:08:44 +0000 - rev 490477
Push 93881 by maglione.k@gmail.com at Wed, 28 Aug 2019 19:40:11 +0000
Bug 1577263: Use memcmp for nsID::Equals. r=froydnj Compilers have gotten a lot better since the last time we tried this, and the generated SIMD code for the inlined memcmp is more efficient than our manual comparison operations. Differential Revision: https://phabricator.services.mozilla.com/D43802
4d29b7c90a5fbcea87dd5d990504dd1bb1cd8d90: Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
Barret Rennie <barret@brennie.ca> - Wed, 28 Aug 2019 18:55:31 +0000 - rev 490472
Push 93879 by brennie@mozilla.com at Wed, 28 Aug 2019 19:34:24 +0000
Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer As part of the ongoing effort to port the nsIWebProgress events from RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need to (de)serialize the nsITransportSecurityInfo instance across the IPC layer. The existing code was calling `NS_SerializeToString` which has the overhead of (a) allocating a buffer and also performing base64 encoding/decoding. This patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`, `nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params directly onto and off of the IPC message so that we don't go through the overhead of allocating and encoding/decoding an additional buffer. This (de)serialization will address the performance issues present in the current implementation. As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM interface, since the existing serialization code was assuming it was, there is only one implementation, and it is in C++. Differential Revision: https://phabricator.services.mozilla.com/D35090
f3741f2b33822b4242cba5d4c8d6823d16ada7b5: Bug 1572880 - Package dist-toolchains from a specific directory. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Wed, 28 Aug 2019 18:34:29 +0000 - rev 490463
Push 93871 by cmanchester@mozilla.com at Wed, 28 Aug 2019 18:35:26 +0000
Bug 1572880 - Package dist-toolchains from a specific directory. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43696
1d8bb18fa74ffc16d4726a1b312d38d967cfe445: Bug 1577049 - Provide sccache and dist-toolchains during bootstrap on Windows. r=froydnj
Chris Manchester <cmanchester@mozilla.com> - Wed, 28 Aug 2019 18:31:23 +0000 - rev 490462
Push 93870 by cmanchester@mozilla.com at Wed, 28 Aug 2019 18:32:09 +0000
Bug 1577049 - Provide sccache and dist-toolchains during bootstrap on Windows. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43700
cecb17bd8c03f033498be5dfb3ee4fc966b38e96: Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer
Barret Rennie <barret@brennie.ca> - Wed, 28 Aug 2019 18:00:16 +0000 - rev 490458
Push 93869 by brennie@mozilla.com at Wed, 28 Aug 2019 18:31:37 +0000
Bug 1510569 - Implement serializers for nsITransportSecurityInfo, nsIX509Cert, and nsIX509CertList r=froydnj,keeler,mayhemer As part of the ongoing effort to port the nsIWebProgress events from RemoteWebProgress / WebProgressChild to BrowserParent / BrowserChild, we need to (de)serialize the nsITransportSecurityInfo instance across the IPC layer. The existing code was calling `NS_SerializeToString` which has the overhead of (a) allocating a buffer and also performing base64 encoding/decoding. This patch adds `IPC::ParamTraits` implementations for `nsITransportSecurityInfo`, `nsIX509Certificate`, and `nsIX509CertList` that (de)serializes the params directly onto and off of the IPC message so that we don't go through the overhead of allocating and encoding/decoding an additional buffer. This (de)serialization will address the performance issues present in the current implementation. As a side effect, I also make nsITransportSecurityInfo a builtinclass XPCOM interface, since the existing serialization code was assuming it was, there is only one implementation, and it is in C++. Differential Revision: https://phabricator.services.mozilla.com/D35090
d72f6bb552f38a54c6df3b1d48e28849da0ce189: Bug 1577051 - Fix an implicit-conversion-changes-value warning with new-enough clang by explicitly converting. r=froydnj
Jeff Walden <jwalden@mit.edu> - Wed, 28 Aug 2019 16:35:22 +0000 - rev 490456
Push 93867 by jwalden@mit.edu at Wed, 28 Aug 2019 18:26:55 +0000
Bug 1577051 - Fix an implicit-conversion-changes-value warning with new-enough clang by explicitly converting. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43701
ac1b574350a7a224c04280cad6bde1ccbaf881b3: Bug 1576922 - Don't build JS fuzz-tests when JS shell is disabled. r=froydnj
Christian Holler <choller@mozilla.com> - Tue, 27 Aug 2019 14:56:50 +0000 - rev 490059
Push 93735 by choller@mozilla.com at Tue, 27 Aug 2019 14:59:32 +0000
Bug 1576922 - Don't build JS fuzz-tests when JS shell is disabled. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D43615
8f0efa5789d0152cdac168adf2d936bc11f68230: Bug 1575566 - stop using the directory service when creating anonymous temporary files, r=froydnj
Gijs Kruitbosch <gijskruitbosch@gmail.com> - Fri, 23 Aug 2019 14:00:27 +0000 - rev 489598
Push 93469 by gijskruitbosch@gmail.com at Fri, 23 Aug 2019 14:08:55 +0000
Bug 1575566 - stop using the directory service when creating anonymous temporary files, r=froydnj Note that this code asserts it gets run in the parent process, so we can be sure that we never want the content process sandbox-accessible dir or similar (though tbf, that seems odd given we have DOM machinery to proxy from the child to here... but that's what happens today). This will start using the actual temp dir even in the case of e.g. xpcshell, which normally dependency-injects a different (also temp) dir and reuses it as the profile as well as temp dir ( https://searchfox.org/mozilla-central/rev/03853a6e87c4a9405fce1de49e5d03b9e7a7a274/testing/xpcshell/head.js#1207-1226 ) if and only if anything calls do_get_profile . I think this is likely OK... but if not, we'll have to come up with a more complicated solution... Differential Revision: https://phabricator.services.mozilla.com/D42950
916ba68d0a7faa70a1b7f7a7ea400ecd87f2bcb5: Bug 1575484 - Don't LTO gkrust-gtest. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 11:14:14 +0000 - rev 489544
Push 93425 by mh@glandium.org at Fri, 23 Aug 2019 04:22:17 +0000
Bug 1575484 - Don't LTO gkrust-gtest. r=froydnj We don't actually care that much about LTO'ing the rust parts of libxul for gtests, and not LTO'ing it would save multiple minutes of build time on automation. Differential Revision: https://phabricator.services.mozilla.com/D42812
4dfe4abe05d8b9c7c692c7187df7435674a6d8b7: Bug 1575783 - Fix bug 1551639 after bug 1573566. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 22 Aug 2019 14:23:05 +0000 - rev 489512
Push 93401 by mh@glandium.org at Thu, 22 Aug 2019 21:42:49 +0000
Bug 1575783 - Fix bug 1551639 after bug 1573566. r=froydnj Bug 1573566 moved libxul in a subdirectory, which means the list of files it links are now relative to that directory, rather than the directory where buildid.cpp is. So the dependencies for buildid.cpp need to account for that. Differential Revision: https://phabricator.services.mozilla.com/D43032
4451580bbd3b63d5b56fcb5d8b005b4de7820f50: Bug 1575804 - Don't decode the result from check_cmd_output. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Thu, 22 Aug 2019 17:02:39 +0000 - rev 489475
Push 93367 by nfroyd@mozilla.com at Thu, 22 Aug 2019 17:18:26 +0000
Bug 1575804 - Don't decode the result from check_cmd_output. r=froydnj Bug 1575135 changed check_cmd_output to return unicode strings, but a couple places were already trying to do their own decoding, which now can fail. Remove those. Interesting the decoding was previously broken on Windows, this actually fixes it (the output of hg config is not actually utf-8 on Windows). Differential Revision: https://phabricator.services.mozilla.com/D43044
8a68c8e08c02b82b390f25d296057e017a1c6159: Bug 1560700 - Change how the rust target is derived from the build system target. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 23:22:24 +0000 - rev 489333
Push 93273 by mh@glandium.org at Wed, 21 Aug 2019 23:23:03 +0000
Bug 1560700 - Change how the rust target is derived from the build system target. r=froydnj There are a few problems with the strategy currently used to find the rust target. For example, we don't find a target for arm freebsd, and we pick the wrong target for armel linux. Both are related to how things currently work when multiple targets have the same (cpu, endianness, os). So, to derive the rust target, we now use a more fine-grained approach. Differential Revision: https://phabricator.services.mozilla.com/D41481
51bf6a97396d96ddb82fa91c2cf9bd9f5bc9ae06: Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 12:25:42 +0000 - rev 489318
Push 93262 by mh@glandium.org at Wed, 21 Aug 2019 22:30:17 +0000
Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D42765
4b29e32f7290482d792c5499d810ebe94d3ef748: Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 12:25:21 +0000 - rev 489316
Push 93260 by mh@glandium.org at Wed, 21 Aug 2019 22:17:46 +0000
Bug 1575415 - Always register the nsApplicationChooser component in Gtk builds. r=froydnj Bug 1278282 removed Gtk2 support, so MOZ_WIDGET_TOOLKIT is always "gtk3" for Gtk builds, and never "gtk", which makes the current check never match. Differential Revision: https://phabricator.services.mozilla.com/D42761
6a60ae5d95820320ce11f156799acdaf0299904e: Bug 1435498 - Change how Make depend files are included. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 12:27:49 +0000 - rev 489312
Push 93256 by mh@glandium.org at Wed, 21 Aug 2019 22:06:25 +0000
Bug 1435498 - Change how Make depend files are included. r=froydnj Make depend files related to object files are only really useful when the corresponding build targets are being processed. OTOH, when they are included too broadly, when the build recurses in the same directory for different targets (e.g. target-objects, target, host-objects and/or host), it is possible for one of them to start creating depend files that the others would end up reading, and those reads might be incomplete, possibly leading to build failures because Make think it's malformed. So, we only include the object files's depend files in when Make is explicitly treating a target that will build objects. Differential Revision: https://phabricator.services.mozilla.com/D42766
025bf16416a74f97f93b76884be32419cd03b40c: Bug 1575471 - Move `make check` from mozharness to moz-automation.mk. r=froydnj
Mike Hommey <mh+mozilla@glandium.org> - Wed, 21 Aug 2019 12:31:30 +0000 - rev 489303
Push 93251 by mh@glandium.org at Wed, 21 Aug 2019 21:44:14 +0000
Bug 1575471 - Move `make check` from mozharness to moz-automation.mk. r=froydnj Currently, we have no real visibility on the time spent after the build finished, despite the fact that a large chunk is actually happening via make check (although thankfully more and more of it is moving out to separate tasks). Also, the mozharness machinery for make check dates from when we were running in buildbot and takes care of turning builds orange instead of red in case of failure, etc. which doesn't do anything useful anymore. Differential Revision: https://phabricator.services.mozilla.com/D42806
2908769da8be5226a299fb0eee2c6f6b937593f2: Bug 1562684 - PR_GetLibraryFilePathname is returning absolute paths in MacOS Catalina r=froydnj
Haik Aftandilian <haftandilian@mozilla.com> - Wed, 21 Aug 2019 12:32:09 +0000 - rev 489298
Push 93247 by haftandilian@mozilla.com at Wed, 21 Aug 2019 20:59:47 +0000
Bug 1562684 - PR_GetLibraryFilePathname is returning absolute paths in MacOS Catalina r=froydnj Instead of using symlinks, copy .dylib files to the ${OBJDIR}/dist/Nightly{Debug}.app/Contents/MacOS dir for local builds. Differential Revision: https://phabricator.services.mozilla.com/D41926