searching for reviewer(francois)
f412108e7d77f62d7eea2461e7e76e007356fa7b: Bug 1501974 - Add keyed telemetry to know the download protection remote lookup result . r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 17 Jan 2019 20:39:53 +0000 - rev 454376
Push 76329 by dlee@mozilla.com at Thu, 17 Jan 2019 22:10:15 +0000
Bug 1501974 - Add keyed telemetry to know the download protection remote lookup result . r=francois Add APPLICATION_REPUTATION_SERVER_VERDICT_2 telemetry with file extension as the key. This can give us an idea about the current detecion rate for archived files. Differential Revision: https://phabricator.services.mozilla.com/D13249
5b1c8bfb5cd2f23306f5e6cdbc811789631a50bc: Bug 1504774 - Fix url-classifier worker thread is not aborted while shutting down. r=francois
dlee <dlee@mozilla.com> - Wed, 19 Dec 2018 10:03:19 +0000 - rev 451313
Push 74987 by dlee@mozilla.com at Wed, 19 Dec 2018 14:31:06 +0000
Bug 1504774 - Fix url-classifier worker thread is not aborted while shutting down. r=francois In Bug 1453038, |mUpdateInterrupted| is set in Classifer::Close() which is called by PreShutdown to abort an ongoing update. That doesn't handle all the cases. The SafeBrowsing update involves two threads, worker thread, and update thread. Update thread takes care of most of the update work, when it finishes its task, it posts a task back to the worker thread to apply the updated database and also do some cleanup stuff. Then the update is complete. The fix in Bug 1453038 doesn't abort an update if the woker thread is doing the job. This is because the |mUpdateInterrupted| flag is set in the worker thread. The PreShutdown event which eventually sets the flag has to wait until the worker thread's current task is done. In this patch: 1. Check nsUrlClassifierDBService::ShutdownHasStarted() to abort shutdown. This is set by main thread so both worker thread and update thread can be interrupted now. 2. mIsClosed is now replaced by the mUpdateInterrupted. The semantics of mUpdateInterrupted is now changed to abort update for any internal APIs which should cause an update to abort. 3. Remove |mUpdateInterrupted| and |ShutdownHasStarted()| checks and unify with |ShouldAbort()| Differential Revision: https://phabricator.services.mozilla.com/D12229
c466f72acdec9998b647307d582e52bb46454ab6: Bug 1505931 - Tests for tracking annotation lists vs tracking protection lists, r=francois
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 13:04:20 +0100 - rev 449142
Push 74158 by aciure@mozilla.com at Sun, 02 Dec 2018 09:54:43 +0000
Bug 1505931 - Tests for tracking annotation lists vs tracking protection lists, r=francois
fe5c160d056e25d10c63e2c9200e2a9e0a3db596: Bug 1505931 - URL-Classifier should consider all the prefs, r=francois
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 13:04:20 +0100 - rev 449141
Push 74158 by aciure@mozilla.com at Sun, 02 Dec 2018 09:54:43 +0000
Bug 1505931 - URL-Classifier should consider all the prefs, r=francois
f94594ae2fc11fb937adcb27b098b5f19b773fd1: Bug 1505931 - Channel-Classifier should not skip annotation when TP is enabled, r=francois
Andrea Marchesini <amarchesini@mozilla.com> - Sat, 01 Dec 2018 13:04:20 +0100 - rev 449140
Push 74158 by aciure@mozilla.com at Sun, 02 Dec 2018 09:54:43 +0000
Bug 1505931 - Channel-Classifier should not skip annotation when TP is enabled, r=francois
dc40390fd43656344b774aa2ba05caa2ebfa14ab: Bug 1500360 - P2. Use reason in download protection testcases. r=francois
dlee <dlee@mozilla.com> - Wed, 28 Nov 2018 14:07:43 +0000 - rev 448513
Push 73887 by dlee@mozilla.com at Wed, 28 Nov 2018 14:09:30 +0000
Bug 1500360 - P2. Use reason in download protection testcases. r=francois Add "Reason" checks in the testcase because it provides more fine-grained check. In this patch, I also refactor the testcase by move telemetry stuff into head_download_manager.js so it could easily used by different testcases. Differential Revision: https://phabricator.services.mozilla.com/D10953
db270ae8003b5eaac4658768af0b5f63369a942a: Bug 1500360 - P1. Add telemetry to record the reason download protection allow or block the download. r=francois
dlee <dlee@mozilla.com> - Wed, 28 Nov 2018 14:07:03 +0000 - rev 448512
Push 73887 by dlee@mozilla.com at Wed, 28 Nov 2018 14:09:30 +0000
Bug 1500360 - P1. Add telemetry to record the reason download protection allow or block the download. r=francois In this patch, we added a telemetry to record different reasons that why download protection service decides to allow or block this download. The |verdict| and |shouldBlock| parameters are moved inside PendingLookup::OnComplete and now we used |Reason| in the query reputation code path instead Use enumerated Telemetry because it is easier to add more reasons in the future. Differential Revision: https://phabricator.services.mozilla.com/D10952
e3a074ae3f0c18a5329c23099c5169f135885852: Bug 1508044 - Part 4: Make nsChannelClassifier use nsContentUtils::IsThirdPartyWindowOrChannel() in order to avoid having duplicated logic r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 00:46:50 +0000 - rev 448152
Push 73734 by eakhgari@mozilla.com at Tue, 27 Nov 2018 03:07:32 +0000
Bug 1508044 - Part 4: Make nsChannelClassifier use nsContentUtils::IsThirdPartyWindowOrChannel() in order to avoid having duplicated logic r=francois Depends on D12853 Differential Revision: https://phabricator.services.mozilla.com/D12854
691286d50c87eb419c121c88836a67a8227e611b: Bug 1508044 - Part 3: Ensure that the third-party checks performed on channels in nsContentUtils::IsThirdPartyWindowOrChannel() follow the same logic as those performed in nsChannelClassifier r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 00:43:20 +0000 - rev 448151
Push 73734 by eakhgari@mozilla.com at Tue, 27 Nov 2018 03:07:32 +0000
Bug 1508044 - Part 3: Ensure that the third-party checks performed on channels in nsContentUtils::IsThirdPartyWindowOrChannel() follow the same logic as those performed in nsChannelClassifier r=francois Depends on D12852 Differential Revision: https://phabricator.services.mozilla.com/D12853
5452c9164d46e49aa8ee6cd3444bb0f8cc7cc121: Bug 1508044 - Part 2: Check the return values of mozIThirdPartyUtil::IsThirdPartyFoo() in nsContentUtils::IsThirdPartyWindowOrChannel() r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 27 Nov 2018 00:38:52 +0000 - rev 448150
Push 73734 by eakhgari@mozilla.com at Tue, 27 Nov 2018 03:07:32 +0000
Bug 1508044 - Part 2: Check the return values of mozIThirdPartyUtil::IsThirdPartyFoo() in nsContentUtils::IsThirdPartyWindowOrChannel() r=francois Differential Revision: https://phabricator.services.mozilla.com/D12852
d4db66eb83f9bae1b88fa3a900ea8159f25b41be: Bug 1508044 - Check the return values of mozIThirdPartyUtil::IsThirdPartyFoo() in IsThirdParty() inside nsChannelClassifier.cpp r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Sat, 24 Nov 2018 00:49:03 +0000 - rev 447914
Push 73631 by eakhgari@mozilla.com at Sat, 24 Nov 2018 02:48:39 +0000
Bug 1508044 - Check the return values of mozIThirdPartyUtil::IsThirdPartyFoo() in IsThirdParty() inside nsChannelClassifier.cpp r=francois Differential Revision: https://phabricator.services.mozilla.com/D12784
b7e40bdc132e6b0dbddc7e0a8fde8e3c0a04b957: Bug 1397546 - Allow Application Reputation lookups when the blacklist/whitelist is missing. r=francois
Dimi Lee <dlee@mozilla.com> - Wed, 21 Nov 2018 19:43:06 +0000 - rev 447684
Push 73518 by dlee@mozilla.com at Thu, 22 Nov 2018 09:03:03 +0000
Bug 1397546 - Allow Application Reputation lookups when the blacklist/whitelist is missing. r=francois Before landing this patch, download protection doesn't trigger a remote lookup when blocklist or allowlist is empty. After landing this patch, download protection triggers a remote lookup regardless if blocklist or allowlist is empty. This is safer default behavior in download protection. Differential Revision: https://phabricator.services.mozilla.com/D11621
306c9aaac8cd1395a17788385cc10997d46b8f2d: Bug 1506947 - Part 1: Add a pref for site-specific workarounds for blocking cookies from trackers; r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 14 Nov 2018 01:29:51 -0500 - rev 447460
Push 73435 by btara@mozilla.com at Wed, 21 Nov 2018 09:49:27 +0000
Bug 1506947 - Part 1: Add a pref for site-specific workarounds for blocking cookies from trackers; r=francois Differential Revision: https://phabricator.services.mozilla.com/D11979
9a3984fec4a4d30d260d6298619f1b127ee008e0: Bug 1503560 - [1.2] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois
Eugen Sawin <esawin@mozilla.com> - Fri, 09 Nov 2018 16:54:37 +0100 - rev 445974
Push 72842 by csabou@mozilla.com at Tue, 13 Nov 2018 04:31:20 +0000
Bug 1503560 - [1.2] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois
c9bd800631be838f0f9f99f31ff6b58ef5f407f5: Bug 1503560 - [1.1] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois
Eugen Sawin <esawin@mozilla.com> - Fri, 09 Nov 2018 16:54:37 +0100 - rev 445579
Push 72771 by shindli@mozilla.com at Sat, 10 Nov 2018 21:41:24 +0000
Bug 1503560 - [1.1] Override tracking protection pref on GeckoView to re-enable blocklist updates. r=francois
cc07fe73ddcead18a7c3f92ce4bd3d5346cfd65c: bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois
Dana Keeler <dkeeler@mozilla.com> - Tue, 06 Nov 2018 22:55:33 +0000 - rev 444763
Push 72475 by dkeeler@mozilla.com at Tue, 06 Nov 2018 23:03:42 +0000
bug 1501889 - add the ability to report binary transparency verification failures from the updater r=rstrong,francois This patch adds the ability for the updater to report binary transparency verification failures without affecting the outcome of the update in progress. Differential Revision: https://phabricator.services.mozilla.com/D9846
2e3543bff9f3c00eadc4c2366bbc6a95dd43f6b4: Bug 1501801 - Add query string to URI that test SafeBrowsing. r=francois
dlee <dlee@mozilla.com> - Tue, 06 Nov 2018 13:52:24 +0000 - rev 444646
Push 72424 by dlee@mozilla.com at Tue, 06 Nov 2018 13:56:28 +0000
Bug 1501801 - Add query string to URI that test SafeBrowsing. r=francois The SafeBrowsing related testcases in NavigationDelegateTest.kt first tests loading bad URI and then tests loading the URI again with |blockMalware| disabled. When the testcase loads a bad URI with |blockMalware| disabled, the load succeed and the HTTP response of the URI is stored in HTTP cache. The next time we run the same test, the load is read from the cache without going through url-classifier hence the load is not blocked. Add query string to the URI to avoid bypassing url-classifier check. Differential Revision: https://phabricator.services.mozilla.com/D10886
56bb430315885b97469a28aef13c2f48bc6fc276: Bug 1503697 - Record trackers being loaded on a site in the content blocking log; r=baku,francois
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 31 Oct 2018 18:52:37 -0400 - rev 444605
Push 72404 by rgurzau@mozilla.com at Tue, 06 Nov 2018 10:03:25 +0000
Bug 1503697 - Record trackers being loaded on a site in the content blocking log; r=baku,francois Differential Revision: https://phabricator.services.mozilla.com/D10439
1b9757b74504927b9169ca1796d016e69a9be835: Bug 1277496 - use nsHttp::Origin instead of literal cstring r=francois
Junior Hsu <juhsu@mozilla.com> - Mon, 05 Nov 2018 21:40:36 +0000 - rev 444532
Push 72387 by nbeleuzu@mozilla.com at Tue, 06 Nov 2018 01:20:55 +0000
Bug 1277496 - use nsHttp::Origin instead of literal cstring r=francois Differential Revision: https://phabricator.services.mozilla.com/D10752
10d5db1fc33fa0ef81202e9a6fdd1771a85c1af9: Bug 1462499 - changed priority of harmful. r=francois
matthias <matthias@kammueller.eu> - Mon, 24 Sep 2018 15:51:50 +0000 - rev 444503
Push 72370 by fmarier@mozilla.com at Mon, 05 Nov 2018 21:52:03 +0000
Bug 1462499 - changed priority of harmful. r=francois Differential Revision: https://phabricator.services.mozilla.com/D6570
67d9714a50e58b48719e48928894cc5c95456316: Bug 1503568 - extend accessibility panel telemetry probes until Firefox 70. r=francois, data-review=francois
Yura Zenevich <yura.zenevich@gmail.com> - Wed, 31 Oct 2018 21:04:38 +0000 - rev 443948
Push 72156 by yura.zenevich@gmail.com at Thu, 01 Nov 2018 14:25:51 +0000
Bug 1503568 - extend accessibility panel telemetry probes until Firefox 70. r=francois, data-review=francois MozReview-Commit-ID: GObzIWTl1Ri Differential Revision: https://phabricator.services.mozilla.com/D10370
dd75cefee794aaaef19940f717f69fc70f9a3ff0: Bug 1050329 - part 1 - Re-start transactions on totally busted h2 sessions. r=francois,dragana
Nicholas Hurley <hurley@mozilla.com> - Thu, 25 Oct 2018 20:46:24 +0000 - rev 443040
Push 71772 by hurley@mozilla.com at Thu, 25 Oct 2018 20:54:01 +0000
Bug 1050329 - part 1 - Re-start transactions on totally busted h2 sessions. r=francois,dragana Previously, we would just let these fail. But, when a peer claims to speak h2 via ALPN, and then plainly doesn't speak h2 (by not doing the opening handshake properly), we should re-try any transactions dispatched to that session using http/1.1 only. No use in giving the user a horrible experience. We will also collect telemetry on how often we have sessions where this happens, so we can see how big of a problem this is (and thus if we need to do any kind of outreach). Depends on D8432 Differential Revision: https://phabricator.services.mozilla.com/D8433
7e0e03b9169e2c5046e8bd8b947edccf04fbdc1b: Bug 1501657 - Move early betas to use the strict list for the default cookie restrictions r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 24 Oct 2018 18:52:04 +0000 - rev 442891
Push 71693 by eakhgari@mozilla.com at Wed, 24 Oct 2018 22:55:26 +0000
Bug 1501657 - Move early betas to use the strict list for the default cookie restrictions r=francois Differential Revision: https://phabricator.services.mozilla.com/D9657
f7fe04d00e18682a760b3fcb458c2be801e59184: Bug 1487559 - add new telemetry probe for the mime type causing suspension for back pressure r=francois,valentin
Junior Hsu <juhsu@mozilla.com> - Wed, 24 Oct 2018 16:26:19 +0000 - rev 442857
Push 71680 by ncsoregi@mozilla.com at Wed, 24 Oct 2018 21:24:50 +0000
Bug 1487559 - add new telemetry probe for the mime type causing suspension for back pressure r=francois,valentin Differential Revision: https://phabricator.services.mozilla.com/D4729
3f5f46ca8ca0df1c34a9077fd4b479e291997a3f: Bug 1501461 - Use the strict list for default cookie restrictions in Nightly r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 23 Oct 2018 23:02:18 +0000 - rev 442663
Push 71592 by eakhgari@mozilla.com at Tue, 23 Oct 2018 23:07:59 +0000
Bug 1501461 - Use the strict list for default cookie restrictions in Nightly r=francois Differential Revision: https://phabricator.services.mozilla.com/D9594
b872e2aa271c063a31219ee93455541198b99cbc: Bug 1190020 - P2. Testcase to ensure digest is not truncated. r=francois
Dimi Lee <dlee@mozilla.com> - Tue, 23 Oct 2018 20:03:44 +0000 - rev 442623
Push 71582 by dlee@mozilla.com at Tue, 23 Oct 2018 21:35:31 +0000
Bug 1190020 - P2. Testcase to ensure digest is not truncated. r=francois This test will trigger a remote lookup. Verify the protocol buffer sent by download protection service matches the hard-coded protocol buffer. This protcol buffer contains following information: 1. source URI 2. referrer URI 3. redirect UiRI 4. sha256 hash with '\x00' in the middle of the data 5. suggested file name Differential Revision: https://phabricator.services.mozilla.com/D9138
ffb7704a1bf8af534306427755e18cfe4db8da62: Bug 1190020 - P1. Fix truncated hashes in application reputation remote lookups. r=francois
Dimi <dimi@liweiguode-MacBook-Pro.local> - Fri, 19 Oct 2018 09:17:08 +0000 - rev 442622
Push 71582 by dlee@mozilla.com at Tue, 23 Oct 2018 21:35:31 +0000
Bug 1190020 - P1. Fix truncated hashes in application reputation remote lookups. r=francois When we set the remote lookup digest, we get char* from nsCString and convert char* to std::string without specifying size. If SHA256 data contains '00', std::string treats it as a null terminated sting so we have a shorter SHA256. This patch fixes this issue by specifying the size when converting char* to std::string. Differential Revision: https://phabricator.services.mozilla.com/D8830
3e62b3523fb5f8af9996e88ff5e15d5edd4742fd: Bug 1500208 - Disable FastBlock, hide FastBlock UI everywhere. r=francois,Ehsan
Johann Hofmann <jhofmann@mozilla.com> - Fri, 19 Oct 2018 06:53:32 +0000 - rev 442078
Push 71328 by jhofmann@mozilla.com at Fri, 19 Oct 2018 07:03:39 +0000
Bug 1500208 - Disable FastBlock, hide FastBlock UI everywhere. r=francois,Ehsan Differential Revision: https://phabricator.services.mozilla.com/D9140
6e0c72599e0b63fe2e4957184c40520c2fa6339c: Bug 1356427 - P3. Add a testcase to test download protection will skip checking whitelist for non-binary files. r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 18 Oct 2018 14:39:41 +0000 - rev 441929
Push 71268 by dlee@mozilla.com at Thu, 18 Oct 2018 14:45:29 +0000
Bug 1356427 - P3. Add a testcase to test download protection will skip checking whitelist for non-binary files. r=francois Add xpcshell test test_whitelisted_non_binary_source. In this test, we pass a whitelisted sourceURI and a non-binary file extension. Check the returned result is NO_LIST to ensure no whitelisted local db query has been made. This patch also adds binary filename for testcases require whitelist query being made. Differential Revision: https://phabricator.services.mozilla.com/D8702
c3e09876ab13c1b27355f2d0680b0e34a40bbcf4: Bug 1356427 - P2. Only check binary files against the Application Reputation whitelist, r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 18 Oct 2018 14:40:56 +0000 - rev 441928
Push 71268 by dlee@mozilla.com at Thu, 18 Oct 2018 14:45:29 +0000
Bug 1356427 - P2. Only check binary files against the Application Reputation whitelist, r=francois We already skip checking whitelist for redirects and referrer in Bug 1434741 So this patch just does the following to remove redundant whitelist check: 1. Skip checking whitelist for the final URL if it is not a binary 2. Skip parsing certificate for non-binary files After applying this patch, whitelist will only be used for final URL of binary file and certificates of binary file Differential Revision: https://phabricator.services.mozilla.com/D8687
ced08ec47ace994bf5c5f1e4052052e7cb9bab30: Bug 1356427 - P1. Remove redundant code from PendingLookup::LookupNext. r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 18 Oct 2018 14:38:14 +0000 - rev 441927
Push 71268 by dlee@mozilla.com at Thu, 18 Oct 2018 14:45:29 +0000
Bug 1356427 - P1. Remove redundant code from PendingLookup::LookupNext. r=francois When mBlocklistCount is set, we will call PendingLookup::OnComplete() to block this download. The |if(mBlocklistCount)| in PendingLookup::LookupNext will never be true. mBlocklistCount member variable is also useless after removing the code. But I think we can keep it since we have mAllowlistCount and we might also need it in the future. Differential Revision: https://phabricator.services.mozilla.com/D8682
b6780702981d863bfd913ca404d5b5209b952066: Bug 1499149 - Better telemetry for alt-svc headers seen in the wild. r=francois,valentin
Nicholas Hurley <hurley@mozilla.com> - Wed, 17 Oct 2018 18:14:56 +0000 - rev 441740
Push 71189 by hurley@mozilla.com at Wed, 17 Oct 2018 18:20:35 +0000
Bug 1499149 - Better telemetry for alt-svc headers seen in the wild. r=francois,valentin Right now, we have no idea how often an origin may offer us multiple alt-svc options. As we are considering racing multiple alt-svc connections (if they're available), it would be good to know how often we actually have (or would have, were we to store them) multiple options available. It would also be good to know how often an origin may change the target of its alt-svc mapping (even if there is only one target), as changes in target may make it useful to store/race multiple targets, as well. Differential Revision: https://phabricator.services.mozilla.com/D8878
762299961b3f7d84e36def128fbb5bb4c5403f5e: Bug 1499549 - Ensure that we only check the corresponding Content Blocking exception list when testing whether a top-level document is on the Content Blocking allow list r=francois
Ehsan Akhgari <ehsan@mozilla.com> - Wed, 17 Oct 2018 17:06:00 +0000 - rev 441722
Push 71178 by eakhgari@mozilla.com at Wed, 17 Oct 2018 17:07:35 +0000
Bug 1499549 - Ensure that we only check the corresponding Content Blocking exception list when testing whether a top-level document is on the Content Blocking allow list r=francois Differential Revision: https://phabricator.services.mozilla.com/D8927
37d138b1e58b9c45ee3baef530bb133597b14eb3: Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois
Dimi Lee <dlee@mozilla.com> - Tue, 16 Oct 2018 10:36:01 +0000 - rev 441450
Push 71060 by dlee@mozilla.com at Tue, 16 Oct 2018 10:38:01 +0000
Bug 1439450 - Ignore has_first_value() check in ProtocolParser. r=francois Sometimes the protocol buffer data (RiceEncodingData) sent by Google's Safe Browsing server has the following properties: 1. |has_first_value| is false 2. |num_entries| > 0 In this case, we can still parse the data and apply partial update correctly by assuming that the first value is equal to 0. Differential Revision: https://phabricator.services.mozilla.com/D6393
75ed7377db616cdeb922a9ebf28e17aa7f97b492: Bug 1495285 - Introduce TrackingDummyChannel to annotate channels before being intercepted by ServiceWorkers, r=francois, r=mayhemer, f=asuth
Andrea Marchesini <amarchesini@mozilla.com> - Fri, 12 Oct 2018 11:40:36 +0200 - rev 440911
Push 70879 by ncsoregi@mozilla.com at Fri, 12 Oct 2018 16:59:18 +0000
Bug 1495285 - Introduce TrackingDummyChannel to annotate channels before being intercepted by ServiceWorkers, r=francois, r=mayhemer, f=asuth
bb8d7ab5e55fea5d8a962b59364d35eb955d8d94: Bug 1489493 - Add a scalar telemetry for the size of content windows r=Gijs,francois
Tim Huang <tihuang@mozilla.com> - Thu, 11 Oct 2018 19:46:25 +0000 - rev 440876
Push 70857 by tihuang@mozilla.com at Fri, 12 Oct 2018 12:53:25 +0000
Bug 1489493 - Add a scalar telemetry for the size of content windows r=Gijs,francois In order to improve the window rounding fingerprinting protection, we want to find a proper rounding value which provides good protection as well as good user experience. With a better understanding of the content window size, we can answer the question that which strategy we should use for improving this protection: should we use certain fixed window sizes or still stick with the current rounding strategy? Also, if we still stick with the current approach, then what is the best rounding value which allows users to utilize their window as much as possible without losing too much protection. Differential Revision: https://phabricator.services.mozilla.com/D7236
7ed2dd1cac5420a828628b08a39ddbeacf458af1: Bug 1477064 - Collect PLUGIN_DRAWING_MODEL histogram data on release. r=francois, data=francois
Jim Mathies <jmathies@mozilla.com> - Fri, 28 Sep 2018 09:51:39 -0500 - rev 438838
Push 70123 by aiakab@mozilla.com at Sat, 29 Sep 2018 04:17:57 +0000
Bug 1477064 - Collect PLUGIN_DRAWING_MODEL histogram data on release. r=francois, data=francois
12f48815d40f0133f86b774469abf455546b9ed7: Bug 1479898 - P3. Increase the application reputation remote lookup timeout to 15sec. r=francois
Dimi Lee <dlee@mozilla.com> - Fri, 07 Sep 2018 18:28:35 +0000 - rev 437464
Push 69669 by dlee@mozilla.com at Thu, 20 Sep 2018 14:07:44 +0000
Bug 1479898 - P3. Increase the application reputation remote lookup timeout to 15sec. r=francois 3% download protection remote lookup failures are from timeout. Increase the timeout from 10sec to 15sec to see if this help. Differential Revision: https://phabricator.services.mozilla.com/D5265
4d2c3be4d7256e678be7189dedddaeaea7126f8f: Bug 1479898 - P2. Add telemetry to know the response time of download protection remote lookup. r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 20 Sep 2018 14:04:31 +0000 - rev 437463
Push 69669 by dlee@mozilla.com at Thu, 20 Sep 2018 14:07:44 +0000
Bug 1479898 - P2. Add telemetry to know the response time of download protection remote lookup. r=francois Telemetry::APPLICATION_REPUTATION_REMOTE_LOOKUP_RESPONSE_TIME can be used to give us an idea how could we adjust the timeout accordingly. Differential Revision: https://phabricator.services.mozilla.com/D5264
5d39eab1a17c0d19916cabd1ab7cc8ac8eeec2ac: Bug 1479898 - P1. Only set false to APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT when it is not timeout. r=francois
Dimi Lee <dlee@mozilla.com> - Thu, 20 Sep 2018 00:18:12 +0000 - rev 437462
Push 69669 by dlee@mozilla.com at Thu, 20 Sep 2018 14:07:44 +0000
Bug 1479898 - P1. Only set false to APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT when it is not timeout. r=francois Right now no matter it is timeout or not, we will always add the counter to the false case of APPLICATION_REPUTATION_REMOTE_LOOKUP_TIMEOUT. We should only set the counter(false) when it is not timeout. Differential Revision: https://phabricator.services.mozilla.com/D5263
1d9298b20b46aacf52eb69bf024c188b354fb00e: Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois
Dimi Lee <dlee@mozilla.com> - Tue, 18 Sep 2018 14:29:20 +0000 - rev 436979
Push 69492 by dlee@mozilla.com at Tue, 18 Sep 2018 14:32:11 +0000
Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois A directory-based file copy without checkpoint to abort may take lots of time to finish. This cause an issue that if firefox is shutting down and try to close an ongoing update thread, main-thread may be blocked for a long time. This patch adds a wrapper for copying an entire directory, within this wrapper, we use file-based copy and add checkpoints to let update thread has a chance to abort. Differential Revision: https://phabricator.services.mozilla.com/D3414
6f6886c89554f9face1b3e8a7090cc0e85800375: Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois
Dimi Lee <dlee@mozilla.com> - Fri, 14 Sep 2018 15:33:24 +0000 - rev 436379
Push 69307 by dlee@mozilla.com at Fri, 14 Sep 2018 15:34:34 +0000
Bug 1481819 - Make Safe Browsing directory-based file copy interruptible. r=francois A directory-based file copy without checkpoint to abort may take lots of time to finish. This cause an issue that if firefox is shutting down and try to close an ongoing update thread, main-thread may be blocked for a long time. This patch adds a wrapper for copying an entire directory, within this wrapper, we use file-based copy and add checkpoints to let update thread has a chance to abort. Differential Revision: https://phabricator.services.mozilla.com/D3414
84fbf23400d5d4de19df9254039fc80a73557b28: Bug 1490074 - add Telemetry to know how long the AudioContext become audible since it was created. r=padenot,francois
alwu <alwu@mozilla.com> - Thu, 13 Sep 2018 16:58:05 +0000 - rev 436175
Push 69238 by alwu@mozilla.com at Thu, 13 Sep 2018 16:59:14 +0000
Bug 1490074 - add Telemetry to know how long the AudioContext become audible since it was created. r=padenot,francois I want to know how many sites will have that scenario which is to create AudioContext in advance and produces sound later (ex. when user click the page or certain button). I will add a Telemetry probe to meausure how long the AudioContext would become audible since it was created. Differential Revision: https://phabricator.services.mozilla.com/D5453
1082415e378fab5986f9c6b90d638d8a03690574: Bug 1480443 - Part 3: Disable FastBlock in URL Classifier tests. r=dimi,francois
Cosmin Sabou <csabou@mozilla.com> - Sat, 01 Sep 2018 11:06:32 +0300 - rev 434405
Push 68644 by csabou@mozilla.com at Sat, 01 Sep 2018 08:10:03 +0000
Bug 1480443 - Part 3: Disable FastBlock in URL Classifier tests. r=dimi,francois
5e01b236471ee1b3b8210d1fbc7f90e9bb11c767: Bug 1480443 - Enable FastBlock by default on Nightly. r=francois
Cosmin Sabou <csabou@mozilla.com> - Sat, 01 Sep 2018 11:01:06 +0300 - rev 434403
Push 68644 by csabou@mozilla.com at Sat, 01 Sep 2018 08:10:03 +0000
Bug 1480443 - Enable FastBlock by default on Nightly. r=francois
953cfa4e5a85bc7126c1500eb537765e9b785aaa: Bug 1476118 - Add .oxt to the list of executable extensions in download protection. r=francois
Dimi Lee <dlee@mozilla.com> - Fri, 31 Aug 2018 14:57:24 +0000 - rev 434236
Push 68602 by dlee@mozilla.com at Fri, 31 Aug 2018 14:58:35 +0000
Bug 1476118 - Add .oxt to the list of executable extensions in download protection. r=francois Differential Revision: https://phabricator.services.mozilla.com/D4341
5092029dac4e2fd24b985c0a438437879e333b07: Bug 1476967 - Allow the adding of tracking-protection entries via prefs, r=francois
Andrea Marchesini <amarchesini@mozilla.com> - Mon, 27 Aug 2018 21:01:14 +0200 - rev 433603
Push 68417 by aciure@mozilla.com at Tue, 28 Aug 2018 22:07:31 +0000
Bug 1476967 - Allow the adding of tracking-protection entries via prefs, r=francois
6f25c83bb4d5e17285cb4f4f62d71e2cabe20801: Bug 1485342 - Avoid isdigit() and isxdigit() in URL classifier. r=francois
Henri Sivonen <hsivonen@hsivonen.fi> - Mon, 27 Aug 2018 15:55:13 +0000 - rev 433530
Push 68372 by hsivonen@mozilla.com at Tue, 28 Aug 2018 13:58:40 +0000
Bug 1485342 - Avoid isdigit() and isxdigit() in URL classifier. r=francois MozReview-Commit-ID: IvadP10PFEZ Differential Revision: https://phabricator.services.mozilla.com/D4312
34ee6df8cb72825769ac3fc3cb946fea424e0f9e: Bug 1484024: add Telemetry histogram for DTLS ciphers on RTCPeerConnection r=francois,mt
Nils Ohlmeier [:drno] <drno@ohlmeier.org> - Fri, 24 Aug 2018 22:49:42 +0000 - rev 433419
Push 68304 by cbrindusan@mozilla.com at Sat, 25 Aug 2018 07:20:31 +0000
Bug 1484024: add Telemetry histogram for DTLS ciphers on RTCPeerConnection r=francois,mt Added a Telemetry histrogram which collects which DTLS cipher got negotiated when a RTCPeerConnection connected. Differential Revision: https://phabricator.services.mozilla.com/D3551
258c008b1915370a62269b2d2b29d36ba888c09f: Bug 1485743 - Don't show the Content Blocking tour in private windows. r=francois
Johann Hofmann <jhofmann@mozilla.com> - Fri, 24 Aug 2018 19:46:07 +0000 - rev 433329
Push 68287 by jhofmann@mozilla.com at Fri, 24 Aug 2018 19:48:05 +0000
Bug 1485743 - Don't show the Content Blocking tour in private windows. r=francois Differential Revision: https://phabricator.services.mozilla.com/D4197