searching for reviewer(dholbert)
2fc6cac0eb1ddb49295ec1ce5fc820ce98f7d72a: Bug 1776079 - Delete SharedFlexData() only if there's no flex container's next-in-flow. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 24 Jun 2022 05:00:07 +0000 - rev 622011
Push 165168 by aethanyc@gmail.com at Fri, 24 Jun 2022 05:16:56 +0000
Bug 1776079 - Delete SharedFlexData() only if there's no flex container's next-in-flow. r=dholbert nsGridContainerFrame has the same logic. https://searchfox.org/mozilla-central/rev/6d0ba065e3d41822337c708c8c0aca334ddd9218/layout/generic/nsGridContainerFrame.cpp#9116 Differential Revision: https://phabricator.services.mozilla.com/D150157
8b1fbea4db866fc9c47574331d0a31908bc1f5ca: Bug 1776157 - Don't force chrome frames to be opaque. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 24 Jun 2022 00:04:18 +0000 - rev 621991
Push 165161 by ealvarez@mozilla.com at Fri, 24 Jun 2022 00:06:42 +0000
Bug 1776157 - Don't force chrome frames to be opaque. r=dholbert It causes unnecessary flashes in some cases, like the sidebar which intentionally loads about:blank. Differential Revision: https://phabricator.services.mozilla.com/D150096
3744e46f9a8c11b18f8d499612e81d862063646f: Bug 1772919 - Port osfile.jsm usage to IOUtils in layout/tools/ r=dholbert
Barret Rennie <barret@brennie.ca> - Thu, 23 Jun 2022 23:40:49 +0000 - rev 621985
Push 165155 by brennie@mozilla.com at Thu, 23 Jun 2022 23:43:10 +0000
Bug 1772919 - Port osfile.jsm usage to IOUtils in layout/tools/ r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149300
66ceb4d27b5a2758e40e2d2e22368ca33437282d: Bug 1774904 - Remove SetTruncated in ReflowInput.h. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 18 Jun 2022 18:40:02 +0000 - rev 621399
Push 164824 by aethanyc@gmail.com at Sat, 18 Jun 2022 18:42:25 +0000
Bug 1774904 - Remove SetTruncated in ReflowInput.h. r=dholbert SetTruncated was moved into nsReflowStatus in Bug 775624 Part 10a https://hg.mozilla.org/mozilla-central/rev/3ea22e82b7a1b493f2f31e52ed310e6288fd9a91, so let's remove the unused declarations in ReflowInput.h. Differential Revision: https://phabricator.services.mozilla.com/D149686
77dca66144deaff050008026c46ad56df2e88838: Bug 1774791 - Fix grid shorthand parsing to not incorrectly ignore the last token in one case. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Jun 2022 20:50:37 +0000 - rev 621357
Push 164811 by ealvarez@mozilla.com at Fri, 17 Jun 2022 20:53:02 +0000
Bug 1774791 - Fix grid shorthand parsing to not incorrectly ignore the last token in one case. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149666
a5403b470ac63e7aec732fecd58d53015d261446: Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 17 Jun 2022 10:42:52 +0000 - rev 621296
Push 164772 by ealvarez@mozilla.com at Fri, 17 Jun 2022 10:45:14 +0000
Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149226
d70914c7f1f3a1fe7cbbee8ff237075d06958f79: Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 16 Jun 2022 08:08:08 +0000 - rev 621103
Push 164664 by ealvarez@mozilla.com at Thu, 16 Jun 2022 08:10:31 +0000
Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149226
d6ee5bae41b8d871d65ad69d76c7598bf94ac06e: Bug 1773121 - If an element is relatively positioned, report overflow area that is a union of relative and static position. r=dholbert
David Shin <dshin@mozilla.com> - Wed, 15 Jun 2022 17:39:05 +0000 - rev 621018
Push 164614 by dshin@mozilla.com at Wed, 15 Jun 2022 17:41:31 +0000
Bug 1773121 - If an element is relatively positioned, report overflow area that is a union of relative and static position. r=dholbert With this, a relatively positioned element e.g. being offset to the left should not decrease the scrollport size. For this, overflow area calculation for relatively positioned elements must behave like `nsIFrame::GetActualAndNormalOverflowAreasRelativeToParent`. We aren't using the function directly since it's meant to be called post-reflow, and we want to report it correctly during reflow in the first place. Differential Revision: https://phabricator.services.mozilla.com/D149156
3924451180463ed6ce84b587ceafc537b7f953a3: Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Jun 2022 09:56:34 +0000 - rev 620970
Push 164583 by ealvarez@mozilla.com at Wed, 15 Jun 2022 10:02:33 +0000
Bug 1730763 - Fix containment and body-to-root propagation. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149226
26d5615493b5b36c20751becbfeb82678bd42a72: Bug 1773795 - Spoof window/windowtext colors in content. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Jun 2022 09:53:13 +0000 - rev 620968
Push 164581 by ealvarez@mozilla.com at Wed, 15 Jun 2022 09:56:24 +0000
Bug 1773795 - Spoof window/windowtext colors in content. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149143
dccdf42f473c0f2ad18d15c6f61aa35ae5d1d2a8: Bug 1774016 - Document non-native theme color-spoofing better. r=dholbert,layout-reviewers
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 15 Jun 2022 09:40:42 +0000 - rev 620962
Push 164578 by ealvarez@mozilla.com at Wed, 15 Jun 2022 09:48:11 +0000
Bug 1774016 - Document non-native theme color-spoofing better. r=dholbert,layout-reviewers Differential Revision: https://phabricator.services.mozilla.com/D149142
466d30a90a012ce9d5a620c6d61b9176be8d8641: Bug 1739561 - Honor break-inside:avoid on flex containers. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 15 Jun 2022 00:55:54 +0000 - rev 620938
Push 164560 by aethanyc@gmail.com at Wed, 15 Jun 2022 00:58:21 +0000
Bug 1739561 - Honor break-inside:avoid on flex containers. r=dholbert Note this patch only prevents "break-inside:avoid" flex containers from being broken when they are not at the top of their current page/column. When they are at the top of their current page/column, this patch fails to help since `nsContainerFrame::ShouldAvoidBreakInside()` returns `false` via the `mIsTopOfPage` check. This is essentially bug 793686. Differential Revision: https://phabricator.services.mozilla.com/D149318
a66dd81f49eb5daf0ddce058b48aad34f0fd8b06: Bug 1774307 - Remove unused member of nsPageBreakFrame and make some variables in nsPageBreakFrame::Reflow const r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 15 Jun 2022 00:34:02 +0000 - rev 620936
Push 164558 by emcdonough@mozilla.com at Wed, 15 Jun 2022 00:36:26 +0000
Bug 1774307 - Remove unused member of nsPageBreakFrame and make some variables in nsPageBreakFrame::Reflow const r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D149330
ec7e694733a0dc3d956b6a3ea3a323fc1d41264c: Bug 1769161 Part 4 - Add test for unwriteable margin scaling with page-size mismatches r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Fri, 10 Jun 2022 19:37:23 +0000 - rev 620571
Push 164372 by emcdonough@mozilla.com at Fri, 10 Jun 2022 20:08:45 +0000
Bug 1769161 Part 4 - Add test for unwriteable margin scaling with page-size mismatches r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146603
e2514be196694c0e4cced2a8aeeea3bdd103f342: Bug 1769161 Part 3 - Scale unwriteable margins and user-specified margins by the page-size scaling factor r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Fri, 10 Jun 2022 19:37:22 +0000 - rev 620570
Push 164372 by emcdonough@mozilla.com at Fri, 10 Jun 2022 20:08:45 +0000
Bug 1769161 Part 3 - Scale unwriteable margins and user-specified margins by the page-size scaling factor r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D148207
8ef0b13d48e096cb4fad3a325984bccac08bb0b5: Bug 1769161 Part 2 - Rename and document margin and sizing calculation for nsPageFrame margins. r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Fri, 10 Jun 2022 19:37:22 +0000 - rev 620569
Push 164372 by emcdonough@mozilla.com at Fri, 10 Jun 2022 20:08:45 +0000
Bug 1769161 Part 2 - Rename and document margin and sizing calculation for nsPageFrame margins. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146602
75371351ca9697480f4c9edbd45f075cbceb0dbb: Bug 1769161 Part 1 - Refactor scaling factor due to page-size for nsPageFrame to be in its own function. r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Fri, 10 Jun 2022 19:37:22 +0000 - rev 620568
Push 164372 by emcdonough@mozilla.com at Fri, 10 Jun 2022 20:08:45 +0000
Bug 1769161 Part 1 - Refactor scaling factor due to page-size for nsPageFrame to be in its own function. r=dholbert This includes two versions of the function, one which takes an already-computed page size to avoid computing this multiple times for a caller, and the other which computes this value itself for convenience. Differential Revision: https://phabricator.services.mozilla.com/D146601
17ea9064fd5387664cb92191167066b4d51d7bf3: Bug 1767364: Return an incomplete reflow status for tables if they have next-in-flow with previously unflowed children. r=dholbert
David Shin <dshin@mozilla.com> - Fri, 10 Jun 2022 09:14:00 +0000 - rev 620501
Push 164328 by archaeopteryx@coole-files.de at Fri, 10 Jun 2022 09:16:24 +0000
Bug 1767364: Return an incomplete reflow status for tables if they have next-in-flow with previously unflowed children. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D148140
d376decbcba074454478a6c9e7adb9bf6bc08bbc: Bug 1769161 Part 4 - Add test for unwriteable margin scaling with page-size mismatches r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 09 Jun 2022 23:51:08 +0000 - rev 620399
Push 164314 by emcdonough@mozilla.com at Thu, 09 Jun 2022 23:53:47 +0000
Bug 1769161 Part 4 - Add test for unwriteable margin scaling with page-size mismatches r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146603
a821b6bc4a1806c248c1698d569de56ec16fbb42: Bug 1769161 Part 3 - Scale unwriteable margins and user-specified margins by the page-size scaling factor r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 09 Jun 2022 23:51:07 +0000 - rev 620398
Push 164314 by emcdonough@mozilla.com at Thu, 09 Jun 2022 23:53:47 +0000
Bug 1769161 Part 3 - Scale unwriteable margins and user-specified margins by the page-size scaling factor r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D148207
4ffac65dfc17aaa700a80f6c0344dc9f7fab23de: Bug 1769161 Part 2 - Rename and document margin and sizing calculation for nsPageFrame margins. r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 09 Jun 2022 23:51:07 +0000 - rev 620397
Push 164314 by emcdonough@mozilla.com at Thu, 09 Jun 2022 23:53:47 +0000
Bug 1769161 Part 2 - Rename and document margin and sizing calculation for nsPageFrame margins. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146602
616392cd1725de27782a0fa518175fdf5e8c3c55: Bug 1769161 Part 1 - Refactor scaling factor due to page-size for nsPageFrame to be in its own function. r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 09 Jun 2022 23:51:07 +0000 - rev 620396
Push 164314 by emcdonough@mozilla.com at Thu, 09 Jun 2022 23:53:47 +0000
Bug 1769161 Part 1 - Refactor scaling factor due to page-size for nsPageFrame to be in its own function. r=dholbert This includes two versions of the function, one which takes an already-computed page size to avoid computing this multiple times for a caller, and the other which computes this value itself for convenience. Differential Revision: https://phabricator.services.mozilla.com/D146601
cce9e3eb2cc12d967e433a0ba0a139b2b501c85a: Bug 1768650 - Turn off gfx.webrender.svg-images for a test. r=dholbert
Nicolas Silva <nsilva@mozilla.com> - Tue, 07 Jun 2022 13:45:20 +0000 - rev 619974
Push 164099 by nsilva@mozilla.com at Tue, 07 Jun 2022 13:47:45 +0000
Bug 1768650 - Turn off gfx.webrender.svg-images for a test. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D147051
71a175e4aba967debb24ef35c16baf9304f07cf6: Bug 1772690 - Add a debug-only ComputedStyle::DumpMatchedRules(). r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 05 Jun 2022 21:21:10 +0000 - rev 619741
Push 164010 by ealvarez@mozilla.com at Sun, 05 Jun 2022 21:23:34 +0000
Bug 1772690 - Add a debug-only ComputedStyle::DumpMatchedRules(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D148336
98cccf9d2932d8db8c8d33789efcf0cc0dd7b5ca: Bug 1771796 - Remove -moz-scrollbar-thumb-proportional. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 Jun 2022 11:58:18 +0000 - rev 619559
Push 163891 by ealvarez@mozilla.com at Thu, 02 Jun 2022 12:01:09 +0000
Bug 1771796 - Remove -moz-scrollbar-thumb-proportional. r=dholbert It unconditionally matches on all platforms, so it's not returning any useful information. Depends on D147689 Differential Revision: https://phabricator.services.mozilla.com/D147690
065de83e89d3e907f491e348b42dc9ac0750a798: Bug 1771796 - Remove useless rule. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 Jun 2022 10:50:32 +0000 - rev 619556
Push 163888 by ealvarez@mozilla.com at Thu, 02 Jun 2022 10:52:53 +0000
Bug 1771796 - Remove useless rule. r=dholbert This stylesheet uses the html namespace by default so it never matches. Plus scrollbars already have cursor: default via scrollbars.css Depends on D147687 Differential Revision: https://phabricator.services.mozilla.com/D147688
34ce731d96656c388ae858a04f97294a460696ba: Bug 1772103 - Use plain object for lazy getter in layout/tools/reftest/. r=dholbert
Tooru Fujisawa <arai_a@mac.com> - Wed, 01 Jun 2022 21:29:14 +0000 - rev 619495
Push 163849 by arai_a@mac.com at Wed, 01 Jun 2022 21:48:08 +0000
Bug 1772103 - Use plain object for lazy getter in layout/tools/reftest/. r=dholbert Depends on D147891 Differential Revision: https://phabricator.services.mozilla.com/D147892
3128c6548f3d67102b3ba095a9a207bd29f0f17d: No bug - Fix configure help command. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Jun 2022 19:37:37 +0000 - rev 619481
Push 163843 by ealvarez@mozilla.com at Wed, 01 Jun 2022 20:14:38 +0000
No bug - Fix configure help command. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D148064
3fe2a93fd2c0b0ced8bed9eea914a6419036d459: Bug 1771564 - Don't re-resolve styles of elements without frames (but with styles). r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 01 Jun 2022 12:03:43 +0000 - rev 619424
Push 163801 by ealvarez@mozilla.com at Wed, 01 Jun 2022 12:12:20 +0000
Bug 1771564 - Don't re-resolve styles of elements without frames (but with styles). r=dholbert I noticed this while debugging some underinvalidation with the patch on bug 1381071. This doesn't change behavior effectively, since the style frame should always have the element's style, but it allows us to not need style resolution for: * display: contents * Any element before we flush layout for the first time. So it seems worth it. Differential Revision: https://phabricator.services.mozilla.com/D147556
0618183b0fbe7d73e79f71c5c68a2d9aa86961f2: Bug 1771564 - Constify ComputedStyle usage in nsComputedDOMStyle. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 28 May 2022 01:04:24 +0000 - rev 619125
Push 163643 by ealvarez@mozilla.com at Sat, 28 May 2022 01:06:51 +0000
Bug 1771564 - Constify ComputedStyle usage in nsComputedDOMStyle. r=dholbert None of the consumer need to mutate styles, and this saves some ugly const_casting on the next patch. Doesn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D147555
a83a2d453bde15272e8d9bbea7f034f7d3b74f12: Bug 1770993 - Remove the `.strip()` from the MOZCONFIG_SUGGESTION_TEMPLATE so that a newline is output before the shell prompt r=dholbert
ahochheiden <ahochheiden@mozilla.com> - Fri, 27 May 2022 18:48:56 +0000 - rev 619111
Push 163629 by ahochheiden@mozilla.com at Fri, 27 May 2022 19:57:17 +0000
Bug 1770993 - Remove the `.strip()` from the MOZCONFIG_SUGGESTION_TEMPLATE so that a newline is output before the shell prompt r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D147485
d7d6fc84ab537baac25e32e4b3bfecf52e54b3b9: Bug 1770991 - Added an extra space and removed `.strip()` so that the spacing between the `./mach bootstrap` choice prompt and the choice input matches textual conventions r=dholbert
ahochheiden <ahochheiden@mozilla.com> - Fri, 27 May 2022 18:48:23 +0000 - rev 619110
Push 163628 by ahochheiden@mozilla.com at Fri, 27 May 2022 19:56:43 +0000
Bug 1770991 - Added an extra space and removed `.strip()` so that the spacing between the `./mach bootstrap` choice prompt and the choice input matches textual conventions r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D147486
1b641947f6a73004e93957f629274ce1b48bc1a5: Bug 1769580 - Add a terrible hack to avoid Netgear's <select>s from overflowing port numbers. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 27 May 2022 09:37:57 +0000 - rev 619081
Push 163605 by ealvarez@mozilla.com at Fri, 27 May 2022 09:40:25 +0000
Bug 1769580 - Add a terrible hack to avoid Netgear's <select>s from overflowing port numbers. r=dholbert Not a fan of this, I'd rather not do this... A potential, maybe less hacky alternative, would be to resolve text-indent by truncating rather than rounding. That would effectively round down the 0.01px to zero. Differential Revision: https://phabricator.services.mozilla.com/D146993
cf63538fe82cdf094b73fd5ce7c9ef7f6bfdf9e8: Bug 1472602 - Sticky/relative position fixes in nsTableWrapperFrame. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 May 2022 23:40:42 +0000 - rev 618595
Push 163358 by ealvarez@mozilla.com at Mon, 23 May 2022 23:43:08 +0000
Bug 1472602 - Sticky/relative position fixes in nsTableWrapperFrame. r=dholbert Captions should be relatively-positioned (other browsers support this as well). This ensures we correctly save their normal positions and thus that the sticky scroll container knows how to reposition them correctly. Avoid registering inner table frames with the sticky scroll container to make the assertion sound in cases of sticky-positioned tables. Differential Revision: https://phabricator.services.mozilla.com/D147092
e3377838e213e7b22905d26101a19f610cc42ea6: Bug 1472602 - Sticky/relative position fixes in nsTableWrapperFrame. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 May 2022 20:43:15 +0000 - rev 618582
Push 163349 by ealvarez@mozilla.com at Mon, 23 May 2022 20:45:37 +0000
Bug 1472602 - Sticky/relative position fixes in nsTableWrapperFrame. r=dholbert Captions should be relatively-positioned (other browsers support this as well). This ensures we correctly save their normal positions and thus that the sticky scroll container knows how to reposition them correctly. Avoid registering inner table frames with the sticky scroll container to make the assertion sound in cases of sticky-positioned tables. Differential Revision: https://phabricator.services.mozilla.com/D147092
13e019e7feadb07e3cef67334eb33a45e4191429: Bug 1770532 - Ensure options in listbox selects are not stacking contexts by default. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 21 May 2022 17:23:24 +0000 - rev 618445
Push 163285 by ealvarez@mozilla.com at Sat, 21 May 2022 17:25:56 +0000
Bug 1770532 - Ensure options in listbox selects are not stacking contexts by default. r=dholbert We could have a different property or something but this seems reasonable as well probably. Differential Revision: https://phabricator.services.mozilla.com/D146994
fb1114750895c4657e99dfcc0c2fea74f0094be3: Bug 1739260 - Force to advance next band if we cannot get a suitable float available space. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Thu, 19 May 2022 20:48:42 +0000 - rev 618297
Push 163176 by bchiou@mozilla.com at Thu, 19 May 2022 20:51:10 +0000
Bug 1739260 - Force to advance next band if we cannot get a suitable float available space. r=dholbert Without this patch, the test case, floats-aspect-ratio-001.html, hangs because: 1. The initial float available space is correct, and its size is 100px x 50px. And the bfc element is "width: auto; height: auto; aspect-ratio: 1/1;". So its width and height depend on the available space. 2. And then, we try to get a new available area based on the height of the bfc element (note: its size is 100px x 100px). However, we get an invalid zero-width float available area which is occupied by the element with float:right (i.e. the pink one), in the first band, and the size of float available space is 0px x 100px. This makes the size of bfc element become 0px x 0px when checking `FloatAvoidingBlockFitsInAvailSpace()`. So it always fits in this float available area. And because we get two different available areas in the first band (i.e. same `aBCoord`), so we don't go into the break condition, and contine to get a new `childReflowInput`, and then go to the next iteration. 3. In the 2nd loop, we try to get a new float available space by the height of the bfc element (note: its size is 0px x 0px now because the width of current float available space is 0px), so the new float available space is 100px x 0px, and the bfc element fits in this available area, but again, we have two different available areas, so we still don't go into the break condition. Instead, we use the new available area to compute the childReflowInput for the next iteration, and now the size of the bfc element becomes 100px x 100px. And then we go back to the state of (2). 4. So the bfc element enters a resize oscillation due to the invalid float available space together with the aspect-ratio and auto sizes (i.e. "widht: auto; height: auto;") I think. And the invalid float available space also let |AvailableSpaceShrunk()| be unexpected because we hit an assertion: "ASSERTION: available space should not grow on the start side and shrink on the end side". A possible way is to make sure we get a suitable float available area for `floatAvoidingBlock`, so this can avoid the bfc element from entering a resize oscillation. Note: 1. bfc means block-formatting-context, and its variable name is `floatAvoidingBlock` in nsBlockFrame.cpp. 2. We don't need to check zere or positive inline size for the float available space because `AvailableSpaceShrunk()` should make sure we leave the loop properly. See https://phabricator.services.mozilla.com/D145524#4766290 for the the example when the inline size is exactly zero. Besides, we also fix contain-inline-size-bfc-floats-001.html with this patch. Differential Revision: https://phabricator.services.mozilla.com/D145524
48cc65bbdef5bb45c4b67336485d7b92c36e78d0: Bug 1770058 - Skip end-of-time-001-crash.html & end-of-time-002-crash.html on Linux opt for making the wpt crashtest job unstable in CI. r=dholbert
Ryan VanderMeulen <ryanvm@gmail.com> - Thu, 19 May 2022 01:25:45 +0000 - rev 618200
Push 163105 by rvandermeulen@mozilla.com at Thu, 19 May 2022 01:36:18 +0000
Bug 1770058 - Skip end-of-time-001-crash.html & end-of-time-002-crash.html on Linux opt for making the wpt crashtest job unstable in CI. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146749
2609e3d8e65dca44723bfe764e29845fae96dc6d: Bug 1765668: Fix border offset when the `writing-mode` of an abspos element's containing block differs from its absolute containing block. r=dholbert
David Shin <dshin@mozilla.com> - Wed, 18 May 2022 18:09:33 +0000 - rev 618163
Push 163084 by dholbert@mozilla.com at Wed, 18 May 2022 18:11:59 +0000
Bug 1765668: Fix border offset when the `writing-mode` of an abspos element's containing block differs from its absolute containing block. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D146095
1d85507a55983f1f556ae556e22be83424c840f2: Bug 1762497 - Allow authors to style unfocused option listboxes. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 13 May 2022 10:11:06 +0000 - rev 617194
Push 162783 by ealvarez@mozilla.com at Fri, 13 May 2022 10:13:32 +0000
Bug 1762497 - Allow authors to style unfocused option listboxes. r=dholbert See bug comments for reasoning. While this could cause undistinguishable selected options when the select doesn't have focus, the idea is that this shouldn't be happening often. This matches other browsers. Differential Revision: https://phabricator.services.mozilla.com/D146059
a095433613cc94f2c4bf8da6206b85e21647bc13: Bug 1765093 - patch 1 - Avoid measuring entire textrun in SVGTextFrame's GetBaselinePosition function. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Sat, 07 May 2022 13:11:59 +0000 - rev 616607
Push 162437 by jkew@mozilla.com at Sat, 07 May 2022 13:16:50 +0000
Bug 1765093 - patch 1 - Avoid measuring entire textrun in SVGTextFrame's GetBaselinePosition function. r=dholbert This aims to prevent an O(n^2) performance situation when per-glyph positioning is in use. This reduces the time to load the testcase here from around 70s to 17s in my local build. Still not great, but at least it's less of a disaster. Differential Revision: https://phabricator.services.mozilla.com/D145631
bbc1944120802b67a8726a95a3141203b10d9903: Bug 1765093 - patch 1 - Avoid measuring entire textrun in SVGTextFrame's GetBaselinePosition function. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Fri, 06 May 2022 17:47:22 +0000 - rev 616561
Push 162406 by jkew@mozilla.com at Fri, 06 May 2022 20:02:13 +0000
Bug 1765093 - patch 1 - Avoid measuring entire textrun in SVGTextFrame's GetBaselinePosition function. r=dholbert This aims to prevent an O(n^2) performance situation when per-glyph positioning is in use. This reduces the time to load the testcase here from around 70s to 17s in my local build. Still not great, but at least it's less of a disaster. Differential Revision: https://phabricator.services.mozilla.com/D145631
57d322f6e79538816837e099b7dedcc02514f7f9: Bug 1766885 - Fix a flaky @layer test. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 29 Apr 2022 11:28:18 +0000 - rev 615682
Push 161949 by ealvarez@mozilla.com at Fri, 29 Apr 2022 11:30:41 +0000
Bug 1766885 - Fix a flaky @layer test. r=dholbert @import loads are async per spec, so we need to wait for the style element's load event. Differential Revision: https://phabricator.services.mozilla.com/D144992
62a5f7ce75a94f8957ac16b432766cf20641f9df: Bug 1740366 - Implement paginated fragmentation on page-name boundaries r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 28 Apr 2022 00:03:19 +0000 - rev 615555
Push 161845 by emcdonough@mozilla.com at Thu, 28 Apr 2022 01:03:28 +0000
Bug 1740366 - Implement paginated fragmentation on page-name boundaries r=dholbert This has a TODO about empty page names on previous sibling frames, to match Chrome's behavior of page break coalescing we should be looking to the frame before that sibling and check for page breaks there instead. Differential Revision: https://phabricator.services.mozilla.com/D140423
b6cd39aa0353ab6e08199351fa1b07ccc051e752: Bug 1765654 - Simplify audio/video frame intrinsic sizing, and make audio elements report the correct intrinsic width during layout r=dholbert,emilio
David Shin <dshin@mozilla.com> - Wed, 27 Apr 2022 16:20:05 +0000 - rev 615495
Push 161798 by dholbert@mozilla.com at Wed, 27 Apr 2022 16:22:27 +0000
Bug 1765654 - Simplify audio/video frame intrinsic sizing, and make audio elements report the correct intrinsic width during layout r=dholbert,emilio Fix regression from returning zero intrinsic size for audio elements, which caused the element to be positioned incorrectly in absolutely positioned, orthogonal flow situations. Differential Revision: https://phabricator.services.mozilla.com/D144182
aa9e91285699bf36e245f92810cb0da6d3a72873: Bug 1696560 - Apply transferred min & max sizes for flex base size if main is the inline axis. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Tue, 26 Apr 2022 19:31:25 +0000 - rev 615384
Push 161737 by bchiou@mozilla.com at Tue, 26 Apr 2022 19:34:43 +0000
Bug 1696560 - Apply transferred min & max sizes for flex base size if main is the inline axis. r=dholbert Basically, the transferred min & max sizes shouldn't override the min & max sizing properties, so applying it earlier than these properties should be identical. This just makes the flex base size and main size be more correct at the beginning (and so other adjustments of sizes in flex algorithm can override the transferred min/max sizes), for non-replaced elements. Note: In Chromium code, it clamps the flex items' base size by transferred min & max sizes, but the computation of items' used min & used max sizes doesn't include the transferred min & max sizes. So in this patch, I'm trying to make this patch simple: we let minimum & maximum sizes only taken into account for flex base size and only for non-replaced elements for now. So the behavior should be similar to other browsers. And we may have to update this tentative solution once these spec words get updated. Differential Revision: https://phabricator.services.mozilla.com/D144499
85873d5c79788a3e5fa00fd7bff2abdbaf5a88b5: Bug 1765426 - Use longer timeout for WPT contain-inline-size-replaced.html. r=dholbert
David Shin <dshin@mozilla.com> - Wed, 20 Apr 2022 17:25:57 +0000 - rev 614814
Push 161401 by dholbert@mozilla.com at Wed, 20 Apr 2022 18:22:11 +0000
Bug 1765426 - Use longer timeout for WPT contain-inline-size-replaced.html. r=dholbert With the shorter timeout, and with the chaos mode flag set to 0xfb, this test can surpass the "slow" time threshold, which then is marked as a failure. Differential Revision: https://phabricator.services.mozilla.com/D144177
7985a1fa0789fa8173f92f3a7ff18ec8bb46c8ce: Bug 1764768 - Don't truncate viewport units at computed value time. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 20 Apr 2022 17:22:36 +0000 - rev 614813
Push 161400 by ealvarez@mozilla.com at Wed, 20 Apr 2022 17:59:00 +0000
Bug 1764768 - Don't truncate viewport units at computed value time. r=dholbert Instead, make the behavior consistent across all <length-percentage> values (by truncating instead of rounding). This is the already-existing behavior for calc() and percentages, but with this patch we also apply it to plain length-flavored <length-percentage> values (this is needed to avoid regressing things like bug 989802). Regular <length>s keep rounding, to preserve existing behavior. We can consider changing that in a follow-up if need be. Differential Revision: https://phabricator.services.mozilla.com/D143857
e3fd585c58fa9cbdf22eeee007177f625c5926c9: Bug 1755565 - Implement `contain: inline-size`. r=emilio,dholbert
David Shin <dshin@mozilla.com> - Tue, 19 Apr 2022 17:44:16 +0000 - rev 614633
Push 161301 by dholbert@mozilla.com at Tue, 19 Apr 2022 17:46:39 +0000
Bug 1755565 - Implement `contain: inline-size`. r=emilio,dholbert Differential Revision: https://phabricator.services.mozilla.com/D143501
0c35c52d51a04a104e5c549ebbe67284228714a8: Bug 1764768 - Don't go through app-units-ratio to convert absolute lengths. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 19 Apr 2022 08:39:29 +0000 - rev 614571
Push 161255 by ealvarez@mozilla.com at Tue, 19 Apr 2022 08:41:55 +0000
Bug 1764768 - Don't go through app-units-ratio to convert absolute lengths. r=dholbert This doesn't change behavior on its own, but the current code introduces some minor floating point error which we can avoid, and which would cause failures with the other patch on the bug. Differential Revision: https://phabricator.services.mozilla.com/D143942