searching for reviewer(dholbert)
e6d7a21d588ced500d9d85d9993219e563fcc144: Bug 1566672 - Handle the {ib}-split reframing in multicol subtree properly. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 19 Jul 2019 19:38:05 +0000 - rev 483576
Push 90466 by aethanyc@gmail.com at Fri, 19 Jul 2019 20:31:21 +0000
Bug 1566672 - Handle the {ib}-split reframing in multicol subtree properly. r=dholbert Delete `return false` at the end of the if-statement block that handling the multicol subtree reframing, and let it fall though the bottom of WipeContainingBlock() where there is a complete logic for ib-split reframing. Differential Revision: https://phabricator.services.mozilla.com/D38548
35043a8b9d81b3216fee30fa1ac1c2261a38dcfd: Bug 1567282: renamed text-decoration-width to text-decoration-thickness r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Fri, 19 Jul 2019 16:33:08 +0000 - rev 483527
Push 90441 by dholbert@mozilla.com at Fri, 19 Jul 2019 16:37:47 +0000
Bug 1567282: renamed text-decoration-width to text-decoration-thickness r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38586
d23f502e0e175e51ed71ebd09dc9e3fc38958a7b: Bug 1555142 - Don't assert if we don't find a -webkit-line-clamp ellipsis when searching for one to clear. r=dholbert
Cameron McCormack <cam@mcc.id.au> - Thu, 18 Jul 2019 16:49:38 +0000 - rev 483425
Push 90377 by cmccormack@mozilla.com at Thu, 18 Jul 2019 21:50:01 +0000
Bug 1555142 - Don't assert if we don't find a -webkit-line-clamp ellipsis when searching for one to clear. r=dholbert The line the ellipsis was on may have already been removed. Differential Revision: https://phabricator.services.mozilla.com/D38449
cd8478a8a71439f37190ac74b491d11b748d2fad: Bug 1564555 - Enable some more ESLint rules for layout. r=Standard8,dholbert
RuchikaGosain <ruchikag826@gmail.com> - Thu, 18 Jul 2019 21:00:21 +0000 - rev 483421
Push 90373 by mbanner@mozilla.com at Thu, 18 Jul 2019 21:32:32 +0000
Bug 1564555 - Enable some more ESLint rules for layout. r=Standard8,dholbert Differential Revision: https://phabricator.services.mozilla.com/D38007
4116a7254a4ee7033f38b7126007bd2af678a7b8: Bug 1566945 - Make nsBlockFrame::AddFrames not search for the line box if it is provided. r=dholbert
L. David Baron <dbaron@dbaron.org> - Thu, 18 Jul 2019 05:45:38 +0000 - rev 483284
Push 90288 by dbaron@mozilla.com at Thu, 18 Jul 2019 06:53:20 +0000
Bug 1566945 - Make nsBlockFrame::AddFrames not search for the line box if it is provided. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38392
92d38cae0841f6e632fcd2c588db375281574aa3: Bug 1566945 - Pass line box through to nsBlockFrame::AddFrames. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 17 Jul 2019 23:34:46 +0000 - rev 483283
Push 90288 by dbaron@mozilla.com at Thu, 18 Jul 2019 06:53:20 +0000
Bug 1566945 - Pass line box through to nsBlockFrame::AddFrames. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38391
55569be3dc17ced11053dc40468b4c2eda5da5aa: Bug 1566945 - Pass line box through from nsTextFrame::SetLength. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 17 Jul 2019 23:34:45 +0000 - rev 483282
Push 90288 by dbaron@mozilla.com at Thu, 18 Jul 2019 06:53:20 +0000
Bug 1566945 - Pass line box through from nsTextFrame::SetLength. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38390
bb32f80c5c9df725ec35a3f25be6b708ee44b85f: Bug 1566945 - Add a parameter to nsContainerFrame::InsertFrames for aPrevFrame's line box. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 17 Jul 2019 23:34:45 +0000 - rev 483281
Push 90288 by dbaron@mozilla.com at Thu, 18 Jul 2019 06:53:20 +0000
Bug 1566945 - Add a parameter to nsContainerFrame::InsertFrames for aPrevFrame's line box. r=dholbert For now, always pass null, except when passing it through from one overload to another. Differential Revision: https://phabricator.services.mozilla.com/D38389
66d48a0fef6b7d32eb54f88e9ec99ea930d7803a: Bug 1565136 - Move some reframing logic out of WipeContainingBlock to make it done earlier. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 18 Jul 2019 04:55:03 +0000 - rev 483280
Push 90287 by aethanyc@gmail.com at Thu, 18 Jul 2019 04:59:32 +0000
Bug 1565136 - Move some reframing logic out of WipeContainingBlock to make it done earlier. r=dholbert Also move the duplicate logic for reframing MathML in ContentAppended() and ContentRangeInserted() into WipeInsertionParent(). Differential Revision: https://phabricator.services.mozilla.com/D38417
9a8a7dd2693b9eff165c71439407f7059906cd20: Bug 1543599 - Don't suppress scroll anchoring adjustments when switching display to `none`. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Jul 2019 17:53:20 +0000 - rev 482815
Push 90006 by ealvarez@mozilla.com at Mon, 15 Jul 2019 17:53:49 +0000
Bug 1543599 - Don't suppress scroll anchoring adjustments when switching display to `none`. r=dholbert Since that means that we won't suppress them when switching display back (since we have no frame to pull the old style from). We may want to match Chrome more exactly and don't do this any time `display` changes (which if I'm reading their code correctly is what they do...). But for now I've done the minimal thing and added a test. Differential Revision: https://phabricator.services.mozilla.com/D38094
1af0dca460dd7362116f252a3be4b01c2a1d8b7d: Bug 1554572 - Don't apply scroll anchor adjustments if we're processing an async scroll animation. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Jul 2019 17:48:16 +0000 - rev 482814
Push 90005 by ealvarez@mozilla.com at Mon, 15 Jul 2019 17:48:53 +0000
Bug 1554572 - Don't apply scroll anchor adjustments if we're processing an async scroll animation. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38077
da82282ba536a930d238cf4112246a92f40709ce: Bug 1546027 - Don't apply scroll anchor adjustments if we're restoring our scroll position. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 15 Jul 2019 17:46:11 +0000 - rev 482813
Push 90004 by ealvarez@mozilla.com at Mon, 15 Jul 2019 17:46:44 +0000
Bug 1546027 - Don't apply scroll anchor adjustments if we're restoring our scroll position. r=dholbert Since scroll position restoration is absolute, and we'll lose it as soon as we apply any adjustment or do any other sort of scrolling. Differential Revision: https://phabricator.services.mozilla.com/D37941
05f675735d39d336dc7253e07872d0232c9ced0e: Bug 1351924 - Keep separate flags for whether block-size has changed and whether percentages derived from the block-size have changed, and make better decisions about what needs reflow. r=dholbert
Chris Pearce <cpearce@mozilla.com> - Sun, 14 Jul 2019 01:04:31 +0000 - rev 482739
Push 89943 by dbaron@mozilla.com at Sun, 14 Jul 2019 01:07:25 +0000
Bug 1351924 - Keep separate flags for whether block-size has changed and whether percentages derived from the block-size have changed, and make better decisions about what needs reflow. r=dholbert This reduces a bit of code complexity, fixes bugs where we weren't reflowing enough, and optimizes additional cases that we couldn't optimize in the past. Co-authored-by: Chris Pearce <cpearce@mozilla.com> Co-authored-by: L. David Baron <dbaron@dbaron.org> Differential Revision: https://phabricator.services.mozilla.com/D37610
27bcd63fde995d358ada9d7f19b3920de55f1963: Bug 1351924 - Add reftests for correctness bug fixed by this bug. r=dholbert
L. David Baron <dbaron@dbaron.org> - Sun, 14 Jul 2019 01:04:29 +0000 - rev 482738
Push 89943 by dbaron@mozilla.com at Sun, 14 Jul 2019 01:07:25 +0000
Bug 1351924 - Add reftests for correctness bug fixed by this bug. r=dholbert Co-authored-by: L. David Baron <dbaron@dbaron.org> Co-authored-by: Chris Pearce <cpearce@mozilla.com> Differential Revision: https://phabricator.services.mozilla.com/D37609
aa0016d9f9f827f86bb82d632998b2d5706fe851: Bug 1565690 - When inferring an aspect ratio from an image's width and height attribute, only honor it if we don't have the real image aspect-ratio. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 12 Jul 2019 21:47:49 +0000 - rev 482681
Push 89908 by ealvarez@mozilla.com at Fri, 12 Jul 2019 21:48:30 +0000
Bug 1565690 - When inferring an aspect ratio from an image's width and height attribute, only honor it if we don't have the real image aspect-ratio. r=dholbert Since people like to get wrong attribute values on their images (see the regressions from bug 1547231). Differential Revision: https://phabricator.services.mozilla.com/D37936
f6a326c94c5315fb0ac3c13add2069903f52dafa: Bug 1565274: Remove self inclusion from nsPageSequenceFrame.h r=dholbert
Calixte Denizet <cdenizet@mozilla.com> - Thu, 11 Jul 2019 21:37:27 +0000 - rev 482554
Push 89840 by cdenizet@mozilla.com at Fri, 12 Jul 2019 08:58:04 +0000
Bug 1565274: Remove self inclusion from nsPageSequenceFrame.h r=dholbert nsPageSequenceFrame.h includes itself. Differential Revision: https://phabricator.services.mozilla.com/D37770
5fd8ae2c6cde7eb09c06baa8c60c0ee2bf05d29d: Bug 1565037 Part 5 - Rename aBottomEdgeOfChildren to aBEndEdgeOfChildren in methods' declaration. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jul 2019 18:43:48 +0000 - rev 482521
Push 89816 by aethanyc@gmail.com at Fri, 12 Jul 2019 02:15:07 +0000
Bug 1565037 Part 5 - Rename aBottomEdgeOfChildren to aBEndEdgeOfChildren in methods' declaration. r=dholbert Their definitions already use aBEndEdgeOfChildren. Depends on D37626 Differential Revision: https://phabricator.services.mozilla.com/D37627
94b17463ded6968b747e5b06608fd539a78576f8: Bug 1565037 Part 4 - Rename aContentBSize to aBEndEdgeOfChildren. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jul 2019 18:43:35 +0000 - rev 482520
Push 89816 by aethanyc@gmail.com at Fri, 12 Jul 2019 02:15:07 +0000
Bug 1565037 Part 4 - Rename aContentBSize to aBEndEdgeOfChildren. r=dholbert As described in https://bugzilla.mozilla.org/show_bug.cgi?id=1562122#c5, this precomputed argument is not our children's block-size, but is the block-end edge of children because aState.mBCoord is initialized as our border-padding block-start in BlockReflowInput's constructor. I also delete the sentence "The final block-size that is used in aMetrics will be set ..." because this is the implementation details of this function, and is likely to become inaccurate after considering the block split by column-span. Depends on D37625 Differential Revision: https://phabricator.services.mozilla.com/D37626
e72af5bb7aa3b89d70e25f306ce1bb56b0cd9010: Bug 1565037 Part 3 - Cache our children's reflow status, and use it to guide the morphing into our reflow status. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jul 2019 18:50:14 +0000 - rev 482519
Push 89816 by aethanyc@gmail.com at Fri, 12 Jul 2019 02:15:07 +0000
Bug 1565037 Part 3 - Cache our children's reflow status, and use it to guide the morphing into our reflow status. r=dholbert Because aStatus is also used as an output argument, caching aStatus as our children's reflow status can and make the logic that morphs aStatus to our reflow status easier to follow. And this helps the patch I'm going to add for computing the block-size for column-span split. Depends on D37624 Differential Revision: https://phabricator.services.mozilla.com/D37625
9a3d6bc5a6f9eaeca919d740af1c1f714c7a646d: Bug 1565037 Part 2 - Change aStatus to a reference for ComputeFinalBSize(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jul 2019 18:43:23 +0000 - rev 482518
Push 89816 by aethanyc@gmail.com at Fri, 12 Jul 2019 02:15:07 +0000
Bug 1565037 Part 2 - Change aStatus to a reference for ComputeFinalBSize(). r=dholbert We usually use reference to manipulate nsReflowStatus like in Reflow(). The documentation for aStatus needs edit, and is done in next part. Depends on D37623 Differential Revision: https://phabricator.services.mozilla.com/D37624
310df636a5476c08c643ebe93a3f754a1e5dfc9d: Bug 1565037 Part 1 - Make nsBlockFrame::ComputeFinalBSize() return the final block size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 11 Jul 2019 18:43:14 +0000 - rev 482517
Push 89816 by aethanyc@gmail.com at Fri, 12 Jul 2019 02:15:07 +0000
Bug 1565037 Part 1 - Make nsBlockFrame::ComputeFinalBSize() return the final block size. r=dholbert ComputeFinalBSize() doesn't need to modify the final inline-size, so we don't need to pass the entire LogicalSize into it. Also, aReflowInput.AvailableBSize() is used multiple times. Cache it to shorten some statements. Differential Revision: https://phabricator.services.mozilla.com/D37623
6f6a43855c532d3c6bd7ec2befc5edd6f9fb9e7d: Bug 1289211 - Rename InfallibleTArray to nsTArray in layout/ r=dholbert
Barret Rennie <barret@brennie.ca> - Wed, 10 Jul 2019 03:31:59 +0000 - rev 482233
Push 89644 by brennie@mozilla.com at Wed, 10 Jul 2019 16:35:23 +0000
Bug 1289211 - Rename InfallibleTArray to nsTArray in layout/ r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D36963
5382e671e265de2eeeb4910eb430b7d09b09afde: Bug 1564308 - Always reflow all row groups and rows if we're doing visibility:collapse adjustments. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 10 Jul 2019 06:49:17 +0000 - rev 482177
Push 89625 by dbaron@mozilla.com at Wed, 10 Jul 2019 15:25:19 +0000
Bug 1564308 - Always reflow all row groups and rows if we're doing visibility:collapse adjustments. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D37467
a2f96a3cba12a80167a2e8a4b4b494a05622e2a8: Bug 1564308 - Add reftest. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 10 Jul 2019 06:41:14 +0000 - rev 482176
Push 89625 by dbaron@mozilla.com at Wed, 10 Jul 2019 15:25:19 +0000
Bug 1564308 - Add reftest. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D37466
514565e608cba4d1c309dfd146c8d01746d62651: Bug 1564308 - Always reflow all row groups and rows if we're doing visibility:collapse adjustments. r=dholbert
L. David Baron <dbaron@dbaron.org> - Tue, 09 Jul 2019 23:03:40 +0000 - rev 482035
Push 89554 by dbaron@mozilla.com at Wed, 10 Jul 2019 01:10:01 +0000
Bug 1564308 - Always reflow all row groups and rows if we're doing visibility:collapse adjustments. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D37467
cb68677410a5c802e860eb4e40cad65ee1117750: Bug 1564308 - Add reftest. r=dholbert
L. David Baron <dbaron@dbaron.org> - Tue, 09 Jul 2019 23:02:10 +0000 - rev 482034
Push 89554 by dbaron@mozilla.com at Wed, 10 Jul 2019 01:10:01 +0000
Bug 1564308 - Add reftest. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D37466
ed32865ed7373d3d1fcaf14cdaa572e0eee9c3b9: Bug 1557857: Added reftests for text-underline-offset r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Tue, 09 Jul 2019 17:37:03 +0000 - rev 482027
Push 89548 by dholbert@mozilla.com at Tue, 09 Jul 2019 23:05:09 +0000
Bug 1557857: Added reftests for text-underline-offset r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D35740
3fd103a9fce841cfcc3aa83467024d4250a0f683: Bug 1557857: Added reftests for text-underline-offset r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Mon, 08 Jul 2019 16:07:52 +0000 - rev 481670
Push 89356 by dholbert@mozilla.com at Mon, 08 Jul 2019 16:52:07 +0000
Bug 1557857: Added reftests for text-underline-offset r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D35740
8afe177a67a86be93b95bad67ab89fe51ef2c925: Bug 1563370 - Eliminate GetPrevInFlowVirtual() and GetNextInFlowVirtual(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 03 Jul 2019 21:37:14 +0000 - rev 481212
Push 89159 by aethanyc@gmail.com at Thu, 04 Jul 2019 01:17:31 +0000
Bug 1563370 - Eliminate GetPrevInFlowVirtual() and GetNextInFlowVirtual(). r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D36829
c70683bb3522b4ae05a185242a72cc20504bc93f: Bug 1474771 - Revert all changes from bug 1459937 since they are no longer needed. r=dholbert
L. David Baron <dbaron@dbaron.org> - Mon, 01 Jul 2019 21:58:35 +0000 - rev 481179
Push 89138 by dbaron@mozilla.com at Wed, 03 Jul 2019 19:50:09 +0000
Bug 1474771 - Revert all changes from bug 1459937 since they are no longer needed. r=dholbert (The single line that made them active was commented out in the previous patch.) Differential Revision: https://phabricator.services.mozilla.com/D36425
ae0a517daf9700bcb8c7ac0b035870fb508f2929: Bug 1474771 - Propagate NS_FRAME_IS_DIRTY to descendants when marking as dirty rather than during reflow. r=dholbert
Gerald Squelart <gsquelart@mozilla.com> - Mon, 01 Jul 2019 21:56:43 +0000 - rev 481178
Push 89138 by dbaron@mozilla.com at Wed, 03 Jul 2019 19:50:09 +0000
Bug 1474771 - Propagate NS_FRAME_IS_DIRTY to descendants when marking as dirty rather than during reflow. r=dholbert This simplifies dealing with frames that are pushed/pulled between continuations during reflow, allows us to avoid the complexity of the fix to 1459937, and hopefully fixes some of the regressions from bug 1308876. This disables the changes from bug 1459937 by commenting out a single line in ReparentFrameInternal in nsBlockFrame.cpp, but all the added code will be removed in the following patch. Co-authored-by: Gerald Squelart <gsquelart@mozilla.com> Co-authored-by: L. David Baron <dbaron@dbaron.org> Depends on D36423 Differential Revision: https://phabricator.services.mozilla.com/D36424
4167fd17006cbe7cd9141b225a5d65150764312c: Bug 1561283 - Don't optimize out recascading of children when becoming or stopping being display: contents. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 01 Jul 2019 21:39:47 +0000 - rev 480845
Push 88939 by ealvarez@mozilla.com at Mon, 01 Jul 2019 22:37:41 +0000
Bug 1561283 - Don't optimize out recascading of children when becoming or stopping being display: contents. r=dholbert Since they can change whether descendants get blockified. Differential Revision: https://phabricator.services.mozilla.com/D35818
1c18f35d0163f1ac2b63ecc5c4bd4d7a63dedb02: Bug 1558899: Added web-platform reftests for text-decoration-width r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Mon, 01 Jul 2019 17:21:57 +0000 - rev 480823
Push 88919 by dholbert@mozilla.com at Mon, 01 Jul 2019 17:56:11 +0000
Bug 1558899: Added web-platform reftests for text-decoration-width r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D36270
321be77f2c08bd572a09d03ec37d122f27a1e002: Bug 1562122 Part 4 - Return early in the overflow incomplete case, and add an assertion for the bound of final block size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 28 Jun 2019 21:21:15 +0000 - rev 480636
Push 88813 by aethanyc@gmail.com at Fri, 28 Jun 2019 21:35:11 +0000
Bug 1562122 Part 4 - Return early in the overflow incomplete case, and add an assertion for the bound of final block size. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D36291
a19c5b59a5bef452d78623fb1d95d45352b30526: Bug 1562122 Part 3 - Delete the duplicate logic computing the final block size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 28 Jun 2019 21:21:06 +0000 - rev 480635
Push 88813 by aethanyc@gmail.com at Fri, 28 Jun 2019 21:35:11 +0000
Bug 1562122 Part 3 - Delete the duplicate logic computing the final block size. r=dholbert After the deleted logic ``` aFinalSize.BSize(wm) = std::max(aReflowInput.AvailableBSize(), aContentBSize); ``` aStatus changes to incomplete, so it computes the same thing again. Differential Revision: https://phabricator.services.mozilla.com/D36290
818f4038280dfacc59e30e8c198707d9e6b9f586: Bug 1562122 Part 2 - Replace effectiveComputedBSize with computedBSizeLeftOver. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 28 Jun 2019 21:21:03 +0000 - rev 480634
Push 88813 by aethanyc@gmail.com at Fri, 28 Jun 2019 21:35:11 +0000
Bug 1562122 Part 2 - Replace effectiveComputedBSize with computedBSizeLeftOver. r=dholbert No need to call GetEffectiveComputedBSize() twice. Also, calling aState.ConsumedBSize() instead of using aState.mConsumedBSize directly because the accessor function caches mConsumedBSize properly when it is called the first time. Differential Revision: https://phabricator.services.mozilla.com/D36289
a82f8b85057e6c117d4531610ced26f582e192ff: Bug 1562122 Part 1 - Move the logic after ComputeFinalBSize() into ComputeFinalBSize(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 28 Jun 2019 21:20:54 +0000 - rev 480633
Push 88813 by aethanyc@gmail.com at Fri, 28 Jun 2019 21:35:11 +0000
Bug 1562122 Part 1 - Move the logic after ComputeFinalBSize() into ComputeFinalBSize(). r=dholbert This patch only moves the logic, and rename some variables. More clean-up follows. Note in the middle of ComputeFinalBSize(), ShouldAvoidBreakInside() can do early return under the condition that aStatus is complete. The logic moved in this patch is executed only when aStatus is *incomplete*, so no behavior is changed after applying this change. Differential Revision: https://phabricator.services.mozilla.com/D36288
f4c40aafc15e3080835a8b1abb2d85de41765ad6: Bug 1561717: Add reftests for 'contain:size' on select elements. r=dholbert
Morgan Rae Reschenberg <mreschenberg@mozilla.com> - Wed, 26 Jun 2019 13:17:47 -0700 - rev 480333
Push 88628 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:43:10 +0000
Bug 1561717: Add reftests for 'contain:size' on select elements. r=dholbert
ba32151f8fc12c08e67647293a7dc43403a18639: Bug 1295404 - Remove requiredFeatures from SVGTests r=dholbert r=bzbarsky
longsonr <longsonr@gmail.com> - Wed, 26 Jun 2019 19:51:12 +0100 - rev 480330
Push 88628 by ccoroiu@mozilla.com at Thu, 27 Jun 2019 09:43:10 +0000
Bug 1295404 - Remove requiredFeatures from SVGTests r=dholbert r=bzbarsky
40986c1d78aa9a4cd6c9cf418f02428e5909690e: Bug 1440014: Part 2: Added reftests for text-decoration-width r=dholbert
Charlie Marlow <cmarlow@mozilla.com> - Tue, 25 Jun 2019 20:09:03 +0000 - rev 480295
Push 88605 by dholbert@mozilla.com at Thu, 27 Jun 2019 03:45:16 +0000
Bug 1440014: Part 2: Added reftests for text-decoration-width r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D34943
fd9cb42cee2978361d8210c9034a408b62bdb741: Bug 1547231 - Make mapped aspect-ratio get reflected in images. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 22:10:08 +0000 - rev 480266
Push 88590 by ealvarez@mozilla.com at Wed, 26 Jun 2019 22:23:00 +0000
Bug 1547231 - Make mapped aspect-ratio get reflected in images. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29039
e314c697fe89257715b8743fcf936a6384bade47: Bug 1547231 - Map width and height on image-ish elements to aspect-ratio. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 22:10:06 +0000 - rev 480265
Push 88590 by ealvarez@mozilla.com at Wed, 26 Jun 2019 22:23:00 +0000
Bug 1547231 - Map width and height on image-ish elements to aspect-ratio. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29038
e7fd34a8c655220798eb284eb05f09e00839376e: Bug 1547231 - Add an internal aspect-ratio CSS property. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Jun 2019 22:10:04 +0000 - rev 480264
Push 88590 by ealvarez@mozilla.com at Wed, 26 Jun 2019 22:23:00 +0000
Bug 1547231 - Add an internal aspect-ratio CSS property. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D29037
88184dadb61ad1d5788b9da402b6446bf1329d6a: Bug 1561351 - Fix prematurely closed head elements. r=dholbert
L. David Baron <dbaron@dbaron.org> - Wed, 26 Jun 2019 15:34:14 +0000 - rev 480184
Push 88550 by dbaron@mozilla.com at Wed, 26 Jun 2019 16:01:53 +0000
Bug 1561351 - Fix prematurely closed head elements. r=dholbert Depends on D35958 Differential Revision: https://phabricator.services.mozilla.com/D35959
ad522f2470a930287fb71c64a6f8d30e331b67a0: Bug 1561351 - Import from WPT: Load Ahem as a webfont everywhere (part 2) (#17173) r=dholbert
Luke Zielinski <44509484+LukeZielinski@users.noreply.github.com> - Wed, 26 Jun 2019 15:35:58 +0000 - rev 480183
Push 88550 by dbaron@mozilla.com at Wed, 26 Jun 2019 16:01:53 +0000
Bug 1561351 - Import from WPT: Load Ahem as a webfont everywhere (part 2) (#17173) r=dholbert This change updates a large number of reftests to link to the `/fonts/ahem.css` stylesheet. Each file contains a single additional line before the first `<style>` element: ``` <link rel="stylesheet" type="text/css" href="/fonts/ahem.css" /> ``` Differential Revision: https://phabricator.services.mozilla.com/D35958
28854bf543da35394680922280e267eb65eb7a41: Bug 1547533 - Update ResizeObserver tests on <img>. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Tue, 25 Jun 2019 18:10:04 +0000 - rev 480097
Push 88502 by boris.chiou@gmail.com at Tue, 25 Jun 2019 20:38:27 +0000
Bug 1547533 - Update ResizeObserver tests on <img>. r=dholbert Looks like onload event is not enough, so we still have intermittents. Based on the suggestion in html spec: https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode We decode the image in parallel, and only inserting it into the DOM (and thus causing it to be painted) once the decoding process is complete. Because the decode() method attempts to ensure that the decoded image data is available for at least one frame, it can be combined with the requestAnimationFrame() API. This means it can be used with coding styles or frameworks that ensure that all DOM modifications are batched together as animation frame callbacks. Hope this could reduce the occurrence rate of this intermittent. Differential Revision: https://phabricator.services.mozilla.com/D35732
f7addc19e0ae6fb0f14a99d493e11eaab4725952: Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 23 Jun 2019 10:08:16 +0000 - rev 479902
Push 88353 by ealvarez@mozilla.com at Sun, 23 Jun 2019 10:09:09 +0000
Bug 1559094 - Restore old behavior for background-size: cover + zero-sized background positioning area. r=dholbert This restores our previous and per-spec behavior. Comparing only ratios was not correct in the case one of the dimensions was zero and thus not scaled. Differential Revision: https://phabricator.services.mozilla.com/D35571
ec13a60035f66bcce7a30e9643aaad40d056aad5: Bug 1536871 - Make 'line-height: normal' return the 'normal' keyword from getComputedStyle() on Nightly and Early Beta, for now. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 14 Jun 2019 09:01:44 +0000 - rev 479884
Push 88339 by ealvarez@mozilla.com at Sat, 22 Jun 2019 12:49:32 +0000
Bug 1536871 - Make 'line-height: normal' return the 'normal' keyword from getComputedStyle() on Nightly and Early Beta, for now. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D25119
7ae44e68ef103e451b5a535b4f77407c0ae78382: Bug 1559094 - Restore old behavior for background-size: cover + zero-height background positioning area. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Sat, 22 Jun 2019 00:47:45 +0000 - rev 479881
Push 88336 by ealvarez@mozilla.com at Sat, 22 Jun 2019 10:17:07 +0000
Bug 1559094 - Restore old behavior for background-size: cover + zero-height background positioning area. r=dholbert This restores our previous behavior and adds a .tentative test because I couldn't see how the spec makes any sense. Filed https://github.com/w3c/csswg-drafts/issues/4049 about that. Differential Revision: https://phabricator.services.mozilla.com/D35571
c099f4a4ffb6b0a590af7d44a2329925763e1f4b: Bug 1558705 - [css-grid-2] Account for the subgrid's margin/border/padding when resolving its non-subgridded track sizes. r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 17 Jun 2019 15:03:03 +0200 - rev 479811
Push 88290 by shindli@mozilla.com at Fri, 21 Jun 2019 09:56:00 +0000
Bug 1558705 - [css-grid-2] Account for the subgrid's margin/border/padding when resolving its non-subgridded track sizes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D35192