searching for reviewer(dholbert)
977b599edf3f631389157aef63bab71b67316f67: Bug 1168478 Part 2 - Combine the border and padding arguments for nsIFrame::ComputeSize(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 14 Sep 2020 20:42:22 +0000 - rev 548612
Push 126298 by aethanyc@gmail.com at Mon, 14 Sep 2020 20:45:12 +0000
Bug 1168478 Part 2 - Combine the border and padding arguments for nsIFrame::ComputeSize(). r=dholbert Also combine the border and padding arguments for nsContainerFrame::ComputeSizeWithIntrinsicDimensions(), too. This method is used as a helper to implement ComputeSize() for various replaced elements. Its callers are all within nsIFrame's derived classes' overridden methods, so I'm not bothering to convert them in a separate patch. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D90064
918080b4e7aed90174ea50ebf4db379cae8534a8: Bug 1168478 Part 1 - Combine the border and padding argument for nsIFrame::ComputeAutoSize(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Mon, 14 Sep 2020 20:39:17 +0000 - rev 548611
Push 126298 by aethanyc@gmail.com at Mon, 14 Sep 2020 20:45:12 +0000
Bug 1168478 Part 1 - Combine the border and padding argument for nsIFrame::ComputeAutoSize(). r=dholbert Also, revise the nsIFrame::ComputeAutoSize()'s documentation. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D90063
c181f711e9e003db5f11f869e5f1bc4cdf0bcb54: Bug 1633038 - Adjust some tests to wait for load event to try to ensure styles are loaded r=dholbert
longsonr <longsonr@gmail.com> - Mon, 14 Sep 2020 17:30:06 +0000 - rev 548604
Push 126291 by longsonr@gmail.com at Mon, 14 Sep 2020 19:37:12 +0000
Bug 1633038 - Adjust some tests to wait for load event to try to ensure styles are loaded r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D90093
c97d502f76a2a61024f1528d9d936c9e37a4cc2a: Bug 1663822 Part 8 - Revise nsIFrame::ComputeSize()'s documentation. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 18:22:37 +0000 - rev 548379
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 8 - Revise nsIFrame::ComputeSize()'s documentation. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D89643
c7547d0ef4be9d3f0f64ce7047445268455af7cd: Bug 1663822 Part 7 - Use constructor delegation for SizeComputationInput. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 17:59:28 +0000 - rev 548378
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 7 - Use constructor delegation for SizeComputationInput. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D89546
ff505e83d0428d70cb7b38eb4681056d0dd2f210: Bug 1663822 Part 6 - Convert the anonymous enum controlling ReflowInput's behavior into an EnumSet. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 17:59:21 +0000 - rev 548377
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 6 - Convert the anonymous enum controlling ReflowInput's behavior into an EnumSet. r=dholbert This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89545
bcc431e93c8e2be755e39b97753f857d45a135c2: Bug 1663822 Part 5 - Move ReflowInputFlags from SizeComputationInput to ReflowInput. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 17:59:13 +0000 - rev 548376
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 5 - Move ReflowInputFlags from SizeComputationInput to ReflowInput. r=dholbert In previous part, we changed SizeComputationInput::InitOffsets to take a ComputeSizeFlags parameter instead of ReflowInputFlags. Now there's no reason to put ReflowInputFlags under SizeComputationInput. Also rename it to `Flags` because it now lives in `ReflowInput`. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89544
bfd617a935233a0c62eb5bd7c9ac9313620e9bb7: Bug 1663822 Part 4 - Add a ComputeSizeFlags parameter to ReflowInput's constructor, and store it in ReflowInput. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 18:17:51 +0000 - rev 548375
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 4 - Add a ComputeSizeFlags parameter to ReflowInput's constructor, and store it in ReflowInput. r=dholbert Currently, to set ComputeSizeFlags, the caller uses an anonymous enum as a parameter to ReflowInput constructor to set ReflowInputFlags fields, and then ReflowInput creates a ComputeSizeFlags from the relevant ReflowInputFlags fields in Init(). This patch simplifies this flags handover by adding ComputeSizeFlags parameter to ReflowInput so that the caller can create the flags and pass it to ReflowInput directly. The can also simplifies the process needed to add a new ComputeSizeFlag. We still need to store ComputeSizeFlags in ReflowInput since there's one caller in `nsBlockFrame::ComputeFinalSize` wanting to checking `ComputeSizeFlag::BClampMarginBoxMinSize`. Note 1: ComputeSizeFlags is added only to the ReflowInput's constructor that also takes parent ReflowInput. The other constructor's existing callers don't need it. Note 2: I don't bother adjust the value of DUMMY_PARENT_REFLOW_INPUT, CALLER_WILL_INIT, and STATIC_POS_IS_CB_ORIGIN because they are going to be converted into a enum class in a later patch. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89543
fbc1eaa18e51b0e89f97f118480961cc03b1659b: Bug 1663822 Part 3 - Move ComputeSizeFlags to LayoutConstants.h, and put it under mozilla namespace. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 18:32:08 +0000 - rev 548374
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 3 - Move ComputeSizeFlags to LayoutConstants.h, and put it under mozilla namespace. r=dholbert In the next part, I'm going to use ComputeSizeFlags as the arguments in some ReflowInput's methods. Because nsIFrame.h includes ReflowInput.h, to solve the circular dependency, ComputeSizeFlags needs to be moved to somewhere else. Also, revise the document for ComputeSizeFlag. The rest of the patch is just dropping `nsIFrame::` and adding `mozilla::` as needed. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89542
8e587833e6290d92d81eca990f81ecf3d3fd7a37: Bug 1663822 Part 2 - Change ComputeSizeFlags into an EnumSet. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 18:32:16 +0000 - rev 548373
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 2 - Change ComputeSizeFlags into an EnumSet. r=dholbert This patch does: 1. Rename the original ComputeSizeFlags to ComputeSizeFlag (dropping the "s"), and make it an enum class. 2. Make ComputeSizeFlags an EnumSet. 3. Adapt the users to use EnumSet's APIs. The `Default` enum value in ComputeSizeFlag is not needed. It equals to an empty ComputeSizeFlags. This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89541
070f9ba9109a70c77fdaeb769baa3890ddd98b0a: Bug 1663822 Part 1 - Drop the "e" prefix from the enum values in ComputeSizeFlags. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 11 Sep 2020 18:31:56 +0000 - rev 548372
Push 126141 by aethanyc@gmail.com at Fri, 11 Sep 2020 18:37:10 +0000
Bug 1663822 Part 1 - Drop the "e" prefix from the enum values in ComputeSizeFlags. r=dholbert This change shouldn't change behavior. Differential Revision: https://phabricator.services.mozilla.com/D89540
dae9b44b1173daa828f23d000379cac0d39a0fba: Bug 1652112 Part 6 - Move remaining shape-outside reftests to wpt, and delete w3c-css/submitted/shapes1 folder. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:24:51 +0000 - rev 547634
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 6 - Move remaining shape-outside reftests to wpt, and delete w3c-css/submitted/shapes1 folder. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85020
c52a8e4fb6bc8bbe5aade9be7e2b7cc721ac27bd: Bug 1652112 Part 5 - Move shape-outside polygon reftests into wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:23:55 +0000 - rev 547633
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 5 - Move shape-outside polygon reftests into wpt. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85019
b40c5b238a2a3aaf3ff013d1981647c1cad9d4c4: Bug 1652112 Part 4 - Move shape-outside inset reftests into wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:18:14 +0000 - rev 547632
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 4 - Move shape-outside inset reftests into wpt. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85018
9d1096f1ec0185ec9d29238a043aa28707a3c5be: Bug 1652112 Part 3 - Move shape-outside ellipse reftests into wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:17:16 +0000 - rev 547631
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 3 - Move shape-outside ellipse reftests into wpt. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85017
2acfb0c8714be4ab34aa6cac614252c4f937d6ab: Bug 1652112 Part 2 - Move shape-outside circle reftests into wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 21:32:10 +0000 - rev 547630
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 2 - Move shape-outside circle reftests into wpt. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85016
e85fc3dfd5e82a2633e6dc2edea2824eccb83d55: Bug 1652112 Part 1 - Move shape-outside shape-box reftests into wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:10:07 +0000 - rev 547629
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 1 - Move shape-outside shape-box reftests into wpt. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85014
8e9afaf719356dc724b828f8a8eb6433eb220b3e: Bug 1652112 Part 0 - Delete vendor-imports/mozilla-central-reftests/shapes1/ in wpt. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 02 Sep 2020 20:02:39 +0000 - rev 547628
Push 125661 by aethanyc@gmail.com at Thu, 03 Sep 2020 03:16:10 +0000
Bug 1652112 Part 0 - Delete vendor-imports/mozilla-central-reftests/shapes1/ in wpt. r=dholbert Delete both the reftests and ini files. Differential Revision: https://phabricator.services.mozilla.com/D87207
5f76c97b6f206fcc18b10bb62773fcce4ef1346f: Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 27 Aug 2020 09:37:31 +0000 - rev 546587
Push 125115 by ealvarez@mozilla.com at Thu, 27 Aug 2020 10:08:16 +0000
Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert Differential Revision: https://phabricator.services.mozilla.com/D88065
78598fcb79e338182b42799e8d8d9225d00af214: Bug 1660908 - Use rawNumPages rather than printPreviewNumPages for the total number of pages. r=emalysz,dholbert
Sam Foster <sfoster@mozilla.com> - Thu, 27 Aug 2020 05:10:16 +0000 - rev 546414
Push 125099 by sfoster@mozilla.com at Thu, 27 Aug 2020 05:14:17 +0000
Bug 1660908 - Use rawNumPages rather than printPreviewNumPages for the total number of pages. r=emalysz,dholbert Differential Revision: https://phabricator.services.mozilla.com/D88223
6c8985ac1d4c4c3e0457a7acc5836932eb3ec557: Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 26 Aug 2020 19:12:15 +0000 - rev 546346
Push 125059 by ealvarez@mozilla.com at Wed, 26 Aug 2020 19:15:49 +0000
Bug 1660857 - Only apply grayscale filter for printing on print preview. r=jwatt,dholbert Depends on D88064 Differential Revision: https://phabricator.services.mozilla.com/D88065
592c99d3054399d45a4bb9afb95946058afb6d12: Bug 1660189 - Bail out from nsPrintJob::DoCommonPrint if the docshell was destroyed in beforeprint event handlers. r=dholbert
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Fri, 21 Aug 2020 04:58:49 +0000 - rev 545630
Push 124697 by hikezoe.birchill@mozilla.com at Fri, 21 Aug 2020 05:01:33 +0000
Bug 1660189 - Bail out from nsPrintJob::DoCommonPrint if the docshell was destroyed in beforeprint event handlers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D87827
fc7ac8859238727b11963e1bcc97670b4b82b975: Bug 1412687 Part 3 - Add a reftest testing breaking a float in a table. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 20 Aug 2020 22:30:16 +0000 - rev 545614
Push 124685 by aethanyc@gmail.com at Thu, 20 Aug 2020 23:03:06 +0000
Bug 1412687 Part 3 - Add a reftest testing breaking a float in a table. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D87631
ce14bf5310d128e45075f100da067eb2e78bf4bb: Bug 1412687 Part 2 - Consider an overflow container's scrollable overflow when deciding whether to reflow it. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 20 Aug 2020 22:29:59 +0000 - rev 545613
Push 124685 by aethanyc@gmail.com at Thu, 20 Aug 2020 23:03:06 +0000
Bug 1412687 Part 2 - Consider an overflow container's scrollable overflow when deciding whether to reflow it. r=dholbert This patch is similar to Bug 1559961 Part 2 [1]. That is, we want to reflow an overflow container again if its scrollable overflow block-end exceeds the available block-size constraint. [1] https://hg.mozilla.org/mozilla-central/rev/d377ce300d0349c1b7dc562bcf5343851d36c6ed Differential Revision: https://phabricator.services.mozilla.com/D87630
9a82bca1962aa9921441653a872a068d322641fb: Bug 1412687 Part 1 - Make const-cast clearer in nsTableRowGroupFrame::Reflow(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 20 Aug 2020 22:24:58 +0000 - rev 545612
Push 124685 by aethanyc@gmail.com at Thu, 20 Aug 2020 23:03:06 +0000
Bug 1412687 Part 1 - Make const-cast clearer in nsTableRowGroupFrame::Reflow(). r=dholbert ReflowInputFlags is a struct of bitfields, so we cannot use AutoRestore to restore its member bitfield. Differential Revision: https://phabricator.services.mozilla.com/D87629
5944dfb5b9513d6249607acbe523736d963a94c8: Bug 1660285 - Improve Print Paper Size Test Assertions r=dholbert
Erik Nordin <nordzilla@mozilla.com> - Thu, 20 Aug 2020 17:52:20 +0000 - rev 545542
Push 124644 by rmaries@mozilla.com at Thu, 20 Aug 2020 17:56:06 +0000
Bug 1660285 - Improve Print Paper Size Test Assertions r=dholbert This improves the paper assertions to check for attribute type, rather than checking if the attribute is null, since undefined is not null and can cause false positives. Also updates the formatting to be congruent with other related tests. Differential Revision: https://phabricator.services.mozilla.com/D87783
52a7009329ba00f764623db21f72b0469f5a81e9: Bug 1660251 - After bug 1658173 we need to re-center pages if any dimensions change, not just if width changes. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 20 Aug 2020 16:23:48 +0000 - rev 545527
Push 124631 by ealvarez@mozilla.com at Thu, 20 Aug 2020 16:26:57 +0000
Bug 1660251 - After bug 1658173 we need to re-center pages if any dimensions change, not just if width changes. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D87757
fee27d9109bbe4661543c9923b531f4a7010034b: Bug 1633031 Part 3 - Remove unused parameters from DoFlexLayout(), ComputeMainSize(), and ComputeCrossSize(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Aug 2020 21:10:48 +0000 - rev 545446
Push 124576 by aethanyc@gmail.com at Thu, 20 Aug 2020 00:51:28 +0000
Bug 1633031 Part 3 - Remove unused parameters from DoFlexLayout(), ComputeMainSize(), and ComputeCrossSize(). r=dholbert We do the flex algorithm by assuming the available block-size is unconstrained. Thus, we can remove `availableBSizeForContent` and `aStatus` passing to DoFlexLayout(), ComputeMainSize(), and ComputeCrossSize(). Differential Revision: https://phabricator.services.mozilla.com/D87109
cd972e86c6d564cbed9d03a7db49949598d1f256: Bug 1633031 Part 2 - Add reftests for fragmenting multi-line column-oriented flex containers. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Aug 2020 21:22:34 +0000 - rev 545445
Push 124576 by aethanyc@gmail.com at Thu, 20 Aug 2020 00:51:28 +0000
Bug 1633031 Part 2 - Add reftests for fragmenting multi-line column-oriented flex containers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D87108
b1220dc3ec0982444cdee534a265926a977daf24: Bug 1633031 Part 1 - Stop considering available block-size when wrapping flex lines in multi-line column-oriented flex container. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Aug 2020 21:10:01 +0000 - rev 545444
Push 124576 by aethanyc@gmail.com at Thu, 20 Aug 2020 00:51:28 +0000
Bug 1633031 Part 1 - Stop considering available block-size when wrapping flex lines in multi-line column-oriented flex container. r=dholbert Although this goes against the suggestion of the sample algorithm in the spec, this brings the layout of the multi-line column-oriented flex container in paginated context closer to the layout with no fragmentation. This also matches Google Chrome's behavior. Tweak flexbox-unbreakable-child-2.html so that it matches the rendering as of this patch. Change the height of `.muticol` and the removal of border in `flexContainer` to let two flex items fit exactly into the flex container's height, making reference easier to write. Differential Revision: https://phabricator.services.mozilla.com/D87107
18dbcec715c7f176ef13c30579efd5603148c4de: Bug 1414600 - Make media queries and viewport units in print be evaluated against the default page size minus margins. r=dholbert,nordzilla
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Aug 2020 10:32:16 +0000 - rev 545304
Push 124500 by ealvarez@mozilla.com at Wed, 19 Aug 2020 11:00:06 +0000
Bug 1414600 - Make media queries and viewport units in print be evaluated against the default page size minus margins. r=dholbert,nordzilla For that, move the default page margin computation to nsPresContext. See https://github.com/w3c/csswg-drafts/issues/5437 as to why doing this and other alternatives. Differential Revision: https://phabricator.services.mozilla.com/D87311
68017ced66c721dc480191de2ab4a7e0ccb0d4a1: Bug 1659899 - Fix title of reftests that test breaking nested float in flex item. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 19 Aug 2020 03:47:50 +0000 - rev 545264
Push 124473 by aethanyc@gmail.com at Wed, 19 Aug 2020 04:10:28 +0000
Bug 1659899 - Fix title of reftests that test breaking nested float in flex item. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D87542
b6d1532f6cd4f3dabe20557fddcfb8595a6ba809: Bug 1414600 - Make media queries and viewport units in print be evaluated against the default page size minus margins. r=dholbert,nordzilla
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 19 Aug 2020 00:02:34 +0000 - rev 545234
Push 124451 by ealvarez@mozilla.com at Wed, 19 Aug 2020 00:16:52 +0000
Bug 1414600 - Make media queries and viewport units in print be evaluated against the default page size minus margins. r=dholbert,nordzilla For that, move the default page margin computation to nsPresContext. See https://github.com/w3c/csswg-drafts/issues/5437 as to why doing this and other alternatives. Differential Revision: https://phabricator.services.mozilla.com/D87311
2da97f87cae2e20a4c1c2840869b9f60711d6e2d: Bug 1639963 - Add extra wpts for HTML embed element. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 17 Aug 2020 07:17:32 +0000 - rev 544930
Push 124281 by bchiou@mozilla.com at Mon, 17 Aug 2020 10:09:22 +0000
Bug 1639963 - Add extra wpts for HTML embed element. r=dholbert This should be very simliar with <object> with image example. We use nsImageFrame to represent this embed element. Just make sure wpt covers all the typical replaced elements, based on MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/Replaced_element). Differential Revision: https://phabricator.services.mozilla.com/D79571
8326d6db27552a56e893000597e1ddc17e9d0003: Bug 1639963 - Support aspect-ratio for video element. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 17 Aug 2020 08:28:37 +0000 - rev 544926
Push 124281 by bchiou@mozilla.com at Mon, 17 Aug 2020 10:09:22 +0000
Bug 1639963 - Support aspect-ratio for video element. r=dholbert This includes a update of the ini file. I noticed the color of the video is not equal to "rgb(0, 128, 0)" (i.e. background-color: green). It is "rgb(1, 128. 1)" on Mac (without WebRender), "rgb(0, 125, 0)" on Mac (with WebRender), and "rgb(1, 128, 2)" on Linux. Perhaps it is a bug of our video rendering or video scaling. Therefore, I added fuzzy into the ini file with max 0-3 difference per channel. (Note: The size of this video is 50x50, so the max number of pixels is 2500.) Differential Revision: https://phabricator.services.mozilla.com/D79337
a37073226eb7143224706570c7513ca01bfd42ae: Bug 1639963 - Define the default size for replaced elements. r=dholbert
Boris Chiou <boris.chiou@gmail.com> - Mon, 17 Aug 2020 07:10:39 +0000 - rev 544925
Push 124281 by bchiou@mozilla.com at Mon, 17 Aug 2020 10:09:22 +0000
Bug 1639963 - Define the default size for replaced elements. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D81006
7fce76db6044252d6599556a960418a8f11d5b30: Bug 1658455 - Remove eANIMATION and eFILTER from IsNodeOfType r=dholbert
longsonr <longsonr@gmail.com> - Sat, 15 Aug 2020 10:38:17 +0000 - rev 544883
Push 124257 by longsonr@gmail.com at Sat, 15 Aug 2020 10:42:02 +0000
Bug 1658455 - Remove eANIMATION and eFILTER from IsNodeOfType r=dholbert - eANIMATION is the same as testing for SVGAnimationElement - eFILTER is the same as testing for SVGFE Differential Revision: https://phabricator.services.mozilla.com/D86695
e140c6cd2eb944579ec99458638879c9b8501920: Bug 1386418 - Fix two issues in nsIFrame::HandleRelease. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 14 Aug 2020 17:36:03 +0000 - rev 544715
Push 124219 by ealvarez@mozilla.com at Fri, 14 Aug 2020 18:46:53 +0000
Bug 1386418 - Fix two issues in nsIFrame::HandleRelease. r=dholbert The frame selection changes can run script, so we need to check for the frame itself getting destroyed. This fixes the crash as reported. Additionally, the document check it does for pointer capture is incorrect, it should use the composed, not uncomposed doc, so that it works in shadow dom. Differential Revision: https://phabricator.services.mozilla.com/D87097
4e2829404dbb5fe8e99b23330046abb23d2ef54a: Bug 1654331 - throw InvalidStateError when getPointAtLength can't get the path for measuring r=dholbert
longsonr <longsonr@gmail.com> - Mon, 10 Aug 2020 03:49:56 +0000 - rev 544066
Push 123791 by longsonr@gmail.com at Mon, 10 Aug 2020 04:07:05 +0000
Bug 1654331 - throw InvalidStateError when getPointAtLength can't get the path for measuring r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D86461
5a3189a82913f443861999b5587422031609c40d: Bug 1654331 - throw InvalidStateError when getPointAtLength can't get the path for measuring r=dholbert
longsonr <longsonr@gmail.com> - Sun, 09 Aug 2020 20:34:04 +0000 - rev 544045
Push 123776 by longsonr@gmail.com at Sun, 09 Aug 2020 20:40:01 +0000
Bug 1654331 - throw InvalidStateError when getPointAtLength can't get the path for measuring r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D86461
baf18578315e78f16173eb59557ad54005eefe1c: Bug 1653858 - Introduce concept of valid target for use elements and use it rather than listing out all elements r=dholbert
longsonr <longsonr@gmail.com> - Sat, 08 Aug 2020 15:47:04 +0000 - rev 544037
Push 123769 by longsonr@gmail.com at Sat, 08 Aug 2020 23:33:30 +0000
Bug 1653858 - Introduce concept of valid target for use elements and use it rather than listing out all elements r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D84104
db613effb20bfd4e703c164d2f464cc22b97e2a8: Bug 1559961 Part 4 - Reflow lines with pushed floats under constrained available block-size or in paginated context. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Sat, 08 Aug 2020 01:13:15 +0000 - rev 543992
Push 123744 by aethanyc@gmail.com at Sat, 08 Aug 2020 01:19:44 +0000
Bug 1559961 Part 4 - Reflow lines with pushed floats under constrained available block-size or in paginated context. r=dholbert When a clearance frame is discovered in a BFC subtree (`ReflowInput::WillReflowAgainForClearance()` is true), all the block descendants of the BFC return from `ReflowBlockFrame` immediately without placing their children or requesting continuation for their children, etc., because the BFC is going to reflow the subtree a second time. When this happens, any block descendant whose lines contain pushed floats should be marked dirty and reflowed again so that they can go through all the split floats logic and set their nsReflowStatus to incomplete/overflow-incomplete correctly. (We may develop a smarter way in bug 851629 to make the performance better.) The condition `aState.mPresContext->IsPaginated()` is added to prevent 1406291-1.html from failing. In 1406291-1.html, the table containing the float in its subtree is being pushed to the second page due to force break, and the float is in PushedFloatsList of its parent block. When we reflow the block again (in the second page), it is reflowed under the measuring stage of the table layout with unconstrained available block-size. nsBlockFrame::DrainSelfPushedFloats() deliberately doesn't drain pushed floats if their placehoder are in the same block, and expect the floats to be reflowed again. Before this patch, the line can be marked dirty via HasPushedFloats(), but in this patch, HasPushedFloats() is moved into the nested if-else, so we need `aState.mPresContext->IsPaginated()` to let the block know that it's in a paginated context, and needs to reflow any line that contains pushed floats. Differential Revision: https://phabricator.services.mozilla.com/D85480
5fe73187284a129fc5de13f642beef1b2ff3e073: Bug 1559961 Part 3 - Refactor the conditions to mark a line dirty under constrained available block-size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 22:16:29 +0000 - rev 543991
Push 123744 by aethanyc@gmail.com at Sat, 08 Aug 2020 01:19:44 +0000
Bug 1559961 Part 3 - Refactor the conditions to mark a line dirty under constrained available block-size. r=dholbert This change cleans up the complex logic with additional comments added. It shouldn't alter the behavior. Differential Revision: https://phabricator.services.mozilla.com/D86068
d377ce300d0349c1b7dc562bcf5343851d36c6ed: Bug 1559961 Part 2 - Consider a line's scrollable overflow when marking a line dirty. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 22:16:21 +0000 - rev 543990
Push 123744 by aethanyc@gmail.com at Sat, 08 Aug 2020 01:19:44 +0000
Bug 1559961 Part 2 - Consider a line's scrollable overflow when marking a line dirty. r=dholbert Before this patch, a block frame considers a line dirty only if the line's block-end is larger than content area's block-end. However, scrollable overflow area should be broken in paginated environment (both in a column container and in printing). We should take this into account when marking a line dirty. The dynamic wpt reftests are written with the following conditions in mind to expose the bug: 1. Initially, all the elements fit into the first column. 2. After shrinking the multicol height, the block itself still fits into the first column, but its tall child (either a simple tall block or a tall float), which overflows the smaller multicol height, needs to be broken. The flexbox printing reftest are similar. A flex container uses unconstrained available block-size to measure flex items' block-size, and then performs a final reflow with constrained available block-size, which is similar to the dynamic scenario above. One caveat is that flex items usually have IsBResize() set. So to expose this bug, a float element needs to be deeply nested under a flex item. Differential Revision: https://phabricator.services.mozilla.com/D85479
2649323b61fb2f91c98aea8accb159e3d9c9acd1: Bug 1559961 Part 1 - Update the reason for child's completeness in measuring reflow of flex items. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 22:16:06 +0000 - rev 543989
Push 123744 by aethanyc@gmail.com at Sat, 08 Aug 2020 01:19:44 +0000
Bug 1559961 Part 1 - Update the reason for child's completeness in measuring reflow of flex items. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D85478
56299d5ad3f6f6052cb30b91d0686e35b28cb453: Bug 1042151 Part 5 - Add a reftest. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 02:20:47 +0000 - rev 543857
Push 123727 by aethanyc@gmail.com at Fri, 07 Aug 2020 21:06:42 +0000
Bug 1042151 Part 5 - Add a reftest. r=dholbert `scrollbar-no-margin.html` is adapted from `scrollbar.html` with margin removed from flex-items, to workaround bug 1527539. `font-size: 0` added to `.flex` is to workaround bug 1302700. Also, adjust `scrollbar-width` and `scrollbar-color` to avoid fuzzy rendering on rounded-corner slider on some platforms. Differential Revision: https://phabricator.services.mozilla.com/D86079
d4f4e419c9757b9bcae02494ccc22f32425e20c9: Bug 1042151 Part 4 - Consider flexbox's main & cross axis when getting scrolled rect. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 19:11:38 +0000 - rev 543856
Push 123727 by aethanyc@gmail.com at Fri, 07 Aug 2020 21:06:42 +0000
Bug 1042151 Part 4 - Consider flexbox's main & cross axis when getting scrolled rect. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D86078
9dd61fc2cbbd2ced90cc32bcc4363d138000e6c6: Bug 1042151 Part 3 - Extract a helper class containing flexbox's axis information. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 17:43:16 +0000 - rev 543855
Push 123727 by aethanyc@gmail.com at Fri, 07 Aug 2020 21:06:42 +0000
Bug 1042151 Part 3 - Extract a helper class containing flexbox's axis information. r=dholbert This struct is going to be used in the next part in nsLayoutUtils::GetScrolledRect(). Differential Revision: https://phabricator.services.mozilla.com/D86077
5558e9475e40f73148fdd1d3a156f6cc229d49f9: Bug 1042151 Part 2 - Refactor the conditions that decide which edge to clamp when getting scrolled rect. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 02:20:44 +0000 - rev 543854
Push 123727 by aethanyc@gmail.com at Fri, 07 Aug 2020 21:06:42 +0000
Bug 1042151 Part 2 - Refactor the conditions that decide which edge to clamp when getting scrolled rect. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D86076
f9d4918600d75f0fc8d90239eb3936eedff75bd3: Bug 1042151 Part 1 - Sort the #include statements in nsLayoutUtils.cpp. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 07 Aug 2020 02:20:42 +0000 - rev 543853
Push 123727 by aethanyc@gmail.com at Fri, 07 Aug 2020 21:06:42 +0000
Bug 1042151 Part 1 - Sort the #include statements in nsLayoutUtils.cpp. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D86075