searching for reviewer(dholbert)
16504649f4893ace8dcc78da4900e546f610fe1f: Bug 1590247 - Fix some pre-existing dynamic restyling issues with scrollbar-width. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Oct 2021 21:19:14 +0000 - rev 595987
Push 151533 by ealvarez@mozilla.com at Thu, 14 Oct 2021 21:21:48 +0000
Bug 1590247 - Fix some pre-existing dynamic restyling issues with scrollbar-width. r=dholbert This was pre-existing but caught by some scrollbar-width tests. A test-case that reproduces on current nightly: data:text/html,<html style="overflow: scroll; scrollbar-color: red red; scrollbar-width: thin"> Toggling the `scrollbar-width` declaration in devtools doesn't change the effective scrollbar width. Ensure we correctly reflow the scrollbars in this case. Differential Revision: https://phabricator.services.mozilla.com/D128515
cb21a032e4ad3b8db96f38cef47b13837fb455e4: Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Oct 2021 21:19:14 +0000 - rev 595986
Push 151533 by ealvarez@mozilla.com at Thu, 14 Oct 2021 21:21:48 +0000
Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert This prevents jank when switching from overflow: auto -> hidden or such. Differential Revision: https://phabricator.services.mozilla.com/D128367
1492d117aca49c68e1c6f7791418c93519212137: Bug 1590247 - Factor out ScrollbarChange handling. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Oct 2021 21:19:13 +0000 - rev 595985
Push 151533 by ealvarez@mozilla.com at Thu, 14 Oct 2021 21:21:48 +0000
Bug 1590247 - Factor out ScrollbarChange handling. r=dholbert No behavior change. Differential Revision: https://phabricator.services.mozilla.com/D128370
9b1d970ca9c2cee96fe50ce3ee31ced8fd60f9c1: Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Oct 2021 15:42:06 +0000 - rev 595909
Push 151501 by ealvarez@mozilla.com at Thu, 14 Oct 2021 15:44:34 +0000
Bug 1590247 - Don't reframe scrollable frames if we already have all needed anonymous content. r=dholbert This prevents jank when switching from overflow: auto -> hidden or such. Differential Revision: https://phabricator.services.mozilla.com/D128367
57193e853f39ec64e318d36fffd741e38b40637f: Bug 1590247 - Factor out ScrollbarChange handling. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Oct 2021 15:42:06 +0000 - rev 595908
Push 151501 by ealvarez@mozilla.com at Thu, 14 Oct 2021 15:44:34 +0000
Bug 1590247 - Factor out ScrollbarChange handling. r=dholbert No behavior change. Differential Revision: https://phabricator.services.mozilla.com/D128370
6728f6569a329776f8c7a92fdbdaf55a72721b42: Bug 1735375 - Always reflow fieldset when its available bsize is constrained. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 13 Oct 2021 21:22:54 +0000 - rev 595735
Push 151448 by aethanyc@gmail.com at Wed, 13 Oct 2021 21:25:17 +0000
Bug 1735375 - Always reflow fieldset when its available bsize is constrained. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D128308
f87feaa8ebb7e70996e1918bf6bab93251f1858b: Bug 1735326 - Use solid rather than dashed border in two flexbox tests. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 13 Oct 2021 06:31:47 +0000 - rev 595637
Push 151395 by ealvarez@mozilla.com at Wed, 13 Oct 2021 06:34:08 +0000
Bug 1735326 - Use solid rather than dashed border in two flexbox tests. r=dholbert Longer term fix, I don't think this impacts the validity of the test in any way and should avoid antialiasing artifacts. Differential Revision: https://phabricator.services.mozilla.com/D128201
0be9d8da537d9ba558828c3ee2ea12d96d2e0ce2: Bug 1145323 - Audit callers of ReflowOutput constructor in nsFlexContainerFrame. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 08 Oct 2021 17:50:35 +0000 - rev 595264
Push 151157 by aethanyc@gmail.com at Fri, 08 Oct 2021 17:52:56 +0000
Bug 1145323 - Audit callers of ReflowOutput constructor in nsFlexContainerFrame. r=dholbert ReflowOutput can accept any writing mode or ReflowInput passed to its constructor, so a caller can pass a writing mode that is more convenient to retrieve the size. After reflowing flex items, we want to cache its metrics in flex item's writing mode, so we pass item's ReflowInput into ReflowOutput. However, for out-of-flow children, we can change ReflowOutput to use flex container's writing mode by convention. Differential Revision: https://phabricator.services.mozilla.com/D127913
eea2d5968d6cadf9c629b1cde83af3b2ff4d39c2: Bug 1734658 - Implement some tree dark theme colors for Windows. r=dholbert
Emilio Cobos Alvarez <emilio@crisal.io> - Fri, 08 Oct 2021 10:53:12 +0000 - rev 595215
Push 151121 by ealvarez@mozilla.com at Fri, 08 Oct 2021 11:58:05 +0000
Bug 1734658 - Implement some tree dark theme colors for Windows. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D127888
29696aad432338db943a9ffc431a976a2a0e85a0: Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 05 Oct 2021 09:40:00 +0000 - rev 594596
Push 150879 by ealvarez@mozilla.com at Tue, 05 Oct 2021 09:42:23 +0000
Bug 1734009 - Pass color-related arguments down to the non-native theme in a more convenient way. r=dholbert This avoids adding yet another parameter for the light/dark color-scheme. This shouldn't have any behavior change, but is a prerequisite to implement dark form controls on the non-native theme. Differential Revision: https://phabricator.services.mozilla.com/D127482
d39b23efefe7e7d89d8dfd0ba188ad6af2b0a9ed: Bug 1733569 - Improve windows OS dark mode support. r=dholbert,dao
Emilio Cobos Alvarez <emilio@crisal.io> - Mon, 04 Oct 2021 18:57:55 +0000 - rev 594499
Push 150825 by ealvarez@mozilla.com at Mon, 04 Oct 2021 19:00:17 +0000
Bug 1733569 - Improve windows OS dark mode support. r=dholbert,dao This exposes the system colors that were unexposed in bug 1733354, but builds up on top of bug 1733569 to get buttons and richlistboxes working properly. This causes windows dialogs to be dark in dark mode, etc. To be landed after the freeze, since it likely has some UI fallout that I missed. Differential Revision: https://phabricator.services.mozilla.com/D127260
86a10437e3e9f9dff175c5b1668724521979f2d5: Bug 1733354 - Expose less dark system colors on Windows for now. r=dholbert,layout-reviewers
Emilio Cobos Alvarez <emilio@crisal.io> - Fri, 01 Oct 2021 19:27:17 +0000 - rev 593986
Push 150740 by ealvarez@mozilla.com at Fri, 01 Oct 2021 19:29:41 +0000
Bug 1733354 - Expose less dark system colors on Windows for now. r=dholbert,layout-reviewers This effectively reverts part of the regressing bug (bug 1731678) temporarily. The right fix is described in a comment: * Make the native Windows theme play well with dark system colors, or * Stop using the native Windows theme in the UI (like other browsers), or * Detect properly (rather than via ifdef) whether the native theme is used on callers to GenericDarkColor (so that we can eventually expose the colors in nsNativeBasicThemeWin-using documents, but not in nsThemeWin-using documents). In any case, that seems at least post-freeze material, and the remaining colors we expose still allows us to fix bug 1731678. Differential Revision: https://phabricator.services.mozilla.com/D127246
a2066807a2707f77c8d8d0beee27074b7d70364d: Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 29 Sep 2021 20:05:47 +0000 - rev 593732
Push 150582 by emcdonough@mozilla.com at Wed, 29 Sep 2021 20:08:15 +0000
Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D126161
e6687d345d537ca669921fa18cc72e399b6a83b2: Bug 1731678 - Add some generic dark system colors for Windows/Android/standins. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 29 Sep 2021 10:20:56 +0000 - rev 593668
Push 150537 by ealvarez@mozilla.com at Wed, 29 Sep 2021 10:23:18 +0000
Bug 1731678 - Add some generic dark system colors for Windows/Android/standins. r=dholbert Eventually we should support all of them, but for now they are only used by native code (unless you enable the color-scheme pref) and these will be enough. Differential Revision: https://phabricator.services.mozilla.com/D126737
b9506763c2f67813f48c0f43bd5d7c9319a22f4b: Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Tue, 28 Sep 2021 22:56:37 +0000 - rev 593530
Push 150512 by emcdonough@mozilla.com at Wed, 29 Sep 2021 01:04:32 +0000
Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D126161
8cb9446b8382fed7c096308743684f1df90d2e0f: Bug 1731653 - Record padding change in a frame bit, and use it to detect inline resize. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 28 Sep 2021 20:59:38 +0000 - rev 593519
Push 150502 by aethanyc@gmail.com at Tue, 28 Sep 2021 21:02:02 +0000
Bug 1731653 - Record padding change in a frame bit, and use it to detect inline resize. r=dholbert We store this new bit in nsIFrame instead of in ReflowInput to record a change to padding (inspired by the mHasBSizeChange bit). That is because we may construct a ReflowInput more than one time before reflowing the frame. The first construction of ReflowInput (in SizeComputationInput::InitOffsets) will update nsIFrame::UsedPaddingProperty() using the latest style data, so we *cannot* determine the padding change in any of the subsequent construction of ReflowInput. dynamic-change-inline-size-001.html is the scenario fixed by bug 1307853. We've already passed this test without this patch. dynamic-change-inline-size-002.html is equivalent to 001.html except it's written with "box-sizing:content". dynamic-change-inline-size-003.html is adapted from testcase 2 in bug 1729122 comment 4. Both tests pass after this patch. Differential Revision: https://phabricator.services.mozilla.com/D126422
4d3c7ac994c796987a46604d84b4323ab1193c1a: Bug 1732759 - Test updates. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 Sep 2021 11:44:33 +0000 - rev 593437
Push 150449 by ealvarez@mozilla.com at Tue, 28 Sep 2021 11:47:06 +0000
Bug 1732759 - Test updates. r=dholbert Mostly progressions, as expected, but there are two bits that deserve some attention: * First there are two table tests that regress (because we were treating fit-content like auto). However Chromium fails the non-tentative one also, just in a different way, so I think it's worth punting on changing table layout and go to the CSSWG to figure out if "auto" is the desired behavior here. * Second, there's another test that regresses (position-absolute-replaced-minmax.html) for the same reason, we used to treat the size as "auto". The test that regresses comes from a Chromium crash (https://bugs.chromium.org/p/chromium/issues/detail?id=1010798) and the relevant behavior different also affects other intrinsic keywords, so I don't think we should address it here, and is unlikely to be a common case in the wild if we hadn't hit this before with other unprefixed keywords IMO. In any case I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1732780 for this behavior difference to investigate later. * Third, I removed fit-content from min-{width,height}-invalid. They are valid sizing keywords in css-sizing-5, and they apply to these properties. Other browsers also parse it. Differential Revision: https://phabricator.services.mozilla.com/D126726
7905b23762e54a70534753cb8f3dfc850ed838a6: Bug 1732759 - Unprefix -moz-fit-content. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 28 Sep 2021 11:44:33 +0000 - rev 593436
Push 150449 by ealvarez@mozilla.com at Tue, 28 Sep 2021 11:47:06 +0000
Bug 1732759 - Unprefix -moz-fit-content. r=dholbert I'm not aware of any reason we shouldn't do this, as it is interoperable with other browsers, and it causes compat issues from sites that forget to use the prefixed version. Note this removes some #[parse(aliases)]. These only affect devtools autocomplete behavior, and we avoid autocompleting -moz-prefixed keywords when possible, so even though it's a slight behavior change, it's worth it. Differential Revision: https://phabricator.services.mozilla.com/D126718
132a81168ee1187d1f7d93caab12b798f6e37c7c: Bug 1732268 - Remove redundant failure-checks from nsLineIterator initialization, as it uses infallible allocation. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Fri, 24 Sep 2021 14:20:05 +0000 - rev 593159
Push 150323 by jkew@mozilla.com at Fri, 24 Sep 2021 14:22:47 +0000
Bug 1732268 - Remove redundant failure-checks from nsLineIterator initialization, as it uses infallible allocation. r=dholbert This means nsBlockFrame::GetLineIterator is also infallible, so callers that know they're dealing with an nsBlockFrame (not an arbitrary nsIFrame) don't need to check for null. Differential Revision: https://phabricator.services.mozilla.com/D126470
93c3353b48f11ca6b78f4fd027f4414816ab7bdb: Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Wed, 22 Sep 2021 23:02:36 +0000 - rev 593007
Push 150230 by emcdonough@mozilla.com at Wed, 22 Sep 2021 23:04:55 +0000
Bug 1723239 - Enable layout.css.page-size.enabled in Nightly r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D126161
55bc705a6b3fded43898f0ac9526ee847e90a6ec: Bug 1729861 - Add missing entry to gExactCallbackPrefs in nsPresContext.cpp. r=dholbert,emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 22 Sep 2021 12:41:25 +0000 - rev 592949
Push 150199 by jkew@mozilla.com at Wed, 22 Sep 2021 13:08:39 +0000
Bug 1729861 - Add missing entry to gExactCallbackPrefs in nsPresContext.cpp. r=dholbert,emilio This adds `privacy.resistFingerprinting` to the list of prefs for which `nsPresContext` registers a callback, because it is included among the prefs that `nsPresContext::PreferenceChanged` explicitly wants to handle. We also sort the `gExactCallbackPrefs` array, to make it easier to scan its contents at a glance in the future. layout.css.prefers-contrast.enabled is dropped from being handled in PreferenceChanged, because that doesn't actually work; we need to reload the document (re-parse the stylesheet) to notice the change. Differential Revision: https://phabricator.services.mozilla.com/D125857
19499821190df2a1577ba6250b05b806cdf8cbea: Bug 1591366 - Always reserve 64 bits for frame property value r=dholbert
Mats Palmgren <mats@mozilla.com> - Mon, 20 Sep 2021 19:52:46 +0000 - rev 592547
Push 150060 by sefeng@mozilla.com at Mon, 20 Sep 2021 19:55:13 +0000
Bug 1591366 - Always reserve 64 bits for frame property value r=dholbert Depends on D115711 Differential Revision: https://phabricator.services.mozilla.com/D124955
19be43686dc0bf6091d5002e684907dcf7fd0de5: Bug 1591366 - Always reserve 64 bits for frame property value r=dholbert
Mats Palmgren <mats@mozilla.com> - Fri, 17 Sep 2021 21:06:53 +0000 - rev 592406
Push 149972 by sefeng@mozilla.com at Fri, 17 Sep 2021 21:29:21 +0000
Bug 1591366 - Always reserve 64 bits for frame property value r=dholbert Depends on D115711 Differential Revision: https://phabricator.services.mozilla.com/D124955
3da0171aa06ec5a340f0568b9772a68cee5572a3: Bug 1700580 Part 4 - Cache flex item's border and padding used in the final reflow. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Sep 2021 05:54:09 +0000 - rev 592275
Push 149901 by aethanyc@gmail.com at Fri, 17 Sep 2021 05:56:43 +0000
Bug 1700580 Part 4 - Cache flex item's border and padding used in the final reflow. r=dholbert Currently, we assume any flex item with percentage padding will be marked as dirty if the percentage basis is changed. However, it is not true. To fix it, we cache the flex item's border and padding used in its most recent final reflow to detect their changes. dynamic-isize-change-004.html is designed to catch the concern in bug 1700580 comment 12. Differential Revision: https://phabricator.services.mozilla.com/D125620
c645fe62180e3e136e37b9f10db038036b2a121d: Bug 1700580 Part 3 - Rename dynamic-isize-change.html to dynamic-isize-change-001.html. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Sep 2021 05:54:09 +0000 - rev 592274
Push 149901 by aethanyc@gmail.com at Fri, 17 Sep 2021 05:56:43 +0000
Bug 1700580 Part 3 - Rename dynamic-isize-change.html to dynamic-isize-change-001.html. r=dholbert We'll add more isize change test to wpt in the next part. Differential Revision: https://phabricator.services.mozilla.com/D124968
45519af7e8d2b746f0b0fc495228f438b10c1572: Bug 1700580 Part 2 - Add a helper class to cache flex item's metrics in its most recent reflow. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Sep 2021 05:54:08 +0000 - rev 592273
Push 149901 by aethanyc@gmail.com at Fri, 17 Sep 2021 05:56:43 +0000
Bug 1700580 Part 2 - Add a helper class to cache flex item's metrics in its most recent reflow. r=dholbert This patch introduces a class that caches metrics in flex item's final reflow. With it, we have a better symmetry for caches, one for measuring reflow and the other for final reflow. Also, we don't have to explain that mLastReflowTreatedBSizeAsIndefinite is only meaningful if mFinalReflowSize is set. Differential Revision: https://phabricator.services.mozilla.com/D124967
9e34694e8c9b706424f46243bce6620b8430df04: Bug 1700580 Part 1 - Unify CachedFlexItemData's APIs that update the existing cache. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 17 Sep 2021 05:54:08 +0000 - rev 592272
Push 149901 by aethanyc@gmail.com at Fri, 17 Sep 2021 05:56:43 +0000
Bug 1700580 Part 1 - Unify CachedFlexItemData's APIs that update the existing cache. r=dholbert Add `CachedFlexItemData::Update()` with the same arguments as the constructor to update the existing cache for both the measuring & final reflow. `mFinalReflowSize` is going to be renamed in a later patch, so I also change `UpdateFinalReflowSize()` to `Update()` for consistency with the new API. Differential Revision: https://phabricator.services.mozilla.com/D124966
e007ff5728404f97b54a52c6ccf6c70063833f74: Bug 1730506 - Tweak the assertion again to recognize integer overflow due to huge main gap size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 16 Sep 2021 23:06:37 +0000 - rev 592267
Push 149896 by aethanyc@gmail.com at Thu, 16 Sep 2021 23:09:01 +0000
Bug 1730506 - Tweak the assertion again to recognize integer overflow due to huge main gap size. r=dholbert Similar to bug 1728319, a huge main gap size can also make SumOfGaps() negative due to integer overflow. This patch is to recognize that scenario. We still need to annotate the crashtest because it still triggers the following assertion in nsIFrame. ``` ASSERTION: inline-size less than zero: 'result >= 0' ``` Differential Revision: https://phabricator.services.mozilla.com/D125778
7caa44235055bc75d8c039491b167a7ce26a2523: Bug 1729935 - Remove unused layout.smaller-painted-layers. r=dholbert
Tetsuharu Ohzeki <tetsuharu.ohzeki@gmail.com> - Thu, 09 Sep 2021 17:06:33 +0000 - rev 591552
Push 149481 by tetsuharu.ohzeki@gmail.com at Thu, 09 Sep 2021 17:08:55 +0000
Bug 1729935 - Remove unused layout.smaller-painted-layers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D125091
4ed1222e42887c69f6367638cdd1d29a13b6ba1c: Bug 1413836 - Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert
Sean Feng <sefeng@mozilla.com> - Tue, 07 Sep 2021 15:01:37 +0000 - rev 591226
Push 149307 by sefeng@mozilla.com at Tue, 07 Sep 2021 15:56:19 +0000
Bug 1413836 - Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert When the `FAIL` text goes away, there could be some antialiased fringe left which caused the test to fail. Use Ahem font to reduce likelihood of this happening again. Depends on D124067 Differential Revision: https://phabricator.services.mozilla.com/D124423
737edd21c6e23765f4b8a30da43adb7e93a9035a: Bug 1728319 - Tweak an assertion to recognize integer overflow due to huge margin/border/padding. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Fri, 03 Sep 2021 21:23:52 +0000 - rev 591011
Push 149192 by aethanyc@gmail.com at Fri, 03 Sep 2021 21:26:16 +0000
Bug 1728319 - Tweak an assertion to recognize integer overflow due to huge margin/border/padding. r=dholbert We could fix the testcase in this patch by promoting `FlexLine::mTotalItemMBP` to `AuCoord64`, but then `layout/generic/crashtests/1488762-1.html` will start crashing. It is because `FlexItem::OuterMainSize()` can return negative size due to integer overflow, and the negative sizes will accumulate in `mTotalOuterHypotheticalMainSize`. Instead of promoting more variables to `AuCoord64` to workaround huge margin/border/padding that we cannot handle gracefully, this patch tweaks the assertion to check only if `mTotalOuterHypotheticalMainSize` and `mTotalItemMBP` have valid values. Differential Revision: https://phabricator.services.mozilla.com/D124409
33201f50cb0636879d3ff55fe1594a63dd320ea7: Bug 1729055 - Provide a webfont for text-decoration-skip-ink-005.html in case no CJK font is present on the system. r=dholbert
Jonathan Kew <jkew@mozilla.com> - Fri, 03 Sep 2021 17:59:12 +0000 - rev 590979
Push 149169 by jkew@mozilla.com at Fri, 03 Sep 2021 18:22:34 +0000
Bug 1729055 - Provide a webfont for text-decoration-skip-ink-005.html in case no CJK font is present on the system. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D124478
53c86681259e185c9c44465b4ff2851757bb2e3b: Bug 1413836 - Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert
Sean Feng <sefeng@mozilla.com> - Fri, 03 Sep 2021 13:32:28 +0000 - rev 590943
Push 149146 by sefeng@mozilla.com at Fri, 03 Sep 2021 13:35:39 +0000
Bug 1413836 - Use Ahem font to avoid antialiased fringe for focus-pseudo-on-shadow-host-2.html r=dholbert When the `FAIL` text goes away, there could be some antialiased fringe left which caused the test to fail. Use Ahem font to reduce likelihood of this happening again. Differential Revision: https://phabricator.services.mozilla.com/D124423
5099d603c2cb0b065316df5a36df152c04213998: Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 Sep 2021 08:56:43 +0000 - rev 590896
Push 149131 by ealvarez@mozilla.com at Fri, 03 Sep 2021 08:59:13 +0000
Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr Also, more directly go from StyleImageRendering to wr::ImageRendering. * image-rendering: smooth the non-deprecated version of OptimizeQuality, which maps to SamplingFilter::LINEAR / wr::ImageRendering::Auto (which uses gl::LINEAR). * image-rendering: pixelated maps to wr::ImageRendering::Pixelated / SamplingFilter::POINT which is the same crisp-edges does. Note that this uncovers that we were mapping image-rendering: crisp-edges to wr::ImageRendering::Pixelated. I'm going to preserve behavior on this patch but we should consider switching that to map to wr::ImageRendering::CrispEdges on a follow-up (filed bug 1728831 for this). Differential Revision: https://phabricator.services.mozilla.com/D124378
7dd1d9e0bc8c81cbc1d9de7f77f664490a63c671: Bug 856337 - Move image-rendering out of mako. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 03 Sep 2021 08:56:42 +0000 - rev 590895
Push 149131 by ealvarez@mozilla.com at Fri, 03 Sep 2021 08:59:13 +0000
Bug 856337 - Move image-rendering out of mako. r=dholbert It's easier to touch in the future that way, even though the derive list is massive. Differential Revision: https://phabricator.services.mozilla.com/D124377
7070c7cea8ece38a2e7b07d4fbe71a2ad53c0490: Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 Sep 2021 20:28:39 +0000 - rev 590876
Push 149113 by ealvarez@mozilla.com at Thu, 02 Sep 2021 20:33:10 +0000
Bug 856337 - Implement image-rendering: smooth and image-rendering: pixelated. r=jrmuizel,dholbert,longsonr Also, more directly go from StyleImageRendering to wr::ImageRendering. * image-rendering: smooth the non-deprecated version of OptimizeQuality, which maps to SamplingFilter::LINEAR / wr::ImageRendering::Auto (which uses gl::LINEAR). * image-rendering: pixelated maps to wr::ImageRendering::Pixelated / SamplingFilter::POINT which is the same crisp-edges does. Note that this uncovers that we were mapping image-rendering: crisp-edges to wr::ImageRendering::Pixelated. I'm going to preserve behavior on this patch but we should consider switching that to map to wr::ImageRendering::CrispEdges on a follow-up (filed bug 1728831 for this). Differential Revision: https://phabricator.services.mozilla.com/D124378
edc12b36439fc3f9d0c3bc300a17a97def19e3bb: Bug 856337 - Move image-rendering out of mako. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 02 Sep 2021 20:28:39 +0000 - rev 590875
Push 149113 by ealvarez@mozilla.com at Thu, 02 Sep 2021 20:33:10 +0000
Bug 856337 - Move image-rendering out of mako. r=dholbert It's easier to touch in the future that way, even though the derive list is massive. Differential Revision: https://phabricator.services.mozilla.com/D124377
3a84e5a0089d301f192dbbc382f181438241d40c: Bug 1728411 - Stop special casing bounds calculation on Windows. r=dholbert
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 01 Sep 2021 03:11:36 +0000 - rev 590425
Push 148947 by jmuizelaar@mozilla.com at Wed, 01 Sep 2021 03:14:01 +0000
Bug 1728411 - Stop special casing bounds calculation on Windows. r=dholbert As of bug 1728401, D2D is no longer used as content backend on Windows, which makes this special casing unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D124110
bb78095fd8c02562ddcb3b3fe2d666f9daf91b01: Bug 1728411 - Stop special casing bounds calculation on Windows. r=dholbert
Jeff Muizelaar <jmuizelaar@mozilla.com> - Wed, 01 Sep 2021 01:03:11 +0000 - rev 590418
Push 148940 by jmuizelaar@mozilla.com at Wed, 01 Sep 2021 01:05:33 +0000
Bug 1728411 - Stop special casing bounds calculation on Windows. r=dholbert As of bug 1728401 D2D is no longer used as content backend on Windows, which makes this special casing unnecessary. Differential Revision: https://phabricator.services.mozilla.com/D124110
4fcd1b02c5bdfdb3d4e9b8d8b93289f81c638981: Bug 1725973 Part 2 - Mark flex items with percentage flex-basis in column flex container as depending on CB's block-size. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 26 Aug 2021 22:43:10 +0000 - rev 590106
Push 148730 by aethanyc@gmail.com at Thu, 26 Aug 2021 22:45:38 +0000
Bug 1725973 Part 2 - Mark flex items with percentage flex-basis in column flex container as depending on CB's block-size. r=dholbert If so, `dependsOnCBBSize` will be set to true, and later in `ReflowInput::InitResizeFlags()` we will add `NS_FRAME_CONTAINS_RELATIVE_BSIZE` to the appropriate ancestor. Sorted the #include statements in ReflowInput.cpp because I added nsFlexContainerFrame.h. Differential Revision: https://phabricator.services.mozilla.com/D123703
3bbec943b9a4fcf84f917e682ba54a56046196eb: Bug 1725973 Part 1 - Add a FLEX_LOG in MoveFlexItemToFinalPosition(). r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Thu, 26 Aug 2021 22:43:09 +0000 - rev 590105
Push 148730 by aethanyc@gmail.com at Thu, 26 Aug 2021 22:45:38 +0000
Bug 1725973 Part 1 - Add a FLEX_LOG in MoveFlexItemToFinalPosition(). r=dholbert Make it easier to spot a flex item is being moved to the final position rather than going through the final reflow. Differential Revision: https://phabricator.services.mozilla.com/D123702
abdafabdceecb71513ac434c4170db70afd412c9: Bug 1469649 Part 3 - Upgrade the assertion to MOZ_ASSERT, and update its comments. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Aug 2021 06:43:34 +0000 - rev 589869
Push 148593 by aethanyc@gmail.com at Wed, 25 Aug 2021 06:47:00 +0000
Bug 1469649 Part 3 - Upgrade the assertion to MOZ_ASSERT, and update its comments. r=dholbert The assertion is testing the sign of `availableFreeSpace` and `isUsingFlexGrow`. After we use 64-bit arithmetic, it's likely that the stronger assertion holds. Differential Revision: https://phabricator.services.mozilla.com/D123519
f0b07571b559937fe98300d7da187b2043ac9e91: Bug 1469649 Part 2 - Use 64-bit coord type when resolving the main size for flex items. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Aug 2021 06:43:34 +0000 - rev 589868
Push 148593 by aethanyc@gmail.com at Wed, 25 Aug 2021 06:47:00 +0000
Bug 1469649 Part 2 - Use 64-bit coord type when resolving the main size for flex items. r=dholbert The idea of this patch is to use 64-bit coord type when resolving the main size for flex items to avoid integer overflow when individual flex items have huge hypothetical main sizes, which can happen with percent-width table-layout:fixed descendants. We have to avoid integer overflow to shrink flex items properly in that scenario. Delete the "Note:" in `AddLastItemToMainSizeTotals()` since we remove `AddChecked()` in favor of regular 64-bit addition for `mTotalOuterHypotheticalMainSize`. The wpt testcase is adapted from bug 1469649 comment 12. Differential Revision: https://phabricator.services.mozilla.com/D123268
be6f1ddbc7439914fcba7b2becd681b59b5c9690: Bug 1469649 Part 1 - Promote floating point precision when computing the weight of flex items. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Wed, 25 Aug 2021 06:43:33 +0000 - rev 589867
Push 148593 by aethanyc@gmail.com at Wed, 25 Aug 2021 06:47:00 +0000
Bug 1469649 Part 1 - Promote floating point precision when computing the weight of flex items. r=dholbert The precision of `double` is needed when we are distributing large `sizeDelta` via `availableFreeSpace * myShareOfRemainingSpace`. Without this patch, the wpt test added in Part 2 will fail. Differential Revision: https://phabricator.services.mozilla.com/D123267
a030e70b6c062dabffaafab83beb85dc7fd33601: Bug 1726396 - Update getComputedStyle pseudo-element behavior. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Aug 2021 23:59:30 +0000 - rev 589641
Push 148484 by ealvarez@mozilla.com at Tue, 24 Aug 2021 00:02:20 +0000
Bug 1726396 - Update getComputedStyle pseudo-element behavior. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D122978
8d4dcff0df0e723e56b8fee33bdb2b47bfa9b866: Bug 1726182 - Add a use counter for content-visibility. r=dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 17 Aug 2021 18:25:11 +0000 - rev 589150
Push 148178 by ealvarez@mozilla.com at Tue, 17 Aug 2021 18:27:35 +0000
Bug 1726182 - Add a use counter for content-visibility. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D122873
8397357bef1f70c89abf08cb45b355bde449068a: Bug 1678089 - Trigger the test function after the child document received the load event. r=dholbert
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Sat, 14 Aug 2021 22:55:17 +0000 - rev 589000
Push 148075 by hikezoe.birchill@mozilla.com at Sat, 14 Aug 2021 22:57:39 +0000
Bug 1678089 - Trigger the test function after the child document received the load event. r=dholbert Though the test funtion is called twice since the parent document reloads the iframe document, but the test will not run for the second call since it's prevented by `testRunning` flag in test_bug851485.html. Differential Revision: https://phabricator.services.mozilla.com/D122662
c69cd7bad3a9dfafa466d239d0e90f9e498ba1af: Bug 1722890 Part 2 - Add disabled print preview test for scaled content on the edge of the clipping rect r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 12 Aug 2021 23:31:20 +0000 - rev 588776
Push 147995 by emcdonough@mozilla.com at Thu, 12 Aug 2021 23:33:49 +0000
Bug 1722890 Part 2 - Add disabled print preview test for scaled content on the edge of the clipping rect r=dholbert Scaling currently doesn't work in print preview tests. This adds a test that will begin to fail if scaling gets fixed, to tell us to enable the actual scaled content test instead. See bug 1725486 for the scaling issue. Differential Revision: https://phabricator.services.mozilla.com/D122292
b660fa9270e340c1e34b0b570f3a3573c5cbf42e: Bug 1722890 Part 1 - Apply page scaling to the clipping rect for page content frames r=dholbert
Emily McDonough <emcdonough@mozilla.com> - Thu, 12 Aug 2021 23:31:19 +0000 - rev 588775
Push 147995 by emcdonough@mozilla.com at Thu, 12 Aug 2021 23:33:49 +0000
Bug 1722890 Part 1 - Apply page scaling to the clipping rect for page content frames r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D122291
99e249810495d252d478908c1e8333b6a3673c4e: Bug 1611303 - Always assume a flex item needs a block-axis resize in final reflow. r=dholbert
Ting-Yu Lin <tlin@mozilla.com> - Tue, 10 Aug 2021 21:43:14 +0000 - rev 588527
Push 147852 by aethanyc@gmail.com at Tue, 10 Aug 2021 22:13:33 +0000
Bug 1611303 - Always assume a flex item needs a block-axis resize in final reflow. r=dholbert In an incremental reflow, if a flex item has a valid bsize cache , we skip its measuring reflow. However, we may still need to set relevant bsize flags if the flex container is changing its definiteness in the block-axis. See bug 1611303 comment 2 for an analysis. This patch is playing safe by always calling SetHasBSizeChange() if we override bsize for the item. Of course this can be solved in a more sophisticated way by checking whether the item really has a block-axis resize, but that means we'll need to duplicate a lot of logic in FlexItem::NeedsFinalReflow(). Differential Revision: https://phabricator.services.mozilla.com/D122041