searching for reviewer(davidwalsh)
d405787748879c258680b966070dcee9b6472330: Bug 1642769 - Show TypeScript icon for .tsx extension. r=davidwalsh
Varun Dey <varundey20@gmail.com> - Fri, 07 Aug 2020 20:36:18 +0000 - rev 543848
Push 123722 by dwalsh@mozilla.com at Fri, 07 Aug 2020 20:38:44 +0000
Bug 1642769 - Show TypeScript icon for .tsx extension. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D86141
9aa1f63be136653ceb6500080392f14c09976c06: Bug 917963 - Implement break on first script statement. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Tue, 04 Aug 2020 18:46:48 +0000 - rev 543262
Push 123349 by dwalsh@mozilla.com at Tue, 04 Aug 2020 18:51:38 +0000
Bug 917963 - Implement break on first script statement. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D85198
06949fab0b88274bdb19e0c1346d216cd92daa69: Bug 1656726 - Pause On Exceptions, DOM mutation breakpoints, debugger statements pause in blackboxed original sources r=davidwalsh
wartmanm <wartmanm@tutanota.com> - Tue, 04 Aug 2020 18:41:53 +0000 - rev 543260
Push 123347 by dwalsh@mozilla.com at Tue, 04 Aug 2020 18:48:08 +0000
Bug 1656726 - Pause On Exceptions, DOM mutation breakpoints, debugger statements pause in blackboxed original sources r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D85718
b97a46258d1183f62e68af873a591f7c6e893a54: Bug 1656035 - Remove CSS rule that wraps directory root header on to multiple lines r=davidwalsh
Kyle Knaggs <kyleknaggs@gmail.com> - Mon, 03 Aug 2020 14:30:32 +0000 - rev 543127
Push 123243 by dwalsh@mozilla.com at Mon, 03 Aug 2020 14:33:10 +0000
Bug 1656035 - Remove CSS rule that wraps directory root header on to multiple lines r=davidwalsh Before this change whenever the directory root header extends to the edge of the Primary pane a `flex-wrap` CSS rule in the `.sources-clear-root` selector breaks the directory root header text on to multiple lines. This patch removes this rule and fixes this bug. {F2380491} Differential Revision: https://phabricator.services.mozilla.com/D85400
fe257d5e4151803357e94df0dada486395ea6c43: Bug 1591143 - Use text in Sources UI to generate header after setting directory root r=davidwalsh
Kyle Knaggs <kyleknaggs@gmail.com> - Fri, 24 Jul 2020 15:57:42 +0000 - rev 542476
Push 122902 by dwalsh@mozilla.com at Wed, 29 Jul 2020 16:20:42 +0000
Bug 1591143 - Use text in Sources UI to generate header after setting directory root r=davidwalsh Before this Work In Progress patch, the text that was displayed next to the home icon after a user sets directory root was generated using `state.sources.projectDirectoryRoot`. This was done in an attempt to reverse engineer the text that was displayed for the corresponding item in the Sources UI. This patch removes the logic that was responsible for this. Instead, it ensures that the text next to the home icon matches the text that was displayed in the Sources UI by using the existing event handler to pass the text that is displayed in the Sources UI to the Redux store whenever a user sets directory root. The text is then passed back down to the Primary Panes UI where it is displayed as the header after a user sets directory root. The test suites in `PrimaryPanes.spec.js` and `setProjectDirectoryRoot.spec.js` will be updated before a final patch for this issue is submitted. {F2352986} Differential Revision: https://phabricator.services.mozilla.com/D83839
6ac9edc64fe58b7de451c9a1bd82b673d66ca54d: Bug 1651402 - Use obj.isError instead of obj.class='Error' in DevTools code. r=davidwalsh
nchevobbe <nchevobbe@mozilla.com> - Mon, 27 Jul 2020 15:48:16 +0000 - rev 542229
Push 122718 by nchevobbe@mozilla.com at Mon, 27 Jul 2020 19:48:20 +0000
Bug 1651402 - Use obj.isError instead of obj.class='Error' in DevTools code. r=davidwalsh Depends on D82876 Differential Revision: https://phabricator.services.mozilla.com/D84958
feb3ad4b4a25f6935423d38b95866b0f488e03ff: Bug 1654762 - Use traits to detect DevTools storage actor supported methods r=nchevobbe,davidwalsh
Julian Descottes <jdescottes@mozilla.com> - Fri, 24 Jul 2020 18:07:14 +0000 - rev 542090
Push 122630 by jdescottes@mozilla.com at Fri, 24 Jul 2020 18:18:20 +0000
Bug 1654762 - Use traits to detect DevTools storage actor supported methods r=nchevobbe,davidwalsh This is the only meaningful callsite for actorHasMethod. This method has many bugs and we want to replace it with traits Differential Revision: https://phabricator.services.mozilla.com/D84689
a5f75b9f575b2dc4cdede4bda3eaf9f35ff6640e: Bug 1653785 - [RTL] Fix the twisty direction when collapsed for the stack trace tooltip r=davidwalsh
Itiel <itiel_yn8@walla.com> - Mon, 20 Jul 2020 17:24:41 +0000 - rev 541301
Push 122160 by dwalsh@mozilla.com at Mon, 20 Jul 2020 17:35:09 +0000
Bug 1653785 - [RTL] Fix the twisty direction when collapsed for the stack trace tooltip r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D84097
f65bc98a26f25002e5921ba1e51a77b05882d600: Bug 1648060 - start-panel sidebar prevented from being dragged wider than the available width. r=davidwalsh,bomsy
alexdominguezg <alexand.dominguez@gmail.com> - Fri, 17 Jul 2020 20:49:52 +0000 - rev 541010
Push 122033 by dwalsh@mozilla.com at Fri, 17 Jul 2020 21:00:32 +0000
Bug 1648060 - start-panel sidebar prevented from being dragged wider than the available width. r=davidwalsh,bomsy I have added a helper method, calcStartPanelWidth(), to limit the start-panel on expansion. Differential Revision: https://phabricator.services.mozilla.com/D80863
c527adb07983f97ec26bd61b78ae21965cfab74e: Bug 1652679 - Generate consistent URLs when pretty-printing anonymous sources. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Fri, 17 Jul 2020 14:55:39 +0000 - rev 540944
Push 122004 by loganfsmyth@gmail.com at Fri, 17 Jul 2020 16:09:39 +0000
Bug 1652679 - Generate consistent URLs when pretty-printing anonymous sources. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D83724
bafe2419af675274b2ac6385a9fb43e1acfac0be: Bug 1643633 - Add a stack trace to the exception tooltip r=davidwalsh
Stepan Stava <stepanstava@gmail.com> - Fri, 17 Jul 2020 15:15:55 +0000 - rev 540937
Push 121998 by dwalsh@mozilla.com at Fri, 17 Jul 2020 15:16:27 +0000
Bug 1643633 - Add a stack trace to the exception tooltip r=davidwalsh Adds a stacktrace to the exception popup of the inline exceptions in the debugger. Matches the styles of the console error messages. The popup works in two modes: - when the stacktrace is closed the exception popup gets closed when the mouse leaves the popup. - when the stacktrace is opened the exception popup gets closed only by clicking outside the popup. Differential Revision: https://phabricator.services.mozilla.com/D82690
ecd90946b978f283765d1c283d6afd676f6c65a2: Bug 1608633 - Fix ability to use scrollbar in conditional panel r=davidwalsh
Krishnal Ciccolella <shellyc23@hotmail.com> - Thu, 16 Jul 2020 15:05:31 +0000 - rev 540754
Push 121893 by dwalsh@mozilla.com at Thu, 16 Jul 2020 15:51:56 +0000
Bug 1608633 - Fix ability to use scrollbar in conditional panel r=davidwalsh This patch addresses bug 1608633. It adds an if statement to `ConditionalPanel.js`, that prevents the conditional panel from closing when clicking on its scrollbar. Differential Revision: https://phabricator.services.mozilla.com/D82187
5202ada0cf1dd734b34338c11390c772a2f63cbe: Bug 1196089 - Treat javascript: scripts as anonymous sources. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Tue, 14 Jul 2020 15:04:59 +0000 - rev 540428
Push 121704 by loganfsmyth@gmail.com at Tue, 14 Jul 2020 16:55:57 +0000
Bug 1196089 - Treat javascript: scripts as anonymous sources. r=davidwalsh Depends on D83410 Differential Revision: https://phabricator.services.mozilla.com/D83411
4b2c7b2f3222707846e436085c4a4627172e1c70: Bug 1196089 - Treat script sources introduced by DOM timers as anonymous. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Tue, 14 Jul 2020 15:03:53 +0000 - rev 540427
Push 121704 by loganfsmyth@gmail.com at Tue, 14 Jul 2020 16:55:57 +0000
Bug 1196089 - Treat script sources introduced by DOM timers as anonymous. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D83410
7737fa6723d6c778ce33f43b3acdd83d5c491d85: Bug 1652608 - Remove usage of nonexistent hostAnnotations property. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Tue, 14 Jul 2020 15:13:31 +0000 - rev 540426
Push 121703 by loganfsmyth@gmail.com at Tue, 14 Jul 2020 16:55:17 +0000
Bug 1652608 - Remove usage of nonexistent hostAnnotations property. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D83421
f0e848b64e2531610a1874fd838c6d6f2836cd7b: Bug 1650658 - Pass line and column position as numbers instead of strings. r=davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Mon, 13 Jul 2020 17:05:29 +0000 - rev 540253
Push 121575 by loganfsmyth@gmail.com at Mon, 13 Jul 2020 18:26:38 +0000
Bug 1650658 - Pass line and column position as numbers instead of strings. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D82950
b74a89903c5abcd81ca4e6ab83283c44923e7cef: Bug 1645887 - Fix text copied by 'Copy to clipboard' and 'Copy source text' context menu items r=davidwalsh
Kyle Knaggs <kyleknaggs@gmail.com> - Wed, 08 Jul 2020 14:40:29 +0000 - rev 539379
Push 121086 by dwalsh@mozilla.com at Wed, 08 Jul 2020 14:41:02 +0000
Bug 1645887 - Fix text copied by 'Copy to clipboard' and 'Copy source text' context menu items r=davidwalsh This patch addresses the issue reported by [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1645887 | Bug 1645887 ]] where the context menu items in the `Editor` were not copying the expected text to the clipboard. Regarding the context menu in the `Editor` this patch modifies the menu items so that: 1. 'Copy to clipboard' => Copies the text that has been selected by a user to the clipboard. 2. 'Copy source text' => Copies all of the text from a source to the clipboard. In addition to the above fix, this patch also modifies a related item in the `Tab` context menu so that: 1. The text for the ‘Copy to clipboard’ menu item is now replaced with ‘Copy source text’. As with the context menu in the `Editor`, the pre-existing ‘Copy to clipboard’ menu item in the `Tab` copied all of the text from a source to the clipboard. However, instead of modifying the functionality of this menu item, the decision was made to replace the ‘Copy to clipboard’ text with ‘Copy source text’. This was done as the `Tab` and its context menu typically provides the user with general information about the file being displayed instead of being concerned with details such as the state of the editor. {F2332380} Differential Revision: https://phabricator.services.mozilla.com/D81887
4fa79b8f6fa9cf4fbf2d6b5f11e3ebd3cd939018: Bug 1618059 - Extract the storage extension live reload test r=ochameau,davidwalsh
Julian Descottes <jdescottes@mozilla.com> - Thu, 02 Jul 2020 15:56:00 +0000 - rev 538475
Push 120602 by jdescottes@mozilla.com at Thu, 02 Jul 2020 15:58:13 +0000
Bug 1618059 - Extract the storage extension live reload test r=ochameau,davidwalsh The failure only occurs locally when I use an attached target for the test_panel_live_reload mochitest. And it only happens if we perform the `extension.upgrade` call during the test. Most of the time it seems linked to a "frameUpdated" event fired when the webextension is being updated. But even after commenting out the event, the test remains intermittent (albeit with a much lower frequency) A first option would be to expose a new API on the webextension descriptor front in order to create detached targets. But it seems that isolating the live_reload test in a dedicated file also fixes the intermittent. It makes the fix a bit obscure, and it probably means we won't look into the issue much furhter but I would prefer to avoid test-only APIs in the codebase. Differential Revision: https://phabricator.services.mozilla.com/D81322
c00459529ec8f276eaccf4e72563b65a155b6ef6: Bug 1642397 - Part 3: Show query string in SourcesTree when files conflict. r=jlast,davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Mon, 29 Jun 2020 18:51:57 +0000 - rev 538045
Push 120368 by loganfsmyth@gmail.com at Tue, 30 Jun 2020 16:00:47 +0000
Bug 1642397 - Part 3: Show query string in SourcesTree when files conflict. r=jlast,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D81268
fa25bc61d9975962c44db58467c3c5b66c7a5028: Bug 1642397 - Part 2: Only pass sources-tree a query param if it should use it. r=jlast,davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Fri, 26 Jun 2020 20:04:36 +0000 - rev 538044
Push 120368 by loganfsmyth@gmail.com at Tue, 30 Jun 2020 16:00:47 +0000
Bug 1642397 - Part 2: Only pass sources-tree a query param if it should use it. r=jlast,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D81267
b240470c554bec26503f6131110b8bc9c61f227f: Bug 1642397 - Part 1: Handle unparseable URLs more consistently and handle query params. r=jlast,davidwalsh
Logan Smyth <loganfsmyth@gmail.com> - Fri, 26 Jun 2020 19:27:54 +0000 - rev 538043
Push 120368 by loganfsmyth@gmail.com at Tue, 30 Jun 2020 16:00:47 +0000
Bug 1642397 - Part 1: Handle unparseable URLs more consistently and handle query params. r=jlast,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D81266
225ed163bd8dd0e6957344fbab414ad43027d9e2: Bug 1643822 - getTextAtLine should not use split. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Mon, 08 Jun 2020 18:21:52 +0000 - rev 534473
Push 118364 by jlaster@mozilla.com at Mon, 08 Jun 2020 18:23:36 +0000
Bug 1643822 - getTextAtLine should not use split. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D78576
142b2d7350f47c33599816c4670e9cd412f0db4b: Bug 1642730 - Fix intermittent on browser_jsterm_autocomplete_null. r=davidwalsh.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 08 Jun 2020 15:21:15 +0000 - rev 534428
Push 118335 by nchevobbe@mozilla.com at Mon, 08 Jun 2020 15:35:20 +0000
Bug 1642730 - Fix intermittent on browser_jsterm_autocomplete_null. r=davidwalsh. Now that network requests can be displayed as error (for 4XX and 5XX), this test could get one of those and think we were getting an actual js error, which makes the test fail. Excluding network messages from the messages we are checking should fix the intermittent. Differential Revision: https://phabricator.services.mozilla.com/D78493
e6d1fb1401f00bb5159b87a92d60268fb786026d: Bug 1599978 - Stores clientX as state.width for start-panel and the difference between clientWidth and clientX for end-panel. r=bomsy,davidwalsh
alexdominguezg <alexand.dominguez@gmail.com> - Tue, 02 Jun 2020 16:10:11 +0000 - rev 533548
Push 117808 by hmanilla@mozilla.com at Tue, 02 Jun 2020 16:26:21 +0000
Bug 1599978 - Stores clientX as state.width for start-panel and the difference between clientWidth and clientX for end-panel. r=bomsy,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D73381
85f7bbd8cf9316564183febe3522348cfa56e0d0: Bug 1641898 - Fix layout inconsistencies for readonly URLs in about:devtools-toolbox r=daisuke,davidwalsh
Julian Descottes <jdescottes@mozilla.com> - Tue, 02 Jun 2020 08:28:06 +0000 - rev 533452
Push 117759 by jdescottes@mozilla.com at Tue, 02 Jun 2020 08:29:10 +0000
Bug 1641898 - Fix layout inconsistencies for readonly URLs in about:devtools-toolbox r=daisuke,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D77484
c8a7ccb337cce55055ef3a7727df44c85b1abea8: Bug 1641898 - Fix layout inconsistencies for readonly URLs in about:devtools-toolbox r=daisuke,davidwalsh
Julian Descottes <jdescottes@mozilla.com> - Mon, 01 Jun 2020 14:18:35 +0000 - rev 533436
Push 117745 by jdescottes@mozilla.com at Tue, 02 Jun 2020 05:57:48 +0000
Bug 1641898 - Fix layout inconsistencies for readonly URLs in about:devtools-toolbox r=daisuke,davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D77484
4f075f06004d2ae96f22413fd051e9feadd63bea: Bug 1641731 - Prefer pausing in original locations. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Fri, 29 May 2020 15:23:30 +0000 - rev 533036
Push 117522 by jlaster@mozilla.com at Fri, 29 May 2020 17:17:31 +0000
Bug 1641731 - Prefer pausing in original locations. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D77158
1393662c8ab88f30c115e7a61192f5a050d81da7: Bug 1637687 - Catch push subscription actor errors in about:debugging r=davidwalsh,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 29 May 2020 06:06:58 +0000 - rev 532915
Push 117458 by jdescottes@mozilla.com at Fri, 29 May 2020 08:17:29 +0000
Bug 1637687 - Catch push subscription actor errors in about:debugging r=davidwalsh,daisuke Depends on D75905 Differential Revision: https://phabricator.services.mozilla.com/D75906
dde01bd41c4d0d660b8dbfeee8a1fc4c60ce9c6e: Bug 1637687 - Remove lastPush/pushCount from PushSubscriptionActor as they are not supported on GeckoView r=davidwalsh,daisuke
Julian Descottes <jdescottes@mozilla.com> - Fri, 29 May 2020 06:08:55 +0000 - rev 532914
Push 117458 by jdescottes@mozilla.com at Fri, 29 May 2020 08:17:29 +0000
Bug 1637687 - Remove lastPush/pushCount from PushSubscriptionActor as they are not supported on GeckoView r=davidwalsh,daisuke Differential Revision: https://phabricator.services.mozilla.com/D75905
079826b74356c53b5a396c57d029dfd0647fbd4d: Bug 1635360 - Fix :screenshot --help command. r=davidwalsh.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Wed, 27 May 2020 14:42:29 +0000 - rev 532749
Push 117349 by nchevobbe@mozilla.com at Thu, 28 May 2020 10:02:53 +0000
Bug 1635360 - Fix :screenshot --help command. r=davidwalsh. This was regressed by Bug 766661, and it highlighted that we're missing test coverage for this, so this test is adding a test case to prevent future breakage. Differential Revision: https://phabricator.services.mozilla.com/D76676
0b15f53e5fc77898c06c1f25d0db4a688028b805: Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 17:13:59 +0000 - rev 532110
Push 116999 by jdescottes@mozilla.com at Mon, 25 May 2020 23:13:07 +0000
Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau Depends on D75902 Differential Revision: https://phabricator.services.mozilla.com/D75904
a8a1167da0689af0987ebb92f4b9ed6c0b7c9150: Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 16:29:24 +0000 - rev 532109
Push 116999 by jdescottes@mozilla.com at Mon, 25 May 2020 23:13:07 +0000
Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau Differential Revision: https://phabricator.services.mozilla.com/D75902
2964f445c2f53b8eb091e23d51486dd12202c52f: Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 12:49:10 +0000 - rev 531909
Push 116953 by jdescottes@mozilla.com at Mon, 25 May 2020 12:50:30 +0000
Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau Depends on D75902 Differential Revision: https://phabricator.services.mozilla.com/D75904
84be772b9ac483356f7ae17ccea2e5c701eadaa2: Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 12:48:32 +0000 - rev 531908
Push 116953 by jdescottes@mozilla.com at Mon, 25 May 2020 12:50:30 +0000
Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau Differential Revision: https://phabricator.services.mozilla.com/D75902
7ca3266213e7198f0c59df5f9ed841ab8d5ceca6: Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 09:47:23 +0000 - rev 531876
Push 116930 by jdescottes@mozilla.com at Mon, 25 May 2020 09:48:09 +0000
Bug 1639111 - Show the filename, line and column for DevTools actor errors r=davidwalsh,ochameau Depends on D75902 Differential Revision: https://phabricator.services.mozilla.com/D75904
55df4479027c3aeb8ef4be555b9475df5d82d0d3: Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau
Julian Descottes <jdescottes@mozilla.com> - Mon, 25 May 2020 09:46:57 +0000 - rev 531875
Push 116930 by jdescottes@mozilla.com at Mon, 25 May 2020 09:48:09 +0000
Bug 1639111 - Fallback on error.name in DevTools actor error handling r=davidwalsh,ochameau Differential Revision: https://phabricator.services.mozilla.com/D75902
3978210495447999e98a443aa838a934270cda2b: Bug 1630776 - Framework groups should be split by async separators. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 20 May 2020 20:53:40 +0000 - rev 531379
Push 116615 by jlaster@mozilla.com at Thu, 21 May 2020 00:08:19 +0000
Bug 1630776 - Framework groups should be split by async separators. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71433
a67e4f5dfe86821bafc6eacacc897465e049cf99: Bug 1639375 - Polish inline preview label styling. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 20 May 2020 15:19:16 +0000 - rev 531278
Push 116543 by jlaster@mozilla.com at Wed, 20 May 2020 15:31:22 +0000
Bug 1639375 - Polish inline preview label styling. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D76059
101545eb6cba628130840a417c77474ccaf58378: Bug 1636798 - Check tabs instead of source when displaying pretty print icon r=davidwalsh
Kyle Knaggs <kyleknaggs@gmail.com> - Mon, 18 May 2020 19:13:58 +0000 - rev 530697
Push 116312 by dwalsh@mozilla.com at Mon, 18 May 2020 19:46:43 +0000
Bug 1636798 - Check tabs instead of source when displaying pretty print icon r=davidwalsh Added a new hasPrettyTab() selector function. Renamed the function and prop in SourcesTreeItem to reflect the new hasPrettyTab() selector function. Updated the snapshot test for the pretty print icon. Differential Revision: https://phabricator.services.mozilla.com/D75733
bc1d9c3a316731a48dccbe06b6b96942b13ef9a5: Bug 1638533 - Add (in promise) suffix for uncaught rejected promise. r=davidwalsh.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Mon, 18 May 2020 14:34:33 +0000 - rev 530635
Push 116289 by nchevobbe@mozilla.com at Mon, 18 May 2020 15:26:27 +0000
Bug 1638533 - Add (in promise) suffix for uncaught rejected promise. r=davidwalsh. Now that nsIScriptError have a `isPromiseRejection` flag, we can consume it in the console to indicate to the user that we're dealing with a promise rejection. The exception message is then: "Uncaught (in promise) XXX". A few tests needed to be updated, and we take this as an opportunity to ensure we have a stacktrace for uncaught promise rejection. Differential Revision: https://phabricator.services.mozilla.com/D75780
7b5fdfe6c769f6a111e29a681bd70e7782f7fadb: Bug 1631529 - Fix intermittent in browser_jsterm_editor_toggle_keyboard_shortcut.js . r=davidwalsh.
Nicolas Chevobbe <nchevobbe@mozilla.com> - Tue, 12 May 2020 17:18:46 +0000 - rev 529440
Push 115700 by nchevobbe@mozilla.com at Tue, 12 May 2020 18:18:50 +0000
Bug 1631529 - Fix intermittent in browser_jsterm_editor_toggle_keyboard_shortcut.js . r=davidwalsh. The test was failing on ccov machines because it was timing out. The interesting part is that in the logs we could see that a huge error was logged, because we were hitting the IGNORED REDUX ACTION middleware, which was about a SET_TERMINAL_EAGER_RESULT action being blocked. I think that logging this object was taking so much time that it made the test timeout on slow machines. So here we're simply waiting for the eager evaluation result to be displayed, so we know that the action won't be ignored. Differential Revision: https://phabricator.services.mozilla.com/D74879
2b43e52af0368483904de9f80016f4794699c3fa: Bug 1621551 - Remove objectBox-string selector that was responsible for white-space: nowrap. r=davidwalsh
AaryanDewan <aaryandewan@yahoo.com> - Wed, 06 May 2020 16:48:39 +0000 - rev 528482
Push 115124 by dwalsh@mozilla.com at Wed, 06 May 2020 17:21:36 +0000
Bug 1621551 - Remove objectBox-string selector that was responsible for white-space: nowrap. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D74027
61436ae396a2a43a2e946a3c1cf7fde5602dfe04: Bug 1630657 - The React callstack group should include react-dom-dev. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Thu, 23 Apr 2020 21:44:09 +0000 - rev 525963
Push 113978 by jlaster@mozilla.com at Fri, 24 Apr 2020 16:55:05 +0000
Bug 1630657 - The React callstack group should include react-dom-dev. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71192
d420853f8d696d894bedcea0b83223fc679e2f41: Bug 1630742 - cmd+click should continue to here. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Thu, 23 Apr 2020 16:52:58 +0000 - rev 525703
Push 113875 by jlaster@mozilla.com at Thu, 23 Apr 2020 22:37:39 +0000
Bug 1630742 - cmd+click should continue to here. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71217
c39d389d140cdaffd02349f91e78a3a5671dc50c: Bug 1630742 - cmd+click should continue to here. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Thu, 23 Apr 2020 00:07:13 +0000 - rev 525538
Push 113772 by jlaster@mozilla.com at Thu, 23 Apr 2020 00:14:54 +0000
Bug 1630742 - cmd+click should continue to here. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71217
da168cc5c08f8ec33691f141c55e987e20906f20: Bug 1630742 - cmd+click should continue to here. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 22 Apr 2020 01:07:05 +0000 - rev 525323
Push 113645 by jlaster@mozilla.com at Wed, 22 Apr 2020 01:48:44 +0000
Bug 1630742 - cmd+click should continue to here. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71217
564f430989a5c37a1f39d1e267022de7cdb96e5f: Bug 1630742 - cmd+click should continue to here. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Mon, 20 Apr 2020 20:22:16 +0000 - rev 524945
Push 113489 by jlaster@mozilla.com at Mon, 20 Apr 2020 20:28:04 +0000
Bug 1630742 - cmd+click should continue to here. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71217
3fcf8ec4f1342d1bfdc3612ec2bbdcf79b70c6b5: Bug 1630660 - Memoize Callstack FrameLocation component. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Mon, 20 Apr 2020 18:39:28 +0000 - rev 524928
Push 113483 by jlaster@mozilla.com at Mon, 20 Apr 2020 20:20:56 +0000
Bug 1630660 - Memoize Callstack FrameLocation component. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D71196
60360b9d1466c0864c118e35ec97da8fbb6cc5d1: Bug 1624459 - First pause on climatescape.org can take 4secs. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 15 Apr 2020 18:03:24 +0000 - rev 524225
Push 113062 by jlaster@mozilla.com at Wed, 15 Apr 2020 19:42:05 +0000
Bug 1624459 - First pause on climatescape.org can take 4secs. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D70124
afa247928245d02b1305a1850eb39f19b84a2f35: Bug 1629171 - convert tabsBlackBoxed to async pref. r=davidwalsh
Jason Laster <jlaster@mozilla.com> - Wed, 15 Apr 2020 16:32:45 +0000 - rev 524201
Push 113050 by jlaster@mozilla.com at Wed, 15 Apr 2020 17:54:57 +0000
Bug 1629171 - convert tabsBlackBoxed to async pref. r=davidwalsh Differential Revision: https://phabricator.services.mozilla.com/D70564