searching for reviewer(cmartin)
88fa88f269e625353a68be2201a8470e7f45f31a: Bug 1774694: Function, browser, media and volume keys should not hide cursor on Windows r=cmartin
David Parks <daparks@mozilla.com> - Wed, 22 Jun 2022 22:37:27 +0000 - rev 621848
Push 165073 by daparks@mozilla.com at Wed, 22 Jun 2022 22:39:52 +0000
Bug 1774694: Function, browser, media and volume keys should not hide cursor on Windows r=cmartin Also includes the Fn key, which isn't documented to map to a special virtual key code but maps to 0xff, an undefined code, on tested machines. Differential Revision: https://phabricator.services.mozilla.com/D149928
0d8d5b36120e3516c07024ec721e1b32668db04e: Bug 1775320 - WinContentSystemParameters is not needed. r=cmartin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Jun 2022 18:03:01 +0000 - rev 621809
Push 165053 by ealvarez@mozilla.com at Wed, 22 Jun 2022 19:31:44 +0000
Bug 1775320 - WinContentSystemParameters is not needed. r=cmartin It was needed before we had remote lookandfeel and non-native theme, but now we no longer call any of the APIs in child processes. Differential Revision: https://phabricator.services.mozilla.com/D149907
da545548f66895df0a447661f28caaebec14f7b8: Bug 1775247 - Enable widget.use-theme-accent on Windows. r=cmartin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 22 Jun 2022 09:45:07 +0000 - rev 621727
Push 164995 by ealvarez@mozilla.com at Wed, 22 Jun 2022 09:48:19 +0000
Bug 1775247 - Enable widget.use-theme-accent on Windows. r=cmartin Just like we do in all other platforms where we use the system accent color. Differential Revision: https://phabricator.services.mozilla.com/D149878
02a7e948a4574c441a4116c6907c5dedf648b3e6: Bug 1773513: Ignore Alt-key sequences when hiding the cursor on Windows r=cmartin
David Parks <daparks@mozilla.com> - Wed, 15 Jun 2022 21:59:40 +0000 - rev 621065
Push 164634 by daparks@mozilla.com at Wed, 15 Jun 2022 22:02:06 +0000
Bug 1773513: Ignore Alt-key sequences when hiding the cursor on Windows r=cmartin On Windows 11, Alt-Space was opening a system context menu while also hiding the mouse cursor. Differential Revision: https://phabricator.services.mozilla.com/D148841
9b36e5d3771e1c365cba169eb8bd0188cd829d50: Bug 642851: Clear autohidden taskbar region on Windows 10+ if drawing NC region r=cmartin
David Parks <daparks@mozilla.com> - Tue, 14 Jun 2022 00:49:09 +0000 - rev 620797
Push 164498 by daparks@mozilla.com at Tue, 14 Jun 2022 00:51:39 +0000
Bug 642851: Clear autohidden taskbar region on Windows 10+ if drawing NC region r=cmartin The unpainted non-client region leaves a white bar at the bottom of the window when maximized on Win11 with auto-hidden taskbar. This region is where a user can mouse-over to expose the taskbar. Painting it black eliminates the row of white pixels and fixes problems with exposing the hidden taskbar. Windows 10 usually (correctly) paints a sliver of the taskbar in this region with or without this patch. However, it also has similar (but more complex) failing edge cases discussed in the bug. Additionally, bug 758280 used 1px for the autohidden region size but the real size is 2px so we switch to that here. Differential Revision: https://phabricator.services.mozilla.com/D148834
4db736ca2ba8077f17010a4022caca6c06528ea5: Bug 642851: Allow identification of correct taskbar window for our screen on Windows r=cmartin
David Parks <daparks@mozilla.com> - Tue, 14 Jun 2022 00:49:09 +0000 - rev 620796
Push 164498 by daparks@mozilla.com at Tue, 14 Jun 2022 00:51:39 +0000
Bug 642851: Allow identification of correct taskbar window for our screen on Windows r=cmartin Since Windows 8, ABM_GETAUTOHIDEBAREX has provided a way to identify if/where the system taskbar is hidden, even in multi-monitor setups. This adds a function to easily fetch that information. Differential Revision: https://phabricator.services.mozilla.com/D148833
0b315f779d2f8a2509c888b1bd28ce1b33784dde: Bug 1774073: Backout bug 1704500 from mozilla-central and mozilla-beta r=cmartin
David Parks <daparks@mozilla.com> - Mon, 13 Jun 2022 19:14:06 +0000 - rev 620766
Push 164477 by daparks@mozilla.com at Mon, 13 Jun 2022 19:16:29 +0000
Bug 1774073: Backout bug 1704500 from mozilla-central and mozilla-beta r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D149163
cd2675132e5792b01660be9d91ca32bcca17f2e9: Bug 1647161 - [2/5] Add cloaking event listener r=handyman,cmartin
Ray Kraesig <rkraesig@mozilla.com> - Tue, 07 Jun 2022 17:07:42 +0000 - rev 619993
Push 164114 by rkraesig@mozilla.com at Tue, 07 Jun 2022 17:10:25 +0000
Bug 1647161 - [2/5] Add cloaking event listener r=handyman,cmartin Add a global hook and per-nsWindow handlers for cloaking events. Part of a sequence of commits for bug 1732517. (Other than caching the cloak-state in-process, these don't actually do anything yet. User-visible functionality will be added in a following commit.) Differential Revision: https://phabricator.services.mozilla.com/D146324
cd365892b9dad3233b7cbe7da0b07977c6a51eac: Bug 1732517 - [1/5] Drive-by cleanup: simplify WinUtils::GetNSWindowPtr() et al. r=cmartin
Ray Kraesig <rkraesig@mozilla.com> - Tue, 07 Jun 2022 17:07:41 +0000 - rev 619992
Push 164114 by rkraesig@mozilla.com at Tue, 07 Jun 2022 17:10:25 +0000
Bug 1732517 - [1/5] Drive-by cleanup: simplify WinUtils::GetNSWindowPtr() et al. r=cmartin A few drive-by improvements: * There's no need to use window properties for this -- it's actually kind of slow, since it involves a kernel call (`NtFindAtom`). Use an in-process hash table instead. * No caller checks the return value of `Set...`, and they couldn't do anything with it even if they did. Convert it to `void`. * The distinction between `Get...BasePtr` and `Get...Ptr` was lost with the removal of `nsWindowBase` (and, arguably, long before). Collapse them, rename them appropriately, and rewrite the associated comments. In particular, remove the description of the latter as a "legacy api". * Confirm and document that these may only be used on the main thread. (This was always true, in the sense that it's inherently racy -- a caller not on the main thread could _get_ the pointer, but the underlying object might vanish before anything could be done with it.) Differential Revision: https://phabricator.services.mozilla.com/D146634
f26e29f4be9291648d8a638a3817384f62284e56: Bug 1768903: Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin
David Parks <daparks@mozilla.com> - Wed, 25 May 2022 12:58:38 +0000 - rev 618869
Push 163465 by rvandermeulen@mozilla.com at Wed, 25 May 2022 13:01:08 +0000
Bug 1768903: Do not hide Windows mouse cursor when typing ctrl-key sequences r=cmartin Previously, we ignored cut-and-paste operations, similar to some other applications, but most ctrl-keys do something in the browser that makes hiding the cursor pointless or distracting (like ctrl-j opening the download window). Differential Revision: https://phabricator.services.mozilla.com/D146506
04574f33e1b9e5ff99e15b2181b2f9cf271bfe47: Bug 1767948: Make Windows cursor hiding dependent on if mouse is installed r=Jamie,cmartin
David Parks <daparks@mozilla.com> - Tue, 17 May 2022 20:05:08 +0000 - rev 618045
Push 163003 by daparks@mozilla.com at Tue, 17 May 2022 20:07:32 +0000
Bug 1767948: Make Windows cursor hiding dependent on if mouse is installed r=Jamie,cmartin We don't need to track cursor hiding when typing if there shouldn't be a cursor anyway because there is no mouse. Differential Revision: https://phabricator.services.mozilla.com/D146516
53032d7125127400ad88d999921039ae69c6ca3f: Bug 1768014 p2: Default to policy win32k lockdown status if in process check fails. r=gcp,cmartin
Bob Owen <bobowencode@gmail.com> - Tue, 10 May 2022 06:07:17 +0000 - rev 616802
Push 162539 by bobowencode@gmail.com at Tue, 10 May 2022 07:03:12 +0000
Bug 1768014 p2: Default to policy win32k lockdown status if in process check fails. r=gcp,cmartin Depends on D145872 Differential Revision: https://phabricator.services.mozilla.com/D145873
372866a4707c204882d8becf81bfaed9821b7709: Bug 1766537 - Exit fullscreen when sizemode change in headless mode; r=cmartin
Edgar Chen <echen@mozilla.com> - Tue, 03 May 2022 08:10:58 +0000 - rev 615930
Push 162082 by echen@mozilla.com at Tue, 03 May 2022 08:38:18 +0000
Bug 1766537 - Exit fullscreen when sizemode change in headless mode; r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D144807
c9f1677401ed0e60ec4be3ca1ba8e3462fcfd04e: Bug 1757751 - Invert Win32 nsWindow::mAspectRatio so it follows the standard definition. r=cmartin
Dmitrij Feller <the.other.feller@gmail.com> - Thu, 28 Apr 2022 21:58:09 +0000 - rev 615648
Push 161926 by cmartin@mozilla.com at Thu, 28 Apr 2022 22:00:29 +0000
Bug 1757751 - Invert Win32 nsWindow::mAspectRatio so it follows the standard definition. r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D144748
7a3848fc8f8f63be0a889147a9226937289aacdb: Bug 1614218: Clean up horizontal/vertical mixup in Windows widget r=cmartin
David Parks <daparks@mozilla.com> - Wed, 20 Apr 2022 17:54:48 +0000 - rev 614818
Push 161404 by daparks@mozilla.com at Wed, 20 Apr 2022 18:23:44 +0000
Bug 1614218: Clean up horizontal/vertical mixup in Windows widget r=cmartin InvalidateNonClientRegion mixed up these constants. They seem to always map to the same value on Windows so this doesn't change any behavior. Depends on D143389 Differential Revision: https://phabricator.services.mozilla.com/D143390
d0b1521fa0c9b46e29898ece168f0ea0cd786ddd: Bug 1759558: Enable widget.windows.hide_cursor_when_typing by default r=cmartin
David Parks <daparks@mozilla.com> - Mon, 18 Apr 2022 20:00:59 +0000 - rev 614530
Push 161231 by daparks@mozilla.com at Mon, 18 Apr 2022 20:03:22 +0000
Bug 1759558: Enable widget.windows.hide_cursor_when_typing by default r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D143850
07fdec3e7cf2006e3ddf2a2d1c11293ae99a82a3: Bug 1759558: Ignore special keys when hiding pointer while typing on Windows r=cmartin
David Parks <daparks@mozilla.com> - Mon, 18 Apr 2022 20:00:58 +0000 - rev 614529
Push 161231 by daparks@mozilla.com at Mon, 18 Apr 2022 20:03:22 +0000
Bug 1759558: Ignore special keys when hiding pointer while typing on Windows r=cmartin Clipboard operations, cursor navigation and input mode changes should not hide the cursor. This mimics behavior in other Windows apps (e.g. WordPad). Differential Revision: https://phabricator.services.mozilla.com/D143849
98474ebab1efaa126904499673cb40526d064e67: Bug 1757797 - Don't use native tooltip drawing on Windows. r=dao,cmartin
Emilio Cobos Alvarez <emilio@mozilla.com> - Thu, 14 Apr 2022 21:05:57 +0000 - rev 614389
Push 161141 by ealvarez@mozilla.com at Thu, 14 Apr 2022 21:08:17 +0000
Bug 1757797 - Don't use native tooltip drawing on Windows. r=dao,cmartin This removes the rounded, native-looking tooltips on Windows 7, but I don't think it's too concerning, let me know if you disagree. I'm not sure what's our Windows 7 support status, but in any case this regression would be relatively minimal. On regular (non-HCM) Windows 10+ we just fill a rect with infobackground color and so on, so there shouldn't be any effective behavior change. On HCM we go through the themed codepath and fail catastrophically, so just don't do it. Differential Revision: https://phabricator.services.mozilla.com/D143754
b46fde1669caf7b0ebd0426de6713f6e6328badb: Bug 1614218: Clean up horizontal/vertical mixup in Windows widget r=cmartin
David Parks <daparks@mozilla.com> - Wed, 13 Apr 2022 00:03:16 +0000 - rev 614143
Push 161010 by daparks@mozilla.com at Wed, 13 Apr 2022 00:41:05 +0000
Bug 1614218: Clean up horizontal/vertical mixup in Windows widget r=cmartin InvalidateNonClientRegion mixed up these constants. They seem to always map to the same value on Windows so this doesn't change any behavior. Differential Revision: https://phabricator.services.mozilla.com/D143390
ca296f209b269a1ea7b29a2a36929c1f05f6b6d4: Bug 1751281 - Enable Windows Event logging with separate logging module and message parameters r=cmartin
Max Vollmer <mvollmer@mozilla.com> - Fri, 25 Mar 2022 15:27:39 +0000 - rev 611939
Push 160055 by gpascutto@mozilla.com at Fri, 25 Mar 2022 15:29:59 +0000
Bug 1751281 - Enable Windows Event logging with separate logging module and message parameters r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D141728
2d5dc5c2afd844d112c17898079cbee5281ad13e: Bug 1758357 - Don't call SetCursor redundantly on Windows. r=cmartin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 23 Mar 2022 17:17:35 +0000 - rev 611685
Push 159893 by ealvarez@mozilla.com at Wed, 23 Mar 2022 17:43:31 +0000
Bug 1758357 - Don't call SetCursor redundantly on Windows. r=cmartin Bug 1724120 apparently regressed this, which is a bit surprising because the redundant ::SetCursor() call is already there. The real fix is the one above, however I think this change is still worth it. Make cursor updates avoid redundant ::SetCursor() calls the same way other widget back-ends do (always except for mUpdateCursor, which is set on scale changes and so on). Differential Revision: https://phabricator.services.mozilla.com/D141864
b21871462449cb6312a0f9a871def152f0cc3419: Bug 1757463: Support "Hide pointer while typing" on Windows r=cmartin
David Parks <daparks@mozilla.com> - Wed, 09 Mar 2022 20:09:41 +0000 - rev 610147
Push 159091 by daparks@mozilla.com at Wed, 09 Mar 2022 20:19:05 +0000
Bug 1757463: Support "Hide pointer while typing" on Windows r=cmartin We need to hide the pointer when we detect a keypress and unhide it when we get any mouse event or window deactivation. We only do this if the Windows "Hide pointer while typing" setting is turned on (it is on by default). We currently also put this behind the Firefox pref "widget.windows.hide_cursor_when_typing". Differential Revision: https://phabricator.services.mozilla.com/D139896
044faec138679cbf865d5eff0d00ee91f0ab7fe6: Bug 1757827 - Improve win11 overlay scrollbars. r=saschanaz,cmartin
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 04 Mar 2022 13:44:51 +0000 - rev 609607
Push 158925 by ealvarez@mozilla.com at Fri, 04 Mar 2022 13:47:15 +0000
Bug 1757827 - Improve win11 overlay scrollbars. r=saschanaz,cmartin Tweaks are: * Round the scrollbar track (when visible, which is almost never). * Make the scrollbar thinner. * Move the thumb closer to the edge. All these changes match closer the Windows 11 style, and there are no changes for other existing styles. Differential Revision: https://phabricator.services.mozilla.com/D140127
3e474bf6eab0dec49c116f06f63786aca053219c: Bug 1751935, ensure size constraints are accounted for when applying aspect ratio on Windows, r=cmartin
Neil Deakin <neil@mozilla.com> - Thu, 03 Mar 2022 01:21:54 +0000 - rev 609460
Push 158818 by neil@mozilla.com at Thu, 03 Mar 2022 01:24:18 +0000
Bug 1751935, ensure size constraints are accounted for when applying aspect ratio on Windows, r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D140062
21553c91b278c428b4c8e861602a99fb1c1acc70: Bug 1757647 - Implement Windows 11 overlay scrollbars. r=cmartin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 02 Mar 2022 12:02:00 +0000 - rev 609392
Push 158763 by ealvarez@mozilla.com at Wed, 02 Mar 2022 12:04:24 +0000
Bug 1757647 - Implement Windows 11 overlay scrollbars. r=cmartin Put it behind a pref for nightly and early beta for now. Differential Revision: https://phabricator.services.mozilla.com/D139987
299312118fecd23e87fa26463807342cbce619e0: Bug 1598312 - Support setting a custom resize margin, and apply that to Picture-in-Picture windows. r=cmartin,emilio
Molly Howell <mhowell@mozilla.com> - Thu, 17 Feb 2022 23:18:45 +0000 - rev 608125
Push 158099 by mhowell@mozilla.com at Fri, 18 Feb 2022 00:06:34 +0000
Bug 1598312 - Support setting a custom resize margin, and apply that to Picture-in-Picture windows. r=cmartin,emilio Differential Revision: https://phabricator.services.mozilla.com/D138725
b35ceb4aaccc09d73a2e4168a5c144d8c9df3b05: Bug 1751367: Delay loading winmm.dll, so it loads after COM initialization. r=cmartin,media-playback-reviewers,alwu
Bob Owen <bobowencode@gmail.com> - Wed, 02 Feb 2022 13:43:51 +0000 - rev 606258
Push 157129 by bobowencode@gmail.com at Wed, 02 Feb 2022 14:36:24 +0000
Bug 1751367: Delay loading winmm.dll, so it loads after COM initialization. r=cmartin,media-playback-reviewers,alwu This is to prevent user32.dll from loading before COM initialization on earlier version of windows. Differential Revision: https://phabricator.services.mozilla.com/D136936
13bebbfea59118a58de024570a9f9d8dc84b6f94: Bug 1151941: Use an alternate winstation for the content process sandbox. r=cmartin
Bob Owen <bobowencode@gmail.com> - Wed, 02 Feb 2022 13:43:51 +0000 - rev 606257
Push 157129 by bobowencode@gmail.com at Wed, 02 Feb 2022 14:36:24 +0000
Bug 1151941: Use an alternate winstation for the content process sandbox. r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D136935
0b12f1bb498a5f024341697b2163f725815b12d5: Bug 1751367: Delay loading winmm.dll, so it loads after COM initialization. r=cmartin,media-playback-reviewers,alwu
Bob Owen <bobowencode@gmail.com> - Tue, 01 Feb 2022 13:31:33 +0000 - rev 606139
Push 157055 by bobowencode@gmail.com at Tue, 01 Feb 2022 13:34:42 +0000
Bug 1751367: Delay loading winmm.dll, so it loads after COM initialization. r=cmartin,media-playback-reviewers,alwu This is to prevent user32.dll from loading before COM initialization on earlier version of windows. Differential Revision: https://phabricator.services.mozilla.com/D136936
bba7c74dafae3c8b93c4b067c9d931c345735c1b: Bug 1151941: Use an alternate winstation for the content process sandbox. r=cmartin
Bob Owen <bobowencode@gmail.com> - Tue, 01 Feb 2022 13:31:33 +0000 - rev 606138
Push 157055 by bobowencode@gmail.com at Tue, 01 Feb 2022 13:34:42 +0000
Bug 1151941: Use an alternate winstation for the content process sandbox. r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D136935
d874ec84b50844e939bcbf4ec08f93361b79fb88: Bug 1750033: Re-enable win32k lockdown for file content processes when pref set. r=cmartin
Bob Owen <bobowencode@gmail.com> - Thu, 13 Jan 2022 18:17:08 +0000 - rev 604498
Push 156007 by bobowencode@gmail.com at Thu, 13 Jan 2022 18:19:31 +0000
Bug 1750033: Re-enable win32k lockdown for file content processes when pref set. r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D135895
1d94da94e88807ee078bae5c32dd09dadd4c9716: Bug 1732343 - Part 9: Directly use DuplicateHandle in RemoteBackbuffer, r=cmartin
Nika Layzell <nika@thelayzells.com> - Tue, 09 Nov 2021 14:17:35 +0000 - rev 598776
Push 152839 by nlayzell@mozilla.com at Tue, 09 Nov 2021 14:25:25 +0000
Bug 1732343 - Part 9: Directly use DuplicateHandle in RemoteBackbuffer, r=cmartin Previously this code was using ipc::DuplicateHandle, which was unnecessary, as the code is being run in the parent process which has access to perform direct handle transfers. After this patch we'd like to remove ipc::DuplicateHandle and rely only on attached handles for serialization, so the code is converted to instead directly use DuplicateHandle. Differential Revision: https://phabricator.services.mozilla.com/D126571
235e9c2fcbce56c9c030fda778d73bc61b38ded7: Bug 1732343 - Part 8: Use attached handles for Windows RemoteBackbufferHandles serialization, r=cmartin
Nika Layzell <nika@thelayzells.com> - Tue, 09 Nov 2021 14:17:34 +0000 - rev 598775
Push 152839 by nlayzell@mozilla.com at Tue, 09 Nov 2021 14:25:25 +0000
Bug 1732343 - Part 8: Use attached handles for Windows RemoteBackbufferHandles serialization, r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D126570
d30fa1e1f60556ba98bb7fe17c4cdefeb75727b1: Bug 1732343 - Part 9: Directly use DuplicateHandle in RemoteBackbuffer, r=cmartin
Nika Layzell <nika@thelayzells.com> - Thu, 04 Nov 2021 19:20:20 +0000 - rev 598326
Push 152622 by nlayzell@mozilla.com at Thu, 04 Nov 2021 19:26:01 +0000
Bug 1732343 - Part 9: Directly use DuplicateHandle in RemoteBackbuffer, r=cmartin Previously this code was using ipc::DuplicateHandle, which was unnecessary, as the code is being run in the parent process which has access to perform direct handle transfers. After this patch we'd like to remove ipc::DuplicateHandle and rely only on attached handles for serialization, so the code is converted to instead directly use DuplicateHandle. Differential Revision: https://phabricator.services.mozilla.com/D126571
ed0b4f757c4bd31cf3e3b8b1c9105aa3f32e9b17: Bug 1732343 - Part 8: Use attached handles for Windows RemoteBackbufferHandles serialization, r=cmartin
Nika Layzell <nika@thelayzells.com> - Thu, 04 Nov 2021 19:20:20 +0000 - rev 598325
Push 152622 by nlayzell@mozilla.com at Thu, 04 Nov 2021 19:26:01 +0000
Bug 1732343 - Part 8: Use attached handles for Windows RemoteBackbufferHandles serialization, r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D126570
542710f708e384113725be5d04b4cd03cc6c6363: Bug 1661127: Cache Windows IVirtualDesktopManager::GetWindowDesktopId value r=cmartin
David Parks <daparks@mozilla.com> - Tue, 02 Nov 2021 17:18:23 +0000 - rev 598028
Push 152486 by daparks@mozilla.com at Tue, 02 Nov 2021 17:32:01 +0000
Bug 1661127: Cache Windows IVirtualDesktopManager::GetWindowDesktopId value r=cmartin GetWindowDesktopId is a slow function and is called on the UI thread during WM_CLOSE message handing (as part of SessionStore). This was causing Windows to assume we are stalled and it abandons some messages, namely future WM_CLOSE messages sent for other windows during a "Close All Windows" operation. In this patch, GetWorkspaceId uses a cached value for GetWindowDesktopId (if available) but also queues an update for that cache value if one isn't already in progress. Since SessionStore already regularly calls GetWorkspaceId in response to window moves, this keeps the value fresh in plases where it might change. (The SessionStore architecture is designed that way because Windows does not notify the application if the user moves the window to another virtual desktop.) Differential Revision: https://phabricator.services.mozilla.com/D128955
edac0b3bd405a595aedbbe162ed7d8ce9863129b: Bug 1722208 - Fix automatically displaying the on-screen keyboard on Windows 11 when running on convertible slates r=cmartin
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 28 Oct 2021 21:08:12 +0000 - rev 597287
Push 152346 by gsvelto@mozilla.com at Thu, 28 Oct 2021 22:32:45 +0000
Bug 1722208 - Fix automatically displaying the on-screen keyboard on Windows 11 when running on convertible slates r=cmartin This fix simply ignores tablet mode when running on Windows 11. The reasoning behind this is that per Microsoft documentation tablet mode is specific to Windows 10 and not supported anymore on Windows 11. This seems consistent in the behavior of the APIs we use to detect the presence of a keyboard: Windows 10-specific APIs return unexpected results while APIs that predate them return values that seem consistent and reliable. Differential Revision: https://phabricator.services.mozilla.com/D128229
539230e86e1175be73fc19985160aa2453e1994a: Bug 1722208 - Workaround to make the Windows on-screen keyboard work properly on convertible slates running Windows 11 r=cmartin
Gabriele Svelto <gsvelto@mozilla.com> - Thu, 14 Oct 2021 08:30:32 +0000 - rev 595857
Push 151477 by gsvelto@mozilla.com at Thu, 14 Oct 2021 08:32:55 +0000
Bug 1722208 - Workaround to make the Windows on-screen keyboard work properly on convertible slates running Windows 11 r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D128229
eaa49cc4154b7129b6317cb5318a6239cbe601bf: Bug 1723674 - mfbt: Add new GenerateRandomBytes() function. r=cmartin
Chris Peterson <cpeterson@mozilla.com> - Thu, 14 Oct 2021 03:28:48 +0000 - rev 595765
Push 151468 by cpeterson@mozilla.com at Thu, 14 Oct 2021 03:31:20 +0000
Bug 1723674 - mfbt: Add new GenerateRandomBytes() function. r=cmartin Generalize RandomUint64() into a new GenerateRandomBytes() function, which will be used in the next changeset to replace nsUUIDGenerator's various platform-specific implementations with one simple implementation. Differential Revision: https://phabricator.services.mozilla.com/D124311
c13cadb3b0e0dc2fb2a0f0d0568ab671b738f7ad: Bug 1730194 - Prevent Copy button to send information to Cloud Clipboard and Clipboard History on Windows r=dimi,johannh,cmartin
Sergey Galich <sgalich@mozilla.com> - Thu, 07 Oct 2021 15:32:03 +0000 - rev 595088
Push 151053 by sgalich@mozilla.com at Thu, 07 Oct 2021 15:34:26 +0000
Bug 1730194 - Prevent Copy button to send information to Cloud Clipboard and Clipboard History on Windows r=dimi,johannh,cmartin Differential Revision: https://phabricator.services.mozilla.com/D125831
b94153cca1f7d677fbbcc1a0d4923d81ddec8958: Bug 1734359 - Make system toolbar dark on windows dark mode. r=cmartin
Emilio Cobos Alvarez <emilio@crisal.io> - Wed, 06 Oct 2021 15:30:00 +0000 - rev 594957
Push 150981 by ealvarez@mozilla.com at Wed, 06 Oct 2021 15:32:33 +0000
Bug 1734359 - Make system toolbar dark on windows dark mode. r=cmartin This can be accomplished by the undocumented DWMWA_USE_IMMERSIVE_DARK_MODE. You can test this by going to "Customize Toolbar" and checking "Title Bar", or opening any native dialog like e.g. the profile creation window / the profile manager / etc. Differential Revision: https://phabricator.services.mozilla.com/D127636
3e99d43f5199ba58bce0a16f795a960276f7d58d: Bug 1732208 - Silence the unused-but-set-variable warning in widget. r=cmartin
Mike Hommey <mh+mozilla@glandium.org> - Tue, 28 Sep 2021 00:02:48 +0000 - rev 593394
Push 150420 by mh@glandium.org at Tue, 28 Sep 2021 00:06:02 +0000
Bug 1732208 - Silence the unused-but-set-variable warning in widget. r=cmartin widget/windows/nsAppShell.cpp(685,10): error: variable 'uiMessage' set but not used [-Werror,-Wunused-but-set-variable] bool uiMessage = false; ^ widget/windows/TaskbarPreview.cpp(370,11): error: variable 'hr' set but not used [-Werror,-Wunused-but-set-variable] HRESULT hr; ^ Differential Revision: https://phabricator.services.mozilla.com/D126461
81c3f1668e7a9d996811b4e7e50def77b3990470: Bug 1643936: Fix vtable for Windows IVirtualDesktopManager r=cmartin
David Parks <daparks@mozilla.com> - Sun, 19 Sep 2021 23:27:23 +0000 - rev 592452
Push 149998 by daparks@mozilla.com at Sun, 19 Sep 2021 23:29:47 +0000
Bug 1643936: Fix vtable for Windows IVirtualDesktopManager r=cmartin Differential Revision: https://phabricator.services.mozilla.com/D125348
6742adc22917e6708fcb862a086c4eef9faffb21: Bug 1731107 - Use more contrasting colors on windows for inactive selected items. r=cmartin
Emilio Cobos Alvarez <emilio@crisal.io> - Fri, 17 Sep 2021 18:32:21 +0000 - rev 592371
Push 149957 by ealvarez@mozilla.com at Fri, 17 Sep 2021 20:06:30 +0000
Bug 1731107 - Use more contrasting colors on windows for inactive selected items. r=cmartin There's no system color for such thing on Windows, at least according to: https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getsyscolor Using 3DFACE/WINDOWTEXT seems a hack at best. Even windows built-in programs like Task Manager use darker colors. So use the background that Edge uses, and black for the color since that's what our <select> listbox and co actually uses by default. Differential Revision: https://phabricator.services.mozilla.com/D126007
e03c235c93c8a2090b4e6b8ab12ad2fcd7b1d46c: Bug 1718629: Handle Windows WM_NCHITTEST message for maximize button r=emilio,cmartin
David Parks <daparks@mozilla.com> - Tue, 07 Sep 2021 16:03:57 +0000 - rev 591232
Push 149313 by daparks@mozilla.com at Tue, 07 Sep 2021 16:10:01 +0000
Bug 1718629: Handle Windows WM_NCHITTEST message for maximize button r=emilio,cmartin Windows 11's Snap Layouts feature generates a window of layout options when the maximize window button is moused over. This requires the WM_NCHITTEST message to handle hit detection for the button. Since WM_NCHITTEST messages are very common, although we limit them to no more than every 50ms, we don't want to do a full hit test each time. Instead, we cache the maximize button rect in the widget when it is positioned during layout. Differential Revision: https://phabricator.services.mozilla.com/D123982
bd5a397b19adda558f3f4527afa3b17ef693085a: Bug 1728171 - Part 2: Add button parameter to utils.sendNativePenInput r=cmartin,edgar
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 06 Sep 2021 11:50:34 +0000 - rev 591112
Push 149245 by krosylight@mozilla.com at Mon, 06 Sep 2021 11:58:56 +0000
Bug 1728171 - Part 2: Add button parameter to utils.sendNativePenInput r=cmartin,edgar Differential Revision: https://phabricator.services.mozilla.com/D124172
c6c1f639398d06002c34830cfde06ea7a4c77409: Bug 1728171 - Part 1: Fire eContextMenu from pen contact with barrel button r=cmartin,edgar
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 06 Sep 2021 11:50:34 +0000 - rev 591111
Push 149245 by krosylight@mozilla.com at Mon, 06 Sep 2021 11:58:56 +0000
Bug 1728171 - Part 1: Fire eContextMenu from pen contact with barrel button r=cmartin,edgar Differential Revision: https://phabricator.services.mozilla.com/D124171
fe88ab9dd36b7571fa6acf2e251ad18634deaa88: Bug 1727722 - Do not consume WM_POINTER without APZ r=cmartin
Kagami Sascha Rosylight <krosylight@mozilla.com> - Mon, 30 Aug 2021 19:44:21 +0000 - rev 590262
Push 148830 by krosylight@mozilla.com at Mon, 30 Aug 2021 20:08:05 +0000
Bug 1727722 - Do not consume WM_POINTER without APZ r=cmartin Consuming WM_POINTER without APZ causes odd behaviors including inability to interact with context menu. This allows falling back to WM_LBUTTON* and WM_GESTURE as touch inputs already do. Differential Revision: https://phabricator.services.mozilla.com/D123966
d425eea582f43b97ed484ce0e3e350a51becc7e1: Bug 1722085: Use Win32 function GetDpiForWindow when available r=cmartin
David Parks <daparks@mozilla.com> - Thu, 19 Aug 2021 17:13:55 +0000 - rev 589355
Push 148300 by daparks@mozilla.com at Thu, 19 Aug 2021 17:19:32 +0000
Bug 1722085: Use Win32 function GetDpiForWindow when available r=cmartin GetDpiForMonitor sometimes gives the wrong result for multi-monitor setups in Windows 11. Differential Revision: https://phabricator.services.mozilla.com/D122027
ed8ac164c43bd2d9e90fd12289c411b0656ef445: Bug 1718564 - Fix -Wlogical-op warning in GamepadTouchState.h. r=cmartin
Chris Peterson <cpeterson@mozilla.com> - Fri, 09 Jul 2021 23:53:47 +0000 - rev 585269
Push 146109 by cpeterson@mozilla.com at Fri, 09 Jul 2021 23:56:20 +0000
Bug 1718564 - Fix -Wlogical-op warning in GamepadTouchState.h. r=cmartin gcc reports the following -Wlogical-op warning because the `touchId == aTouch.touchId` check is duplicated: GamepadTouchState.h:28:38: warning: logical 'and' of equal expressions [-Wlogical-op] Differential Revision: https://phabricator.services.mozilla.com/D118924