searching for reviewer(birtles)
c38b3c03d21feedfbce28e0ca1bff0269c35c5e6: Bug 1585589 - Do not reduce the precision of the requestAnimationFrame timestamp if we are in the System Principal Context r=birtles
Tom Ritter <tom@mozilla.com> - Thu, 03 Oct 2019 22:53:28 +0000 - rev 496269
Push 97141 by tritter@mozilla.com at Thu, 03 Oct 2019 23:34:24 +0000
Bug 1585589 - Do not reduce the precision of the requestAnimationFrame timestamp if we are in the System Principal Context r=birtles Differential Revision: https://phabricator.services.mozilla.com/D48118
dcf8bb9eb0db981075bc8864e0a0115b21980d89: Bug 1567330 - Add offset shorthand. r=emilio,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 23 Sep 2019 19:56:33 +0000 - rev 494631
Push 96129 by bchiou@mozilla.com at Tue, 24 Sep 2019 01:06:24 +0000
Bug 1567330 - Add offset shorthand. r=emilio,birtles Also, update the serialization by the shorter perference because this is a new feature and using older syntax doesn't make sense. Besides, use `cssOffset` for web animation IDL attribute name. Differential Revision: https://phabricator.services.mozilla.com/D45607
6d6be499b8323bf1e13b045ad9893e7eb3d2a37d: Bug 1480665 - Implement the contain flag for ray() function. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 16 Sep 2019 23:24:50 +0000 - rev 493651
Push 95623 by bchiou@mozilla.com at Tue, 17 Sep 2019 21:19:51 +0000
Bug 1480665 - Implement the contain flag for ray() function. r=birtles Basically, the math calculation logic is from the github repo of the spec author, Eric: https://github.com/ewilligers/petrogale-purpureicollis/blob/20b7403d85d664eb943232e2a34bc95b6f4a8b62/ray.py#L311-L363 Differential Revision: https://phabricator.services.mozilla.com/D42722
6db0fd0a2252fa3b7a65be0cb054853d2a8837f2: Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles
Boris Chiou <boris.chiou@gmail.com> - Mon, 16 Sep 2019 23:24:48 +0000 - rev 493650
Push 95623 by bchiou@mozilla.com at Tue, 17 Sep 2019 21:19:51 +0000
Bug 1480665 - Support ray() in offset-path and make it animatable. r=emilio,birtles 1. Add `generics::motion::OffsetPath`, and use specified `Angle` and computed `Angle` to define specified `OffsetPath` and computed `OffsetPath`. 2. Add `ray` function into `OffsetPath`. We also tweak the degree from 150deg to 135deg in wpt (e.g. offset-path-ray-001.html and others) to avoid floating point precision issues. For example: ``` // offset-path: ray(150deg ...); // offset-distance: 20px; matrix: { {0.500000 0.866025 0.000000 0.000000}, {-0.866025 0.500000 0.000000 0.000000}, {0.000000 0.000000 1.000000 0.000000}, {10.000000 17.320509 0.000000 1.000000} } // rotate(60deg) translate(20px) matrix: { {0.500000 0.866025 0.000000 0.000000}, {-0.866025 0.500000 0.000000 0.000000}, {0.000000 0.000000 1.000000 0.000000}, {10.000000 17.320507 0.000000 1.000000} } ``` Their translate parts, 17.320509 vs 17.320507, are almost the same (only tiny difference), which may cause the reftest failed. Differential Revision: https://phabricator.services.mozilla.com/D42721
62f5b57b9a03cad3963519d01d00c38e62525d26: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-multicol tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:12 +0000 - rev 491969
Push 94637 by dakatsuka.birchill@mozilla.com at Fri, 06 Sep 2019 04:38:27 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-multicol tests. r=birtles Depends on D44940 Differential Revision: https://phabricator.services.mozilla.com/D44941
2d92a2fa764ab55309211ad2576392a0504188aa: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-transforms tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:03 +0000 - rev 491968
Push 94637 by dakatsuka.birchill@mozilla.com at Fri, 06 Sep 2019 04:38:27 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-transforms tests. r=birtles Depends on D44939 Differential Revision: https://phabricator.services.mozilla.com/D44940
58011a2d3dbc75ca51a3d39819979a88f6663828: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-backgrounds tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:10 +0000 - rev 491967
Push 94637 by dakatsuka.birchill@mozilla.com at Fri, 06 Sep 2019 04:38:27 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-backgrounds tests. r=birtles Depends on D44938 Differential Revision: https://phabricator.services.mozilla.com/D44939
cc83d7fe35d8270ed04318c4c8ad1f6a376e8b37: Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-box tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 06 Sep 2019 04:29:01 +0000 - rev 491966
Push 94637 by dakatsuka.birchill@mozilla.com at Fri, 06 Sep 2019 04:38:27 +0000
Bug 1579062: Turn on dom.animations-api.implicit-keyframes.enabled for css-box tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44938
6f1d654fcf37282daab20dd67806946187c66843: Bug 1578728: Turn on dom.animations-api.implicit-keyframes.enabled for css-shapes tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 05 Sep 2019 06:15:36 +0000 - rev 491819
Push 94529 by dakatsuka.birchill@mozilla.com at Thu, 05 Sep 2019 08:00:44 +0000
Bug 1578728: Turn on dom.animations-api.implicit-keyframes.enabled for css-shapes tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44767
a45c5b31080b2b88b9a287e9b3c35a3f0d2817c7: Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 03 Sep 2019 22:38:45 +0000 - rev 491681
Push 94456 by tritter@mozilla.com at Wed, 04 Sep 2019 14:35:55 +0000
Bug 1577642 - Move the timestamp rounding outside of the loop so it's only reduced once r=birtles When we had it in the loop, we would continually reduce it, which held the possibility of bumping it down an epoch due to double imprecision. Now we only reduce it once, using all rAF callbacks get the same timestamp. Differential Revision: https://phabricator.services.mozilla.com/D44526
725115d70e4f7c4fbd18ff7be5b181a86ba46e3f: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-text tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:01:51 +0000 - rev 490813
Push 94054 by dakatsuka.birchill@mozilla.com at Fri, 30 Aug 2019 05:08:57 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-text tests. r=birtles Depends on D44100 Differential Revision: https://phabricator.services.mozilla.com/D44101
a674f8e0369dabb45b976e205e9f87ef862abb30: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-position tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:01:53 +0000 - rev 490812
Push 94054 by dakatsuka.birchill@mozilla.com at Fri, 30 Aug 2019 05:08:57 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-position tests. r=birtles Depends on D44099 Differential Revision: https://phabricator.services.mozilla.com/D44100
e0978ab17d5de76c867628599269621e5dd36b59: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-fonts tests. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Fri, 30 Aug 2019 05:06:16 +0000 - rev 490811
Push 94054 by dakatsuka.birchill@mozilla.com at Fri, 30 Aug 2019 05:08:57 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled for css-fonts tests. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D44099
02bfa4baa2edd2d1c9417018c4cbd85e99d15aa8: Bug 1577243 - Backed out changeset cae99e27ccdd, restoring document.timeline and rAF timestamp comparisons r=birtles
Tom Ritter <tom@mozilla.com> - Wed, 28 Aug 2019 23:44:14 +0000 - rev 490633
Push 93957 by tritter@mozilla.com at Thu, 29 Aug 2019 14:28:40 +0000
Bug 1577243 - Backed out changeset cae99e27ccdd, restoring document.timeline and rAF timestamp comparisons r=birtles Depends on D43788 Differential Revision: https://phabricator.services.mozilla.com/D43789
565a897065e0deb97864b7635bfb0185e88c4048: Bug 1577243 - Unconditionally clamp the requestAnimationFrame timestamp (and clamp/jitter it in RFP mode) r=birtles
Tom Ritter <tom@mozilla.com> - Wed, 28 Aug 2019 23:44:07 +0000 - rev 490632
Push 93957 by tritter@mozilla.com at Thu, 29 Aug 2019 14:28:40 +0000
Bug 1577243 - Unconditionally clamp the requestAnimationFrame timestamp (and clamp/jitter it in RFP mode) r=birtles In Bug 1387894 we created a mode for Firefox where it unconditionally clamps all timestamps to 20 microseconds. This happens if you disable privacy.reduceTimerPrecision (which is on by default) and is so we don't inadvertently leak super-high-resolution (nanosec) timestamps. As part of that patch, we started clamping animation timestamps - which are exempted from privacy.reduceTimerPrecision because it was too difficult to get them working at the time. (We should still fix that though.) This caused new test failures, and one of those was a comparison between document timelines and the timestamp in requestAnimationFrame. we were not clamping the timestamp in requestAnimationFrame under the logic that it fires in predictable intervals. However discussions about the WPT change we made to 'fix' the now-broken comparison https://github.com/web-platform-tests/wpt/pull/18172 and https://github.com/web-platform-tests/wpt/pull/18357 showed me that document.timeline is supposed to be slaved to the requestAnimationFrame timestamp (or vice versa.) The correct fix is therefore to unconditionally clamp the requestAnimationFrame timestamp AND the document.timeline timestamp. In doing so we also start clamping/jittering the requestAnimationFrame timestamp in Resist Fingerprinting mode, so that might cause some new/unexpected behaviors for that mode we should watch out for. Differential Revision: https://phabricator.services.mozilla.com/D43788
d4b4d46545b3f0c05b8ce7cb5b0e766aa304f9ab: Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/smil r=birtles
Sylvestre Ledru <sledru@mozilla.com> - Thu, 29 Aug 2019 06:37:38 +0000 - rev 490545
Push 93921 by sledru@mozilla.com at Thu, 29 Aug 2019 06:38:11 +0000
Bug 1577236 - clang-10: Fix -Wimplicit-int-float-conversion warnings in dom/smil r=birtles Depends on D43778 Differential Revision: https://phabricator.services.mozilla.com/D43779
c5ef2fb8522499d82d2805a2f77b1739bfafccbc: Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:45:18 +0000 - rev 490537
Push 93915 by dakatsuka.birchill@mozilla.com at Thu, 29 Aug 2019 01:58:59 +0000
Bug 1576892: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D43886
38bd63ec76c797c4d04cc158330af0d45533cd8d: Bug 1577156: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:34:30 +0000 - rev 490536
Push 93914 by dakatsuka.birchill@mozilla.com at Thu, 29 Aug 2019 01:58:00 +0000
Bug 1577156: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Depends on D43886 Differential Revision: https://phabricator.services.mozilla.com/D43887
270abd593fa43bf48038326f8e66a3bb2f2e8276: Bug 1577163: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles
Daisuke Akatsuka <daisuke@birchill.co.jp> - Thu, 29 Aug 2019 01:34:37 +0000 - rev 490535
Push 93913 by dakatsuka.birchill@mozilla.com at Thu, 29 Aug 2019 01:57:31 +0000
Bug 1577163: Turn on dom.animations-api.implicit-keyframes.enabled pref. r=birtles Depends on D43887 Differential Revision: https://phabricator.services.mozilla.com/D43888
1d9715fd32fc3757e7d37d578f9581901c0c6e24: Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 23:16:14 +0000 - rev 486470
Push 91738 by btara@mozilla.com at Mon, 05 Aug 2019 23:36:08 +0000
Bug 1571038 - Copy test logic for scrolled out element to out of view element r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40664
1c82a9581ad6708dce653bcbe4857b095b64f02a: Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles
Tom Ritter <tom@mozilla.com> - Mon, 05 Aug 2019 22:45:48 +0000 - rev 486469
Push 91737 by btara@mozilla.com at Mon, 05 Aug 2019 23:35:12 +0000
Bug 1571227 - Fix test_restyles to account for double imprecision r=birtles Differential Revision: https://phabricator.services.mozilla.com/D40663
7c6c3ac5f8fd987fd47e473e4457266498e48f1f: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 20:12:40 +0000 - rev 486056
Push 91615 by bchiou@mozilla.com at Fri, 02 Aug 2019 21:59:58 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
d47d9f4bf9a9ea8b816534916292ca446c7543ce: Bug 1559231 - Make offset-anchor animatable. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 02 Aug 2019 00:47:09 +0000 - rev 486008
Push 91587 by bchiou@mozilla.com at Fri, 02 Aug 2019 18:29:16 +0000
Bug 1559231 - Make offset-anchor animatable. r=birtles Per the spec issue, https://github.com/w3c/csswg-drafts/issues/3482, we update the wpt to keep the percentage in `calc()` for `offset-anchor`. Differential Revision: https://phabricator.services.mozilla.com/D39552
38e17f634ce4e77bfbf665fe920094012c349bb6: Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:59 +0200 - rev 485921
Push 91534 by archaeopteryx@coole-files.de at Fri, 02 Aug 2019 10:06:18 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests. r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812 Depends on D38811
2c84f4806f91fa54f1580e2bf83e848cf51a85cc: Bug 1387894 - Fix animation WPTs. r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:38 +0200 - rev 485919
Push 91534 by archaeopteryx@coole-files.de at Fri, 02 Aug 2019 10:06:18 +0000
Bug 1387894 - Fix animation WPTs. r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810 Depends on D38809
f07ba3e1ae0d98af129619c5f211b795375ac0ba: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:29 +0200 - rev 485918
Push 91534 by archaeopteryx@coole-files.de at Fri, 02 Aug 2019 10:06:18 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping. r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809 Depends on D38808
e73d900b1dcf01da7c7023d7d6ee70043be5d9cf: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping. r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:19 +0200 - rev 485917
Push 91534 by archaeopteryx@coole-files.de at Fri, 02 Aug 2019 10:06:18 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping. r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808 Depends on D38807
cae99e27ccdd2a8b86f8d054237e318f9add63c0: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping. r=birtles
Tom Ritter <tom@mozilla.com> - Fri, 02 Aug 2019 07:36:09 +0200 - rev 485916
Push 91534 by archaeopteryx@coole-files.de at Fri, 02 Aug 2019 10:06:18 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping. r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807 Depends on D38806
cd58aae7d47bede2f5699c07855676fa6fc26a09: Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:39 +0000 - rev 485362
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812
ef7b589d751b8fd2882d2740439395010715fd4f: Bug 1387894 - Fix animation WPTs r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:17 +0000 - rev 485360
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix animation WPTs r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810
75c0249b594a371d250dca81d1f3c60aaad944a3: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:08 +0000 - rev 485359
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809
4a75f2556242a972fd49c0ef447df7f26de7344e: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:59 +0000 - rev 485358
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808
0bff9ba4237cec4f0fc3a66a6f60a1b588b4ce85: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:50 +0000 - rev 485357
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807
09785dc4c5aa58ddb33531831f60a77371381b1e: Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:15 +0000 - rev 485325
Push 91243 by rmaries@mozilla.com at Tue, 30 Jul 2019 13:47:15 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812
01e5b31bcc179b30b4c9d98d64108860467f4726: Bug 1387894 - Fix animation WPTs r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:06 +0000 - rev 485323
Push 91243 by rmaries@mozilla.com at Tue, 30 Jul 2019 13:47:15 +0000
Bug 1387894 - Fix animation WPTs r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810
c5e16646ddb1166345658a0fbdd6925e568caabc: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485322
Push 91243 by rmaries@mozilla.com at Tue, 30 Jul 2019 13:47:15 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809
d1f09b772baca9dad66477f785bb606a7e83c1bd: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485321
Push 91243 by rmaries@mozilla.com at Tue, 30 Jul 2019 13:47:15 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808
de538a48f45583c6da759fe01760773580b6aada: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 13:19:05 +0000 - rev 485320
Push 91243 by rmaries@mozilla.com at Tue, 30 Jul 2019 13:47:15 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807
654ddf428c9033b9b7f3ce74182efb8c5516faf5: Bug 1564366 - Update animations when a pseudo-element had animations but no longer has, and has been re-framed in the meantime. r=birtles
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 16 Jul 2019 15:42:08 +0000 - rev 482957
Push 90095 by ealvarez@mozilla.com at Tue, 16 Jul 2019 15:49:51 +0000
Bug 1564366 - Update animations when a pseudo-element had animations but no longer has, and has been re-framed in the meantime. r=birtles This is the easy fix. The hard fix (outlined in the comment) would be nice, but I don't think this bug alone justifies it. Differential Revision: https://phabricator.services.mozilla.com/D38184
9f687685a13cb1b0015cfb2f98821e624b42754a: Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Fri, 28 Jun 2019 18:18:08 +0000 - rev 480618
Push 88804 by boris.chiou@gmail.com at Fri, 28 Jun 2019 20:44:20 +0000
Bug 1534884 - Add new animation warning for animations overridden by important rules. r=birtles We move the check of important rule and animation level into KeyframeEffect::ShouldBlockAsyncTransformAnimations(), and add a new warning for it. Note: 1. ShouldBlockAsyncTransformAnimations() only cares about transforms. And for other compositor animation properties, we count on HasEffectiveAnimationOfPropertySet() (in IsMatchForCompositor()). 2. If we check the important rules in both EffectCompositor::HasAnimationsForCompositor() and ActiveLayerTracker::IsTransformMaybeAnimated(), we may get the incorrect animation warnings (i.e. TransformFrameInactive). In most cases, we check these two functions together, so perhaps move the check of important rules outside HasEffectiveAnimationOfPropertySet() is fine. Besides, ActiveLayerTracker just tracks if there is a style change on this property (or display item) on the active layers, so should be OK to not check important rules in it. So IsMatchForCompositor() should check all transform-like properties, instead of each one, to get the correct result. (That's why we have to refactor KeyframeEffect::GetPropertiesForCompositor() as well.) Differential Revision: https://phabricator.services.mozilla.com/D34432
25ed16786ef943e467c94bff2189a5dc25b0b38e: Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles
Hiroyuki Ikezoe <hikezoe@mozilla.com> - Wed, 26 Jun 2019 10:29:37 +0000 - rev 480158
Push 88531 by hikezoe@mozilla.com at Wed, 26 Jun 2019 10:31:26 +0000
Bug 1560704 - Revert the change `transform-style: inherit` added to ::-moz-table-wrapper in ua.css. r=birtles It caused rendering issues just like a reftest in this commit. We don't know the reason but fixing it will be some amount of work which couldn't be uplifted to 68. So we just revert the change here now. Probably we should revisit the problem once we got a bug report that the lack of the `transform-style: inherit` causes rendering issues. Differential Revision: https://phabricator.services.mozilla.com/D35946
0e84cf2872e7002304a700246ae709a8a3a6d9da: Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles
violet <violet.bugreport@gmail.com> - Sun, 23 Jun 2019 23:01:47 +0000 - rev 479921
Push 88362 by violet.bugreport@gmail.com at Mon, 24 Jun 2019 03:25:53 +0000
Bug 1557563 - Add computed value ZeroToOneNumber r=emilio,birtles Correctly handle clamping to 1 behavior of grayscale(), invert(), opacity() and sepia(). Differential Revision: https://phabricator.services.mozilla.com/D35509
17869bc540e5fde8961a19497c3cbb4a4de631f3: Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles
Boris Zbarsky <bzbarsky@mit.edu> - Sun, 09 Jun 2019 22:00:41 +0000 - rev 478270
Push 87622 by bzbarsky@mozilla.com at Tue, 11 Jun 2019 17:03:54 +0000
Bug 1557793 part 1. Fix incorrect template arguments in AnimationPerformanceWarning. r=birtles It looks like bug 1321412 changed the number of params but didn't update the template parameter, and then bug 1364221 followed its example of not matching the template parameter to the actual number of params. As a result we're passing an array with one garbage pointer to the callee, and it just happens that the callee doesn't examine that pointer. But that's about to change. Differential Revision: https://phabricator.services.mozilla.com/D34234
3fe6750f57d7492bcc3620e4976d19b71d98f872: Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles
violet <violet.bugreport@gmail.com> - Tue, 04 Jun 2019 11:59:55 +0000 - rev 476778
Push 87034 by violet.bugreport@gmail.com at Tue, 04 Jun 2019 12:01:16 +0000
Bug 1554488 - Add WPT test for baseVal behavior inside symbol/display:none r=birtles This test is for baseVal behavior interacting with <symbol>, display:none and font-size. Differential Revision: https://phabricator.services.mozilla.com/D32624
eb7d78fdd5d86d713b8ae88f50413d8c23e9d8f9: Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:50 +0000 - rev 475984
Push 86573 by bchiou@mozilla.com at Wed, 29 May 2019 01:53:53 +0000
Bug 1429303 - Add a missing reftest for offset-distance interpolation. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32537
c62c252bb59dac33a79883bc2fcd3e052e713637: Bug 1429303 - Animate offset-rotate. r=birtles
Boris Chiou <boris.chiou@gmail.com> - Tue, 28 May 2019 18:31:48 +0000 - rev 475983
Push 86573 by bchiou@mozilla.com at Wed, 29 May 2019 01:53:53 +0000
Bug 1429303 - Animate offset-rotate. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32237
33a7cec553b2b79b4067416fab3191d19243c3bf: Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 05:06:47 +0000 - rev 475693
Push 86413 by violet.bugreport@gmail.com at Mon, 27 May 2019 09:00:28 +0000
Bug 1554457 - Obtain style from frame rather than GetComputedStyleNoFlush r=emilio,longsonr,birtles These usecases are almost the same as the geometry property stuff. It'd be better to use `GetPrimaryFrame()->Style()` consistently rather than using `GetComputedStyleNoFlush()` here. Differential Revision: https://phabricator.services.mozilla.com/D32613
f4260d7b6296c069b410d7a85decfb58cdf9c0eb: Bug 1552345 - Should not assume en is always an accepted language r=birtles
violet <violet.bugreport@gmail.com> - Mon, 27 May 2019 00:17:13 +0000 - rev 475666
Push 86395 by violet.bugreport@gmail.com at Mon, 27 May 2019 03:38:07 +0000
Bug 1552345 - Should not assume en is always an accepted language r=birtles The test assumes "en" is always an accepted language, it's not correct. This assumption isn't what is being tested here anyway. We should set language preference at the beginning before testing to avoid irrelevant failure. Differential Revision: https://phabricator.services.mozilla.com/D32628
7d73f17d3c58fcadca4d41674973f254ba5f6a6b: Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles
Sebastian Hengst <archaeopteryx@coole-files.de> - Wed, 22 May 2019 23:51:19 +0000 - rev 475302
Push 86239 by archaeopteryx@coole-files.de at Thu, 23 May 2019 22:15:48 +0000
Bug 1553154 - enable animation preferences for test_animation_observers_async.html. r=birtles Differential Revision: https://phabricator.services.mozilla.com/D32035
5514f80c4f48f8dca61cdfc88e2225244c236d19: Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr
violet <violet.bugreport@gmail.com> - Thu, 16 May 2019 13:21:20 +0000 - rev 474721
Push 85953 by violet.bugreport@gmail.com at Tue, 21 May 2019 10:28:22 +0000
Bug 1383650 - Notify style system when SMIL animation changes length r=birtles,longsonr When animating geometry attribute, we need to notify style system about the change of SMIL override style. Differential Revision: https://phabricator.services.mozilla.com/D30361