searching for reviewer(arai)
00a761b7fce83bfe255ac76a65641cd83c5c7915: Bug 1551893: Require strict zero-pad for time element if T exists r=arai
Kagami Sascha Rosylight <saschanaz@outlook.com> - Thu, 16 May 2019 18:02:58 +0000 - rev 474290
Push 85727 by ncsoregi@mozilla.com at Fri, 17 May 2019 03:54:21 +0000
Bug 1551893: Require strict zero-pad for time element if T exists r=arai Make T as a strictness marker for ISO8601 time element, as it already does for the date element. Differential Revision: https://phabricator.services.mozilla.com/D31418
9ae652e07ac2e3481d3cf8ce27a8f12d81d8e79c: Bug 1551916 - Add a boolean to every chunk for a long-line vector indicating whether that chunk contains any multiple-unit code points, so that column computations inside wholly-single-unit chunks can do a constant-time pointer-range computation... r=arai
Jeff Walden <jwalden@mit.edu> - Fri, 17 May 2019 03:21:06 +0000 - rev 474288
Push 85725 by jwalden@mit.edu at Fri, 17 May 2019 03:27:11 +0000
Bug 1551916 - Add a boolean to every chunk for a long-line vector indicating whether that chunk contains any multiple-unit code points, so that column computations inside wholly-single-unit chunks can do a constant-time pointer-range computation... r=arai ...and avoid iterating at all. r=arai Depends on D31302 Differential Revision: https://phabricator.services.mozilla.com/D31303
70c4b663298ae5c4b287d020cc0842625fe6f52c: Bug 1551916 - Optimize column-number computations for offsets more than |ColumnChunkLength = 128| code units into a line by saving column information at 128-unit increments (rounded down to the nearest code point start) so that at most (length of... r=arai
Jeff Walden <jwalden@mit.edu> - Fri, 17 May 2019 03:21:04 +0000 - rev 474287
Push 85725 by jwalden@mit.edu at Fri, 17 May 2019 03:27:11 +0000
Bug 1551916 - Optimize column-number computations for offsets more than |ColumnChunkLength = 128| code units into a line by saving column information at 128-unit increments (rounded down to the nearest code point start) so that at most (length of... r=arai ...longest code point encoding - 1) + ColumnChunkLength - 1 units must be observed when computing a column number. r=arai Depends on D31301 Differential Revision: https://phabricator.services.mozilla.com/D31302
04cce27de4ac16500981c23558b355cfe4ddc186: Bug 1551916 - Make JS_COLUMN_DIMENSION_IS_CODE_POINTS a no-argument macro function so that calling it before its definition is an error, and move it upward in TokenStream.h so it's defined in places where subsequent changes will need it. r=arai
Jeff Walden <jwalden@mit.edu> - Fri, 17 May 2019 03:21:02 +0000 - rev 474286
Push 85725 by jwalden@mit.edu at Fri, 17 May 2019 03:27:11 +0000
Bug 1551916 - Make JS_COLUMN_DIMENSION_IS_CODE_POINTS a no-argument macro function so that calling it before its definition is an error, and move it upward in TokenStream.h so it's defined in places where subsequent changes will need it. r=arai Differential Revision: https://phabricator.services.mozilla.com/D31301
c5180b76c35305e08385c338101b6f7e18ae1641: Bug 1551916 - Remove |TokenStreamAnyChars::undoInternalUpdateLineInfoForEOL| as unused. r=arai
Jeff Walden <jwalden@mit.edu> - Fri, 17 May 2019 03:20:58 +0000 - rev 474285
Push 85725 by jwalden@mit.edu at Fri, 17 May 2019 03:27:11 +0000
Bug 1551916 - Remove |TokenStreamAnyChars::undoInternalUpdateLineInfoForEOL| as unused. r=arai Differential Revision: https://phabricator.services.mozilla.com/D31300
69c5ef5e60352efbfb03e562eb77c9f30ac32690: Bug 1550949: Disallow time-only version of ISO8601 r=arai
Kagami Sascha Rosylight <saschanaz@outlook.com> - Wed, 15 May 2019 14:03:54 +0000 - rev 473953
Push 85561 by btara@mozilla.com at Wed, 15 May 2019 14:13:27 +0000
Bug 1550949: Disallow time-only version of ISO8601 r=arai ES5.1 removed time-only format T00:00:00 and no other browsers support it. So this diff removes the support from gecko. Differential Revision: https://phabricator.services.mozilla.com/D31253
efacc855c35612cec29992fd6149e38db2fd1690: Bug 1500748 - Require standard compliance when a time part exists r=arai
Kagami Sascha Rosylight <saschanaz@outlook.com> - Sun, 12 May 2019 10:23:14 +0000 - rev 473563
Push 85296 by nbeleuzu@mozilla.com at Sun, 12 May 2019 10:44:48 +0000
Bug 1500748 - Require standard compliance when a time part exists r=arai Differential Revision: https://phabricator.services.mozilla.com/D30761
c3ea428d6b2a4ab026fea0e1dc5c0776720d1b2d: Bug 1547039: Adjust async-generator state when manually closing an async-generator. r=arai
André Bargull <andre.bargull@gmail.com> - Tue, 07 May 2019 04:11:58 +0000 - rev 472960
Push 84938 by ncsoregi@mozilla.com at Tue, 07 May 2019 19:13:37 +0000
Bug 1547039: Adjust async-generator state when manually closing an async-generator. r=arai Similar to AutoSetGeneratorRunning, AdjustGeneratorResumptionValue also needs to modify the async-generator state in addition to the shared generator state. Differential Revision: https://phabricator.services.mozilla.com/D30035
26d207ba289e2b3e04eabe5da8dde3c67c32cf2e: Bug 1255165 - Improve error message for TypeArray.prototype.set if source array is too large;r=arai
Vincent Lequertier <vi.le@autistici.org> - Wed, 24 Apr 2019 02:39:57 +0000 - rev 472011
Push 84403 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 17:31:55 +0000
Bug 1255165 - Improve error message for TypeArray.prototype.set if source array is too large;r=arai Differential Revision: https://phabricator.services.mozilla.com/D28308
ce9c122d9c32087f63c8d5a053cb24c97a546bbe: Bug 1547809 - Respond to partially-ignored review comments in bug 1544882, and incidentally fix a minor regression that nitpicking would have made a bit more obvious. :-| Aggressively, r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 29 Apr 2019 18:55:46 -0700 - rev 471922
Push 84358 by archaeopteryx@coole-files.de at Tue, 30 Apr 2019 11:36:40 +0000
Bug 1547809 - Respond to partially-ignored review comments in bug 1544882, and incidentally fix a minor regression that nitpicking would have made a bit more obvious. :-| Aggressively, r=arai
e516adb0ff9e98281e8be4b3e642c6d878ca259c: Bug 1545751 - In BinAST, pass Context while parsing;r=arai
David Teller <dteller@mozilla.com> - Mon, 29 Apr 2019 17:24:55 +0000 - rev 471793
Push 84274 by dteller@mozilla.com at Mon, 29 Apr 2019 17:47:27 +0000
Bug 1545751 - In BinAST, pass Context while parsing;r=arai The Context 0.1 format specifies that the (de)compression of nodes is determined by: - its node type; - its parent type; - the index in the parent node; - whether the node is an element of an array. This patch modifies the parser generator to pass the information during parsing. Differential Revision: https://phabricator.services.mozilla.com/D28534
c89cf3ac460f35aa4c0516410c25e88e0f6cc8e6: Bug 1546327 - Clean up bytecode and source note allocation. r=arai
Jan de Mooij <jdemooij@mozilla.com> - Mon, 29 Apr 2019 12:55:20 +0000 - rev 471748
Push 84255 by jdemooij@mozilla.com at Mon, 29 Apr 2019 12:56:32 +0000
Bug 1546327 - Clean up bytecode and source note allocation. r=arai Differential Revision: https://phabricator.services.mozilla.com/D28469
af5f74d9a5668542afa6209c77e10fd5148b30ba: Bug 1547655 - Move RootedAtom before LabelEmitter to work around LabelControl issues with Maybe<> and RootedAtom. r=arai
Jan de Mooij <jdemooij@mozilla.com> - Mon, 29 Apr 2019 12:01:19 +0000 - rev 471746
Push 84253 by jdemooij@mozilla.com at Mon, 29 Apr 2019 12:51:53 +0000
Bug 1547655 - Move RootedAtom before LabelEmitter to work around LabelControl issues with Maybe<> and RootedAtom. r=arai Differential Revision: https://phabricator.services.mozilla.com/D29186
2dcd3edb3c5d13410f9ae2943c103b9b9cda3afb: Bug 1546603 - Don't finalize stream sources from JS if creating the stream object failed, r=arai.
Brian Hackett <bhackett1024@gmail.com> - Thu, 25 Apr 2019 12:13:30 -1000 - rev 471711
Push 84232 by dluca@mozilla.com at Sun, 28 Apr 2019 09:46:18 +0000
Bug 1546603 - Don't finalize stream sources from JS if creating the stream object failed, r=arai. Differential Revision: https://phabricator.services.mozilla.com/D28931
1b05b45b9abee67390ef1e69c6eb750172bb8015: Bug 1544882 - Make js::SourceHook load either UTF-8 or UTF-16 source text, depending upon the source type of the ScriptSource in question. r=arai
Jeff Walden <jwalden@mit.edu> - Fri, 12 Apr 2019 17:20:18 -0700 - rev 471654
Push 84213 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:51:43 +0000
Bug 1544882 - Make js::SourceHook load either UTF-8 or UTF-16 source text, depending upon the source type of the ScriptSource in question. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27777
b3053863705de3052ab27429f8a3df023581354e: Bug 1544882 - Split ScriptSource::Retrievable<Unit> out of Missing to record sources that are retrievable even tho they're missing. (Only UTF-16 is supported for now.) r=arai
Jeff Walden <jwalden@mit.edu> - Thu, 25 Apr 2019 11:10:25 -0700 - rev 471653
Push 84213 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:51:43 +0000
Bug 1544882 - Split ScriptSource::Retrievable<Unit> out of Missing to record sources that are retrievable even tho they're missing. (Only UTF-16 is supported for now.) r=arai Differential Revision: https://phabricator.services.mozilla.com/D27776
808585ce159839b9b1babe1f90be0120c79298ca: Bug 1544882 - XDR ScriptSource data almost entirely by switching on the type of data stored in |ScriptSource::data|. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 17 Apr 2019 00:57:46 -0700 - rev 471652
Push 84213 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:51:43 +0000
Bug 1544882 - XDR ScriptSource data almost entirely by switching on the type of data stored in |ScriptSource::data|. r=arai Differential Revision: https://phabricator.services.mozilla.com/D28924
641a364dcb54ae09689e73d7b8e1d30f12fa7705: Bug 1544882 - Move XDR of ScriptSource::data and a couple related values into its own standalone function, for simplicity/to reduce complexity when SS::data is XDR'd using variant-matching code. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 16 Apr 2019 15:27:44 -0700 - rev 471651
Push 84213 by nbeleuzu@mozilla.com at Sat, 27 Apr 2019 09:51:43 +0000
Bug 1544882 - Move XDR of ScriptSource::data and a couple related values into its own standalone function, for simplicity/to reduce complexity when SS::data is XDR'd using variant-matching code. r=arai Differential Revision: https://phabricator.services.mozilla.com/D28923
8be1bf5f1e97eb1a01ecd83e422d18b537027767: Bug 1544882 - Convert ScriptSource::setSource to ScriptSource::setUncompressedSourceHelper as a helper function that more-precise functions can call. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 19:18:05 -0700 - rev 471479
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Convert ScriptSource::setSource to ScriptSource::setUncompressedSourceHelper as a helper function that more-precise functions can call. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27775
d137eb73db95e59bc9647eb9d5d284e92c8ca957: Bug 1544882 - Inline ScriptSource::setSource<Unit>(SourceTypeTraits<Unit>::SharedImmutableString) into its two callers for clarity. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 18:48:27 -0700 - rev 471478
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Inline ScriptSource::setSource<Unit>(SourceTypeTraits<Unit>::SharedImmutableString) into its two callers for clarity. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27773
d4d8e4bf895f84f9a6a62080b6eebb6100ccd484: Bug 1544882 - Add ScriptSource::setRetrievedSource to clarify the ScriptSource::data state transition when retrieved source is set. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 18:37:41 -0700 - rev 471477
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Add ScriptSource::setRetrievedSource to clarify the ScriptSource::data state transition when retrieved source is set. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27772
7e238465037a8a9f7fedb033e50c9d4e9cb9c5f6: Bug 1544882 - Split ScriptSource::setCompressedSource into ScriptSource::{convertTo,initializeWith}CompressedSource so that ScriptSource::data's state transitions are clearer. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 18:09:26 -0700 - rev 471476
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Split ScriptSource::setCompressedSource into ScriptSource::{convertTo,initializeWith}CompressedSource so that ScriptSource::data's state transitions are clearer. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27771
762b78b66248061140984b2a2876a329c6479389: Bug 1544882 - Make BytecodeCompiler::assignSource<Unit>(...) directly defer to a new ScriptSource::assignSource<Unit>(...) function. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 16:55:51 -0700 - rev 471475
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Make BytecodeCompiler::assignSource<Unit>(...) directly defer to a new ScriptSource::assignSource<Unit>(...) function. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27770
14248be0eba939ce2317e887e205386ad3214774: Bug 1544882 - Reformulate ScriptSource::loadSource into Variant-matching code. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 15:35:44 -0700 - rev 471474
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Reformulate ScriptSource::loadSource into Variant-matching code. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27769
8509f60299dfdb085a8a64ea45522bacb82b16c5: Bug 1544882 - Move JSScript::loadSource into ScriptSource, because it only acts on ScriptSource and so only makes sense there. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 15:09:01 -0700 - rev 471473
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Move JSScript::loadSource into ScriptSource, because it only acts on ScriptSource and so only makes sense there. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27768
74774a7f1a4dd13925354df4e3963068fc4cd28d: Bug 1544882 - Rename JSScript::tryLoadSource back to JSScript::loadSource now that all users have recognized the semantics change. r=arai
Jeff Walden <jwalden@mit.edu> - Mon, 15 Apr 2019 14:57:24 -0700 - rev 471472
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Rename JSScript::tryLoadSource back to JSScript::loadSource now that all users have recognized the semantics change. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27767
2af8656bd3c0362939cda478005e9eb2238ed9b5: Bug 1544882 - Make |JSScript::loadSource| applicable to any |ScriptSource| by folding its precondition into its behavior. r=arai
Jeff Walden <jwalden@mit.edu> - Thu, 11 Apr 2019 18:22:56 -0700 - rev 471471
Push 84118 by rmaries@mozilla.com at Fri, 26 Apr 2019 09:57:26 +0000
Bug 1544882 - Make |JSScript::loadSource| applicable to any |ScriptSource| by folding its precondition into its behavior. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27766
d0eebfb3d9160645793e1ad8a04b89b76faad529: Bug 1545751 - In BinAST, pass Context while parsing;r=arai
David Teller <dteller@mozilla.com> - Thu, 25 Apr 2019 08:07:57 +0000 - rev 471308
Push 84025 by dteller@mozilla.com at Thu, 25 Apr 2019 13:53:47 +0000
Bug 1545751 - In BinAST, pass Context while parsing;r=arai The Context 0.1 format specifies that the (de)compression of nodes is determined by: - its node type; - its parent type; - the index in the parent node; - whether the node is an element of an array. This patch modifies the parser generator to pass the information during parsing. Differential Revision: https://phabricator.services.mozilla.com/D28534
a296a09b1ad10df66320e1726198e35b4ed99aef: Bug 1545354: Don't try to reject an already resolved async function promise on OOM. r=arai
André Bargull <andre.bargull@gmail.com> - Tue, 23 Apr 2019 16:53:38 +0000 - rev 470697
Push 83916 by csabou@mozilla.com at Wed, 24 Apr 2019 15:55:04 +0000
Bug 1545354: Don't try to reject an already resolved async function promise on OOM. r=arai Differential Revision: https://phabricator.services.mozilla.com/D28476
a4847e3f634ec14d42e78cbf0be98314080726d4: Bug 1545751 - In BinAST, pass Context while parsing;r=arai
David Teller <dteller@mozilla.com> - Wed, 24 Apr 2019 09:27:00 +0000 - rev 470623
Push 83867 by dteller@mozilla.com at Wed, 24 Apr 2019 09:29:31 +0000
Bug 1545751 - In BinAST, pass Context while parsing;r=arai The Context 0.1 format specifies that the (de)compression of nodes is determined by: - its node type; - its parent type; - the index in the parent node; - whether the node is an element of an array. This patch modifies the parser generator to pass the information during parsing. Differential Revision: https://phabricator.services.mozilla.com/D28534
0905d8963ffab547436a67d3e7d5597fb1fd4846: Bug 1545782 - Store BinVariant and BinField as int16_t r=arai
David Teller <dteller@mozilla.com> - Fri, 19 Apr 2019 18:57:40 +0000 - rev 470261
Push 83628 by dteller@mozilla.com at Fri, 19 Apr 2019 20:31:08 +0000
Bug 1545782 - Store BinVariant and BinField as int16_t r=arai This will help us convert between a context (BinVariant, BinField) and a int32_t. Differential Revision: https://phabricator.services.mozilla.com/D28208
badb8ef128dd0c11dd6ef284585d7a4edb0626fd: Bug 1406146 - Remove modified debugger jit-tests from BinAST suite. r=arai
Ted Campbell <tcampbell@mozilla.com> - Wed, 10 Apr 2019 16:22:42 +0000 - rev 469954
Push 83452 by tcampbell@mozilla.com at Wed, 17 Apr 2019 23:19:50 +0000
Bug 1406146 - Remove modified debugger jit-tests from BinAST suite. r=arai These tests use our non-standard Debugger interface and there are minor changes needed for them to run in the case of WindowProxy in shell. Differential Revision: https://phabricator.services.mozilla.com/D26902
6c23754dcb407a1e1138a87abba334b058f5c164: Bug 1544737 - Make AbstractGeneratorObject::ResumeKind an enum class, rename to js::GeneratorResumeKind. r=arai
Jan de Mooij <jdemooij@mozilla.com> - Tue, 16 Apr 2019 11:32:10 +0000 - rev 469677
Push 83282 by jdemooij@mozilla.com at Tue, 16 Apr 2019 13:08:01 +0000
Bug 1544737 - Make AbstractGeneratorObject::ResumeKind an enum class, rename to js::GeneratorResumeKind. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27662
3b3201f491e6f266d3d1956f929c81de58210a0c: Bug 1543498 - Make PAC scripts be compiled directly as UTF-8 without inflating. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 10 Apr 2019 10:54:02 -0700 - rev 469225
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543498 - Make PAC scripts be compiled directly as UTF-8 without inflating. r=arai Differential Revision: https://phabricator.services.mozilla.com/D27174
6ceeb37b708d10ecb1f7584c83aff9705394ad1c: Bug 1543458 - Compile UTF-8 files in jsapi-tests without inflating to UTF-16. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 10 Apr 2019 10:19:00 -0700 - rev 469224
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543458 - Compile UTF-8 files in jsapi-tests without inflating to UTF-16. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26957
e0c75d5168bea9578a1a7b0877aaea1343bbb75a: Bug 1543458 - Compile lines of UTF-8 interactive input to xpcshell and jsshell without inflating to UTF-16. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 10 Apr 2019 09:42:58 -0700 - rev 469223
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543458 - Compile lines of UTF-8 interactive input to xpcshell and jsshell without inflating to UTF-16. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26956
73742301cb65f2fe88531a9d1572094edb33ad21: Bug 1543455 - Make JS::{Compile,Evaluate}Utf8Path operate directly on UTF-8 data without first inflating it. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 14:35:02 -0700 - rev 469221
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543455 - Make JS::{Compile,Evaluate}Utf8Path operate directly on UTF-8 data without first inflating it. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26950
40edaa2016ccbbeb60ec320c755110c357afbd9b: Bug 1543458 - Perform non-inflating nonsyntactic UTF-8 compilation in jsapi-tests. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 10 Apr 2019 09:19:30 -0700 - rev 469220
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543458 - Perform non-inflating nonsyntactic UTF-8 compilation in jsapi-tests. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26955
ed24501174af4b6db6af29d4f61c4047a5ca611a: Bug 1543458 - Perform non-inflating syntactic UTF-8 compilation in jsapi-tests. r=arai
Jeff Walden <jwalden@mit.edu> - Wed, 10 Apr 2019 09:08:53 -0700 - rev 469219
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543458 - Perform non-inflating syntactic UTF-8 compilation in jsapi-tests. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26954
f3907d97ead5961b21d2eb4dd5a57fe076691131: Bug 1543455 - Don't document JS::CompileUtf8FileDontInflate as invoking functionality with known bugs now that the last known bug's been fixed -- just suggest it's experimental. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 18:29:43 -0700 - rev 469218
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543455 - Don't document JS::CompileUtf8FileDontInflate as invoking functionality with known bugs now that the last known bug's been fixed -- just suggest it's experimental. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26953
210168fff4a94efb05ef2d2d85c1288d1eee247b: Bug 1543455 - Inline a static function in vm/CompilationAndEvaluation.cpp into its sole call site. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 18:23:09 -0700 - rev 469217
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543455 - Inline a static function in vm/CompilationAndEvaluation.cpp into its sole call site. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26952
75f351cf467a123f709ebaccc4f12747314fa58a: Bug 1543455 - Make JS::CompileUtf8{,ForNonSyntacticScope} omit Utf8 from their names and take SourceText<Utf8Unit>&. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 17:03:32 -0700 - rev 469216
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543455 - Make JS::CompileUtf8{,ForNonSyntacticScope} omit Utf8 from their names and take SourceText<Utf8Unit>&. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26951
c8ddb203209d92be18b411a22e5d25622b6d7d11: Bug 1543455 - Rename JS::EvaluateUtf8 to JS::Evaluate and make it take |JS::SourceText<mozilla::Utf8Unit>&| for consistency with the UTF-16 form of the API. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 13:56:18 -0700 - rev 469215
Push 83013 by csabou@mozilla.com at Fri, 12 Apr 2019 03:48:25 +0000
Bug 1543455 - Rename JS::EvaluateUtf8 to JS::Evaluate and make it take |JS::SourceText<mozilla::Utf8Unit>&| for consistency with the UTF-16 form of the API. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26949
b410f871d04a6b3f20f606b131a52d052f4e239a: Bug 1543420 - Ban SlashIsInvalid followed by SlashIsDiv. r=arai
Jason Orendorff <jorendorff@mozilla.com> - Wed, 10 Apr 2019 16:24:38 +0000 - rev 468911
Push 82851 by jorendorff@mozilla.com at Thu, 11 Apr 2019 00:11:42 +0000
Bug 1543420 - Ban SlashIsInvalid followed by SlashIsDiv. r=arai With this change, the use of SlashIsInvalid at the top of GeneralParser<>::classMember obliges us to use the same modifier when getting the same token later (in both classMember and propertyName). Differential Revision: https://phabricator.services.mozilla.com/D26928
79a1164b8780efe5b643a906bad4de096c0c373a: Bug 1543472 - Make align_stack_comment.py take multiple arguments. r=arai
Ashley Hauck <khyperia@mozilla.com> - Wed, 10 Apr 2019 20:20:40 +0000 - rev 468906
Push 82846 by ahauck@mozilla.com at Thu, 11 Apr 2019 00:07:49 +0000
Bug 1543472 - Make align_stack_comment.py take multiple arguments. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26965
5c5765ae3e648c812c09e86b76ca59d297363cb2: Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 17:58:52 +0000 - rev 468622
Push 82698 by jwalden@mit.edu at Tue, 09 Apr 2019 18:04:41 +0000
Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26616
53e379a5738feb54107333ef592198263ea1cf44: Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 17:24:31 +0000 - rev 468619
Push 82696 by jwalden@mit.edu at Tue, 09 Apr 2019 17:25:39 +0000
Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26616
d470f958ea613268f839f8346e983dc9d8820c06: Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 03:50:03 +0000 - rev 468591
Push 82683 by jwalden@mit.edu at Tue, 09 Apr 2019 16:03:48 +0000
Bug 1542910 - Make all script compilation APIs directly return a JSScript*, rather than returning a success code and returning the JSScript* via outparam that exactly duplicates the success code value's meaning. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26616
79e4fd335dc6e5454d5819eb613a266679531093: Bug 1542910 - Make JS::CompileFunction return a JSFunction* directly, instead of by outparam for no good reason. r=arai
Jeff Walden <jwalden@mit.edu> - Tue, 09 Apr 2019 03:49:58 +0000 - rev 468483
Push 82617 by jwalden@mit.edu at Tue, 09 Apr 2019 03:54:43 +0000
Bug 1542910 - Make JS::CompileFunction return a JSFunction* directly, instead of by outparam for no good reason. r=arai Differential Revision: https://phabricator.services.mozilla.com/D26615
68ca7447ef6215900af104931b108746fb854089: Bug 1535626: Extend range of FOR_OF_ITERCLOSE trynotes until scope exit r=arai
Iain Ireland <iireland@mozilla.com> - Mon, 08 Apr 2019 20:53:21 +0000 - rev 468440
Push 82587 by iireland@mozilla.com at Mon, 08 Apr 2019 20:56:43 +0000
Bug 1535626: Extend range of FOR_OF_ITERCLOSE trynotes until scope exit r=arai When breaking out of nested for-of loops, we emit code to close each of the iterators, and we cover each of those code segments with an individual FOR_OF_ITERCLOSE trynote. When TryNoteIter walks through the trynotes, it sees a single FOR_OF_ITERCLOSE trynote at the current pc, and skips past one enclosing for-of. This is insufficient for the case where an outer iterator throws an exception while being closed. This patch fixes that problem. The new semantics for FOR_OF_ITERCLOSE trynotes are: a FOR_OF_ITERCLOSE trynote begins as soon as we clear ther iterator slot on the stack, and continues until we leave the scope. It indicates that the innermost unclosed for-of iterator has been closed. Nested FOR_OF_ITERCLOSE trynotes indicate that nested for-of iterators have been closed. This is my first patch touching the frontend, so it's probably horribly unidiomatic. I am open to suggestions for better ways to structure this. Differential Revision: https://phabricator.services.mozilla.com/D26572