searching for reviewer(aosmond)
67975e339c73de478a3a7660ba6f7daebb2c89db: Bug 1783421 - Don't cache an hb_face_t in gfxFontEntry to share between font instances, as it is not thread-safe. r=aosmond
Jonathan Kew <jkew@mozilla.com> - Sat, 06 Aug 2022 11:54:00 +0000 - rev 626358
Push 167460 by jkew@mozilla.com at Sat, 06 Aug 2022 11:58:04 +0000
Bug 1783421 - Don't cache an hb_face_t in gfxFontEntry to share between font instances, as it is not thread-safe. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153853
d6e8192da203e140a64e833fc2144fb3486f86ee: Bug 1783182 - Revise wpt test conditions that got clobbered by wpt-sync. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Sat, 06 Aug 2022 03:38:18 +0000 - rev 626351
Push 167457 by lsalzman@mozilla.com at Sat, 06 Aug 2022 03:42:25 +0000
Bug 1783182 - Revise wpt test conditions that got clobbered by wpt-sync. r=aosmond,gfx-reviewers Per advice from James Graham, if we don't want the wpt-sync bot to modify the conditions, then we have to specify them in terms of condition that won't apply to the try runs it uses to update the conditions. This means we must specify conditions with "not nightly_build" so that they won't apply to the try run, and thus don't get updated. It's a bit uglier, but manageable and we can eventually replace these once things ride the trains. Differential Revision: https://phabricator.services.mozilla.com/D153764
c32962d08e6c36fa350f2a24f184fff65cf0524a: Bug 1781064 - Get buffer size directly from BufferTextureData. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 05 Aug 2022 18:48:48 +0000 - rev 626348
Push 167454 by lsalzman@mozilla.com at Fri, 05 Aug 2022 18:51:13 +0000
Bug 1781064 - Get buffer size directly from BufferTextureData. r=aosmond,gfx-reviewers Since the BufferTextureData is getting created based on ImageDataSerialize::ComputeRGBBufferSize, the stride may be padded for alignment which doesn't agree with the simple calculation duplicated here. In general, it is less error-prone to just ask the BufferTextureData itself for its buffer size, so just do that here instead rather than trying to make duplicate calculations with invalid assumptions. Differential Revision: https://phabricator.services.mozilla.com/D153868
00c45094026a8d589e8d2d6127bcc3fc16966436: Bug 1783182 - Revise wpt test conditions that got clobbered by wpt-sync. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 05 Aug 2022 16:28:22 +0000 - rev 626345
Push 167451 by lsalzman@mozilla.com at Fri, 05 Aug 2022 16:30:45 +0000
Bug 1783182 - Revise wpt test conditions that got clobbered by wpt-sync. r=aosmond,gfx-reviewers Per advice from James Graham, if we don't want the wpt-sync bot to modify the conditions, then we have to specify them in terms of condition that won't apply to the try runs it uses to update the conditions. This means we must specify conditions with "not nightly_build" so that they won't apply to the try run, and thus don't get updated. It's a bit uglier, but manageable and we can eventually replace these once things ride the trains. Differential Revision: https://phabricator.services.mozilla.com/D153764
113f49c15b47806a1da3a834cca2e3a8ce1cea34: Bug 1783141 - Adjust fuzz for incorrect_display_in_bytestream_vp9.html. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 05 Aug 2022 16:20:04 +0000 - rev 626344
Push 167450 by lsalzman@mozilla.com at Fri, 05 Aug 2022 16:24:07 +0000
Bug 1783141 - Adjust fuzz for incorrect_display_in_bytestream_vp9.html. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D153767
6f0f72915ef90917d376b9d7a51a6094ea26a1b8: Bug 1783421 - Don't cache an hb_face_t in gfxFontEntry to share between font instances, as it is not thread-safe. r=aosmond
Jonathan Kew <jkew@mozilla.com> - Fri, 05 Aug 2022 15:07:41 +0000 - rev 626343
Push 167449 by jkew@mozilla.com at Fri, 05 Aug 2022 15:10:07 +0000
Bug 1783421 - Don't cache an hb_face_t in gfxFontEntry to share between font instances, as it is not thread-safe. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153853
8d392cb8c537f088696baa06ffbdd10c73f510f3: Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond
Jonathan Kew <jkew@mozilla.com> - Thu, 04 Aug 2022 21:24:11 +0000 - rev 626298
Push 167425 by jkew@mozilla.com at Thu, 04 Aug 2022 21:26:38 +0000
Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D153444
a3b604b751e84f9a53838653936658bbdcb36dd7: Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond
Jonathan Kew <jkew@mozilla.com> - Thu, 04 Aug 2022 14:12:52 +0000 - rev 626212
Push 167386 by jkew@mozilla.com at Thu, 04 Aug 2022 14:15:22 +0000
Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D153444
b1ee6c6dd7ec53ae9725dbfcdd2b0812ce5943e6: Bug 1783053 - Disable DMABUF_SURFACE_EXPORT on Qualcomm. r=aosmond
Leonard Lausen <leonard@lausen.nl> - Wed, 03 Aug 2022 21:23:50 +0000 - rev 626089
Push 167324 by aosmond@mozilla.com at Wed, 03 Aug 2022 21:28:33 +0000
Bug 1783053 - Disable DMABUF_SURFACE_EXPORT on Qualcomm. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153660
8d96a7c14d334e9cd7dee73e62761fa857f8a1d3: Bug 1782247 - Don't track images if our frame is not associated to them. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Aug 2022 18:23:43 +0000 - rev 626069
Push 167311 by ealvarez@mozilla.com at Wed, 03 Aug 2022 18:27:59 +0000
Bug 1782247 - Don't track images if our frame is not associated to them. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153474
ea288d88571f815a7728ca20ec2894ad120474e7: Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond
Jonathan Kew <jkew@mozilla.com> - Wed, 03 Aug 2022 15:52:45 +0000 - rev 626032
Push 167294 by jkew@mozilla.com at Wed, 03 Aug 2022 16:20:35 +0000
Bug 1779205 - part 2 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D153444
ed8d8e120de930076d7263341d5edfc467d39bc8: Bug 1782838 - Include ccov builds in fail condition. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Wed, 03 Aug 2022 15:08:45 +0000 - rev 626021
Push 167285 by lsalzman@mozilla.com at Wed, 03 Aug 2022 15:15:54 +0000
Bug 1782838 - Include ccov builds in fail condition. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D153540
cebf54456944e7ca31ce7916387c7ea6eb7891dd: Bug 1782247 - Don't track images if our frame is not associated to them. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 03 Aug 2022 01:40:37 +0000 - rev 625853
Push 167238 by ealvarez@mozilla.com at Wed, 03 Aug 2022 01:43:00 +0000
Bug 1782247 - Don't track images if our frame is not associated to them. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153474
3ac703c87e3c7e1c9a1e8ad85722589d1dbf1a14: Bug 1782838 - Include ccov builds in fail condition. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Wed, 03 Aug 2022 01:12:34 +0000 - rev 625850
Push 167235 by lsalzman@mozilla.com at Wed, 03 Aug 2022 01:14:57 +0000
Bug 1782838 - Include ccov builds in fail condition. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D153540
4c274fdd42f088d0c2dc8013f59c2a961b3de2f8: Bug 1781555 - Fix fail condition for DOMMatrix2DInit-validate-fixup.html. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Tue, 02 Aug 2022 16:21:59 +0000 - rev 625779
Push 167195 by lsalzman@mozilla.com at Tue, 02 Aug 2022 16:24:21 +0000
Bug 1781555 - Fix fail condition for DOMMatrix2DInit-validate-fixup.html. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153307
7a7e7bb6cdffafa70284f486369d87e32d296eb7: Bug 1781776 - Fix pass condition for drawImage-from-blob.tentative.html. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Tue, 02 Aug 2022 16:20:47 +0000 - rev 625778
Push 167194 by lsalzman@mozilla.com at Tue, 02 Aug 2022 16:23:13 +0000
Bug 1781776 - Fix pass condition for drawImage-from-blob.tentative.html. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153358
f0d33d0689087a6255e544526f6846085e6ec460: Bug 1779205 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond
Jonathan Kew <jkew@mozilla.com> - Tue, 02 Aug 2022 11:47:11 +0000 - rev 625738
Push 167163 by jkew@mozilla.com at Tue, 02 Aug 2022 11:49:34 +0000
Bug 1779205 - Drop variation tables entirely during sanitization if we don't support variations on the current platform. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D153444
7c7de0fb66e13bf58b55a075b645ac34f6519855: Bug 1771374 - Fix build and lint warnings. r=gfx-reviewers,aosmond
Kelsey Gilbert <kelsey.gilbert@mozilla.com> - Mon, 01 Aug 2022 19:49:27 +0000 - rev 625661
Push 167121 by jgilbert@mozilla.com at Mon, 01 Aug 2022 19:54:11 +0000
Bug 1771374 - Fix build and lint warnings. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D150620
dce608b43d9630b4c79920f83cd053a93c4c7900: Bug 1782443 - Call MarkSkiaChanged in DrawTargetWebgl::LockBits. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Mon, 01 Aug 2022 15:29:49 +0000 - rev 625639
Push 167105 by lsalzman@mozilla.com at Mon, 01 Aug 2022 15:32:13 +0000
Bug 1782443 - Call MarkSkiaChanged in DrawTargetWebgl::LockBits. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153317
261c4baf7f303197051181a6cb3e238fe186ec9d: Bug 1771007 - Add testcase. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Sun, 31 Jul 2022 15:36:59 +0000 - rev 625584
Push 167071 by lsalzman@mozilla.com at Sun, 31 Jul 2022 15:39:27 +0000
Bug 1771007 - Add testcase. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D153308
fa22da3375db0f048e217376f6857e9c6b341d20: Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Tue, 26 Jul 2022 13:41:32 +0000 - rev 625172
Push 166819 by lsalzman@mozilla.com at Tue, 26 Jul 2022 13:43:57 +0000
Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers mWebglValid gets initialized to false, but it will never get reset to true until the next frame, causing us to render into Skia the first frame rather than accelerate. Therefor, we should just initialize it to valid. Since it is cleared to zero initially, this is safe. Differential Revision: https://phabricator.services.mozilla.com/D151896
79318e64621821da03dd16b678051e88c70161dd: Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r=aosmond
Timothy Nikkel <tnikkel@gmail.com> - Tue, 26 Jul 2022 08:24:27 +0000 - rev 625148
Push 166800 by tnikkel@mozilla.com at Tue, 26 Jul 2022 08:27:40 +0000
Bug 1780834. If a webp file header specifies ICCP but no ICCP chunk is found just ignore it and continue. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D152588
4b19d16c4fec81cca21b3fc341cebf71f8f623aa: Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Tue, 26 Jul 2022 01:30:45 +0000 - rev 625110
Push 166784 by lsalzman@mozilla.com at Tue, 26 Jul 2022 01:33:10 +0000
Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers mWebglValid gets initialized to false, but it will never get reset to true until the next frame, causing us to render into Skia the first frame rather than accelerate. Therefor, we should just initialize it to valid. Since it is cleared to zero initially, this is safe. Differential Revision: https://phabricator.services.mozilla.com/D151896
4e6a14748df6ba049d5eb72e242d2aff12dad95e: Bug 1779766 - Ensure DrawTargetWebgl is done using shmem before dealloc. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 15 Jul 2022 20:34:19 +0000 - rev 624200
Push 166290 by lsalzman@mozilla.com at Fri, 15 Jul 2022 20:36:45 +0000
Bug 1779766 - Ensure DrawTargetWebgl is done using shmem before dealloc. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151957
951f438df1753bf749722de1c95507a8069f6629: Bug 1779804 - Check for valid target in DrawTargetWebgl before accessing shmem. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 15 Jul 2022 16:34:02 +0000 - rev 624191
Push 166281 by lsalzman@mozilla.com at Fri, 15 Jul 2022 16:36:38 +0000
Bug 1779804 - Check for valid target in DrawTargetWebgl before accessing shmem. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151938
3112a6346071785641588fe0c0442990c080d3d4: Bug 1779387 - Restore clip root parenting for now r=gfx-reviewers,aosmond
Glenn Watson <git@intuitionlibrary.com> - Fri, 15 Jul 2022 04:16:07 +0000 - rev 624127
Push 166252 by gwatson@mozilla.com at Fri, 15 Jul 2022 04:18:32 +0000
Bug 1779387 - Restore clip root parenting for now r=gfx-reviewers,aosmond There are some hit-test use cases that still rely on clip-chains and invalid clip-chain handles inheriting from the root clip-id for a pipeline. This will become irrelevant once the clip-tree patches land next week, but for now we can restore these to fix a regression going out in a release. Differential Revision: https://phabricator.services.mozilla.com/D151880
2e2286de9ab9eef614c98fcb9b6b1c6d1fa216e4: Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 15 Jul 2022 02:29:01 +0000 - rev 624117
Push 166245 by lsalzman@mozilla.com at Fri, 15 Jul 2022 02:34:17 +0000
Bug 1779681 - Mark WebGL framebuffer as initially valid in DrawTargetWebgl. r=aosmond,gfx-reviewers mWebglValid gets initialized to false, but it will never get reset to true until the next frame, causing us to render into Skia the first frame rather than accelerate. Therefor, we should just initialize it to valid. Since it is cleared to zero initially, this is safe. Differential Revision: https://phabricator.services.mozilla.com/D151896
813986baa96d99dfb3f9b16e28388c41d7cf5f11: Bug 1779684 - Mark more surface types as IsDataSourceSurface. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Fri, 15 Jul 2022 02:27:58 +0000 - rev 624116
Push 166244 by lsalzman@mozilla.com at Fri, 15 Jul 2022 02:33:46 +0000
Bug 1779684 - Mark more surface types as IsDataSourceSurface. r=aosmond,gfx-reviewers We spend a significant amount of time in profiles allocating DataSourceSurfaceWrapper when GetDataSurface is called inside DrawTargetWebgl. We can mark some more surface types as IsDataSurface to work around this fairly easily. Differential Revision: https://phabricator.services.mozilla.com/D151898
09e0fa770021501e4cb1c243109f437b6b47cb18: Bug 1779342 - Force any Skia snapshots to copy the shmem before it deallocs. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Thu, 14 Jul 2022 21:15:45 +0000 - rev 624099
Push 166233 by lsalzman@mozilla.com at Thu, 14 Jul 2022 21:38:03 +0000
Bug 1779342 - Force any Skia snapshots to copy the shmem before it deallocs. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D151876
dbb5202d0c0fed4caa1b68297f163bfd4b2a71c2: Bug 1779598 - Stop passing around Maybe<SVGImageContext>. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Jul 2022 16:03:25 +0000 - rev 623978
Push 166205 by ealvarez@mozilla.com at Thu, 14 Jul 2022 16:05:50 +0000
Bug 1779598 - Stop passing around Maybe<SVGImageContext>. r=aosmond All its members are optional, so we can just use it as a plain struct rather than Maybe<> all around, which simplifies the code and prevents silly bugs like bug 1779592. Mostly automatic via: rg -l 'SVGImageContext' . | xargs sed -i 's/Maybe<SVGImageContext>/SVGImageContext/g' With trivial build fixes. Not intended to change behavior. Differential Revision: https://phabricator.services.mozilla.com/D151846
36feeae0273fd4a3743ae8b02dad10abe96de608: Bug 1779592 - Fix a bug in DrawImageInternal uncovered by bug 1779457. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Jul 2022 15:40:22 +0000 - rev 623970
Push 166197 by ealvarez@mozilla.com at Thu, 14 Jul 2022 15:43:03 +0000
Bug 1779592 - Fix a bug in DrawImageInternal uncovered by bug 1779457. r=aosmond We want to ensure the right viewport is set. Differential Revision: https://phabricator.services.mozilla.com/D151840
33fbecca098c163ff086113225f580d67a53c611: Bug 1779457 - Make prefers-color-scheme of SVG images match embedder on content too. r=aosmond
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 14 Jul 2022 10:04:38 +0000 - rev 623945
Push 166172 by ealvarez@mozilla.com at Thu, 14 Jul 2022 10:07:06 +0000
Bug 1779457 - Make prefers-color-scheme of SVG images match embedder on content too. r=aosmond As per discussion in https://github.com/w3c/csswg-drafts/issues/7213. Differential Revision: https://phabricator.services.mozilla.com/D151751
28bb76d444f5be41d2a112e7073ea1d0b0a343ec: Bug 1778908 - Implement the fontKerning attribute for Canvas2d text. r=gfx-reviewers,aosmond,emilio
Jonathan Kew <jkew@mozilla.com> - Wed, 13 Jul 2022 18:55:37 +0000 - rev 623861
Push 166135 by jkew@mozilla.com at Wed, 13 Jul 2022 18:58:03 +0000
Bug 1778908 - Implement the fontKerning attribute for Canvas2d text. r=gfx-reviewers,aosmond,emilio Per spec, the value of fontKerning should be an enum, not a string, but currently we handle all the keyword-valued canvas attributes in this way. We may want to convert them to enums (which will mean that unrecognized values throw an error instead of being ignored), but I think that should be done for all the attributes together as a separate bug. For now, using a string here provides consistency with the rest of the canvas APIs. Note that Blink's current implementation and the existing WPT tests have some problems: they treat the values of fontKerning as case-insensitive, which is wrong. I have filed https://bugs.chromium.org/p/chromium/issues/detail?id=1343333 about this. Differential Revision: https://phabricator.services.mozilla.com/D151755
1d93ccc72ff33996137c20de108da0ef0734c1d2: Bug 1779410 - Ensure SwapChainPresenter destructor is called before we access the front buffer. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Wed, 13 Jul 2022 17:27:03 +0000 - rev 623852
Push 166128 by lsalzman@mozilla.com at Wed, 13 Jul 2022 17:46:17 +0000
Bug 1779410 - Ensure SwapChainPresenter destructor is called before we access the front buffer. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D151732
9f5cf953fcc8e3822089aa7f1d31512c1e6e06cf: Bug 1771374 - Fix build and lint warnings. r=gfx-reviewers,aosmond
Kelsey Gilbert <kelsey.gilbert@mozilla.com> - Tue, 12 Jul 2022 23:55:51 +0000 - rev 623727
Push 166087 by jgilbert@mozilla.com at Wed, 13 Jul 2022 00:27:22 +0000
Bug 1771374 - Fix build and lint warnings. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D150620
ea595572b3922c6ae4e034b6af82c05750b692f4: Bug 1778114 Disable DMABUF_SURFACE_EXPORT on AMD r=jgilbert,aosmond
stransky <stransky@redhat.com> - Tue, 12 Jul 2022 19:05:47 +0000 - rev 623710
Push 166073 by stransky@redhat.com at Tue, 12 Jul 2022 22:11:48 +0000
Bug 1778114 Disable DMABUF_SURFACE_EXPORT on AMD r=jgilbert,aosmond Differential Revision: https://phabricator.services.mozilla.com/D151587
856332401a32b07c8fd31d28b66097be92aa93d2: Bug 1779227 - Add a WPT reftest. r=aosmond
Jonathan Kew <jkew@mozilla.com> - Tue, 12 Jul 2022 18:36:32 +0000 - rev 623705
Push 166070 by jkew@mozilla.com at Tue, 12 Jul 2022 22:10:00 +0000
Bug 1779227 - Add a WPT reftest. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D151646
adb9c0a3c38f092b66bba71da3c8aa7c9caf2968: Bug 1779227 - Enable the font attribute to be set on a disconnected <canvas> element without throwing an error. r=aosmond
Jonathan Kew <jkew@mozilla.com> - Tue, 12 Jul 2022 18:36:32 +0000 - rev 623704
Push 166070 by jkew@mozilla.com at Tue, 12 Jul 2022 22:10:00 +0000
Bug 1779227 - Enable the font attribute to be set on a disconnected <canvas> element without throwing an error. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D151627
317c9080847f563596199d7abdb3884dd07f0f09: Bug 1779010 - Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Tue, 12 Jul 2022 08:11:06 +0000 - rev 623626
Push 166023 by lsalzman@mozilla.com at Tue, 12 Jul 2022 08:13:32 +0000
Bug 1779010 - Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151511
579b9df20237dd58c13835ea0ecb2a41699da24b: Bug 1779010 - Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Tue, 12 Jul 2022 07:00:46 +0000 - rev 623621
Push 166019 by lsalzman@mozilla.com at Tue, 12 Jul 2022 07:03:11 +0000
Bug 1779010 - Rely on WebGL zero initializing buffers in DrawTargetWebgl. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151511
509b05b741a2c5b27f467f9bd8c45bb1f32902da: Bug 1777426 - Ensure MemoryTextureData frees memory when owned by RemoteTextureMap. r=aosmond,gfx-reviewers
Lee Salzman <lsalzman@mozilla.com> - Tue, 12 Jul 2022 06:56:21 +0000 - rev 623619
Push 166017 by lsalzman@mozilla.com at Tue, 12 Jul 2022 06:59:01 +0000
Bug 1777426 - Ensure MemoryTextureData frees memory when owned by RemoteTextureMap. r=aosmond,gfx-reviewers Differential Revision: https://phabricator.services.mozilla.com/D151422
2fdaa8eca97c844585850721193bfb3f87281a69: Bug 1777426 - Remove CopySnapshotTo in favor of async present. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Tue, 12 Jul 2022 06:56:20 +0000 - rev 623618
Push 166017 by lsalzman@mozilla.com at Tue, 12 Jul 2022 06:59:01 +0000
Bug 1777426 - Remove CopySnapshotTo in favor of async present. r=aosmond With async present we can now rely on being able to do readbacks from WebGL in the GPU process, rather than needing CopySnapshotTo to accelerate this in the content process. Just remove CopySnapshotTo since it doesn't help anymore. Differential Revision: https://phabricator.services.mozilla.com/D150721
7bd6e0c436e740aab449ea1423bf6431e096cf63: Bug 1777426 - Add gfx.canvas.accelerated.async-present for toggling async present with Canvas2D independent of WebGL. r=aosmond
Lee Salzman <lsalzman@mozilla.com> - Tue, 12 Jul 2022 06:56:20 +0000 - rev 623617
Push 166017 by lsalzman@mozilla.com at Tue, 12 Jul 2022 06:59:01 +0000
Bug 1777426 - Add gfx.canvas.accelerated.async-present for toggling async present with Canvas2D independent of WebGL. r=aosmond Differential Revision: https://phabricator.services.mozilla.com/D150881
789d9363b2be0b3bdf322e227de77e780c4f2901: Bug 1777927 - Force-disable VAAPI if vaapitest() failed, r=gfx-reviewers,aosmond
Robert Mader <robert.mader@posteo.de> - Tue, 12 Jul 2022 01:49:39 +0000 - rev 623579
Push 166001 by robert.mader@posteo.de at Tue, 12 Jul 2022 01:52:21 +0000
Bug 1777927 - Force-disable VAAPI if vaapitest() failed, r=gfx-reviewers,aosmond `vaapitest()` is meant to be a sanity check. If it failed there's likely something very broken about the driver and we log gfx warnings accordingly, allowing to debug the problem. Ensure to force-disable VAAPI in this case but still allow users to enable the feature in blocklisted cases. While on it add some additional fixes for issues encoutered while testing: - `InitVAAPIConfig()` was not run on X11-only builds, wrongly setting `sLayersSupportsHardwareVideoDecoding` to `true` there on allowlisted drivers. Thus replace `MOZ_WAYLAND` with `MOZ_WIDGET_GTK`, ensuring the "Wayland support missing" warning is shown in `about:support`. - `UserForceEnable` must be run before `ForceDisable`, otherwise an assert is triggered on debug builds. Reorder this. - `GetFeatureStatus` was run twice for `FEATURE_HARDWARE_VIDEO_DECODING`, once in `InitAcceleration()` in the common code path, the again in `InitVAAPIConfig()`. Untangle the common code path to only run `InitVAAPIConfig()`. - Use the chance to turn `media.hardware-video-decoding.enabled` into a static pref so it matches `media.hardware-video-decoding.force-enabled` Differential Revision: https://phabricator.services.mozilla.com/D150959
eae66c448e16c50ef2746854fb6e4de1997d9a70: Bug 1777927 - Force-disable VAAPI if vaapitest() failed, r=gfx-reviewers,aosmond
Robert Mader <robert.mader@posteo.de> - Tue, 12 Jul 2022 00:00:59 +0000 - rev 623574
Push 165997 by robert.mader@posteo.de at Tue, 12 Jul 2022 00:03:24 +0000
Bug 1777927 - Force-disable VAAPI if vaapitest() failed, r=gfx-reviewers,aosmond `vaapitest()` is meant to be a sanity check. If it failed there's likely something very broken about the driver and we log gfx warnings accordingly, allowing to debug the problem. Ensure to force-disable VAAPI in this case but still allow users to enable the feature in blocklisted cases. While on it add some additional fixes for issues encoutered while testing: - `InitVAAPIConfig()` was not run on X11-only builds, wrongly setting `sLayersSupportsHardwareVideoDecoding` to `true` there on allowlisted drivers. Thus replace `MOZ_WAYLAND` with `MOZ_WIDGET_GTK`, ensuring the "Wayland support missing" warning is shown in `about:support`. - `UserForceEnable` must be run before `ForceDisable`, otherwise an assert is triggered on debug builds. Reorder this. - `GetFeatureStatus` was run twice for `FEATURE_HARDWARE_VIDEO_DECODING`, once in `InitAcceleration()` in the common code path, the again in `InitVAAPIConfig()`. Untangle the common code path to only run `InitVAAPIConfig()`. - Use the chance to turn `media.hardware-video-decoding.enabled` into a static pref so it matches `media.hardware-video-decoding.force-enabled` Differential Revision: https://phabricator.services.mozilla.com/D150959
c2fa0b7167f26257e522156e07171dd63fe5ca05: Bug 1779069 - Assert that we only ever use a GLContext on its original thread. r=gfx-reviewers,aosmond
Kelsey Gilbert <jgilbert@mozilla.com> - Tue, 12 Jul 2022 00:00:28 +0000 - rev 623573
Push 165996 by jgilbert@mozilla.com at Tue, 12 Jul 2022 00:02:52 +0000
Bug 1779069 - Assert that we only ever use a GLContext on its original thread. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D151540
1f8d3df1b73f01707f0d112eb3b9ecc27e5773d2: Bug 1778855 - Remove unused gfxEnv getters. r=gfx-reviewers,aosmond
Kelsey Gilbert <kelsey.gilbert@mozilla.com> - Mon, 11 Jul 2022 23:59:53 +0000 - rev 623571
Push 165995 by jgilbert@mozilla.com at Tue, 12 Jul 2022 00:02:21 +0000
Bug 1778855 - Remove unused gfxEnv getters. r=gfx-reviewers,aosmond Differential Revision: https://phabricator.services.mozilla.com/D151546
39fecab5c852d2ed3bd4ef452b3c063863766327: Bug 1778651 - Add gfxCriticalNote for negative ANativeWindow size r=gfx-reviewers,geckoview-reviewers,aosmond,owlish
Jamie Nicol <jnicol@mozilla.com> - Fri, 08 Jul 2022 15:19:14 +0000 - rev 623374
Push 165880 by jnicol@mozilla.com at Fri, 08 Jul 2022 15:21:36 +0000
Bug 1778651 - Add gfxCriticalNote for negative ANativeWindow size r=gfx-reviewers,geckoview-reviewers,aosmond,owlish One possible cause of the failures to create an EGLSurface we are seeing in bug 1772839 is that the Surface's underlying BufferQueue has already been abandoned. In such circumstances, ANativeWindow_getWidth/Height will return a negative value. If this occurs, ensure we annotate crash reports via gfxCriticalNote. This will allow us to determine whether the crashes we are seeing are indeed due to an abandoned BufferQueue, or some other reason. Differential Revision: https://phabricator.services.mozilla.com/D151360
50901e1befca4c30e18e8311649f13a357afce78: Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio
Nicolas Silva <nsilva@mozilla.com> - Fri, 08 Jul 2022 08:11:39 +0000 - rev 623318
Push 165850 by nsilva@mozilla.com at Fri, 08 Jul 2022 08:14:10 +0000
Bug 1750576 - WebGPU shader module asynchronous CompilationInfo API. r=aosmond,emilio This patch is a lot of plumbing for not that much functionality. The goal is to align CreateShaderModule's error reporting with the spec. Creating a shader module is now a dedicated async IPDL message returning the compilation info so that it can be exposed as a promise by the WebGPU API. Differential Revision: https://phabricator.services.mozilla.com/D146817
0d8bccc8c20bd0e86fcc0ef370822e308dc9de76: Bug 1778431 - Allocate canvas render thread for out-of-process WebGL r=gfx-reviewers,aosmond
sotaro <sotaro.ikeda.g@gmail.com> - Fri, 08 Jul 2022 04:02:41 +0000 - rev 623313
Push 165845 by sikeda.birchill@mozilla.com at Fri, 08 Jul 2022 04:05:08 +0000
Bug 1778431 - Allocate canvas render thread for out-of-process WebGL r=gfx-reviewers,aosmond If dedicated thread for out-of-process WebGL exists, compositor thread tasks are not delayed by WebGL tasks. And Bug 1712486 requests that WebGL run on non-compositor thread. Differential Revision: https://phabricator.services.mozilla.com/D151210