searching for reviewer(aklotz)
9ec199693b08166bc0bdc5f6335a162190e553bc: Bug 1685703 - Make the dllServicesDisable RAII object cover all of XRE_mainRun, including the call to nsAppStartup::Run. r=aklotz
Markus Stange <mstange.moz@gmail.com> - Fri, 08 Jan 2021 17:52:18 +0000 - rev 562483
Push 133799 by mstange@themasta.com at Fri, 08 Jan 2021 18:10:26 +0000
Bug 1685703 - Make the dllServicesDisable RAII object cover all of XRE_mainRun, including the call to nsAppStartup::Run. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D101201
d0c2b70d78adad186310ee83b97d83cb415b71ac: Bug 1684761 - Pass null principal for external loads. r=aklotz,ckerschb
Agi Sferro <agi@sferro.dev> - Thu, 07 Jan 2021 21:36:33 +0000 - rev 562373
Push 133736 by asferro@mozilla.com at Thu, 07 Jan 2021 21:39:02 +0000
Bug 1684761 - Pass null principal for external loads. r=aklotz,ckerschb Differential Revision: https://phabricator.services.mozilla.com/D100837
6662de5ba407159089ea442c6be1ebd6937991df: Bug 1682668 - Add GeckoResult.map. r=owlish,aklotz
Agi Sferro <agi@sferro.dev> - Wed, 06 Jan 2021 20:18:54 +0000 - rev 562196
Push 133653 by asferro@mozilla.com at Wed, 06 Jan 2021 20:21:36 +0000
Bug 1682668 - Add GeckoResult.map. r=owlish,aklotz This method allows callers to synchronously map a GeckoResult value to another value. Differential Revision: https://phabricator.services.mozilla.com/D96950
0407ee33d80aef08263d0fa55f0144cdd3d3b39f: Bug 1671497 - Remove deprecated loadUri methods. r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 05 Jan 2021 22:33:09 +0000 - rev 562092
Push 133579 by asferro@mozilla.com at Tue, 05 Jan 2021 22:35:54 +0000
Bug 1671497 - Remove deprecated loadUri methods. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D99836
7a338e2e07e2ac237f5ccb664a91fd49635c348d: Bug 1671497 - Removed deprecated REPLACED_UNSAFE_CONTENT r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 05 Jan 2021 22:33:17 +0000 - rev 562091
Push 133579 by asferro@mozilla.com at Tue, 05 Jan 2021 22:35:54 +0000
Bug 1671497 - Removed deprecated REPLACED_UNSAFE_CONTENT r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D99835
3dd198cecf8c9e4f9379071971b5e765094c034d: Bug 1669036 - Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:54 +0000 - rev 560284
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik This patch introduces a new flag `EXCLUDE_STACKINFO_FROM_LOADEVENTS` to the `Telemetry.getUntrustedModuleLoadEvents()` to excude the "combinedStacks" field. With this flag, we can merge an instance of `UntrustedModulesData` into a JS object directly. Differential Revision: https://phabricator.services.mozilla.com/D93831
5b4ce82056629f45b37e9e6f8d339561985e6526: Bug 1669036 - Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:57 +0000 - rev 560283
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik This patch introduces a new flag `INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS` to the `Telemetry.getUntrustedModuleLoadEvents()` to include a file object instead of the string field `resolvedDllName` so that the JS caller can have more flexibility. Differential Revision: https://phabricator.services.mozilla.com/D93830
5d5f43a4d5d03cf3707131aeaf6d72f7362545cb: Bug 1669036 - Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:59 +0000 - rev 560282
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik The method `Telemetry.getUntrustedModuleLoadEvents()` used to move data, meaning once it was called, the returned data was removed from the application so that the same data would never be returned again. To show third-party modules info on about:support, we need to keep data even after it's submitted as telemetry. At the same time, we need to know which loading events have been submitted and which have not. With this patch UntrustedModulesBackupService holds two storages named "Staging" and "Settled" respectively. To achieve the behavior described earlier, we use the "Staging" to keep instances not yet submitted, and "Settled" to keep instances already submitted. This patch also introduces two flags `INCLUDE_OLD_LOADEVENTS` and `KEEP_LOADEVENTS_NEW` under `nsITelemetry`, with which the caller of `getUntrustedModuleLoadEvents()` can control which instances to be returned and how the returned instances are kept internally. Differential Revision: https://phabricator.services.mozilla.com/D93829
b56353063d54dbd59bda64b63d3aea2d9c77ee22: Bug 1669036 - Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:38 +0000 - rev 560281
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D93828
ace784f1e51b3b800060058241d40cee0e6a1998: Bug 1669036 - Part4: Introduce UntrustedModulesBackupData r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:40 +0000 - rev 560280
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part4: Introduce UntrustedModulesBackupData r=aklotz This patch introduces a new strcuture `UntrustedModulesBackupData`, which is designed to hold multiple `UntrustedModulesData` instances as a hash table whose key is a pair of PID and ProcessType. When `Telemetry.getUntrustedModuleLoadEvents()` is invoked, an instance of `UntrustedModulesData` is transferred from each process to the main process, converted into a JS object, and deleted. With this "backup" concept, we keep `UntrustedModulesData` instances after it's converted into a JS object, so that we can retrieve it later. Subsequent patches use data in the backup to show on about:support page. Depends on D93825 Differential Revision: https://phabricator.services.mozilla.com/D93827
301794281a553822fd8ec4858760e1f75910ef9d: Bug 1669036 - Part2: Introduce UntrustedModulesDataSerializer r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:45 +0000 - rev 560278
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part2: Introduce UntrustedModulesDataSerializer r=aklotz This patch refactors the function design to convert `UntrustedModulesData` to a JS object by introducing `UntrustedModulesDataSerializer`, with which we can serialize multiple data objects into a single JS object with more flexibility. Differential Revision: https://phabricator.services.mozilla.com/D93824
d1c79db20cb38b8b999328b01adf1fb080ffded1: Bug 1669036 - Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 21:52:47 +0000 - rev 560277
Push 132558 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 23:53:39 +0000
Bug 1669036 - Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz This is a test-only change adding a new testsuite to test the infrastructure of the third-party modules ping. Differential Revision: https://phabricator.services.mozilla.com/D93823
ad3942a4c1f28a1609d899140c8e44072097fe2e: Bug 1669036 - Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:19:24 +0000 - rev 560266
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part8: Add EXCLUDE_STACKINFO_FROM_LOADEVENTS r=aklotz,janerik This patch introduces a new flag `EXCLUDE_STACKINFO_FROM_LOADEVENTS` to the `Telemetry.getUntrustedModuleLoadEvents()` to excude the "combinedStacks" field. With this flag, we can merge an instance of `UntrustedModulesData` into a JS object directly. Differential Revision: https://phabricator.services.mozilla.com/D93831
2d3dd096f49f278a29aca374301047f9cb58a4ce: Bug 1669036 - Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:19:02 +0000 - rev 560265
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part7: Add INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS r=aklotz,janerik This patch introduces a new flag `INCLUDE_PRIVATE_FIELDS_IN_LOADEVENTS` to the `Telemetry.getUntrustedModuleLoadEvents()` to include a file object instead of the string field `resolvedDllName` so that the JS caller can have more flexibility. Differential Revision: https://phabricator.services.mozilla.com/D93830
cd782ea33949f52b1b7376261a852834c46aadbb: Bug 1669036 - Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:18:54 +0000 - rev 560264
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part6: Introduce options for Telemetry.getUntrustedModuleLoadEvents() to control data r=aklotz,janerik The method `Telemetry.getUntrustedModuleLoadEvents()` used to move data, meaning once it was called, the returned data was removed from the application so that the same data would never be returned again. To show third-party modules info on about:support, we need to keep data even after it's submitted as telemetry. At the same time, we need to know which loading events have been submitted and which have not. With this patch UntrustedModulesBackupService holds two storages named "Staging" and "Settled" respectively. To achieve the behavior described earlier, we use the "Staging" to keep instances not yet submitted, and "Settled" to keep instances already submitted. This patch also introduces two flags `INCLUDE_OLD_LOADEVENTS` and `KEEP_LOADEVENTS_NEW` under `nsITelemetry`, with which the caller of `getUntrustedModuleLoadEvents()` can control which instances to be returned and how the returned instances are kept internally. Differential Revision: https://phabricator.services.mozilla.com/D93829
a025cdac711c87b76326e3f01bb742a464ac5879: Bug 1669036 - Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:18:36 +0000 - rev 560263
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part5: Add the process type to the key of a per-proc object of the third-party module ping r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D93828
91549922741fc8f93dd73a7fcbc87e9e82dee7cc: Bug 1669036 - Part4: Introduce UntrustedModulesBackupData r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:18:13 +0000 - rev 560262
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part4: Introduce UntrustedModulesBackupData r=aklotz This patch introduces a new strcuture `UntrustedModulesBackupData`, which is designed to hold multiple `UntrustedModulesData` instances as a hash table whose key is a pair of PID and ProcessType. When `Telemetry.getUntrustedModuleLoadEvents()` is invoked, an instance of `UntrustedModulesData` is transferred from each process to the main process, converted into a JS object, and deleted. With this "backup" concept, we keep `UntrustedModulesData` instances after it's converted into a JS object, so that we can retrieve it later. Subsequent patches use data in the backup to show on about:support page. Depends on D93825 Differential Revision: https://phabricator.services.mozilla.com/D93827
9d35204f6569ae406d8ea6914a52bccb6f06f227: Bug 1669036 - Part2: Introduce UntrustedModulesDataSerializer r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:41:17 +0000 - rev 560260
Push 132550 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:51:39 +0000
Bug 1669036 - Part2: Introduce UntrustedModulesDataSerializer r=aklotz This patch refactors the function design to convert `UntrustedModulesData` to a JS object by introducing `UntrustedModulesDataSerializer`, with which we can serialize multiple data objects into a single JS object with more flexibility. Differential Revision: https://phabricator.services.mozilla.com/D93824
2e779792d8650978291674e79f5e5857e08a5b97: Bug 1669036 - Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Thu, 10 Dec 2020 20:17:17 +0000 - rev 560257
Push 132547 by nbeleuzu@mozilla.com at Thu, 10 Dec 2020 20:39:05 +0000
Bug 1669036 - Part1: Add a new GTest suite UntrustedModulesFixture r=aklotz This is a test-only change adding a new testsuite to test the infrastructure of the third-party modules ping. Differential Revision: https://phabricator.services.mozilla.com/D93823
79aca2b9e53ac862e368eefc6062aa23415f9350: Bug 1672262 - Remove workaround for duplicated START events. r=aklotz
Agi Sferro <agi@sferro.dev> - Fri, 04 Dec 2020 20:11:13 +0000 - rev 559560
Push 132140 by asferro@mozilla.com at Fri, 04 Dec 2020 20:13:40 +0000
Bug 1672262 - Remove workaround for duplicated START events. r=aklotz The underlying problem has been fixed in Bug 1661833. Differential Revision: https://phabricator.services.mozilla.com/D98686
ec6a64b639a82e957376c09a71aef7ce62b3a5aa: Bug 1657404 - Implement a strongly-typed, service-dependent gamepad handle r=handyman,aklotz
Chris Martin <cmartin@mozilla.com> - Wed, 02 Dec 2020 23:06:05 +0000 - rev 559161
Push 131976 by cmartin@mozilla.com at Wed, 02 Dec 2020 23:24:22 +0000
Bug 1657404 - Implement a strongly-typed, service-dependent gamepad handle r=handyman,aklotz Currently, the gamepad code uses a uint32_t as a handle and does some trickery with it by trying to create a unique ID and adding an offset to it for VR code. This can (and has) led to errors where the developer forgets to perform the arithmetic and sends the wrong number to the wrong manager. This change created a strongly-typed handle that remembers which service it belongs to. This should eliminate such accidents. Differential Revision: https://phabricator.services.mozilla.com/D96273
23cb629a4c7c2f3bf16b1c063e1cfd6000fab9eb: Bug 1680042 - Fix "detroyed" typos. DONTBUILD r=necko-reviewers,geckoview-reviewers,aklotz
Andrew McCreight <continuation@gmail.com> - Tue, 01 Dec 2020 17:35:54 +0000 - rev 558954
Push 131854 by amccreight@mozilla.com at Tue, 01 Dec 2020 17:38:29 +0000
Bug 1680042 - Fix "detroyed" typos. DONTBUILD r=necko-reviewers,geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D98341
a8da02cb71d618d1bd545366b1186b6bcb0150ba: Bug 1529510 - Move ProcInfo to processtoolsservice;r=aklotz,mstange
Tarek Ziadé <tarek@mozilla.com> - Thu, 12 Nov 2020 17:42:54 +0000 - rev 557375
Push 131036 by tziade@mozilla.com at Mon, 16 Nov 2020 17:10:54 +0000
Bug 1529510 - Move ProcInfo to processtoolsservice;r=aklotz,mstange With this change, we expose ProcInfo to Android. Differential Revision: https://phabricator.services.mozilla.com/D94810
b940f0ddf5026e2399e9e7a006a1e90797e8d97f: Bug 1669419 - Remove unnecessary literal string constant from nsDataObj::CMemStream::Stat. r=aklotz
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 13 Oct 2020 21:39:09 +0000 - rev 552912
Push 128589 by aklotz@mozilla.com at Wed, 14 Oct 2020 04:25:11 +0000
Bug 1669419 - Remove unnecessary literal string constant from nsDataObj::CMemStream::Stat. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D92617
46c0b8ec1432dc3849eb3c4d9529755ae0b525f6: Bug 1665661 - Opt into UnusedZero<WindowsError>::value == true to enable mozilla::Result optimizations. r=aklotz
Simon Giesecke <sgiesecke@mozilla.com> - Mon, 12 Oct 2020 13:48:43 +0000 - rev 552729
Push 128461 by sgiesecke@mozilla.com at Mon, 12 Oct 2020 14:27:43 +0000
Bug 1665661 - Opt into UnusedZero<WindowsError>::value == true to enable mozilla::Result optimizations. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D90685
fc42ab7c51894dfef81cdc9ac4350864fb68c91e: Bug 1468250 - Block all versions of database.dll to stop the crash. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Fri, 09 Oct 2020 20:39:58 +0000 - rev 552558
Push 128373 by rmaries@mozilla.com at Fri, 09 Oct 2020 21:05:34 +0000
Bug 1468250 - Block all versions of database.dll to stop the crash. r=aklotz We blocked the older versions of database.dll as Bug 1566109 in 2019, but the same crash is still happening with the newer versions. We decided to block all versions because crashing in the middle of printing or file uploading is not acceptable. Differential Revision: https://phabricator.services.mozilla.com/D92988
4b99cd59c105d2ef7947a7654f104d30994eab75: Bug 1652259 - Update client margins when DPI changes r=aklotz
Kagami Sascha Rosylight <krosylight@mozilla.com> - Thu, 08 Oct 2020 21:45:30 +0000 - rev 552316
Push 128277 by aklotz@mozilla.com at Fri, 09 Oct 2020 02:09:24 +0000
Bug 1652259 - Update client margins when DPI changes r=aklotz Currently margin values only change when the window goes fullscreen, causes unexpected white borders when moving to a lower-DPI display. This patch fixes that by updating the values whenever DPI changes. Differential Revision: https://phabricator.services.mozilla.com/D89493
21d7ee08c104ff7595e4ab9cca178fe933c14e06: Bug 1664099 - Replace MOZ_MUST_USE with [[nodiscard]] in libjar. r=aklotz
Chris Peterson <cpeterson@mozilla.com> - Wed, 23 Sep 2020 17:07:13 +0000 - rev 550104
Push 127092 by cpeterson@mozilla.com at Thu, 24 Sep 2020 02:31:32 +0000
Bug 1664099 - Replace MOZ_MUST_USE with [[nodiscard]] in libjar. r=aklotz The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute. Differential Revision: https://phabricator.services.mozilla.com/D91094
3bcf703cd64c7d2e3fbff3f14e6cacb24822fab1: Bug 1666310 - Enable IOInterposer on early beta r=aklotz
Doug Thayer <dothayer@mozilla.com> - Mon, 21 Sep 2020 21:32:07 +0000 - rev 549554
Push 126858 by dothayer@mozilla.com at Tue, 22 Sep 2020 01:01:59 +0000
Bug 1666310 - Enable IOInterposer on early beta r=aklotz We want to collect information on late writes via telemetry. We have been doing this in Nightly for a while now, but want to do so in beta/release. I was actually initially unaware of this limitation of the IOInterposer, but we need the IOInterposer to collect information on late writes, so I would like to enable it for just early beta, in the hopes that we can catch any late writes that may be happening, without adding a performance tax onto release. Accordingly, is perf the only reason that this was restricted to Nightly? And if so, did we measure a perf difference, or was this just general caution regarding the performance impact? Is there anything else to look out for? Differential Revision: https://phabricator.services.mozilla.com/D90894
b1a38140966e91ab11543f11f3bffd4ca24a2349: Bug 1660546 - Ensure Surface is released when closing GeckoSession r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Tue, 01 Sep 2020 18:52:28 +0000 - rev 547481
Push 125563 by jwillcox@mozilla.com at Wed, 02 Sep 2020 14:22:32 +0000
Bug 1660546 - Ensure Surface is released when closing GeckoSession r=geckoview-reviewers,aklotz Without this, the asynchronous nature of compositor shutdown causes races if the Android surface is immediately reused with another GeckoSession instance. Differential Revision: https://phabricator.services.mozilla.com/D89025
b2ead6bc3facebe8d23c483e89374a4ca7d4cdfb: Bug 1630444: Part3 - Send the launcher process failure ping from the browser process. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 26 Aug 2020 19:01:27 +0000 - rev 546350
Push 125060 by cbrindusan@mozilla.com at Wed, 26 Aug 2020 19:17:04 +0000
Bug 1630444: Part3 - Send the launcher process failure ping from the browser process. r=aklotz This patch adds a new property `process_type` to the launcher process failure ping, indicating which process type the browser process failed to initialize as a sandboxed process. Depends on D83639 Differential Revision: https://phabricator.services.mozilla.com/D83640
1fd05ba97bd463f73e89dc22450bbfd07041ac87: Bug 1630444: Part2 - Add HandleLauncherError to DllServices. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 26 Aug 2020 19:01:40 +0000 - rev 546349
Push 125060 by cbrindusan@mozilla.com at Wed, 26 Aug 2020 19:17:04 +0000
Bug 1630444: Part2 - Add HandleLauncherError to DllServices. r=aklotz This patch adds winlauncher's HandleLauncherError to DllServices along with InitializeDllBlocklistOOPInternal so that SandboxBroker can call HandleLauncherError. Differential Revision: https://phabricator.services.mozilla.com/D83639
7a5a57611e9c5af962bea1f01cdd4a3cf9e5f083: Bug 1630444: Part1 - Put LauncherError behind MOZ_USE_LAUNCHER_ERROR. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Wed, 26 Aug 2020 19:01:44 +0000 - rev 546348
Push 125060 by cbrindusan@mozilla.com at Wed, 26 Aug 2020 19:17:04 +0000
Bug 1630444: Part1 - Put LauncherError behind MOZ_USE_LAUNCHER_ERROR. r=aklotz This patch defines a new macro `MOZ_USE_LAUNCHER_ERROR` and keeps the use of `LauncherError` behind `MOZ_USE_LAUNCHER_ERROR` instead of `MOZILLA_INTERNAL_API` so that we can selectively use `LauncherError` in locations where `MOZILLA_INTERNAL_API` is defined. Differential Revision: https://phabricator.services.mozilla.com/D83638
a4f5d187f2bc14d2d1b811b55d8e83a5a94c4762: Bug 1649494 - Don't assume a notification has a URL. r=aklotz
Agi Sferro <agi@sferro.dev> - Tue, 25 Aug 2020 17:49:31 +0000 - rev 546178
Push 124953 by asferro@mozilla.com at Tue, 25 Aug 2020 17:52:14 +0000
Bug 1649494 - Don't assume a notification has a URL. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D88165
8274426a159c9b88ac440ac6c64e083fb79d713c: Bug 1654969: Always disable COM pings for mscom::FastMarshaler (and thus mscom::Interceptor). r=aklotz
James Teh <jteh@mozilla.com> - Wed, 29 Jul 2020 21:11:14 +0000 - rev 542562
Push 122956 by jteh@mozilla.com at Thu, 30 Jul 2020 01:55:10 +0000
Bug 1654969: Always disable COM pings for mscom::FastMarshaler (and thus mscom::Interceptor). r=aklotz Previously, we only did this when IsCallerExternalProcess() returned false. There are three reasons for changing this: 1. There seem to be cases where IsCallerExternalProcess() returns true even when marshaling for a COM query in the MTA. 2. After bug 1627084, we pre-build a11y handler payloads on the main thread for bulk fetch calls. That will marshal interceptors. However, IsCallerExternalProcess() can't work in that case because it's not running on the thread on which the COM call is being handled. 3. If MSHLFLAGS_NOPING is used, Release calls from remote clients are never sent to the server. So, as soon as we use NOPING for our parent process, we're already going to leak references, even if we don't use NOPING for external callers. Put another way, as soon as we use NOPING for one caller, we may as well use it for all callers because COM pinging will never release the object anyway. Differential Revision: https://phabricator.services.mozilla.com/D84778
d8c1bf3fd700aea554a6ea902b32c354ead17895: Bug 1644561 - Verify that mCapturePixelsResults is not empty. r=aklotz
Agi Sferro <agi@sferro.dev> - Wed, 24 Jun 2020 17:07:03 +0000 - rev 537227
Push 119856 by asferro@mozilla.com at Wed, 24 Jun 2020 17:27:40 +0000
Bug 1644561 - Verify that mCapturePixelsResults is not empty. r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D80757
53f01e0036e1bf65486cb0b0158f69de2ee46bd7: Bug 1635564 - Implement ensureBuiltIn. r=droeh,aklotz
Agi Sferro <agi@sferro.dev> - Tue, 23 Jun 2020 19:03:50 +0000 - rev 536974
Push 119741 by asferro@mozilla.com at Tue, 23 Jun 2020 19:04:27 +0000
Bug 1635564 - Implement ensureBuiltIn. r=droeh,aklotz Verified locally that reading the manifest does not affect performance in Fenix (which uses 5 different built-in extensions) for google.com. 79.0.20200617184425 - Don't parse manifest fully-drawn : avg: 2030 ± 11 stddev: 112 n=101 about:blank : avg: 2775 ± 26 stddev: 265 n=101 page loaded : avg: 3922 ± 50 stddev: 503 n=101 79.0.20200617205116 - Parse manifest fully-drawn : avg: 2025 ± 13 stddev: 130 n=89 about:blank : avg: 2761 ± 24 stddev: 232 n=89 page loaded : avg: 3866 ± 39 stddev: 377 n=89 Differential Revision: https://phabricator.services.mozilla.com/D80567
47d8e049731befdfbdcd65c1fd09541fc206dfe3: Bug 1647761 - Part 2: Remove outdated process priority terminology, r=mccr8,geckoview-reviewers,aklotz
Nika Layzell <nika@thelayzells.com> - Tue, 23 Jun 2020 17:34:51 +0000 - rev 536963
Push 119730 by nlayzell@mozilla.com at Tue, 23 Jun 2020 18:03:11 +0000
Bug 1647761 - Part 2: Remove outdated process priority terminology, r=mccr8,geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D80684
f612d453e009554f7d9a375ebf01e8606178c38c: Bug 1642577 - De-elevate the process with CreateProcessAsUser if the compat flag RUNASADMIN is set. r=aklotz
Toshihito Kikuchi <tkikuchi@mozilla.com> - Mon, 22 Jun 2020 18:37:49 +0000 - rev 536656
Push 119601 by cbrindusan@mozilla.com at Mon, 22 Jun 2020 21:14:41 +0000
Bug 1642577 - De-elevate the process with CreateProcessAsUser if the compat flag RUNASADMIN is set. r=aklotz If the process was elevated due to AppCompatFlags, we should not use LaunchUnelevated to launch the browser process because it starts an infinite loop of process launch. The fix is to make GetElevationState return a new elevation state if RUNASADMIN is set in AppCompatFlags. With that state, we use CreateProcessAsUser to launch the browser process. Differential Revision: https://phabricator.services.mozilla.com/D80114
5066e3d136dc7ade7f3e5547a66735d156caf8b4: Bug 1640087: Part 2: tuck optimized prefetches behind a preference. r=dthayer,aklotz
Emma Malysz <emalysz@mozilla.com> - Mon, 22 Jun 2020 16:38:15 +0000 - rev 536614
Push 119573 by cbrindusan@mozilla.com at Mon, 22 Jun 2020 18:33:55 +0000
Bug 1640087: Part 2: tuck optimized prefetches behind a preference. r=dthayer,aklotz PrefetchRegistryInfo is intended to be a temporary file in order to conduct this experiment on startup times vs. retention. Most of the implementation is similar to LauncherRegistryInfo. If we startup and the registry is different than the preference, we will want to use the preference for the purpose of this experiment. Differential Revision: https://phabricator.services.mozilla.com/D76993
5409134fc766cfea378963fa5a37ac9c56515fdd: Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 16 Jun 2020 12:22:55 +0000 - rev 535863
Push 119111 by aplacitelli@mozilla.com at Tue, 16 Jun 2020 12:26:25 +0000
Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz This removes the support for the 'geckoview' telemetry in the core and in the JSM files. It also cleans up testing and the configurations. Differential Revision: https://phabricator.services.mozilla.com/D79521
dd0ce5e4a1bf410938a840a8ee223b250bb66f54: Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz
Alessio Placitelli <alessio.placitelli@gmail.com> - Tue, 16 Jun 2020 08:49:12 +0000 - rev 535834
Push 119097 by aplacitelli@mozilla.com at Tue, 16 Jun 2020 09:49:15 +0000
Bug 1620656 - Remove 'geckoview' telemetry support. r=chutten,geckoview-reviewers,aklotz This removes the support for the 'geckoview' telemetry in the core and in the JSM files. It also cleans up testing and the configurations. Differential Revision: https://phabricator.services.mozilla.com/D79521
b746ee53bfe9d96612b4397349d81cb0564293a0: Bug 1643129 - Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Wed, 10 Jun 2020 05:44:48 +0000 - rev 534967
Push 118650 by jwillcox@mozilla.com at Wed, 10 Jun 2020 19:43:24 +0000
Bug 1643129 - Add a reload to GV auth prompt test r=geckoview-reviewers,aklotz This is needed in order to catch certain problems with LoginStorage.jsm. Differential Revision: https://phabricator.services.mozilla.com/D78142
aa85ec8bc0721238f2c3a88342dfeca418b036fd: Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj
Ricky Stewart <rstewart@mozilla.com> - Mon, 01 Jun 2020 16:00:28 +0000 - rev 533339
Push 117677 by rstewart@mozilla.com at Mon, 01 Jun 2020 16:06:34 +0000
Bug 1641693 - Replace a bunch of uses of `GENERATED_FILES` with the `GeneratedFile` template r=necko-reviewers,geckoview-reviewers,aklotz,dragana,froydnj Also update documentation to suggest using the `GeneratedFile` template rather than directly referencing `GENERATED_FILES` where possible. Differential Revision: https://phabricator.services.mozilla.com/D77496
0929113893bd796bc5b0d4002585878a8506ec9d: Bug 1618058 - [2.c.7] Implement Autocomplete API backend. r=geckoview-reviewers,MattN,aklotz
Eugen Sawin <esawin@mozilla.com> - Mon, 25 May 2020 18:45:25 +0000 - rev 532088
Push 116985 by esawin@mozilla.com at Mon, 25 May 2020 18:47:48 +0000
Bug 1618058 - [2.c.7] Implement Autocomplete API backend. r=geckoview-reviewers,MattN,aklotz Differential Revision: https://phabricator.services.mozilla.com/D73753
f121c6c8aeb0c4b6f1e4a5c5d1b58648746a14da: Bug 1639275 - Add some null checking to Base64Utils r=geckoview-reviewers,aklotz
James Willcox <snorp@snorp.net> - Wed, 20 May 2020 21:58:33 +0000 - rev 531471
Push 116666 by jwillcox@mozilla.com at Thu, 21 May 2020 16:46:46 +0000
Bug 1639275 - Add some null checking to Base64Utils r=geckoview-reviewers,aklotz Differential Revision: https://phabricator.services.mozilla.com/D76219
6c10970490f3cc19e644964f583be1a047c08b2c: Bug 1628903: Prefetch DLLs to improve disk reads on Windows HDD devices. r=aklotz
Emma Malysz <emalysz@mozilla.com> - Wed, 20 May 2020 17:09:24 +0000 - rev 531315
Push 116570 by nerli@mozilla.com at Wed, 20 May 2020 18:19:48 +0000
Bug 1628903: Prefetch DLLs to improve disk reads on Windows HDD devices. r=aklotz These DLLs were identified as good candidates for prefetch using the diskify logs. Differential Revision: https://phabricator.services.mozilla.com/D73121
9c6d6a6348256a1e350b08751bcbad7c75440ce2: Bug 1636656 - Update Clobber r=aklotz
J.C. Jones <jjones@mozilla.com> - Wed, 20 May 2020 18:14:36 +0000 - rev 531313
Push 116568 by jjones@mozilla.com at Wed, 20 May 2020 18:15:17 +0000
Bug 1636656 - Update Clobber r=aklotz Differential Revision: https://phabricator.services.mozilla.com/D76195
2533428c72fb9d304286dbf87114b979b4b9ed04: Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz
Masatoshi Kimura <VYV03354@nifty.ne.jp> - Wed, 20 May 2020 14:07:19 +0000 - rev 531308
Push 116563 by VYV03354@nifty.ne.jp at Wed, 20 May 2020 17:35:07 +0000
Bug 1636740 - Block CMemStream::Read only if the drop target initiated an async operation. r=aklotz If the drop target did not initiate an async operation, `DoDragDrop` will block on the main thread until the data transfer completes. Although the `ObtainCachedIconFile` callback itself will run off the main thread, `ObtainCachedIconFile` will end up with calling `NotifyIconObservers` that heavily relies on the main thread. So `ObtainCachedIconFile` will have no chance to run the callback. To complete the data transfer, however, the `ObtainCachedIconFile` callback must signal the event object to unblock `CMemStream::Read`. Deadlock. Differential Revision: https://phabricator.services.mozilla.com/D75531
ea4dbf383a4d727a5d5fbcf78dc315c337ec0414: Bug 1638251 - Remove unused members in Frame from GeckoJavaSampler. r=geckoview-reviewers,aklotz,canaltinova
Makoto Kato <m_kato@ga2.so-net.ne.jp> - Mon, 18 May 2020 14:15:28 +0000 - rev 530737
Push 116341 by m_kato@ga2.so-net.ne.jp at Tue, 19 May 2020 02:12:46 +0000
Bug 1638251 - Remove unused members in Frame from GeckoJavaSampler. r=geckoview-reviewers,aklotz,canaltinova fileName and lineNo are unused now. Differential Revision: https://phabricator.services.mozilla.com/D75481