searching for reviewer(TYLin)
543941d75bf9abdcd977523cad136d170e67d4a2: Bug 1730774 part 3: Add includes for Inlines headers, to fix non-unified-build linking issues in layout/generic (and remove REQUIRES_UNIFIED_BUILD decl). r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 15 Sep 2021 22:43:24 +0000 - rev 592131
Push 149817 by dholbert@mozilla.com at Wed, 15 Sep 2021 22:45:48 +0000
Bug 1730774 part 3: Add includes for Inlines headers, to fix non-unified-build linking issues in layout/generic (and remove REQUIRES_UNIFIED_BUILD decl). r=TYLin After the fixes in this patch, the REQUIRES_UNIFIED_BUILD declaration is no longer needed, so I'm removing it here. This directory now builds successfully with that removed and with ac_add_options --disable-unified-build in the mozconfig. Differential Revision: https://phabricator.services.mozilla.com/D125738
09e8594d0601b9b205b792694deb4fe95a1d0a31: Bug 1730774 part 2: Add includes and forward-decls to fix non-unified-build bustage in layout/generic. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 15 Sep 2021 16:15:02 +0000 - rev 592075
Push 149792 by dholbert@mozilla.com at Wed, 15 Sep 2021 16:17:23 +0000
Bug 1730774 part 2: Add includes and forward-decls to fix non-unified-build bustage in layout/generic. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D125611
007ff7f371c95f82439b3a75aa73edb4b3cfd89c: Bug 1730774 part 2: Add includes and forward-decls to fix non-unified-build bustage in layout/generic, and remove REQUIRES_UNIFIED_BUILD declaration. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 15 Sep 2021 00:04:16 +0000 - rev 591993
Push 149752 by dholbert@mozilla.com at Wed, 15 Sep 2021 00:06:38 +0000
Bug 1730774 part 2: Add includes and forward-decls to fix non-unified-build bustage in layout/generic, and remove REQUIRES_UNIFIED_BUILD declaration. r=TYLin After the fixes in this patch, the REQUIRES_UNIFIED_BUILD declaration is no longer needed, so I'm removing it here. This directory now builds successfully with that removed and with ac_add_options --disable-unified-build in the mozconfig. Depends on D125610 Differential Revision: https://phabricator.services.mozilla.com/D125611
23bc48417fa101b4d8e85f36fe294339e3eb53b4: Bug 1730774 part 1: Give EnumeratedRange.h an include for Assertions.h, since it includes MOZ_ASSERT statements. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 14 Sep 2021 22:06:22 +0000 - rev 591984
Push 149745 by dholbert@mozilla.com at Tue, 14 Sep 2021 23:54:11 +0000
Bug 1730774 part 1: Give EnumeratedRange.h an include for Assertions.h, since it includes MOZ_ASSERT statements. r=TYLin Without this patch, these MOZ_ASSERT statements cause build errors, if I build the layout/generic directory in non-unified mode. (Instead of this patch, we could also hypothetically sprinkle individual #includes for Assertions.h around to all the downstream files; but it's simpler and more direct to just put it here in the file that contains the MOZ_ASSERT statements in question. Note that many other MFBT headers also have includes for Assertions.h, so it seems reasonable to include it here as well.) Differential Revision: https://phabricator.services.mozilla.com/D125610
d74edfc1d3eda8c52442dc0d43487d4c63784978: Bug 1730084 Part 6 - Add some empty fragments to the word-breaker test data. r=TYLin
Jonathan Kew <jkew@mozilla.com> - Mon, 13 Sep 2021 23:55:34 +0000 - rev 591856
Push 149661 by aethanyc@gmail.com at Mon, 13 Sep 2021 23:58:20 +0000
Bug 1730084 Part 6 - Add some empty fragments to the word-breaker test data. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D125180
d68c972998b5eb7736d56d3367ddfdb6a9a96122: Bug 1728497 - Remove nsColumnSetFrame::CalculateColumnRuleBounds and just return InkOverflowRect() instead. r=TYLin
Mats Palmgren <mats@mozilla.com> - Thu, 02 Sep 2021 15:42:04 +0000 - rev 590845
Push 149090 by mpalmgren@mozilla.com at Thu, 02 Sep 2021 15:44:56 +0000
Bug 1728497 - Remove nsColumnSetFrame::CalculateColumnRuleBounds and just return InkOverflowRect() instead. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D124202
2292bb2559037819ea9237f201e572db0ea77af4: Bug 1727604: clang-format the layout directory. r=layout-reviewers,TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 25 Aug 2021 19:46:48 +0000 - rev 589955
Push 148648 by aethanyc@gmail.com at Wed, 25 Aug 2021 19:49:09 +0000
Bug 1727604: clang-format the layout directory. r=layout-reviewers,TYLin This patch's changes were automatically generated by this command: ./mach clang-format -p layout/ Differential Revision: https://phabricator.services.mozilla.com/D123662
3e81e2a213107f44ef9aec06e8838a2f6effff3c: Bug 1723727 - Specify a meta viewport tag to each files in /css/css-shapes/shape-outside/values/ to avoid auto-scaling on mobile. r=TYLin
Hiroyuki Ikezoe <hikezoe.birchill@mozilla.com> - Tue, 24 Aug 2021 21:44:56 +0000 - rev 589819
Push 148563 by hikezoe.birchill@mozilla.com at Tue, 24 Aug 2021 21:47:56 +0000
Bug 1723727 - Specify a meta viewport tag to each files in /css/css-shapes/shape-outside/values/ to avoid auto-scaling on mobile. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D123402
2bb68b925cea7fba4ea23732943bb9f3ee25dee7: Bug 1724237 - Fix optimization from bug 1722968 to account for when we may dig out of the target subtree for SVG. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Mon, 23 Aug 2021 23:10:15 +0000 - rev 589639
Push 148482 by ealvarez@mozilla.com at Mon, 23 Aug 2021 23:14:28 +0000
Bug 1724237 - Fix optimization from bug 1722968 to account for when we may dig out of the target subtree for SVG. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D122964
de6bd6b6def508179277f7e98ecaba31c2454e03: Bug 1672640 part 3: Adjust GetNaturalBaselineBOffset implementations to bail (report no baseline) if the frame has 'contain:layout'. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 06 Aug 2021 18:46:22 +0000 - rev 588113
Push 147643 by dholbert@mozilla.com at Fri, 06 Aug 2021 18:48:54 +0000
Bug 1672640 part 3: Adjust GetNaturalBaselineBOffset implementations to bail (report no baseline) if the frame has 'contain:layout'. r=TYLin Some of our GetNaturalBaselineBOffset implementations already have this; others don't. But they all should have it, or else a caller might improperly query their baseline and use it for layout despite the frame having 'contain:layout'. Without this patch, the rest of this patch-stack makes us fail WPT test contain-layout-suppress-baseline-002.html because we improperly honor the baseline for the 'contain:layout' buttons at the top of the test. Differential Revision: https://phabricator.services.mozilla.com/D121938
a0f6f8d6feda917599dd02d891dc1653bac96824: Bug 1672640 part 2: Fall back to GetNaturalBaselineBOffset to ask flex items what their baseline is. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 06 Aug 2021 18:46:21 +0000 - rev 588112
Push 147643 by dholbert@mozilla.com at Fri, 06 Aug 2021 18:48:54 +0000
Bug 1672640 part 2: Fall back to GetNaturalBaselineBOffset to ask flex items what their baseline is. r=TYLin Our earlier call to nsLayoutUtils::GetFirstLineBaseline/GetLastLineBaseline works in most cases, but those APIs don't handle every frame type and fails for text control frames (for example). This new call should handle those cases by directly asking the frame for its baseline. Differential Revision: https://phabricator.services.mozilla.com/D121922
f95806b5b69bffe9b966e2c3ef8d0c6c80c73b79: Bug 1672640 part 1: Flatten logic and update comments in FlexItem::ResolvedAscent(). r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 06 Aug 2021 18:46:21 +0000 - rev 588111
Push 147643 by dholbert@mozilla.com at Fri, 06 Aug 2021 18:48:54 +0000
Bug 1672640 part 1: Flatten logic and update comments in FlexItem::ResolvedAscent(). r=TYLin This patch doesn't affect behavior; it just refactors some logic to have an early-return and reduce indentation, to make the next patch in this series easier/simpler. While we're at it, this patch also updates & extends some neighboring code-comments to be more specific & more correct about how this code behaves and its limitations. Differential Revision: https://phabricator.services.mozilla.com/D121921
507c4e968022af1ee435fee6061f6439bf3b6741: Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Aug 2021 17:56:58 +0000 - rev 587699
Push 147401 by ealvarez@mozilla.com at Tue, 03 Aug 2021 19:35:06 +0000
Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin break-before/after: page|column seem harder because you need to deal with nested breaks, I think, but this should be straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D121206
67c33ba5566e558513687692eeb7f3bbf6e07043: Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 03 Aug 2021 13:59:47 +0000 - rev 587638
Push 147372 by ealvarez@mozilla.com at Tue, 03 Aug 2021 14:02:09 +0000
Bug 1722945 - Support break-inside: avoid-{page,column}. r=TYLin break-before/after: page|column seem harder because you need to deal with nested breaks, I think, but this should be straight-forward. Differential Revision: https://phabricator.services.mozilla.com/D121206
79f0883a85a5fc59a32d99b9e8577540c0a70aff: Bug 1723039: Remove obsolete code-comments about our flexbox implementation disagreeing with spec (now that spec has changed). r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Fri, 30 Jul 2021 19:05:18 +0000 - rev 587290
Push 147230 by dholbert@mozilla.com at Fri, 30 Jul 2021 20:34:08 +0000
Bug 1723039: Remove obsolete code-comments about our flexbox implementation disagreeing with spec (now that spec has changed). r=TYLin DONTBUILD This patch doesn't impact behavior; it's just removing code-comments that refer to a requirement in the spec that we don't honor, & which the CSSWG has now resolved to remove (which makes our existing behavior correct & no longer noteworthy). The CSSWG resolution is in https://github.com/w3c/csswg-drafts/issues/4311 . The new text is yet-to-be-written, but the main takeaway is that the "fully inflexible" requirement (which we ignore) has been removed; so now, any flex item with a definite flex-basis should have its main-size considered to be definite. (And this matches our implementation.) Differential Revision: https://phabricator.services.mozilla.com/D121284
b2899198bb54c5844bdf7ae3ea947d3d5cfa7d60: Bug 1249548 - Use svg for GeckoView carets. r=TYLin,agi
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Jul 2021 18:24:39 +0000 - rev 586772
Push 146978 by ealvarez@mozilla.com at Tue, 27 Jul 2021 18:27:05 +0000
Bug 1249548 - Use svg for GeckoView carets. r=TYLin,agi This allows us to style them with system colors. The SVGs are comment 2 but: * Cleaned up manually (removed random ids / namespaces / etc). * With -moz-accent-color as the fill color rather than orange. * With license added (since it was added by a mozilla.com address I'm pretty sure we can use them pretty much as-is, thanks :antlam!). Differential Revision: https://phabricator.services.mozilla.com/D120910
b4be48deb30deab6d2c8bbc28f4b7b7dff49e885: Bug 1722405 - Use image-set() for accessiblecaret. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Jul 2021 11:51:49 +0000 - rev 586731
Push 146941 by ealvarez@mozilla.com at Tue, 27 Jul 2021 13:30:32 +0000
Bug 1722405 - Use image-set() for accessiblecaret. r=TYLin This makes the UA sheet much simpler. Differential Revision: https://phabricator.services.mozilla.com/D120905
b57fb649fe41c139108d8c940a5bd8e95bba28b4: Bug 1722405 - Use image-set() for accessiblecaret. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Jul 2021 07:16:53 +0000 - rev 586720
Push 146935 by ealvarez@mozilla.com at Tue, 27 Jul 2021 07:19:17 +0000
Bug 1722405 - Use image-set() for accessiblecaret. r=TYLin This makes the UA sheet much simpler. Differential Revision: https://phabricator.services.mozilla.com/D120905
36ac8f37dbd9bbb34e1d35fd2cac2283d2bd75f4: Bug 1722400 - Remove layout.css.image-set.enabled. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 27 Jul 2021 06:59:39 +0000 - rev 586719
Push 146934 by ealvarez@mozilla.com at Tue, 27 Jul 2021 07:02:02 +0000
Bug 1722400 - Remove layout.css.image-set.enabled. r=TYLin We shipped this in 88. Differential Revision: https://phabricator.services.mozilla.com/D120899
2dd0d0b26390cc37a442e15d2ce6108faa678be8: Bug 1715098 - Skip overflow containers in nsSplittableFrame::CalcAndCacheConsumedBSize. r=TYLin,dholbert
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 16 Jul 2021 09:01:52 +0000 - rev 585687
Push 146397 by ealvarez@mozilla.com at Fri, 16 Jul 2021 09:04:17 +0000
Bug 1715098 - Skip overflow containers in nsSplittableFrame::CalcAndCacheConsumedBSize. r=TYLin,dholbert As per comments on the bug. Differential Revision: https://phabricator.services.mozilla.com/D120010
38eb426a84398c651227587c144ee93250af15e1: Bug 1156996 - Add WPT checking baseline alignment of 'list-style: decimal inside' ::marker pseudos. r=TYLin
Mats Palmgren <mats@mozilla.com> - Thu, 24 Jun 2021 02:13:37 +0000 - rev 584241
Push 145537 by mpalmgren@mozilla.com at Thu, 24 Jun 2021 02:16:09 +0000
Bug 1156996 - Add WPT checking baseline alignment of 'list-style: decimal inside' ::marker pseudos. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D117962
1fb8a83a1be061b094238b0e63e057a6738f8f17: Bug 1715984 - Remove -moz-outline-radius. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Tue, 15 Jun 2021 04:16:46 +0000 - rev 583111
Push 144963 by ealvarez@mozilla.com at Tue, 15 Jun 2021 04:19:11 +0000
Bug 1715984 - Remove -moz-outline-radius. r=TYLin It does nothing since 88 and we unshipped it in 89. Differential Revision: https://phabricator.services.mozilla.com/D117532
738bc12bd497cbb828435bbf761c5820c5cb8ffc: Bug 1681958 - Use eReplacedSizing to assert replaced elements for aspect-ratio. r=TYLin
Boris Chiou <boris.chiou@gmail.com> - Sat, 12 Jun 2021 00:32:40 +0000 - rev 582916
Push 144856 by bchiou@mozilla.com at Sat, 12 Jun 2021 00:35:03 +0000
Bug 1681958 - Use eReplacedSizing to assert replaced elements for aspect-ratio. r=TYLin It seems `eReplacedSizing` is much closer to the definition of replaced elements (defined in [1]), and we override ComputeSize() for those frames which are set eReplacedSizing or inline/table frames. Perhaps we have to update the comments for the frame type bits later. [1] https://html.spec.whatwg.org/multipage/rendering.html#replaced-elements Differential Revision: https://phabricator.services.mozilla.com/D117372
1f62700d85c2a6d2bab864d4e71586726f713457: Bug 1695509: Don't inflate overflow areas with stale positions of pushed floats that we drained but weren't able to place. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 09 Jun 2021 23:13:08 +0000 - rev 582597
Push 144689 by dholbert@mozilla.com at Wed, 09 Jun 2021 23:15:33 +0000
Bug 1695509: Don't inflate overflow areas with stale positions of pushed floats that we drained but weren't able to place. r=TYLin Before this patch, there's an edge case where we may drain a pushed float (with a stale position), and then discover that it won't fit in the current block (so we push it and leave its position untouched), but we still inadvertently include its rect in the current block's overflow areas. This means we're feeding stale/bogus position into the overflow areas, which can make them unnecessarily huge. This patch accounts for this by only considering overflow from floats that we actually successfully placed, in ReflowPushedFloats. (Also: this patch removes a stale bit of documentation about aLineLayout being possibly-null in AddFloat. In actuality, AddFloat has a fatal assertion that mandates that this arg is non-null.) Differential Revision: https://phabricator.services.mozilla.com/D117218
41792e6152e6b5e8ad472e6cc21ce07352447bb8: Bug 1312588 - Part 5: Implement the intrinsic size contribution for fit-content(). r=TYLin,emilio
Boris Chiou <boris.chiou@gmail.com> - Tue, 08 Jun 2021 05:05:51 +0000 - rev 582196
Push 144527 by bchiou@mozilla.com at Tue, 08 Jun 2021 05:08:28 +0000
Bug 1312588 - Part 5: Implement the intrinsic size contribution for fit-content(). r=TYLin,emilio We simplified to just rely on the behavior of the plain argument. That is, width: fit-content(50%) behaves the same as width: 50%; in all circumstances, just clamped by min/max-content. Note: for block axis, we treat fit-content() as initial value its minimal and maximal value are identical and equal to the initial value in block axis. From: https://github.com/w3c/csswg-drafts/issues/3731#issuecomment-661408877 Note: this patch doesn't include any update on flex and grid layout. We may have to come back to check it. Differential Revision: https://phabricator.services.mozilla.com/D113199
1fafda061dceb0cedece654f909dfeb9bf3b0a01: Bug 1711630 - Honor 'break-inside: avoid' also when 'min-block-size' causes the overflow. r=TYLin
Mats Palmgren <mats@mozilla.com> - Sat, 22 May 2021 22:57:31 +0000 - rev 580513
Push 143612 by mpalmgren@mozilla.com at Sat, 22 May 2021 23:12:54 +0000
Bug 1711630 - Honor 'break-inside: avoid' also when 'min-block-size' causes the overflow. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D115604
d096207d1c76b2db12a6dcb8849e0ad77200c735: Bug 1710969 - Use an enum class for nsDOMCSSDeclaration::Operation. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 13 May 2021 01:26:35 +0000 - rev 579571
Push 143075 by ealvarez@mozilla.com at Thu, 13 May 2021 01:48:36 +0000
Bug 1710969 - Use an enum class for nsDOMCSSDeclaration::Operation. r=TYLin No behavior change. Differential Revision: https://phabricator.services.mozilla.com/D115038
9f22278362b85636568ccb10d1d1b3b28324eddd: Bug 1704742 - Fix percent basis of shape radii. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Wed, 14 Apr 2021 09:29:37 +0000 - rev 575874
Push 141001 by ealvarez@mozilla.com at Wed, 14 Apr 2021 09:40:19 +0000
Bug 1704742 - Fix percent basis of shape radii. r=TYLin Matches other browsers, and the spec, as per https://drafts.csswg.org/css-shapes/#basic-shape: All the lengths expressed in percentages are resolved from the used dimensions of the reference box. Differential Revision: https://phabricator.services.mozilla.com/D111790
eb8042bd69cc1d8295f7f6b5a265eb40248969a7: Bug 1698428: Adjust WPT reference case "overflow-top-left-ref.html" to use a white border as a mockup for the testcase's margins. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Sat, 10 Apr 2021 06:00:05 +0000 - rev 575367
Push 140679 by dholbert@mozilla.com at Sat, 10 Apr 2021 06:02:28 +0000
Bug 1698428: Adjust WPT reference case "overflow-top-left-ref.html" to use a white border as a mockup for the testcase's margins. r=TYLin Per https://drafts.csswg.org/css-overflow-3/#scrollable , the scrollable overflow area of a scrollable flex container is supposed to contain "the margin areas of...flex item boxes for which the box establishes a containing block." Before this patch, the reference case didn't properly require this behavior (in its mockup of the inline-end edge of the testcase's flex containers). The reference case was using "margin" on blocks in a block container to represent this space, and that didn't match the testcase because margins behave differently in block layout vs. flex layout with respect to creating scrollable overflow in their container. This patch changes the reference case to use borders to represent this space. This works better because borders do reliably create scrollable overflow. (Also, borders don't collapse like margins do in block layout; this lets us remove an extra hack that the reference case was having to use to counteract this.) Differential Revision: https://phabricator.services.mozilla.com/D111025
2e76f79e22a0d2056749897f0ce64c5e9fe5646e: Bug 1699468 - Pass StyleSizeOverrides into ComputeISizeValue(). r=TYLin
Boris Chiou <boris.chiou@gmail.com> - Wed, 07 Apr 2021 23:55:38 +0000 - rev 574917
Push 140414 by bchiou@mozilla.com at Thu, 08 Apr 2021 02:43:44 +0000
Bug 1699468 - Pass StyleSizeOverrides into ComputeISizeValue(). r=TYLin The inconsistent usage of block size and aspect ratio in ComputeSize() and ComputeISizeValue() cause this assertion. We use StyleSizeOverrides when measuring the content block sizes of flex items, and the expected computed value of block size is auto. And so in ComputeISizeValue(), we should use any field in StyleSizeOverrides that having an override rather than fetching it from the style system. Differential Revision: https://phabricator.services.mozilla.com/D111031
9db41e93c66ff111fe3fdbd4d80a932b7d00b594: Bug 1698428: Adjust WPT reference case "overflow-top-left-ref.html" to use a white border as a mockup for the testcase's margins. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 07 Apr 2021 23:33:04 +0000 - rev 574915
Push 140412 by dholbert@mozilla.com at Thu, 08 Apr 2021 02:41:56 +0000
Bug 1698428: Adjust WPT reference case "overflow-top-left-ref.html" to use a white border as a mockup for the testcase's margins. r=TYLin Per https://drafts.csswg.org/css-overflow-3/#scrollable , the scrollable overflow area of a scrollable flex container is supposed to contain "the margin areas of...flex item boxes for which the box establishes a containing block." Before this patch, the reference case didn't properly require this behavior (in its mockup of the inline-end edge of the testcase's flex containers). The reference case was using "margin" on blocks in a block container to represent this space, and that didn't match the testcase because margins behave differently in block layout vs. flex layout with respect to creating scrollable overflow in their container. This patch changes the reference case to use borders to represent this space. This works better because borders do reliably create scrollable overflow. (Also, borders don't collapse like margins do in block layout; this lets us remove an extra hack that the reference case was having to use to counteract this.) Differential Revision: https://phabricator.services.mozilla.com/D111025
5574f84255953f4cbb1616e51fb9efa1f846c108: Bug 1626108: Adjust test expectations in flexbox WPT negative-overflow.html, to indicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Tue, 06 Apr 2021 23:54:16 +0000 - rev 574666
Push 140295 by dholbert@mozilla.com at Tue, 06 Apr 2021 23:56:42 +0000
Bug 1626108: Adjust test expectations in flexbox WPT negative-overflow.html, to indicate that negative cross-axis overflow in a "wrap-reverse" flexbox should be scrollable. r=TYLin This testcase wasn't accounting for the fact that "flex-wrap: wrap-reverse" flips the direction in which overflow is reachable/scrollable, in a flex container's cross axis (just as "flex-direction: column-reverse" does in the main axis). The CSSWG resolved on this here: https://lists.w3.org/Archives/Public/www-style/2014Sep/0187.html This commit makes the test account for this, by increasing the expected scrollHeight of the "wrap-reverse" pieces of the test (which have overflow that should be scrollable). Note that Chromium doesn't pass these amended subtests, because it doesn't correctly handle scrolling with wrap-reverse; this is covered by https://bugs.chromium.org/p/chromium/issues/detail?id=1114306 . (However, if I modify the test to use "wrap" instead of "wrap-reverse", then Chromium does pass these subtests. This indicates that Chromium does essentially agree on the expected value here, aside from that bug report about making the overflow scrollable.) Differential Revision: https://phabricator.services.mozilla.com/D110968
379285a42f124620d09d77524db5465e1591e001: Bug 1702835 - Min/Max size transfers should work only when inline size is not specified. r=TYLin,emilio
Boris Chiou <boris.chiou@gmail.com> - Mon, 05 Apr 2021 21:34:49 +0000 - rev 574404
Push 140179 by bchiou@mozilla.com at Mon, 05 Apr 2021 21:37:18 +0000
Bug 1702835 - Min/Max size transfers should work only when inline size is not specified. r=TYLin,emilio We have to apply min/max transferred size if inline size is auto or intrinsic size keywords. The basic principle is that sizing constraints transfer through the aspect-ratio to the other side to preserve the aspect ratio to the extent that they can without violating any sizes specified explicitly on that affected axis. Note: block-aspect-ratio-021.html tests the similar case with the non-zero content size. However we don't have the similar tests for intrinsic size keywords, so I add them in this patch as well. Differential Revision: https://phabricator.services.mozilla.com/D110725
1e18de5001bc4cf4636b19b0c891403172a5be8c: Bug 1699263 - Fix the issue that we unconditionally use autoBSize when we specify the block size and aspect-ratio. r=TYLin
Boris Chiou <boris.chiou@gmail.com> - Mon, 05 Apr 2021 19:33:05 +0000 - rev 574386
Push 140167 by bchiou@mozilla.com at Mon, 05 Apr 2021 19:35:36 +0000
Bug 1699263 - Fix the issue that we unconditionally use autoBSize when we specify the block size and aspect-ratio. r=TYLin Also, rewrite CalculateAbsoluteSizeWithResolvedAutoBlockSize(). Move all the aspect-ratio checks into this function, so make the caller simplier. Differential Revision: https://phabricator.services.mozilla.com/D109568
977f76231d707cb75d1f7a03a236f7e09ba930ec: Bug 1700801 - Remove stale test annotation of test_bug756984 which passes with fission-xorigin. r=layout-reviewers,TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Apr 2021 23:49:38 +0000 - rev 574103
Push 140059 by ealvarez@mozilla.com at Thu, 01 Apr 2021 23:52:05 +0000
Bug 1700801 - Remove stale test annotation of test_bug756984 which passes with fission-xorigin. r=layout-reviewers,TYLin Differential Revision: https://phabricator.services.mozilla.com/D110603
43b719c60744aa4e3981e02f3cf76a4ad680042d: Bug 1684921 - Factor the "find prev/next sibling accounting for box ordinal", and fix a missing use of it. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Apr 2021 23:48:39 +0000 - rev 574102
Push 140058 by ealvarez@mozilla.com at Thu, 01 Apr 2021 23:51:07 +0000
Bug 1684921 - Factor the "find prev/next sibling accounting for box ordinal", and fix a missing use of it. r=TYLin I only noticed this via code inspection. Differential Revision: https://phabricator.services.mozilla.com/D110529
6ccf4f85204224f3f3578945a8ca25c74186231c: Bug 1684921 - Fix some missing sorts in xul tree / splitter code. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Thu, 01 Apr 2021 09:45:42 +0000 - rev 573982
Push 139963 by ealvarez@mozilla.com at Thu, 01 Apr 2021 09:48:09 +0000
Bug 1684921 - Fix some missing sorts in xul tree / splitter code. r=TYLin I missed those in bug 1411372. Custom hit-testing code, yay. Differential Revision: https://phabricator.services.mozilla.com/D110429
bdf6fd9375720f11eb99c043caad98622cdc4ab6: Bug 1700416: Fix problems with WPT test "scaley.html" that were preventing it from passing in any browser. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Wed, 24 Mar 2021 18:41:59 +0000 - rev 572929
Push 139407 by dholbert@mozilla.com at Wed, 24 Mar 2021 18:54:38 +0000
Bug 1700416: Fix problems with WPT test "scaley.html" that were preventing it from passing in any browser. r=TYLin This test had a number of issues that were preventing it from passing in any browser. After this patch, it passes in Firefox at least, and I suspect it'll pass in other browsers as well. Problems with the test that are fixed here (all of which were keeping this test from passing): - The descriptive text on the page was different ("box." vs "area"), between the testcase and reference case. - The testcase had a margin on this text, for no clear reason. - The reference case had a border around the scaled-up green div, whereas the testcase doesn't (making them mismatch by the size of that border). And while I'm at it, I'm making minor edits... - making the indentation more consistent. - switching to the HTML5 standards-mode doctype (since the testcase isn't doing anything relevant to quirks-mode that would require a legacy doctype). - removing the unused ".hidden" CSS rule from the reference case. This makes the testcase and reference case more usefully diffable. Differential Revision: https://phabricator.services.mozilla.com/D109524
a6dad002989d789f27b6f57dc487082d1d2965f5: Bug 1698235 - Add some error handling when using RemotePrintJobChild which may be destroyed. r=TYLin
Mats Palmgren <mats@mozilla.com> - Thu, 18 Mar 2021 19:39:09 +0000 - rev 571867
Push 138938 by mpalmgren@mozilla.com at Thu, 18 Mar 2021 19:41:46 +0000
Bug 1698235 - Add some error handling when using RemotePrintJobChild which may be destroyed. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D108711
9bfc0d833adfcb77b0bfe80bbb5d37656f5ac137: Bug 1695314 - Frame constructor shouldn't use nsIFrame::IsFloating to determine whether it should create a float. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Fri, 26 Feb 2021 20:03:24 +0000 - rev 568989
Push 137332 by ealvarez@mozilla.com at Fri, 26 Feb 2021 21:20:55 +0000
Bug 1695314 - Frame constructor shouldn't use nsIFrame::IsFloating to determine whether it should create a float. r=TYLin It should just look at the float style. This shouldn't be a behavior change because SVG text should pass false for aCanBeFloated. This unblocks bug 1690701 because checking the out of flow frame bit here would be wrong (we're deciding whether the frame should be out of flow so the bit isn't set yet). Differential Revision: https://phabricator.services.mozilla.com/D106664
b871fff62d9893641ec465f98d01debb2824cf91: Bug 1691205 - Initialize the intrinsic block-size to zero in case there is no :root frame. r=TYLin
Mats Palmgren <mats@mozilla.com> - Sat, 20 Feb 2021 04:25:25 +0000 - rev 568173
Push 136879 by mpalmgren@mozilla.com at Sat, 20 Feb 2021 04:27:49 +0000
Bug 1691205 - Initialize the intrinsic block-size to zero in case there is no :root frame. r=TYLin Note that this only happens for chrome: documents that have been invasively styled by userChrome.css sheets. Content documents are never intrinsically sized, and our own chrome: sheets that use intrinsic sizing never set 'display:none' on the :root as far as I know. I think this is an argument for removing support for userChrome.css. Differential Revision: https://phabricator.services.mozilla.com/D104715
d5975841c32631cf46f2aaf18f7e6b9d1dc6538d: Bug 1690422 - Resolve {min|max}-content contribution with the preferred aspect ratio and the definite block size. r=TYLin
Boris Chiou <boris.chiou@gmail.com> - Wed, 17 Feb 2021 02:41:24 +0000 - rev 567816
Push 136617 by bchiou@mozilla.com at Wed, 17 Feb 2021 02:43:48 +0000
Bug 1690422 - Resolve {min|max}-content contribution with the preferred aspect ratio and the definite block size. r=TYLin This is simliar with the previous patch, but we use min-content/max-content for the inner div (i.e. child frame). Perhaps we could remove the simliar implementation from ComputeISizeValue(). However, I still keep it because it can avoid some extra work when resolving {min|max}-content with aspect-ratio when reflowing. Differential Revision: https://phabricator.services.mozilla.com/D104476
373fe3a0806a72574a9a95cac9dd25e9881380c9: Bug 1690422 - Take box-sizing into account when computing the intrinsic size with the preferred aspect ratio. r=TYLin,mats
Boris Chiou <boris.chiou@gmail.com> - Wed, 17 Feb 2021 02:41:24 +0000 - rev 567815
Push 136617 by bchiou@mozilla.com at Wed, 17 Feb 2021 02:43:48 +0000
Bug 1690422 - Take box-sizing into account when computing the intrinsic size with the preferred aspect ratio. r=TYLin,mats We resolve the auto value in IntrinsicForAxis by the ratio determining size and the preferred aspect ratio. However, this should take box-sizing into account when using aspect-ratio property. Differential Revision: https://phabricator.services.mozilla.com/D104293
bf6cf886b9683288fa453a66f999875b6ff6d3eb: Bug 1667501 - Add an nsIFrame::IsFrameOfType bit to say whether frames support aspect-ratio. r=TYLin
Boris Chiou <boris.chiou@gmail.com> - Thu, 11 Feb 2021 00:19:58 +0000 - rev 566920
Push 136212 by bchiou@mozilla.com at Thu, 11 Feb 2021 00:50:20 +0000
Bug 1667501 - Add an nsIFrame::IsFrameOfType bit to say whether frames support aspect-ratio. r=TYLin aspect-ratio applies to all elements except inline boxes and internal ruby or table boxes. So we should return false for inline frames, table internal frames (i.e. except nsTableFrame and nsTableWrapperFrame), and ruby internal frames. Also, we can drop ComputeSizeFlags::SkipAspectRatio because this frame bit can replace this flag. Note: it seems nsRubyBaseContainerFrame and nsRubyTextContainerFrame are inline, so we return false for them. This will be very useful when computing the intrinsic size because IntrinsicForAxis() computes the intrinsic size for all descendant frames and some of descendants may not support aspect-ratio. It's pretty hard to achieve this by just adding a flag for this function. Differential Revision: https://phabricator.services.mozilla.com/D104296
fde83e4dd9dc9c9c4782fd9b05913125a2378f9a: Bug 1690706 - Move caption-side outside of mako. r=TYLin
Emilio Cobos Álvarez <emilio@crisal.io> - Sun, 07 Feb 2021 12:33:45 +0000 - rev 566301
Push 135896 by ealvarez@mozilla.com at Sun, 07 Feb 2021 12:36:13 +0000
Bug 1690706 - Move caption-side outside of mako. r=TYLin Make it an enum class, etc. Differential Revision: https://phabricator.services.mozilla.com/D103978
40234f92c842599b1e1145b25d6e735e15e3ee51: Bug 1690166 - Don't report BreakBefore reflow status if the <fieldset> is an abs/fixed positioned out-of-flow. r=TYLin
Mats Palmgren <mats@mozilla.com> - Wed, 03 Feb 2021 21:21:40 +0000 - rev 565924
Push 135661 by mpalmgren@mozilla.com at Wed, 03 Feb 2021 21:24:22 +0000
Bug 1690166 - Don't report BreakBefore reflow status if the <fieldset> is an abs/fixed positioned out-of-flow. r=TYLin Differential Revision: https://phabricator.services.mozilla.com/D103824
7f37547c29ff78df8c58102923a679cf2adf6255: Bug 1686728 - Make nsCheckboxRadioFrame::GetUsableScreenRect a static function for its only consumer. r=layout-reviewers,TYLin
Mats Palmgren <mats@mozilla.com> - Fri, 29 Jan 2021 20:47:59 +0000 - rev 565826
Push 135600 by mpalmgren@mozilla.com at Wed, 03 Feb 2021 04:23:56 +0000
Bug 1686728 - Make nsCheckboxRadioFrame::GetUsableScreenRect a static function for its only consumer. r=layout-reviewers,TYLin Differential Revision: https://phabricator.services.mozilla.com/D101777
35053583b9a751daed53f428f12219425a84004c: Bug 1683126 - Make nsCanvasFrame::Reflow more robust. r=TYLin
Mats Palmgren <mats@mozilla.com> - Mon, 01 Feb 2021 23:46:17 +0000 - rev 565544
Push 135490 by mpalmgren@mozilla.com at Tue, 02 Feb 2021 00:10:55 +0000
Bug 1683126 - Make nsCanvasFrame::Reflow more robust. r=TYLin This patch improves nsCanvasFrame::Reflow in a few ways. First, we now iterate over mFrames and reflow every child. This makes it more robust vis-à-vis the order of any placeholders and the root frame, and also resilient against a missing root frame (this fixes the fatal assertion in this bug). We now also actually reflow all placeholders which wasn't the case before. It seems like a prudent thing to do. I also added a separate nsReflowStatus for each child. We now also call SetOverflowAreasToDesiredBounds() in all cases. We failed to do that in the 'mFrames.IsEmpty()' case before, which triggered the assertions in bug 1655630 and bug 1392106. Differential Revision: https://phabricator.services.mozilla.com/D103592
0acd315f0a702a0d65fee9aa12ec7f39cdcbcc7b: Bug 1689719: Add a WPT to assert that a table with a content-based flex-basis should be sized as if it had a 'max-content' size in a block. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 01 Feb 2021 19:22:53 +0000 - rev 565510
Push 135469 by abutkovits@mozilla.com at Mon, 01 Feb 2021 21:40:53 +0000
Bug 1689719: Add a WPT to assert that a table with a content-based flex-basis should be sized as if it had a 'max-content' size in a block. r=TYLin Chrome and Safari fail this WPT because they mishandle the max-content sizing in the reference case. That's tracked in these bugs: https://bugs.chromium.org/p/chromium/issues/detail?id=1172498 https://bugs.webkit.org/show_bug.cgi?id=221165 Differential Revision: https://phabricator.services.mozilla.com/D103534
061da9f1f7d017dc7b01f994997e024adb7afe0e: Bug 1689719: Add a WPT to assert that a table with a content-based flex-basis should be sized as if it had a 'max-content' size in a block. r=TYLin
Daniel Holbert <dholbert@cs.stanford.edu> - Mon, 01 Feb 2021 19:22:53 +0000 - rev 565497
Push 135460 by dholbert@mozilla.com at Mon, 01 Feb 2021 19:25:17 +0000
Bug 1689719: Add a WPT to assert that a table with a content-based flex-basis should be sized as if it had a 'max-content' size in a block. r=TYLin Chrome and Safari fail this WPT because they mishandle the max-content sizing in the reference case. That's tracked in these bugs: https://bugs.chromium.org/p/chromium/issues/detail?id=1172498 https://bugs.webkit.org/show_bug.cgi?id=221165 Differential Revision: https://phabricator.services.mozilla.com/D103534