fc5c57e9b65b65e98fdc8e792913a5553bb67897: Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles
Mantaroh Yoshinaga <mantaroh@gmail.com> - Mon, 20 Aug 2018 07:03:07 +0000 - rev 432329
Push 67963 by mantaroh@gmail.com at Mon, 20 Aug 2018 07:05:15 +0000
Bug 1484595 - Remove the HTMLTooltip hidden event listener before destroying the HTMLTooltip. r=birtles MenuButton will listen the HTMLTooltip hidden event even if HTMLTooltip is destroyed. As a result of it, the timer which issued in the MenuButton's event listener might fail due to the target window is destroyed. (e.g., switching the dock mode to bottom from window mode.) This patch will remove this event listener before destroying the HTMLTooltip. Differential Revision: https://phabricator.services.mozilla.com/D3759
1aa8b1865c770f3b3a48bbda953ce5d38f69dd45: Bug 1484575 - Simplify PropertyDeclarationBlock::get a little. r=xidorn
Cameron McCormack <cam@mcc.id.au> - Mon, 20 Aug 2018 04:11:37 +0000 - rev 432328
Push 67962 by cmccormack@mozilla.com at Mon, 20 Aug 2018 06:41:42 +0000
Bug 1484575 - Simplify PropertyDeclarationBlock::get a little. r=xidorn Depends On D3747 Differential Revision: https://phabricator.services.mozilla.com/D3748
a592b4286d6fa94ecf434e2c5d0f9bac74e3bda9: Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn
Cameron McCormack <cam@mcc.id.au> - Mon, 20 Aug 2018 05:34:16 +0000 - rev 432327
Push 67961 by cmccormack@mozilla.com at Mon, 20 Aug 2018 06:40:34 +0000
Bug 1484571 - Replace NormalDeclarationIterator return type with `impl Trait`. r=xidorn Differential Revision: https://phabricator.services.mozilla.com/D3747
541fbb29f21d262d88d0ae08776606db0b62d8f6: Bug 1449564 - part 4: Make users can show Gecko specific editing UIs with new prefs r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 16 Aug 2018 13:51:36 +0900 - rev 432326
Push 67960 by masayuki@d-toybox.com at Mon, 20 Aug 2018 06:12:51 +0000
Bug 1449564 - part 4: Make users can show Gecko specific editing UIs with new prefs r=m_kato Even after we disable Gecko specific editing UIs by default, web apps can enable them with execCommand. However, until such web apps change their behavior, users cannot use Gecko specific UIs. At least for now, we should make users can enable them by default. MozReview-Commit-ID: AuAdw4FQ4He
e93a23a4741c7760d76e33c3515e9b6ee2f5e26d: Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Thu, 05 Apr 2018 00:32:32 +0900 - rev 432325
Push 67960 by masayuki@d-toybox.com at Mon, 20 Aug 2018 06:12:51 +0000
Bug 1449564 - part 3: Make absolute position editor listen to mouse events at the system event group r=m_kato Currently, absolute position editor listens to mouse events at the default event group to handle dragging of positioner. However, this is blocked by a call of Event.stopPropagation() in web apps unexpectedly. Therefore, we should make it listen to the events at the system event group instead. MozReview-Commit-ID: Hoa8c9QvMuG
ccb713187e45a0ce52cf0ebe8969ddac9608e215: Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Wed, 04 Apr 2018 22:27:49 +0900 - rev 432324
Push 67960 by masayuki@d-toybox.com at Mon, 20 Aug 2018 06:12:51 +0000
Bug 1449564 - part 2: Make absolute positioned element editor disabled in default and make it possible to enable it with new command r=m_kato We have another built-in UI of editor which is not implemented by any other browsers. That is a draggable handler to move absolute positioned elements. So, we should disable it in default for compatibility with the other browsers. However, different from resizers and inline table editor, we don't have command to enable/disable this feature but for backward compatibility, we should have it. Therefore, this patch adds new command "enableAbsolutePositionEditor". Note that whether resizing UI is available only with enableObjectResizing state is different from enableInlineTableEditing command. Resizers for absolute positioned elements are NOT available both enableObjectResizing and enableAbsolutePositionEditor are enabled. Additionally, this adds automated tests to check basic functions of absolute positioned editor. MozReview-Commit-ID: 9ZSGB8tLpFw
4e0960a6ffb6c283f29d75ba5bc2585df4c3caf0: Bug 1449564 - part 1: Disable object resizer and inline table editor in default r=m_kato
Masayuki Nakano <masayuki@d-toybox.com> - Mon, 02 Apr 2018 17:26:46 +0900 - rev 432323
Push 67960 by masayuki@d-toybox.com at Mon, 20 Aug 2018 06:12:51 +0000
Bug 1449564 - part 1: Disable object resizer and inline table editor in default r=m_kato Gecko supports resizers of <img> elements and <table>, <td>, <th> elements and has UI to remove existing table row or column in default. However, the other browsers don't have such UI and web apps need to disable this feature with calling both: document.execCommand("enableObjectResizing", false, false); document.execCommand("enableInlineTableEditing", false, false); for avoiding conflicting with their own features to edit such elements. Therefore, it doesn't make sense to keep enabling them in default only on Gecko. If web apps want to keep using these features, they should call: document.execCommand("enableObjectResizing", false, true); document.execCommand("enableInlineTableEditing", false, true); at initializing the editor. And also this patch fixes bugs of document.queryCommandState("enableObjectResizing") and document.queryCommandState("enableInlineTableEditing"). They always return false even after calling document.execCommand(..., false, true) since nsSetDocumentStateCommand::GetCommandStateParams() sets bool value as STATE_ATTRIBUTE. However, nsHTMLDocument::QueryCommandValue() which is the caller referring STATE_ATTRIBUTE doesn't treat it as bool value. And also those commands are related to state of document. Therefore, they should be return as bool value of STATE_ALL instead. Then, nsHTMLDocument::QueryCommandState() returns the state as expected. Note that those commands are supported only by Gecko. So, we don't need to worry about the compatibility. Finally, this patch rewrites 2 existing tests to check basic behavior of resizers and appearance of resizers. Note that this patch does not add new tests to test inline table editor since it's difficult to test the behavior with current API. Perhaps, we should add an API to nsIHTMLEditor to retrieve each anonymous elements in another bug since it requires to add wrapping API of SpecialPowers. MozReview-Commit-ID: 1FhYo5vcV60
eaf6867923b99cd189d501cd3dd131f73c0e533c: Bug 1484565 - Implement scrollbar-width: thin support for cocoa widget. r=spohl
Xidorn Quan <me@upsuper.org> - Mon, 20 Aug 2018 04:57:58 +0000 - rev 432322
Push 67959 by xquan@mozilla.com at Mon, 20 Aug 2018 05:12:10 +0000
Bug 1484565 - Implement scrollbar-width: thin support for cocoa widget. r=spohl It also converts nsNativeThemeCocoa::GetParentScrollbarFrame into a local static function rather than a member function, since it doesn't seem to be necessary that way. Differential Revision: https://phabricator.services.mozilla.com/D3737
93d0e291f45883765df384c070e56e4e0517db4b: Merge mozilla-inbound to mozilla-central. a=merge
Cosmin Sabou <csabou@mozilla.com> - Mon, 20 Aug 2018 00:49:12 +0300 - rev 432321
Push 67958 by csabou@mozilla.com at Sun, 19 Aug 2018 21:51:15 +0000
Merge mozilla-inbound to mozilla-central. a=merge
9f9bb31175a814856eeef5939196fa485ca03143: Bug 1483999 - Avoid duplicate GetBuiltinClass call. r=sfink
Tom Schuster <evilpies@gmail.com> - Sat, 18 Aug 2018 17:22:19 +0200 - rev 432320
Push 67958 by csabou@mozilla.com at Sun, 19 Aug 2018 21:51:15 +0000
Bug 1483999 - Avoid duplicate GetBuiltinClass call. r=sfink
bac4139e4ff9b3071e1ce17113ac65ed1d8e8598: Bug 1465616 - Add failing fixed-position async-zoom reftests. r=botond
Kashav Madan <kshvmdn@gmail.com> - Fri, 03 Aug 2018 14:20:53 -0400 - rev 432319
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Add failing fixed-position async-zoom reftests. r=botond When async-zooming, the compositor applies an invalid offset transformation to position:fixed elements, causing them to be positioned incorrectly until a repaint occurs. MozReview-Commit-ID: IZEN1gtpbIA
ca7f6311613cbf7dd2a5151fed6deba9c4141543: Bug 1465616 - Add async-scroll reftests. r=botond
Kashav Madan <kshvmdn@gmail.com> - Fri, 20 Jul 2018 17:48:30 -0400 - rev 432318
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Add async-scroll reftests. r=botond The first set of tests test that fixed/sticky position elements are no longer attached to the visual viewport (i.e., that they go "out of view" when the visual viewport is scrolled) and the second set of tests test that fixed/sticky position elements are attached to the layout viewport (i.e., that they "follow" the layout viewport when it's scrolled). MozReview-Commit-ID: 6H2f0oz9lW7
ac55e50f906c5acd9efc7f444c708dd749327741: Bug 1465616 - Add reftests for main-thread scroll behaviour. r=botond
Kashav Madan <kshvmdn@gmail.com> - Tue, 14 Aug 2018 13:34:36 -0400 - rev 432317
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Add reftests for main-thread scroll behaviour. r=botond MozReview-Commit-ID: IzSUQqvjrUp
232b161a64f99536595e2ac4811a964cfd0a2674: Bug 1465616 - Add a mochitest for fixed position hit-testing. r=botond
Kashav Madan <kshvmdn@gmail.com> - Wed, 04 Jul 2018 16:17:31 -0400 - rev 432316
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Add a mochitest for fixed position hit-testing. r=botond MozReview-Commit-ID: IC82JZoVgPs
430f2e4f9d3b650ba0ce0d264f9cc99a693586b9: Bug 1465616 - Use layout viewport transformations to async-adjust fixed position elements. r=botond
Kashav Madan <kshvmdn@gmail.com> - Fri, 20 Jul 2018 17:45:48 -0400 - rev 432315
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Use layout viewport transformations to async-adjust fixed position elements. r=botond This results in fixed position elements being attached to the layout viewport when being async-scrolled by APZ (when the layout viewport is larger than the visual viewport). MozReview-Commit-ID: 2YYIDnTWgVn
fbb567678a4df4b9d7734e2f226e106082ff41d7: Bug 1465616 - Temporarily apply async test attributes when compositing. r=botond,kats
Kashav Madan <kshvmdn@gmail.com> - Fri, 20 Jul 2018 17:37:36 -0400 - rev 432314
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Temporarily apply async test attributes when compositing. r=botond,kats Includes a new RAII class: AutoApplyAsyncTestAttributes, which, for the duration of its lifetime, applies mTestAsyncScrollOffset and mTestAsyncZoom to the APZC's FrameMetrics. We need this to ensure that the AsyncPanZoomController::GetCurrentAsync* methods consider test scroll and zoom attributes when doing their respective computations. MozReview-Commit-ID: 9owJcdIegNH
b14350eb2d926069a4a31ddb16704eb0c1b3d9f5: Bug 1465616 - Use the larger viewport to layout and size fixed position elements. r=mstange
Kashav Madan <kshvmdn@gmail.com> - Wed, 04 Jul 2018 16:10:04 -0400 - rev 432313
Push 67957 by bballo@mozilla.com at Sun, 19 Aug 2018 16:50:16 +0000
Bug 1465616 - Use the larger viewport to layout and size fixed position elements. r=mstange Since fixed position elements are now scrollable, we need to ensure that they're drawn into the viewport that they're attached to. MozReview-Commit-ID: ADQXkLjwIzR
c6e7b65bf8b02a32a6c1d583eb1d79e3116d692d: Merge mozilla-central to autoland. a=merge CLOSED TREE
Gurzau Raul <rgurzau@mozilla.com> - Sun, 19 Aug 2018 12:44:10 +0300 - rev 432312
Push 67956 by rgurzau@mozilla.com at Sun, 19 Aug 2018 09:44:37 +0000
Merge mozilla-central to autoland. a=merge CLOSED TREE
2d1d32212c1e4107bef4d24dbbe2f12adca11837: Merge inbound to mozilla-central. a=merge
Gurzau Raul <rgurzau@mozilla.com> - Sun, 19 Aug 2018 12:41:39 +0300 - rev 432311
Push 67956 by rgurzau@mozilla.com at Sun, 19 Aug 2018 09:44:37 +0000
Merge inbound to mozilla-central. a=merge
f4f56776a1122ff3df80203386c9a836f936bf6d: Bug 260562 - Remove obsolete accessibility.typeaheadfind.enabletimeout preference. r=kmag
spillner <spillner@acm.org> - Sun, 19 Aug 2018 08:47:57 +0300 - rev 432310
Push 67956 by rgurzau@mozilla.com at Sun, 19 Aug 2018 09:44:37 +0000
Bug 260562 - Remove obsolete accessibility.typeaheadfind.enabletimeout preference. r=kmag Summary: Mike DeBoer correctly noted in a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=254592 that enabletimeout is no longer used and should be removed. I updated the timeout logic to treat a zero or negative value as effectively "no automatic timeout" for the quick-find dialog (otherwise, setting the timeout value to a small or negative value makes the feature unusable). This is a corollary to the bugfix at https://phabricator.services.mozilla.com/D3404 ; I've split it out into a separate patch to avoid confusing that issue. Update: this specific issue already had its own bug at https://bugzilla.mozilla.org/show_bug.cgi?id=260562, and another mention at https://bugzilla.mozilla.org/show_bug.cgi?id=265915 . Reviewers: kmag Reviewed By: kmag Bug #: 260562 Differential Revision: https://phabricator.services.mozilla.com/D3504
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip