fb19701c39d5344549f422d36a3b52a1932d11bf: Bug 1608302: Part 2 - Modify GeckoProcessManager to support multiple content processes; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Tue, 10 Mar 2020 16:35:13 +0000 - rev 517899
Push 109684 by aklotz@mozilla.com at Tue, 10 Mar 2020 16:43:34 +0000
Bug 1608302: Part 2 - Modify GeckoProcessManager to support multiple content processes; r=geckoview-reviewers,snorp We change a lot of things in this patch: * `ChildConnection` now inherits from `ServiceAllocator.InstanceInfo`, which imbues the former with service allocation superpowers. * We remove the `IBinder.linkToDeath` call and the `IBinder.DeathRecipient` callback; a close review of the service binding APIs (and the actual Android source code) clearly shows that `ServiceConnection.onServiceDisconnected` already performs that role. * We also greatly simplify unbinding, as a successful `Context.unbindService` call does not require a subsequent `onServiceDisconnected` notification; The `ServiceConnection` callbacks should be thought of as pertaining to the acquisition and loss of `Binder` connections. On that note, to improve the clarity of what those callbacks do, we now implement them as `onBinderConnected` and `onBinderConnectionLost` overrides originating from `ServiceAllocator.InstanceInfo`. * We add the `ConnectionManager` class which handles the organization of tracking which processes exist with which pid. Its public methods are named such that it should be very clear what their purposes are. * This patch adds a minimal amount of priority management code to `ConnectionManager`. Right now we assume that everything is running at `PriorityLevel.FOREGROUND` (i.e. `Context.BIND_IMPORTANT`). This will be further improved in bug 1620145. Differential Revision: https://phabricator.services.mozilla.com/D65640
c503f508741060f700ec1d6a7cbd83d12a94f8ef: Bug 1608302: Part 1 - Modify service definitions to support multiple content processes; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Tue, 10 Mar 2020 16:31:51 +0000 - rev 517898
Push 109684 by aklotz@mozilla.com at Tue, 10 Mar 2020 16:43:34 +0000
Bug 1608302: Part 1 - Modify service definitions to support multiple content processes; r=geckoview-reviewers,snorp For testing purposes, we'll only support 3 at the moment. Note that this does not materially affect our test builds, as e10s-multi is still govered by the `dom.ipc.processCount` Gecko pref. Differential Revision: https://phabricator.services.mozilla.com/D65639
c2032c305a4b4e9296f5aa7e40e7b26871855f35: Bug 1608301: Part 3 - Add an allocator for generating unique service names and instance IDs; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Tue, 10 Mar 2020 16:31:54 +0000 - rev 517897
Push 109684 by aklotz@mozilla.com at Tue, 10 Mar 2020 16:43:34 +0000
Bug 1608301: Part 3 - Add an allocator for generating unique service names and instance IDs; r=geckoview-reviewers,snorp `ServiceAllocator` wraps the various `Context.bindService` APIs and manages the allocation of service names (in the case of non-isolated services) or instance names (in the case of isolated services on Android 10+). During the first allocation of a content process, we construct a policy that is used for all content process allocations. The `DefaultContentPolicy` computes the maximum number of content processes and then allocates those names using a `BitSet`. The `IsolatedContentPolicy` tracks the number of live content processes, but simply uses a monotonically-increasing counter for generating instance IDs. This patch also adds a `ServiceUtils` class that contains numerous functions relating to generating service names and retrieving information about service definitions in this package. * Content processes are now named `tab0` through `tabN`. When a single content process name is used (either for single-e10s or for the process name used by isolated services), we always use `tab0`. * I am not wedded to the names of the priorities used in the `PriorityLevel` enum -- suggestions welcome! * Some of the `ServiceUtils` functions could arguably go into `ContextUtils` instead, but I thought that this was fine since they are fairly specific to this use case. * Further modifications will need to be made to support multiple priorities. This patch is enough to get everything up and running for testing, with further prioritization work being done in bug 1620145. Differential Revision: https://phabricator.services.mozilla.com/D65636
908488937ad8462eb985ff73164772f687c4640b: Bug 1608301: Part 2 - Add an additional assertion type to XPCOMEventTarget and change them to throw AssertionErrors; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Tue, 10 Mar 2020 16:31:42 +0000 - rev 517896
Push 109684 by aklotz@mozilla.com at Tue, 10 Mar 2020 16:43:34 +0000
Bug 1608301: Part 2 - Add an additional assertion type to XPCOMEventTarget and change them to throw AssertionErrors; r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D65635
bb0a96b414fc4a32ac76fcdf85d5c975a8ddafcc: Bug 1608301: Part 1 - Add an overload to ContextUtils.getCurrentPackageInfo that accepts flags; r=geckoview-reviewers,snorp
Aaron Klotz <aklotz@mozilla.com> - Tue, 10 Mar 2020 16:31:45 +0000 - rev 517895
Push 109684 by aklotz@mozilla.com at Tue, 10 Mar 2020 16:43:34 +0000
Bug 1608301: Part 1 - Add an overload to ContextUtils.getCurrentPackageInfo that accepts flags; r=geckoview-reviewers,snorp Differential Revision: https://phabricator.services.mozilla.com/D65634
677e514c582547c77df392d7e2e83c26ae742334: Bug 1620923 - Avoid using `six` since it is not installed everywhere r=lth
Steve Fink <sfink@mozilla.com> - Tue, 10 Mar 2020 07:38:09 +0000 - rev 517894
Push 109683 by sfink@mozilla.com at Tue, 10 Mar 2020 16:41:42 +0000
Bug 1620923 - Avoid using `six` since it is not installed everywhere r=lth This will eagerly generate all of the manifests and hold them all at once in memory, but only for Python 2. If that causes problems, we should complete the port to Python 3. Differential Revision: https://phabricator.services.mozilla.com/D66090
ecc0db42db9cfe23698c0e2f726bd9bd4b409ea5: Bug 1537761 - P2 Add an IPC message for AltSvcMapping::ProcessHeader r=dragana
Kershaw Chang <kershaw@mozilla.com> - Tue, 10 Mar 2020 16:28:49 +0000 - rev 517893
Push 109682 by kjang@mozilla.com at Tue, 10 Mar 2020 16:41:09 +0000
Bug 1537761 - P2 Add an IPC message for AltSvcMapping::ProcessHeader r=dragana Differential Revision: https://phabricator.services.mozilla.com/D65553
457118de807cdddbcccba8294e988427ae3a1934: Bug 1537761 - P1: Send an IPC message for ClearHostMapping() r=dragana
Kershaw Chang <kershaw@mozilla.com> - Tue, 10 Mar 2020 16:28:47 +0000 - rev 517892
Push 109682 by kjang@mozilla.com at Tue, 10 Mar 2020 16:41:09 +0000
Bug 1537761 - P1: Send an IPC message for ClearHostMapping() r=dragana Differential Revision: https://phabricator.services.mozilla.com/D65552
91c04bc7ec999933cecded74bf323f3a4e7d16c5: Bug 745494 - Add a crashtest based on the test case for the bug
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 10 Mar 2020 16:28:57 +0000 - rev 517891
Push 109681 by eakhgari@mozilla.com at Tue, 10 Mar 2020 16:39:51 +0000
Bug 745494 - Add a crashtest based on the test case for the bug Differential Revision: https://phabricator.services.mozilla.com/D66254
a7a6063bd5a4b49911b5a956c252a16961aec5a0: Bug 1621323 - Disable an OOMing test for TSan and fix TSan OOM options. r=froydnj
Christian Holler <choller@mozilla.com> - Tue, 10 Mar 2020 16:22:25 +0000 - rev 517890
Push 109680 by choller@mozilla.com at Tue, 10 Mar 2020 16:39:17 +0000
Bug 1621323 - Disable an OOMing test for TSan and fix TSan OOM options. r=froydnj Differential Revision: https://phabricator.services.mozilla.com/D66252
751127cc9b0e4f0d192113363ff7e237e00dd46b: Bug 1621193 - Fix linting opt failure on jit_test.py CLOSED TREE
Bogdan Tara <btara@mozilla.com> - Tue, 10 Mar 2020 18:35:58 +0200 - rev 517889
Push 109679 by btara@mozilla.com at Tue, 10 Mar 2020 16:36:44 +0000
Bug 1621193 - Fix linting opt failure on jit_test.py CLOSED TREE DONTBUILD
64e293f463e62953ca435caff047fd7fe3c35f1d: Backed out 6 changesets (bug 1608302, bug 1608301) for linting failure on GeckoProcessManager.java.
Cosmin Sabou <csabou@mozilla.com> - Tue, 10 Mar 2020 18:24:56 +0200 - rev 517888
Push 109678 by csabou@mozilla.com at Tue, 10 Mar 2020 16:28:02 +0000
Backed out 6 changesets (bug 1608302, bug 1608301) for linting failure on GeckoProcessManager.java. CLOSED TREE Backed out changeset 5a78c81ddaa7 (bug 1608302) Backed out changeset 81b75065d43d (bug 1608302) Backed out changeset e75565cd4103 (bug 1608302) Backed out changeset dba5330a46dc (bug 1608301) Backed out changeset 7b9e2ba30ff2 (bug 1608301) Backed out changeset 3a2342e9440f (bug 1608301)
ae479330cecdab590481764d6673a6afb1f8c889: Bug 1621193 - py3: raw_input r=tcampbell
Steve Fink <sfink@mozilla.com> - Tue, 10 Mar 2020 16:17:35 +0000 - rev 517887
Push 109677 by sfink@mozilla.com at Tue, 10 Mar 2020 16:20:30 +0000
Bug 1621193 - py3: raw_input r=tcampbell Differential Revision: https://phabricator.services.mozilla.com/D66171
fb05448f7b8999ed72cbde399fc12d3ff64e888c: Bug 1621126 - Bump toolkit.shutdown.fastShutdownStage to 2 r=froydnj
Doug Thayer <dothayer@mozilla.com> - Tue, 10 Mar 2020 13:47:30 +0000 - rev 517886
Push 109676 by dothayer@mozilla.com at Tue, 10 Mar 2020 16:14:01 +0000
Bug 1621126 - Bump toolkit.shutdown.fastShutdownStage to 2 r=froydnj The telemetry for this window of time on Nightly is clean, so this should be safe to bump up. Differential Revision: https://phabricator.services.mozilla.com/D66173
7c4cd68156c184cad9e26d7f6e2e548b4950362f: Bug 865004 - Add a crashtest based on the test case for the bug
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 10 Mar 2020 16:03:13 +0000 - rev 517885
Push 109675 by eakhgari@mozilla.com at Tue, 10 Mar 2020 16:11:35 +0000
Bug 865004 - Add a crashtest based on the test case for the bug Differential Revision: https://phabricator.services.mozilla.com/D66251
177bc361cbbefebf9e2be31b6326a1411eb301d5: Bug 1621170 - Disable capping the maximum life-time of client-side cookies to seven days on Nightly; r=baku
Ehsan Akhgari <ehsan@mozilla.com> - Tue, 10 Mar 2020 15:12:59 +0000 - rev 517884
Push 109674 by eakhgari@mozilla.com at Tue, 10 Mar 2020 16:10:30 +0000
Bug 1621170 - Disable capping the maximum life-time of client-side cookies to seven days on Nightly; r=baku Differential Revision: https://phabricator.services.mozilla.com/D66147
414e532db23fdcfcf789292c0a2852005dccd198: No bug: [mozhanress] Remove unused `TransferMixin.scp_upload_directory` method; r=aki
Tom Prince <mozilla@hocat.ca> - Sat, 07 Mar 2020 02:38:47 +0000 - rev 517883
Push 109673 by mozilla@hocat.ca at Tue, 10 Mar 2020 16:09:27 +0000
No bug: [mozhanress] Remove unused `TransferMixin.scp_upload_directory` method; r=aki Differential Revision: https://phabricator.services.mozilla.com/D65843
2381c9be235c6132e3e1ab6536b32728850bb817: No bug: [mozharness] Remove unused TryToolsMixin from FxDesktopBuild; r=aki
Tom Prince <mozilla@hocat.ca> - Sat, 07 Mar 2020 02:42:56 +0000 - rev 517882
Push 109673 by mozilla@hocat.ca at Tue, 10 Mar 2020 16:09:27 +0000
No bug: [mozharness] Remove unused TryToolsMixin from FxDesktopBuild; r=aki Before Bug 1530908, the build script used `TryToolsMixin.try_message_has_flag` to dectect a request for artifact builds. Since that is no longer used, we can remove the dependency. Differential Revision: https://phabricator.services.mozilla.com/D65842
d7e7ddf3f8ba94b5225139444da49d5abb892130: Bug 1620669 - Separate CONTAINS_REMOTE_SUBFRAMES to its own label in BFCACHE_COMBO telemetry r=nika
Sean Feng <sefeng@mozilla.com> - Tue, 10 Mar 2020 15:39:34 +0000 - rev 517881
Push 109672 by sefeng@mozilla.com at Tue, 10 Mar 2020 16:08:14 +0000
Bug 1620669 - Separate CONTAINS_REMOTE_SUBFRAMES to its own label in BFCACHE_COMBO telemetry r=nika Differential Revision: https://phabricator.services.mozilla.com/D65792
a90d78dc683c057cd83cf95b003be53d1a5505cb: Bug 1614760 - Add telemetryInfo to Addon Install object. r=rpl
Agi Sferro <agi@sferro.dev> - Tue, 10 Mar 2020 15:24:50 +0000 - rev 517880
Push 109671 by asferro@mozilla.com at Tue, 10 Mar 2020 16:07:08 +0000
Bug 1614760 - Add telemetryInfo to Addon Install object. r=rpl Differential Revision: https://phabricator.services.mozilla.com/D66093
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip