f33cb032cc9f1f01b22f6663c1553a6e481e7f59: Bug 1288329: [ogg] P6. Enable new OggDemuxer by default. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 28 Jul 2016 21:24:24 +1000 - rev 307251
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg] P6. Enable new OggDemuxer by default. r=gerald Now passes all media mochitests. MozReview-Commit-ID: 85aVXrrRSWW
49ea83d00a77850710c8c57f408a080dc1557741: Bug 1288329: [ogg] P5. Adjust mochitests. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 28 Jul 2016 22:52:08 +1000 - rev 307250
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg] P5. Adjust mochitests. r=gerald There are various differences between the new ogg player and the old OggReader that leads to inconsistencies on how durations are reported. 1- The old OggReader only use the end time as duration of the video, ignoring the start time of the first sample. This leads to incorrect duration calculation. 2- The OggReader do not ignore undecodable frames located at the beginning of the video, and those are used by the MDSM to calculate the start time. This leads to durations sometimes being shorter than they ought to. MozReview-Commit-ID: 6yi1P4N6tPE
1406c14098f1fa36e557ffc5233991639342eeab: Bug 1288329: [ogg] P4. Fix coding style. r=gerald,jwwang
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 29 Jul 2016 10:47:03 +1000 - rev 307249
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg] P4. Fix coding style. r=gerald,jwwang MozReview-Commit-ID: 1bAE92BECRD
936b73eb37c6469fe8b31bf14965a5f04e25b740: Bug 1288329: [ogg] P3. Never take into considerations frames prior the first keyframe. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 29 Jul 2016 10:38:36 +1000 - rev 307248
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg] P3. Never take into considerations frames prior the first keyframe. r=gerald MozReview-Commit-ID: 1aJSbJb9kQW
a1c4d9b9de328a0ebb68c9540f473b43bedbb22c: Bug 1288329: [ogg/vorbis] P2. Pass extra information to the decoder so that it can perform proper trimmer. r=gerald,jwwang
Jean-Yves Avenard <jyavenard@mozilla.com> - Fri, 29 Jul 2016 02:19:21 +1000 - rev 307247
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg/vorbis] P2. Pass extra information to the decoder so that it can perform proper trimmer. r=gerald,jwwang The OggReader always passed a complete ogg_packet to the vorbis decoder, ensuring that the right number of frames was be returned. In the conversion to the new architecture, this information got lost making the vorbis decoder always return more frames than normal on the last packet. MozReview-Commit-ID: HYHxqXfYntJ
a76b6e5597772de7c8cb9d1a68fee0477a907f0b: Bug 1288329: [ogg] P1. Add support for metadata chaining in OggDemuxer. r=gerald,jwwang
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 28 Jul 2016 15:32:11 +1000 - rev 307246
Push 30926 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:47:49 +0000
Bug 1288329: [ogg] P1. Add support for metadata chaining in OggDemuxer. r=gerald,jwwang This is not the cleanest approach, but ensures identical behavior with the OggReader when it comes to firing loadedmetadata event and handling the change of seekability. A more universal solution could be considered involving the MediaFormatReader and changing the MediaDataDemuxer API, of interest would be adding support for a new event fired whenever we have a change of content or metadata (useful with MSE or recorded webm of a WebRTC session MozReview-Commit-ID: BojB2r1CtA3
9fac9a76954f66b448ee8787b90ec1370ffe4cd3: Bug 1289438: [ogg] P5. Don't seek back to first buffered position during reset. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 17:57:22 +1000 - rev 307245
Push 30925 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:45:49 +0000
Bug 1289438: [ogg] P5. Don't seek back to first buffered position during reset. r=gerald A call to reset is always followed by a call to Seek; seeking is an heavy operation with ogg so let's minimize the number of times we are actually seeking. MozReview-Commit-ID: Jz7dL9IFM14
9852c16d65e4b9ee4027745babac8ff15be79d6c: Bug 1289438: [ogg] P4. Use SaferMultDiv where appropriate. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 17:17:21 +1000 - rev 307244
Push 30925 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:45:49 +0000
Bug 1289438: [ogg] P4. Use SaferMultDiv where appropriate. r=gerald MozReview-Commit-ID: 3AWTGciNj4D
0f13ecf177c65ee9438b3c32d3a064cde5b29f1e: Bug 1289438: [ogg] P3 Fix code style. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 17:01:27 +1000 - rev 307243
Push 30925 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:45:49 +0000
Bug 1289438: [ogg] P3 Fix code style. r=gerald MozReview-Commit-ID: K6qpPVgsIi7
2f6157213da23a19e508bbe2da299e540cb3e54d: Bug 1289438: [ogg] P2. Re-enable earlier test now the seeking behaves as expected. r=cpearce,gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 16:21:47 +1000 - rev 307242
Push 30925 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:45:49 +0000
Bug 1289438: [ogg] P2. Re-enable earlier test now the seeking behaves as expected. r=cpearce,gerald Note that the closest keyframes are for video 0.666667 and audio 0.645805, however the current OggReader still incorrectly seeks audio to an earlier time as it seek to the index page boundary. MozReview-Commit-ID: 5g7FHFmRQXD
1e645059025f3e7aace65f496984a095c9858aa7: Bug 1289438: [ogg] P1. Always seek to the closest keyframe. r=brion+1012
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 16:19:03 +1000 - rev 307241
Push 30925 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:45:49 +0000
Bug 1289438: [ogg] P1. Always seek to the closest keyframe. r=brion+1012 MozReview-Commit-ID: 1IGFgU1GFz5
60d5223a8d886cb7b1ff1e6d57ee1817212cf5ee: Bug 1288331: [ogg] P2. Fix fast seek mochitest. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 00:12:28 +1000 - rev 307240
Push 30924 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:43:55 +0000
Bug 1288331: [ogg] P2. Fix fast seek mochitest. r=cpearce Fast seek in the old OggReader is broken: the audio track isn't seeked to the video track in order to preserve A/V sync and we end up always performing an accurate seek which explain why this test succeeded before. The page index is only made of two entries, and so the first video frame returned after a seek, if within the first index will always have a time of 0. MozReview-Commit-ID: 2EYzLMWRZAi
c249b34465a9194d2a9c70d7e2acf3b567b2b13b: Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. r=brion+1012
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Jul 2016 23:03:36 +1000 - rev 307239
Push 30924 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:43:55 +0000
Bug 1288331: [ogg] P1. Seek audio track and video track independently from one another. r=brion+1012 MozReview-Commit-ID: 3ZOuzLNbPiq Bug 1288331: [ogg] P1 amend MozReview-Commit-ID: BoeDuGziBX5
39bc955ad2fa5b1a230270f8cbfdfb018fe43b59: Bug 1289059: P1. Add MediaDemuxer generic logging. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Sun, 24 Jul 2016 22:30:07 +1000 - rev 307238
Push 30923 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:42:25 +0000
Bug 1289059: P1. Add MediaDemuxer generic logging. r=cpearce MozReview-Commit-ID: 453QrMX1nWp
70cda19d2159974d13842a905b42ca5f973267ca: Bug 1168674: [ogg] P8. Fix metadata retrieval. r=brion+1012
Jean-Yves Avenard <jyavenard@mozilla.com> - Wed, 27 Jul 2016 12:22:31 +1000 - rev 307237
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [ogg] P8. Fix metadata retrieval. r=brion+1012 MozReview-Commit-ID: BMUNy4zyWMz
435bf9dd44f33169ca3111608b1d43aacdd92496: Bug 1168674: [ogg] P7. Properly mark overridden methods. r=gerald
Jean-Yves Avenard <jyavenard@mozilla.com> - Tue, 26 Jul 2016 16:39:44 +1000 - rev 307236
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [ogg] P7. Properly mark overridden methods. r=gerald MozReview-Commit-ID: 5aICN1aQwgC
864104ba08a648137660176cca3618ec183c31e8: Bug 1168674: [vorbis] P6. Do not tweak first decoded sample time. r=cpearce
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 25 Jul 2016 19:14:39 +1000 - rev 307235
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [vorbis] P6. Do not tweak first decoded sample time. r=cpearce r?cpearce A hack was in place to ensure that the first returned sample would have a time of 0 so that the media start time would be 0. This was incorrect for two primary reasons: - The media start time is adjusted according to the first sample anyway. - When seeking to 0, the first sample would have a time different to the first sample decoded (when we want them to have the same time). MozReview-Commit-ID: IyuT9O2F4EZ
3db6ca9dc9cd2801fb77225a169984259a5a422d: Bug 1168674: [ogg] P5. Use common demuxing methods. r=brion+1012
Jean-Yves Avenard <jyavenard@mozilla.com> - Mon, 25 Jul 2016 19:06:20 +1000 - rev 307234
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [ogg] P5. Use common demuxing methods. r=brion+1012 This ensure that the first sample demuxed will be identical to the first one demuxed following a seek to the beginning. Also, only demux the next packet when none is queued rather than all the time. MozReview-Commit-ID: 5wtFVLiCAW
0152356f027f2be2cef08e97082ef21075f8428f: Bug 1168674: [ogg] P4. Skip over header packets when seeking close to the start. r=brion+1012
Jean-Yves Avenard <jyavenard@mozilla.com> - Thu, 21 Jul 2016 17:56:01 +1000 - rev 307233
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [ogg] P4. Skip over header packets when seeking close to the start. r=brion+1012 MozReview-Commit-ID: F0Ezo0yfOyo
06bab9aac05e886c511e5bf799725f6d3c639d19: Bug 1168674: [ogg] P3. Add theora MediaDataDecoder. r=me
Brion Vibber <brion@pobox.com> - Thu, 21 Jul 2016 11:36:47 +1000 - rev 307232
Push 30922 by jyavenard@mozilla.com at Fri, 29 Jul 2016 16:41:01 +0000
Bug 1168674: [ogg] P3. Add theora MediaDataDecoder. r=me MozReview-Commit-ID: 7ZJD21JMXBY
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip