ecfb960dc1097ab0e34b4c83caebc9c88c03c03f: Bug 1363085 - Part 1. Update license for react-intl usage in activity-stream. r=gerv
Ed Lee <edilee@mozilla.com> - Tue, 09 May 2017 10:42:22 -0700 - rev 357864
Push 42527 by edilee@gmail.com at Thu, 11 May 2017 21:19:44 +0000
Bug 1363085 - Part 1. Update license for react-intl usage in activity-stream. r=gerv MozReview-Commit-ID: Ec5pNkDlUX2
385067a8df33c105a085db31c52d7a68f519f804: servo: Merge #16816 - Fix unsafe casting between PersistentLayoutData and PartialPersistentLayoutData (from MortimerGoro:unsafe_layout_data_cast); r=SimonSapin
Imanol Fernandez <mortimergoro@gmail.com> - Thu, 11 May 2017 14:47:24 -0500 - rev 357863
Push 42526 by servo-vcs-sync@mozilla.com at Thu, 11 May 2017 21:10:54 +0000
servo: Merge #16816 - Fix unsafe casting between PersistentLayoutData and PartialPersistentLayoutData (from MortimerGoro:unsafe_layout_data_cast); r=SimonSapin <!-- Please describe your changes on the following line: --> PersistentLayoutData and PartialPersistentLayoutData castings in Layout component assume that they have the same base raw address. This is unsafe because field orders is not guaranteed by default, and it's causing some SEGV crashes on Android indeed (https://github.com/servo/servo/issues/16647) Add a C representation to guarantee that the order of the fields and the safe casting. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #16647 (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: c277beab2b9c3294ea69c6088cd0dc3b1665717e
ccd0ac82b8bd099388926c642f03313a2826f023: Bug 1147271 - Add ssh option to prevent hanging on password prompt in upload.py r=mshal
Chris Manchester <cmanchester@mozilla.com> - Thu, 11 May 2017 09:40:58 -0700 - rev 357862
Push 42525 by cmanchester@mozilla.com at Thu, 11 May 2017 21:04:46 +0000
Bug 1147271 - Add ssh option to prevent hanging on password prompt in upload.py r=mshal MozReview-Commit-ID: Lmg5SAtLuE3
1e6c8eee951e9e61502f96694ddfb2602d933cb8: Bug 1354127 - Add a 'More' toolbar button to the Photon app menu. r=Gijs
Mike de Boer <mdeboer@mozilla.com> - Thu, 11 May 2017 16:23:16 -0400 - rev 357861
Push 42524 by mdeboer@mozilla.com at Thu, 11 May 2017 20:30:50 +0000
Bug 1354127 - Add a 'More' toolbar button to the Photon app menu. r=Gijs This also improves the styling of checkbox buttons inside the menu and improves support for adopting panelviews into the app menu from another area properly. MozReview-Commit-ID: 1I9CeBx3zrz
75ed70ff9b76cef90a883fa16754cb9f8e56bebb: Bug 1348103 - Fix test_chrome_bookmarks.js error when collecting code coverage on linux64-jsdcov. r=Gijs
Greg Mierzwinski <gmierz2@outlook.com> - Sat, 29 Apr 2017 10:47:24 -0400 - rev 357860
Push 42523 by kwierso@gmail.com at Thu, 11 May 2017 20:26:22 +0000
Bug 1348103 - Fix test_chrome_bookmarks.js error when collecting code coverage on linux64-jsdcov. r=Gijs This patch first adds an argument to the 'do_get_file(...)' function call in 'test_chrome_bookmarks.js' that simply allows the 'chromefiles' folder to be non-existent if it does not exist. The 'CoverageUtils.jsm' file is then modified so that the import of 'osfile.jsm' does not interfere with any tests. So, it is now imported into the script after the test has completed. Two other tests have unwanted behaviour that cause code coverage collection to fail so they are also skipped through this patch. MozReview-Commit-ID: H42HN1solkh
6ceba506b62a0ad3f92a4c35e178684bfdc77667: Bug 1364063 - Stop setting development preferences from DevTools add-on. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Thu, 11 May 2017 15:02:41 +0200 - rev 357859
Push 42522 by apoirot@mozilla.com at Thu, 11 May 2017 20:09:50 +0000
Bug 1364063 - Stop setting development preferences from DevTools add-on. r=jdescottes MozReview-Commit-ID: J4I5SSkErxE
20977f40cc829607928776e8e7f6509bf5bf34c8: Bug 1363419 - Unregister DevTools on Add-on disabling. r=jdescottes
Alexandre Poirot <poirot.alex@gmail.com> - Tue, 09 May 2017 18:28:57 +0200 - rev 357858
Push 42521 by apoirot@mozilla.com at Thu, 11 May 2017 20:09:01 +0000
Bug 1363419 - Unregister DevTools on Add-on disabling. r=jdescottes MozReview-Commit-ID: 7ME0xBdjvle
5e04c49d2d10ad48b19cddaf28fee845dc6e8629: Bug 1362164 - Remove mozharness code to print ccache stats; r=ted
Gregory Szorc <gps@mozilla.com> - Thu, 11 May 2017 12:49:09 -0700 - rev 357857
Push 42520 by gszorc@mozilla.com at Thu, 11 May 2017 19:50:57 +0000
Bug 1362164 - Remove mozharness code to print ccache stats; r=ted I was going to inline "enable_ccache" into buildbase.py because AFAICT its value is effectively "if not windows." However, I realized that all this is doing is dumping ccache stats (something the build system itself is in a better position to do because it actually knows if ccache is enabled). Then I realized we don't use ccache directly any more in automation because we use sccache (or at least that's the way it should be). Since there's no need for this ccache code in mozharness, this commit deletes it. If we want it back, we can add the functionality to `mach build`. MozReview-Commit-ID: BrRi1QKe5l3
18afc87e7a68bc5e05a94dfcd4dfec0823692fe8: Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection. r=dao
Drew Willcoxon <adw@mozilla.com> - Thu, 11 May 2017 12:48:28 -0700 - rev 357856
Push 42519 by dwillcoxon@mozilla.com at Thu, 11 May 2017 19:50:12 +0000
Bug 1363407 - Awesome bar results and one-off buttons have different blue shades on keyboard selection. r=dao MozReview-Commit-ID: 3Kb7olur077
c9812dd7d27a174c0ee46d44ec595fbe29c9e1db: Bug 1362148 - Always collect build metrics; r=ted
Gregory Szorc <gps@mozilla.com> - Thu, 04 May 2017 12:28:52 -0700 - rev 357855
Push 42518 by gszorc@mozilla.com at Thu, 11 May 2017 19:48:49 +0000
Bug 1362148 - Always collect build metrics; r=ted Previously, mozharness defined a separate action to collect build metrics. This required the script and/or config to define that action. Metrics collection for CI is important. So it should be enabled by default. This commit changes the "build" action/method to always call the metrics collection function after successful build. References to the "generate-build-stats" action have been removed because it is redundant. A side-effect of this change is we may generate build metrics where we weren't before. This could lead to e.g. duplicate entries in some Perfherder series. Let's see what breaks ;) MozReview-Commit-ID: 42UQI5YQTMC
387d8415d05e7f1dc96ed3adb441c54f232baf0d: Bug 1362148 - Call generate_build_props() as part of build(); r=ted
Gregory Szorc <gps@mozilla.com> - Thu, 04 May 2017 17:24:06 -0700 - rev 357854
Push 42518 by gszorc@mozilla.com at Thu, 11 May 2017 19:48:49 +0000
Bug 1362148 - Call generate_build_props() as part of build(); r=ted Previously, this ran during postflight_build(). The magic postflight_* methods are called automagically by BaseScript.run_action() and are only called if the main action method didn't raise. So there should be no functional difference with this commit. The reason I changed this is that a subsequent commit will perform metrics generation from build() and without the build properties file loaded, at least the OS X 64 opt buildbot build doesn't have packageFilename defines, which breaks metrics collection. MozReview-Commit-ID: 54ftuQqGKVi
266e09e18a8e7ba8e9da62d819985e484f939dcb: Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer
Valentin Gosu <valentin.gosu@gmail.com> - Thu, 11 May 2017 21:35:37 +0200 - rev 357853
Push 42517 by valentin.gosu@gmail.com at Thu, 11 May 2017 19:47:57 +0000
Bug 1363653 - Make AltDataOutputStreamParent not send any messages after object destruction r=mayhemer This patch prevents the following error: AltDataOutputStreamChild::Close -> SendClose() AltDataOutputStreamChild::Release -> Send__delete__() AltDataOutputStreamParent::RecvClose() -> SendError() AltDataOutputStreamParent::ActorDestroy -> mIPCOpen = false AltDataOutputStreamChild::RecvError -> === Crash - object was deleted === We introduce the DeleteSelf message. AltDataOutputStreamChild::Release -> SendDeleteSelf() AltDataOutputStreamParent::RecvDeleteSelf -> mIPCOpen = false; SendDeleteSelf() AltDataOutputStreamChild::RecvDeleteSelf -> Send__delete__() The parent will not send any more messages after receiving the DeleteSelf message. MozReview-Commit-ID: I9RQ5I7eSt9
6a82d640aa274f6532528bd45d9e86ede901f44d: Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:16:58 -0700 - rev 357852
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Don't invoke `mach build` through bash.exe; r=ted Executing `mach build` through bash.exe was introduced by 5f379c98b962 / bug 1279011. Why, I don't know. Literally every other invocation of `mach` in mozharness does it directly or via a Python executable (the latter is necessary on Windows since `mach` is not a win32 executable). So, this commit removes bash.exe and executes `mach` via Python like everyone else. MozReview-Commit-ID: GFNUVbfHZdq
23050ffaf6490bb3d7811d586eb174b3c85fd4d6: Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:10:33 -0700 - rev 357851
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Stop defining python2.7 executable as sys.executable; r=ted The "python2.7" executable is always defined as sys.executable in mozharness configs. This abstraction is not necessary. This commit removes the "python2.7" executable from mozharness configs and just inlines sys.executable instead. MozReview-Commit-ID: 4xiEkoFwekr
402ef9d842a347123d2ba8acf22679272b330f8c: Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted
Gregory Szorc <gps@mozilla.com> - Wed, 03 May 2017 18:04:00 -0700 - rev 357850
Push 42516 by gszorc@mozilla.com at Thu, 11 May 2017 19:45:31 +0000
Bug 1361912 - Resolve mach arguments in mozharness action, not in configs; r=ted Every TaskCluster Windows mozharness config was defining an identical executable entry for "mach-build." For something that's used exactly once and is identical, this is not necessary. This commit moves the login inline into the mozharness Python module. It assumes that if MOZILLABUILD is defined that it points to a MozillaBuild path and we should invoke mach through it using the same mechanism that was defined in the config files. This commit changes behavior on buildbot because it also defines MOZILLABUILD but didn't define "mach-build" before. For whatever reason, TC configs involved bash.exe from their moment of inception (5f379c98b962 / bug 1279011). This commit restores consistency between the environments. I do question whether bash.exe needs to be involved at all. But that's for another commit. MozReview-Commit-ID: I5GXHRJ1Eq0
22e82ca6c1155483303bed7ed67a6cb412a999d2: Backed out changeset fa3f3b08ec2b (bug 1361912) for build bustage. r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:55 +0200 - rev 357849
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset fa3f3b08ec2b (bug 1361912) for build bustage. r=backout on a CLOSED TREE
005a8efca0bae931bced9c18c4ab46aa79c99050: Backed out changeset a7a7eb83f9cb (bug 1361912)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:15 +0200 - rev 357848
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset a7a7eb83f9cb (bug 1361912)
feafde9d5fcab8f690df2fd3be43113db0bce628: Backed out changeset ca3dddda32b0 (bug 1361912)
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:40:11 +0200 - rev 357847
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset ca3dddda32b0 (bug 1361912)
19aa5a4ceb3c739f460179913bd6309773f1f4e7: Backed out changeset 508966268fab (bug 1362364) for unused variable at toolkit/mozapps/extensions/test/addons/test_cache_certdb/bootstrap.js:74 (linting failure). r=backout on a CLOSED TREE
Sebastian Hengst <archaeopteryx@coole-files.de> - Thu, 11 May 2017 21:39:48 +0200 - rev 357846
Push 42515 by archaeopteryx@coole-files.de at Thu, 11 May 2017 19:41:08 +0000
Backed out changeset 508966268fab (bug 1362364) for unused variable at toolkit/mozapps/extensions/test/addons/test_cache_certdb/bootstrap.js:74 (linting failure). r=backout on a CLOSED TREE
c79085f94c572c014be098398450caec68049140: servo: Merge #16807 - Fix clamping of scroll position in window.scrollBy (from mrobinson:scroll-clamping); r=emilio
Martin Robinson <mrobinson@igalia.com> - Thu, 11 May 2017 13:23:39 -0500 - rev 357845
Push 42514 by servo-vcs-sync@mozilla.com at Thu, 11 May 2017 19:27:08 +0000
servo: Merge #16807 - Fix clamping of scroll position in window.scrollBy (from mrobinson:scroll-clamping); r=emilio For rightward and downward overflow the spec says: Let x be max(0, min(x, viewport scrolling area width - viewport width)). Let y be max(0, min(y, viewport scrolling area height - viewport height)). Previously, those operations were reversed, which created negative overflow even when the overflow direction was downward. This change ensures that Servo matches spec behavior. <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [x] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: e196776c2477f5f204ce1333bd15070afbf9a7f6
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 +30000 +100000 tip