ea48a906643001a4bfa83bb82b12c67c19a5f4b2: Bug 1567438 part 3 - Don't skip JSOP_LOOPENTRY ops for prologue bailouts. r=tcampbell,iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 30 Jul 2019 12:09:18 +0000 - rev 485365
Push 91261 by jdemooij@mozilla.com at Tue, 30 Jul 2019 15:32:31 +0000
Bug 1567438 part 3 - Don't skip JSOP_LOOPENTRY ops for prologue bailouts. r=tcampbell,iain The old code happened to work but didn't really make sense and I ran into some assertion failures with other changes. Later patches will clean this up more. Differential Revision: https://phabricator.services.mozilla.com/D38862
ff457522f563972d7cc6de9e914ed8ebfd3ef4bb: Bug 1567438 part 2 - Clean up environment chain and prologue bailout handling. r=tcampbell,iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 30 Jul 2019 12:09:02 +0000 - rev 485364
Push 91261 by jdemooij@mozilla.com at Tue, 30 Jul 2019 15:32:31 +0000
Bug 1567438 part 2 - Clean up environment chain and prologue bailout handling. r=tcampbell,iain We now always set the frame's environment chain to a non-null value and have an explicit isPrologueBailout flag instead of relying on envChain == nullptr. Differential Revision: https://phabricator.services.mozilla.com/D38861
58ea17fc315ef8bc3a325a958953a50e047f4499: Bug 1567438 part 1 - Replace the enter-monitor-chain bailout code with type monitoring in C++. r=tcampbell,iain
Jan de Mooij <jdemooij@mozilla.com> - Tue, 30 Jul 2019 12:08:48 +0000 - rev 485363
Push 91261 by jdemooij@mozilla.com at Tue, 30 Jul 2019 15:32:31 +0000
Bug 1567438 part 1 - Replace the enter-monitor-chain bailout code with type monitoring in C++. r=tcampbell,iain When we resumeAfter a JOF_TYPESET op, we had code to enter the type monitor chain for the bailing op, passing it the top stack value. It's simpler to do this monitoring in C++ in FinishBailoutToBaseline and then treat it as a regular resumeAfter bailout. The code for this will be simplified more later in the stack. Differential Revision: https://phabricator.services.mozilla.com/D38860
cd58aae7d47bede2f5699c07855676fa6fc26a09: Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:39 +0000 - rev 485362
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Disable unconditional clamping for two CSS tests r=birtles We're hitting double imprecision here. Example: Given 86.68392200000000 and 86.67999999999999 we want to see if they're equal with two significant digits. (They are, they're 86.68) However, when we reduce them, 86.68 (which is represented as an epislon lower) gets reduced to 86.66 and they no longer match. We disable unconditional clamping on these tests to confirm they behave the way they shoud... excepting the clamping which may introduce imprecision. Differential Revision: https://phabricator.services.mozilla.com/D38812
a51919fb20625ab42f4c442a5a87b41bffe081e8: Bug 1387894 - Remove expected failure from Event-timestamp-safe-resolution.html r=smaug
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:30 +0000 - rev 485361
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Remove expected failure from Event-timestamp-safe-resolution.html r=smaug Hey, we fixed it! Differential Revision: https://phabricator.services.mozilla.com/D38811
ef7b589d751b8fd2882d2740439395010715fd4f: Bug 1387894 - Fix animation WPTs r=birtles,jgraham
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:17 +0000 - rev 485360
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix animation WPTs r=birtles,jgraham I believe these intermittents are caused by double imprecision. When unconditional clamping is enabled it gets multiplied out and causes animation.currentTime to occasionally go to 50000.02 which causes the test to fail. We can reduce the precision back down to ignore that. We do so using some WPT overrides. Differential Revision: https://phabricator.services.mozilla.com/D38810
75c0249b594a371d250dca81d1f3c60aaad944a3: Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:12:08 +0000 - rev 485359
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix browser_animation_setCurrentTime.js for unconditional clamping r=birtles This has to do with double imprecision. The test originally had toPrecision(6) to account for this imprecision. It'd round up 499.9999 into 500. When we send double(500) (which is an epsilon below 500) into ReduceTimePrecision we wind up coming out with 499.98. By reducing our precision requirement in this test we can handle that and round 499.98 back up to 500 Differential Revision: https://phabricator.services.mozilla.com/D38809
4a75f2556242a972fd49c0ef447df7f26de7344e: Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:59 +0000 - rev 485358
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894, 1476950 - Fix test_restyles.html for unconditional clamping r=birtles,hiro This refactors things to run until the animation is unthrottled. It confirms the proper amount of time has passed; and then awaits another styling to ensure that markers.length = 0 (unless it took very long (over 200ms) that it should be 1. Differential Revision: https://phabricator.services.mozilla.com/D38808
0bff9ba4237cec4f0fc3a66a6f60a1b588b4ce85: Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:50 +0000 - rev 485357
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Fix the WPT and mochitest test_document-timeline.html for unconditional clamping r=birtles We fix this by clamping the requestAnimationFrame timestamp in the test before comparing it. We don't clamp the requestAnimationFrame timestamp normally because it would be meaningless: rAF fires on a regular frequency and someone perfoming a fine-grained timing attack will be able to determine the timestamp from when it fires. We need to use parseFloat to knock off any extra epislon we gain. This shouldn't cause any major blow-ups because timelines are disabled in release and beta, so at least any potential fallout would be constrained. Differential Revision: https://phabricator.services.mozilla.com/D38807
80040c0a275e4566af2eac53a8dcb02c97dd2b08: Bug 1387894 - Resolve timer intermittents when reduceTimerPrecision is disabled r=smaug
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:41 +0000 - rev 485356
Push 91260 by apavel@mozilla.com at Tue, 30 Jul 2019 15:30:44 +0000
Bug 1387894 - Resolve timer intermittents when reduceTimerPrecision is disabled r=smaug We unconditionally clamp all times to 20us and not just performance.now() This will consistently apply a 'safe' minimal clamping (it's not safe but I guess it's safer than ns-level precision) to all timestamps, and remove intermittents that are caused by comparing a clamped performance.now() to an unclamped [something else]. Differential Revision: https://phabricator.services.mozilla.com/D38806
02814f69872dcf15075001030aadbc1a01690712: Bug 1387894 - Move all Resist Fingerprinting/Reduce Time Precision prefs to StaticPrefs r=smaug
Tom Ritter <tom@mozilla.com> - Tue, 30 Jul 2019 15:11:32 +0000 - rev 485355
Push 91259 by apavel@mozilla.com at Tue, 30 Jul 2019 15:29:45 +0000
Bug 1387894 - Move all Resist Fingerprinting/Reduce Time Precision prefs to StaticPrefs r=smaug Differential Revision: https://phabricator.services.mozilla.com/D39212
4235d3b061468d1844bfadb22940d2f4777ffdf0: Bug 1569472 - Level Down the Error level to 2. r=ahal
championshuttler <shivams2799@gmail.com> - Tue, 30 Jul 2019 15:20:00 +0000 - rev 485354
Push 91258 by ahalberstadt@mozilla.com at Tue, 30 Jul 2019 15:24:08 +0000
Bug 1569472 - Level Down the Error level to 2. r=ahal Differential Revision: https://phabricator.services.mozilla.com/D39663
61157622d36667b5d521af1949decdf847f270be: Bug 1569472 - Fix taskcluster docs linting errors. r=ahal
championshuttler <shivams2799@gmail.com> - Tue, 30 Jul 2019 15:20:00 +0000 - rev 485353
Push 91258 by ahalberstadt@mozilla.com at Tue, 30 Jul 2019 15:24:08 +0000
Bug 1569472 - Fix taskcluster docs linting errors. r=ahal Differential Revision: https://phabricator.services.mozilla.com/D39627
95fde01bad79fe96a80b6077b077a0472d1a642d: Bug 1563750 - Add individual subcategory Enabled/Disabled headers in about:addons. r=fluent-reviewers,mstriemer,Pike
Neil Bleasdale <bleasdale.n@gmail.com> - Tue, 30 Jul 2019 15:11:28 +0000 - rev 485352
Push 91257 by mstriemer@mozilla.com at Tue, 30 Jul 2019 15:12:37 +0000
Bug 1563750 - Add individual subcategory Enabled/Disabled headers in about:addons. r=fluent-reviewers,mstriemer,Pike Add separate subcategory headers for Enabled/Disabled to about:addons. Differential Revision: https://phabricator.services.mozilla.com/D38680
04a64d6707ea9d7b1124b4692d8fd8e0f4cfa5f9: Bug 1567230 - Require master password auth before copying or revealing passwords in about:logins. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 30 Jul 2019 15:03:30 +0000 - rev 485351
Push 91256 by jwein@mozilla.com at Tue, 30 Jul 2019 15:09:24 +0000
Bug 1567230 - Require master password auth before copying or revealing passwords in about:logins. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D38587
1f122ed713cbace26246c620af6dbceb09ecec73: Bug 1567230 - Move copying of login detail to AboutLoginsChild.jsm to workaround limitations in the Clipboard API. r=MattN
Jared Wein <jwein@mozilla.com> - Tue, 30 Jul 2019 15:03:23 +0000 - rev 485350
Push 91256 by jwein@mozilla.com at Tue, 30 Jul 2019 15:09:24 +0000
Bug 1567230 - Move copying of login detail to AboutLoginsChild.jsm to workaround limitations in the Clipboard API. r=MattN Differential Revision: https://phabricator.services.mozilla.com/D39131
40c9b3841232a06d5989b6c9ae4136295be69fb8: Bug 1561654 - Add contentPolicyType to DownloadCore to enable sending cookies r=mak,baku,robwu
Tomislav Jovanovic <tomica@gmail.com> - Tue, 30 Jul 2019 15:04:23 +0000 - rev 485349
Push 91255 by tomica@gmail.com at Tue, 30 Jul 2019 15:05:51 +0000
Bug 1561654 - Add contentPolicyType to DownloadCore to enable sending cookies r=mak,baku,robwu Also stop opting-out Downloads tests from real behavior. Differential Revision: https://phabricator.services.mozilla.com/D39571
3c4a84ec8b3a6d8185a57cdeaa68e45c0af87a31: Bug 1565515 - Removed duplication between LengthOfEncodedBinary and CalcDecodedStringySize r=ttung,asuth
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 30 Jul 2019 14:52:18 +0000 - rev 485348
Push 91254 by apavel@mozilla.com at Tue, 30 Jul 2019 15:03:35 +0000
Bug 1565515 - Removed duplication between LengthOfEncodedBinary and CalcDecodedStringySize r=ttung,asuth Differential Revision: https://phabricator.services.mozilla.com/D38173
85fbe010629248586ad6a5197bcbc471324315cb: Bug 1565515 - Define and use type aliases EncodedDataType r=ttung,asuth
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 30 Jul 2019 14:52:04 +0000 - rev 485347
Push 91254 by apavel@mozilla.com at Tue, 30 Jul 2019 15:03:35 +0000
Bug 1565515 - Define and use type aliases EncodedDataType r=ttung,asuth Differential Revision: https://phabricator.services.mozilla.com/D38172
2aef1859366b8c4ff225bcc90f9c16c396cf5b94: Bug 1565515 - Reduced code duplication in DecodeString/DecodeBinary r=ttung,asuth
Simon Giesecke <sgiesecke@mozilla.com> - Tue, 30 Jul 2019 14:51:40 +0000 - rev 485346
Push 91254 by apavel@mozilla.com at Tue, 30 Jul 2019 15:03:35 +0000
Bug 1565515 - Reduced code duplication in DecodeString/DecodeBinary r=ttung,asuth EncodeString and EncodeBinary already use a common backend EncodeAsString, the same should be done in decoding, as the encoding of a binary is a special case of the encoding of a string. Differential Revision: https://phabricator.services.mozilla.com/D38076
(0) -300000 -100000 -30000 -10000 -3000 -1000 -300 -100 -50 -20 +20 +50 +100 +300 +1000 +3000 +10000 tip